> -----Original Message-----
> From: Olivier Matz [mailto:olivier.m...@6wind.com]
> Sent: Monday, April 24, 2017 8:34 PM
> To: dev@dpdk.org; Wu, Jingjing <jingjing...@intel.com>
> Cc: Richardson, Bruce <bruce.richard...@intel.com>; sta...@dpdk.org
> Subject: [PATCH 2/2] app/testpmd: fix number of mbufs in pool
>
> The number of mbufs in pools is not consistent depending on the options passed
> by the user and the number of ports, especially in numa mode, when the number
> of mbuf is specified by the user.
>
> When the user specifies the number of mbuf (per pool), it should overrides the
> default value.
>
> - before the patch
>
> ./build/app/testpmd -- -i
> <mbuf_pool_socket_0>: n=331456, size=2176, socket=0
> <mbuf_pool_socket_1>: n=331456, size=2176, socket=1
>
> ./build/app/testpmd -- --total-num-mbufs=8000 -i
> <mbuf_pool_socket_0>: n=256000, size=2176, socket=0
> <mbuf_pool_socket_1>: n=256000, size=2176, socket=1
> # BAD, should be n=8000 for each socket
>
> ./build/app/testpmd -- --no-numa -i
> <mbuf_pool_socket_0>: n=331456, size=2176, socket=0
>
> ./build/app/testpmd -- --no-numa --total-num-mbufs=8000 -i
> <mbuf_pool_socket_0>: n=8000, size=2176, socket=0
>
> ./build/app/testpmd --vdev=eth_null0 --vdev=eth_null1 -- -i
> <mbuf_pool_socket_0>: n=331456, size=2176, socket=0
> <mbuf_pool_socket_1>: n=331456, size=2176, socket=1
>
> ./build/app/testpmd --vdev=eth_null0 --vdev=eth_null1 -- \
> --total-num-mbufs=8000 -i
> <mbuf_pool_socket_0>: n=128000, size=2176, socket=0
> <mbuf_pool_socket_1>: n=128000, size=2176, socket=1
> # BAD, should be n=8000 for each socket
>
> ./build/app/testpmd --vdev=eth_null0 --vdev=eth_null1 -- --no-numa -i
> <mbuf_pool_socket_0>: n=331456, size=2176, socket=0
>
> ./build/app/testpmd --vdev=eth_null0 --vdev=eth_null1 -- --no-numa \
> --total-num-mbufs=8000 -i
> <mbuf_pool_socket_0>: n=8000, size=2176, socket=0
>
> - after the patch
>
> ./build/app/testpmd -- -i
> <mbuf_pool_socket_0>: n=331456, size=2176, socket=0
> <mbuf_pool_socket_1>: n=331456, size=2176, socket=1
>
> ./build/app/testpmd -- --total-num-mbufs=8000 -i
> <mbuf_pool_socket_0>: n=8000, size=2176, socket=0
> <mbuf_pool_socket_1>: n=8000, size=2176, socket=1
>
> ./build/app/testpmd -- --no-numa -i
> <mbuf_pool_socket_0>: n=331456, size=2176, socket=0
>
> ./build/app/testpmd -- --no-numa --total-num-mbufs=8000 -i
> <mbuf_pool_socket_0>: n=8000, size=2176, socket=0
>
> ./build/app/testpmd --vdev=eth_null0 --vdev=eth_null1 -- -i
> <mbuf_pool_socket_0>: n=331456, size=2176, socket=0
> <mbuf_pool_socket_1>: n=331456, size=2176, socket=1
>
> ./build/app/testpmd --vdev=eth_null0 --vdev=eth_null1 -- \
> --total-num-mbufs=8000 -i
> <mbuf_pool_socket_0>: n=8000, size=2176, socket=0
> <mbuf_pool_socket_1>: n=8000, size=2176, socket=1
>
> ./build/app/testpmd --vdev=eth_null0 --vdev=eth_null1 -- --no-numa -i
> <mbuf_pool_socket_0>: n=331456, size=2176, socket=0
>
> ./build/app/testpmd --vdev=eth_null0 --vdev=eth_null1 -- --no-numa \
> --total-num-mbufs=8000 -i
> <mbuf_pool_socket_0>: n=8000, size=2176, socket=0
>
> Fixes: b6ea6408fbc7 ("ethdev: store numa_node per device")
>
> CC: sta...@dpdk.org
> Signed-off-by: Olivier Matz <olivier.m...@6wind.com>
Acked-by: Jingjing Wu <jingjing...@intel.com>
