[dpdk-dev] [dpdk-dev v4 3/3] test: enable HW CRC strip by default

2017-04-07 Thread Jeff Guo
Since VF can not disable/enable HW CRC strip for non-DPDK PF drivers, and kernel driver almost default enable that feature, if disable it in test app's rxmode, VF driver will report the VF launch failure. So this patch default to enable HW CRC strip to let VF launch successful. Signed-off-by: Jeff

[dpdk-dev] [dpdk-dev v4 2/3] app: enable HW CRC strip by default

2017-04-07 Thread Jeff Guo
Since VF can not disable/enable HW CRC strip for non-DPDK PF drivers, and kernel driver almost default enable that feature, if disable it in app's rxmode, VF driver will report the VF launch failure. So this patch default to enable HW CRC strip to let VF launch successful. Signed-off-by: Jeff Guo

[dpdk-dev] [dpdk-dev v4 1/3] examples: enable HW CRC strip by default

2017-04-07 Thread Jeff Guo
Since VF can not disable/enable HW CRC strip for non-DPDK PF drivers, and kernel driver almost default enable that feature, if disable it in example app's rxmode, VF driver will report the VF launch failure. So this patch default to enable HW CRC strip to let VF launch successful. Signed-off-by: J

[dpdk-dev] [PATCH 2/2] maintainers: change section name for szedata2 driver

2017-04-07 Thread Matej Vido
The name of company is listed for other drivers. Use the company name also for szedata2 driver. Cards are available from Netcope rather than Cesnet. Signed-off-by: Matej Vido --- MAINTAINERS | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS

[dpdk-dev] [PATCH 1/2] doc: update szedata2 guide

2017-04-07 Thread Matej Vido
NICs are available from Netcope under the names NFB-*. Change names and direct the links to Netcope web. Signed-off-by: Matej Vido --- doc/guides/nics/szedata2.rst | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/doc/guides/nics/szedata2.rst b/doc/guides/nic

[dpdk-dev] [PATCH 09/11] ether: remove unnecessary cast of void pointer

2017-04-07 Thread Stephen Hemminger
Remove unnecessary casts of void * pointers to a specfic type. Signed-off-by: Stephen Hemminger --- lib/librte_ether/rte_ethdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/librte_ether/rte_ethdev.c b/lib/librte_ether/rte_ethdev.c index 4e1e6dc17..fa6ae4412 100644 --

Re: [dpdk-dev] [PATCH v3 2/2] ethdev: add hierarchical scheduler API

2017-04-07 Thread Dumitrescu, Cristian
Hi Jerin, Thanks for your review! > > Thanks Cristian for v3. > > From Cavium HW perceptive, v3 is in relatively good shape to consume it, > Except the below mentioned two pointers. > > 1) We strongly believes, application explicitly need to give level id, while > creating topology(i.e rte_tm_

[dpdk-dev] [PATCH 11/11] test: remove unnecessary cast of void pointer

2017-04-07 Thread Stephen Hemminger
Remove unnecessary casts of void * pointers to a specfic type. Signed-off-by: Stephen Hemminger --- test/test-pipeline/pipeline_hash.c | 2 +- test/test/test_efd.c | 2 +- test/test/test_interrupts.c| 4 ++-- test/test/test_mbuf.c | 2 +- test/test/test_table.c

[dpdk-dev] [PATCH 10/11] mempool: remove unnecessary cast of void pointer

2017-04-07 Thread Stephen Hemminger
Remove unnecessary casts of void * pointers to a specfic type. Signed-off-by: Stephen Hemminger --- lib/librte_mempool/rte_mempool.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/librte_mempool/rte_mempool.c b/lib/librte_mempool/rte_mempool.c index ef7d3d15b..f65310f60

[dpdk-dev] [PATCH 08/11] net: remmove unnecessary cast of void pointer

2017-04-07 Thread Stephen Hemminger
Remove unnecessary casts of void * pointers to a specfic type. Signed-off-by: Stephen Hemminger --- lib/librte_net/rte_net_crc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/librte_net/rte_net_crc.c b/lib/librte_net/rte_net_crc.c index 72efe2026..e8326fe76 100644 --- a

[dpdk-dev] [PATCH 07/11] eal: remove unnecessary cast of void pointer

2017-04-07 Thread Stephen Hemminger
Remove unnecessary casts of void * pointers to a specfic type. Signed-off-by: Stephen Hemminger --- lib/librte_eal/bsdapp/eal/eal.c | 4 ++-- lib/librte_eal/linuxapp/eal/eal.c| 2 +- lib/librte_eal/linuxapp/eal/eal_memory.c | 8 3 files changed, 7 insertions(+), 7 delet

[dpdk-dev] [PATCH 05/11] crypto: remove unnecessary cast of void pointer

2017-04-07 Thread Stephen Hemminger
Remove unnecessary casts of void * pointers to a specfic type. Signed-off-by: Stephen Hemminger --- lib/librte_cryptodev/rte_cryptodev.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/librte_cryptodev/rte_cryptodev.c b/lib/librte_cryptodev/rte_cryptodev.c index 30fd

[dpdk-dev] [PATCH 06/11] acl: remove unnecessary cast of void pointer

2017-04-07 Thread Stephen Hemminger
Remove unnecessary casts of void * pointers to a specfic type. Signed-off-by: Stephen Hemminger --- lib/librte_acl/acl_bld.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/lib/librte_acl/acl_bld.c b/lib/librte_acl/acl_bld.c index 9e5ad1c63..0768cd3bf 100644 --- a/lib

[dpdk-dev] [PATCH 04/11] port: remove unnecessary cast of void pointers

2017-04-07 Thread Stephen Hemminger
Remove unnecessary casts of void * pointers to a specfic type. Signed-off-by: Stephen Hemminger --- lib/librte_port/rte_port_ethdev.c | 26 +++--- lib/librte_port/rte_port_fd.c | 26 +++--- lib/librte_port/rte_port_frag.c| 6 ++--- lib/librt

[dpdk-dev] [PATCH 01/11] table: remove unnecessary void cast

2017-04-07 Thread Stephen Hemminger
Remove unnecessary casts of void * pointers to a specfic type. Signed-off-by: Stephen Hemminger --- lib/librte_table/rte_table_acl.c | 24 lib/librte_table/rte_table_array.c | 11 +-- lib/librte_table/rte_table_hash_cuckoo.c | 8 lib/librt

[dpdk-dev] [PATCH 02/11] kni: remove unnecessary cast of void pointers

2017-04-07 Thread Stephen Hemminger
Remove unnecessary casts of void * pointers to a specfic type. Signed-off-by: Stephen Hemminger --- lib/librte_eal/linuxapp/kni/ethtool/igb/igb_ethtool.c | 2 +- lib/librte_eal/linuxapp/kni/ethtool/igb/igb_main.c| 8 lib/librte_eal/linuxapp/kni/ethtool/ixgbe/ixgbe_ethtool.c

[dpdk-dev] [PATCH 03/11] vhost: remove unnecessary cast of void pointer

2017-04-07 Thread Stephen Hemminger
Remove unnecessary casts of void * pointers to a specfic type. Signed-off-by: Stephen Hemminger --- lib/librte_vhost/virtio_net.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/librte_vhost/virtio_net.c b/lib/librte_vhost/virtio_net.c index d6b7c7a22..b9f216842 100

[dpdk-dev] [PATCH 00/11] remove unnecessary cast of void pointers

2017-04-07 Thread Stephen Hemminger
This is a set patches inspired by a set of Linux kernel patches by simran singhal The following Coccinelle script was used to detect this: @r@ expression x; void* e; type T; identifier f; @@ ( *((T *)e) | ((T *)x)[...] | ((T*)x)->f | - (T*) e ) Stephen Hemminger (11): table: remove un

Re: [dpdk-dev] [PATCH v3 2/2] ethdev: add hierarchical scheduler API

2017-04-07 Thread Dumitrescu, Cristian
Hi Hemant, Thanks for your input! ... > > +/** > > + * Traffic manager dynamic updates > > + */ > > +enum rte_tm_dynamic_update_type { > > + /**< Dynamic parent node update. The new parent node is located > on same > > +* hierarchy level as the former parent node. Consequently, the > node

Re: [dpdk-dev] [PATCH v3 7/9] net/virtio: Add MTU feature support

2017-04-07 Thread Maxime Coquelin
Hi Jianfeng, On 04/05/2017 04:50 PM, Tan, Jianfeng wrote: On 4/5/2017 9:54 PM, Maxime Coquelin wrote: On 04/05/2017 11:42 AM, Tan, Jianfeng wrote: Hi Maxime, Thank you for replying. On 4/5/2017 3:11 PM, Maxime Coquelin wrote: Hi Jianfeng, On 04/05/2017 06:52 AM, Tan, Jianfeng wrote: H

Re: [dpdk-dev] [PATCH v2] net/i40e: fix QinQ eth pattern parsing

2017-04-07 Thread Ferruh Yigit
On 4/6/2017 5:54 AM, Xing, Beilei wrote: > >> -Original Message- >> From: Iremonger, Bernard >> Sent: Wednesday, April 5, 2017 10:04 PM >> To: dev@dpdk.org; Xing, Beilei >> Cc: Lu, Wenzhuo ; Iremonger, Bernard >> >> Subject: [PATCH v2] net/i40e: fix QinQ eth pattern parsing >> >> The eth

Re: [dpdk-dev] [PATCH] net/sfc: remove unnecessary mbuf initialization on Rx path

2017-04-07 Thread Ferruh Yigit
On 4/4/2017 12:57 PM, Andrew Rybchenko wrote: > mbuf next is equal to NULL, nb_segs and reference counter are equal to 1 > when mbuf is obtained from mempool. > > Signed-off-by: Andrew Rybchenko Applied to dpdk-next-net/master, thanks.

Re: [dpdk-dev] [PATCH v2 1/2] test/mempool_perf: Free mempool on exit

2017-04-07 Thread Olivier Matz
Hi Santosh, On Thu, 6 Apr 2017 12:15:48 +0530, Santosh Shukla wrote: > Mempool_perf test not freeing pool memory. > > Cc: sta...@dpdk.org > Signed-off-by: Santosh Shukla > Acked-by: Shreyansh Jain > --- > v1 --> v2: > * Fixed patch context > > test/test/test_mempool_perf.c | 31 ++

Re: [dpdk-dev] [PATCH] mem: balanced allocation of hugepages

2017-04-07 Thread Thomas Monjalon
2017-04-07 18:14, Ilya Maximets: > Hi All. > > I wanted to ask (just to clarify current status): > Will this patch be included in current release (acked by maintainer) > and then I will upgrade it to hybrid logic or I will just prepare v3 > with hybrid logic for 17.08 ? What is your preferred opt

Re: [dpdk-dev] [PATCH 0/2] reduce writes to mbuf in ixgbe vRX

2017-04-07 Thread Ferruh Yigit
On 4/7/2017 4:13 PM, Ferruh Yigit wrote: > On 4/4/2017 11:29 AM, Konstantin Ananyev wrote: >> Pretty much the same as one from Bruce: >> http://dpdk.org/ml/archives/dev/2017-April/062936.html >> but now for ixgbe. >> Based on Olivier's mbuf rework patchset, and makes some >> improvement to the ixgb

Re: [dpdk-dev] [PATCH v4 2/2] test/test: support default mempool autotest

2017-04-07 Thread Olivier Matz
On Wed, 5 Apr 2017 15:05:34 +0530, Shreyansh Jain wrote: > Mempool test currently supports: > * ring_mp_mc > * stack > > Adding a new default pool options. So, ring* + stack + default > (which can be 'stack' or 'ring') > * This way, whatever the value of RTE_MBUF_DEFAULT_MEMPOOL_OPS is set, >

Re: [dpdk-dev] [PATCH v4 1/2] test/test: free mempool on exit

2017-04-07 Thread Olivier Matz
On Wed, 5 Apr 2017 15:05:33 +0530, Shreyansh Jain wrote: > mempool autotest was not freeing the mempools. > > Fixes: 8ef772ae ("app/test: rework mempool tes") > Cc: sta...@dpdk.org > > Signed-off-by: Shreyansh Jain > Reviewed-by: Santosh Shukla Acked-by: Olivier Matz

[dpdk-dev] [PATCH v12 5/5] test: remove pci tests

2017-04-07 Thread Gaetan Rivet
These tests are not suited for the rte_bus PCI implementation anymore. Signed-off-by: Gaetan Rivet --- MAINTAINERS| 2 - test/test/Makefile | 2 - test/test/test.h | 3 - test/test/tes

[dpdk-dev] [PATCH v12 4/5] pci: use bus driver for scan/probe

2017-04-07 Thread Gaetan Rivet
From: Shreyansh Jain Remove EAL initiated direct PCI scan/probe and enable PCI Bus linkage. Signed-off-by: Shreyansh Jain Reviewed-by: Ferruh Yigit Signed-off-by: Thomas Monjalon Reviewed-by: Gaetan Rivet --- lib/librte_eal/bsdapp/eal/eal.c | 14 - lib/librte_eal/bsd

[dpdk-dev] [PATCH v12 2/5] pci: remove loop over drivers in device detach

2017-04-07 Thread Gaetan Rivet
From: Shreyansh Jain rte_eal_pci_detach calls pci_detach_all_drivers which loops over all PCI drivers for detaching the device. This is unnecessary as the device already has the PCI driver reference which can be used directly. Removing pci_detach_all_drivers and restructuring rte_eal_pci_detach

[dpdk-dev] [PATCH v12 3/5] pci: add bus driver

2017-04-07 Thread Gaetan Rivet
From: Shreyansh Jain Based on EAL Bus APIs, PCI bus callbacks and support functions are introduced in this patch. EAL continues to have direct PCI init/scan calls as well. These would be removed in subsequent patches to enable bus only PCI devices. Signed-off-by: Shreyansh Jain Reviewed-by: Fe

[dpdk-dev] [PATCH v12 1/5] pci: split match and probe

2017-04-07 Thread Gaetan Rivet
From: Shreyansh Jain Matching of PCI device address and driver ID table is being done at two discreet locations duplicating the code. (rte_eal_pci_probe_one_driver and rte_eal_pci_detach_dev). Refactor the match logic as a single function. Signed-off-by: Shreyansh Jain Reviewed-by: Ferruh Yigi

[dpdk-dev] [PATCH v12 0/5] rte_bus_pci

2017-04-07 Thread Gaetan Rivet
I have rebased the work done by Shreyansh and Thomas to follow the bus abstraction introduced in v17.02 for the PCI bus implementation. This series is only a partial version of the previous one, because some of the patches have already been integrated, and others still need rework. changes in v12:

Re: [dpdk-dev] [PATCH v3] ether: use a default for max Rx frame size in configure()

2017-04-07 Thread Andriy Berestovskyy
Hey Thomas, On 07.04.2017 16:47, Thomas Monjalon wrote: What if we add to the max_rx_pkt_len description: "the effective maximum RX frame size depends on PMD, please refer the PMD guide for the details"? I think the problem is not in the documentation but in the implementations which should be

[dpdk-dev] [PATCH 2/2] doc: add QinQ flow information to testpmd

2017-04-07 Thread Bernard Iremonger
Add information on validating and creating QinQ flow rules to the flow rules management section of the Testpmd User Guide. Signed-off-by: Bernard Iremonger --- doc/guides/testpmd_app_ug/testpmd_funcs.rst | 41 + 1 file changed, 41 insertions(+) diff --git a/doc/guide

[dpdk-dev] [PATCH 1/2] doc: release note for QinQ cloud filter

2017-04-07 Thread Bernard Iremonger
Signed-off-by: Bernard Iremonger --- doc/guides/rel_notes/release_17_05.rst | 7 +++ 1 file changed, 7 insertions(+) diff --git a/doc/guides/rel_notes/release_17_05.rst b/doc/guides/rel_notes/release_17_05.rst index 4968b8f74..6f3f7ab36 100644 --- a/doc/guides/rel_notes/release_17_05.rst ++

Re: [dpdk-dev] [PATCH] mem: balanced allocation of hugepages

2017-04-07 Thread Ilya Maximets
Hi All. I wanted to ask (just to clarify current status): Will this patch be included in current release (acked by maintainer) and then I will upgrade it to hybrid logic or I will just prepare v3 with hybrid logic for 17.08 ? Best regards, Ilya Maximets. On 27.03.2017 17:43, Ilya Maximets wrote

Re: [dpdk-dev] [PATCH 0/2] reduce writes to mbuf in ixgbe vRX

2017-04-07 Thread Ferruh Yigit
On 4/4/2017 11:29 AM, Konstantin Ananyev wrote: > Pretty much the same as one from Bruce: > http://dpdk.org/ml/archives/dev/2017-April/062936.html > but now for ixgbe. > Based on Olivier's mbuf rework patchset, and makes some > improvement to the ixgbe driver taking account of the rework. > It also

[dpdk-dev] [PATCH] net/bonding: allow configuring jumbo frames without slaves

2017-04-07 Thread Ilya Maximets
Currently, 'rte_eth_dev_configure' fails on attempt to setup max_rx_pkt_len > 2048 if no slaves was added to bonded device. For example: rte_eth_dev_attach("eth_bond0,slave=05:00.0,mode=l34", &id) conf.rxmode.jumbo_frame = 1; conf.rxmode.max_rx_pkt_len = 9000; rte_

[dpdk-dev] [PATCH] doc: pvp: fix typo in host's testpmd command line

2017-04-07 Thread Maxime Coquelin
This patch adds missing backslash in host's testpmd command line. Without it the command works, but a single core is used instead of four, which might create confusion. Fixes: 58a2551a160f ("doc: introduce PVP reference benchmark") Cc: John McNamara Signed-off-by: Maxime Coquelin --- doc/guid

Re: [dpdk-dev] [PATCH v3] ether: use a default for max Rx frame size in configure()

2017-04-07 Thread Thomas Monjalon
2017-04-07 16:18, Andriy Berestovskyy: > Hey Bruce, > > On 07.04.2017 14:29, Bruce Richardson wrote: > > Is this entirely hidden from drivers? As I said previously, I believe > > NICs using ixgbe/i40e etc. only use the frame size value when the jumbo > > frame flag is set. That may lead to further

[dpdk-dev] [PATCH] net/thunderx: fix access an array out of bounds

2017-04-07 Thread marcin . wilk
From: Marcin Wilk Trying to assign more queues to stats struct break only from one loop when the maximum size is reached. Outside loop interation is continued. This leads to access an array out of bounds. Fixes: 21e3fb0050b9 ("net/thunderx: add final bits for secondary queue support") Signed-of

Re: [dpdk-dev] [dpdk-announce] 6WIND will stop managing the dpdk.org community on April 14

2017-04-07 Thread Thomas Monjalon
Happy to announce that I will join Mellanox Technologies as a software engineer tasked with DPDK project maintenance. I want to take this opportunity to thank 6WIND for having supported me during the past five years. Mellanox believe that as DPDK maintainer I must be neutral and fair with all cont

Re: [dpdk-dev] [dpdk-stable] [PATCH 2/3] net/i40e: fix wrong VF link speed

2017-04-07 Thread Ferruh Yigit
On 4/6/2017 12:12 AM, Qi Zhang wrote: > When PF notify link speed to VF, encode of link speed need to > be converted from ETH_SPEED_XXX to I40E_LINK_SPEED_XXX. > > Fixes: bb6722fb5c0e ("net/i40e: fix VF bonded device link down") > Cc: sta...@dpdk.org > > Signed-off-by: Qi Zhang Hi Qi, There ar

Re: [dpdk-dev] [PATCH v3] ether: use a default for max Rx frame size in configure()

2017-04-07 Thread Andriy Berestovskyy
Hey Bruce, On 07.04.2017 14:29, Bruce Richardson wrote: Is this entirely hidden from drivers? As I said previously, I believe NICs using ixgbe/i40e etc. only use the frame size value when the jumbo frame flag is set. That may lead to further inconsistent behaviour unless all NICs are set up to b

Re: [dpdk-dev] dpdk-armv7: build failure since de96fe68ae9

2017-04-07 Thread Jan Viktorin
On Fri, 7 Apr 2017 15:27:16 +0200 Pascal Mazon wrote: > Hmmm. This is very strange. > From what you've given me, tap_flow.c should include a tap_autoconf.h with > HAVE_TC_FLOWER, avoiding the duplicated definition. > > Just to be sure, can you compile the tap driver with V=1 and look for the >

[dpdk-dev] 6WIND will stop managing the dpdk.org community on April 14

2017-04-07 Thread Eric Carmes
Hi As you may already know from our work together, 6WIND started the dpdk.org project almost 4 years ago and has been leading the community to make it a great success. dpdk.org is now the reference open source technology for fast packet processing supporting market-leading processor architectures

[dpdk-dev] [PATCH] config: support 16 sockets server

2017-04-07 Thread Yunjian Wang
From: Henry Cai Support 16 sockets server, such as HPE AH337A, Huawei kunlun server etc. Signed-off-by: Henry Cai --- config/common_base | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/config/common_base b/config/common_base index 5bdba1d..38561b6 100644 --- a/config/co

Re: [dpdk-dev] dpdk-armv7: build failure since de96fe68ae9

2017-04-07 Thread Pascal Mazon
Hmmm. This is very strange. From what you've given me, tap_flow.c should include a tap_autoconf.h with HAVE_TC_FLOWER, avoiding the duplicated definition. Just to be sure, can you compile the tap driver with V=1 and look for the following line? Looking for TCA_FLOWER_UNSPEC enum in linux/pkt_c

Re: [dpdk-dev] [PATCH v3 2/2] ethdev: add hierarchical scheduler API

2017-04-07 Thread Jerin Jacob
-Original Message- > Date: Sat, 4 Mar 2017 01:10:20 + > From: Cristian Dumitrescu > To: dev@dpdk.org > CC: thomas.monja...@6wind.com, jerin.ja...@caviumnetworks.com, > balasubramanian.manoha...@cavium.com, hemant.agra...@nxp.com, > shreyansh.j...@nxp.com > Subject: [PATCH v3 2/2] eth

Re: [dpdk-dev] [PATCH] examples: ethtool: Link against librte_pmd_ixgbe if necessary

2017-04-07 Thread Timothy M. Redaelli
On 02/17/2017 05:11 PM, remy.horton at intel.com (Remy Horton) wrote: > > On 16/02/2017 16:17, Markos Chandras wrote: >> The librte_ethtool library depends on librte_pmd_ixgbe if that >> pmd driver is enabled so we need to link against it when we compile >> the ethtool application. It fixes the fo

Re: [dpdk-dev] [PATCH v3] ether: use a default for max Rx frame size in configure()

2017-04-07 Thread Bruce Richardson
On Fri, Apr 07, 2017 at 02:15:47PM +0200, Thomas Monjalon wrote: > 2017-04-07 13:02, Andriy Berestovskyy: > > At the moment rte_eth_dev_configure() behaves inconsistent: > > - for normal frames: zero max_rx_pkt_len uses a default > > - for jumbo frames: zero max_rx_pkt_len gives an error > > > >

Re: [dpdk-dev] dpdk-armv7: build failure since de96fe68ae9

2017-04-07 Thread Jan Viktorin
On Fri, 7 Apr 2017 14:05:59 +0200 Pascal Mazon wrote: > On Fri, 7 Apr 2017 13:13:13 +0200 > Jan Viktorin wrote: > > > Hello Pascal, > > > > my internal ARMv7 DPDK autobuilder is failing. I've bisected to the > > source of the problem: > > > > commit de96fe68ae95990f5ce2cd4c8d9547ab62d2a810 >

Re: [dpdk-dev] [PATCH v3] ether: use a default for max Rx frame size in configure()

2017-04-07 Thread Thomas Monjalon
2017-04-07 13:02, Andriy Berestovskyy: > At the moment rte_eth_dev_configure() behaves inconsistent: > - for normal frames: zero max_rx_pkt_len uses a default > - for jumbo frames: zero max_rx_pkt_len gives an error > > This patch fixes this inconsistency by using a default value > if max_rx_pkt

Re: [dpdk-dev] dpdk-armv7: build failure since de96fe68ae9

2017-04-07 Thread Pascal Mazon
On Fri, 7 Apr 2017 13:13:13 +0200 Jan Viktorin wrote: > Hello Pascal, > > my internal ARMv7 DPDK autobuilder is failing. I've bisected to the > source of the problem: > > commit de96fe68ae95990f5ce2cd4c8d9547ab62d2a810 > Author: Pascal Mazon > Date: Thu Mar 23 09:33:57 2017 +0100 > > ne

Re: [dpdk-dev] [PATCH] net/thunderx: use rte version of byteorder.h

2017-04-07 Thread Ferruh Yigit
On 4/6/2017 5:06 PM, Jerin Jacob wrote: > The base code was using native GCC macros > for endian detection. Change to portable > rte_byteorder.h based endian detection. > > Fixes: 262d43fe20ee ("net/thunderx/base: add HW register definitions") > > Suggested-by: Thomas Monjalon > Signed-off-by: J

Re: [dpdk-dev] Working of pipeline in a given config file and regarding user-defined actions in IP_PIPELINE application

2017-04-07 Thread Singh, Jasvinder
Hi Nidhia, > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Nidhia Varghese > Sent: Thursday, April 6, 2017 10:07 AM > To: dev@dpdk.org; us...@dpdk.org > Subject: [dpdk-dev] Working of pipeline in a given config file and regarding > user-defined actions in IP_PIP

[dpdk-dev] dpdk-armv7: build failure since de96fe68ae9

2017-04-07 Thread Jan Viktorin
Hello Pascal, my internal ARMv7 DPDK autobuilder is failing. I've bisected to the source of the problem: commit de96fe68ae95990f5ce2cd4c8d9547ab62d2a810 Author: Pascal Mazon Date: Thu Mar 23 09:33:57 2017 +0100 net/tap: add basic flow API patterns and actions Is it a know issue? Is ther

Re: [dpdk-dev] [PATCH v2] config: compile avp driver only on intel 64 bit

2017-04-07 Thread Ferruh Yigit
On 4/4/2017 6:37 PM, Allain Legacy wrote: > The AVP devices are only supported on Intel 64-bit architectures so > adjusting the defconfig attributes accordingly. > > Fixes: 0485859868a9 ("net/avp: support driver registration") > > Signed-off-by: Allain Legacy Applied to dpdk-next-net/master, th

[dpdk-dev] [PATCH v3] ether: use a default for max Rx frame size in configure()

2017-04-07 Thread Andriy Berestovskyy
At the moment rte_eth_dev_configure() behaves inconsistent: - for normal frames: zero max_rx_pkt_len uses a default - for jumbo frames: zero max_rx_pkt_len gives an error This patch fixes this inconsistency by using a default value if max_rx_pkt_len is zero both for normal and jumbo frames. Sig

Re: [dpdk-dev] [PATCH v8 1/7] net/ark: stub PMD for Atomic Rules Arkville

2017-04-07 Thread Ferruh Yigit
On 4/4/2017 8:50 PM, Ed Czeck wrote: > Enable Arkville on supported configurations > Add overview documentation > Minimum driver support for valid compile > Arkville PMD is not supported on ARM or PowerPC at this time > > v8: > * Update to allow patch application from dpdk-next-net > > v6: > * Ad

Re: [dpdk-dev] [PATCH v3] net/i40e: fix return value check issue

2017-04-07 Thread Ferruh Yigit
On 4/5/2017 4:34 PM, Zhang, Helin wrote: > > >> -Original Message- >> From: henry [mailto:ca...@huawei.com] >> Sent: Wednesday, April 5, 2017 9:20 PM >> To: Zhang, Helin >> Cc: dev@dpdk.org; Wu, Jingjing; zhoujing...@huawei.com; henry cai >> Subject: [PATCH v3] net/i40e: fix return value

Re: [dpdk-dev] [PATCH v2] net/cxgbe: fix a bug in t4_wr_mbox_meat_timeout

2017-04-07 Thread Ferruh Yigit
On 3/30/2017 12:28 PM, Rahul Lakkireddy wrote: > On Tuesday, March 03/28/17, 2017 at 13:02:20 +0530, henry wrote: >>Check return value of malloc >> >>Signed-off-by: henry Signed-off-by: Henry Cai > Acked-by: Rahul Lakkireddy Applied to dpdk-next-net/master, thanks.

[dpdk-dev] [PATCH 4/4] net/ena: calculate partial checksum if DF bit is disabled

2017-04-07 Thread Marcin Wojtas
From: Michal Krawczyk When TSO is disabled we still have to calculate partial checksum if DF bit if turned off. This is caused by firmware bug. If application will not set m2_len field, we assume we that it was Ethernet frame because we have to look inside the packet to check for the DF flag. To

[dpdk-dev] [PATCH 1/4] net/ena: fix incorrect Rx descriptors allocation

2017-04-07 Thread Marcin Wojtas
From: Michal Krawczyk When application tried to allocate 1024 descriptors, device was not initializing properly. This patch solves it by avoiding allocation of all descriptors in the ring in one attempt. At least one descriptor must remain unused in the HW ring. Fixes: 1173fca25af9 ("ena: add p

[dpdk-dev] [PATCH 0/4] Ena PMD fixes

2017-04-07 Thread Marcin Wojtas
Hi, I sent 4 various fixes for ena PMD. 3 of them fix descriptors handling and the last one adjusts to the device firmware issue. We are looking forward to any comments or remarks. Best regards, Marcin Michal Krawczyk (4): net/ena: fix incorrect Rx descriptors allocation net/ena: fix delaye

[dpdk-dev] [PATCH 3/4] net/ena: cleanup if refilling of Rx descriptors fails

2017-04-07 Thread Marcin Wojtas
From: Michal Krawczyk If wrong number of descriptors for refilling was passed to the Rx repopulate function, there was memory leak which caused memory pool to run out of resources in longer go. In case of fail when refilling Rx descriptors, all additional mbufs have to be released. Fixes: 1173f

[dpdk-dev] [PATCH 2/4] net/ena: fix delayed cleanup of Rx descriptors

2017-04-07 Thread Marcin Wojtas
From: Michal Krawczyk On RX path, after receiving bunch of packets, variable tracking available descriptors in HW queue was not updated. To fix this issue, additional variable was added which is storing number of depleted descriptors updated by number of descriptors used in this cycle. Finally

[dpdk-dev] [PATCH v1] net: support PPPOE in software packet type parser

2017-04-07 Thread Ray Zhang
From: Ray Zhang Add a new RTE_PTYPE_L2_ETHER_PPPOE and its support in rte_net_get_ptype() Signed-off-by: Ray Zhang --- Resend the patch lib/librte_mbuf/rte_mbuf_ptype.h | 7 +++ lib/librte_net/rte_ether.h | 12 lib/librte_net/rte_net.c | 19 +++

Re: [dpdk-dev] [PATCH] net: support PPPOE in software packet type parser

2017-04-07 Thread Thomas Monjalon
Hi, Please, when sending a new patch version, follow these advices: - use --in-reply-to - use -v for version numbering - use --annotate to put a changelog below --- You can find more guidelines here: http://dpdk.org/dev#send Thank you for contributing

Re: [dpdk-dev] [PATCH 1/8] doc: add doc to explain compiling and testing of PMD

2017-04-07 Thread Shijith Thotton
On Fri, Apr 07, 2017 at 03:12:25PM +0530, Jerin Jacob wrote: > -Original Message- > > Date: Fri, 7 Apr 2017 12:37:26 +0530 > > From: Shijith Thotton > > To: Thomas Monjalon > > CC: John Mcnamara , dev@dpdk.org, Ferruh Yigit > > > > Subject: Re: [dpdk-dev] [PATCH 1/8] doc: add doc to exp

[dpdk-dev] [PATCH] net: support PPPOE in software packet type parser

2017-04-07 Thread skytap
From: Ray Zhang Add a new RTE_PTYPE_L2_ETHER_PPPOE and its support in rte_net_get_ptype() Signed-off-by: Ray Zhang --- lib/librte_mbuf/rte_mbuf_ptype.h | 7 +++ lib/librte_net/rte_ether.h | 12 lib/librte_net/rte_net.c | 19 +++ 3 files changed,

Re: [dpdk-dev] [PATCH] latency: fix compilation with timer lib disabled

2017-04-07 Thread Thomas Monjalon
2017-04-07 10:43, Olivier Matz: > Remove the include to "rte_timer.h" which is not needed > by latencystats library (only "rte_cycles.h" is used). > > Signed-off-by: Olivier Matz Applied, thanks

Re: [dpdk-dev] [PATCH 1/8] doc: add doc to explain compiling and testing of PMD

2017-04-07 Thread Jerin Jacob
-Original Message- > Date: Fri, 7 Apr 2017 12:37:26 +0530 > From: Shijith Thotton > To: Thomas Monjalon > CC: John Mcnamara , dev@dpdk.org, Ferruh Yigit > > Subject: Re: [dpdk-dev] [PATCH 1/8] doc: add doc to explain compiling and > testing of PMD > User-Agent: Mutt/1.5.21 (2010-09-15)

Re: [dpdk-dev] [PATCH 1/8] doc: add doc to explain compiling and testing of PMD

2017-04-07 Thread Thomas Monjalon
2017-04-07 09:23, Mcnamara, John: > > > -Original Message- > > From: Shijith Thotton [mailto:shijith.thot...@caviumnetworks.com] > > Sent: Friday, April 7, 2017 8:07 AM > > To: Thomas Monjalon > > Cc: Mcnamara, John ; dev@dpdk.org; Yigit, Ferruh > > > > Subject: Re: [dpdk-dev] [PATCH 1/8

Re: [dpdk-dev] [PATCH 1/8] doc: add doc to explain compiling and testing of PMD

2017-04-07 Thread Mcnamara, John
> -Original Message- > From: Shijith Thotton [mailto:shijith.thot...@caviumnetworks.com] > Sent: Friday, April 7, 2017 8:07 AM > To: Thomas Monjalon > Cc: Mcnamara, John ; dev@dpdk.org; Yigit, Ferruh > > Subject: Re: [dpdk-dev] [PATCH 1/8] doc: add doc to explain compiling and > testing

[dpdk-dev] [PATCH] net: support PPPOE in software packet type parser

2017-04-07 Thread Zhang Lei
Add a new RTE_PTYPE_L2_ETHER_PPPOE and its support in rte_net_get_ptype() Signed-off-by: Ray Zhang --- lib/librte_mbuf/rte_mbuf_ptype.h | 7 +++ lib/librte_net/rte_ether.h | 12 lib/librte_net/rte_net.c | 19 +++ 3 files changed, 38 insertions(+)

Re: [dpdk-dev] [PATCH v2] ether: use a default for max Rx frame size in configure()

2017-04-07 Thread Andriy Berestovskyy
On 07.04.2017 10:34, Thomas Monjalon wrote: We can set the right default value if the app input is 0, as a special case. For any other value, we must try to set it or return an error. Right, I will resend the patch. Andriy

[dpdk-dev] [PATCH] net: support PPPOE in software packet type parser

2017-04-07 Thread Zhang Lei
Add a new RTE_PTYPE_L2_ETHER_PPPOE and its support in rte_net_get_ptype() Signed-off-by: Ray Zhang --- lib/librte_mbuf/rte_mbuf_ptype.h | 7 +++ lib/librte_net/rte_ether.h | 12 lib/librte_net/rte_net.c | 19 +++ 3 files changed, 38 insertions(+)

[dpdk-dev] [PATCH] latency: fix compilation with timer lib disabled

2017-04-07 Thread Olivier Matz
Remove the include to "rte_timer.h" which is not needed by latencystats library (only "rte_cycles.h" is used). Signed-off-by: Olivier Matz --- lib/librte_latencystats/rte_latencystats.c | 1 - 1 file changed, 1 deletion(-) diff --git a/lib/librte_latencystats/rte_latencystats.c b/lib/librte_la

Re: [dpdk-dev] [PATCH v2] ether: use a default for max Rx frame size in configure()

2017-04-07 Thread Thomas Monjalon
2017-04-07 10:09, Andriy Berestovskyy: > Hi Thomas, > > On 06.04.2017 22:48, Thomas Monjalon wrote: > > Anyway, why not fixing it in the reverse way: returning error for > > out of range of non-jumbo frames? > > I guess we need to fix most of the examples then, since most of them > just pass 0 f

Re: [dpdk-dev] [PATCH v2 1/2] net/i40e: eliminate mbuf write on rearm

2017-04-07 Thread Bruce Richardson
On Thu, Apr 06, 2017 at 05:24:44PM +0100, Zhang, Qi Z wrote: > Hi Bruce: > > > -Original Message- > > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Bruce Richardson > > Sent: Thursday, April 6, 2017 7:32 PM > > To: Zhang, Helin > > Cc: dev@dpdk.org; Yigit, Ferruh ; Richardson, Bruc

Re: [dpdk-dev] [PATCH v2] ether: use a default for max Rx frame size in configure()

2017-04-07 Thread Bruce Richardson
On Mon, Mar 27, 2017 at 10:38:13AM +0200, Andriy Berestovskyy wrote: > Hey Qiming, > > On 27.03.2017 08:15, Yang, Qiming wrote: > > I don't think this is a bug. Return errors when configure an invalid > > max_rx_pkt_len is suitable for this generic API. > > It is not a bug, it is an inconsistenc

Re: [dpdk-dev] [PATCH v2] ether: use a default for max Rx frame size in configure()

2017-04-07 Thread Andriy Berestovskyy
Hi Thomas, On 06.04.2017 22:48, Thomas Monjalon wrote: Anyway, why not fixing it in the reverse way: returning error for out of range of non-jumbo frames? I guess we need to fix most of the examples then, since most of them just pass 0 for normal frames. And there is no default for jumbo fram

[dpdk-dev] [PATCH] net/virtio-user: fix cannot get initialized

2017-04-07 Thread Jianfeng Tan
After the introduction of vhost MTU, VIRTIO_NET_F_MTU is enabled by default. However, virtio-user vtpci does not support to get MTU from device yet, i.e., vtpci_read_dev_config(MTU) fails. Plus, struct virtio_net_config is defined as a uninitialized variable, and could be different values in virtio

Re: [dpdk-dev] [PATCH 1/8] doc: add doc to explain compiling and testing of PMD

2017-04-07 Thread Shijith Thotton
On Thu, Apr 06, 2017 at 08:30:21PM +0200, Thomas Monjalon wrote: > 2017-04-06 13:21, Shijith Thotton: > > Add a section in NIC drivers documentation to explain compiling and > > testing of a PMD. It also mentions about host setup, which is required > > before running testpmd. > > > > Add label "te