Re: [dpdk-dev] [PATCH 3/5] net/virtio-user: support to report net status

2017-03-28 Thread Yuanhan Liu
On Mon, Mar 27, 2017 at 07:46:32AM +, Tan, Jianfeng wrote: > > > diff --git a/drivers/net/virtio/virtio_user/virtio_user_dev.c > > b/drivers/net/virtio/virtio_user/virtio_user_dev.c > > > index 9777d6b..cc6f557 100644 > > > --- a/drivers/net/virtio/virtio_user/virtio_user_dev.c > > > +++ b/driv

Re: [dpdk-dev] [PATCH v2 2/5] net/virtio: add interrupt configure for vdev

2017-03-28 Thread Yuanhan Liu
On Tue, Mar 28, 2017 at 08:21:53AM +, Jianfeng Tan wrote: > For virtio PCI devices, interrupt should be configured before setting > VIRTIO_CONFIG_STATUS_DRIVER_OK so that QEMU can properly set eventfds > in the host. > > For virtio virtual devices, VIRTIO_CONFIG_STATUS_DRIVER_OK should be > se

Re: [dpdk-dev] [PATCH v3 2/5] net/i40e: parse QinQ pattern

2017-03-28 Thread Xing, Beilei
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Xing, Beilei > Sent: Wednesday, March 29, 2017 10:46 AM > To: Iremonger, Bernard ; dev@dpdk.org; > Wu, Jingjing > Cc: Zhang, Helin ; Lu, Wenzhuo > > Subject: Re: [dpdk-dev] [PATCH v3 2/5] net/i40e: parse QinQ pa

Re: [dpdk-dev] [dpdk-stable] [PATCH] net/mlx5: fix TSO header size in case of VLAN insertion

2017-03-28 Thread Shahaf Shuler
Tuesday, March 28, 2017 7:03 PM, Ferruh Yigit: > On 3/24/2017 8:25 AM, Nélio Laranjeiro wrote: > > On Thu, Mar 23, 2017 at 02:42:11PM +0200, Shahaf Shuler wrote: > >> When VLAN insertion is requested the vlan size must be added to the > >> calculation of the TSO header size, as it is not embedded w

Re: [dpdk-dev] disable i40e vf vlan stripping

2017-03-28 Thread Wu, Jingjing
> -Original Message- > From: Olivier Matz [mailto:olivier.m...@6wind.com] > Sent: Tuesday, March 28, 2017 11:30 PM > To: dev@dpdk.org; Zhang, Helin ; Wu, Jingjing > > Subject: disable i40e vf vlan stripping > > Hi i40e maintainers, > > I have the following configuration: > - host runs

Re: [dpdk-dev] [PATCH v4 00/14] refactor and cleanup of rte_ring

2017-03-28 Thread Yuanhan Liu
On Tue, Mar 28, 2017 at 09:35:52PM +0100, Bruce Richardson wrote: > This patchset make a set of, sometimes non-backward compatible, cleanup > changes to the rte_ring code in order to improve it. The resulting code is > shorter, since the existing functions are restructured to reduce code > duplicat

Re: [dpdk-dev] [PATCH v3 2/5] net/i40e: parse QinQ pattern

2017-03-28 Thread Xing, Beilei
Hi Bernard, > -Original Message- > From: Iremonger, Bernard > Sent: Wednesday, March 29, 2017 12:21 AM > To: dev@dpdk.org; Xing, Beilei ; Wu, Jingjing > > Cc: Zhang, Helin ; Lu, Wenzhuo > ; Iremonger, Bernard > > Subject: [PATCH v3 2/5] net/i40e: parse QinQ pattern > > add QinQ pattern.

Re: [dpdk-dev] [PATCH v3 5/5] net/i40e: update tunnel filter restore function

2017-03-28 Thread Lu, Wenzhuo
Hi, > -Original Message- > From: Iremonger, Bernard > Sent: Wednesday, March 29, 2017 12:21 AM > To: dev@dpdk.org; Xing, Beilei; Wu, Jingjing > Cc: Zhang, Helin; Lu, Wenzhuo; Iremonger, Bernard > Subject: [PATCH v3 5/5] net/i40e: update tunnel filter restore function > > The QinQ filter u

Re: [dpdk-dev] [PATCH v3 4/5] net/i40e: initialise L3 MAP register

2017-03-28 Thread Lu, Wenzhuo
Hi Bernard, > -Original Message- > From: Iremonger, Bernard > Sent: Wednesday, March 29, 2017 12:21 AM > To: dev@dpdk.org; Xing, Beilei; Wu, Jingjing > Cc: Zhang, Helin; Lu, Wenzhuo; Iremonger, Bernard > Subject: [PATCH v3 4/5] net/i40e: initialise L3 MAP register > > The L3 MAP register

Re: [dpdk-dev] [PATCH v3 2/5] net/i40e: parse QinQ pattern

2017-03-28 Thread Lu, Wenzhuo
Hi Bernard, > -Original Message- > From: Iremonger, Bernard > Sent: Wednesday, March 29, 2017 12:21 AM > To: dev@dpdk.org; Xing, Beilei; Wu, Jingjing > Cc: Zhang, Helin; Lu, Wenzhuo; Iremonger, Bernard > Subject: [PATCH v3 2/5] net/i40e: parse QinQ pattern > > add QinQ pattern. > add i40e

Re: [dpdk-dev] [PATCH v3 4/5] net/i40e: initialise L3 MAP register

2017-03-28 Thread Xing, Beilei
> -Original Message- > From: Iremonger, Bernard > Sent: Wednesday, March 29, 2017 12:21 AM > To: dev@dpdk.org; Xing, Beilei ; Wu, Jingjing > > Cc: Zhang, Helin ; Lu, Wenzhuo > ; Iremonger, Bernard > > Subject: [PATCH v3 4/5] net/i40e: initialise L3 MAP register > > The L3 MAP register

[dpdk-dev] [PATCH v6 7/7] net/ark: Arkville PMD component integration

2017-03-28 Thread Ed Czeck
* Flesh out device configuration * Add links dev_ops * allow dynamic extension loading v6: * Address review issues * Unify messages and logging * Improved error capturing Signed-off-by: Shepard Siegel Signed-off-by: John Miller Signed-off-by: Ed Czeck --- doc/guides/nics/features/ark.ini | 1

[dpdk-dev] [PATCH v6 5/7] net/ark: Packet TX support initial version

2017-03-28 Thread Ed Czeck
* Core TX packet moving functions * Flesh out ark_adapter struct to support TX code (not all fields used at this patch v6: * Unify messages and logging * improve comments * Use of PRIu32 format where needed Signed-off-by: Ed Czeck --- drivers/net/ark/Makefile| 1 + drivers/net/ark/ark

[dpdk-dev] [PATCH v6 6/7] net/ark: Packet RX support initial version

2017-03-28 Thread Ed Czeck
* Core RX packet moving functions v6: * Unify messaging and logging * Use PRIu32 format where needed * Address review comments Signed-off-by: Ed Czeck --- drivers/net/ark/Makefile| 1 + drivers/net/ark/ark_ethdev_rx.c | 672 drivers/net/ark/ark

[dpdk-dev] [PATCH v6 4/7] net/ark: Provide API for hardware modules pktchkr and pktgen

2017-03-28 Thread Ed Czeck
Provide C-level interface for Arkville's internal HW resources pktchkr and pktgen v6: * bug fix handing empty dev arguments. * Unify messaging and logging * Improve comments Signed-off-by: Ed Czeck --- drivers/net/ark/Makefile | 2 + drivers/net/ark/ark_pktchkr.c | 474 ++

[dpdk-dev] [PATCH v6 3/7] net/ark: Provide API for hardware modules udm and ddm

2017-03-28 Thread Ed Czeck
Provide C-level interface for Arkville's internal HW resources ddm (Downstream Data Mover) and udm (Upstream Data Mover) modules v6: * Unify messaging and logging Signed-off-by: Ed Czeck --- drivers/net/ark/Makefile | 4 +- drivers/net/ark/ark_ddm.c | 151 +++ dri

[dpdk-dev] [PATCH v6 2/7] net/ark: Provide API for hardware modules mpu, rqp, and pktdir

2017-03-28 Thread Ed Czeck
Provide C-level interface for Arkville's internal HW resources mpu, (Memory Prefetch Unit) pktdir (Packet director), and rqp (Request Pacer) modules v6: * Unify messaging and logging * Expand comments Signed-off-by: Ed Czeck --- drivers/net/ark/Makefile | 4 +- drivers/net/ark/ark_mpu.c

[dpdk-dev] [PATCH v6 1/7] net/ark: PMD for Atomic Rules Arkville driver stub

2017-03-28 Thread Ed Czeck
Enable Arkville on supported configurations Add overview documentation Minimum driver support for valid compile Arkville PMD is not supported on ARM or PowerPC at this time v6: * Address review comments * Unify messaging, logging and debug macros to ark_logs.h v5: * Address comments from Ferruh Y

Re: [dpdk-dev] [PATCH v2 1/3] net/i40e: add QinQ wrapper function

2017-03-28 Thread Lu, Wenzhuo
Hi Bernard, > -Original Message- > From: Iremonger, Bernard > Sent: Tuesday, March 28, 2017 9:23 PM > To: Iremonger, Bernard; Lu, Wenzhuo; dev@dpdk.org; Xing, Beilei; Wu, > Jingjing > Cc: Zhang, Helin; Stroe, Laura > Subject: RE: [dpdk-dev] [PATCH v2 1/3] net/i40e: add QinQ wrapper functio

[dpdk-dev] [PATCH v3 5/6] cfgfile: increase local buffer size for max name and value

2017-03-28 Thread Allain Legacy
From: Joseph Richard When parsing a ini file with a "key = value" line that has both "key" and "value" sized to the maximum allowed length causes a parsing failure. The internal "buffer" variable should be sized at least as large as the maximum for both fields. This commit updates the local arr

[dpdk-dev] [PATCH v3 3/6] cfgfile: add support for configurable comment character

2017-03-28 Thread Allain Legacy
The current cfgfile comment character is hardcoded to ';'. This commit a new API to allow the user to specify which comment character to use while parsing the file. This is to ease adoption by applications that have an existing configuration file which may use a different comment character. For

[dpdk-dev] [PATCH v3 1/6] test: basic unit tests for cfgfile

2017-03-28 Thread Allain Legacy
This commit adds the basic infrastructure for the cfgfile library unit tests. It includes success path tests for the most commonly used APIs. More unit tests will be added later. Signed-off-by: Allain Legacy --- MAINTAINERS | 1 + test/test/Makefile

Re: [dpdk-dev] [PATCH v3 1/3] crypto/scheduler: add fail-over scheduling mode file

2017-03-28 Thread De Lara Guarch, Pablo
Hi Fan, > -Original Message- > From: Zhang, Roy Fan > Sent: Tuesday, March 28, 2017 3:31 PM > To: dev@dpdk.org > Cc: De Lara Guarch, Pablo; Gonzalez Monroy, Sergio; Doherty, Declan > Subject: [PATCH v3 1/3] crypto/scheduler: add fail-over scheduling mode > file > > This patch adds the fai

Re: [dpdk-dev] [PATCH v5 7/7] net/ark: Arkville PMD component integration

2017-03-28 Thread Ed Czeck
On Tue, Mar 28, 2017 at 10:38 AM, Ferruh Yigit wrote: > On 3/23/2017 11:01 PM, Ed Czeck wrote: > > * Flesh out device configuration > > * Add links dev_ops > > * allow dynamic extension loading > > > > Signed-off-by: Shepard Siegel > > Signed-off-by: John Miller > > Signed-off-by: Ed Czeck > >

Re: [dpdk-dev] [PATCH v5 1/7] net/ark: PMD for Atomic Rules Arkville driver stub

2017-03-28 Thread Ed Czeck
On Tue, Mar 28, 2017 at 10:34 AM, Ferruh Yigit wrote: > > On 3/23/2017 10:59 PM, Ed Czeck wrote: > > Enable Arkville on supported configurations > > Add overview documentation > > Minimum driver support for valid compile > > Arkville PMD is not supported on ARM or PowerPC at this time > > > > v5:

Re: [dpdk-dev] [PATCH v5 6/7] net/ark: Packet RX support initial version

2017-03-28 Thread Ed Czeck
On Tue, Mar 28, 2017 at 10:36 AM, Ferruh Yigit wrote: > > On 3/23/2017 11:01 PM, Ed Czeck wrote: > > * Core RX packet moving functions > > > > Signed-off-by: Ed Czeck > > <...> > > > +/* TODO pick a better function name */ > > Is it possible to do now :) Thanks. > Done. > > > > + > > +/* Only u

Re: [dpdk-dev] [PATCH 1/3] net/qede: fix missing UDP protocol in RSS offload types

2017-03-28 Thread Mody, Rasesh
> From: Ferruh Yigit [mailto:ferruh.yi...@intel.com] > Sent: Tuesday, March 28, 2017 5:19 AM > > On 3/24/2017 7:40 AM, Rasesh Mody wrote: > > From: Harish Patil > > > > Both UDP and TCP based RSS offload types are supported by the device. > > This patch adds UDP protocol which got missed out in t

Re: [dpdk-dev] [PATCH v4 31/62] net/qede/base: revise tunnel APIs/structs

2017-03-28 Thread Mody, Rasesh
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Ferruh Yigit > Sent: Tuesday, March 28, 2017 4:23 AM > > On 3/28/2017 7:52 AM, Rasesh Mody wrote: > > Revise tunnel APIs/structs. > > - Unite tunnel start and update params in single struct > >"ecore_tunnel_info" > > - Remove A0 chip tun

Re: [dpdk-dev] [PATCH v4 1/7] net/ark: PMD for Atomic Rules Arkville driver stub

2017-03-28 Thread Ed Czeck
On Tue, Mar 28, 2017 at 8:58 AM, Ferruh Yigit wrote: > On 3/23/2017 7:46 PM, Ed Czeck wrote: > > >> > +#define ARK_TRACE_ON(fmt, ...) \ > >> > + PMD_DRV_LOG(ERR, fmt, ##__VA_ARGS__) > >> > + > >> > +#define ARK_TRACE_OFF(fmt, ...) \ > >> > + do {if (0) PMD_DRV_LOG(ERR, fmt, ##__VA_ARGS__)

Re: [dpdk-dev] [PATCH v7 1/7] qede: add base driver

2017-03-28 Thread Mody, Rasesh
Hi Ferruh, > From: Ferruh Yigit [mailto:ferruh.yi...@intel.com] > Sent: Tuesday, March 28, 2017 4:16 AM > > On 4/27/2016 3:18 PM, rasesh.mody at qlogic.com (Rasesh Mody) wrote: > > The base driver is the backend module for the QLogic FastLinQ QL4 > > 25G/40G CNA family of adapters as well as t

[dpdk-dev] [PATCHv2] pkg/dpdk.spec: add dkms to build kernel module

2017-03-28 Thread Anders Roxell
Build igb-uio and rte-kni kernel module using dkms. Signed-off-by: Anders Roxell --- pkg/dpdk.spec | 104 ++ 1 file changed, 104 insertions(+) diff --git a/pkg/dpdk.spec b/pkg/dpdk.spec index 7bc5780..550fb76 100644 --- a/pkg/dpdk.spec +++

Re: [dpdk-dev] [PATCH] pkg: add dkms to build kernel module

2017-03-28 Thread Anders Roxell
On 2017-02-07 18:04, Thomas Monjalon wrote: > Hi, Hi, I'm sorry for the extremely slow response. > > So the idea is to package DPDK kernel modules with DKMS. > And if we do not want to use DKMS, we just have to remove this part? > Could we better identify the DKMS part to remove? Or add a varia

[dpdk-dev] [PATCH v4 14/14] ring: make ring struct and enq/deq macros type agnostic

2017-03-28 Thread Bruce Richardson
Modify the enqueue and dequeue macros to support copying any type of object by passing in the exact object type. Rather than using the "ring" structure member of rte_ring, which is of type "array of void *", instead have the macros take the start of the ring a a pointer value, thereby leaving the r

[dpdk-dev] [PATCH v4 13/14] ring: create common function for updating tail idx

2017-03-28 Thread Bruce Richardson
Both producer and consumer use the same logic for updating the tail index so merge into a single function. Signed-off-by: Bruce Richardson Acked-by: Olivier Matz --- V3: added check for "single" mode in tail update to buypass unneeded check --- lib/librte_ring/rte_ring.h | 34 +-

[dpdk-dev] [PATCH v4 12/14] ring: separate out head index manipulation for enq/deq

2017-03-28 Thread Bruce Richardson
We can write a single common function for head manipulation for enq and a common one for deq, allowing us to have a single worker function for enq and deq, rather than two of each. Update all other inline functions to use the new functions. Signed-off-by: Bruce Richardson Acked-by: Olivier Matz

[dpdk-dev] [PATCH v4 11/14] ring: reduce scope of local variables

2017-03-28 Thread Bruce Richardson
The local variable i is only used for loop control so define it in the enqueue and dequeue blocks directly, rather than at the function level. Signed-off-by: Bruce Richardson Acked-by: Olivier Matz --- lib/librte_ring/rte_ring.h | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff

[dpdk-dev] [PATCH v4 10/14] examples/quota_watermark: use ring space for watermarks

2017-03-28 Thread Bruce Richardson
Now that the enqueue function returns the amount of space in the ring, we can use that to replace the old watermark functionality. Update the example app to do so, and re-enable it in the examples Makefile. Signed-off-by: Bruce Richardson Acked-by: Olivier Matz --- v4: updated rst doc to match t

[dpdk-dev] [PATCH v4 09/14] ring: allow dequeue fns to return remaining entry count

2017-03-28 Thread Bruce Richardson
Add an extra parameter to the ring dequeue burst/bulk functions so that those functions can optionally return the amount of remaining objs in the ring. This information can be used by applications in a number of ways, for instance, with single-consumer queues, it provides a max dequeue size which i

[dpdk-dev] [PATCH v4 08/14] ring: allow enqueue fns to return free space value

2017-03-28 Thread Bruce Richardson
Add an extra parameter to the ring enqueue burst/bulk functions so that those functions can optionally return the amount of free space in the ring. This information can be used by applications in a number of ways, for instance, with single-producer queues, it provides a max enqueue size which is gu

[dpdk-dev] [PATCH v4 07/14] ring: make bulk and burst fn return vals consistent

2017-03-28 Thread Bruce Richardson
The bulk fns for rings returns 0 for all elements enqueued and negative for no space. Change that to make them consistent with the burst functions in returning the number of elements enqueued/dequeued, i.e. 0 or N. This change also allows the return value from enq/deq to be used directly without a

[dpdk-dev] [PATCH v4 02/14] ring: create common structure for prod and cons metadata

2017-03-28 Thread Bruce Richardson
create a common structure to hold the metadata for the producer and the consumer, since both need essentially the same information - the head and tail values, the ring size and mask. Signed-off-by: Bruce Richardson Acked-by: Olivier Matz --- V3: removed union and replaced with "single" variable

[dpdk-dev] [PATCH v4 05/14] ring: remove the yield when waiting for tail update

2017-03-28 Thread Bruce Richardson
There was a compile time setting to enable a ring to yield when it entered a loop in mp or mc rings waiting for the tail pointer update. Build time settings are not recommended for enabling/disabling features, and since this was off by default, remove it completely. If needed, a runtime enabled equ

[dpdk-dev] [PATCH v4 06/14] ring: remove watermark support

2017-03-28 Thread Bruce Richardson
Remove the watermark support. A future commit will add support for having enqueue functions return the amount of free space in the ring, which will allow applications to implement their own watermark checks, while also being more useful to the app. Signed-off-by: Bruce Richardson Acked-by: Olivie

[dpdk-dev] [PATCH v4 03/14] ring: eliminate duplication of size and mask fields

2017-03-28 Thread Bruce Richardson
The size and mask fields are duplicated in both the producer and consumer data structures. Move them out of that into the top level structure so they are not duplicated. Signed-off-by: Bruce Richardson Acked-by: Olivier Matz --- lib/librte_ring/rte_ring.c | 20 ++-- lib/librte_r

[dpdk-dev] [PATCH v4 00/14] refactor and cleanup of rte_ring

2017-03-28 Thread Bruce Richardson
This patchset make a set of, sometimes non-backward compatible, cleanup changes to the rte_ring code in order to improve it. The resulting code is shorter, since the existing functions are restructured to reduce code duplication, as well as being more consistent in behaviour. The specific changes m

[dpdk-dev] [PATCH v4 04/14] ring: remove debug setting

2017-03-28 Thread Bruce Richardson
The debug option only provided statistics to the user, most of which could be tracked by the application itself. Remove this as a compile time option, and feature, simplifying the code. Signed-off-by: Bruce Richardson Acked-by: Olivier Matz --- config/common_base | 1 - do

[dpdk-dev] [PATCH v4 01/14] ring: remove split cacheline build setting

2017-03-28 Thread Bruce Richardson
Users compiling DPDK should not need to know or care about the arrangement of cachelines in the rte_ring structure. Therefore just remove the build option and set the structures to be always split. On platforms with 64B cachelines, for improved performance use 128B rather than 64B alignment since

Re: [dpdk-dev] [PATCH v5 2/7] net/ark: provide api to hardware module mpu, rqp, and pktdir

2017-03-28 Thread Ed Czeck
On Tue, Mar 28, 2017 at 10:35 AM, Ferruh Yigit wrote: > > On 3/23/2017 11:00 PM, Ed Czeck wrote: > > Provide C-level interface for Arkville's internal HW resources > > mpu, pktdir, and rqp modules > > At least in commit log, and if possible in documentation, can you please > mention what mpu, rqp

Re: [dpdk-dev] [PATCH v5 2/2] test/test: add unit test for CRC computation

2017-03-28 Thread Singh, Jasvinder
Hi Pablo, > -Original Message- > From: De Lara Guarch, Pablo > Sent: Tuesday, March 28, 2017 8:23 PM > To: Singh, Jasvinder ; dev@dpdk.org > Cc: olivier.m...@6wind.com; Doherty, Declan > Subject: RE: [PATCH v5 2/2] test/test: add unit test for CRC computation > > Hi Jasvinder, > > > >

Re: [dpdk-dev] [PATCH v5 2/2] test/test: add unit test for CRC computation

2017-03-28 Thread De Lara Guarch, Pablo
Hi Jasvinder, > -Original Message- > From: Singh, Jasvinder > Sent: Tuesday, March 21, 2017 2:46 PM > To: dev@dpdk.org > Cc: olivier.m...@6wind.com; Doherty, Declan; De Lara Guarch, Pablo > Subject: [PATCH v5 2/2] test/test: add unit test for CRC computation > > This patch provides a set

Re: [dpdk-dev] [PATCH v5 1/2] librte_net: add crc compute APIs

2017-03-28 Thread Singh, Jasvinder
Hi Pablo, > -Original Message- > From: De Lara Guarch, Pablo > Sent: Tuesday, March 28, 2017 7:04 PM > To: Singh, Jasvinder ; dev@dpdk.org > Cc: olivier.m...@6wind.com; Doherty, Declan > Subject: RE: [PATCH v5 1/2] librte_net: add crc compute APIs > > Hi Jasvinder, > > > -Original

Re: [dpdk-dev] [PATCH v5 1/2] librte_net: add crc compute APIs

2017-03-28 Thread De Lara Guarch, Pablo
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of De Lara Guarch, > Pablo > Sent: Tuesday, March 28, 2017 7:04 PM > To: Singh, Jasvinder; dev@dpdk.org > Cc: olivier.m...@6wind.com; Doherty, Declan > Subject: Re: [dpdk-dev] [PATCH v5 1/2] librte_net: add crc compu

Re: [dpdk-dev] [PATCH v5 1/2] librte_net: add crc compute APIs

2017-03-28 Thread De Lara Guarch, Pablo
Hi Jasvinder, > -Original Message- > From: Singh, Jasvinder > Sent: Tuesday, March 21, 2017 2:46 PM > To: dev@dpdk.org > Cc: olivier.m...@6wind.com; Doherty, Declan; De Lara Guarch, Pablo > Subject: [PATCH v5 1/2] librte_net: add crc compute APIs > > APIs for selecting the architecure spe

Re: [dpdk-dev] [PATCH v5 06/20] event/sw: add support for event queues

2017-03-28 Thread Jerin Jacob
On Tue, Mar 28, 2017 at 12:42:27PM +, Van Haaren, Harry wrote: > > From: Jerin Jacob [mailto:jerin.ja...@caviumnetworks.com] > > Sent: Tuesday, March 28, 2017 11:43 AM > > To: Van Haaren, Harry > > Cc: dev@dpdk.org; Richardson, Bruce > > Subject: Re: [PATCH v5 06/20] event/sw: add support for

[dpdk-dev] [PATCH v3 6/6] cfgfile: add support for empty value string

2017-03-28 Thread Allain Legacy
This commit adds support to the cfgfile library for parsing a key=value line that has no value string specified (e.g., "key="). This can be used to override a configuration attribute that has a default value or default list of values to set it back to an undefined value to disable functionality.

[dpdk-dev] [PATCH v3 4/6] cfgfile: use strnlen to constrain memchr search

2017-03-28 Thread Allain Legacy
The call to memchr() uses the absolute length of the string buffer instead of the actual length of the string returned by fgets(). This causes the search to go beyond the '\n' character and find ';' characters in random garbage on the stack. This then causes the 'len' variable to be updated and t

[dpdk-dev] [PATCH v3 3/6] cfgfile: add support for configurable comment character

2017-03-28 Thread Allain Legacy
The current cfgfile comment character is hardcoded to ';'. This commit a new API to allow the user to specify which comment character to use while parsing the file. This is to ease adoption by applications that have an existing configuration file which may use a different comment character. For

[dpdk-dev] [PATCH v3 1/6] test: basic unit tests for cfgfile

2017-03-28 Thread Allain Legacy
This commit adds the basic infrastructure for the cfgfile library unit tests. It includes success path tests for the most commonly used APIs. More unit tests will be added later. Signed-off-by: Allain Legacy --- MAINTAINERS | 1 + test/test/Makefile

[dpdk-dev] [PATCH v3 0/6] librte_cfgfile enhancements

2017-03-28 Thread Allain Legacy
This patchset includes some minor enhancements that we have developped for our DPDK application. We would like to contribute them upstream to help ease adoption of the DPDK by anyone looking for this type of functionality. The commit logs on each patch should be self-sufficient in explaining the

[dpdk-dev] [PATCH v3 3/5] net/i40e: update destroy tunnel filter function

2017-03-28 Thread Bernard Iremonger
The QinQ filter uses big buffers, set the big_buffer flag when removing a QinQ filter. Signed-off-by: Bernard Iremonger Acked-by: Wenzhuo Lu --- drivers/net/i40e/i40e_flow.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/i40e/i40e_flow.c b/drivers/net/i40e/i4

[dpdk-dev] [PATCH v3 4/5] net/i40e: initialise L3 MAP register

2017-03-28 Thread Bernard Iremonger
The L3 MAP register is initialised to support QinQ cloud filters. Signed-off-by: Bernard Iremonger --- drivers/net/i40e/i40e_ethdev.c | 8 1 file changed, 8 insertions(+) diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c index 5a03c7a95..a57b0416d 100644 ---

[dpdk-dev] [PATCH v3 5/5] net/i40e: update tunnel filter restore function

2017-03-28 Thread Bernard Iremonger
The QinQ filter uses big buffers, set the big_buffer flag when restoring a QinQ filter. Signed-off-by: Bernard Iremonger --- drivers/net/i40e/i40e_ethdev.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c inde

[dpdk-dev] [PATCH v3 2/5] net/i40e: parse QinQ pattern

2017-03-28 Thread Bernard Iremonger
add QinQ pattern. add i40e_flow_parse_qinq_pattern function. add i40e_flow_parse_qinq_filter function. Signed-off-by: Bernard Iremonger --- drivers/net/i40e/i40e_flow.c | 187 ++- 1 file changed, 185 insertions(+), 2 deletions(-) diff --git a/drivers/net/

[dpdk-dev] [PATCH v3 1/5] net/i40e: add QinQ filter create function

2017-03-28 Thread Bernard Iremonger
Add i40e_cloud_filter_qinq_create function, and call it from i40e_dev_consistent_tunnel_filter_set function. Replace the Outer IP filter with the QinQ filter. QinQ allows multiple VLAN tags to be inserted into a single Ethernet frame. A QinQ frame is a frame that has two VLAN 802.1Q headers. 802.1

[dpdk-dev] [PATCH v3 0/5] net/i40e: QinQ filter

2017-03-28 Thread Bernard Iremonger
This patchset depends on the following patch sets: [dpdk-dev,v5,1/5] net/i40e: add pipeline personalization profile processing [dpdk-dev,v4,1/4] net/i40e: rework tunnel filter functions [dpdk-dev,v3,1/3] app/testpmd: add support for MPLS and GRE items It adds support for QinQ filters. It uses the

Re: [dpdk-dev] [PATCH v5 09/20] event/sw: add worker core functions

2017-03-28 Thread Van Haaren, Harry
> From: Jerin Jacob [mailto:jerin.ja...@caviumnetworks.com] > Sent: Monday, March 27, 2017 2:51 PM > To: Van Haaren, Harry > Cc: dev@dpdk.org; Richardson, Bruce ; Eads, Gage > > Subject: Re: [PATCH v5 09/20] event/sw: add worker core functions > > On Fri, Mar 24, 2017 at 04:53:04PM +, Harry

Re: [dpdk-dev] mlx5 flow create/destroy behaviour

2017-03-28 Thread Legacy, Allain
> -Original Message- > From: Nélio Laranjeiro [mailto:nelio.laranje...@6wind.com] > Sent: Tuesday, March 28, 2017 11:36 AM <..> > If I understand correctly, your application is adding 500 rules like: > > flow create 0 ingress pattern eth src is dst is / vlan vid is > / end action mark

Re: [dpdk-dev] [PATCH 0/2] lib: add TCP IPv4 GRO support

2017-03-28 Thread Wiles, Keith
> On Mar 28, 2017, at 8:57 AM, Hu, Jiayu wrote: > > > >> -Original Message- >> From: Wiles, Keith >> Sent: Tuesday, March 28, 2017 9:40 PM >> To: Olivier Matz >> Cc: Ananyev, Konstantin ; Hu, Jiayu >> ; Yuanhan Liu ; >> Richardson, Bruce ; Stephen Hemminger >> ; Yigit, Ferruh ; >> dev

Re: [dpdk-dev] [dpdk-stable] [PATCH] net/mlx5: fix TSO header size in case of VLAN insertion

2017-03-28 Thread Ferruh Yigit
On 3/24/2017 8:25 AM, Nélio Laranjeiro wrote: > On Thu, Mar 23, 2017 at 02:42:11PM +0200, Shahaf Shuler wrote: >> When VLAN insertion is requested the vlan size must be added to the >> calculation of the TSO header size, as it is not embedded within the >> mbuf l2 length. >> >> Fixes: 98083fd482a2

[dpdk-dev] [PATCH v3] vfio: fix compile on older kernels

2017-03-28 Thread Anatoly Burakov
From: "Burakov, Anatoly" Fixing compile failures for kernels without sPAPR IOMMU support. Fixes: 0fe9830b5345 ("eal/ppc: support sPAPR IOMMU for vfio-pci") Signed-off-by: Burakov, Anatoly --- v3: fixed compile on kernels where SPAPR_v2 is not present but SPAPR is v2: fixed newlines lib/lib

Re: [dpdk-dev] [PATCH v12 4/6] app/test-pmd: add bitrate statistics calculation

2017-03-28 Thread Pattan, Reshma
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Remy Horton > Sent: Monday, March 27, 2017 9:22 PM > To: dev@dpdk.org > Cc: Thomas Monjalon > Subject: [dpdk-dev] [PATCH v12 4/6] app/test-pmd: add bitrate statistics > calculation > > --- > app/test-pmd/testpm

Re: [dpdk-dev] [PATCH v12 3/6] lib: add bitrate statistics library

2017-03-28 Thread Remy Horton
On 28/03/2017 16:30, Pattan, Reshma wrote: [..] +CFLAGS += $(WERROR_FLAGS) -I$(SRCDIR) + Adding -O3 flags? Not here, as I don't think optimization flags should be in non top-level Makefiles (someone correct me if this is wrong..). Other changes done.

Re: [dpdk-dev] [PATCH v2 0/6] librte_cfgfile enhancements

2017-03-28 Thread Bruce Richardson
On Tue, Mar 28, 2017 at 05:41:01PM +0200, Thomas Monjalon wrote: > 2017-03-28 16:24, Bruce Richardson: > > On Tue, Mar 28, 2017 at 12:12:26PM +0200, Thomas Monjalon wrote: > > > 2017-03-28 09:58, Dumitrescu, Cristian: > > > > > > As follow-up to my own mail, for this specific library example, I > >

Re: [dpdk-dev] [PATCH v2 0/6] librte_cfgfile enhancements

2017-03-28 Thread Thomas Monjalon
2017-03-28 16:24, Bruce Richardson: > On Tue, Mar 28, 2017 at 12:12:26PM +0200, Thomas Monjalon wrote: > > 2017-03-28 09:58, Dumitrescu, Cristian: > > > > > As follow-up to my own mail, for this specific library example, I > > > > > wouldn't look to remove it from DPDK anyway. Parsing ini files is

Re: [dpdk-dev] mlx5 flow create/destroy behaviour

2017-03-28 Thread Nélio Laranjeiro
Hi Allain, My attempt to reproduce it was a failure, may be I missed something, please see below, On Tue, Mar 28, 2017 at 12:42:05PM +, Legacy, Allain wrote: > Hi, > I am setting up an experiment to gauge the usability of the flow API > and the flow marking behavior of the CX4. I am working

Re: [dpdk-dev] [PATCH v5 18/20] test/eventdev: add SW deadlock tests

2017-03-28 Thread Burakov, Anatoly
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Harry van Haaren > Sent: Friday, March 24, 2017 4:53 PM > To: dev@dpdk.org > Cc: jerin.ja...@caviumnetworks.com; Van Haaren, Harry > ; Richardson, Bruce > ; Hunt, David > Subject: [dpdk-dev] [PATCH v5 18/20] test/eventdev: add SW deadlock test

Re: [dpdk-dev] [PATCH v12 3/6] lib: add bitrate statistics library

2017-03-28 Thread Pattan, Reshma
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Remy Horton > Sent: Monday, March 27, 2017 9:22 PM > To: dev@dpdk.org > Cc: Thomas Monjalon > Subject: [dpdk-dev] [PATCH v12 3/6] lib: add bitrate statistics library > > This patch adds a library that calculates

Re: [dpdk-dev] [PATCH v5 17/20] test/eventdev: add SW xstats tests

2017-03-28 Thread Burakov, Anatoly
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Harry van Haaren > Sent: Friday, March 24, 2017 4:53 PM > To: dev@dpdk.org > Cc: jerin.ja...@caviumnetworks.com; Van Haaren, Harry > ; Richardson, Bruce > ; Hunt, David > Subject: [dpdk-dev] [PATCH v5 17/20] test/eventdev: add SW xstats tests

[dpdk-dev] disable i40e vf vlan stripping

2017-03-28 Thread Olivier Matz
Hi i40e maintainers, I have the following configuration: - host runs with Linux pf i40e driver - guest runs with DPDK vf i40e driver I send a vlan packet from the host to the guest. On the guest, I start testpmd with --disable-hw-vlan-strip. When I receive the packet on the guest, it has the PKT

Re: [dpdk-dev] [PATCH v2] vfio: Fix vfio disable INTx

2017-03-28 Thread Burakov, Anatoly
> From: Rao, Nikhil > Sent: Wednesday, March 29, 2017 12:54 AM > To: Burakov, Anatoly > Cc: dev@dpdk.org > Subject: [PATCH v2] vfio: Fix vfio disable INTx > > The flags member of irq_set should be ORed with > VFIO_IRQ_SET_ACTION_MASK and not VFIO_IRQ_SET_ACTION_UNMASK. > The bug was found by code

Re: [dpdk-dev] [PATCH v2 0/6] librte_cfgfile enhancements

2017-03-28 Thread Bruce Richardson
On Tue, Mar 28, 2017 at 12:12:26PM +0200, Thomas Monjalon wrote: > 2017-03-28 09:58, Dumitrescu, Cristian: > > > > As follow-up to my own mail, for this specific library example, I > > > > wouldn't look to remove it from DPDK anyway. Parsing ini files is fairly > > > > trivial, so I think it's not

Re: [dpdk-dev] [PATCH] net/ixgbevf: fix stats update after a PF reset

2017-03-28 Thread Thomas Monjalon
Please ixgbe maintainers, what can be done for this fix? 2017-03-24 15:11, Olivier Matz: > Hi, > > (remove sta...@dpdk.org) > > On Tue, 14 Mar 2017 10:46:40 +0100, Olivier Matz > wrote: > > Hi Wei, > > > > On Thu, 16 Feb 2017 17:49:22 +0100, Olivier Matz > > wrote: > > > Hi Wei, > > > > >

Re: [dpdk-dev] [PATCH v5 15/20] test/eventdev: add basic SW tests

2017-03-28 Thread Burakov, Anatoly
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Harry van Haaren > Sent: Friday, March 24, 2017 4:53 PM > To: dev@dpdk.org > Cc: jerin.ja...@caviumnetworks.com; Van Haaren, Harry > ; Richardson, Bruce > ; Hunt, David > Subject: [dpdk-dev] [PATCH v5 15/20] test/eventdev: add basic SW tests >

Re: [dpdk-dev] [PATCH v5 16/20] test/eventdev: add SW tests for load balancing

2017-03-28 Thread Burakov, Anatoly
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Harry van Haaren > Sent: Friday, March 24, 2017 4:53 PM > To: dev@dpdk.org > Cc: jerin.ja...@caviumnetworks.com; Van Haaren, Harry > ; Richardson, Bruce > ; Hunt, David > Subject: [dpdk-dev] [PATCH v5 16/20] test/eventdev: add SW tests for loa

Re: [dpdk-dev] [PATCH v5 14/20] test/eventdev: add SW test infrastructure

2017-03-28 Thread Burakov, Anatoly
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Harry van Haaren > Sent: Friday, March 24, 2017 4:53 PM > To: dev@dpdk.org > Cc: jerin.ja...@caviumnetworks.com; Van Haaren, Harry > ; Richardson, Bruce > ; Hunt, David > Subject: [dpdk-dev] [PATCH v5 14/20] test/eventdev: add SW test > infras

[dpdk-dev] [PATCH v2] vfio: Fix vfio disable INTx

2017-03-28 Thread Nikhil Rao
The flags member of irq_set should be ORed with VFIO_IRQ_SET_ACTION_MASK and not VFIO_IRQ_SET_ACTION_UNMASK. The bug was found by code inspection. Fixes: 5c782b3928b8 (\"vfio: interrupts\") Signed-off-by: Nikhil Rao --- Changes since v1: * Better summary * Fix error message lib/librte_eal/linu

Re: [dpdk-dev] [PATCH v12 1/6] lib: add information metrics library

2017-03-28 Thread Remy Horton
On 28/03/2017 15:14, Pattan, Reshma wrote: [..] + +include $(RTE_SDK)/mk/rte.vars.mk + +# library name +LIB = librte_metrics.a + +CFLAGS += $(WERROR_FLAGS) -I$(SRCDIR) How about adding -O3 to flags? Off the top of my mind, I think such flags are added to CFLAGS separately. I think optimisat

Re: [dpdk-dev] [PATCH] doc: add option to install PMD driver shared library

2017-03-28 Thread Ferruh Yigit
On 3/27/2017 1:32 PM, Reshma Pattan wrote: > Update the document with the available EAL command > line option to install the pmd drivers that are built > as shared libraries. > > Signed-off-by: Reshma Pattan Acked-by: Ferruh Yigit

Re: [dpdk-dev] [PATCH v5 7/7] net/ark: Arkville PMD component integration

2017-03-28 Thread Adrien Mazarguil
On Tue, Mar 28, 2017 at 03:38:13PM +0100, Ferruh Yigit wrote: > On 3/23/2017 11:01 PM, Ed Czeck wrote: > > * Flesh out device configuration > > * Add links dev_ops > > * allow dynamic extension loading > > > > Signed-off-by: Shepard Siegel > > Signed-off-by: John Miller > > Signed-off-by: Ed Cze

Re: [dpdk-dev] [PATCH v5 7/7] net/ark: Arkville PMD component integration

2017-03-28 Thread Ferruh Yigit
On 3/23/2017 11:01 PM, Ed Czeck wrote: > * Flesh out device configuration > * Add links dev_ops > * allow dynamic extension loading > > Signed-off-by: Shepard Siegel > Signed-off-by: John Miller > Signed-off-by: Ed Czeck <...> > +[Features] > +Queue start/stop = Y > +Jumbo frame

[dpdk-dev] [PATCH] vfio: Fix vfio ioctl call to mask INTx

2017-03-28 Thread Nikhil Rao
The flags member of irq_set should be ORed with VFIO_IRQ_SET_ACTION_MASK and not VFIO_IRQ_SET_ACTION_UNMASK. The bug was found by code inspection. Fixes: 5c782b3928b8 (\"vfio: interrupts\") Signed-off-by: Nikhil Rao --- lib/librte_eal/linuxapp/eal/eal_interrupts.c | 2 +- 1 file changed, 1 inse

Re: [dpdk-dev] [PATCH v5 1/7] net/ark: PMD for Atomic Rules Arkville driver stub

2017-03-28 Thread Ferruh Yigit
On 3/23/2017 10:59 PM, Ed Czeck wrote: > Enable Arkville on supported configurations > Add overview documentation > Minimum driver support for valid compile > Arkville PMD is not supported on ARM or PowerPC at this time > > v5: > * Address comments from Ferruh Yigit > * Added documentation on dri

[dpdk-dev] [PATCH v3 2/3] crypto/scheduler: enable fail-over scheduling mode

2017-03-28 Thread Fan Zhang
This patch enables the fail-over mode in scheduler PMD. Signed-off-by: Fan Zhang --- drivers/crypto/scheduler/Makefile | 1 + drivers/crypto/scheduler/rte_cryptodev_scheduler.c | 7 +++ drivers/crypto/scheduler/rte_cryptodev_scheduler.h | 3 +++ 3 files changed, 11 insertion

Re: [dpdk-dev] [PATCH v5 6/7] net/ark: Packet RX support initial version

2017-03-28 Thread Ferruh Yigit
On 3/23/2017 11:01 PM, Ed Czeck wrote: > * Core RX packet moving functions > > Signed-off-by: Ed Czeck <...> > +/* TODO pick a better function name */ Is it possible to do now :) Thanks. > +static int > +eth_ark_rx_hw_setup(struct rte_eth_dev *dev, > + struct ark_rx_queue *qu

Re: [dpdk-dev] [PATCH v5 2/7] net/ark: provide api to hardware module mpu, rqp, and pktdir

2017-03-28 Thread Ferruh Yigit
On 3/23/2017 11:00 PM, Ed Czeck wrote: > Provide C-level interface for Arkville's internal HW resources > mpu, pktdir, and rqp modules At least in commit log, and if possible in documentation, can you please mention what mpu, rqp stands for, and perhaps describe them briefly? Same for other hardw

Re: [dpdk-dev] [PATCH v5 1/7] net/ark: PMD for Atomic Rules Arkville driver stub

2017-03-28 Thread Ferruh Yigit
On 3/23/2017 10:59 PM, Ed Czeck wrote: > Enable Arkville on supported configurations > Add overview documentation > Minimum driver support for valid compile > Arkville PMD is not supported on ARM or PowerPC at this time > > v5: > * Address comments from Ferruh Yigit > * Added documentation on dri

[dpdk-dev] [PATCH v3 0/3] crypto/scheduler: add fail-over mode

2017-03-28 Thread Fan Zhang
This patch adds fail-over mode for cryptodev scheduler PMD. Fail-over mode works with 2 slaves, primary slave and secondary slave. In this mode, the scheduler will enqueues the incoming crypto op burst to the primary slave. When one or more crypto ops are failed to be enqueued, they then will be en

[dpdk-dev] [PATCH v3 3/3] doc: update cryptodev scheduler PMD documentation

2017-03-28 Thread Fan Zhang
This patch updates fail-over scheduling mode description. Signed-off-by: Fan Zhang --- doc/guides/cryptodevs/scheduler.rst | 7 +++ 1 file changed, 7 insertions(+) diff --git a/doc/guides/cryptodevs/scheduler.rst b/doc/guides/cryptodevs/scheduler.rst index 70fb62e..da051ad 100644 --- a/doc

[dpdk-dev] [PATCH v3 1/3] crypto/scheduler: add fail-over scheduling mode file

2017-03-28 Thread Fan Zhang
This patch adds the fail-over scheduling mode main source file. Fail-over mode works with 2 slaves, primary slave and secondary slave. In this mode, the scheduler will enqueues the incoming crypto op burst to the primary slave. When one or more crypto ops are failed to be enqueued, they then will b

Re: [dpdk-dev] [dpdk-stable] [PATCH 1/2] net/mlx4: fix returned values upon failed probing

2017-03-28 Thread Gaëtan Rivet
Hi Ferruh, On Tue, Mar 28, 2017 at 11:15:42AM +0100, Ferruh Yigit wrote: On 3/27/2017 3:17 PM, Gaetan Rivet wrote: Let error messages in place, but return unambiguous values upon probing errors. Fixes: 66e1591687ac ("mlx4: avoid init errors when kernel modules are not loaded") Cc: sta...@dpdk

  1   2   3   >