On Tue, Mar 28, 2017 at 10:36 AM, Ferruh Yigit <ferruh.yi...@intel.com>
wrote:
>
> On 3/23/2017 11:01 PM, Ed Czeck wrote:
> > * Core RX packet moving functions
> >
> > Signed-off-by: Ed Czeck <ed.cz...@atomicrules.com>
>
> <...>
>
> > +/* TODO pick a better function name */
>
> Is it possible to do now :) Thanks.
>
Done.
>
>
> > +
> > +/* Only used in debug */
> > +static void
> > +dump_mbuf_data(struct rte_mbuf *mbuf, uint16_t lo, uint16_t hi)
> > +{
>
> There is already a rte_pktmbuf_dump(), does it works for you?
The rte_pktmbuf_dump() function dumps data based on the data_off field. My
use here is to examine data in the headroom of an mbuf. A comment was
added before this function to explain the difference.
>
> <...>
>
> > +/* Forward declarations */
> > +struct rte_mbuf;
> > +struct rte_mempool;
> > +struct rte_eth_dev;
> > +struct rte_eth_stats;
> > +struct rte_eth_rxconf;
>
> Same comment with Tx patch, these structs can be removed by including
> proper dpdk headers.
Done
Thanks
Ed.
