Re: [dpdk-dev] [PATCH 03/38] net/nfp: use library function for DMA zone reserve

On Fri, Mar 10, 2017 at 8:03 AM, Shreyansh Jain wrote: > On Monday 06 March 2017 03:29 PM, Jan Blunck wrote: >> >> -/* Creating memzone for hardware rings. */ >> -static const struct rte_memzone * >> -ring_dma_zone_reserve(struct rte_eth_dev *dev, const char *ring_name, >> - ui

Re: [dpdk-dev] [PATCH 03/38] net/nfp: use library function for DMA zone reserve

Hello Jan, On Monday 06 March 2017 03:29 PM, Jan Blunck wrote: This driver can use the library function rte_eth_dma_zone_reserve() instead of duplicating the code. Signed-off-by: Jan Blunck --- drivers/net/nfp/nfp_net.c | 30 ++ 1 file changed, 6 insertions(+), 24

Re: [dpdk-dev] ip_pipeline firewall customization

Hi Singh Please find my comments inline > > [Jasvinder] - You need to set the right proto field and accordingly the > mask in the above rule. You can keep src/dst ip addresses intact. Proto > field defines the protocol used in the data portion of the IP datagram and > can be find here >

Re: [dpdk-dev] [PATCH] examples/ip_fragmentation: fix check of packet type

Sorry, correct the name of Tester > -Original Message- > From: Dai, Wei > Sent: Friday, March 10, 2017 11:28 AM > To: dev@dpdk.org; Ananyev, Konstantin > Cc: Dai, Wei ; sta...@dpdk.org > Subject: [PATCH] examples/ip_fragmentation: fix check of packet type > > The packet_type in mbuf is n

[dpdk-dev] [PATCH] examples/ip_fragmentation: fix check of packet type

The packet_type in mbuf is not correctly filled by ixgbe 82599 NIC. To use the ether_type in ethernet header to check packet type is more reliaber. Fixes: 3c0184cc0c60 ("examples: replace some offload flags with packet type") Fixes: ab351fe1c95c ("mbuf: remove packet type from offload flags") Cc:

Re: [dpdk-dev] [PATCH v2 00/18] net/fm10k: update base code.

Hi Ferruh: I have checked 3/18 patch, no issue, Thank for the kind help! Regards Qi > -Original Message- > From: Yigit, Ferruh > Sent: Thursday, March 9, 2017 7:13 PM > To: Zhang, Qi Z ; Chen, Jing D > > Cc: Zhang, Helin ; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v2 00/18] ne

[dpdk-dev] DPDK R17.02 Intel Performance reports are available now on dpdk.org

Hi, all I'm pleased to announce that DPDK 17.02 Intel performance reports are available at below links. Please take a look at them and welcome your comments. Special thanks to Yulong, Pei and Lei, Yao to make the reports! DPDK 17.02 Intel NIC Performance Report: http://fast.dpdk.org/doc/perf/DP

Re: [dpdk-dev] [v4 0/3] Merge l3fwd-acl and l3fwd

Hi John, On Thu, Mar 9, 2017 at 2:23 AM, Mcnamara, John wrote: > > From: Ravi Kerur [mailto:rke...@gmail.com] > > Sent: Monday, March 6, 2017 11:21 PM > > To: Mcnamara, John > > Cc: dev@dpdk.org; Ananyev, Konstantin ; > > Richardson, Bruce > > Subject: Re: [dpdk-dev] [v4 0/3] Merge l3fwd-a

Re: [dpdk-dev] [PATCH v5 3/3] examples/l3fwd: add config file support for EM

Hi John, On Thu, Mar 9, 2017 at 2:45 AM, Mcnamara, John wrote: > > > > -Original Message- > > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Ravi Kerur > > Sent: Wednesday, March 8, 2017 9:32 PM > > To: dev@dpdk.org; Ananyev, Konstantin ; > > Richardson, Bruce > > Cc: Ravi Kerur

Re: [dpdk-dev] [PATCH] rte, eal: Rename pci_update_device and make it public

Hi Thomas, That's OK. Hope that the need of usage can be considered in the new framework. -Original Message- From: Thomas Monjalon [mailto:thomas.monja...@6wind.com] Sent: Friday, March 10, 2017 1:58 AM To: Yang, Ziye Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH] rte, eal: Rename pc

Re: [dpdk-dev] ip_pipeline firewall customization

Hi Shayam, From: Shyam Shrivastav [mailto:shrivastav.sh...@gmail.com] Sent: Thursday, March 9, 2017 1:50 PM To: Dumitrescu, Cristian Cc: dev@dpdk.org; Singh, Jasvinder Subject: Re: [dpdk-dev] ip_pipeline firewall customization My mistake, arp packets are hit by pipeline>p 1 firewall add priori

Re: [dpdk-dev] [PATCH v3] app/crypto-perf: fix avoid wrong optype for AEAD algorithms

> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of De Lara Guarch, > Pablo > Sent: Thursday, March 09, 2017 9:35 PM > To: Mrzyglod, DanielX T; Mrozowicz, SlawomirX; Doherty, Declan > Cc: dev@dpdk.org; Mrzyglod, DanielX T > Subject: Re: [dpdk-dev] [PATCH v3] app/cr

Re: [dpdk-dev] [PATCH] app/crypto-perf: fix invalid latency for QAT PMD

> -Original Message- > From: De Lara Guarch, Pablo > Sent: Thursday, March 09, 2017 9:25 PM > To: De Lara Guarch, Pablo; Mrozowicz, SlawomirX; Doherty, Declan > Cc: dev@dpdk.org; Mrozowicz, SlawomirX > Subject: RE: [dpdk-dev] [PATCH] app/crypto-perf: fix invalid latency for QAT > PMD > >

Re: [dpdk-dev] [PATCH v3] app/crypto-perf: fix avoid wrong optype for AEAD algorithms

> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Daniel Mrzyglod > Sent: Wednesday, March 08, 2017 5:03 PM > To: Mrozowicz, SlawomirX; Doherty, Declan; De Lara Guarch, Pablo > Cc: dev@dpdk.org; Mrzyglod, DanielX T > Subject: [dpdk-dev] [PATCH v3] app/crypto-perf

Re: [dpdk-dev] [PATCH] app/crypto-perf: fix invalid latency for QAT PMD

> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of De Lara Guarch, > Pablo > Sent: Monday, March 06, 2017 4:29 PM > To: Mrozowicz, SlawomirX; Doherty, Declan > Cc: dev@dpdk.org; Mrozowicz, SlawomirX > Subject: Re: [dpdk-dev] [PATCH] app/crypto-perf: fix invalid la

Re: [dpdk-dev] [PATCH] examples: optind should be reset to one not zero

> On Mar 9, 2017, at 2:41 PM, Thomas Monjalon wrote: > > 2017-02-14 16:09, Keith Wiles: >> Signed-off-by: Keith Wiles > > Please, could explain and describe what was the consequence of this > wrong reset value? > You can just reply and I will integrate it in the commit when applying. Here is

[dpdk-dev] [PATCH v6 3/3] net/vhost: vHost support to free consumed buffers

Add support to the vHostdriver for the new API to force free consumed buffers on Tx ring. vHost does not cache the mbufs so there is no work to do. Signed-off-by: Billy McFall --- doc/guides/nics/features/vhost.ini | 1 + drivers/net/vhost/rte_eth_vhost.c | 11 +++ 2 files changed, 12

[dpdk-dev] [PATCH v6 2/3] net/e1000: e1000 igb support to free consumed buffers

Add support to the e1000 igb driver for the new API to force free consumed buffers on Tx ring. This API is independent of the tx_rs_thresh setting. With this API, buffers should be free even if tx_rs_thresh is not met. e1000 igb driver does not implement a tx_rs_thresh to free mbufs, it frees a sl

[dpdk-dev] [PATCH v6 1/3] ethdev: new API to free consumed buffers in Tx ring

Add a new API to force free consumed buffers on Tx ring. API will return the number of packets freed (0-n) or error code if feature not supported (-ENOTSUP) or input invalid (-ENODEV). Please double check my python coding in conf.py and make sure I implemented 'feature_str_len' properly. Signed-o

[dpdk-dev] [PATCH v6 0/3] new API to free consumed buffers in Tx ring

See request from 11/21/2016: http://dpdk.org/ml/archives/dev/2016-November/050585.html Add a new API to free consumed buffers on TX ring. This addresses two scenarios: 1) Flooding a packet and want to reuse existing mbuf to avoid a packet copy. Increment the reference count of the packet and pol

Re: [dpdk-dev] [PATCH] examples: optind should be reset to one not zero

2017-02-14 16:09, Keith Wiles: > Signed-off-by: Keith Wiles Please, could explain and describe what was the consequence of this wrong reset value? You can just reply and I will integrate it in the commit when applying. Thanks

[dpdk-dev] [PATCH] net/virtio: disable LSC interrupt if MSIX not enabled

From: Matt Peters The link state change interrupt can only be configured if the virtio device supports MSIX. Prior to this change the writing of the vector to the PCI config space was causing it to overwrite the initial part of the MAC address since the MSIX vector is not in the config space and

Re: [dpdk-dev] [PATCH] doc: fix crypto overview matrix for missing QAT items

2017-03-03 12:51, Fiona Trahe: > Support for all the following was added in release 16.11 > but not updated in the matrix: > 3DES, MD5_HMAC, SHA224, SHA383, NULL, KASUMI F8/F9, GMAC. > > Fixes: e1b7f509e6f2 ("crypto/qat: add 3DES cipher algorithm") > Fixes: 61ec5181625f ("crypto/qat: add MD5 HMAC

Re: [dpdk-dev] [PATCH] examples: ethtool: Link against librte_pmd_ixgbe if necessary

2017-02-16 16:17, Markos Chandras: > The librte_ethtool library depends on librte_pmd_ixgbe if that > pmd driver is enabled so we need to link against it when we compile > the ethtool application. It fixes the following build problem: > > /usr/lib64/gcc/x86_64-suse-linux/6/../../../../x86_64-suse-

[dpdk-dev] [PATCH v2 2/3] doc: restructure QAT PMD guide

Restructure QAT PMD instructions and add a device table to minimise duplication for each device and make it easier to add devices. Fix some device name typos. Signed-off-by: Fiona Trahe --- doc/guides/cryptodevs/qat.rst | 370 +- 1 file changed, 148 insert

[dpdk-dev] [PATCH v2 1/3] crypto/qat: add support for Intel QAT device D15xx

Add support for Intel QuickAssist Technology device D15xx Signed-off-by: Fiona Trahe --- drivers/crypto/qat/rte_qat_cryptodev.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/crypto/qat/rte_qat_cryptodev.c b/drivers/crypto/qat/rte_qat_cryptodev.c index 5b34f5e..386a449 100644 --

[dpdk-dev] [PATCH v2 3/3] doc: add support for Intel QAT device D15xx

Add instructions for D15xx device to the QAT PMD guide. Signed-off-by: Fiona Trahe --- doc/guides/cryptodevs/qat.rst | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/doc/guides/cryptodevs/qat.rst b/doc/guides/cryptodevs/qat.rst index 4927a00..897919e 100644 --- a/doc/guid

[dpdk-dev] [PATCH v2 0/3] crypto/qat: add support for Intel QAT device D15xx

Add support for Intel QuickAssist Technology device D15xx v2 changes: - update documentation Fiona Trahe (3): crypto/qat: add support for Intel QAT device D15xx doc: restructure QAT PMD guide doc: add support for Intel QAT device D15xx doc/guides/cryptodevs/qat.rst | 374 +++

Re: [dpdk-dev] [PATCH v11 5/7] mbuf: add a timestamp to the mbuf for latencystats

On Thu, 9 Mar 2017 16:25:32 + Remy Horton wrote: > From: Harry van Haaren > > This commit adds a uint64_t to the mbuf struct, > allowing collection of latency and jitter statistics > by measuring packet I/O timestamps. This change is > required by the latencystats library. > > Signed-off-

Re: [dpdk-dev] [PATCH 2/2] ethdev: move queue id check in generic layer

2017-02-17 16:25, Olivier Matz: > The check of queue_id is done in all drivers implementing > rte_eth_rx_queue_count(). Factorize this check in the generic function. > > Note that the nfp driver was doing the check differently, which could > induce crashes if the queue index was too big. > > Sign

Re: [dpdk-dev] [PATCH 1/2] eal_interrupts: support external rxq interrupt handlers

2017-02-08 15:57, Shahaf Shuler: > /** > + * It deletes registered eventfds. > + * > + * @param intr_handle > + * Pointer to the interrupt handle. > + */ > +void > +rte_intr_free_epoll_fd(struct rte_intr_handle *intr_handle); This patch looks OK except a miss in the EAL map files for this new f

Re: [dpdk-dev] [PATCH] rte, eal: Rename pci_update_device and make it public

2017-02-13 10:53, Ziye Yang: > The reaon is that sometimes we only like to rebound the > kernel driver or VFIO or UIO or other drivers for > this device after rte_eal_detach function. Function > rte_eal_pci_probe_one not only updates the device but > also probes the rte_eal_driver for this device,

Re: [dpdk-dev] [PATCH v3] eal: sPAPR IOMMU support in pci probing for vfio-pci in ppc64le

2017-03-09 09:38, Chao Zhu: > > From: Gowrishankar Muthukrishnan > > > > Below changes adds pci probing support for vfio-pci devices in power8. > > > > v3 - better validation for kernel not implementing few iocts called > > v2 - kernel version checked and doc updated > > > > Signed-off-by: Gowr

Re: [dpdk-dev] [PATCH v2 00/11] Support flow API in Solarflare PMD

On 3/9/2017 3:26 PM, Andrew Rybchenko wrote: > Support simple queue destination flow API filters in Solarflare > libefx-based PMD including: > - Ethernet source/destination, EtherType exact matching > - VLAN ID exact matching including double-tagging > - IPv4/6 source/destination and IP protocol

[dpdk-dev] [PATCH v2 5/6] net/sfc: add support for MCDI proxy

From: Ivan Malov The patch is to add support for MCDI proxy which comes in useful, particularly, while running over VF: few commands will normally fail with EPERM, but in some cases the host driver (i.e. running over the corresponding PF, typically, within a hypervisor) may set itself as a proxy

[dpdk-dev] [PATCH v2 3/6] net/sfc: poll MAC stats if periodic DMA is not supported

From: Ivan Malov If periodic DMA statistics feature is absent (particularly, while running over VF), the PMD must provide an ability to cope with it using explicit update requests which are kept restrained according to 'stats_update_period_ms' parameter Signed-off-by: Ivan Malov Signed-off-by:

[dpdk-dev] [PATCH v2 2/6] net/sfc: add kvarg control for MAC statistics update period

From: Ivan Malov The patch is to make MAC statistics update interval tunable by means of 'stats_update_period_ms' kvarg parameter making it possible to use values different from 1000 ms in case of SFN8xxx boards provided that firmware version is 6.2.1.1033 Signed-off-by: Ivan Malov Signed-off-b

[dpdk-dev] [PATCH v2 6/6] net/sfc: add VFs to the table of PCI IDs for supported NICs

From: Ivan Malov Signed-off-by: Ivan Malov Signed-off-by: Andrew Rybchenko Reviewed-by: Andrew Lee --- doc/guides/nics/features/sfc_efx.ini | 1 + doc/guides/rel_notes/release_17_05.rst | 4 drivers/net/sfc/sfc_ethdev.c | 3 +++ 3 files changed, 8 insertions(+) diff --git a/

[dpdk-dev] [PATCH v2 4/6] net/sfc: avoid failure on port start if Rx mode is rejected

From: Ivan Malov If Rx mode is unacceptable, in particular, when promiscuous or all-multicast filters are not allowed while running over PCI function which is not a member of appropriate privilege groups, the driver has to cope with the failures gracefully Signed-off-by: Ivan Malov Signed-off-b

[dpdk-dev] [PATCH v2 1/6] net/sfc/base: don't ignore requested MAC stats update period

Signed-off-by: Andrew Rybchenko --- drivers/net/sfc/base/efx_mcdi.c | 24 ++-- drivers/net/sfc/base/efx_mcdi.h | 2 +- 2 files changed, 15 insertions(+), 11 deletions(-) diff --git a/drivers/net/sfc/base/efx_mcdi.c b/drivers/net/sfc/base/efx_mcdi.c index ac432a6..c9d29a7 100

[dpdk-dev] [PATCH v2 0/6] Support running Solarflare PMD over PCI VFs

Running Solarflare PMD over PCI virtual functions requires few fixes: - periodic MAC stats DMA is not supported for VFs - promiscious and all-multicast modes may be denied by FW/PF - MCDI proxy authorization made by FW should be properly handled by the VF driver v1 -> v2 * rephrase git logs

Re: [dpdk-dev] [PATCH] net/ixgbe: Put correct id values in ixgbevf_dev_xstats_get

On 3/9/2017 4:46 PM, Ferruh Yigit wrote: > On 3/7/2017 2:28 PM, Ido Barnea (ibarnea) wrote: >> Without setting the id, calling xstats_get twice with same array causes >> memory corruption. >> Also, if IXGBEVF_NB_XSTATS will be different than 1 in the future, this will >> cause issues. >> >> Signe

Re: [dpdk-dev] [PATCH v5 1/3] ethdev: new API to free consumed buffers in Tx ring

2017-03-09 10:49, Billy McFall: > On Tue, Mar 7, 2017 at 11:03 AM, Thomas Monjalon > wrote: > > 2017-03-07 09:29, Billy McFall: > > > On Mon, Feb 27, 2017 at 8:48 AM, Thomas Monjalon < > > thomas.monja...@6wind.com> > > > wrote: > > > > I think you could use rte_errno (while keeping negative retur

Re: [dpdk-dev] [PATCH 0/4] net/bonding: bonding and LACP fixes

On 09/03/2017 1:19 PM, Thomas Monjalon wrote: 2017-02-08 18:14, Thomas Monjalon: 2016-08-01 16:42, Robert Sanford: In this patch series, we fix two bonding driver bugs and enhance testpmd so that bonding mode 4 (LACP) ports remain operational even when idle. These patches are blocked because

Re: [dpdk-dev] [PATCH] net/ixgbe: Put correct id values in ixgbevf_dev_xstats_get

On 3/7/2017 2:28 PM, Ido Barnea (ibarnea) wrote: > Without setting the id, calling xstats_get twice with same array causes > memory corruption. > Also, if IXGBEVF_NB_XSTATS will be different than 1 in the future, this will > cause issues. > > Signed-off-by: Ido Barnea Acked-by: Ferruh Yigit

[dpdk-dev] [PATCH v11 7/7] app/test-pmd: add latency statistics calculation

From: Harry van Haaren This patch adds latency stats commandline argument to testpmd, allowing to specify the lcore to use for latencystats updates. Signed-off-by: Reshma Pattan Signed-off-by: Harry van Haaren Signed-off-by: Remy Horton --- app/test-pmd/parameters.c | 20 +++-

[dpdk-dev] [PATCH v11 6/7] lib: added new library for latency stats

From: Harry van Haaren Add a library designed to calculate latency statistics and report them to the application when queried. The library measures minimum, average and maximum latencies, and jitter in nano seconds. The current implementation supports global latency stats, i.e. per application st

[dpdk-dev] [PATCH v11 5/7] mbuf: add a timestamp to the mbuf for latencystats

From: Harry van Haaren This commit adds a uint64_t to the mbuf struct, allowing collection of latency and jitter statistics by measuring packet I/O timestamps. This change is required by the latencystats library. Signed-off-by: Reshma Pattan Signed-off-by: Harry van Haaren --- lib/librte_mbuf

[dpdk-dev] [PATCH v11 4/7] app/test-pmd: add bitrate statistics calculation

Calculate bitrate statistics using the bitrate stats library. The resulting statistics can be viewed via proc_info. Signed-off-by: Remy Horton --- app/test-pmd/testpmd.c | 41 - 1 file changed, 40 insertions(+), 1 deletion(-) diff --git a/app/test-pmd/tes

[dpdk-dev] [PATCH v11 0/7] Expanded statistics reporting

This patchset consists of three libraries: A Metrics library for distributing device information, a library that calculates bit-rate statistics, and a library that calculates latency statistics. The latter two libraries make use of the first library. Metrics Library --- The Metrics lib

[dpdk-dev] [PATCH v11 3/7] lib: add bitrate statistics library

This patch adds a library that calculates peak and average data-rate statistics. For ethernet devices. These statistics are reported using the metrics library. Signed-off-by: Remy Horton --- MAINTAINERS| 4 + config/common_base

[dpdk-dev] [PATCH v11 2/7] app/proc_info: add metrics displaying

From: Reshma Pattan Modify the dpdk-procinfo process to display the newly added metrics. Added new command line option "--metrics" to display metrics. Signed-off-by: Reshma Pattan Signed-off-by: Remy Horton --- app/proc_info/main.c | 79 +++- 1

[dpdk-dev] [PATCH v11 1/7] lib: add information metrics library

This patch adds a new information metrics library. This Metrics library implements a mechanism by which producers can publish numeric information for later querying by consumers. Metrics themselves are statistics that are not generated by PMDs, and hence are not reported via ethdev extended statist

[dpdk-dev] [PATCH v2] net/sfc: set multicast address list in started state only

From: Ivan Malov According to 'libefx' API requirements, one is allowed to apply multicast address list to the port in started state only, otherwise the new array should be copied to a local storage in order to be applied during the next port start Fixes: 0fa0070e4391 ("net/sfc: support multicas

Re: [dpdk-dev] [PATCH v4] eal: Support running as unprivileged user

2017-02-17 11:28, Stephen Hemminger: > On Tue, 31 Jan 2017 10:44:53 -0700 > Ben Walker wrote: > > > + if (physaddr == RTE_BAD_PHYS_ADDR) { > > RTE_LOG(ERR, EAL, > > - "Cannot open /proc/self/pagemap: %s. " > > - "virt2phys address translation will

Re: [dpdk-dev] [PATCH v4] eal: Support running as unprivileged user

2017-02-17 14:59, Sergio Gonzalez Monroy: > On 31/01/2017 17:44, Ben Walker wrote: > > For Linux kernel 4.0 and newer, the ability to obtain > > physical page frame numbers for unprivileged users from > > /proc/self/pagemap was removed. Instead, when an IOMMU > > is present, simply choose our own D

Re: [dpdk-dev] [dpdk-stable] [PATCH] net/mlx5: fix TSO TCP checksum flag

On 3/9/2017 7:17 AM, Nélio Laranjeiro wrote: > On Tue, Mar 07, 2017 at 01:47:51PM +0200, Shahaf Shuler wrote: >> Since PKT_TX_TCP_SEG implies PKT_TX_TCP_CKSUM, the PMD must force this >> flag. >> The fix applied for both tunneled and non-tunneled packets. >> >> Fixes: 19c5dc66b851 ("net/mlx5: add h

Re: [dpdk-dev] [PATCH v3 2/6] net/tap: add speed capabilities

On 3/9/2017 2:36 PM, Wiles, Keith wrote: > >> On Mar 9, 2017, at 8:18 AM, Yigit, Ferruh wrote: >> >> On 3/7/2017 4:31 PM, Pascal Mazon wrote: >>> Tap PMD is flexible, it supports any speed. >>> >>> Signed-off-by: Pascal Mazon >>> --- >>> doc/guides/nics/features/tap.ini | 1 + >>> drivers/net/ta

Re: [dpdk-dev] [dpdk-stable] [PATCH] net/sfc: set multicast address list in started state only

On 3/2/2017 2:40 PM, Andrew Rybchenko wrote: > From: Ivan Malov > > According to 'libefx' API requirements, one is allowed to > apply multicast address list to the port in started state > only, otherwise the new array should be copied to a local > storage in order to be applied during the next po

Re: [dpdk-dev] [PATCH v5 1/3] ethdev: new API to free consumed buffers in Tx ring

On Tue, Mar 7, 2017 at 11:03 AM, Thomas Monjalon wrote: > 2017-03-07 09:29, Billy McFall: > > On Mon, Feb 27, 2017 at 8:48 AM, Thomas Monjalon < > thomas.monja...@6wind.com> > > wrote: > > > I think you could use rte_errno (while keeping negative return codes). > > > > > > > I can do that if you

Re: [dpdk-dev] [ovs-dev] [PATCH] selinux: Allow creating tap devices.

Aaron Conole writes: > Daniele Di Proietto writes: > >> On 26/01/2017 12:35, "Ansis Atteka" wrote: >>> >>> >>>On 26 January 2017 at 21:24, Aaron Conole >>> wrote: >>> >>>Daniele Di Proietto writes: >>> On 25/01/2017 00:01, "Ansis Atteka" wrote: >On Jan 25, 2017 4:22 AM, "Daniel

Re: [dpdk-dev] [PATCH] eal: fix bug in x86 cmpset

2017-02-10 08:46, Stephen Hemminger: > On Fri, 10 Feb 2017 11:53:06 +0100 > Thomas Monjalon wrote: > > > 2017-02-10 10:39, Hunt, David: > > > > > > On 9/2/2017 4:53 PM, Thomas Monjalon wrote: > > > > 2016-11-06 22:09, Thomas Monjalon: > > > >> 2016-09-29 18:34, Thomas Monjalon: > > > >>> 2

Re: [dpdk-dev] [PATCH v2] lpm: extend IPv6 next hop field

2017-02-22 12:02, Bruce Richardson: > On Tue, Feb 21, 2017 at 04:46:39PM +0200, Vladyslav Buslov wrote: > > This patch extend next_hop field from 8-bits to 21-bits in LPM library > > for IPv6. > > > > Added versioning symbols to functions and updated > > library and applications that have a depend

[dpdk-dev] [PATCH v2 08/11] net/sfc: add IPV6 in flow API filters support

From: Roman Zhukov Exact match of IP protocol, source and destination addresses is supported by parser. EtherType match is enforced to IPv6 EtherType. Signed-off-by: Roman Zhukov Signed-off-by: Andrew Rybchenko Reviewed-by: Andrew Lee --- doc/guides/nics/sfc_efx.rst | 3 ++ drivers/net/sfc

[dpdk-dev] [PATCH v2 06/11] net/sfc: add VLAN in flow API filters support

From: Roman Zhukov Exact match of VLAN ID bits is supported only and required in VLAN item. Mask to match VLAN ID bits only is required, default mask to match entire TCI is not supported. Signed-off-by: Roman Zhukov Signed-off-by: Andrew Rybchenko Reviewed-by: Andrew Lee --- doc/guides/nics/

[dpdk-dev] [PATCH v2 10/11] net/sfc: add UDP in flow API filters support

From: Roman Zhukov Exact match of source and destination ports is supported by parser. IP protocol match is enforced to UDP. Signed-off-by: Roman Zhukov Signed-off-by: Andrew Rybchenko Reviewed-by: Andrew Lee --- doc/guides/nics/sfc_efx.rst | 2 ++ drivers/net/sfc/sfc_flow.c | 88 +

[dpdk-dev] [PATCH v2 07/11] net/sfc: add IPV4 in flow API filters support

From: Roman Zhukov Exact match of IP protocol, source and destination addresses is supported by parser. EtherType match is enforced to IPv4 EtherType. Signed-off-by: Roman Zhukov Signed-off-by: Andrew Rybchenko Reviewed-by: Andrew Lee --- doc/guides/nics/sfc_efx.rst | 3 ++ drivers/net/sfc/

[dpdk-dev] [PATCH v2 11/11] net/sfc: add unknown unicast/multicast match in flow API

From: Roman Zhukov Support individual/group destination address match (unknown unicast and all-multicast correspondingly in terms of firmware). Signed-off-by: Roman Zhukov Signed-off-by: Andrew Rybchenko Reviewed-by: Andrew Lee --- doc/guides/nics/sfc_efx.rst | 11 ++- drivers/net/sf

[dpdk-dev] [PATCH v2 05/11] net/sfc: add flow API filters support

From: Roman Zhukov Only pattern items VOID, ETH and actions VOID, QUEUE is now supported. Signed-off-by: Roman Zhukov Signed-off-by: Andrew Rybchenko --- doc/guides/nics/features/sfc_efx.ini | 1 + doc/guides/nics/sfc_efx.rst| 24 ++ doc/guides/rel_notes/release_17_05.rst |

[dpdk-dev] [PATCH v2 09/11] net/sfc: add TCP in flow API filters support

From: Roman Zhukov Exact match of source and destination ports is supported by parser. IP protocol match is enforced to TCP. Signed-off-by: Roman Zhukov Signed-off-by: Andrew Rybchenko Reviewed-by: Andrew Lee --- doc/guides/nics/sfc_efx.rst | 2 + drivers/net/sfc/sfc_flow.c | 89 ++

[dpdk-dev] [PATCH v2 00/11] Support flow API in Solarflare PMD

Support simple queue destination flow API filters in Solarflare libefx-based PMD including: - Ethernet source/destination, EtherType exact matching - VLAN ID exact matching including double-tagging - IPv4/6 source/destination and IP protocol exact matching - TCP/UDP source/destination exact mat

[dpdk-dev] [PATCH v2 03/11] net/sfc: implement dummy filter control callback

Just log error for all filter types and return no support indication. Signed-off-by: Andrew Rybchenko Reviewed-by: Andrew Lee Reviewed-by: Andy Moreton Reviewed-by: Robert Stonehouse --- drivers/net/sfc/sfc_ethdev.c | 49 1 file changed, 49 inserti

[dpdk-dev] [PATCH v2 01/11] net/sfc/base: split local MAC I/G back into separate flags

From: Mark Spender The flag EFX_FILTER_MATCH_LOC_MAC_IG to represent filtering on the individual/group bit of the MAC address (with the two cases being distingusished by the MAC address in the filter specification) was introduced to mirror the Linux driver filtering code, but the implementations

[dpdk-dev] [PATCH v2 02/11] net/sfc/base: improve API to get supported filter matches

From: Mark Spender The previous API had various problems, including the length of the caller provided buffer not being specified, no means being available to discover how big the buffer needs to be, and a lack of clarity of what the resulting list contains. To improve it: - add the buffer length

[dpdk-dev] [PATCH v2 04/11] net/sfc: provide a way to check if filter is supported

The information is obtained from firmware on attach. It may change after MC reboot (firmware version or variant change). Cache should be refreshed after MC reboot when it is handled properly (not yet). Signed-off-by: Andrew Rybchenko Reviewed-by: Andrew Lee Reviewed-by: Andy Moreton Reviewed-by

Re: [dpdk-dev] [PATCH 05/11] net/sfc: add flow API filters support

On 03/07/2017 04:21 PM, Ferruh Yigit wrote: On 3/2/2017 4:03 PM, Andrew Rybchenko wrote: From: Roman Zhukov Only pattern items VOID, ETH and actions VOID, QUEUE is now supported. Signed-off-by: Roman Zhukov Signed-off-by: Andrew Rybchenko <...> diff --git a/drivers/net/sfc/sfc_flow.c b/d

Re: [dpdk-dev] [PATCH v3 3/4] net/tap: add netlink back-end for flow API

On 3/7/2017 4:35 PM, Pascal Mazon wrote: > Each kernel netdevice may have queueing disciplines set for it, which > determine how to handle the packet (mostly on egress). That's part of > the TC (Traffic Control) mechanism. This is nice. qdisc is egress part of the network stack right, is there any

Re: [dpdk-dev] [PATCH v3 1/4] net/tap: move private elements to external header

On 3/7/2017 4:35 PM, Pascal Mazon wrote: > In the next patch, access to struct pmd_internals will be necessary in > tap_flow.c to store the flows. > > Signed-off-by: Pascal Mazon > Acked-by: Olga Shern > --- > drivers/net/tap/Makefile | 1 + > drivers/net/tap/rte_eth_tap.c | 34 ++

Re: [dpdk-dev] [PATCH 5/5] cfgfile: increase local buffer size for max name and value

> On Mar 9, 2017, at 9:16 AM, Legacy, Allain > wrote: > >> -Original Message- >> From: Wiles, Keith [mailto:keith.wi...@intel.com] >> Sent: Thursday, March 09, 2017 8:46 AM >> Would this change still cause a failure and memory over write if the user >> decides to have very large string.

Re: [dpdk-dev] [PATCH 5/5] cfgfile: increase local buffer size for max name and value

> -Original Message- > From: Wiles, Keith [mailto:keith.wi...@intel.com] > Sent: Thursday, March 09, 2017 8:46 AM > Would this change still cause a failure and memory over write if the user > decides to have very large string. Does the code check the lengths to make > sure they are valid an

Re: [dpdk-dev] [PATCH v3 08/16] net/avp: device initialization

> -Original Message- > From: Legacy, Allain > > From: Chas Williams [mailto:3ch...@gmail.com] > > I don't see the other side of this to unregister the callback. It's also a > > bit > > confusing with this here and the other parts in part 15. It looks like you > > enable the interrupts on

Re: [dpdk-dev] [RFC PATCH] net/virtio: Align Virtio-net header on cache line in receive path

On 03/08/2017 07:01 AM, Yao, Lei A wrote: -Original Message- From: Maxime Coquelin [mailto:maxime.coque...@redhat.com] Sent: Monday, March 6, 2017 10:11 PM To: Yuanhan Liu Cc: Liang, Cunming ; Tan, Jianfeng ; dev@dpdk.org; Wang, Zhihong ; Yao, Lei A Subject: Re: [RFC PATCH] net/vir

Re: [dpdk-dev] [PATCH v3 2/6] net/tap: add speed capabilities

> On Mar 9, 2017, at 8:18 AM, Yigit, Ferruh wrote: > > On 3/7/2017 4:31 PM, Pascal Mazon wrote: >> Tap PMD is flexible, it supports any speed. >> >> Signed-off-by: Pascal Mazon >> --- >> doc/guides/nics/features/tap.ini | 1 + >> drivers/net/tap/rte_eth_tap.c| 35 ++

Re: [dpdk-dev] [PATCH v3 5/6] net/tap: add packet type management

On 3/7/2017 4:31 PM, Pascal Mazon wrote: > Advertize RTE_PTYPE_UNKNOWN since tap does not report any packet type. > > Signed-off-by: Pascal Mazon > --- > doc/guides/nics/features/tap.ini | 1 + > drivers/net/tap/rte_eth_tap.c| 15 +++ > 2 files changed, 16 insertions(+) > > dif

Re: [dpdk-dev] [PATCH v3 2/6] net/tap: add speed capabilities

On 3/7/2017 4:31 PM, Pascal Mazon wrote: > Tap PMD is flexible, it supports any speed. > > Signed-off-by: Pascal Mazon > --- > doc/guides/nics/features/tap.ini | 1 + > drivers/net/tap/rte_eth_tap.c| 35 +++ > 2 files changed, 36 insertions(+) > > diff --git

Re: [dpdk-dev] [PATCH v3 1/6] net/tap: add MAC address management ops

On 3/7/2017 4:31 PM, Pascal Mazon wrote: > Set a random MAC address when probing the device, as to not leave an > empty MAC in pmd->eth_addr. > > This MAC will be set on the tap netdevice as soon as it's been created > using tun_alloc(). As the tap_mac_add() function depend on the fd in > the firs

Re: [dpdk-dev] [PATCH v3 08/16] net/avp: device initialization

> -Original Message- > From: Chas Williams [mailto:3ch...@gmail.com] > I don't see the other side of this to unregister the callback. It's also a > bit > confusing with this here and the other parts in part 15. It looks like you > enable the interrupts on .dev_create but disable on .dev_

Re: [dpdk-dev] ip_pipeline firewall customization

My mistake, arp packets are hit by pipeline>p 1 firewall add priority 1 ipv4 0.0.0.0 0 0.0.0.0 0 0 65535 0 65535 0 0 port 0 ACL as anything and rightly so gets matched for above fields. Only way is to somehow avoid ARP packets being input to table itself, and yes one way is to direct them to a se

Re: [dpdk-dev] [PATCH v3 15/16] net/avp: device start and stop operations

> -Original Message- > From: Stephen Hemminger [mailto:step...@networkplumber.org] > > The second goto is unnecessary. Ok. Will remove.

Re: [dpdk-dev] [PATCH v3 13/16] net/avp: device statistics operations

> -Original Message- > From: Stephen Hemminger [mailto:step...@networkplumber.org] > Memset here is unnecessary since only caller is rte_eth_stats_get() which > already did memset > Ok. Will remove.

Re: [dpdk-dev] [PATCH 3/3] net/i40e: enable cloud filter for MPLS

Hi Beilei, > > > > > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Beilei Xing > > > > > Sent: Friday, March 3, 2017 9:44 AM > > > > > To: Wu, Jingjing > > > > > Cc: Zhang, Helin ; dev@dpdk.org > > > > > Subject: [dpdk-dev] [PATCH 3/3] net/i40e: enable cloud filter > > > > > for MPLS > >

Re: [dpdk-dev] [PATCH 5/5] cfgfile: increase local buffer size for max name and value

> On Mar 2, 2017, at 1:29 PM, Allain Legacy wrote: > > From: Joseph Richard > > When parsing a ini file with a "key = value" line that has both "key" and > "value" sized to the maximum allowed length causes a parsing failure. The > internal "buffer" variable should be sized at least as large

Re: [dpdk-dev] [PATCH] vhost: add back support for concurrent enqueue

2016-08-23 15:42, Rich Lane: > On Mon, Aug 22, 2016 at 7:16 AM, Yuanhan Liu > wrote: > > On Thu, Aug 18, 2016 at 11:27:06AM -0700, Rich Lane wrote: > > > I could also add back concurrent enqueue support for mergeable RX, but I > > > was hoping to avoid that since the mergeable codepath is already

Re: [dpdk-dev] [PATCH 0/4] net/bonding: bonding and LACP fixes

2017-02-08 18:14, Thomas Monjalon: > 2016-08-01 16:42, Robert Sanford: > > In this patch series, we fix two bonding driver bugs and > > enhance testpmd so that bonding mode 4 (LACP) ports remain > > operational even when idle. > > These patches are blocked because we are waiting a v2. > > Waiting

[dpdk-dev] [PATCH v2 4/6] cfgfile: use strnlen to constrain memchr search

The call to memchr() uses the absolute length of the string buffer instead of the actual length of the string returned by fgets(). This causes the search to go beyond the '\n' character and find ';' characters in random garbage on the stack. This then causes the 'len' variable to be updated and t

[dpdk-dev] [PATCH v2 5/6] cfgfile: increase local buffer size for max name and value

From: Joseph Richard When parsing a ini file with a "key = value" line that has both "key" and "value" sized to the maximum allowed length causes a parsing failure. The internal "buffer" variable should be sized at least as large as the maximum for both fields. This commit updates the local arr

[dpdk-dev] [PATCH v2 6/6] cfgfile: add support for empty value string

This commit adds support to the cfgfile library for parsing a key=value line that has no value string specified (e.g., "key="). This can be used to override a configuration attribute that has a default value or default list of values to set it back to an undefined value to disable functionality.

Re: [dpdk-dev] [PATCH] doc: add details on requirements for patch ack and merge

2017-02-21 16:16, Mcnamara, John: > From: Bruce Richardson > > > > Add to the contributors guide the requirements and guidelines for getting > > patches acked and merged. It details at what point the review comments and > > the ack's need to be received in order to have a given patch merged into a

[dpdk-dev] [PATCH v2 2/6] cfgfile: add support for unamed global section

The current implementation of the cfgfile library requires that all key=value pairs be within [SECTION] definitions. The ini file standard allows for key=value pairs in an unnamed section. https://en.wikipedia.org/wiki/INI_file#Global_properties This commit adds the capability of parsing key=

[dpdk-dev] [PATCH v2 3/6] cfgfile: configurable comment character

The current cfgfile comment character is hardcoded to ';'. This commit a new API to allow the user to specify which comment character to use while parsing the file. This is to ease adoption by applications that have an existing configuration file which may use a different comment character. For

  1   2   >