Re: [dpdk-dev] [PATCH v3 08/16] net/avp: device initialization

[Legacy, Allain]

> -----Original Message-----
> From: Chas Williams [mailto:3ch...@gmail.com]
> I don't see the other side of this to unregister the callback.  It's also a 
> bit
> confusing with this here and the other parts in part 15.  It looks like you
> enable the interrupts on .dev_create but disable on .dev_stop?
> If that's the case, you likely want to just do the setup here and the enable 
> in
> .dev_start.
Agreed.  This is not symmetric.  I will setup in create, enable in start, 
disable in stop.