[dpdk-dev] [PATCH 2/2] app/test: add ZUC EEA3 test cases to QAT test suite

2017-02-28 Thread Arek Kusztal
This patch adds ZUC EEA3 cipher test cases to Intel(R) QuickAssist Technology crypto test suite Signed-off-by: Arek Kusztal --- app/test/test_cryptodev.c | 12 1 file changed, 12 insertions(+) diff --git a/app/test/test_cryptodev.c b/app/test/test_cryptodev.c index 357a92e..45ddd35

[dpdk-dev] [PATCH 1/2] crypto/qat: add ZUC EEA3 cipher capability

2017-02-28 Thread Arek Kusztal
This commit adds ZUC EEA3 cipher capability to Intel(R) QuickAssist Technology driver Signed-off-by: Arek Kusztal --- doc/guides/cryptodevs/qat.rst| 2 + drivers/crypto/qat/qat_adf/qat_algs.h| 11 ++- drivers/crypto/qat/qat_adf/qat_algs_build_desc.c | 97

[dpdk-dev] [PATCH 0/2] Add ZUC EEA3 capability to Intel(R) QuickAssist Technology driver

2017-02-28 Thread Arek Kusztal
This patchset add ZUC EEA3 stream cipher capability to Intel(R) QuickAssist Technology driver and corresponding test cases to QAT test suite Arek Kusztal (2): crypto/qat: add ZUC EEA3 cipher capability app/test: add ZUC EEA3 test cases to QAT test suite app/test/test_cryptodev.c

Re: [dpdk-dev] [PATCH 0/7] virtio/vhost: Add MTU feature support

2017-02-28 Thread Maxime Coquelin
On 02/23/2017 08:10 AM, Yuanhan Liu wrote: On Mon, Feb 13, 2017 at 03:28:13PM +0100, Maxime Coquelin wrote: This series adds support to new Virtio's MTU feature[1]. Seems you missed a link here? Oops, I meant this link: https://www.spinics.net/lists/linux-virtualization/msg28908.html Will

Re: [dpdk-dev] [RFC PATCH] net/virtio: Align Virtio-net header on cache line in receive path

2017-02-28 Thread Maxime Coquelin
On 02/23/2017 06:49 AM, Yuanhan Liu wrote: On Wed, Feb 22, 2017 at 10:36:36AM +0100, Maxime Coquelin wrote: On 02/22/2017 02:37 AM, Yuanhan Liu wrote: On Tue, Feb 21, 2017 at 06:32:43PM +0100, Maxime Coquelin wrote: This patch aligns the Virtio-net header on a cache-line boundary to optimi

Re: [dpdk-dev] What is the max size of packets rte_eth_tx_burst() can send practically/theoritically?

2017-02-28 Thread Stephen Hemminger
On Tue, 28 Feb 2017 20:28:21 -0800 Joo Kim wrote: > Hello, > > > For example, as I understand, ovs-dpdk code uses a buffer of size 32 > when it transmits via rte_eth_tx_burst(). > > I think it can transmit more packets in a bust. > I know there should be a balance between throughput and late

Re: [dpdk-dev] net/bonding - need for 8023ad slave to be in promisc mode

2017-02-28 Thread sujith sankar
Hi Declan, Got your name from the maintainers' list. Could you please help me with this? Thanks, -Sujith On Mon, Feb 27, 2017 at 1:40 PM, sujith sankar wrote: > Hi folks, > > Could someone clarify the need to put mode 4 bonding slaves in promiscuous > mode? > > 840 void > 841 bond_mode_8023ad_a

[dpdk-dev] [PATCH 9/9] net/ixgbe/base: update readme

2017-02-28 Thread Wenzhuo Lu
Signed-off-by: Wenzhuo Lu --- doc/guides/rel_notes/release_17_05.rst | 8 drivers/net/ixgbe/base/README | 4 ++-- 2 files changed, 10 insertions(+), 2 deletions(-) diff --git a/doc/guides/rel_notes/release_17_05.rst b/doc/guides/rel_notes/release_17_05.rst index e25ea9f..ab87e

[dpdk-dev] [PATCH 8/9] net/ixgbe/base: fix build error

2017-02-28 Thread Wenzhuo Lu
Fix ICC build error by removing the EWARN third parameter. Signed-off-by: Wenzhuo Lu --- drivers/net/ixgbe/base/ixgbe_phy.c | 23 ++- 1 file changed, 2 insertions(+), 21 deletions(-) diff --git a/drivers/net/ixgbe/base/ixgbe_phy.c b/drivers/net/ixgbe/base/ixgbe_phy.c index

[dpdk-dev] [PATCH 6/9] net/ixgbe/base: disable FC for 15B0

2017-02-28 Thread Wenzhuo Lu
Make sure that ixgbe_device_supports_autoneg_fc() returns false and hw->fc.disable_fc_autoneg is set to true to avoid running the fc_autoneg function for the device 15B0, as this device doesn't support this function. Signed-off-by: Wenzhuo Lu --- drivers/net/ixgbe/base/ixgbe_common.c | 5 -

[dpdk-dev] [PATCH 7/9] net/ixgbe: support xcast promisc mode

2017-02-28 Thread Wenzhuo Lu
Add the support of xcast promiscuous mode. It's added in mailbox v1.3. Move the definition of xcast mode to base code. Signed-off-by: Wenzhuo Lu --- drivers/net/ixgbe/base/ixgbe_mbx.h | 8 drivers/net/ixgbe/base/ixgbe_vf.c | 4 drivers/net/ixgbe/ixgbe_ethdev.c | 6 -- 3 file

[dpdk-dev] [PATCH 4/9] net/ixgbe/base: add bit for enabling L3/L4 filtering

2017-02-28 Thread Wenzhuo Lu
Add a L3/L4 filtering definition of register MRQC for the future use. Signed-off-by: Wenzhuo Lu --- drivers/net/ixgbe/base/ixgbe_type.h | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ixgbe/base/ixgbe_type.h b/drivers/net/ixgbe/base/ixgbe_type.h index bb1f85b..6acd966 100644 ---

[dpdk-dev] [PATCH 5/9] net/ixgbe/base: complete hw init when SFP not present

2017-02-28 Thread Wenzhuo Lu
If SFP module is not present, reset_hw doesn't return success. SW should complete the initialization, or with specific module it resulted in no link when the module was later inserted. Signed-off-by: Wenzhuo Lu --- drivers/net/ixgbe/base/ixgbe_common.c | 2 +- 1 file changed, 1 insertion(+), 1 d

[dpdk-dev] [PATCH 1/9] net/ixgbe/base: make a debug message simple

2017-02-28 Thread Wenzhuo Lu
The debug message is too long. Make it shorter. Signed-off-by: Wenzhuo Lu --- drivers/net/ixgbe/base/ixgbe_x550.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ixgbe/base/ixgbe_x550.c b/drivers/net/ixgbe/base/ixgbe_x550.c index 6f9c034..cf72bba 100644 --- a/dri

[dpdk-dev] [PATCH 3/9] net/ixgbe/base: add link block check for KR

2017-02-28 Thread Wenzhuo Lu
When setting up link on x550 KR devices, should check if there're constraints on link from manageability, which may result in link loss. Signed-off-by: Wenzhuo Lu --- drivers/net/ixgbe/base/ixgbe_x550.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/ixgbe/base/ixgbe_x550.c b

[dpdk-dev] [PATCH 2/9] net/ixgbe/base: remove X550em SFP iXFI setup

2017-02-28 Thread Wenzhuo Lu
Removes X550em SFP iXFI setup since there is no released HW production with SFP iXFI. Signed-off-by: Wenzhuo Lu --- drivers/net/ixgbe/base/ixgbe_x550.c | 57 +++-- 1 file changed, 11 insertions(+), 46 deletions(-) diff --git a/drivers/net/ixgbe/base/ixgbe_x550.c

[dpdk-dev] [PATCH 0/9] Update ixgbe base driver

2017-02-28 Thread Wenzhuo Lu
Some minor changes and fixes, including, link block check for KR, complete HW initialization even if SFP is not present, add VF xcast promiscuous mode. Wenzhuo Lu (9): net/ixgbe/base: make a debug message simple net/ixgbe/base: remove X550em SFP iXFI setup net/ixgbe/base: add link block chec

[dpdk-dev] [PATCH 1/2] net/mlx5: add enhanced multi-packet send for ConnectX-5

2017-02-28 Thread Yongseok Koh
ConnectX-5 supports enhanced version of multi-packet send (MPS). An MPS Tx descriptor can carry multiple packets either by including pointers of packets or by inlining packets. Inlining packet data can be helpful to better utilize PCIe bandwidth. In addition, Enhanced MPS supports hybrid mode - mix

[dpdk-dev] [PATCH 2/2] doc: update PMD options for mlx5

2017-02-28 Thread Yongseok Koh
Enhanced multi-packet send mode is newly introduced for ConnectX-5 families of adaptors. Signed-off-by: Yongseok Koh --- doc/guides/nics/mlx5.rst | 32 1 file changed, 28 insertions(+), 4 deletions(-) diff --git a/doc/guides/nics/mlx5.rst b/doc/guides/nics/mlx5.

[dpdk-dev] [PATCH 0/2] net/mlx5: add enhanced multi-packet send for ConnectX-5

2017-02-28 Thread Yongseok Koh
This patch set is to add the Enhanced Multi-Packet Send feature which is newly introduced for ConnectX-5 families of adaptors. Yongseok Koh (2): net/mlx5: add enhanced multi-packet send for ConnectX-5 doc: update PMD options for mlx5 doc/guides/nics/mlx5.rst | 32 +++- drivers/net/mlx

[dpdk-dev] What is the max size of packets rte_eth_tx_burst() can send practically/theoritically?

2017-02-28 Thread Joo Kim
Hello, For example, as I understand, ovs-dpdk code uses a buffer of size 32 when it transmits via rte_eth_tx_burst(). I think it can transmit more packets in a bust. I know there should be a balance between throughput and latency. But, I am wondering what max size packets a dpdk application c

Re: [dpdk-dev] [RFC 0/8] mbuf: structure reorganization

2017-02-28 Thread Ananyev, Konstantin
> -Original Message- > From: Olivier Matz [mailto:olivier.m...@6wind.com] > Sent: Tuesday, February 28, 2017 12:28 PM > To: Ananyev, Konstantin > Cc: Jan Blunck ; Richardson, Bruce > ; dev@dpdk.org > Subject: Re: [dpdk-dev] [RFC 0/8] mbuf: structure reorganization > > On Tue, 28 Feb 20

Re: [dpdk-dev] [ovs-dev] [PATCH] selinux: Allow creating tap devices.

2017-02-28 Thread Aaron Conole
Daniele Di Proietto writes: > On 26/01/2017 12:35, "Ansis Atteka" wrote: >> >> >>On 26 January 2017 at 21:24, Aaron Conole >> wrote: >> >>Daniele Di Proietto writes: >> >>> On 25/01/2017 00:01, "Ansis Atteka" wrote: >>> On Jan 25, 2017 4:22 AM, "Daniele Di Proietto" wrote:

[dpdk-dev] [PATCH v6 26/26] rte_eal_init: add info about various error codes

2017-02-28 Thread Aaron Conole
The rte_eal_init function will now pass failure reason hints to the application. To help app developers deciper this, add some brief information about what the codes are indicating. Signed-off-by: Aaron Conole Acked-by: Bruce Richardson --- lib/librte_eal/common/include/rte_eal.h | 27

[dpdk-dev] [PATCH v6 23/26] eal: do not panic (or abort) if vdev init fails

2017-02-28 Thread Aaron Conole
Seems like it's possible to continue. At least, the error is reflected properly in the logs. A user could then go and correct or investigate the situation. Signed-off-by: Aaron Conole Acked-by: Bruce Richardson --- lib/librte_eal/linuxapp/eal/eal.c | 2 +- 1 file changed, 1 insertion(+), 1 de

[dpdk-dev] [PATCH v6 25/26] eal: do not panic on failed bus scan

2017-02-28 Thread Aaron Conole
For now, do an abort. It's likely that even aborting the initialization is premature in this case, as it may be possible to proceed even if one bus or another is not available. Signed-off-by: Aaron Conole Acked-by: Bruce Richardson --- lib/librte_eal/linuxapp/eal/eal.c | 7 +-- 1 file chan

[dpdk-dev] [PATCH v6 24/26] eal: do not panic when bus probe fails

2017-02-28 Thread Aaron Conole
Signed-off-by: Aaron Conole Acked-by: Bruce Richardson --- lib/librte_eal/linuxapp/eal/eal.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/lib/librte_eal/linuxapp/eal/eal.c b/lib/librte_eal/linuxapp/eal/eal.c index ddc50f2..8274196 100644 --- a/lib/librte_eal/linuxa

[dpdk-dev] [PATCH v6 22/26] eal_common_dev: continue initializing vdevs

2017-02-28 Thread Aaron Conole
Even if one vdev should fail, there's no need to prevent further processing. Log the error, and reflect it to the higher levels to decide. Signed-off-by: Aaron Conole Acked-by: Bruce Richardson --- lib/librte_eal/common/eal_common_dev.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-

[dpdk-dev] [PATCH v6 21/26] eal: do not panic on failed PCI-probe

2017-02-28 Thread Aaron Conole
Since PCI isn't neccessarily required, it may be possible to simply log the error and continue on letting the user check the logs and restart the application when things have failed. Signed-off-by: Aaron Conole Acked-by: Bruce Richardson --- lib/librte_eal/linuxapp/eal/eal.c | 7 +-- 1 file

[dpdk-dev] [PATCH v6 20/26] eal_pci: continue probing even on failures

2017-02-28 Thread Aaron Conole
Some devices may be inaccessible for a variety of reasons, or the PCI-bus may be unavailable causing the whole thing to fail. Still, better to continue attempts at probes. Signed-off-by: Aaron Conole Acked-by: Bruce Richardson --- lib/librte_eal/common/eal_common_pci.c | 15 ++- 1

[dpdk-dev] [PATCH v6 19/26] eal: do not error if plugins fail to init

2017-02-28 Thread Aaron Conole
Plugins are useful and important. However, it seems crazy to abort everything just because they don't initialize properly. Signed-off-by: Aaron Conole Acked-by: Bruce Richardson --- lib/librte_eal/linuxapp/eal/eal.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/librte

[dpdk-dev] [PATCH v6 18/26] eal: do not panic on interrupt thread init

2017-02-28 Thread Aaron Conole
When initializing the interrupt thread, there are a number of possible reasons for failure - some of which are correctable by the application. Do not panic() needlessly, and give the application a change to reflect this information to the user. Signed-off-by: Aaron Conole Acked-by: Bruce Richards

[dpdk-dev] [PATCH v6 17/26] eal: change the private pipe call to reflect errno

2017-02-28 Thread Aaron Conole
There could be some confusion as to why the call failed - this change will always reflect the value of the error in rte_error. Signed-off-by: Aaron Conole Acked-by: Bruce Richardson --- lib/librte_eal/linuxapp/eal/eal_interrupts.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff

[dpdk-dev] [PATCH v6 16/26] eal: convert timer init not to call panic

2017-02-28 Thread Aaron Conole
After code inspection, there is no way for eal_timer_init() to fail. It simply returns 0 in all cases. As such, this test could either go-away or stay here as 'future-proofing'. Signed-off-by: Aaron Conole Acked-by: Bruce Richardson --- lib/librte_eal/linuxapp/eal/eal.c | 7 +-- 1 file ch

[dpdk-dev] [PATCH v6 15/26] eal: do not panic on alarm init

2017-02-28 Thread Aaron Conole
rte_eal_alarm_init() call uses the linux timerfd framework to create a poll()-able timer using standard posix file operations. This could fail for a few reasons given in the man-pages, but many could be corrected by the user application. No need to panic. Signed-off-by: Aaron Conole Acked-by: B

[dpdk-dev] [PATCH v6 14/26] eal: do not panic on tailq init

2017-02-28 Thread Aaron Conole
There are some theoretical racy conditions in the system that _could_ cause early tailq init to fail; however, no need to panic the application. While it can't continue using DPDK, it could make better alerts to the user. Signed-off-by: Aaron Conole Acked-by: Bruce Richardson --- lib/librte_e

[dpdk-dev] [PATCH v6 13/26] eal: do not panic on memory init

2017-02-28 Thread Aaron Conole
This can only happen when access to hugepages (either as primary or secondary process) fails (and that is usually permissions). Since the manner of failure is not reversible, we cannot allow retry. Signed-off-by: Aaron Conole Acked-by: Bruce Richardson --- lib/librte_eal/linuxapp/eal/eal.c | 7

[dpdk-dev] [PATCH v6 12/26] eal: do not panic on vfio failure

2017-02-28 Thread Aaron Conole
Signed-off-by: Aaron Conole Acked-by: Bruce Richardson --- lib/librte_eal/linuxapp/eal/eal.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/lib/librte_eal/linuxapp/eal/eal.c b/lib/librte_eal/linuxapp/eal/eal.c index d5ef7b5..10eefd3 100644 --- a/lib/librte_eal/linux

[dpdk-dev] [PATCH v6 11/26] eal: do not panic on PCI-probe

2017-02-28 Thread Aaron Conole
This will usually be an issue because of permissions. However, it could also be caused by OOM. In either case, errno will contain the underlying cause. It is safe to re-init the system here, so allow the application to take corrective action and reinit. Signed-off-by: Aaron Conole Acked-by: Br

[dpdk-dev] [PATCH v6 09/26] eal: set errno when exiting for already called

2017-02-28 Thread Aaron Conole
Signed-off-by: Aaron Conole Acked-by: Bruce Richardson --- lib/librte_eal/linuxapp/eal/eal.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/lib/librte_eal/linuxapp/eal/eal.c b/lib/librte_eal/linuxapp/eal/eal.c index 5a92b28..564cac3 100644 --- a/lib/librte_eal/linuxapp/

[dpdk-dev] [PATCH v6 10/26] eal: do not panic on log failures

2017-02-28 Thread Aaron Conole
When log initialization fails, it's generally because the fopencookie failed. While this is rare in practice, it could happen, and it is likely because of memory pressure. So, flag the error, and allow the user to retry. Signed-off-by: Aaron Conole Acked-by: Bruce Richardson --- lib/librte_ea

[dpdk-dev] [PATCH v6 08/26] eal: do not panic on memzone initialization fails

2017-02-28 Thread Aaron Conole
When memzone initialization fails, report the error to the calling application rather than panic(). Without a good way of detaching / releasing hugepages, at this point the application will have to restart. Signed-off-by: Aaron Conole Acked-by: Bruce Richardson --- lib/librte_eal/linuxapp/eal/

[dpdk-dev] [PATCH v6 07/26] eal: do not panic when CPU isn't supported

2017-02-28 Thread Aaron Conole
It's now possible to gracefully exit the application, or for applications which support non-dpdk datapaths working in concert with DPDK datapaths, there no longer is the possibility of exiting for unsupported CPUs. Signed-off-by: Aaron Conole Acked-by: Bruce Richardson --- lib/librte_eal/linuxa

[dpdk-dev] [PATCH v6 06/26] eal-common: introduce a way to query cpu support

2017-02-28 Thread Aaron Conole
This adds a new API to check for the eal cpu versions. Signed-off-by: Aaron Conole Acked-by: Bruce Richardson --- lib/librte_eal/common/eal_common_cpuflags.c | 13 +++-- lib/librte_eal/common/include/generic/rte_cpuflags.h | 8 2 files changed, 19 insertions(+), 2 del

[dpdk-dev] [PATCH v6 05/26] eal: do not panic if parsing args returns error

2017-02-28 Thread Aaron Conole
It's possible that the application could take a corrective action here, and either prompt the user for different arguments, or at least perform a better logging. Exiting this early prevents any useful information gathering from the application layer. Signed-off-by: Aaron Conole Acked-by: Bruce R

[dpdk-dev] [PATCH v6 04/26] eal: do not panic on failed hugepage query

2017-02-28 Thread Aaron Conole
If we fail to acquire hugepage information, simply signal an error to the application. This clears the run_once counter, allowing the user or application to take a corrective action and retry. Signed-off-by: Aaron Conole Acked-by: Bruce Richardson --- lib/librte_eal/linuxapp/eal/eal.c | 8

[dpdk-dev] [PATCH v6 03/26] eal: do not panic on hugepage info init

2017-02-28 Thread Aaron Conole
When attempting to scan hugepages, signal to the eal that an error has occurred, rather than performing a panic. Signed-off-by: Aaron Conole Acked-by: Bruce Richardson --- lib/librte_eal/linuxapp/eal/eal_hugepage_info.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git

[dpdk-dev] [PATCH v6 02/26] eal: return error instead of panic for cpu init

2017-02-28 Thread Aaron Conole
There may be no way to gracefully recover, but the application should be notified that a failure happened, rather than completely aborting. This allows the user to proceed with a "slow-path" type solution. Signed-off-by: Aaron Conole Acked-by: Bruce Richardson --- lib/librte_eal/linuxapp/eal/e

[dpdk-dev] [PATCH v6 01/26] eal: cpu init will no longer panic

2017-02-28 Thread Aaron Conole
After this change, the EAL CPU NUMA node resolution step can no longer emit an rte_panic. This aligns with the code in rte_eal_init, which expects failures to return an error code. Signed-off-by: Aaron Conole Acked-by: Bruce Richardson --- lib/librte_eal/common/eal_common_lcore.c | 7 ---

[dpdk-dev] [PATCH v6 00/26] linux/eal: Remove most causes of panic on init

2017-02-28 Thread Aaron Conole
From: Aaron Conole In many cases, it's enough to simply let the application know that the call to initialize DPDK has failed. A complete halt can then be decided by the application based on error returned (and the app could even attempt a possible re-attempt after some corrective action by the u

Re: [dpdk-dev] [PATCH v1 01/14] ring: remove split cacheline build setting

2017-02-28 Thread Jerin Jacob
On Tue, Feb 28, 2017 at 01:52:26PM +, Bruce Richardson wrote: > On Tue, Feb 28, 2017 at 05:38:34PM +0530, Jerin Jacob wrote: > > On Tue, Feb 28, 2017 at 11:57:03AM +, Bruce Richardson wrote: > > > On Tue, Feb 28, 2017 at 05:05:13PM +0530, Jerin Jacob wrote: > > > > On Thu, Feb 23, 2017 at 0

Re: [dpdk-dev] [PATCH] app/testpmd: Fix typos

2017-02-28 Thread Mcnamara, John
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Nirmoy Das > Sent: Monday, February 27, 2017 7:24 PM > To: dev@dpdk.org > Cc: Nirmoy Das > Subject: [dpdk-dev] [PATCH] app/testpmd: Fix typos > > fixes trivial typos in app/test-pmd/cmdline.c, app/test-pmd/icmpec

Re: [dpdk-dev] [PATCH v5] doc: use corelist instead of coremask

2017-02-28 Thread Mcnamara, John
> -Original Message- > From: Wiles, Keith > Sent: Monday, February 27, 2017 7:14 PM > To: dev@dpdk.org > Cc: iryz...@nfware.com; thomas.monja...@6wind.com; Mcnamara, John > > Subject: [PATCH v5] doc: use corelist instead of coremask > > The coremask option in DPDK is difficult to use an

Re: [dpdk-dev] [PATCH 1/3] mk: clean .lib.cmd files

2017-02-28 Thread Thomas Monjalon
> Signed-off-by: Ferruh Yigit > --- > mk/rte.lib.mk | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Series merged and applied as one commit, thanks

[dpdk-dev] [PATCH 0/2] net/mlx5: add Tx offloads for tunneled packets

2017-02-28 Thread Shahaf Shuler
This patchset adds support for hardware TX offloads for tunneled packets. [PATCH 1/2] net/mlx5: add hardware checksum offload for tunnel [PATCH 2/2] net/mlx5: add hardware TSO support for VXLAN and GRE

[dpdk-dev] [PATCH 1/2] net/mlx5: add hardware checksum offload for tunnel packets

2017-02-28 Thread Shahaf Shuler
Prior to this commit Tx checksum offload was supported only for the inner headers. This commit adds support for the hardware to compute the checksum for the outer headers as well. The support is for tunneling protocols GRE and VXLAN. Signed-off-by: Shahaf Shuler --- doc/guides/nics/features/mlx

[dpdk-dev] [PATCH 2/2] net/mlx5: add hardware TSO support for VXLAN and GRE

2017-02-28 Thread Shahaf Shuler
This commit adds support for hardware TSO for tunneled packets. Signed-off-by: Shahaf Shuler --- drivers/net/mlx5/mlx5_ethdev.c | 4 +++- drivers/net/mlx5/mlx5_rxtx.c | 9 + 2 files changed, 12 insertions(+), 1 deletion(-) diff --git a/drivers/net/mlx5/mlx5_ethdev.c b/drivers/net/mlx5

Re: [dpdk-dev] [PATCH v2 1/5] test: move tests to separate folder

2017-02-28 Thread Thomas Monjalon
2017-02-16 14:57, Ferruh Yigit: > This is to logically group unit tests into their own folder, > separating them from "app" folder. > > Hopefully this will make the unit test in DPDK more visible. > > Following binaries moved to "test" folder: > cmdline-test > test-acl > test-pipeline > test

Re: [dpdk-dev] [RFC 3/8] mbuf: set mbuf fields while in pool

2017-02-28 Thread Olivier Matz
Hi Bruce, On Tue, 24 Jan 2017 15:50:49 +, Bruce Richardson wrote: > On Tue, Jan 24, 2017 at 04:19:28PM +0100, Olivier Matz wrote: > > Set the value of m->refcnt to 1, m->nb_segs to 1 and m->next > > to NULL when the mbuf is stored inside the mempool (unused). > > This is done in rte_pktmbuf_p

Re: [dpdk-dev] Pktgen-DPDK build errors on ppc64le

2017-02-28 Thread Wiles, Keith
> On Feb 28, 2017, at 2:48 AM, Rahul Lakkireddy > wrote: > > Hi All, > > We are seeing Pktgen-DPDK not building on ppc64le with latest dpdk git > repo. Yes, it looks like Pktgen needs to change to account for 256 cores. It is using uint8_t and needs to change to uint16_t variables. I can onl

Re: [dpdk-dev] [PATCH v5 03/26] eal: No panic on hugepages info init

2017-02-28 Thread Aaron Conole
Bruce Richardson writes: > On Mon, Feb 27, 2017 at 11:17:48AM -0500, Aaron Conole wrote: >> When attempting to scan hugepages, signal to the eal.c that an error has >> occurred, rather than performing a panic. >> >> Signed-off-by: Aaron Conole >> --- >> lib/librte_eal/linuxapp/eal/eal_hugepage

Re: [dpdk-dev] [PATCH v5 08/26] eal: do not panic on memzone initialization fails

2017-02-28 Thread Aaron Conole
Bruce Richardson writes: > On Mon, Feb 27, 2017 at 11:17:53AM -0500, Aaron Conole wrote: >> When memzone initialization fails, report the error to the calling >> application rather than panic(). Without a good way of detaching / >> releasing hugepages, at this point the application will have to

Re: [dpdk-dev] [PATCH v5 00/26] linux/eal: Remove most causes of panic on init

2017-02-28 Thread Bruce Richardson
On Mon, Feb 27, 2017 at 11:17:45AM -0500, Aaron Conole wrote: > In many cases, it's enough to simply let the application know that the > call to initialize DPDK has failed. A complete halt can then be > decided by the application based on error returned (and the app could > even attempt a possible

Re: [dpdk-dev] [PATCH v5 08/26] eal: do not panic on memzone initialization fails

2017-02-28 Thread Bruce Richardson
On Mon, Feb 27, 2017 at 11:17:53AM -0500, Aaron Conole wrote: > When memzone initialization fails, report the error to the calling > application rather than panic(). Without a good way of detaching / > releasing hugepages, at this point the application will have to restart. > > Signed-off-by: Aar

Re: [dpdk-dev] [PATCH v5 03/26] eal: No panic on hugepages info init

2017-02-28 Thread Bruce Richardson
On Mon, Feb 27, 2017 at 11:17:48AM -0500, Aaron Conole wrote: > When attempting to scan hugepages, signal to the eal.c that an error has > occurred, rather than performing a panic. > > Signed-off-by: Aaron Conole > --- > lib/librte_eal/linuxapp/eal/eal_hugepage_info.c | 6 -- > 1 file change

Re: [dpdk-dev] [PATCH v2 0/4] New crypto algorithm string parser API

2017-02-28 Thread De Lara Guarch, Pablo
> -Original Message- > From: De Lara Guarch, Pablo > Sent: Monday, February 27, 2017 2:39 PM > To: Doherty, Declan > Cc: dev@dpdk.org; De Lara Guarch, Pablo > Subject: [PATCH v2 0/4] New crypto algorithm string parser API > > Last release, an array with strings for the supported algorith

Re: [dpdk-dev] [PATCH v2] tools: add tags and cscope index file generation support

2017-02-28 Thread Jerin Jacob
On Mon, Feb 27, 2017 at 03:18:52PM +0100, Thomas Monjalon wrote: > 2017-01-17 14:11, Jerin Jacob: > > This script generates cscope, gtags, and tags > > index files based on EAL environment. > > (architecture and OS(linux/bsd)) > > > > Selection of the architecture and OS environment > > is based o

Re: [dpdk-dev] [PATCH v1 01/14] ring: remove split cacheline build setting

2017-02-28 Thread Bruce Richardson
On Tue, Feb 28, 2017 at 05:38:34PM +0530, Jerin Jacob wrote: > On Tue, Feb 28, 2017 at 11:57:03AM +, Bruce Richardson wrote: > > On Tue, Feb 28, 2017 at 05:05:13PM +0530, Jerin Jacob wrote: > > > On Thu, Feb 23, 2017 at 05:23:54PM +, Bruce Richardson wrote: > > > > Users compiling DPDK shou

[dpdk-dev] [PATCH] net/ixgbe: remove invalid declaration

2017-02-28 Thread Olivier Matz
The function is not defined anywhere, remove it. Fixes: 0eb609239efd ("ixgbe: enable Rx queue interrupts for PF and VF") Signed-off-by: Olivier Matz --- drivers/net/ixgbe/ixgbe_ethdev.h | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/ixgbe/ixgbe_ethdev.h b/drivers/net/ixgbe/ixgbe

Re: [dpdk-dev] [RFC 0/8] mbuf: structure reorganization

2017-02-28 Thread Olivier Matz
On Tue, 28 Feb 2017 11:48:20 +, "Ananyev, Konstantin" wrote: > > > > On Tue, 28 Feb 2017 10:29:41 +, "Ananyev, Konstantin" > > wrote: > > > > > > > > Hi, > > > > > > > > On Tue, 28 Feb 2017 09:05:07 +, "Ananyev, Konstantin" > > > > wrote: > > > > > Hi everyone, > > > > > > > >

Re: [dpdk-dev] [PATCH v2 1/2] librte_net: add crc init and compute APIs

2017-02-28 Thread Jerin Jacob
On Tue, Feb 28, 2017 at 12:08:20PM +, Jasvinder Singh wrote: > APIs for initialising and computing the crc (16-bit and 32-bit CRCs) > are added. For CRCs calculation, scalar as well as x86 intrinsic(sse4.2) > versions are implemented. > > The scalar version is based on generic Look-Up Table(LU

Re: [dpdk-dev] [PATCH v1 01/14] ring: remove split cacheline build setting

2017-02-28 Thread Jerin Jacob
On Tue, Feb 28, 2017 at 11:57:03AM +, Bruce Richardson wrote: > On Tue, Feb 28, 2017 at 05:05:13PM +0530, Jerin Jacob wrote: > > On Thu, Feb 23, 2017 at 05:23:54PM +, Bruce Richardson wrote: > > > Users compiling DPDK should not need to know or care about the arrangement > > > of cachelines

[dpdk-dev] [PATCH v2 2/2] app/test: add unit test for CRC computation

2017-02-28 Thread Jasvinder Singh
This patch provides a set of tests for verifying the functional correctness of 16-bit and 32-bit CRC APIs. Signed-off-by: Jasvinder Singh --- app/test/Makefile | 2 + app/test/test_crc.c | 229 2 files changed, 231 insertions(+) create mo

[dpdk-dev] [PATCH v2 1/2] librte_net: add crc init and compute APIs

2017-02-28 Thread Jasvinder Singh
APIs for initialising and computing the crc (16-bit and 32-bit CRCs) are added. For CRCs calculation, scalar as well as x86 intrinsic(sse4.2) versions are implemented. The scalar version is based on generic Look-Up Table(LUT) algorithm, while x86 intrinsic version uses carry-less multiplication fo

[dpdk-dev] [PATCH v2 0/2] librte_net: add crc computation support

2017-02-28 Thread Jasvinder Singh
In some applications, CRC (Cyclic Redundancy Check) needs to be computed or updated during packet processing operations. This patchset adds software implementation of some common standard CRCs (32-bit Ethernet CRC as per Ethernet/[ISO/IEC 8802-3] and 16-bit CCITT-CRC [ITU-T X.25]). Two versions of

Re: [dpdk-dev] [PATCH v1 01/14] ring: remove split cacheline build setting

2017-02-28 Thread Bruce Richardson
On Tue, Feb 28, 2017 at 05:05:13PM +0530, Jerin Jacob wrote: > On Thu, Feb 23, 2017 at 05:23:54PM +, Bruce Richardson wrote: > > Users compiling DPDK should not need to know or care about the arrangement > > of cachelines in the rte_ring structure. Therefore just remove the build > > option and

Re: [dpdk-dev] [PATCH v2 08/15] net/avp: device initialization

2017-02-28 Thread Jerin Jacob
On Sun, Feb 26, 2017 at 02:08:56PM -0500, Allain Legacy wrote: > Adds support for initialization newly probed AVP PCI devices. Initial > queue translations are setup in preparation for device configuration. > > Signed-off-by: Allain Legacy > Signed-off-by: Matt Peters > --- > drivers/net/avp/a

Re: [dpdk-dev] [PATCH v2 02/15] net/avp: public header files

2017-02-28 Thread Jerin Jacob
On Sun, Feb 26, 2017 at 02:08:50PM -0500, Allain Legacy wrote: > Adds public/exported header files for the AVP PMD. The AVP device is a > shared memory based device. The structures and constants that define the > method of operation of the device must be visible by both the PMD and the > host DPD

Re: [dpdk-dev] [RFC 0/8] mbuf: structure reorganization

2017-02-28 Thread Ananyev, Konstantin
> > On Tue, 28 Feb 2017 10:29:41 +, "Ananyev, Konstantin" > wrote: > > > > > > Hi, > > > > > > On Tue, 28 Feb 2017 09:05:07 +, "Ananyev, Konstantin" > > > wrote: > > > > Hi everyone, > > > > > > > > > > > > > > > > In my opinion, if we have the room in the first cache line, we > > > > >

Re: [dpdk-dev] [PATCH v1 01/14] ring: remove split cacheline build setting

2017-02-28 Thread Jerin Jacob
On Thu, Feb 23, 2017 at 05:23:54PM +, Bruce Richardson wrote: > Users compiling DPDK should not need to know or care about the arrangement > of cachelines in the rte_ring structure. Therefore just remove the build > option and set the structures to be always split. For improved > performance us

Re: [dpdk-dev] [RFC 0/8] mbuf: structure reorganization

2017-02-28 Thread Olivier Matz
On Tue, 28 Feb 2017 10:29:41 +, "Ananyev, Konstantin" wrote: > > > > Hi, > > > > On Tue, 28 Feb 2017 09:05:07 +, "Ananyev, Konstantin" > > wrote: > > > Hi everyone, > > > > > > > > > > > > > In my opinion, if we have the room in the first cache line, we > > > > > should put it there

Re: [dpdk-dev] [RFC 17.05 v1 0/3] Merge l3fwd-acl and l3fwd

2017-02-28 Thread Ananyev, Konstantin
Hi Ravi, > > Thanks to Konstantin and Bruce on first internal review comments. This > patch is RFC for 17.05 to merge l3fwd-acl and l3fwd code and add file > read options to build LPM and EM tables. Thanks for the patch, I think it is really useful one. Can I suggest you re-submit it as non-RFC

Re: [dpdk-dev] [RFC 0/8] mbuf: structure reorganization

2017-02-28 Thread Ananyev, Konstantin
> > Hi, > > On Tue, 28 Feb 2017 09:05:07 +, "Ananyev, Konstantin" > wrote: > > Hi everyone, > > > > > > > > > > In my opinion, if we have the room in the first cache line, we > > > > should put it there. The only argument I see against is "we may > > > > find something more important in th

Re: [dpdk-dev] [PATCH v2 11/15] net/avp: packet receive functions

2017-02-28 Thread Bruce Richardson
On Mon, Feb 27, 2017 at 05:06:24PM +, Legacy, Allain wrote: > > > -Original Message- > > From: Stephen Hemminger [mailto:step...@networkplumber.org] > > On Sun, 26 Feb 2017 14:08:59 -0500 > > Allain Legacy wrote: > > > > Try not to break error messages onto two lines, it makes it har

Re: [dpdk-dev] [RFC 0/8] mbuf: structure reorganization

2017-02-28 Thread Jan Blunck
On Tue, Feb 28, 2017 at 10:23 AM, Olivier Matz wrote: >> > >> > Do you still want to call the 64bit field "timestamp" or rename it >> > to something neutral and document that it is used together with the >> > mbuf flags? > > I think timestamp is a good name. In the current RFC patchset, we have >

Re: [dpdk-dev] [PATCH v3 00/10] Rework vdev probing to use rte_bus infrastructure

2017-02-28 Thread Shreyansh Jain
> -Original Message- > From: jblu...@gmail.com [mailto:jblu...@gmail.com] On Behalf Of Jan Blunck > Sent: Tuesday, February 28, 2017 2:49 PM > To: Shreyansh Jain > Cc: dev ; David Marchand ; Ferruh > Yigit > Subject: Re: [PATCH v3 00/10] Rework vdev probing to use rte_bus > infrastructure

Re: [dpdk-dev] [RFC 0/8] mbuf: structure reorganization

2017-02-28 Thread Jan Blunck
On Tue, Feb 28, 2017 at 10:05 AM, Ananyev, Konstantin wrote: >> > >> > In both cases, we would need a conversion code (maybe in a library) if >> > the application wants to work with timestamps from several sources. The >> > second solution removes the normalization code in the PMD when not >> > ne

Re: [dpdk-dev] [RFC 0/8] mbuf: structure reorganization

2017-02-28 Thread Olivier Matz
Hi, On Tue, 28 Feb 2017 09:05:07 +, "Ananyev, Konstantin" wrote: > Hi everyone, > > > > > > > In my opinion, if we have the room in the first cache line, we > > > should put it there. The only argument I see against is "we may > > > find something more important in the future, and we won't h

[dpdk-dev] [PATCH] net/mlx5: fix flow mark action handling

2017-02-28 Thread Nelio Laranjeiro
Mark value is always reported even when not requested or invalid. Fixes: ea3bc3b1df94 ("net/mlx5: support mark flow action") CC: sta...@dpdk.org Reported-by: Mark Bloch Signed-off-by: Nelio Laranjeiro Acked-by: Adrien Mazarguil --- drivers/net/mlx5/mlx5_rxtx.c | 2 +- 1 file changed, 1 insert

Re: [dpdk-dev] [PATCH v3 00/10] Rework vdev probing to use rte_bus infrastructure

2017-02-28 Thread Jan Blunck
On Tue, Feb 28, 2017 at 9:48 AM, Shreyansh Jain wrote: > On Monday 27 February 2017 06:39 PM, Jan Blunck wrote: >> >> On Sat, Feb 25, 2017 at 11:28 AM, Jan Blunck >> wrote: >>> >>> With the rte_bus infrastructure present in 17.02 it is possible to >>> refactor >>> the virtual device probing into

Re: [dpdk-dev] [RFC 0/8] mbuf: structure reorganization

2017-02-28 Thread Ananyev, Konstantin
Hi everyone, > > > > In my opinion, if we have the room in the first cache line, we should > > put it there. The only argument I see against is "we may find something > > more important in the future, and we won't have room for it in the > > first cache line". I don't feel we should penalize today

Re: [dpdk-dev] [RFC 0/8] mbuf: structure reorganization

2017-02-28 Thread Jan Blunck
On Fri, Feb 24, 2017 at 3:00 PM, Olivier Matz wrote: > > In my opinion, if we have the room in the first cache line, we should > put it there. The only argument I see against is "we may find something > more important in the future, and we won't have room for it in the > first cache line". I don't

[dpdk-dev] Pktgen-DPDK build errors on ppc64le

2017-02-28 Thread Rahul Lakkireddy
Hi All, We are seeing Pktgen-DPDK not building on ppc64le with latest dpdk git repo. Below build errors are seen: - [pktgen-dpdk]# make == lib == common CC l2p.o In file included from /root/pktgen-dpdk/lib/common/l2p.c:88:0: /root/pktgen-dpdk/lib/common/l2p.h: In functio

Re: [dpdk-dev] [PATCH v3 00/10] Rework vdev probing to use rte_bus infrastructure

2017-02-28 Thread Shreyansh Jain
On Monday 27 February 2017 06:39 PM, Jan Blunck wrote: On Sat, Feb 25, 2017 at 11:28 AM, Jan Blunck wrote: With the rte_bus infrastructure present in 17.02 it is possible to refactor the virtual device probing into a bus. This series also introduces the rte_vdev_device to better keep track of d

Re: [dpdk-dev] [PATCH] mk: Provide option to set Major ABI version

2017-02-28 Thread Jan Blunck
On Wed, Feb 22, 2017 at 2:24 PM, Christian Ehrhardt wrote: > --- a/mk/rte.lib.mk > +++ b/mk/rte.lib.mk > @@ -40,6 +40,12 @@ EXTLIB_BUILD ?= n > # VPATH contains at least SRCDIR > VPATH += $(SRCDIR) > > +ifneq ($(CONFIG_RTE_MAJOR_ABI),) > +ifneq ($(LIBABIVER),) > +LIBABIVER := $(CONFIG_RTE_MAJOR_

[dpdk-dev] [PATCH] net/mlx5: fix a wrong error handler

2017-02-28 Thread Nelio Laranjeiro
The returned error code was wrongly handled causing the PMD to refuse to start. Fixes: 91572d2a0b1a ("net/mlx5: fix startup when flow cannot be applied") CC: sta...@dpdk.org Signed-off-by: Nelio Laranjeiro --- drivers/net/mlx5/mlx5_trigger.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)