On Mon, Feb 27, 2017 at 03:18:52PM +0100, Thomas Monjalon wrote: > 2017-01-17 14:11, Jerin Jacob: > > This script generates cscope, gtags, and tags > > index files based on EAL environment. > > (architecture and OS(linux/bsd)) > > > > Selection of the architecture and OS environment > > is based on dpdk configuration target(T=) > > What is the purpose of selecting a configuration? > Is it to go quicker in the implementation you are interested in?
Yes. That is the hard part to do. > In that case, I think we need a catch-all option, because I like > being prompted by vim that several implementations exist and I can > choose one of them. OK. Then we can make T= as optional and if T= is not specified then script can take all the source files. Thoughts? > > > example usage: > > make tags T=x86_64-native-linuxapp-gcc > > make cscope T=x86_64-native-linuxapp-gcc > > make gtags T=x86_64-native-linuxapp-gcc > > > > Signed-off-by: Jerin Jacob <jerin.ja...@caviumnetworks.com> > > Reviewed-by: Yuanhan Liu <yuanhan....@linux.intel.com> > > Reviewed-by: Ferruh Yigit <ferruh.yi...@intel.com> > [...] > > .gitignore | 8 ++ > > devtools/tags.sh | 251 > > ++++++++++++++++++++++++++++++++++++++++++++++++++++++ > > mk/rte.sdkroot.mk | 4 + > > 3 files changed, 263 insertions(+) > > I think build-tags.sh would be a better name. OK > > On the implementation, I have few comments: > - is there a way to re-use the skip list when including the related > files? > - you can remove tile from this patch OK > And for the details: > - why a bash shebang where /bin/sh would be wider? I will change to /bin/sh > - verbose option should be -v (with getopts) OK > - please use $() instead of backquotes OK > - please avoid one-line functions used only once like doctags OK > > I can help you with this script if needed. OK. I can work on this next week, if you have time then feel free to take up this. >
