Re: [dpdk-dev] [PATCH 2/2] net/virtio-user: fix multi-process issue

2017-02-27 Thread Ami Sabo
Hi, You are right, the commit I mentioned didn't cause the issue - it just flooded it. The real issue is that rte_eth_dev_allocate should be called only from the primary process. Tomas's commit flood the issue by resseting rte_eth_dev_data, so now, when the virtio-user secondary process comes up

Re: [dpdk-dev] next technical board meeting, 2017-03-01

2017-02-27 Thread Olivier Matz
Hello, Just a reminder for those who want to assist. Olivier On Tue, 21 Feb 2017 14:11:15 +0100, Olivier MATZ wrote: > Hello everyone, > > A meeting of the DPDK technical board will occur next week, on > the 1st of March 2017 at 3pm UTC (4pm France, 11pm PRC, 7am US > Pacific). The meeting ta

Re: [dpdk-dev] [PATCH 0/2] net/mlx5 add rxq interrupt support

2017-02-27 Thread Shahaf Shuler
Tuesday, February 21, 2017 1:40 PM, Shahaf Shuler: > Wednesday, February 8, 2017 3:58 PM, Shahaf Shuler: > > Subject: [dpdk-dev] [PATCH 0/2] net/mlx5 add rxq interrupt support > > > > This patchset adds support for rxq interrupts on MLX5 PMD. > > The first patch introduces changes on eal_interrupt

Re: [dpdk-dev] [PATCH v1] doc: add guidelines on stable and lts releases

2017-02-27 Thread Yuanhan Liu
On Wed, Feb 08, 2017 at 06:39:23AM -0800, Thomas Monjalon wrote: > 2017-01-20 16:43, Yuanhan Liu: > > 16.07 as a first trial of stable release, I made a proposal to have 2 > > releases: v16.07.1 shortly after v16.11-rc1 and v16.07.2 shortly after > > v16.11. While the gap between v16.07 and v16.11

Re: [dpdk-dev] [PATCH v5 3/3] net/vhost: vHost support to free consumed buffers

2017-02-27 Thread Yuanhan Liu
On Mon, Feb 27, 2017 at 02:50:54PM +0100, Thomas Monjalon wrote: > 2017-01-27 13:38, Billy McFall: > > Add support to the vHostdriver for the new API to force free consumed > > buffers on Tx ring. vHost does not cache the mbufs so there is no work > > to do. > > > > Signed-off-by: Billy McFall >

Re: [dpdk-dev] [PATCH 2/2] net/virtio-user: fix multi-process issue

2017-02-27 Thread Yuanhan Liu
On Sun, Feb 26, 2017 at 11:55:26AM +0200, Ami Sabo wrote: > Secondary process doesn't properly attach to the rte_eth_device > initialized by the primary process. > > ccessing device from secondary process (e.g. via rte_eth_rx_burst), > causes process to crash. because rte_eth_dev_data is not prope

Re: [dpdk-dev] [PATCH 1/2] lib/librte_ether: export secondary attach function

2017-02-27 Thread Yuanhan Liu
Cc Thomas, the librte_ether maintainer. On Sun, Feb 26, 2017 at 11:55:25AM +0200, Ami Sabo wrote: > /** > * @internal > + * Attach to the ethdev already initialized by the primary > + * process. > + * > + * @param nameEthernet device's name. > + @return mailformed comment: missing *

[dpdk-dev] [PATCH 4/4] net/i40e: enable DCB on SRIOV VFs

2017-02-27 Thread Jingjing Wu
enable DCB on SRIOV VFs, including - UP and TC mapping according to dcb_tc in struct rte_eth_dcb_rx_conf. - TC and queue mapping: queues are divided equally for each TC. - UP insert when sending packet according to the TC the Tx queue belongs to. Signed-off-by: Jingjing Wu --- drivers/net/i40

[dpdk-dev] [PATCH 2/4] app/testpmd: fix init config for multi-queue mode

2017-02-27 Thread Jingjing Wu
In SRIOV mode, the mq_mode of rte_eth_rxmode should not carry VMDQ info without rx_adv_conf setting. Fixes: a30979f6ad7f ("app/testpmd: set Rx VMDq RSS mode") Cc: sta...@dpdk.org Signed-off-by: Jingjing Wu --- app/test-pmd/testpmd.c | 13 + 1 file changed, 1 insertion(+), 12 deletio

[dpdk-dev] [PATCH 1/4] net/ixgbe: fix multi-queue mode check in SRIOV mode

2017-02-27 Thread Jingjing Wu
In SRIOV case, ETH_MQ_RX_VMDQ_DCB and ETH_MQ_RX_DCB should be considered as the same meaning, due to the multi-queue mapping is the same SRIOV and VMDq in ixgbe. Fixes: 27b609cbd1c6 ("ethdev: move the multi-queue mode check to specific drivers") Cc: sta...@dpdk.org Signed-off-by: Jingjing Wu --

[dpdk-dev] [PATCH 3/4] app/testpmd: fix TC mapping in DCB init config

2017-02-27 Thread Jingjing Wu
Fix the UP and TC mapping to divide multiple UPs to TCs instead of mapping the UPs who are lager than num_tcs to TC0. Fixes: 1a572499beb6 ("app/testpmd: setup DCB forwarding based on traffic class") Cc: sta...@dpdk.org Signed-off-by: Jingjing Wu --- app/test-pmd/testpmd.c | 6 +++--- 1 file cha

Re: [dpdk-dev] [PATCHv7 03/47] common/dpaa2: adding qbman driver

2017-02-27 Thread Shreyansh Jain
> -Original Message- > From: Ferruh Yigit [mailto:ferruh.yi...@intel.com] > Sent: Monday, February 27, 2017 9:06 PM > To: Shreyansh Jain > Cc: dev@dpdk.org; nhor...@tuxdriver.com; Hemant Agrawal > > Subject: Re: [PATCHv7 03/47] common/dpaa2: adding qbman driver > > On 2/27/2017 10:01 AM,

Re: [dpdk-dev] [PATCH 0/8] QoS features on i40e - Linux kernel divergence

2017-02-27 Thread Lu, Wenzhuo
Hi Vincent, > -Original Message- > From: Vincent JARDIN [mailto:vincent.jar...@6wind.com] > Sent: Friday, February 24, 2017 5:14 PM > To: Lu, Wenzhuo; Stephen Hemminger > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH 0/8] QoS features on i40e - Linux kernel > divergence > > Le 24/02/2

Re: [dpdk-dev] [PATCH v4] i40e: implement vector PMD for altivec

2017-02-27 Thread Chao Zhu
-Original Message- From: Gowrishankar [mailto:gowrishanka...@linux.vnet.ibm.com] Sent: 2017年2月23日 12:39 To: dev@dpdk.org Cc: Chao Zhu ; Helin Zhang ; Jingjing Wu ; Thomas Monjalon ; Pradeep ; Gowrishankar Muthukrishnan Subject: [PATCH v4] i40e: implement vector PMD for altivec From: Gowr

Re: [dpdk-dev] [PATCH] net/vhost: remove include of numaif.h.

2017-02-27 Thread Yuanhan Liu
On Sun, Feb 26, 2017 at 11:54:11PM -0500, Rami Rosen wrote: > This patch revmoves include of the numaif.h header from rte_eth_vhost.c. > Commit 586e3 ("vhost: export numa node") moved > the invocation of get_mempolicy() from rte_eth_vhost.c to > librte_vhost/virtio-net.c, > so there is no need to

Re: [dpdk-dev] [dpdk-stable] [PATCH] net/i40e: Fix a typo in i40e_flow.c.

2017-02-27 Thread Yuanhan Liu
On Mon, Feb 27, 2017 at 04:31:28PM +, Ferruh Yigit wrote: > On 2/27/2017 3:50 PM, Mcnamara, John wrote: > > > > > >> -Original Message- > >> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Rami Rosen > >> Sent: Monday, February 27, 2017 4:54 AM > >> To: dev@dpdk.org > >> Cc: Rose

Re: [dpdk-dev] [PATCH 1/2] eal: clean up interrupt handle

2017-02-27 Thread Zhang, Qi Z
HI Jan: > -Original Message- > From: jblu...@gmail.com [mailto:jblu...@gmail.com] On Behalf Of Jan Blunck > Sent: Tuesday, February 28, 2017 12:19 AM > To: Zhang, Qi Z > Cc: Thomas Monjalon ; dev > Subject: Re: [dpdk-dev] [PATCH 1/2] eal: clean up interrupt handle > > On Wed, Feb 22, 20

Re: [dpdk-dev] [PATCH v5 2/3] net/e1000: e1000 igb support to free consumed buffers

2017-02-27 Thread Lu, Wenzhuo
Hi Billy, > -Original Message- > From: Billy McFall [mailto:bmcf...@redhat.com] > Sent: Saturday, January 28, 2017 2:38 AM > To: thomas.monja...@6wind.com; Lu, Wenzhuo; olivier.m...@6wind.com > Cc: dev@dpdk.org; Billy McFall > Subject: [PATCH v5 2/3] net/e1000: e1000 igb support to free co

Re: [dpdk-dev] [PATCH v2] crypto/openssl: add DES DOCSIS BPI support

2017-02-27 Thread Jain, Deepak K
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Pablo de Lara > Sent: Thursday, February 23, 2017 3:22 PM > To: Doherty, Declan > Cc: dev@dpdk.org; De Lara Guarch, Pablo > Subject: [dpdk-dev] [PATCH v2] crypto/openssl: add DES DOCSIS BPI support > > Adds supp

Re: [dpdk-dev] [PATCH v2] cryptodev: enable BPI for Cablelabs DOCSIS security spec

2017-02-27 Thread Jain, Deepak K
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Pablo de Lara > Sent: Thursday, February 23, 2017 2:03 PM > To: Doherty, Declan ; Trahe, Fiona > > Cc: dev@dpdk.org; De Lara Guarch, Pablo > Subject: [dpdk-dev] [PATCH v2] cryptodev: enable BPI for Cablelabs DOCS

[dpdk-dev] [PATCH] app/testpmd: Fix typos

2017-02-27 Thread Nirmoy Das
fixes trivial typos in app/test-pmd/cmdline.c, app/test-pmd/icmpecho.c, app/test-pmd/testpmd.c Signed-off-by: Nirmoy Das --- app/test-pmd/cmdline.c | 4 ++-- app/test-pmd/icmpecho.c | 4 ++-- app/test-pmd/testpmd.c | 4 ++-- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/app/te

[dpdk-dev] [PATCH v5] doc: use corelist instead of coremask

2017-02-27 Thread Keith Wiles
The coremask option in DPDK is difficult to use and we should be promoting the use of the corelist (-l) option. The patch adjusts the docs to use -l EAL option instead of the -c option. The patch only changes the docs and not the code as the -c option will continue to exist unless it is removed in

Re: [dpdk-dev] [PATCH v2 07/15] net/avp: driver registration

2017-02-27 Thread Legacy, Allain
> -Original Message- > From: Stephen Hemminger [mailto:step...@networkplumber.org] > > PCI table should be const Ok. Will do.

Re: [dpdk-dev] [PATCH v2 07/15] net/avp: driver registration

2017-02-27 Thread Legacy, Allain
> -Original Message- > From: Stephen Hemminger [mailto:step...@networkplumber.org] > > What exactly is the spinlock protecting? The control operations in DPDK are > defined to be not thread safe. I.e it is responsibility of caller to > synchronize. > Therefore is lock really needed? The

Re: [dpdk-dev] [PATCH v2 15/15] doc: adds information related to the AVP PMD

2017-02-27 Thread Legacy, Allain
> -Original Message- > From: Mcnamara, John [mailto:john.mcnam...@intel.com] > > The patchset should also include an update to the release notes: > > doc/guides/rel_notes/release_17_05.rst > Ok. will do.

Re: [dpdk-dev] [PATCH v2 11/15] net/avp: packet receive functions

2017-02-27 Thread Legacy, Allain
> -Original Message- > From: Stephen Hemminger [mailto:step...@networkplumber.org] > On Sun, 26 Feb 2017 14:08:59 -0500 > Allain Legacy wrote: > > Try not to break error messages onto two lines, it makes it harder when a > user is trying to find the location of the error message with sea

Re: [dpdk-dev] [PATCH v2 15/15] doc: adds information related to the AVP PMD

2017-02-27 Thread Mcnamara, John
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Allain Legacy > Sent: Sunday, February 26, 2017 7:09 PM > To: Yigit, Ferruh > Cc: dev@dpdk.org > Subject: [dpdk-dev] [PATCH v2 15/15] doc: adds information related to the > AVP PMD > > Updates the documentation

Re: [dpdk-dev] [PATCH v2 07/15] net/avp: driver registration

2017-02-27 Thread Stephen Hemminger
On Sun, 26 Feb 2017 14:08:55 -0500 Allain Legacy wrote: > +struct avp_dev { > + uint32_t magic; /**< Memory validation marker */ > + uint64_t device_id; /**< Unique system identifier */ > + struct ether_addr ethaddr; /**< Host specified MAC address */ > + struct rte_eth_dev_data *

Re: [dpdk-dev] [PATCH v2 07/15] net/avp: driver registration

2017-02-27 Thread Stephen Hemminger
On Sun, 26 Feb 2017 14:08:55 -0500 Allain Legacy wrote: > +static struct rte_pci_id pci_id_avp_map[] = { > + { .vendor_id = RTE_AVP_PCI_VENDOR_ID, > + .device_id = RTE_AVP_PCI_DEVICE_ID, > + .subsystem_vendor_id = RTE_AVP_PCI_SUB_VENDOR_ID, > + .subsystem_device_id = RTE_AVP

Re: [dpdk-dev] [PATCH v2 11/15] net/avp: packet receive functions

2017-02-27 Thread Stephen Hemminger
On Sun, 26 Feb 2017 14:08:59 -0500 Allain Legacy wrote: > + if (eth_dev->data->scattered_rx) { > + PMD_DRV_LOG(NOTICE, > + "AVP device configured " > + "for chained mbufs\n"); Try not to break error m

Re: [dpdk-dev] [PATCH] net/i40e: Fix a typo in i40e_flow.c.

2017-02-27 Thread Ferruh Yigit
On 2/27/2017 3:50 PM, Mcnamara, John wrote: > > >> -Original Message- >> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Rami Rosen >> Sent: Monday, February 27, 2017 4:54 AM >> To: dev@dpdk.org >> Cc: Rosen, Rami >> Subject: [dpdk-dev] [PATCH] net/i40e: Fix a typo in i40e_flow.c. >

[dpdk-dev] [PATCH v5 08/26] eal: do not panic on memzone initialization fails

2017-02-27 Thread Aaron Conole
When memzone initialization fails, report the error to the calling application rather than panic(). Without a good way of detaching / releasing hugepages, at this point the application will have to restart. Signed-off-by: Aaron Conole --- lib/librte_eal/linuxapp/eal/eal.c | 7 +-- 1 file ch

[dpdk-dev] [PATCH v5 24/26] eal: do not panic when bus probe fails

2017-02-27 Thread Aaron Conole
Signed-off-by: Aaron Conole --- lib/librte_eal/linuxapp/eal/eal.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/lib/librte_eal/linuxapp/eal/eal.c b/lib/librte_eal/linuxapp/eal/eal.c index 77a1950..361256f 100644 --- a/lib/librte_eal/linuxapp/eal/eal.c +++ b/lib/librt

Re: [dpdk-dev] [PATCH 1/2] eal: clean up interrupt handle

2017-02-27 Thread Jan Blunck
On Wed, Feb 22, 2017 at 11:17 PM, Qi Zhang wrote: > --- a/lib/librte_eal/linuxapp/eal/eal_interrupts.c > +++ b/lib/librte_eal/linuxapp/eal/eal_interrupts.c > @@ -278,29 +278,6 @@ vfio_disable_msi(const struct rte_intr_handle > *intr_handle) { > return ret; > } > > -static int > -get_max_

[dpdk-dev] [PATCH v5 25/26] eal: do not panic on failed bus scan

2017-02-27 Thread Aaron Conole
For now, do an abort. It's likely that even aborting the initialization is premature in this case, as it may be possible to proceed even if one bus or another is not available. Signed-off-by: Aaron Conole --- lib/librte_eal/linuxapp/eal/eal.c | 7 +-- 1 file changed, 5 insertions(+), 2 dele

[dpdk-dev] [PATCH v5 23/26] eal: do not panic (or abort) if vdev init fails

2017-02-27 Thread Aaron Conole
Seems like it's possible to continue. At least, the error is reflected properly in the logs. A user could then go and correct or investigate the situation. Signed-off-by: Aaron Conole --- lib/librte_eal/linuxapp/eal/eal.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/

[dpdk-dev] [PATCH v5 22/26] eal_common_dev: continue initializing vdevs

2017-02-27 Thread Aaron Conole
Even if one vdev should fail, there's no need to prevent further processing. Log the error, and reflect it to the higher levels to decide. Signed-off-by: Aaron Conole --- lib/librte_eal/common/eal_common_dev.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/lib/librte_e

[dpdk-dev] [PATCH v5 26/26] rte_eal_init: add info about rte_errno codes

2017-02-27 Thread Aaron Conole
The rte_eal_init function will now pass failure reason hints to the application. To help app developers deciper this, add some brief information about what the codes are indicating. Signed-off-by: Aaron Conole --- lib/librte_eal/common/include/rte_eal.h | 27 ++- 1 file

[dpdk-dev] [PATCH v5 21/26] eal: do not panic on failed PCI probe

2017-02-27 Thread Aaron Conole
It may even be possible to simply log the error and continue on letting the user check the logs and restart the application when things are failed. Signed-off-by: Aaron Conole --- lib/librte_eal/linuxapp/eal/eal.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/lib/lib

[dpdk-dev] [PATCH v5 18/26] eal: Do not panic on interrupt thread init

2017-02-27 Thread Aaron Conole
When initializing the interrupt thread, there are a number of possible reasons for failure - some of which are correctable by the application. Do not panic() needlessly, and give the application a change to reflect this information to the user. Signed-off-by: Aaron Conole --- lib/librte_eal/linu

[dpdk-dev] [PATCH v5 16/26] eal: convert timer_init not to call panic

2017-02-27 Thread Aaron Conole
After code inspection, there is no way for eal_timer_init() to fail. It simply returns 0 in all cases. As such, this test could either go-away or stay here as 'future-proofing'. Signed-off-by: Aaron Conole --- lib/librte_eal/linuxapp/eal/eal.c | 7 +-- 1 file changed, 5 insertions(+), 2 de

[dpdk-dev] [PATCH v5 19/26] eal: do not error if plugins fail to init

2017-02-27 Thread Aaron Conole
Plugins are useful and important. However, it seems crazy to abort everything just because they don't initialize properly. Signed-off-by: Aaron Conole --- lib/librte_eal/linuxapp/eal/eal.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/librte_eal/linuxapp/eal/eal.c b/l

[dpdk-dev] [PATCH v5 20/26] eal_pci: Continue probing even on failures

2017-02-27 Thread Aaron Conole
Some devices may be inaccessible for a variety of reasons, or the PCI-bus may be unavailable causing the whole thing to fail. Still, better to continue attempts at probes. Signed-off-by: Aaron Conole --- lib/librte_eal/common/eal_common_pci.c | 15 ++- 1 file changed, 10 insertions(

[dpdk-dev] [PATCH v5 17/26] eal: change the private pipe call to reflect errno

2017-02-27 Thread Aaron Conole
There could be some confusion as to why the call failed - this change will always reflect the value of the error in rte_error. Signed-off-by: Aaron Conole --- lib/librte_eal/linuxapp/eal/eal_interrupts.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/lib/librte_eal/linux

[dpdk-dev] [PATCH v5 15/26] eal: do not panic on alarm init

2017-02-27 Thread Aaron Conole
rte_eal_alarm_init() call uses the linux timerfd framework to create a poll()-able timer using standard posix file operations. This could fail for a few reasons given in the man-pages, but many could be corrected by the user application. No need to panic. Signed-off-by: Aaron Conole --- lib/li

[dpdk-dev] [PATCH v5 12/26] eal: do not panic on vfio failure

2017-02-27 Thread Aaron Conole
Signed-off-by: Aaron Conole --- lib/librte_eal/linuxapp/eal/eal.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/lib/librte_eal/linuxapp/eal/eal.c b/lib/librte_eal/linuxapp/eal/eal.c index c9f8c11..2e7faa8 100644 --- a/lib/librte_eal/linuxapp/eal/eal.c +++ b/lib/libr

[dpdk-dev] [PATCH v5 13/26] eal: do not panic on memory init

2017-02-27 Thread Aaron Conole
This can only happen when access to hugepages (either as primary or secondary process) fails (and that is usually permissions). Since the manner of failure is not reversible, we cannot allow retry. Signed-off-by: Aaron Conole --- lib/librte_eal/linuxapp/eal/eal.c | 7 +-- 1 file changed, 5

[dpdk-dev] [PATCH v5 14/26] eal: do not panic on tailq init

2017-02-27 Thread Aaron Conole
There are some theoretical racy conditions in the system that _could_ cause early tailq init to fail; however, no need to panic the application. While it can't continue using DPDK, it could make better alerts to the user. Signed-off-by: Aaron Conole --- lib/librte_eal/common/eal_common_tailqs.

[dpdk-dev] [PATCH v5 11/26] eal: Do not panic on pci-probe

2017-02-27 Thread Aaron Conole
This will usually be an issue because of permissions. However, it could also be caused by OOM. In either case, errno will contain the underlying cause. It is safe to re-init the system here, so allow the application to take corrective action and reinit. Signed-off-by: Aaron Conole --- lib/lib

[dpdk-dev] [PATCH v5 10/26] eal: Do not panic on log failures

2017-02-27 Thread Aaron Conole
When log initialization fails, it's generally because the fopencookie failed. While this is rare in practice, it could happen, and it is likely because of memory pressure. So, flag the error, and allow the user to retry. Signed-off-by: Aaron Conole --- lib/librte_eal/linuxapp/eal/eal.c | 8 +++

[dpdk-dev] [PATCH v5 05/26] eal: failure to parse args returns error

2017-02-27 Thread Aaron Conole
It's possible that the application could take a corrective action here, and either prompt the user for different arguments, or at least perform a better logging. Exiting this early prevents any useful information gathering from the application layer. Signed-off-by: Aaron Conole --- lib/librte_e

[dpdk-dev] [PATCH v5 06/26] eal-common: introduce a way to query cpu support

2017-02-27 Thread Aaron Conole
This adds a new API to check for the eal cpu versions. Signed-off-by: Aaron Conole --- lib/librte_eal/common/eal_common_cpuflags.c | 13 +++-- lib/librte_eal/common/include/generic/rte_cpuflags.h | 8 2 files changed, 19 insertions(+), 2 deletions(-) diff --git a/lib/

[dpdk-dev] [PATCH v5 09/26] eal: set errno when exiting for already called

2017-02-27 Thread Aaron Conole
Signed-off-by: Aaron Conole --- lib/librte_eal/linuxapp/eal/eal.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/lib/librte_eal/linuxapp/eal/eal.c b/lib/librte_eal/linuxapp/eal/eal.c index 1e54ca1..4b6c7b8 100644 --- a/lib/librte_eal/linuxapp/eal/eal.c +++ b/lib/librte_e

[dpdk-dev] [PATCH v5 07/26] eal: Signal error when CPU isn't supported

2017-02-27 Thread Aaron Conole
It's now possible to gracefully exit the application, or for applications which support non-dpdk datapaths working in concert with DPDK datapaths, there no longer is the possibility of exiting for unsupported CPUs. Signed-off-by: Aaron Conole --- lib/librte_eal/linuxapp/eal/eal.c | 6 +- 1 f

[dpdk-dev] [PATCH v5 04/26] eal: do not panic on failed hugepage query

2017-02-27 Thread Aaron Conole
If we fail to acquire hugepage information, simply signal an error to the application. This clears the run_once counter, allowing the user or application to take a corrective action and retry. Signed-off-by: Aaron Conole --- lib/librte_eal/linuxapp/eal/eal.c | 8 ++-- 1 file changed, 6 inse

[dpdk-dev] [PATCH v5 03/26] eal: No panic on hugepages info init

2017-02-27 Thread Aaron Conole
When attempting to scan hugepages, signal to the eal.c that an error has occurred, rather than performing a panic. Signed-off-by: Aaron Conole --- lib/librte_eal/linuxapp/eal/eal_hugepage_info.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/lib/librte_eal/linuxapp/eal

[dpdk-dev] [PATCH v5 02/26] eal: return error instead of panic for cpu init

2017-02-27 Thread Aaron Conole
There may be no way to gracefully recover, but the application should be notified that a failure happened, rather than completely aborting. This allows the user to proceed with a "slow-path" type solution. Signed-off-by: Aaron Conole --- lib/librte_eal/linuxapp/eal/eal.c | 14 -- 1

[dpdk-dev] [PATCH v5 00/26] linux/eal: Remove most causes of panic on init

2017-02-27 Thread Aaron Conole
In many cases, it's enough to simply let the application know that the call to initialize DPDK has failed. A complete halt can then be decided by the application based on error returned (and the app could even attempt a possible re-attempt after some corrective action by the user or application).

[dpdk-dev] [PATCH v5 01/26] eal: CPU init will no longer panic

2017-02-27 Thread Aaron Conole
After this change, the EAL CPU NUMA node resolution step can no longer emit an rte_panic. This aligns with the code in rte_eal_init, which expects failures to return an error code. Signed-off-by: Aaron Conole --- lib/librte_eal/common/eal_common_lcore.c | 7 --- 1 file changed, 4 insertions

Re: [dpdk-dev] [PATCH] igb_uio: use non-threaded ISR

2017-02-27 Thread Ferruh Yigit
On 1/20/2017 11:08 PM, David Su wrote: > This eliminates the overhead of a task switch when an interrupt arrives. > > Signed-off-by: David Su Overall I agree with Stephen to switch vfio when possible but for the cases igb_uio still required: Acked-by: Ferruh Yigit

Re: [dpdk-dev] [PATCH] net/i40e: Fix a typo in i40e_flow.c.

2017-02-27 Thread Mcnamara, John
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Rami Rosen > Sent: Monday, February 27, 2017 4:54 AM > To: dev@dpdk.org > Cc: Rosen, Rami > Subject: [dpdk-dev] [PATCH] net/i40e: Fix a typo in i40e_flow.c. > > This patch fixes a trivial typo in i40e_flow.c. >

Re: [dpdk-dev] [PATCH 0/4] catch up TILE-Gx support in DPDK

2017-02-27 Thread Thomas Monjalon
2017-02-17 20:52, Chris Metcalf: > This patch series allows DPDK to build for TILE-Gx as of version 17.02. > > A required library (libgxio) had not been made publicly available. > It is now available as source here: > > http://www.mellanox.com/repository/solutions/tile-scm/libgxio-1.0.tar.xz >

Re: [dpdk-dev] [PATCHv7 03/47] common/dpaa2: adding qbman driver

2017-02-27 Thread Ferruh Yigit
On 2/27/2017 10:01 AM, Shreyansh Jain wrote: > Hello Ferruh, > > On Friday 24 February 2017 03:28 PM, Ferruh Yigit wrote: > > [snip] > >>> >>> Now, we have these possibility: >>> 1. Have a shared library with non rte_* symbols >>> 2. We have shared library with rte_* symbols >>> 3. We have non-n

Re: [dpdk-dev] [PATCH v2] proc-info: added collectd-format and host-id options.

2017-02-27 Thread Van Haaren, Harry
Apologies, I reviewed patch v2, but replied to v1 on the mailing list. For reference, the original reply on v1: http://dpdk.org/ml/archives/dev/2017-February/058518.html The same feedback provided here: > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Roman

Re: [dpdk-dev] [PATCH v2 00/16] Wind River Systems AVP PMD

2017-02-27 Thread Wiles, Keith
> On Feb 27, 2017, at 4:15 AM, Legacy, Allain > wrote: > >> -Original Message- >> From: Vincent JARDIN [mailto:vincent.jar...@6wind.com] > ... >> So, before spending too much time in reviewing your long serie, I think that >> proper statements are needed. In the past, other NICs using Q

Re: [dpdk-dev] [PATCH 1/2] Fix container_of() macro to work with const members

2017-02-27 Thread Bruce Richardson
On Mon, Feb 27, 2017 at 03:28:14PM +0100, Jan Blunck wrote: > On Tue, Feb 14, 2017 at 3:36 PM, Jan Blunck wrote: > > This fixes the usage of structure members that are declared const to get > > a pointer to the embedding parent structure. > > Ping. Is anyone willing to review this? > Looks ok to

Re: [dpdk-dev] [PATCH] proc-info: added collectd-format and host-id options.

2017-02-27 Thread Van Haaren, Harry
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Roman Korynkevych > Sent: Friday, February 24, 2017 4:52 PM > To: dev@dpdk.org > Cc: Korynkevych, RomanX > Subject: [dpdk-dev] [PATCH] proc-info: added collectd-format and host-id > options. > > Extended proc-inf

Re: [dpdk-dev] [PATCH v4 06/26] eal-common: introduce a way to query cpu support

2017-02-27 Thread Bruce Richardson
On Mon, Feb 27, 2017 at 09:33:19AM -0500, Aaron Conole wrote: > Bruce Richardson writes: > > > On Sat, Feb 25, 2017 at 11:02:49AM -0500, Aaron Conole wrote: > >> This adds a new API to check for the eal cpu versions. > >> > >> Signed-off-by: Aaron Conole > >> --- > >> lib/librte_eal/common/eal

Re: [dpdk-dev] [PATCH] doc: add default values of install variables

2017-02-27 Thread Thomas Monjalon
> > The variables DESTDIR and prefix are used with "make install" > > to copy the files in $DESTDIR$prefix. > > Their default values will be shown when calling "make help". > > > > Signed-off-by: Thomas Monjalon > > Acked-by: John McNamara Applied

[dpdk-dev] [PATCH v2 3/4] app/crypto-perf: use cryptodev algorithm parser

2017-02-27 Thread Pablo de Lara
Instead of going through the array of supported algorithms in the app, to get the algorithm enum, use the new API in cryptodev to parse this string, so it is not necessary to add a new supported algorithm in the cryptodev library and this app. Signed-off-by: Pablo de Lara Acked-by: Fiona Trahe A

[dpdk-dev] [PATCH v2 4/4] examples/l2fwd-crypto: use cryptodev algorithm parser

2017-02-27 Thread Pablo de Lara
L2fwd-crypto app was creating an array of strings for the supported algorithms, which was different from the strings that are now in cryptodev. Use the new API in cryptodev to parse the string from the user, to get the algorithm enum, instead, so it is not necessary to add a new supported algorith

[dpdk-dev] [PATCH v2 2/4] cryptodev: add algorithm string parsers

2017-02-27 Thread Pablo de Lara
Adds functions to get the cipher/authentication algorithm enums, given a string. This is useful for applications which gets the algorithm required from the user, to have a common string-enum mapping. Signed-off-by: Pablo de Lara Acked-by: Fiona Trahe Acked-by: Hemant Agrawal --- lib/librte_cry

[dpdk-dev] [PATCH v2 1/4] cryptodev: add missing algorithm strings

2017-02-27 Thread Pablo de Lara
DES-CBC and AUTH NULL algorithms were missing in the array of algorithm strings. Signed-off-by: Pablo de Lara Acked-by: Fiona Trahe Acked-by: Hemant Agrawal --- lib/librte_cryptodev/rte_cryptodev.c | 4 1 file changed, 4 insertions(+) diff --git a/lib/librte_cryptodev/rte_cryptodev.c b/

[dpdk-dev] [PATCH v2 0/4] New crypto algorithm string parser API

2017-02-27 Thread Pablo de Lara
Last release, an array with strings for the supported algorithms by the cryptodev library was added and used in the crypto-perf app. This patchset creates a new API to parse strings from the user, to select the desired algorithm (using the array above), which can be used by any application, making

Re: [dpdk-dev] [PATCH v4 02/26] eal: return error instead of panic for cpu init

2017-02-27 Thread Aaron Conole
Bruce Richardson writes: > On Sat, Feb 25, 2017 at 11:02:45AM -0500, Aaron Conole wrote: >> There may be no way to gracefully recover, but the application >> should be notified that a failure happened, rather than completely >> aborting. This allows the user to proceed with a "slow-path" type >>

Re: [dpdk-dev] [PATCH v4 02/26] eal: return error instead of panic for cpu init

2017-02-27 Thread Aaron Conole
Bruce Richardson writes: > On Sat, Feb 25, 2017 at 11:02:45AM -0500, Aaron Conole wrote: >> There may be no way to gracefully recover, but the application >> should be notified that a failure happened, rather than completely >> aborting. This allows the user to proceed with a "slow-path" type >>

Re: [dpdk-dev] [PATCH v4 00/26] linux/eal: Remove most causes of panic on init

2017-02-27 Thread Aaron Conole
Bruce Richardson writes: > On Sat, Feb 25, 2017 at 11:02:43AM -0500, Aaron Conole wrote: >> In many cases, it's enough to simply let the application know that the >> call to initialize DPDK has failed. A complete halt can then be >> decided by the application based on error returned (and the app

Re: [dpdk-dev] [PATCH v4 06/26] eal-common: introduce a way to query cpu support

2017-02-27 Thread Aaron Conole
Bruce Richardson writes: > On Sat, Feb 25, 2017 at 11:02:49AM -0500, Aaron Conole wrote: >> This adds a new API to check for the eal cpu versions. >> >> Signed-off-by: Aaron Conole >> --- >> lib/librte_eal/common/eal_common_cpuflags.c | 13 +++-- >> lib/librte_eal/common/inclu

Re: [dpdk-dev] [PATCH 1/2] Fix container_of() macro to work with const members

2017-02-27 Thread Jan Blunck
On Tue, Feb 14, 2017 at 3:36 PM, Jan Blunck wrote: > This fixes the usage of structure members that are declared const to get > a pointer to the embedding parent structure. Ping. Is anyone willing to review this? Thanks, Jan > > Signed-off-by: Jan Blunck > --- > lib/librte_eal/common/include/

Re: [dpdk-dev] [PATCH] net/ixgbevf: reset hardware whenstoppingport

2017-02-27 Thread Olivier Matz
Hi Wenzhuo, On Fri, 24 Feb 2017 11:42:56 +0100, Olivier Matz wrote: > Hi Fengtian, > > On Fri, 24 Feb 2017 18:15:27 +0800, "fengtian Guo" > wrote: > > Hi, Wenzhuo > > > > The attachment is test report without product. > > The test report uses is a use-case with 6WINDGate, so it cannot be >

Re: [dpdk-dev] [PATCH v2] tools: add tags and cscope index file generation support

2017-02-27 Thread Thomas Monjalon
2017-01-17 14:11, Jerin Jacob: > This script generates cscope, gtags, and tags > index files based on EAL environment. > (architecture and OS(linux/bsd)) > > Selection of the architecture and OS environment > is based on dpdk configuration target(T=) What is the purpose of selecting a configurati

[dpdk-dev] [PATCH v2] proc-info: added collectd-format and host-id options.

2017-02-27 Thread Roman Korynkevych
Extended proc-info application to send DPDK port statistics to STDOUT in the format expected by collectd exec plugin. Added HOST ID option to identify the host DPDK process is running on when multiple instance of DPDK are running in parallel. This is needed for the barometer project in OPNFV. Sign

Re: [dpdk-dev] [PATCH v4 00/26] linux/eal: Remove most causes of panic on init

2017-02-27 Thread Bruce Richardson
On Sat, Feb 25, 2017 at 11:02:43AM -0500, Aaron Conole wrote: > In many cases, it's enough to simply let the application know that the > call to initialize DPDK has failed. A complete halt can then be > decided by the application based on error returned (and the app could > even attempt a possible

Re: [dpdk-dev] [PATCH v5 3/3] net/vhost: vHost support to free consumed buffers

2017-02-27 Thread Thomas Monjalon
2017-01-27 13:38, Billy McFall: > Add support to the vHostdriver for the new API to force free consumed > buffers on Tx ring. vHost does not cache the mbufs so there is no work > to do. > > Signed-off-by: Billy McFall Yuanhan, Maxime, do you agree with this empty function?

Re: [dpdk-dev] [PATCH v5 1/3] ethdev: new API to free consumed buffers in Tx ring

2017-02-27 Thread Thomas Monjalon
2017-01-27 13:37, Billy McFall: > --- a/doc/guides/nics/features/default.ini > +++ b/doc/guides/nics/features/default.ini > @@ -55,6 +55,7 @@ FW version = > EEPROM dump = > Registers dump = > Multiprocess aware = > +Free TX ring buffers = I'm afraid this wording will

Re: [dpdk-dev] [PATCH v5 2/3] net/e1000: e1000 igb support to free consumed buffers

2017-02-27 Thread Thomas Monjalon
2017-01-27 13:37, Billy McFall: > Add support to the e1000 igb driver for the new API to force free > consumed buffers on Tx ring. e1000 igb driver does not implement a > tx_rs_thresh to free mbufs, it frees a slot in the ring as needed, so > a new function needed to be written. > > Signed-off-by:

Re: [dpdk-dev] [PATCH v4 06/26] eal-common: introduce a way to query cpu support

2017-02-27 Thread Bruce Richardson
On Sat, Feb 25, 2017 at 11:02:49AM -0500, Aaron Conole wrote: > This adds a new API to check for the eal cpu versions. > > Signed-off-by: Aaron Conole > --- > lib/librte_eal/common/eal_common_cpuflags.c | 13 +++-- > lib/librte_eal/common/include/generic/rte_cpuflags.h | 9

Re: [dpdk-dev] [PATCH v3 00/10] Rework vdev probing to use rte_bus infrastructure

2017-02-27 Thread Jan Blunck
On Sat, Feb 25, 2017 at 11:28 AM, Jan Blunck wrote: > With the rte_bus infrastructure present in 17.02 it is possible to refactor > the virtual device probing into a bus. This series also introduces the > rte_vdev_device to better keep track of devices. > > This patchset depends on: > http://dpdk.

Re: [dpdk-dev] [PATCH v4 02/26] eal: return error instead of panic for cpu init

2017-02-27 Thread Bruce Richardson
On Sat, Feb 25, 2017 at 11:02:45AM -0500, Aaron Conole wrote: > There may be no way to gracefully recover, but the application > should be notified that a failure happened, rather than completely > aborting. This allows the user to proceed with a "slow-path" type > solution. > > Signed-off-by: Aa

Re: [dpdk-dev] [PATCH v4 02/26] eal: return error instead of panic for cpu init

2017-02-27 Thread Bruce Richardson
On Sat, Feb 25, 2017 at 11:02:45AM -0500, Aaron Conole wrote: > There may be no way to gracefully recover, but the application > should be notified that a failure happened, rather than completely > aborting. This allows the user to proceed with a "slow-path" type > solution. > > Signed-off-by: Aa

Re: [dpdk-dev] [PATCH v2 00/16] Wind River Systems AVP PMD

2017-02-27 Thread Legacy, Allain
> -Original Message- > From: Vincent JARDIN [mailto:vincent.jar...@6wind.com] ... > So, before spending too much time in reviewing your long serie, I think that > proper statements are needed. In the past, other NICs using Qemu have > been sent, but they were avoided since virtio solved all

Re: [dpdk-dev] [PATCHv7 03/47] common/dpaa2: adding qbman driver

2017-02-27 Thread Shreyansh Jain
Hello Ferruh, On Friday 24 February 2017 03:28 PM, Ferruh Yigit wrote: [snip] Now, we have these possibility: 1. Have a shared library with non rte_* symbols 2. We have shared library with rte_* symbols 3. We have non-net devices (crypto, eventdev, ..) depend on net for these hardware interfa

Re: [dpdk-dev] [PATCH v3 02/10] eal: probe new virtual bus after other bus devices

2017-02-27 Thread Jan Blunck
On Mon, Feb 27, 2017 at 9:59 AM, Shreyansh Jain wrote: > On Saturday 25 February 2017 03:58 PM, Jan Blunck wrote: >> >> Also see commit f4ce209a ("eal: postpone vdev initialization"). >> >> Signed-off-by: Jan Blunck >> --- >> lib/librte_eal/common/eal_common_bus.c | 16 +++- >> 1 fil

Re: [dpdk-dev] [PATCH v2 00/16] Wind River Systems AVP PMD

2017-02-27 Thread Vincent JARDIN
Le 26/02/2017 à 20:08, Allain Legacy a écrit : This patch series submits an initial version of the AVP PMD from Wind River Systems. The series includes shared header files, driver implementation, and changes to documentation files in support of this new driver. The AVP driver is a shared memory

Re: [dpdk-dev] [PATCH v3 02/10] eal: probe new virtual bus after other bus devices

2017-02-27 Thread Shreyansh Jain
On Saturday 25 February 2017 03:58 PM, Jan Blunck wrote: Also see commit f4ce209a ("eal: postpone vdev initialization"). Signed-off-by: Jan Blunck --- lib/librte_eal/common/eal_common_bus.c | 16 +++- 1 file changed, 15 insertions(+), 1 deletion(-) diff --git a/lib/librte_eal/comm

[dpdk-dev] net/bonding - need for 8023ad slave to be in promisc mode

2017-02-27 Thread sujith sankar
Hi folks, Could someone clarify the need to put mode 4 bonding slaves in promiscuous mode? 840 void 841 bond_mode_8023ad_activate_slave(struct rte_eth_dev *bond_dev, uint8_t slave_id) 842 { . . . 878 /* use this port as agregator */ 879 port->aggregator_port_id = slave_id; 880 rte_

[dpdk-dev] [PATCH 60/61] net/qede: add ntuple and flow director filter support

2017-02-27 Thread Rasesh Mody
From: Harish Patil Add limited support for ntuple filter and flow director configuration. The filtering is based on 4-tuples viz src-ip, dst-ip, src-port, dst-port. The mask fields, tcp_flags, flex masks, priority fields, Rx queue drop etc are not supported. Signed-off-by: Harish Patil --- doc

[dpdk-dev] [PATCH 61/61] net/qede: add LRO/TSO offloads support

2017-02-27 Thread Rasesh Mody
From: Harish Patil This patch includes slowpath configuration and fastpath changes to support LRO and TSO. A bit of revamping is needed in order to make use of existing packet classification schemes in Rx fastpath and for SG element processing in Tx. Signed-off-by: Harish Patil --- doc/guides/

[dpdk-dev] [PATCH 59/61] net/qede/base: add support for arfs mode

2017-02-27 Thread Rasesh Mody
From: Harish Patil Add base driver APIs to enable accelerated RFS[aRFS] mode and ramrod to configure rfs and ntuple filter. Signed-off-by: Harish Patil --- drivers/net/qede/base/ecore_cxt.c | 49 +++- drivers/net/qede/base/ecore_init_fw_funcs.c | 30 ++ driver

[dpdk-dev] [PATCH 58/61] net/qede/base: semantic changes

2017-02-27 Thread Rasesh Mody
Make APIs static and other semantic changes. A step toward cleaning 'make C=1' with GCC 4.8.3. Signed-off-by: Rasesh Mody --- drivers/net/qede/base/ecore_cxt.c |5 +- drivers/net/qede/base/ecore_cxt.h | 11 drivers/net/qede/base/ecore_dcbx.c |2 +- drivers/net/qede/base/ecore_de

  1   2   >