Cc Thomas, the librte_ether maintainer.
On Sun, Feb 26, 2017 at 11:55:25AM +0200, Ami Sabo wrote:
> /**
> * @internal
> + * Attach to the ethdev already initialized by the primary
> + * process.
> + *
> + * @param name Ethernet device's name.
> + @return
mailformed comment: missing *.
> + * - Success: Slot in the rte_dev_devices array for attached
> + * device.
> + * - Error: Null pointer.
> + */
> +struct rte_eth_dev *rte_eth_dev_attach_secondary(const char *name);
> +
> +/**
> + * @internal
> * Release the specified ethdev port.
> *
> * @param eth_dev
> diff --git a/lib/librte_ether/rte_ether_version.map
> b/lib/librte_ether/rte_ether_version.map
> index c6c9d0d..d34c57a 100644
> --- a/lib/librte_ether/rte_ether_version.map
> +++ b/lib/librte_ether/rte_ether_version.map
> @@ -154,3 +154,10 @@ DPDK_17.02 {
> rte_flow_validate;
>
> } DPDK_16.11;
> +
> +DPDK_17.05 {
> + global:
> +
> + rte_eth_dev_attach_secondary;
I saw whitespace chars. Like code, it should be TABs. Other than those
minor nits, it looks good to me.
Reviewed-by: Yuanhan Liu <yuanhan....@linux.intel.com>
--yliu
