Re: [dpdk-dev] [PATCH v3 1/3] examples/ip_reassembly: add parse-ptype option

2017-02-09 Thread Liu, Yong
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Thomas Monjalon > Sent: Friday, February 10, 2017 5:27 AM > To: Liu, Yong ; Tan, Jianfeng > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v3 1/3] examples/ip_reassembly: add parse- > ptype option > > 2017-02

Re: [dpdk-dev] [PATCH] Fill speed_capa for virtio

2017-02-09 Thread Ido Barnea (ibarnea)
Just wanted this to be consistent with below (From virtio_dev_link_update): link.link_speed = SPEED_10G; Need to put some value in speed_capa. Ido On 09/02/2017, 6:19 PM, "Thomas Monjalon" wrote: >2017-02-02 12:05, Ido Barnea: >> From: Ido Barnea >> >> Signed-off-by: Ido Barnea >> ---

[dpdk-dev] [PATCH] eal: sPAPR IOMMU support in pci probing for vfio-pci in ppc64le

2017-02-09 Thread Gowrishankar
From: Gowrishankar Muthukrishnan Below changes adds pci probing support for vfio-pci devices in power8. Signed-off-by: Gowrishankar Muthukrishnan Acked-by: Chao Zhu --- lib/librte_eal/linuxapp/eal/eal_vfio.c | 88 ++ lib/librte_eal/linuxapp/eal/eal_vfio.h | 1

[dpdk-dev] [PATCH] net/i40e: fix wrong definition of TC bandwidth

2017-02-09 Thread Wenzhuo Lu
The range of TC bandwidth is 0 ~ 800, it's 16bits not 8bits. Fixes: c8b9a3e3fe1b ("i40e: support DCB mode") CC: sta...@dpdk.org Signed-off-by: Wenzhuo Lu --- drivers/net/i40e/i40e_ethdev.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/i40e/i40e_ethdev.h b/drive

[dpdk-dev] [PATCH] net/i40e: fix wrong handle when enable interrupt

2017-02-09 Thread Qi Zhang
In i40e_dev_interrupt_handler, when call rte_intr_enable, We should parse dev->intr_handle but not intr_handle. intr_handle is the copy of dev->intr_handle when it is registered, but parameter of dev->intr_handle is possible to be modifed later in i40e driver. Fixes: 2ce7a1ed09fc ("net/i40e: local

[dpdk-dev] [PATCH] eal: fix max number of interrupt request

2017-02-09 Thread Qi Zhang
The max number of interrupt request is possible be changed after rte_intr_callback_register, so in get_max_intr, we need to check if nessesary to update the max_intr. Signed-off-by: Qi Zhang --- lib/librte_eal/linuxapp/eal/eal_interrupts.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/li

[dpdk-dev] [PATCH] net/ixgbe: fix tci mask check in fdir pasrer

2017-02-09 Thread Wei Zhao
It must use big endian when check on the tci mask of vlan and vxlan parser in fdir filter rule pattern parser.Because rte layer send out tci mask using big endian mode. Fixes: 11777435c727 ("net/ixgbe: parse flow director filter") Fixes: cc83320af286 ("net/ixgbe: add tci mask check in fdir parser"

[dpdk-dev] [PATCH] net/i40e: fix vlan insert code redundance

2017-02-09 Thread Qiming Yang
This patch removed useless tx_flags in vlan insertion. Fixes: 4861cde46116 ("i40e: new poll mode driver") Signed-off-by: Qiming Yang --- drivers/net/i40e/i40e_rxtx.c | 8 +--- drivers/net/i40e/i40e_rxtx.h | 2 -- 2 files changed, 1 insertion(+), 9 deletions(-) diff --git a/drivers/net/i40e

Re: [dpdk-dev] [PATCH] examples/l2fwd-crypto: fix overflow

2017-02-09 Thread De Lara Guarch, Pablo
> -Original Message- > From: Zhang, Roy Fan > Sent: Thursday, February 09, 2017 6:24 PM > To: De Lara Guarch, Pablo; Doherty, Declan > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] examples/l2fwd-crypto: fix overflow > > > > On 07/02/2017 14:17, Pablo de Lara wrote: > > This commi

Re: [dpdk-dev] [PATCH] examples/l2fwd-crypto: fix incorrect padding addition

2017-02-09 Thread De Lara Guarch, Pablo
> -Original Message- > From: Zhang, Roy Fan > Sent: Thursday, February 09, 2017 6:23 PM > To: De Lara Guarch, Pablo; Doherty, Declan > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] examples/l2fwd-crypto: fix incorrect > padding addition > > > > On 09/02/2017 12:27, Pablo de Lara w

Re: [dpdk-dev] [PATCH] app/test-crypto-perf: fix incorrect size of expression

2017-02-09 Thread De Lara Guarch, Pablo
Hi Jacek, > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Jacek Piasecki > Sent: Wednesday, February 08, 2017 4:05 PM > To: Doherty, Declan > Cc: dev@dpdk.org; Piasecki, JacekX > Subject: [dpdk-dev] [PATCH] app/test-crypto-perf: fix incorrect size of > expressio

Re: [dpdk-dev] [PATCH] app/test-crypto-perf: fix big paremeter passed by value

2017-02-09 Thread De Lara Guarch, Pablo
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of De Lara Guarch, > Pablo > Sent: Thursday, February 09, 2017 11:42 PM > To: Piasecki, JacekX; Doherty, Declan > Cc: dev@dpdk.org; Piasecki, JacekX > Subject: Re: [dpdk-dev] [PATCH] app/test-crypto-perf: fix big par

[dpdk-dev] [PATCH v2 11/11] doc/sample_app: use corelist instead of coremask

2017-02-09 Thread Keith Wiles
Signed-off-by: Keith Wiles --- doc/guides/sample_app_ug/cmd_line.rst | 2 +- doc/guides/sample_app_ug/dist_app.rst | 2 +- doc/guides/sample_app_ug/exception_path.rst| 4 +-- doc/guides/sample_app_ug/hello_world.rst | 2 +- doc/guides/sample_app_ug/

[dpdk-dev] [PATCH v2 09/11] doc/cryptoperf: use corelist instead of coremask

2017-02-09 Thread Keith Wiles
Signed-off-by: Keith Wiles --- doc/guides/tools/cryptoperf.rst | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/doc/guides/tools/cryptoperf.rst b/doc/guides/tools/cryptoperf.rst index 6832312..30994cd 100644 --- a/doc/guides/tools/cryptoperf.rst +++ b/doc/guides/tools/cryp

[dpdk-dev] [PATCH v2 10/11] doc/xen: use corelist instead of coremask

2017-02-09 Thread Keith Wiles
Signed-off-by: Keith Wiles --- doc/guides/xen/pkt_switch.rst | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/doc/guides/xen/pkt_switch.rst b/doc/guides/xen/pkt_switch.rst index 0b4ddfd..0d73fa5 100644 --- a/doc/guides/xen/pkt_switch.rst +++ b/doc/guides/xen/pkt_swit

[dpdk-dev] [PATCH v2 07/11] doc/prog_guide: use corelist instead of coremask

2017-02-09 Thread Keith Wiles
Signed-off-by: Keith Wiles --- doc/guides/prog_guide/kernel_nic_interface.rst | 2 +- doc/guides/prog_guide/link_bonding_poll_mode_drv_lib.rst | 10 +- doc/guides/prog_guide/multi_proc_support.rst | 2 +- 3 files changed, 7 insertions(+), 7 deletions(-) diff --git

[dpdk-dev] [PATCH v2 08/11] doc/testpmd: use corelist instead of coremask

2017-02-09 Thread Keith Wiles
Signed-off-by: Keith Wiles --- doc/guides/testpmd_app_ug/run_app.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/guides/testpmd_app_ug/run_app.rst b/doc/guides/testpmd_app_ug/run_app.rst index 38a4025..d1fabef 100644 --- a/doc/guides/testpmd_app_ug/run_app.rst +++ b/d

[dpdk-dev] [PATCH v2 06/11] doc/nics: use corelist instead of coremask

2017-02-09 Thread Keith Wiles
Signed-off-by: Keith Wiles --- doc/guides/nics/bnx2x.rst | 2 +- doc/guides/nics/cxgbe.rst | 4 ++-- doc/guides/nics/ena.rst | 2 +- doc/guides/nics/i40e.rst | 4 ++-- doc/guides/nics/intel_vf.rst | 7 +-- doc/guides/nics/ixgbe.rst | 4 ++-- doc/guides/nics/mlx4.

[dpdk-dev] [PATCH v2 02/11] doc/faq: use corelist instead of coremask

2017-02-09 Thread Keith Wiles
Signed-off-by: Keith Wiles --- doc/guides/faq/faq.rst | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/doc/guides/faq/faq.rst b/doc/guides/faq/faq.rst index 5a324b2..98c1e33 100644 --- a/doc/guides/faq/faq.rst +++ b/doc/guides/faq/faq.rst @@ -54,7 +54,7 @@ If you need to cha

[dpdk-dev] [PATCH v2 01/11] doc/cryptodev: use corelist instead of coremask

2017-02-09 Thread Keith Wiles
Signed-off-by: Keith Wiles --- doc/guides/cryptodevs/aesni_gcm.rst | 2 +- doc/guides/cryptodevs/aesni_mb.rst | 2 +- doc/guides/cryptodevs/kasumi.rst| 2 +- doc/guides/cryptodevs/null.rst | 2 +- doc/guides/cryptodevs/openssl.rst | 2 +- doc/guides/cryptodevs/snow3g.rst| 2 +- do

[dpdk-dev] [PATCH v2 05/11] doc/linux: use corelist instead of coremask

2017-02-09 Thread Keith Wiles
Signed-off-by: Keith Wiles --- doc/guides/linux_gsg/build_sample_apps.rst | 19 ++- doc/guides/linux_gsg/nic_perf_intel_platform.rst | 2 +- doc/guides/linux_gsg/quick_start.rst | 2 +- 3 files changed, 12 insertions(+), 11 deletions(-) diff --git a/doc/guides

[dpdk-dev] [PATCH v2 03/11] doc/freebsd: use corelist instead of coremask

2017-02-09 Thread Keith Wiles
Signed-off-by: Keith Wiles --- doc/guides/freebsd_gsg/build_sample_apps.rst | 9 + doc/guides/freebsd_gsg/install_from_ports.rst | 2 +- 2 files changed, 6 insertions(+), 5 deletions(-) diff --git a/doc/guides/freebsd_gsg/build_sample_apps.rst b/doc/guides/freebsd_gsg/build_sample_apps

[dpdk-dev] [PATCH v2 04/11] doc/howto: use corelist instead of coremask

2017-02-09 Thread Keith Wiles
Signed-off-by: Keith Wiles --- doc/guides/howto/flow_bifurcation.rst | 2 +- doc/guides/howto/lm_bond_virtio_sriov.rst | 2 +- doc/guides/howto/lm_virtio_vhost_user.rst | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/doc/guides/howto/flow_bifurcation.rst b/doc/guides/h

[dpdk-dev] [PATCH v2 00/11] moving away from coremask to corelist

2017-02-09 Thread Keith Wiles
The coremask option in DPDK is difficult to use and we should be promoting the use of the corelist (-l) option. The patch series adjusts the docs to use -l EAL option instead of the -c option. The patch series doc change only and is not required to be done in 17.02 release, but should be added to

Re: [dpdk-dev] [PATCH] app/test-crypto-perf: fix big paremeter passed by value

2017-02-09 Thread De Lara Guarch, Pablo
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Jacek Piasecki > Sent: Wednesday, February 08, 2017 4:05 PM > To: Doherty, Declan > Cc: dev@dpdk.org; Piasecki, JacekX > Subject: [dpdk-dev] [PATCH] app/test-crypto-perf: fix big paremeter passed > by value > > S

Re: [dpdk-dev] [PATCH] crypto: fix incorrect key setting

2017-02-09 Thread De Lara Guarch, Pablo
> -Original Message- > From: Jain, Deepak K > Sent: Thursday, February 09, 2017 5:18 PM > To: De Lara Guarch, Pablo; dev@dpdk.org > Cc: De Lara Guarch, Pablo; sta...@dpdk.org > Subject: RE: [dpdk-dev] [PATCH] crypto: fix incorrect key setting > > > > -Original Message- > > From:

Re: [dpdk-dev] [PATCH] app/crypto-perf: fix total_ops value validation

2017-02-09 Thread De Lara Guarch, Pablo
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of De Lara Guarch, > Pablo > Sent: Thursday, February 09, 2017 11:18 PM > To: Kozak, KubaX; Doherty, Declan > Cc: dev@dpdk.org; Kozak, KubaX > Subject: Re: [dpdk-dev] [PATCH] app/crypto-perf: fix total_ops value > va

Re: [dpdk-dev] [PATCH] doc: add limitations section to cryptoperf guide

2017-02-09 Thread De Lara Guarch, Pablo
> -Original Message- > From: Mrozowicz, SlawomirX > Sent: Wednesday, February 08, 2017 9:48 AM > To: Trahe, Fiona; dev@dpdk.org > Cc: De Lara Guarch, Pablo; Jain, Deepak K; Griffin, John; Doherty, Declan > Subject: RE: [PATCH] doc: add limitations section to cryptoperf guide > > > > >-

Re: [dpdk-dev] [PATCH 04/11] doc/howto: use corelist instead of coremask

2017-02-09 Thread Wiles, Keith
> On Feb 9, 2017, at 5:00 PM, Igor Ryzhov wrote: > > Hello Keith, > comments inline below. > > On Thu, Feb 9, 2017 at 9:14 PM, Keith Wiles wrote: > Signed-off-by: Keith Wiles > --- > doc/guides/howto/flow_bifurcation.rst | 2 +- > doc/guides/howto/lm_bond_virtio_sriov.rst | 6 +++--- > d

Re: [dpdk-dev] [PATCH] app/crypto-perf: fix total_ops value validation

2017-02-09 Thread De Lara Guarch, Pablo
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Kuba Kozak > Sent: Tuesday, February 07, 2017 12:20 PM > To: Doherty, Declan > Cc: dev@dpdk.org; Kozak, KubaX > Subject: [dpdk-dev] [PATCH] app/crypto-perf: fix total_ops value validation > > Added total_ops valu

Re: [dpdk-dev] [PATCH 04/11] doc/howto: use corelist instead of coremask

2017-02-09 Thread Igor Ryzhov
Hello Keith, comments inline below. On Thu, Feb 9, 2017 at 9:14 PM, Keith Wiles wrote: > Signed-off-by: Keith Wiles > --- > doc/guides/howto/flow_bifurcation.rst | 2 +- > doc/guides/howto/lm_bond_virtio_sriov.rst | 6 +++--- > doc/guides/howto/lm_virtio_vhost_user.rst | 6 +++--- > 3 file

Re: [dpdk-dev] [PATCH] app/test-crypto-perf: fix buffer not null terminated

2017-02-09 Thread De Lara Guarch, Pablo
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of De Lara Guarch, > Pablo > Sent: Thursday, February 09, 2017 10:42 PM > To: Gajewski, AleksanderX; Doherty, Declan > Cc: dev@dpdk.org; Gajewski, AleksanderX > Subject: Re: [dpdk-dev] [PATCH] app/test-crypto-perf: f

Re: [dpdk-dev] [PATCH] app/test-crypto-perf: fix uninitialized scalar variable

2017-02-09 Thread De Lara Guarch, Pablo
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Aleksander > Gajewski > Sent: Tuesday, February 07, 2017 9:22 AM > To: Doherty, Declan > Cc: dev@dpdk.org; Gajewski, AleksanderX > Subject: [dpdk-dev] [PATCH] app/test-crypto-perf: fix uninitialized scalar > varia

Re: [dpdk-dev] [dpdk-techboard] decision process and DPDK scope

2017-02-09 Thread Stephen Hemminger
On Thu, 9 Feb 2017 12:20:47 + Bruce Richardson wrote: > > I think we can use this case to avoid seeing it again in the future. > > I suggest that the technical board should check whether every new proposed > > features are explained, discussed and approved enough in the community. > > If need

Re: [dpdk-dev] [PATCH] app/test-crypto-perf: fix buffer not null terminated

2017-02-09 Thread De Lara Guarch, Pablo
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Aleksander > Gajewski > Sent: Tuesday, February 07, 2017 9:20 AM > To: Doherty, Declan > Cc: dev@dpdk.org; Gajewski, AleksanderX > Subject: [dpdk-dev] [PATCH] app/test-crypto-perf: fix buffer not null > terminated

Re: [dpdk-dev] [PATCH v3 00/25] linux/eal: Remove most causes of panic on init

2017-02-09 Thread Stephen Hemminger
On Thu, 9 Feb 2017 09:29:28 -0500 Aaron Conole wrote: > In many cases, it's enough to simply let the application know that the > call to initialize DPDK has failed. A complete halt can then be > decided by the application based on error returned (and the app could > even attempt a possible re-a

Re: [dpdk-dev] [PATCH v3 25/25] rte_eal_init: add info about rte_errno codes

2017-02-09 Thread Stephen Hemminger
On Thu, 9 Feb 2017 09:29:53 -0500 Aaron Conole wrote: > + * The error codes returned via rte_errno: > + * EACCES indicates a permissions issue. > + * > + * EAGAIN indicates either a bus or system resource was not available, > + *try again. > + * > + * EALREADY indicates

Re: [dpdk-dev] [PATCH] app/crypto-perf: fix dereference null return value

2017-02-09 Thread De Lara Guarch, Pablo
Hi Slawomir, > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Slawomir > Mrozowicz > Sent: Monday, February 06, 2017 2:55 PM > To: Doherty, Declan > Cc: dev@dpdk.org; Mrozowicz, SlawomirX > Subject: [dpdk-dev] [PATCH] app/crypto-perf: fix dereference null return

Re: [dpdk-dev] [PATCH v2] cryptodev: fix segmentation fault

2017-02-09 Thread De Lara Guarch, Pablo
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of De Lara Guarch, > Pablo > Sent: Thursday, February 09, 2017 3:29 PM > To: Mrozowicz, SlawomirX; Doherty, Declan > Cc: dev@dpdk.org; Mrozowicz, SlawomirX > Subject: Re: [dpdk-dev] [PATCH v2] cryptodev: fix segmenta

Re: [dpdk-dev] [PATCH] crypto/aesni_mb: add missing digest length

2017-02-09 Thread De Lara Guarch, Pablo
> -Original Message- > From: Doherty, Declan > Sent: Tuesday, January 31, 2017 4:44 PM > To: dev@dpdk.org > Cc: De Lara Guarch, Pablo > Subject: Re: [dpdk-dev] [PATCH] crypto/aesni_mb: add missing digest > length > > On 27/01/17 13:16, Pablo de Lara wrote: > > AESNI MB now supports authe

Re: [dpdk-dev] [PATCH v2] mk: move libs that don't dependent PMD libs out of whole archive

2017-02-09 Thread Thomas Monjalon
2017-01-31 15:01, Ferruh Yigit: > During app build with static library, some libraries wrapped with > --whole-archive compiler flag. > > Wrapped libraries are mainly PMD libraries, this is required because PMD > APIs not called directly but run through callbacks registered via > constructor functi

Re: [dpdk-dev] [PATCH v4] ethtool: dispaly bus information

2017-02-09 Thread Thomas Monjalon
2017-01-04 20:18, Qiming Yang: > This patch enhances the ethtool example to support to show > bus information, in the same way that the Linux kernel > ethtool does. > > Signed-off-by: Qiming Yang > Acked-by: Remy Horton Applied, thanks

Re: [dpdk-dev] [PATCH v3 1/3] examples/ip_reassembly: add parse-ptype option

2017-02-09 Thread Thomas Monjalon
2017-02-09 22:25, Marvin Liu: > Add new option parse-ptype in this sample in case of pmd driver > not provide packet type info. If this option enabled, packet type > will be analyzed in Rx callback function. [...] > + if (parse_ptype) { > + if (add_cb_parse_ptype(por

[dpdk-dev] [PATCH v3] crypto/scheduler: fix initialization

2017-02-09 Thread Fan Zhang
Fixes the wrong slave initialization issue on start-up Fixes: 100e4f7e44ab ("crypto/scheduler: add round-robin mode") Signed-off-by: Fan Zhang --- drivers/crypto/scheduler/scheduler_roundrobin.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/crypto/scheduler/s

[dpdk-dev] [PATCH] crypto/scheduler: fix session backup

2017-02-09 Thread Fan Zhang
Fixes the missed session backup during enqueue. Fixes: 100e4f7e44ab ("crypto/scheduler: add round-robin mode") Signed-off-by: Fan Zhang --- drivers/crypto/scheduler/scheduler_roundrobin.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/crypto/scheduler/scheduler_roundrobin.c b/dr

[dpdk-dev] [PATCH v2] crypto/scheduler: fix initialization

2017-02-09 Thread Fan Zhang
Fixes the wrong slave initialization issue on start-up Fixes: 100e4f7("add round-robin mode") Signed-off-by: Fan Zhang --- v2: remove committed lines of code not relating to the topic drivers/crypto/scheduler/scheduler_roundrobin.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) d

Re: [dpdk-dev] [PATCH] examples/l2fwd-crypto: fix overflow

2017-02-09 Thread Zhang, Roy Fan
On 07/02/2017 14:17, Pablo de Lara wrote: This commit fixes an array overflow when number of crypto devices is higher than 32. Fixes: 387259bd6c67 ("examples/l2fwd-crypto: add sample application") Signed-off-by: Pablo de Lara Acked-by : Fan Zhang

Re: [dpdk-dev] [PATCH] examples/l2fwd-crypto: fix incorrect padding addition

2017-02-09 Thread Zhang, Roy Fan
On 09/02/2017 12:27, Pablo de Lara wrote: L2fwd-crypto app was padding an incoming buffer, to be aligned with the algorithm block size, in all cases. This was not the right approach, as padding is only necessary when using block cipher algorithms, such as AES-CBC. In case of using a stream ciph

[dpdk-dev] [PATCH 07/11] doc/prog_guide: use corelist instead of coremask

2017-02-09 Thread Keith Wiles
Signed-off-by: Keith Wiles --- doc/guides/prog_guide/kernel_nic_interface.rst | 2 +- doc/guides/prog_guide/link_bonding_poll_mode_drv_lib.rst | 10 +- doc/guides/prog_guide/multi_proc_support.rst | 2 +- 3 files changed, 7 insertions(+), 7 deletions(-) diff --git

[dpdk-dev] [PATCH 04/11] doc/howto: use corelist instead of coremask

2017-02-09 Thread Keith Wiles
Signed-off-by: Keith Wiles --- doc/guides/howto/flow_bifurcation.rst | 2 +- doc/guides/howto/lm_bond_virtio_sriov.rst | 6 +++--- doc/guides/howto/lm_virtio_vhost_user.rst | 6 +++--- 3 files changed, 7 insertions(+), 7 deletions(-) diff --git a/doc/guides/howto/flow_bifurcation.rst b/doc/

[dpdk-dev] [PATCH 05/11] doc/linux: use corelist instead of coremask

2017-02-09 Thread Keith Wiles
Signed-off-by: Keith Wiles --- doc/guides/linux_gsg/build_sample_apps.rst | 19 ++- doc/guides/linux_gsg/nic_perf_intel_platform.rst | 2 +- doc/guides/linux_gsg/quick_start.rst | 2 +- 3 files changed, 12 insertions(+), 11 deletions(-) diff --git a/doc/guides

[dpdk-dev] [PATCH 11/11] doc/sample_app: use corelist instead of coremask

2017-02-09 Thread Keith Wiles
Signed-off-by: Keith Wiles --- doc/guides/sample_app_ug/cmd_line.rst | 2 +- doc/guides/sample_app_ug/dist_app.rst | 2 +- doc/guides/sample_app_ug/exception_path.rst| 4 +-- doc/guides/sample_app_ug/hello_world.rst | 2 +- doc/guides/sample_app_ug/

[dpdk-dev] [PATCH 08/11] doc/testpmd: use corelist instead of coremask

2017-02-09 Thread Keith Wiles
Signed-off-by: Keith Wiles --- doc/guides/testpmd_app_ug/run_app.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/guides/testpmd_app_ug/run_app.rst b/doc/guides/testpmd_app_ug/run_app.rst index 38a4025..d1fabef 100644 --- a/doc/guides/testpmd_app_ug/run_app.rst +++ b/d

[dpdk-dev] [PATCH 06/11] doc/nics: use corelist instead of coremask

2017-02-09 Thread Keith Wiles
Signed-off-by: Keith Wiles --- doc/guides/nics/bnx2x.rst | 2 +- doc/guides/nics/cxgbe.rst | 4 ++-- doc/guides/nics/ena.rst | 2 +- doc/guides/nics/i40e.rst | 4 ++-- doc/guides/nics/intel_vf.rst | 7 +-- doc/guides/nics/ixgbe.rst | 4 ++-- doc/guides/nics/mlx4.

[dpdk-dev] [PATCH 09/11] doc/cryptoperf: use corelist instead of coremask

2017-02-09 Thread Keith Wiles
Signed-off-by: Keith Wiles --- doc/guides/tools/cryptoperf.rst | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/doc/guides/tools/cryptoperf.rst b/doc/guides/tools/cryptoperf.rst index 6832312..30994cd 100644 --- a/doc/guides/tools/cryptoperf.rst +++ b/doc/guides/tools/cryp

[dpdk-dev] [PATCH 10/11] doc/xen: use corelist instead of coremask

2017-02-09 Thread Keith Wiles
Signed-off-by: Keith Wiles --- doc/guides/xen/pkt_switch.rst | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/doc/guides/xen/pkt_switch.rst b/doc/guides/xen/pkt_switch.rst index 0b4ddfd..0d73fa5 100644 --- a/doc/guides/xen/pkt_switch.rst +++ b/doc/guides/xen/pkt_swit

[dpdk-dev] [PATCH 02/11] doc/faq: use corelist instead of coremask

2017-02-09 Thread Keith Wiles
Signed-off-by: Keith Wiles --- doc/guides/faq/faq.rst | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/doc/guides/faq/faq.rst b/doc/guides/faq/faq.rst index 5a324b2..98c1e33 100644 --- a/doc/guides/faq/faq.rst +++ b/doc/guides/faq/faq.rst @@ -54,7 +54,7 @@ If you need to cha

[dpdk-dev] [PATCH 00/11] moving away from coremask to corelist

2017-02-09 Thread Keith Wiles
The coremask option in DPDK is difficult to use and we should be promoting the use of the corelist (-l) option. The patch series adjusts the docs to use -l EAL option instead of the -c option. The patch series doc change only and is not required to be done in 17.02 release, but should be added to

[dpdk-dev] [PATCH 03/11] doc/freebsd: use corelist instead of coremask

2017-02-09 Thread Keith Wiles
Signed-off-by: Keith Wiles --- doc/guides/freebsd_gsg/build_sample_apps.rst | 9 + doc/guides/freebsd_gsg/install_from_ports.rst | 2 +- 2 files changed, 6 insertions(+), 5 deletions(-) diff --git a/doc/guides/freebsd_gsg/build_sample_apps.rst b/doc/guides/freebsd_gsg/build_sample_apps

[dpdk-dev] [PATCH 01/11] doc/cryptodev: use corelist instead of coremask

2017-02-09 Thread Keith Wiles
Signed-off-by: Keith Wiles --- doc/guides/cryptodevs/aesni_gcm.rst | 2 +- doc/guides/cryptodevs/aesni_mb.rst | 2 +- doc/guides/cryptodevs/kasumi.rst| 2 +- doc/guides/cryptodevs/null.rst | 2 +- doc/guides/cryptodevs/openssl.rst | 2 +- doc/guides/cryptodevs/snow3g.rst| 2 +- do

Re: [dpdk-dev] [PATCH v2] net/enic: fix hardcoding of some flow director masks

2017-02-09 Thread Ferruh Yigit
On 2/9/2017 5:43 PM, John Daley (johndale) wrote: > > >> -Original Message- >> From: Ferruh Yigit [mailto:ferruh.yi...@intel.com] >> Sent: Thursday, February 09, 2017 2:16 AM >> To: John Daley (johndale) >> Cc: dev@dpdk.org; sta...@dpdk.org >> Subject: Re: [PATCH v2] net/enic: fix hardco

Re: [dpdk-dev] [PATCH v1] doc: add distributor library API change notice

2017-02-09 Thread Thomas Monjalon
2017-02-09 17:02, Hunt, David: > On 9/2/2017 2:20 PM, Ferruh Yigit wrote: > > On 2/6/2017 8:08 AM, David Hunt wrote: > >> +* lib: distributor library API will be changed to incorporate a burst- > >> + oriented API. This will include a change to ``rte_distributor_create`` > >> + to specify which t

Re: [dpdk-dev] [PATCH] sched: fix segmentation fault when freeing port

2017-02-09 Thread Thomas Monjalon
> > Prevent a segmentation fault in rte_sched_port_free by only accessing > > the port structure after the NULL pointer check has been made. > > > > Fixes: 7b3c4f35 ("sched: fix releasing enqueued packets") > > > > Signed-off-by: Alan Dewar > > Signed-off-by: Jan Blunck > > Acked-by: Cristian

Re: [dpdk-dev] [PATCH v2] enic flow director fixes

2017-02-09 Thread John Daley (johndale)
> -Original Message- > From: Ferruh Yigit [mailto:ferruh.yi...@intel.com] > Sent: Thursday, February 09, 2017 4:15 AM > To: John Daley (johndale) > Cc: dev@dpdk.org > Subject: Re: [PATCH v2] enic flow director fixes > > On 2/9/2017 12:40 AM, John Daley wrote: > > This should replace > >

Re: [dpdk-dev] [PATCH v2] net/enic: fix hardcoding of some flow director masks

2017-02-09 Thread John Daley (johndale)
> -Original Message- > From: Ferruh Yigit [mailto:ferruh.yi...@intel.com] > Sent: Thursday, February 09, 2017 2:16 AM > To: John Daley (johndale) > Cc: dev@dpdk.org; sta...@dpdk.org > Subject: Re: [PATCH v2] net/enic: fix hardcoding of some flow director masks > > On 2/9/2017 12:40 AM,

Re: [dpdk-dev] [PATCH v2 3/3] doc: postpone ABI changes in igb_uio

2017-02-09 Thread Ferruh Yigit
On 2/9/2017 4:06 PM, Jianfeng Tan wrote: > This ABI changes to remove iomem and ioport mapping in igb_uio. The > purpose of this changes was to fix a bug: when DPDK app crashes, > those devices by igb_uio are not stopped either DPDK PMD driver or > igb_uio driver. > > Then it has been pointed out

Re: [dpdk-dev] [PATCH] Fix overwriting of dev_flags in rte_eth_dev after initialization

2017-02-09 Thread Ferruh Yigit
On 2/9/2017 4:40 PM, Ben Walker wrote: > rte_eth_copy_pci_info no longer sets RTE_ETH_DEV_DETACHABLE > as per my previous patch, but it still does initialize > the dev_flags. In a number of cases, a later assignment to > dev_flags to set RTE_ETH_DEV_DETACHABLE was overwriting > the previously initi

Re: [dpdk-dev] [PATCH] vfio: fix file descriptor leak in multi-process applications

2017-02-09 Thread Thomas Monjalon
> > When a secondary process wants access to the VFIO container file descriptor, > > the primary process calls vfio_get_container_fd() which always opens an > > entirely new file descriptor on /dev/vfio/vfio. > > However, once the file descriptor has been passed to the subprocess, it is > > effecti

Re: [dpdk-dev] [PATCH] crypto: fix incorrect key setting

2017-02-09 Thread Jain, Deepak K
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Pablo de Lara > Sent: Tuesday, February 7, 2017 10:50 PM > To: dev@dpdk.org > Cc: De Lara Guarch, Pablo ; > sta...@dpdk.org > Subject: [dpdk-dev] [PATCH] crypto: fix incorrect key setting > > When ciphering and au

Re: [dpdk-dev] [PATCH] crypto/scheduler: fix initialization

2017-02-09 Thread De Lara Guarch, Pablo
Hi Fan, > -Original Message- > From: Zhang, Roy Fan > Sent: Thursday, February 09, 2017 1:44 PM > To: dev@dpdk.org > Cc: De Lara Guarch, Pablo > Subject: [PATCH] crypto/scheduler: fix initialization > > Fixes the wrong slave initialization issue on start-up > > Fixes: 100e4f7("add round-

Re: [dpdk-dev] [PATCH v1] doc: add distributor library API change notice

2017-02-09 Thread Hunt, David
On 9/2/2017 2:20 PM, Ferruh Yigit wrote: On 2/6/2017 8:08 AM, David Hunt wrote: Given that the packet distributor library improvements (1) will not be in 17.02, I plan on doing some consolidation of the API for burst operation for 17.05, merging the two api's into one, with options for single o

[dpdk-dev] [PATCH v3 3/3] pci: Clarify interfaces for dynamic attach/detach of drivers

2017-02-09 Thread Ben Walker
There are now two functions - rte_eal_pci_attach_driver and rte_eal_pci_detach_driver - that dynamically attempt to attach and detach drivers from PCI devices. These only control whether a registered PCI driver is loaded or not - they are independent of whether the PCI device exists on the system.

[dpdk-dev] [PATCH v3 2/3] pci: Move driver registration above pci scan

2017-02-09 Thread Ben Walker
The user needs to register drivers before scanning, so it makes the most sense to put the registration functions above the scan function in the header file. Signed-off-by: Ben Walker --- Only rebased onto latest master with the rest of this series. No changes. lib/librte_eal/common/include/rte

[dpdk-dev] [PATCH v3 1/3] pci: rte_eal_pci_scan now handles removal of PCI devices

2017-02-09 Thread Ben Walker
rte_eal_pci_scan can be called repeatedly to re-scan the PCI bus. If a device was removed from the system, the associated driver will automatically be unloaded. Signed-off-by: Ben Walker --- Only code style changes compared to last submission. It is also rebased onto the latest from master, whic

Re: [dpdk-dev] [RFC 0/8] mbuf: structure reorganization

2017-02-09 Thread Ananyev, Konstantin
> -Original Message- > From: Morten Brørup [mailto:m...@smartsharesystems.com] > Sent: Thursday, February 9, 2017 4:20 PM > To: Ananyev, Konstantin > Cc: Olivier Matz ; dev@dpdk.org > Subject: RE: [dpdk-dev] [RFC 0/8] mbuf: structure reorganization > > > From: dev [mailto:dev-boun...@dp

Re: [dpdk-dev] [PATCH] eal: fix bug in x86 cmpset

2017-02-09 Thread Thomas Monjalon
2016-11-06 22:09, Thomas Monjalon: > 2016-09-29 18:34, Thomas Monjalon: > > 2016-09-30 02:54, Nikhil Rao: > > > The original code used movl instead of xchgl, this caused > > > rte_atomic64_cmpset to use ebx as the lower dword of the source > > > to cmpxchg8b instead of the lower dword of function a

[dpdk-dev] [PATCH] Fix overwriting of dev_flags in rte_eth_dev after initialization

2017-02-09 Thread Ben Walker
rte_eth_copy_pci_info no longer sets RTE_ETH_DEV_DETACHABLE as per my previous patch, but it still does initialize the dev_flags. In a number of cases, a later assignment to dev_flags to set RTE_ETH_DEV_DETACHABLE was overwriting the previously initialized value. Pointed out by Michael Larsen. Si

Re: [dpdk-dev] Kill off PCI dependencies

2017-02-09 Thread Thomas Monjalon
2017-02-08 14:56, Stephen Hemminger: > I am trying to make DPDK more agnostic about bus type. The existing API still > has hardwired into that ethernet devices are either PCI or not PCI (ie > pci_dev == NULL). > Jan, Jerin, and Shreyansh started the process but it hasn't gone far enough. > > It w

Re: [dpdk-dev] [RFC 0/8] mbuf: structure reorganization

2017-02-09 Thread Morten Brørup
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Ananyev, Konstantin > > > > > The main changes are: > > ... > > - change port and nb_segs to 16 bits > > Not that I am completely against it, > but changing nb_segs to 16 bits seems like an overkill to me. > I think we can keep and extra 8bit

Re: [dpdk-dev] [PATCH] Fill speed_capa for virtio

2017-02-09 Thread Thomas Monjalon
2017-02-02 12:05, Ido Barnea: > From: Ido Barnea > > Signed-off-by: Ido Barnea > --- > drivers/net/virtio/virtio_ethdev.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/net/virtio/virtio_ethdev.c > b/drivers/net/virtio/virtio_ethdev.c > index d1ff234..1d572b5 100644 > --- a/

[dpdk-dev] [PATCH v2 1/3] doc: add guide to use virtio_user for container networking

2017-02-09 Thread Jianfeng Tan
Signed-off-by: Jianfeng Tan --- .../use_models_for_running_dpdk_in_containers.svg | 574 ++ .../img/virtio_user_for_container_networking.svg | 638 + doc/guides/howto/index.rst | 1 + .../howto/virtio_user_for_container_networking.r

[dpdk-dev] [PATCH v2 3/3] doc: postpone ABI changes in igb_uio

2017-02-09 Thread Jianfeng Tan
This ABI changes to remove iomem and ioport mapping in igb_uio. The purpose of this changes was to fix a bug: when DPDK app crashes, those devices by igb_uio are not stopped either DPDK PMD driver or igb_uio driver. Then it has been pointed out by Stephen Hemminger that it has backward compatibili

[dpdk-dev] [PATCH v2 2/3] doc: add guide to use virtio_user as exceptional path

2017-02-09 Thread Jianfeng Tan
Signed-off-by: Jianfeng Tan --- .../howto/img/virtio_user_as_exceptional_path.svg | 386 + doc/guides/howto/index.rst | 1 + .../howto/virtio_user_as_exceptional_path.rst | 142 3 files changed, 529 insertions(+) create mode 100644 doc

[dpdk-dev] [PATCH v2 0/3] doc upates

2017-02-09 Thread Jianfeng Tan
v2: - Change svg files. - Postpone instead of remove ABI changes in igb_uio. Patch 1: howto doc of virtio_user for container networking. Patch 2: howto doc of virtio_user as exceptional path. Patch 3: postpone ABI changes in igb_uio Signed-off-by: Jianfeng Tan Jianfeng Tan (3): doc: add g

Re: [dpdk-dev] [PATCH 03/13] rte_ether: set PKT_RX_VLAN_STRIPPED in rte_vlan_strip()

2017-02-09 Thread Olivier MATZ
Hi, On Mon, 30 Jan 2017 10:54:08 +0100, Thomas Monjalon wrote: > It is fixing the introduction of the new flag PKT_RX_VLAN_STRIPPED. > > Fixes: b37b528d957c ("mbuf: add new Rx flags for stripped VLAN") > > This patch is applying the flag to the software emulation case > (currently only for virt

Re: [dpdk-dev] [PATCH v2] doc: add flow API to features list

2017-02-09 Thread Thomas Monjalon
> Signed-off-by: Nelio Laranjeiro Applied, thanks

Re: [dpdk-dev] [PATCH v2 0/2] update ixgbe doc

2017-02-09 Thread Ferruh Yigit
On 2/9/2017 1:27 AM, Wenzhuo Lu wrote: > 1, adjust the framework of the ixgbe doc. > 2, announce the MTU setting limitation. > > v2: > - split the patch to 2 to add more fixes. > > Wenzhuo Lu (2): > doc: fix framework of ixgbe doc > doc: announce ixgbe MTU setting limitation > > doc/guides/

Re: [dpdk-dev] [PATCH v2] net/i40e: set no drop for traffic class

2017-02-09 Thread Ferruh Yigit
On 2/7/2017 3:25 PM, Wu, Jingjing wrote: > > >> -Original Message- >> From: Sexton, Rory >> Sent: Thursday, January 19, 2017 6:38 PM >> To: Wu, Jingjing >> Cc: dev@dpdk.org; Marjanovic, Nemanja >> Subject: RE: [PATCH v2] net/i40e: set no drop for traffic class >> >> Perhaps the best sol

Re: [dpdk-dev] [PATCH v2] cryptodev: fix segmentation fault

2017-02-09 Thread De Lara Guarch, Pablo
Hi Slawomir, > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Slawomir > Mrozowicz > Sent: Friday, February 03, 2017 3:55 PM > To: Doherty, Declan > Cc: dev@dpdk.org; Mrozowicz, SlawomirX > Subject: [dpdk-dev] [PATCH v2] cryptodev: fix segmentation fault > > Thi

Re: [dpdk-dev] [PATCH v2] doc: add known issue for i40e PMD

2017-02-09 Thread Ferruh Yigit
On 2/9/2017 8:26 AM, Mcnamara, John wrote: > > >> -Original Message- >> From: Wu, Jingjing >> Sent: Thursday, February 9, 2017 6:42 AM >> To: dev@dpdk.org >> Cc: Wu, Jingjing ; Mcnamara, John >> >> Subject: [PATCH v2] doc: add known issue for i40e PMD >> >> Rx statistic is incorrect when

[dpdk-dev] [PATCH v2] doc: add flow API to features list

2017-02-09 Thread Nelio Laranjeiro
Signed-off-by: Nelio Laranjeiro --- Changes in v2: - add ixgbe and i40e. --- doc/guides/nics/features/default.ini | 1 + doc/guides/nics/features/i40e.ini| 1 + doc/guides/nics/features/ixgbe.ini | 1 + doc/guides/nics/features/mlx5.ini| 1 + doc/guides/nics/mlx5.rst | 1

Re: [dpdk-dev] [PATCH v3] app/test-crypto-perf: fix compilation under FreeBSD

2017-02-09 Thread Thomas Monjalon
2017-02-07 10:44, Daniel Mrzyglod: > This patch fixes error: implicit declaration of function 'getline' > > Fixes: f8be1786b1b8 ("app/crypto-perf: introduce performance test > application") > > Signed-off-by: Daniel Mrzyglod Applied, thanks

Re: [dpdk-dev] [PATCH] doc: update the document for virtio xstats feature

2017-02-09 Thread Thomas Monjalon
> > Currently, extended statistics has been supported by virtio. But there > > are no corresponding document updates. Therefore, this patch is to update > > the document for virtio xstats feature. > > > > Signed-off-by: Jiayu Hu > > Acked-by: Yuanhan Liu Fixes: 76d4c652e07d ("virtio: add exten

Re: [dpdk-dev] [dpdk-stable] [PATCH v2 1/2] doc: fix framework of ixgbe doc

2017-02-09 Thread Mcnamara, John
> -Original Message- > From: stable [mailto:stable-boun...@dpdk.org] On Behalf Of Wenzhuo Lu > Sent: Thursday, February 9, 2017 1:28 AM > To: dev@dpdk.org > Cc: Lu, Wenzhuo ; sta...@dpdk.org > Subject: [dpdk-stable] [PATCH v2 1/2] doc: fix framework of ixgbe doc > > The framework of the

Re: [dpdk-dev] [PATCH v2 2/2] doc: announce ixgbe MTU setting limitation

2017-02-09 Thread Mcnamara, John
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Wenzhuo Lu > Sent: Thursday, February 9, 2017 1:28 AM > To: dev@dpdk.org > Cc: Lu, Wenzhuo > Subject: [dpdk-dev] [PATCH v2 2/2] doc: announce ixgbe MTU setting > limitation > > Signed-off-by: Wenzhuo Lu Acked-

Re: [dpdk-dev] [PATCH] doc: add known issue for virtio TSO with clones

2017-02-09 Thread Thomas Monjalon
2017-02-06 15:10, Stephen Hemminger: > On Mon, 6 Feb 2017 14:16:53 +0100 > Olivier Matz wrote: > > > +**Implication**: > > + In this situation, the shared data will be modified by the driver, > > + potentially causing race conditions with the other users of the mbuf > > + data. > > This i

Re: [dpdk-dev] [PATCH] doc: update release notes for enic driver

2017-02-09 Thread Thomas Monjalon
2017-02-01 11:21, John Daley: > Signed-off-by: John Daley Applied, thanks

Re: [dpdk-dev] [PATCH] doc: add flow API to features list

2017-02-09 Thread Thomas Monjalon
2017-02-09 09:27, Nelio Laranjeiro: > Signed-off-by: Nelio Laranjeiro > --- > doc/guides/nics/features/default.ini | 1 + > doc/guides/nics/features/mlx5.ini| 1 + > doc/guides/nics/mlx5.rst | 1 + > 3 files changed, 3 insertions(+) You missed to add the feature check for ixgbe a

Re: [dpdk-dev] [PATCH] net/ixgbevf: fix stats update after a PF reset

2017-02-09 Thread Dai, Wei
Another way is to clear hw_stats->last_vfgprc/last_vfgorc/last_vfgptc/last_vfmprc at the same time PF is set down. > -Original Message- > From: Dai, Wei > Sent: Thursday, February 9, 2017 10:38 PM > To: 'Olivier Matz' ; dev@dpdk.org; Zhang, Helin > ; Ananyev, Konstantin > > Cc: Guo Feng

Re: [dpdk-dev] [PATCH v2 1/3] doc: note that the app list is incomplete

2017-02-09 Thread Thomas Monjalon
2016-12-06 17:53, Thomas Monjalon: > 2016-12-06 14:38, Baruch Siach: > > Extend the note at the end of Source Organization chapter to also mention > > the app directory. > > > > Signed-off-by: Baruch Siach > [...] > > --- a/doc/guides/prog_guide/source_org.rst > > +++ b/doc/guides/prog_guide/sour

  1   2   >