On 2/9/2017 5:43 PM, John Daley (johndale) wrote: > > >> -----Original Message----- >> From: Ferruh Yigit [mailto:[email protected]] >> Sent: Thursday, February 09, 2017 2:16 AM >> To: John Daley (johndale) <[email protected]> >> Cc: [email protected]; [email protected] >> Subject: Re: [PATCH v2] net/enic: fix hardcoding of some flow director masks >> >> On 2/9/2017 12:40 AM, John Daley wrote: >>> Hard coded mask values were being used for several of the IPv4 and >>> IPv6 fields. Use the values in the rte_eth_fdir_masks structure >>> provided by the caller. >>> >>> Fixes: dfbd6a9cb504 ("net/enic: extend flow director support for 1300 >>> series") >>> >>> Cc: [email protected] >>> Signed-off-by: John Daley <[email protected]> >>> --- >>> >>> v2: fix compile error >> >> I wasn't getting an error for this. >> >> V2 adds: >> >> - ipv6_val.vtc_flow = input->flow.ipv6_flow.tc << 16; >> + ipv6_val.vtc_flow = input->flow.ipv6_flow.tc << 12; >> >> What is the compile error this fixes? > > This patch had the compile error: > http://www.dpdk.org/dev/patchwork/patch/20147/ > + ipv6_mask.vtc_flow = masks->ipv6_mask.tc << 16);
I see, perhaps (don't remember) I fixed this while applying, because next-net was compiling fine.
