[dpdk-dev] [PATCH] app/testpmd: fix static build link ordering

2017-01-11 Thread Jerin Jacob
By introducing explicit -lrte_pmd_ixgbe link request in testpmd Makefile,"-Wl,-lrte_pmd_ixgbe" provided twice, and linker removes the duplication by keeping only first occurrence. This moves "-Wl,-lrte_pmd_ixgbe" out of "-Wl,--whole-archive" flag and makes symbol generation totally different than p

Re: [dpdk-dev] Port stats zero when using MLX5 DPDK driver

2017-01-11 Thread Shahaf Shuler
--Shahaf -Original Message- From: Thomas Monjalon [mailto:thomas.monja...@6wind.com] Sent: Wednesday, January 11, 2017 3:47 PM To: Shahaf Shuler Cc: dev@dpdk.org; george@gmail.com Subject: Re: [dpdk-dev] Port stats zero when using MLX5 DPDK driver > > On Mon, Jan 9, 2017 at 2:32

[dpdk-dev] [PATCH v8 4/5] net/i40e: add firmware version get

2017-01-11 Thread Qiming Yang
This patch add a new function i40e_fw_version_get. Signed-off-by: Qiming Yang Acked-by: Remy Horton --- doc/guides/nics/features/i40e.ini | 1 + drivers/net/i40e/i40e_ethdev.c| 33 + 2 files changed, 34 insertions(+) diff --git a/doc/guides/nics/features/i4

[dpdk-dev] [PATCH v8 5/5] ethtool: display firmware version

2017-01-11 Thread Qiming Yang
This patch enhances the ethtool example to support to show firmware version, in the same way that the Linux kernel ethtool does. Signed-off-by: Qiming Yang Acked-by: Remy Horton --- examples/ethtool/ethtool-app/ethapp.c | 1 + examples/ethtool/lib/rte_ethtool.c| 6 ++ 2 files changed, 7

[dpdk-dev] [PATCH v8 2/5] net/e1000: add firmware version get

2017-01-11 Thread Qiming Yang
This patch adds a new function eth_igb_fw_version_get. Signed-off-by: Qiming Yang Acked-by: Remy Horton --- doc/guides/nics/features/igb.ini | 1 + drivers/net/e1000/igb_ethdev.c | 56 2 files changed, 57 insertions(+) diff --git a/doc/guides/nics/fe

[dpdk-dev] [PATCH v8 1/5] ethdev: add firmware version get

2017-01-11 Thread Qiming Yang
This patch adds a new API 'rte_eth_dev_fw_version_get' for fetching firmware version by a given device. Signed-off-by: Qiming Yang Acked-by: Remy Horton --- doc/guides/nics/features/default.ini | 1 + doc/guides/rel_notes/deprecation.rst | 4 doc/guides/rel_notes/release_17_02.rst |

[dpdk-dev] [PATCH v8 3/5] net/ixgbe: add firmware version get

2017-01-11 Thread Qiming Yang
This patch adds a new function ixgbe_fw_version_get. Signed-off-by: Qiming Yang Acked-by: Remy Horton --- doc/guides/nics/features/ixgbe.ini | 1 + drivers/net/ixgbe/ixgbe_ethdev.c | 26 ++ 2 files changed, 27 insertions(+) diff --git a/doc/guides/nics/features/ixgbe

[dpdk-dev] [PATCH v8 0/5] new API 'rte_eth_dev_fw_version_get'

2017-01-11 Thread Qiming Yang
v8: - defined the minimum fw version size as a macro. v7: - rebased v6: - renamed fw_length -> fw_size - added return value for insufficient fw_size - fixed the indentation problem in e1000 - added ver.build.patch in i40e, keep the same with Linux kernel driver v5: - modified the API

[dpdk-dev] [PATCH v2 2/2] maintainers: split virtio and vhost

2017-01-11 Thread Yuanhan Liu
Signed-off-by: Yuanhan Liu Acked-by: John McNamara --- v2: split virtio and vhost --- MAINTAINERS | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index ca0c276..f9b3f5e 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -366,16 +366,21 @@ M:

[dpdk-dev] [PATCH v2 0/2] maintainers: minor updates to virtio/vhost

2017-01-11 Thread Yuanhan Liu
v2: split virtio and vhost --- Yuanhan Liu (2): maintainers: update virtio maintainer maintainers: split virtio and vhost MAINTAINERS | 12 1 file changed, 8 insertions(+), 4 deletions(-) -- 1.9.0

[dpdk-dev] [PATCH v2 1/2] maintainers: update virtio maintainer

2017-01-11 Thread Yuanhan Liu
Huawei has left DPDK team for months, and he hasn't showed up since then. Remove him. Cc: Huawei Xie Signed-off-by: Yuanhan Liu Acked-by: John McNamara --- MAINTAINERS | 1 - 1 file changed, 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index 9645c9b..ca0c276 100644 --- a/MAINTAINERS +

[dpdk-dev] [PATCH 1/2] net/virtio: access interrupt handler directly

2017-01-11 Thread Yuanhan Liu
Since commit 0e1b45a284b4 ("ethdev: decouple interrupt handling from PCI device"), intr_handle is stored at eth_dev struct, that we could use it directly. Thus there is no need to get it from hw. Signed-off-by: Yuanhan Liu --- drivers/net/virtio/virtio_ethdev.c | 9 - drivers/net/virtio/

[dpdk-dev] [PATCH 2/2] net/virtio: do not store PCI device pointer at shared memory

2017-01-11 Thread Yuanhan Liu
hw->dev, a pointer to pci_dev, was actually not used, until the refactor of decouping from PCI device. This would somehow break the multiple process again, since "hw" is stored at shared memory, while "pci_dev" is not: the primary and secondary process could have different address for it, while jus

Re: [dpdk-dev] [PATCH v3 6/6] net/virtio: remove dead structure field

2017-01-11 Thread Yuanhan Liu
On Fri, Jan 06, 2017 at 06:16:20PM +0800, Yuanhan Liu wrote: > Actually, virtio_hw->dev is not used since the beginning when it's > introduced. Remove it. It's not true after the refactoring of decoupling from PCI device. This patch is dropped. Instead, two more patches will be sent soon.

Re: [dpdk-dev] [PATCH 1/2] add rte_bus->probe

2017-01-11 Thread Shreyansh Jain
> -Original Message- > From: Ferruh Yigit [mailto:ferruh.yi...@intel.com] > Sent: Wednesday, January 11, 2017 8:34 PM > To: Shreyansh Jain ; dev@dpdk.org > Cc: Stephen Hemminger ; Jan Blunck > > Subject: Re: [PATCH 1/2] add rte_bus->probe > > On 1/11/2017 4:53 AM, Shreyansh Jain wrote: >

Re: [dpdk-dev] [PATCH v6] vhost: allow for many vhost user ports

2017-01-11 Thread Yuanhan Liu
On Wed, Dec 21, 2016 at 05:45:13PM +0800, Yuanhan Liu wrote: > From: Jan Wickbom > > Currently select() is used to monitor file descriptors for vhostuser > ports. This limits the number of ports possible to create since the > fd number is used as index in the fd_set and we have seen fds > 1023. >

Re: [dpdk-dev] [PATCH] vhost: Introduce vhost-user's REPLY_ACK feature

2017-01-11 Thread Yuanhan Liu
On Mon, Dec 12, 2016 at 06:54:00PM +0100, Maxime Coquelin wrote: > REPLY_ACK features provide a generic way for QEMU to ensure both > completion and success of a request. > > As described in vhost-user spec in QEMU repository, QEMU sets > VHOST_USER_NEED_REPLY flag (bit 3) when expecting a reply_a

Re: [dpdk-dev] [PATCH v5 00/29] Support VFD and DPDK PF + kernel VF on i40e

2017-01-11 Thread Chen, Jing D
Hi, Vincent, > -Original Message- > From: Vincent JARDIN [mailto:vincent.jar...@6wind.com] > Sent: Tuesday, January 10, 2017 9:30 PM > To: Scott Daniels ; dev@dpdk.org > Cc: kaust...@research.att.com; az5...@att.com; Chen, Jing D > > Subject: Re: [dpdk-dev] [PATCH v5 00/29] Support VFD an

[dpdk-dev] [PATCH v5] app/testpmd: supported offload capabilities query

2017-01-11 Thread Qiming Yang
Add two new commands "show port cap " and "show port cap all"to diaplay what offload capabilities supported in ports. It will not only display all the capabilities of the port, but also the enabling condition for each capability in the running time. Signed-off-by: Qiming Yang Acked-by: Jingjing W

[dpdk-dev] [PATCH v2] doc: add known uio_pci_generic issue for i40e

2017-01-11 Thread Jeff Guo
From: "Guo, Jia" When bind with uio_pci_generic in X710/XL710/XXV710, the result is failed. uio_pci_generic is not supported by X710/XL710/XXV710. Signed-off-by: Guo, Jia --- v2: add X710/XXV710 limitation case --- doc/guides/rel_notes/known_issues.rst | 24 1 file cha

Re: [dpdk-dev] [PATCH v8 00/25] Support VFD on i40e

2017-01-11 Thread Lu, Wenzhuo
Hi Vincent, > -Original Message- > From: Vincent JARDIN [mailto:vincent.jar...@6wind.com] > Sent: Wednesday, January 11, 2017 9:14 PM > To: Yigit, Ferruh; Zhang, Helin; Lu, Wenzhuo; dev@dpdk.org > Cc: 'JOSHI, KAUSTUBH'; 'DANIELS, EDWARD'; 'ZELEZNIAK, ALEX' > Subject: Re: [dpdk-dev] [PATCH

Re: [dpdk-dev] [PATCH v4] ethdev: fix port data mismatched in multiple process model

2017-01-11 Thread Yuanhan Liu
On Wed, Jan 11, 2017 at 02:32:03PM +0100, Thomas Monjalon wrote: > 2017-01-10 22:33, Yuanhan Liu: > > On Mon, Jan 09, 2017 at 06:08:04PM +0100, Thomas Monjalon wrote: > > > Hi Yuanhan, > > > > > > Nit: the title should be "v4 1/6" > > > > Oops, my bad. > > > > > Except that, good patch :) > > >

Re: [dpdk-dev] [PATCH v2] examples/vhost: fix the wrong initialization of lcore_ids

2017-01-11 Thread Yuanhan Liu
On Wed, Jan 11, 2017 at 03:59:46AM -0500, Yong Wang wrote: > when "TAILQ_INIT()" was added to the loop of "for (lcore_id = 0; ...)" > statement, the assignment to "lcore_ids" was removed out of the loop. > It changed the original initialization of "lcore_ids". opps and nice catch! Thanks. > >

Re: [dpdk-dev] [PATCH] examples/vhost: fix calc err of nr_mbufs_per_core

2017-01-11 Thread Yuanhan Liu
On Wed, Jan 11, 2017 at 10:52:17PM -0500, Yong Wang wrote: > When calculating 'nr_mbufs_per_core', 'MAX_PKT_BURST' was mutiplied > twice. Fix it by removing one of them. > > Fixes: bdb19b771e6f ("examples/vhost: fix mbuf allocation failure") > > Signed-off-by: Yong Wang Applied to dpdk-next-vir

[dpdk-dev] [PATCH] examples/vhost: fix calc err of nr_mbufs_per_core

2017-01-11 Thread Yong Wang
When calculating 'nr_mbufs_per_core', 'MAX_PKT_BURST' was mutiplied twice. Fix it by removing one of them. Fixes: bdb19b771e6f ("examples/vhost: fix mbuf allocation failure") Signed-off-by: Yong Wang --- examples/vhost/main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/e

Re: [dpdk-dev] [PATCH v5 3/8] ethdev: reserve capability flags for PMD-specific API

2017-01-11 Thread Yuanhan Liu
On Wed, Jan 11, 2017 at 06:32:48PM +0100, Olivier MATZ wrote: > Generally speaking, we have to be careful when introducing new mbuf > flags, since we don't have so much of them (~25 remaining out of 64, > which mean we may run out of them in 3-4 years). > > In this particular case, despite the fla

Re: [dpdk-dev] [dpdk-stable] [PATCH 1/2] net/virtio: fix performance regression due to TSO enabling

2017-01-11 Thread Yuanhan Liu
On Wed, Jan 11, 2017 at 03:51:22PM +0100, Thomas Monjalon wrote: > 2017-01-11 12:27, Yuanhan Liu: > > The fact that virtio net header is initiated to zero in PMD driver > > init stage means that these costly writes are unnecessary and could > > be avoided: > > > > if (hdr->csum_start != 0) > >

Re: [dpdk-dev] [PATCH v5 3/8] ethdev: reserve capability flags for PMD-specific API

2017-01-11 Thread Tiwei Bie
On Wed, Jan 11, 2017 at 06:32:48PM +0100, Olivier MATZ wrote: > Hi Tiwei, Hi Thomas, > > On Mon, 09 Jan 2017 12:26:53 +0100, Thomas Monjalon > wrote: > > 2017-01-09 11:57, Tiwei Bie: > > > On Sun, Jan 08, 2017 at 08:39:55PM +0800, Ananyev, Konstantin > > > wrote: > > > > > Well my first reply t

Re: [dpdk-dev] [PATCH v2 1/3] ethdev: new API to free consumed buffers in Tx ring

2017-01-11 Thread Stephen Hemminger
On Wed, 11 Jan 2017 15:03:21 -0500 Billy McFall wrote: > /** > + * Request the driver to free mbufs currently cached by the driver. The > + * driver will only free the mbuf if it is no longer in use. It is the > + * application's responsibity to ensure rte_eth_tx_buffer_flush(..) is > + * called

Re: [dpdk-dev] [PATCH v2 3/3] net/vhost: vHost support to free consumed buffers

2017-01-11 Thread Stephen Hemminger
On Wed, 11 Jan 2017 15:03:23 -0500 Billy McFall wrote: > Add support to the vHostdriver for the new API to force free consumed > buffers on Tx ring. vHost does not cache the mbufs so there is no work > to do. > > Signed-off-by: Billy McFall > --- > drivers/net/vhost/rte_eth_vhost.c | 11 ++

Re: [dpdk-dev] [PATCH v7 2/5] net/e1000: add firmware version get

2017-01-11 Thread Yang, Qiming
-Original Message- From: Horton, Remy Sent: Wednesday, January 11, 2017 11:45 PM To: Yang, Qiming ; dev@dpdk.org Cc: Yigit, Ferruh Subject: Re: [PATCH v7 2/5] net/e1000: add firmware version get On 11/01/2017 06:41, Qiming Yang wrote: > This patch adds a new function eth_igb_fw_version_

Re: [dpdk-dev] [PATCH 8/8] eal: VMBUS infrastructure

2017-01-11 Thread Stephen Hemminger
On Wed, 11 Jan 2017 22:13:32 +0100 Jan Blunck wrote: > >> +static void *vmbus_map_addr; > >> + > >> +static struct rte_tailq_elem rte_vmbus_uio_tailq = { > >> + .name = "UIO_RESOURCE_LIST", > > This should be VMBUS_UIO_RESOURCE_LIST to not collide with rte_uio_tailq. Ok, please trim rev

Re: [dpdk-dev] [PATCH] app/testpmd: fix ixgbe private API calling

2017-01-11 Thread Lu, Wenzhuo
Hi Bernard, > -Original Message- > From: Iremonger, Bernard > Sent: Wednesday, January 11, 2017 6:27 PM > To: Lu, Wenzhuo; dev@dpdk.org > Cc: Wu, Jingjing; sta...@dpdk.org > Subject: RE: [dpdk-dev] [PATCH] app/testpmd: fix ixgbe private API calling > > Hi Wenzhuo, > > > > -Original

Re: [dpdk-dev] [PATCH 8/8] eal: VMBUS infrastructure

2017-01-11 Thread Jan Blunck
On Wed, Jan 11, 2017 at 3:49 PM, Jan Blunck wrote: > On Sat, Jan 7, 2017 at 7:17 PM, Stephen Hemminger > wrote: >> Add support for VMBUS on Hyper-V/Azure. VMBUS is similar to PCI >> but has different addressing and internal API's. >> >> Signed-off-by: Stephen Hemminger >> --- >> lib/librte_eal/

[dpdk-dev] [PATCH v2 0/3] new API to free consumed buffers in Tx ring

2017-01-11 Thread Billy McFall
Based on a request from Damjan Marion and seconded by Keith Wiles, see dpdk-dev mailing list from 11/21/2016, add a new API to free consumed buffers on TX ring. This addresses two scenarios: 1) Flooding a packet and want to reuse existing mbuf to avoid a packet copy. Increment the reference count o

[dpdk-dev] [PATCH v2 3/3] net/vhost: vHost support to free consumed buffers

2017-01-11 Thread Billy McFall
Add support to the vHostdriver for the new API to force free consumed buffers on Tx ring. vHost does not cache the mbufs so there is no work to do. Signed-off-by: Billy McFall --- drivers/net/vhost/rte_eth_vhost.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/drivers/net/vhost

[dpdk-dev] [PATCH v2 2/3] net/e1000: e1000 igb support to free consumed buffers

2017-01-11 Thread Billy McFall
Add support to the e1000 igb driver for the new API to force free consumed buffers on Tx ring. e1000 igb driver does not implement a tx_rs_thresh to free mbufs, it frees a slot in the ring as needed, so a new function needed to be written. Signed-off-by: Billy McFall --- drivers/net/e1000/e1000_

[dpdk-dev] [PATCH v2 1/3] ethdev: new API to free consumed buffers in Tx ring

2017-01-11 Thread Billy McFall
Add a new API to force free consumed buffers on Tx ring. API will return the number of packets freed (0-n) or error code if feature not supported (-ENOTSUP) or input invalid (-ENODEV). Signed-off-by: Billy McFall --- lib/librte_ether/rte_ethdev.h | 43 +++

Re: [dpdk-dev] [PATCH 3/3] driver: vHost support to free consumed buffers

2017-01-11 Thread Billy McFall
This new API is attempting to address two scenarios: 1) Application wants to reuse existing mbuf to avoid a packet copy (example: Flooding a packet to multiple ports). The application increments the reference count of the packet and then polls new API until the reference count for the given mbuf is

Re: [dpdk-dev] [dpdk-users] Pktgen DPDK net bonding mode 4 802.3AD (LACP) not working with BIGIP trunk with LACP enabled

2017-01-11 Thread Vincent Li
On Wed, Jan 11, 2017 at 10:51 AM, Wiles, Keith wrote: > > > On Jan 11, 2017, at 12:08 PM, Vincent Li > wrote: > > > > Hi, > > > > I have direct two cable connections between Pktgen DPDK box and BIGIP > > > > this is a problem I am not sure if it Pktgen, or the DPDK net bonding > mode > > 4 LACP,

Re: [dpdk-dev] Coverity project created for dpdk-next-net tree

2017-01-11 Thread Ferruh Yigit
On 11/21/2016 11:29 PM, Ferruh Yigit wrote: > Coverity project created for dpdk-next-net tree: > https://scan.coverity.com/projects/dpdk-next-net > > This can be useful to fix coverity issues before next-net merged into > master branch. > > Project is open for everyone to register and to get scan

Re: [dpdk-dev] [PATCH] kni: use bulk functions to allocate and free mbufs

2017-01-11 Thread Stephen Hemminger
On Wed, 11 Jan 2017 18:41:28 + Ferruh Yigit wrote: > On 1/11/2017 6:25 PM, Ananyev, Konstantin wrote: > > > > > >> -Original Message- > >> From: Yigit, Ferruh > >> Sent: Wednesday, January 11, 2017 5:48 PM > >> To: Ananyev, Konstantin ; Stephen Hemminger > >> > >> Cc: Sergey Vya

Re: [dpdk-dev] [dpdk-users] Pktgen DPDK net bonding mode 4 802.3AD (LACP) not working with BIGIP trunk with LACP enabled

2017-01-11 Thread Wiles, Keith
> On Jan 11, 2017, at 12:08 PM, Vincent Li wrote: > > Hi, > > I have direct two cable connections between Pktgen DPDK box and BIGIP > > this is a problem I am not sure if it Pktgen, or the DPDK net bonding mode > 4 LACP, or the BIGIP trunk with LACP enabled issue, I am hoping someone > here ha

Re: [dpdk-dev] [PATCH] kni: use bulk functions to allocate and free mbufs

2017-01-11 Thread Ferruh Yigit
On 1/11/2017 6:25 PM, Ananyev, Konstantin wrote: > > >> -Original Message- >> From: Yigit, Ferruh >> Sent: Wednesday, January 11, 2017 5:48 PM >> To: Ananyev, Konstantin ; Stephen Hemminger >> >> Cc: Sergey Vyazmitinov ; >> olivier.m...@6wind.com; dev@dpdk.org >> Subject: Re: [dpdk-dev

Re: [dpdk-dev] [PATCH] kni: use bulk functions to allocate and free mbufs

2017-01-11 Thread Ananyev, Konstantin
> -Original Message- > From: Yigit, Ferruh > Sent: Wednesday, January 11, 2017 5:48 PM > To: Ananyev, Konstantin ; Stephen Hemminger > > Cc: Sergey Vyazmitinov ; olivier.m...@6wind.com; > dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] kni: use bulk functions to allocate and free > mbu

Re: [dpdk-dev] [PATCH v2] net/ixgbe: fix API parameter checking

2017-01-11 Thread Ferruh Yigit
On 1/11/2017 5:24 PM, Bernard Iremonger wrote: > Add checks to rte_pmd_ixgbe_* API's to ensure that the port > is an ixgbe port. > > Fixes: 49e248223e9f ("net/ixgbe: add API for VF management") > > CC: sta...@dpdk.org > Signed-off-by: Bernard Iremonger Acked-by: Ferruh Yigit Applied to dpdk-n

[dpdk-dev] Pktgen DPDK net bonding mode 4 802.3AD (LACP) not working with BIGIP trunk with LACP enabled

2017-01-11 Thread Vincent Li
Hi, I have direct two cable connections between Pktgen DPDK box and BIGIP this is a problem I am not sure if it Pktgen, or the DPDK net bonding mode 4 LACP, or the BIGIP trunk with LACP enabled issue, I am hoping someone here have more clue and give me some direction on how to trouble shoot this.

Re: [dpdk-dev] [dpdk-stable] [PATCH] app/testpmd: fix ixgbe private API calling

2017-01-11 Thread Ferruh Yigit
On 1/11/2017 4:29 PM, Iremonger, Bernard wrote: > Hi Ferruh, > >> -Original Message- >> From: Yigit, Ferruh >> Sent: Wednesday, January 11, 2017 4:19 PM >> To: Iremonger, Bernard ; Lu, Wenzhuo >> ; dev@dpdk.org >> Cc: Wu, Jingjing ; sta...@dpdk.org >> Subject: Re: [dpdk-stable] [dpdk-dev]

Re: [dpdk-dev] [PATCH] net/enic: remove unnecessary function parameter attributes

2017-01-11 Thread Ferruh Yigit
On 1/11/2017 3:42 AM, John Daley wrote: > Remove __rte_unused attributes in function declaration when > the parameters really are used. > > Fixes: dfbd6a9cb504 ("net/enic: extend flow director support for 1300 series") > > CC: sta...@dpdk.org > Signed-off-by: John Daley Applied to dpdk-next-net

Re: [dpdk-dev] [PATCH] net/enic: use new Rx checksum flags

2017-01-11 Thread Ferruh Yigit
On 1/11/2017 3:42 AM, John Daley wrote: > Use the new L3 and L4 ..CKSUM_GOOD and ..CKSUM_UNKNOWN flags to > distinguish good checksums from unknown ones. > > Signed-off-by: John Daley Applied to dpdk-next-net/master, thanks.

Re: [dpdk-dev] [PATCH v3 1/1] i40e: improve message grepability

2017-01-11 Thread Ferruh Yigit
On 1/11/2017 5:50 PM, Ferruh Yigit wrote: > On 1/11/2017 5:13 PM, Michał Mirosław wrote: >> From: Michał Mirosław >> >> Join message lines for easier grepping. >> PRIxXX are left glued to strings as they are in other parts of the file. >> >> Signed-off-by: Michał Mirosław > > Acked-by: Ferruh Yi

Re: [dpdk-dev] [PATCH v3 1/1] i40e: improve message grepability

2017-01-11 Thread Ferruh Yigit
On 1/11/2017 5:13 PM, Michał Mirosław wrote: > From: Michał Mirosław > > Join message lines for easier grepping. > PRIxXX are left glued to strings as they are in other parts of the file. > > Signed-off-by: Michał Mirosław Acked-by: Ferruh Yigit

Re: [dpdk-dev] [PATCH] kni: use bulk functions to allocate and free mbufs

2017-01-11 Thread Ferruh Yigit
On 1/11/2017 5:43 PM, Ananyev, Konstantin wrote: > > >> -Original Message- >> From: Stephen Hemminger [mailto:step...@networkplumber.org] >> Sent: Wednesday, January 11, 2017 5:36 PM >> To: Ananyev, Konstantin >> Cc: Sergey Vyazmitinov ; >> olivier.m...@6wind.com; Yigit, Ferruh ; dev@dp

Re: [dpdk-dev] [PATCH] kni: use bulk functions to allocate and free mbufs

2017-01-11 Thread Ananyev, Konstantin
> -Original Message- > From: Stephen Hemminger [mailto:step...@networkplumber.org] > Sent: Wednesday, January 11, 2017 5:36 PM > To: Ananyev, Konstantin > Cc: Sergey Vyazmitinov ; olivier.m...@6wind.com; > Yigit, Ferruh ; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] kni: use bulk func

Re: [dpdk-dev] [PATCH v6 1/6] mbuf: add flag for MACsec

2017-01-11 Thread Olivier MATZ
On Wed, 11 Jan 2017 12:31:33 +0800, Tiwei Bie wrote: > Add a new Tx flag in mbuf, that can be set by applications to > enable the MACsec offload for a packet to be transmitted. > > Signed-off-by: Tiwei Bie Acked-by: Olivier Matz

Re: [dpdk-dev] [PATCH 4/7] kni: remove useless return statements

2017-01-11 Thread Ferruh Yigit
On 1/9/2017 11:30 PM, Stephen Hemminger wrote: > A return statement at end of void function is unnecessary. > > Signed-off-by: Stephen Hemminger > --- > lib/librte_eal/linuxapp/kni/ethtool/igb/e1000_82575.c | 4 > lib/librte_eal/linuxapp/kni/ethtool/igb/e1000_i210.c| 2 -- > lib/lib

Re: [dpdk-dev] [PATCH] kni: use bulk functions to allocate and free mbufs

2017-01-11 Thread Stephen Hemminger
On Wed, 11 Jan 2017 17:28:21 + "Ananyev, Konstantin" wrote: > > -Original Message- > > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Stephen Hemminger > > Sent: Wednesday, January 11, 2017 4:18 PM > > To: Sergey Vyazmitinov > > Cc: olivier.m...@6wind.com; Yigit, Ferruh ; > >

Re: [dpdk-dev] [PATCH v5 3/8] ethdev: reserve capability flags for PMD-specific API

2017-01-11 Thread Olivier MATZ
Hi Tiwei, Hi Thomas, On Mon, 09 Jan 2017 12:26:53 +0100, Thomas Monjalon wrote: > 2017-01-09 11:57, Tiwei Bie: > > On Sun, Jan 08, 2017 at 08:39:55PM +0800, Ananyev, Konstantin > > wrote: > > > > Well my first reply to this thread was asking why isn't the > > > > whole API global from the start

Re: [dpdk-dev] [PATCH] kni: fast data availability check in thread_single loop

2017-01-11 Thread Ferruh Yigit
On 12/29/2016 11:23 PM, Sergey Vyazmitinov wrote: > This allow to significant reduces packets processing latency. > > Signed-off-by: Sergey Vyazmitinov > --- > .../linuxapp/eal/include/exec-env/rte_kni_common.h | 6 > lib/librte_eal/linuxapp/kni/kni_misc.c | 33 > +

Re: [dpdk-dev] [PATCH] kni: use bulk functions to allocate and free mbufs

2017-01-11 Thread Ananyev, Konstantin
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Stephen Hemminger > Sent: Wednesday, January 11, 2017 4:18 PM > To: Sergey Vyazmitinov > Cc: olivier.m...@6wind.com; Yigit, Ferruh ; > dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] kni: use bulk functions to al

[dpdk-dev] [PATCH v2] net/ixgbe: fix API parameter checking

2017-01-11 Thread Bernard Iremonger
Add checks to rte_pmd_ixgbe_* API's to ensure that the port is an ixgbe port. Fixes: 49e248223e9f ("net/ixgbe: add API for VF management") CC: sta...@dpdk.org Signed-off-by: Bernard Iremonger --- Changes in v2: Moved pmd checks into new function is_ixgbe_pmd. drivers/net/ixgbe/ixgbe_ethdev.c |

[dpdk-dev] [PATCH v3 1/1] i40e: improve message grepability

2017-01-11 Thread Michał Mirosław
From: Michał Mirosław Join message lines for easier grepping. PRIxXX are left glued to strings as they are in other parts of the file. Signed-off-by: Michał Mirosław --- v2: move long strings on a line by themselves v3: indent modified lines with TAB only Change-Id: Idbaa3392d8112f96a9f15818f6

[dpdk-dev] [PATCH 0/2] crypto: add user defined name initializing parameter

2017-01-11 Thread Fan Zhang
This patchset adds a user defined name initializing parameter to all software cryptodevs. Fan Zhang (2): cryptodev: add user defined name initializing parameter to software PMD crypto: add user defined name initializing parameter parsing to software PMDs drivers/crypto/aesni_gcm/aesn

[dpdk-dev] [PATCH 2/2] crypto: add user defined name initializing parameter parsing to software PMDs

2017-01-11 Thread Fan Zhang
This patch adds user defined name parsing feature to software PMDs. Signed-off-by: Fan Zhang --- drivers/crypto/aesni_gcm/aesni_gcm_pmd.c | 58 ++-- drivers/crypto/aesni_mb/rte_aesni_mb_pmd.c | 61 ++ drivers/crypto/kasumi/rte_kasumi_pmd.c

[dpdk-dev] [PATCH 1/2] cryptodev: add user defined name initializing parameter to software PMD

2017-01-11 Thread Fan Zhang
This patch adds a user defined name initializing parameter to cryptodev library. Originally, for software cryptodev PMD, the vdev name parameter is treated as the driver identifier, and will create an unique name for each device automatically, which is not necessarily as same as the vdev parameter

[dpdk-dev] [PATCH v3 2/3] pci: Separate detaching ethernet ports from PCI devices

2017-01-11 Thread Ben Walker
Attaching and detaching ethernet ports from an application is not the same thing as physically removing a PCI device, so clarify the flags indicating support. All PCI devices are assumed to be physically removable, so no flag is necessary in the PCI layer. Signed-off-by: Ben Walker --- doc/guide

[dpdk-dev] [PATCH v3 3/3] pci: Pass rte_pci_addr to functions instead of separate args

2017-01-11 Thread Ben Walker
Instead of passing domain, bus, devid, func, just pass an rte_pci_addr. Signed-off-by: Ben Walker --- lib/librte_eal/linuxapp/eal/eal_pci.c | 32 +--- 1 file changed, 13 insertions(+), 19 deletions(-) diff --git a/lib/librte_eal/linuxapp/eal/eal_pci.c b/lib/librte_e

[dpdk-dev] [PATCH v3 1/3] pci: If a driver's probe function fails, unmap resources.

2017-01-11 Thread Ben Walker
If resources were mapped prior to probe, unmap them if probe fails. This does not handle the case where the kernel driver was forcibly unbound prior to probe. Signed-off-by: Ben Walker --- lib/librte_eal/common/eal_common_pci.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --g

Re: [dpdk-dev] [dpdk-stable] [PATCH] net/ixgbe: fix API parameter checking

2017-01-11 Thread Iremonger, Bernard
Hi Ferruh, > -Original Message- > From: Yigit, Ferruh > Sent: Wednesday, January 11, 2017 3:15 PM > To: Iremonger, Bernard ; dev@dpdk.org; > Lu, Wenzhuo > Cc: sta...@dpdk.org > Subject: Re: [dpdk-stable] [PATCH] net/ixgbe: fix API parameter checking > > On 1/11/2017 2:25 PM, Bernard Irem

[dpdk-dev] [PATCH] net/virtio: fix advertised Rx offload capabilities

2017-01-11 Thread Olivier Matz
When the virtio PMD is used on top of a vhost that does not support offloads, Rx offload capabilities are still advertised by virtio_dev_info_get(). But if an application tries to start the PMD with Rx offloads enabled (rxmode.hw_ip_checksum = 1), the initialization of the device will fail with -EN

[dpdk-dev] [PATCH] net/ixgbevf: fix stats update after a PF reset

2017-01-11 Thread Olivier Matz
From: Guo Fengtian When PF is set down, in VF, the value of stats register is zero. So only increase stats when it's non zero. Fixes: af75078fece3 ("first public release") CC: sta...@dpdk.org Signed-off-by: Guo Fengtian Signed-off-by: Olivier Matz --- drivers/net/ixgbe/ixgbe_ethdev.c | 6 +++

[dpdk-dev] [PATCH] net/ixgbevf: reset hardware when stopping port

2017-01-11 Thread Olivier Matz
From: Guo Fengtian When PF triggers a reset, VF port must acknowledge it by calling ixgbe_reset_hw(). Before this patch, the port link status, speed and duplex are invalid (all set to 0). The patch move the call to ixgbe_reset_hw() from ixgbevf_dev_close() to ixgbevf_dev_stop(), so that after a

Re: [dpdk-dev] [PATCH] kni: use bulk functions to allocate and free mbufs

2017-01-11 Thread Ferruh Yigit
Hi Sergey, On 1/11/2017 4:17 PM, Stephen Hemminger wrote: > On Fri, 30 Dec 2016 04:50:16 +0700 > Sergey Vyazmitinov wrote: > >> /** >> + * Free n packets mbuf back into its original mempool. >> + * >> + * Free each mbuf, and all its segments in case of chained buffers. Each >> + * segment is ad

Re: [dpdk-dev] [PATCH v6 0/4] Expanded statistics reporting

2017-01-11 Thread Thomas Monjalon
2017-01-12 00:03, Remy Horton: > Due to merge issues Reshma's latency statistics, which depends > on the reporting library, has been merged into this patchset. You losed Reshma authorship. It can be fixed with "git commit --amend --author"

Re: [dpdk-dev] [PATCH] net/mlx5: support extended statistics

2017-01-11 Thread Adrien Mazarguil
Hi Shahaf, Thanks, I have a few comments, most of them relatively minor. Please see below. On Wed, Jan 11, 2017 at 10:55:42AM +0200, Shahaf Shuler wrote: > Implement xstats_*() DPDK callbacks > > Signed-off-by: Shahaf Shuler > Signed-off-by: Elad Persiko > Signed-off-by: Hanoch Haim > --- >

[dpdk-dev] [PATCH] net/mlx: fix IPv4 and IPv6 packet type

2017-01-11 Thread Olivier Matz
From: Matthieu Ternisien d'Ouville Mellanox PMDs do not differentiate IP header with or without options, so the advertised packet type for an IPv4 should not be RTE_PTYPE_L3_IPV4, which explicitly means "does not contain any header option". Change the driver to set RTE_PTYPE(_INNER)_L3_IPV4_EXT_

[dpdk-dev] [PATCH] net/mlx: remove link update lock

2017-01-11 Thread Olivier Matz
From: Matthieu Ternisien d'Ouville Retrieving link status information through the link update callback should be quick and non-blocking. Mellanox PMDs retrieve this information through ioctl() calls on the related kernel netdevice. This appears to take a long time to complete and may cause signi

Re: [dpdk-dev] [PATCH] kni: use bulk functions to allocate and free mbufs

2017-01-11 Thread Olivier MATZ
On Wed, 11 Jan 2017 08:17:59 -0800, Stephen Hemminger wrote: > On Fri, 30 Dec 2016 04:50:16 +0700 > Sergey Vyazmitinov wrote: > > > /** > > + * Free n packets mbuf back into its original mempool. > > + * > > + * Free each mbuf, and all its segments in case of chained > > buffers. Each > > + * s

Re: [dpdk-dev] [dpdk-stable] [PATCH] app/testpmd: fix ixgbe private API calling

2017-01-11 Thread Iremonger, Bernard
Hi Ferruh, > -Original Message- > From: Yigit, Ferruh > Sent: Wednesday, January 11, 2017 4:19 PM > To: Iremonger, Bernard ; Lu, Wenzhuo > ; dev@dpdk.org > Cc: Wu, Jingjing ; sta...@dpdk.org > Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH] app/testpmd: fix ixgbe > private API calling > > O

Re: [dpdk-dev] [dpdk-stable] [PATCH] app/testpmd: fix ixgbe private API calling

2017-01-11 Thread Ferruh Yigit
On 1/11/2017 3:47 PM, Iremonger, Bernard wrote: > Hi Ferruh, > >> -Original Message- >> From: Yigit, Ferruh >> Sent: Wednesday, January 11, 2017 3:27 PM >> To: Iremonger, Bernard ; Lu, Wenzhuo >> ; dev@dpdk.org >> Cc: Wu, Jingjing ; sta...@dpdk.org >> Subject: Re: [dpdk-stable] [dpdk-dev]

Re: [dpdk-dev] [PATCH] kni: use bulk functions to allocate and free mbufs

2017-01-11 Thread Stephen Hemminger
On Fri, 30 Dec 2016 04:50:16 +0700 Sergey Vyazmitinov wrote: > /** > + * Free n packets mbuf back into its original mempool. > + * > + * Free each mbuf, and all its segments in case of chained buffers. Each > + * segment is added back into its original mempool. > + * > + * @param mp > + * The

Re: [dpdk-dev] [PATCH v6 2/4] lib: add bitrate statistics library

2017-01-11 Thread Stephen Hemminger
On Thu, 12 Jan 2017 00:03:12 +0800 Remy Horton wrote: > + > +struct rte_stats_bitrates_s * > +rte_stats_bitrate_create(void) > +{ > + return rte_zmalloc(NULL, sizeof(struct rte_stats_bitrates_s), 0); > +} > + You want these statistics to be cache aligned (ie not 0) to avoid false cache shari

Re: [dpdk-dev] [PATCH 12/13] i40e: return -errno when intr setup fails

2017-01-11 Thread Ferruh Yigit
On 12/28/2016 3:47 AM, Wu, Jingjing wrote: > > >> -Original Message- >> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Michal Miroslaw >> Sent: Tuesday, December 13, 2016 9:08 AM >> To: dev@dpdk.org >> Subject: [dpdk-dev] [PATCH 12/13] i40e: return -errno when intr setup fails >> >>

Re: [dpdk-dev] [PATCH] i40e: improve message grepability

2017-01-11 Thread Ferruh Yigit
On 1/11/2017 9:49 AM, Michał Mirosław wrote: > Join message lines for easier grepping. > PRIxXX are left glued to strings as they are in other parts of the file. I can't apply this cleanly, would you mind rebasing on top of latest next-net? Also there is a minor nit below. Thanks, ferruh > > S

[dpdk-dev] [PATCH v6 4/4] latencystats: added new library for latency stats

2017-01-11 Thread Remy Horton
Add a library designed to calculate latency statistics and report them to the application when queried. The library measures minimum, average and maximum latencies, and jitter in nano seconds. The current implementation supports global latency stats, i.e. per application stats. Added new field to

[dpdk-dev] [PATCH v6 3/4] app/test-pmd: add support for bitrate statistics

2017-01-11 Thread Remy Horton
Signed-off-by: Remy Horton --- app/test-pmd/testpmd.c | 36 1 file changed, 36 insertions(+) diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c index bfb2f8e..a0b7430 100644 --- a/app/test-pmd/testpmd.c +++ b/app/test-pmd/testpmd.c @@ -79,6 +79,10 @

[dpdk-dev] [PATCH v6 0/4] Expanded statistics reporting

2017-01-11 Thread Remy Horton
This patchset extends statistics reporting to include peak and average data-rate metrics. It comes in two parts: a statistics reporting library, and a bitrate calculation library that uses it. This structure is intended to seperate statistic reporting from ethdev and allow more flexible metric regi

[dpdk-dev] [PATCH v6 1/4] lib: add information metrics library

2017-01-11 Thread Remy Horton
This patch adds a new information metric library that allows other modules to register named metrics and update their values. It is intended to be independent of ethdev, rather than mixing ethdev and non-ethdev information in xstats. Signed-off-by: Remy Horton --- MAINTAINERS

[dpdk-dev] [PATCH v6 2/4] lib: add bitrate statistics library

2017-01-11 Thread Remy Horton
This patch adds a library that calculates peak and average data-rate statistics. For ethernet devices. These statistics are reported using the metrics library. Signed-off-by: Remy Horton --- MAINTAINERS| 4 + config/common_base

Re: [dpdk-dev] [PATCH v8 00/25] Support VFD on i40e

2017-01-11 Thread JOSHI, KAUSTUBH (KAUSTUBH)
Also, the kernel drivers have no concept of passing VF messages to upstream "decision making” (or policy enforcement) software like VFd. On Jan 11, 2017, at 9:49 AM, Kaustubh Joshi mailto:kaust...@research.att.com>> wrote: When Alex from our team started working on Niantic last year, the follow

Re: [dpdk-dev] [PATCH v8 00/25] Support VFD on i40e

2017-01-11 Thread JOSHI, KAUSTUBH (KAUSTUBH)
When Alex from our team started working on Niantic last year, the following were the list of gaps in the kernel drivers we had a need to fill: Direct traffic to VF based on more than one outer VLAN tags Optionally strip on ingress (to PF) and insert on egress VLAN tag Disable/enable MAC and VLAN

Re: [dpdk-dev] [PATCH 0/5] Assorted fixes for the flow API

2017-01-11 Thread Thomas Monjalon
2017-01-10 14:08, Adrien Mazarguil: > This series makes a few adjustments to the flow API (rte_flow) based on > issues encountered by preliminary PMD implementations and addresses bugs > reported by Coverity in the testpmd flow command. > > Adrien Mazarguil (5): > app/testpmd: fix array bounds c

Re: [dpdk-dev] [PATCH] doc: fix openssl formating text

2017-01-11 Thread De Lara Guarch, Pablo
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of De Lara Guarch, > Pablo > Sent: Wednesday, January 11, 2017 3:50 PM > To: Mrzyglod, DanielX T; Mrozowicz, SlawomirX > Cc: dev@dpdk.org; Mrzyglod, DanielX T > Subject: Re: [dpdk-dev] [PATCH] doc: fix openssl format

Re: [dpdk-dev] [PATCH v3 0/6] libeventdev API and northbound implementation

2017-01-11 Thread Jerin Jacob
On Tue, Dec 20, 2016 at 01:22:51PM +, Bruce Richardson wrote: > On Tue, Dec 20, 2016 at 06:39:30PM +0530, Jerin Jacob wrote: > > On Tue, Dec 20, 2016 at 11:13:42AM +, Bruce Richardson wrote: > > > On Sun, Dec 18, 2016 at 07:51:29PM +0530, Jerin Jacob wrote: > > > > As previously discussed i

Re: [dpdk-dev] [PATCH] doc: fix openssl formating text

2017-01-11 Thread De Lara Guarch, Pablo
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Daniel Mrzyglod > Sent: Tuesday, January 10, 2017 2:44 PM > To: Mrozowicz, SlawomirX > Cc: dev@dpdk.org; Mrzyglod, DanielX T > Subject: [dpdk-dev] [PATCH] doc: fix openssl formating text > > The code section was

Re: [dpdk-dev] [dpdk-stable] [PATCH] app/testpmd: fix ixgbe private API calling

2017-01-11 Thread Iremonger, Bernard
Hi Ferruh, > -Original Message- > From: Yigit, Ferruh > Sent: Wednesday, January 11, 2017 3:27 PM > To: Iremonger, Bernard ; Lu, Wenzhuo > ; dev@dpdk.org > Cc: Wu, Jingjing ; sta...@dpdk.org > Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH] app/testpmd: fix ixgbe > private API calling > > O

Re: [dpdk-dev] [PATCH v7 2/5] net/e1000: add firmware version get

2017-01-11 Thread Remy Horton
On 11/01/2017 06:41, Qiming Yang wrote: This patch adds a new function eth_igb_fw_version_get. Signed-off-by: Qiming Yang [..] +static int +eth_igb_fw_version_get(struct rte_eth_dev *dev, char *fw_version, + size_t fw_size) +{ + struct e1000_hw *hw = E1000_DEV_PRIV

Re: [dpdk-dev] [PATCH 6/7] net/ixgbe/base: add some debug traces

2017-01-11 Thread Ferruh Yigit
On 1/10/2017 3:45 PM, Wei Dai wrote: > This patch adds some traces in the reset_hw logic > and semaphore acquisition logic to help debugging. Is verbosity of the PMD changes with this update? Is something required in PMD to disable DEBUGOUT1(), DEBUGOUT2(), DEBUGOUT() by default? > > Signed-off

Re: [dpdk-dev] [PATCH 2/7] net/ixgbe/base: remove a compiler warning

2017-01-11 Thread Ferruh Yigit
On 1/10/2017 3:45 PM, Wei Dai wrote: > This patch fixes a compiler warning. I guess compiler warning is because of "mac->led_link_act = i;", since led_link_act is 8bits.. But can you please add the compile warning here, to make it more clear to understand what is the issue. > > Signed-off-by: W

Re: [dpdk-dev] [PATCH 1/7] net/ixgbe/base: support Broadwell-DE XFI backplane

2017-01-11 Thread Ferruh Yigit
On 1/10/2017 3:45 PM, Wei Dai wrote: > This patch adds initial support for a Braodwell-DE XFI backplane > interface. The XFI backplane requires a custom tuned link. > Hardware/Firmware owns the link config for XF backplane and software > must not interfere with it. Does it make sense to announce t

  1   2   >