On 1/9/2017 11:30 PM, Stephen Hemminger wrote: > A return statement at end of void function is unnecessary. > > Signed-off-by: Stephen Hemminger <step...@networkplumber.org> > --- > lib/librte_eal/linuxapp/kni/ethtool/igb/e1000_82575.c | 4 ---- > lib/librte_eal/linuxapp/kni/ethtool/igb/e1000_i210.c | 2 -- > lib/librte_eal/linuxapp/kni/ethtool/igb/e1000_mac.c | 4 ---- > lib/librte_eal/linuxapp/kni/ethtool/igb/e1000_phy.c | 1 - > lib/librte_eal/linuxapp/kni/ethtool/igb/igb_ethtool.c | 3 +-- > lib/librte_eal/linuxapp/kni/ethtool/igb/igb_main.c | 2 -- > lib/librte_eal/linuxapp/kni/ethtool/igb/igb_vmdq.c | 11 ++--------- > lib/librte_eal/linuxapp/kni/ethtool/ixgbe/ixgbe_82598.c | 2 -- > 8 files changed, 3 insertions(+), 26 deletions(-) >
I am not sure about benefit of refactoring drivers in KNI, since we have no intention to do development on that code, at best we can get updated version of the driver and replace, which I don't expect to happen soon. But if you have strong opinion on this: Reviewed-by: Ferruh Yigit <ferruh.yi...@intel.com>
