Re: [dpdk-dev] [PATCH 2/8] i40e: don't refer to eth_dev->pci_dev

2017-01-10 Thread Jan Blunck
On Tue, Jan 10, 2017 at 6:57 PM, Stephen Hemminger wrote: > On Tue, 10 Jan 2017 13:08:30 +0100 > Jan Blunck wrote: > >> On Sat, Jan 7, 2017 at 7:17 PM, Stephen Hemminger >> wrote: >> > Later patches remove pci_dev from the ethernet device structure. >> > Fix the i40e code to just use it's own na

[dpdk-dev] [PATCH v2] examples/vhost: fix the wrong initialization of lcore_ids

2017-01-10 Thread Yong Wang
when "TAILQ_INIT()" was added to the loop of "for (lcore_id = 0; ...)" statement, the assignment to "lcore_ids" was removed out of the loop. It changed the original initialization of "lcore_ids". Fix it by introducing two braces. Fixes: 45657a5c6861 ("examples/vhost: use tailq to link vhost devic

Re: [dpdk-dev] [PATCH v2 10/18] net/ixgbe: flush all the filters

2017-01-10 Thread Zhao1, Wei
Hi,yigit > -Original Message- > From: Yigit, Ferruh > Sent: Saturday, January 7, 2017 12:40 AM > To: Zhao1, Wei ; dev@dpdk.org > Cc: Lu, Wenzhuo > Subject: Re: [dpdk-dev] [PATCH v2 10/18] net/ixgbe: flush all the filters > > On 12/30/2016 7:53 AM, Wei Zhao wrote: > > Add support for flus

[dpdk-dev] [PATCH v2] doc: add known uio_pci_generic issue for i40e

2017-01-10 Thread Jeff Guo
From: "Guo, Jia" When bind with uio_pci_generic in X710/XL710/XXV710, the result is failed. uio_pci_generic is not supported by X710/XL710/XXV710. Signed-off-by: Guo, Jia --- v2: add X710/XXV710 limitation case --- doc/guides/rel_notes/known_issues.rst | 24 1 file cha

[dpdk-dev] [PATCH] examples/vhost: fix the wrong initialization of lcore_ids

2017-01-10 Thread Yong Wang
when "TAILQ_INIT()" was added to the loop of "for (lcore_id = 0; ...)" statement, the assignment to "lcore_ids" was removed out of the loop. It changed the original initialization of "lcore_ids". Fix it by introducing two braces. Fixes: 45657a5c6861 ("examples/vhost: use tailq to link vhost devic

[dpdk-dev] [PATCH v7 5/5] ethtool: display firmware version

2017-01-10 Thread Qiming Yang
This patch enhances the ethtool example to support to show firmware version, in the same way that the Linux kernel ethtool does. Signed-off-by: Qiming Yang Acked-by: Remy Horton --- examples/ethtool/ethtool-app/ethapp.c | 1 + examples/ethtool/lib/rte_ethtool.c| 6 ++ 2 files changed, 7

[dpdk-dev] [PATCH v7 4/5] net/i40e: add firmware version get

2017-01-10 Thread Qiming Yang
This patch add a new function i40e_fw_version_get. Signed-off-by: Qiming Yang Acked-by: Remy Horton --- doc/guides/nics/features/i40e.ini | 1 + drivers/net/i40e/i40e_ethdev.c| 31 +++ 2 files changed, 32 insertions(+) diff --git a/doc/guides/nics/features/i40e

[dpdk-dev] [PATCH v7 3/5] net/ixgbe: add firmware version get

2017-01-10 Thread Qiming Yang
This patch adds a new function ixgbe_fw_version_get. Signed-off-by: Qiming Yang Acked-by: Remy Horton --- doc/guides/nics/features/ixgbe.ini | 1 + drivers/net/ixgbe/ixgbe_ethdev.c | 25 + 2 files changed, 26 insertions(+) diff --git a/doc/guides/nics/features/ixgbe.

[dpdk-dev] [PATCH v7 1/5] ethdev: add firmware version get

2017-01-10 Thread Qiming Yang
This patch adds a new API 'rte_eth_dev_fw_version_get' for fetching firmware version by a given device. Signed-off-by: Qiming Yang Acked-by: Remy Horton --- doc/guides/nics/features/default.ini | 1 + doc/guides/rel_notes/deprecation.rst | 4 doc/guides/rel_notes/release_17_02.rst |

[dpdk-dev] [PATCH v7 2/5] net/e1000: add firmware version get

2017-01-10 Thread Qiming Yang
This patch adds a new function eth_igb_fw_version_get. Signed-off-by: Qiming Yang Acked-by: Remy Horton --- doc/guides/nics/features/igb.ini | 1 + drivers/net/e1000/igb_ethdev.c | 54 2 files changed, 55 insertions(+) diff --git a/doc/guides/nics/fe

[dpdk-dev] [PATCH v7 0/5] new API 'rte_eth_dev_fw_version_get'

2017-01-10 Thread Qiming Yang
v7: - rebased v6: - renamed fw_length -> fw_size - added return value for insufficient fw_size - fixed the indentation problem in e1000 - added ver.build.patch in i40e, keep the same with Linux kernel driver v5: - modified the API rte_eth_dev_fw_version_get(uint8_t port_id, char

[dpdk-dev] [PATCH] kni: fast data availability check in thread_single loop

2017-01-10 Thread Sergey Vyazmitinov
This allow to significant reduces packets processing latency. Signed-off-by: Sergey Vyazmitinov --- .../linuxapp/eal/include/exec-env/rte_kni_common.h | 6 lib/librte_eal/linuxapp/kni/kni_misc.c | 33 -- 2 files changed, 30 insertions(+), 9 deletions(-) dif

Re: [dpdk-dev] [PATCH 1/2] add rte_bus->probe

2017-01-10 Thread Shreyansh Jain
On Tuesday 10 January 2017 11:32 PM, Ferruh Yigit wrote: Signed-off-by: Ferruh Yigit --- lib/librte_eal/common/eal_common_bus.c | 7 --- lib/librte_eal/common/include/rte_bus.h | 3 +++ lib/librte_eal/linuxapp/eal/eal_pci.c | 1 + 3 files changed, 8 insertions(+), 3 deletions(-) diff --

[dpdk-dev] [PATCH v6 6/6] doc: add ixgbe specific APIs

2017-01-10 Thread Tiwei Bie
Add information about the new ixgbe PMD APIs in the release notes. Signed-off-by: Tiwei Bie Acked-by: John McNamara --- doc/guides/rel_notes/release_17_02.rst | 5 + 1 file changed, 5 insertions(+) diff --git a/doc/guides/rel_notes/release_17_02.rst b/doc/guides/rel_notes/release_17_02.rs

[dpdk-dev] [PATCH v6 5/6] app/testpmd: add MACsec offload commands

2017-01-10 Thread Tiwei Bie
Below MACsec offload commands are added: - set macsec offload on encrypt on|off replay-protect on|off - set macsec offload off - set macsec sc tx|rx - set macsec sa tx|rx Also update the testpmd user guide. Signed-off-by: Tiwei Bie Acked-by: Wenzhuo Lu --- app/test-pmd/cmdline.c

[dpdk-dev] [PATCH v6 4/6] net/ixgbe: add MACsec offload support

2017-01-10 Thread Tiwei Bie
MACsec (or LinkSec, 802.1AE) is a MAC level encryption/authentication scheme defined in IEEE 802.1AE that uses symmetric cryptography. This commit adds the MACsec offload support for ixgbe. Signed-off-by: Tiwei Bie Acked-by: Wenzhuo Lu --- doc/guides/nics/features/default.ini| 1 + do

[dpdk-dev] [PATCH v6 3/6] ethdev: add MACsec offload capability flags

2017-01-10 Thread Tiwei Bie
If these flags are advertised by a PMD, the NIC supports the MACsec offload. The incoming MACsec traffics can be offloaded transparently after the MACsec offload is configured correctly by the application. And the application can set the PKT_TX_MACSEC flag in mbufs to enable the MACsec offload for

[dpdk-dev] [PATCH v6 2/6] ethdev: add event type for MACsec

2017-01-10 Thread Tiwei Bie
This commit adds a below event type: - RTE_ETH_EVENT_MACSEC This event will occur when the PN counter in a MACsec connection reaches the exhaustion threshold. Signed-off-by: Tiwei Bie --- lib/librte_ether/rte_ethdev.h | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/librte_ether/rte_eth

[dpdk-dev] [PATCH v6 1/6] mbuf: add flag for MACsec

2017-01-10 Thread Tiwei Bie
Add a new Tx flag in mbuf, that can be set by applications to enable the MACsec offload for a packet to be transmitted. Signed-off-by: Tiwei Bie --- doc/guides/rel_notes/release_17_02.rst | 5 + lib/librte_mbuf/rte_mbuf.c | 2 ++ lib/librte_mbuf/rte_mbuf.h | 6 ++

[dpdk-dev] [PATCH v6 0/6] Add MACsec offload support for ixgbe

2017-01-10 Thread Tiwei Bie
This patch set adds the MACsec offload support for ixgbe. The testpmd is also updated to support MACsec cmds. v2: - Update the documents for testpmd; - Update the release notes; - Reuse the functions provided by base code; v3: - Add the missing parts of MACsec mbuf flag and reorganize the patch s

[dpdk-dev] [PATCH 2/2] net/virtio: optimize header reset on any layout

2017-01-10 Thread Yuanhan Liu
When any layout is used, the header is stored in the head room of mbuf. mbuf is allocated and filled by user, means there is no gurateen the header is all zero for non TSO case. Therefore, we have to do the reset by ourself: memest(hdr, 0, head_size); The memset has two impacts on performance

[dpdk-dev] [PATCH 1/2] net/virtio: fix performance regression due to TSO enabling

2017-01-10 Thread Yuanhan Liu
TSO is now enabled, but it's not actually being used by default in a simple L2 forward mode. In such case, we have to zero the virtio net headers, to inform the vhost backend that no offload is being used: hdr->csum_start = 0; hdr->csum_offset = 0; hdr->flags = 0; hdr->gso_type =

[dpdk-dev] [PATCH 0/2] net/virtio: optimize virtio net header reset

2017-01-10 Thread Yuanhan Liu
This two patches optimized the virtio net header reset when TSO is not actually used (though it could be enabled). The basic idea is to not reset (assign 0) when it's already 0. This could avoid some severe cache issues. Micro benchmarking shows it could boost the performance up to 20+%. --- Yuanh

[dpdk-dev] [PATCH] net/enic: remove unnecessary function parameter attributes

2017-01-10 Thread John Daley
Remove __rte_unused attributes in function declaration when the parameters really are used. Fixes: dfbd6a9cb504 ("net/enic: extend flow director support for 1300 series") CC: sta...@dpdk.org Signed-off-by: John Daley --- drivers/net/enic/enic.h | 5 ++--- 1 file changed, 2 insertions(+), 3 dele

[dpdk-dev] [PATCH v2] kni: use bulk functions to allocate and free mbufs

2017-01-10 Thread Sergey Vyazmitinov
Optimized kni_allocate_mbufs and kni_free_mbufs by using mbuf bulk functions. This can improve performance more than two times. Signed-off-by: Sergey Vyazmitinov --- lib/librte_kni/rte_kni.c | 44 +++ lib/librte_kni/rte_kni_fifo.h | 18 +++

[dpdk-dev] [PATCH] net/enic: use new Rx checksum flags

2017-01-10 Thread John Daley
Use the new L3 and L4 ..CKSUM_GOOD and ..CKSUM_UNKNOWN flags to distinguish good checksums from unknown ones. Signed-off-by: John Daley --- drivers/net/enic/enic_rxtx.c | 29 +++-- 1 file changed, 19 insertions(+), 10 deletions(-) diff --git a/drivers/net/enic/enic_rxtx

[dpdk-dev] [PATCH] kni: use bulk functions to allocate and free mbufs

2017-01-10 Thread Sergey Vyazmitinov
Optimized kni_allocate_mbufs and kni_free_mbufs by using mbuf bulk functions. This can improve performance more than two times. Signed-off-by: Sergey Vyazmitinov --- lib/librte_kni/rte_kni.c | 44 +--- lib/librte_kni/rte_kni_fifo.h| 18

Re: [dpdk-dev] [PATCH v2 5/7] net/virtio_user: add vhost kernel support

2017-01-10 Thread Jason Wang
On 2017年01月11日 11:13, Tan, Jianfeng wrote: On 1/11/2017 10:42 AM, Jason Wang wrote: On 2017年01月10日 14:11, Tan, Jianfeng wrote: Hi Jason, On 1/9/2017 12:39 PM, Jason Wang wrote: On 2016年12月23日 15:14, Jianfeng Tan wrote: This patch add support vhost kernel as the backend for virtio_u

Re: [dpdk-dev] [PATCH v2 5/7] net/virtio_user: add vhost kernel support

2017-01-10 Thread Tan, Jianfeng
On 1/11/2017 10:42 AM, Jason Wang wrote: On 2017年01月10日 14:11, Tan, Jianfeng wrote: Hi Jason, On 1/9/2017 12:39 PM, Jason Wang wrote: On 2016年12月23日 15:14, Jianfeng Tan wrote: This patch add support vhost kernel as the backend for virtio_user. Three main hook functions are added: -

Re: [dpdk-dev] i40e_aq_get_phy_capabilities() fails when using SFP+ with no link

2017-01-10 Thread Christos Ricudis
Hi Helin, > On 11 Jan 2017, at 09:08, Zhang, Helin wrote: > > Hi Aaron > > Is the SFP+ (Finisar FTLX8571D3BCL) supported and validated by Intel? > It seems there is some PHY issue in this case. As the original reporter of this issue, I will test with validated SFP+s and will report on my tes

[dpdk-dev] [PATCH] app/testpmd: fix ixgbe private API calling

2017-01-10 Thread Wenzhuo Lu
Some ixgbe private APIs are added to expose ixgbe specific functions. When they're used by testpmd, there's no check for if the NICs are ixgbe. Other NICs also have chance to call these APIs. This patch add the check and the feedback print. Fixes: 425781ff5afe ("app/testpmd: add ixgbe VF manageme

Re: [dpdk-dev] [PATCH v2 5/7] net/virtio_user: add vhost kernel support

2017-01-10 Thread Jason Wang
On 2017年01月11日 10:30, Tan, Jianfeng wrote: Hi Jason, On 1/9/2017 12:39 PM, Jason Wang wrote: +if (!enable) { +if (dev->tapfds[pair_idx]) { +close(dev->tapfds[pair_idx]); +dev->tapfds[pair_idx] = -1; +} +return vhost_kernel_set_backend(vhos

Re: [dpdk-dev] [PATCH v2 5/7] net/virtio_user: add vhost kernel support

2017-01-10 Thread Jason Wang
On 2017年01月10日 14:11, Tan, Jianfeng wrote: Hi Jason, On 1/9/2017 12:39 PM, Jason Wang wrote: On 2016年12月23日 15:14, Jianfeng Tan wrote: This patch add support vhost kernel as the backend for virtio_user. Three main hook functions are added: - vhost_kernel_setup() to open char device, e

[dpdk-dev] [PATCH v4] mempool: use cache in single producer or consumer mode

2017-01-10 Thread Wenfeng Liu
Currently we will check mempool flags when we put/get objects from mempool. However, this makes cache useless when mempool is SC|SP, SC|MP, MC|SP cases. This patch makes cache available in above cases and improves performance. Signed-off-by: Wenfeng Liu --- lib/librte_mempool/rte_mempool.h | 26

Re: [dpdk-dev] [PATCH v2 5/7] net/virtio_user: add vhost kernel support

2017-01-10 Thread Tan, Jianfeng
Hi Jason, On 1/9/2017 12:39 PM, Jason Wang wrote: +if (!enable) { +if (dev->tapfds[pair_idx]) { +close(dev->tapfds[pair_idx]); +dev->tapfds[pair_idx] = -1; +} +return vhost_kernel_set_backend(vhostfd, -1); If this is used to for thing like e

Re: [dpdk-dev] [PATCH v1 2/2] Test cases for rte_memcmp functions

2017-01-10 Thread Wang, Zhihong
> -Original Message- > From: Thomas Monjalon [mailto:thomas.monja...@6wind.com] > Sent: Monday, January 9, 2017 7:09 PM > To: Wang, Zhihong > Cc: Ravi Kerur ; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v1 2/2] Test cases for rte_memcmp > functions > > 2017-01-09 05:29, Wang, Zhihong:

Re: [dpdk-dev] [PATCH v8 18/25] app/testpmd: use VFD APIs on i40e

2017-01-10 Thread Lu, Wenzhuo
Hi Ferruh, > -Original Message- > From: Yigit, Ferruh > Sent: Wednesday, January 11, 2017 4:09 AM > To: Lu, Wenzhuo; dev@dpdk.org > Cc: Chen, Jing D; Iremonger, Bernard > Subject: Re: [dpdk-dev] [PATCH v8 18/25] app/testpmd: use VFD APIs on i40e > > On 1/10/2017 11:29 AM, Ferruh Yigit wro

Re: [dpdk-dev] i40e_aq_get_phy_capabilities() fails when using SFP+ with no link

2017-01-10 Thread Zhang, Helin
Hi Aaron Is the SFP+ (Finisar FTLX8571D3BCL) supported and validated by Intel? It seems there is some PHY issue in this case. Regards, Helin -Original Message- From: Olivier MATZ [mailto:olivier.m...@6wind.com] Sent: Tuesday, January 10, 2017 11:29 PM To: Christos Ricudis Cc: dev@dpdk.

Re: [dpdk-dev] [PATCH v8 00/25] Support VFD on i40e

2017-01-10 Thread Ferruh Yigit
Hi Vincent, On 1/10/2017 8:23 PM, Vincent Jardin wrote: > Nope. First one needs to assess if DPDK should be intensively used to > become a PF knowing Linux can do the jobs. Linux kernel community does not > like the forking of Kernel drivers, I tend to agree that we should not keep > duplicatin

Re: [dpdk-dev] [PATCH v8 00/25] Support VFD on i40e

2017-01-10 Thread Vincent Jardin
Nope. First one needs to assess if DPDK should be intensively used to become a PF knowing Linux can do the jobs. Linux kernel community does not like the forking of Kernel drivers, I tend to agree that we should not keep duplicating options that can be solved with the Linux kernel. Best regard

Re: [dpdk-dev] [PATCH v8 18/25] app/testpmd: use VFD APIs on i40e

2017-01-10 Thread Ferruh Yigit
On 1/10/2017 11:29 AM, Ferruh Yigit wrote: > On 1/10/2017 7:16 AM, Wenzhuo Lu wrote: >> The new VF Daemon (VFD) APIs is implemented on i40e. Change >> testpmd code to use them, including VF MAC anti-spoofing, >> VF VLAN anti-spoofing, TX loopback, VF VLAN strip, VF VLAN >> insert. >> >> Signed-off-

[dpdk-dev] [PATCH v1] ethdev: fix multi-process NULL dereference crashes

2017-01-10 Thread Remy Horton
Even though only primary processes should setup PMDs, secondary processes were also blanket zeroing ethernet device memory. The result was NULL dereference crashes in multi-process setups. Fixes: 7f95f78a8aea ("ethdev: clear data when allocating device") Signed-off-by: Remy Horton --- doc/guide

Re: [dpdk-dev] [PATCH 8/8] eal: VMBUS infrastructure

2017-01-10 Thread Stephen Hemminger
On Tue, 10 Jan 2017 18:27:31 +0100 Jan Blunck wrote: > > +#ifdef RTE_LIBRTE_HV_PMD > > +/** > > + * @internal > > + * Wrapper for use by vmbus drivers as a .probe function to attach to a > > ethdev > > + * interface. > > + */ > > +int rte_eth_dev_vmbus_probe(struct rte_vmbus_driver *vmbus_drv, >

[dpdk-dev] [PATCH 2/2] separate bus and functionality driver structs

2017-01-10 Thread Ferruh Yigit
Signed-off-by: Ferruh Yigit --- drivers/net/bnx2x/bnx2x_ethdev.c| 44 ++--- drivers/net/cxgbe/cxgbe_ethdev.c| 22 +++ drivers/net/e1000/em_ethdev.c | 26 - drivers/net/e1000/igb_ethdev.c | 50 --

Re: [dpdk-dev] [PATCH 7/8] ethdev: break ethernet driver and pci_driver connection

2017-01-10 Thread Stephen Hemminger
On Tue, 10 Jan 2017 17:11:15 +0100 Jan Blunck wrote: > On Sat, Jan 7, 2017 at 7:17 PM, Stephen Hemminger > wrote: > > There are multiple buses and device types now. Therefore it no longer > > makes sense that PCI driver information is part of the Ethernet driver > > structure. > > The Etherne

[dpdk-dev] [PATCH 1/2] add rte_bus->probe

2017-01-10 Thread Ferruh Yigit
Signed-off-by: Ferruh Yigit --- lib/librte_eal/common/eal_common_bus.c | 7 --- lib/librte_eal/common/include/rte_bus.h | 3 +++ lib/librte_eal/linuxapp/eal/eal_pci.c | 1 + 3 files changed, 8 insertions(+), 3 deletions(-) diff --git a/lib/librte_eal/common/eal_common_bus.c b/lib/librte_

Re: [dpdk-dev] [PATCH 7/8] ethdev: break ethernet driver and pci_driver connection

2017-01-10 Thread Ferruh Yigit
On 1/10/2017 1:59 PM, Ferruh Yigit wrote: > On 1/7/2017 6:17 PM, Stephen Hemminger wrote: >> There are multiple buses and device types now. Therefore it no longer >> makes sense that PCI driver information is part of the Ethernet driver >> structure. >> >> This patch removes pci_driver from eth_dri

Re: [dpdk-dev] [PATCH 2/8] i40e: don't refer to eth_dev->pci_dev

2017-01-10 Thread Stephen Hemminger
On Tue, 10 Jan 2017 13:08:30 +0100 Jan Blunck wrote: > On Sat, Jan 7, 2017 at 7:17 PM, Stephen Hemminger > wrote: > > Later patches remove pci_dev from the ethernet device structure. > > Fix the i40e code to just use it's own name when forming zone name. > > > > Signed-off-by: Stephen Hemminger

Re: [dpdk-dev] [PATCH v3 0/8] Add crypto PMD optimized for ARMv8

2017-01-10 Thread Zbigniew Bodek
Hello Pablo, Please check my answers in-line below. Kind regards Zbigniew On 10.01.2017 18:11, De Lara Guarch, Pablo wrote: Hi Zbigniew, -Original Message- From: zbigniew.bo...@caviumnetworks.com [mailto:zbigniew.bo...@caviumnetworks.com] Sent: Wednesday, January 04, 2017 5:33 PM To

Re: [dpdk-dev] [PATCH 8/8] eal: VMBUS infrastructure

2017-01-10 Thread Jan Blunck
On Sat, Jan 7, 2017 at 7:17 PM, Stephen Hemminger wrote: > Add support for VMBUS on Hyper-V/Azure. VMBUS is similar to PCI > but has different addressing and internal API's. > > Signed-off-by: Stephen Hemminger > --- > lib/librte_eal/common/Makefile | 2 +- > lib/librte_eal/common

[dpdk-dev] [PATCH v2] tools: fix active interface detection in dpdk-devbind.py

2017-01-10 Thread Yoni Gilad
When adding crypto devices, the "Active" and "Ssh_if" attributes of existing network devices were reset. This causes the following issues: - Network interfaces aren't marked as "*Active*" in the --status output. - Active network interfaces can be unbound without the --force option, causing loss

Re: [dpdk-dev] [PATCH v3 0/8] Add crypto PMD optimized for ARMv8

2017-01-10 Thread De Lara Guarch, Pablo
Hi Zbigniew, > -Original Message- > From: zbigniew.bo...@caviumnetworks.com > [mailto:zbigniew.bo...@caviumnetworks.com] > Sent: Wednesday, January 04, 2017 5:33 PM > To: dev@dpdk.org > Cc: De Lara Guarch, Pablo; Doherty, Declan; > jerin.ja...@caviumnetworks.com; Zbigniew Bodek > Subject:

Re: [dpdk-dev] [PATCH v4] rte_mbuf: add rte_pktmbuf_linearize

2017-01-10 Thread Olivier MATZ
Hi Tomasz, On Thu, 5 Jan 2017 17:44:00 +0100, Tomasz Kulasek wrote: > This patch adds function rte_pktmbuf_linearize to let crypto PMD > coalesce chained mbuf before crypto operation and extend their > capabilities to support segmented mbufs when device cannot handle > them natively. > > Includ

Re: [dpdk-dev] [PATCH 7/8] ethdev: break ethernet driver and pci_driver connection

2017-01-10 Thread Jan Blunck
On Sat, Jan 7, 2017 at 7:17 PM, Stephen Hemminger wrote: > There are multiple buses and device types now. Therefore it no longer > makes sense that PCI driver information is part of the Ethernet driver > structure. The Ethernet driver itself doesn't over alot of value from an abstraction point of

[dpdk-dev] [PATCH 4/7] net/ixgbe/base: support Marvell 1000BASE-T PHYs

2017-01-10 Thread Wei Dai
This patch adds initial support for Marvell 1000BASE-T PHYs on Broadwell-DE. Firmware owns the link config for Marvell PHYs on Broadwell-DE, software should not touch it. Also Broadwell-DE is not capable of speeds lower than 1Gb. Signed-off-by: Wei Dai --- drivers/net/ixgbe/base/ixgbe_phy.c | 4

[dpdk-dev] [PATCH 3/7] net/ixgbe/base: configure speeds for KR/KX backplane

2017-01-10 Thread Wei Dai
This patch ensures that the advertised link speeds are configured for KR/KX backplane on some new platform. Without this patch the link remains at 1G when resuming from low power after being downshifted by LPLU(Low Power Link Up). This patch ensures that the advertise speeds are not changed for 2.5

[dpdk-dev] [PATCH 7/7] net/ixgbe/base: update version of shared code

2017-01-10 Thread Wei Dai
update version of shared code to 2017-01-05 in README. Signed-off-by: Wei Dai --- drivers/net/ixgbe/base/README | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ixgbe/base/README b/drivers/net/ixgbe/base/README index 1936191..0a6054f 100644 --- a/drivers/net/ixgbe/

[dpdk-dev] [PATCH 2/7] net/ixgbe/base: remove a compiler warning

2017-01-10 Thread Wei Dai
This patch fixes a compiler warning. Signed-off-by: Wei Dai --- drivers/net/ixgbe/base/ixgbe_common.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ixgbe/base/ixgbe_common.c b/drivers/net/ixgbe/base/ixgbe_common.c index 18bb18c..0dd33b8 100644 --- a/drivers/net

[dpdk-dev] [PATCH 6/7] net/ixgbe/base: add some debug traces

2017-01-10 Thread Wei Dai
This patch adds some traces in the reset_hw logic and semaphore acquisition logic to help debugging. Signed-off-by: Wei Dai --- drivers/net/ixgbe/base/ixgbe_common.c | 7 - drivers/net/ixgbe/base/ixgbe_phy.c| 16 +--- drivers/net/ixgbe/base/ixgbe_x540.c | 11 ++-- drivers/

[dpdk-dev] [PATCH 5/7] net/ixgbe/base: use clause 22 MDIO functions for Marvell PHYs

2017-01-10 Thread Wei Dai
This patch sets the MDIO(Management Data Input/Output Interface) read/write function ponters for Broadwell+Marvell PHYs to use the clause 22 functions. Marvell PHYs do not support clause 45. Signed-off-by: Wei Dai --- drivers/net/ixgbe/base/ixgbe_x550.c | 4 1 file changed, 4 insertions(+)

[dpdk-dev] [PATCH 1/7] net/ixgbe/base: support Broadwell-DE XFI backplane

2017-01-10 Thread Wei Dai
This patch adds initial support for a Braodwell-DE XFI backplane interface. The XFI backplane requires a custom tuned link. Hardware/Firmware owns the link config for XF backplane and software must not interfere with it. Signed-off-by: Wei Dai --- drivers/net/ixgbe/base/ixgbe_api.c | 1 + driv

[dpdk-dev] [PATCH 0/7] update ixgbe shared code to version 2017-01-05

2017-01-10 Thread Wei Dai
This patch set updates ixgbe shared code to cid-ixgbe.2017.01.05.tar.gz . The shared codes are in drivers/net/ixgbe/base/ and are developed by another Intel team. This patch add more supports to some Intel Broadwell-DE platforms. A new device id and two PHY types are introduced and also add some

Re: [dpdk-dev] i40e_aq_get_phy_capabilities() fails when using SFP+ with no link

2017-01-10 Thread Olivier MATZ
Hi Christos, +CC i40e maintainers On Tue, 10 Jan 2017 20:32:26 +0800, Christos Ricudis wrote: > Hello, > > Using a X710 based 4-port 4x10Gbit NIC, I have came across the > following issue on the i40e PMD: > > When an optical SFP+ (Finisar FTLX8571D3BCL) is used with no active > link partner

Re: [dpdk-dev] [PATCH v3] mempool: don't check mempool flags when cache is enabled

2017-01-10 Thread Olivier MATZ
Hi Wengfeng, On Tue, 10 Jan 2017 08:26:42 +, Wenfeng Liu wrote: > Currently we will check mempool flags when we put/get objects from > mempool. However, this makes cache useless when mempool is SC|SP, > SC|MP, MC|SP cases. > This patch makes cache available in above cases and improves > perfo

Re: [dpdk-dev] [PATCH v4] ethdev: fix port data mismatched in multiple process model

2017-01-10 Thread Yuanhan Liu
On Mon, Jan 09, 2017 at 06:08:04PM +0100, Thomas Monjalon wrote: > Hi Yuanhan, > > Nit: the title should be "v4 1/6" Oops, my bad. > Except that, good patch :) > > > Signed-off-by: Yuanhan Liu > > Acked-by: Thomas Monjalon Thanks for review! Mind if I apply it to the next-virtio tree?

[dpdk-dev] [PATCH] doc: fix openssl formating text

2017-01-10 Thread Daniel Mrzyglod
The code section was lacking indentation to be be correctly formatted. Signed-off-by: Daniel Mrzyglod --- doc/guides/cryptodevs/openssl.rst | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/doc/guides/cryptodevs/openssl.rst b/doc/guides/cryptodevs/openssl.rs

Re: [dpdk-dev] [PATCH 7/8] ethdev: break ethernet driver and pci_driver connection

2017-01-10 Thread Ferruh Yigit
On 1/7/2017 6:17 PM, Stephen Hemminger wrote: > There are multiple buses and device types now. Therefore it no longer > makes sense that PCI driver information is part of the Ethernet driver > structure. > > This patch removes pci_driver from eth_driver and introduces a > new combined structure fo

Re: [dpdk-dev] [PATCH] crypto test: add integrity check for mbuf data

2017-01-10 Thread De Lara Guarch, Pablo
> -Original Message- > From: Kusztal, ArkadiuszX > Sent: Monday, January 09, 2017 3:23 PM > To: Trahe, Fiona; dev@dpdk.org > Cc: Griffin, John; Jain, Deepak K; De Lara Guarch, Pablo; Trahe, Fiona > Subject: RE: [dpdk-dev] [PATCH] crypto test: add integrity check for mbuf > data > > > >

Re: [dpdk-dev] [PATCH] crypto/openssl: fix that remove unneeded check

2017-01-10 Thread De Lara Guarch, Pablo
> -Original Message- > From: Doherty, Declan > Sent: Tuesday, January 10, 2017 9:28 AM > To: Azarewicz, PiotrX T; De Lara Guarch, Pablo; dev@dpdk.org > Cc: sta...@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] crypto/openssl: fix that remove unneeded > check > > On 09/01/17 14:45, Piotr Azar

Re: [dpdk-dev] [PATCH] doc: fix openssl formating text in documentation

2017-01-10 Thread De Lara Guarch, Pablo
Hi Daniel, > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Daniel Mrzyglod > Sent: Tuesday, January 10, 2017 11:04 AM > To: Mrozowicz, SlawomirX > Cc: dev@dpdk.org; Mrzyglod, DanielX T > Subject: [dpdk-dev] [PATCH] doc: fix openssl formating text in > documentat

Re: [dpdk-dev] [PATCH v5 00/29] Support VFD and DPDK PF + kernel VF on i40e

2017-01-10 Thread Vincent JARDIN
Hi Scott, Le 04/01/2017 à 22:09, Scott Daniels a écrit : With holidays we are a bit late with our thoughts, but would like to toss them into the mix. Same, I hope I am not missing emails. I do appreciate your arguments, it provides lot of light. See below, The original NAK is understand

Re: [dpdk-dev] [PATCH v8 00/25] Support VFD on i40e

2017-01-10 Thread Zhang, Helin
Acked-by: Helin Zhang > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Wenzhuo Lu > Sent: Tuesday, January 10, 2017 3:16 PM > To: dev@dpdk.org > Cc: Lu, Wenzhuo > Subject: [dpdk-dev] [PATCH v8 00/25] Support VFD on i40e > > 1, VF Daemon (VFD) > VFD is an idea t

[dpdk-dev] [PATCH 5/5] ethdev: define default item masks in flow API

2017-01-10 Thread Adrien Mazarguil
Leaving default pattern item mask values up for interpretation by PMDs is an undefined behavior that applications might find difficult to use in the wild. It also needlessly complicates PMD implementation. This commit addresses this by defining consistent default masks for each item type. Signed-

[dpdk-dev] [PATCH 4/5] ethdev: clarify RSS action in flow API

2017-01-10 Thread Adrien Mazarguil
Contrary to the current description, mbuf RSS hash result storage does not overlap with the returned MARK value (hash.fdir.lo vs. hash.fdir.hi), and both may be combined. Reflect this change by allowing testpmd to display both values simultaneously. Signed-off-by: Adrien Mazarguil Cc: Jingjing W

[dpdk-dev] [PATCH 3/5] ethdev: clarify MARK and FLAG actions in flow API

2017-01-10 Thread Adrien Mazarguil
Both actions share the PKT_RX_FDIR mbuf flag, as a result there is no way to tell them apart. Moreover, the maximum allowed value for the MARK action may not necessarily cover the entire 32-bit space. Signed-off-by: Adrien Mazarguil Cc: John McNamara --- doc/guides/prog_guide/rte_flow.rst | 24

[dpdk-dev] [PATCH 2/5] ethdev: modify flow API's error setting function

2017-01-10 Thread Adrien Mazarguil
Based on initial PMD implementations of the flow API, returning the error structure which may be NULL is useless and always discarded. Returning the error code instead appears to be much more convenient. Signed-off-by: Adrien Mazarguil Cc: Nelio Laranjeiro Cc: Wei Zhao Cc: Beilei Xing --- li

[dpdk-dev] [PATCH 1/5] app/testpmd: fix array bounds checks

2017-01-10 Thread Adrien Mazarguil
This commit addresses several obvious issues reported by Coverity (139596, 139597, 139598 and 139599) with array bounds checks in functions related to the flow API. Fixes: 938a184a1870 ("app/testpmd: implement basic support for flow API") Signed-off-by: Adrien Mazarguil --- app/test-pmd/config.

[dpdk-dev] [PATCH 0/5] Assorted fixes for the flow API

2017-01-10 Thread Adrien Mazarguil
This series makes a few adjustments to the flow API (rte_flow) based on issues encountered by preliminary PMD implementations and addresses bugs reported by Coverity in the testpmd flow command. Adrien Mazarguil (5): app/testpmd: fix array bounds checks ethdev: modify flow API's error setting

[dpdk-dev] i40e_aq_get_phy_capabilities() fails when using SFP+ with no link

2017-01-10 Thread Christos Ricudis
Hello, Using a X710 based 4-port 4x10Gbit NIC, I have came across the following issue on the i40e PMD: When an optical SFP+ (Finisar FTLX8571D3BCL) is used with no active link partner on the other end of the link (or fiber completely disconnected from the SFP+), i40e_aq_get_phy_capabilities(

Re: [dpdk-dev] [PATCH 6/8] qat: don't refer to eth_dev->pci_dev

2017-01-10 Thread Jan Blunck
On Sat, Jan 7, 2017 at 7:17 PM, Stephen Hemminger wrote: > Later patches remove pci_dev from the ethernet device structure. > Fix the quick assist code to just use it's own name when forming zone name. > > Signed-off-by: Stephen Hemminger > --- > drivers/crypto/qat/qat_qp.c | 6 +++--- > 1 file

Re: [dpdk-dev] [PATCH 5/8] nfp: don't refer to eth_dev->pci_dev

2017-01-10 Thread Jan Blunck
On Sat, Jan 7, 2017 at 7:17 PM, Stephen Hemminger wrote: > Later patches remove pci_dev from the ethernet device structure. > Fix the nfp code to just use it's own name when forming zone name. > > Signed-off-by: Stephen Hemminger > --- > drivers/net/nfp/nfp_net.c | 4 +--- > 1 file changed, 1 in

Re: [dpdk-dev] [PATCH 4/8] cxgbe: don't refer to eth_dev->pci_dev

2017-01-10 Thread Jan Blunck
On Sat, Jan 7, 2017 at 7:17 PM, Stephen Hemminger wrote: > Later patches remove pci_dev from the ethernet device structure. > Fix the cxgbe code to just use it's own name when forming zone name. > > Signed-off-by: Stephen Hemminger > --- > drivers/net/cxgbe/sge.c | 9 +++-- > 1 file changed,

Re: [dpdk-dev] [PATCH 3/8] vmxnet3: don't refer to eth_dev->pci_dev

2017-01-10 Thread Jan Blunck
On Sat, Jan 7, 2017 at 7:17 PM, Stephen Hemminger wrote: > Fix the vmxnet3 code to just use it's own name when forming zone name. > > Signed-off-by: Stephen Hemminger > --- > drivers/net/vmxnet3/vmxnet3_rxtx.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/drivers/

Re: [dpdk-dev] [PATCH 2/8] i40e: don't refer to eth_dev->pci_dev

2017-01-10 Thread Jan Blunck
On Sat, Jan 7, 2017 at 7:17 PM, Stephen Hemminger wrote: > Later patches remove pci_dev from the ethernet device structure. > Fix the i40e code to just use it's own name when forming zone name. > > Signed-off-by: Stephen Hemminger > --- > drivers/net/i40e/i40e_fdir.c | 3 +-- > 1 file changed, 1

Re: [dpdk-dev] [PATCH v8 18/25] app/testpmd: use VFD APIs on i40e

2017-01-10 Thread Ferruh Yigit
On 1/10/2017 7:16 AM, Wenzhuo Lu wrote: > The new VF Daemon (VFD) APIs is implemented on i40e. Change > testpmd code to use them, including VF MAC anti-spoofing, > VF VLAN anti-spoofing, TX loopback, VF VLAN strip, VF VLAN > insert. > > Signed-off-by: Wenzhuo Lu > Signed-off-by: Chen Jing D(Mark)

[dpdk-dev] [PATCH] doc: fix openssl formating text in documentation

2017-01-10 Thread Daniel Mrzyglod
the code section was lacking indendation to be be corectly formatted. Signed-off-by: Daniel Mrzyglod --- doc/guides/cryptodevs/openssl.rst | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/doc/guides/cryptodevs/openssl.rst b/doc/guides/cryptodevs/openssl.rst

Re: [dpdk-dev] [PATCH v2 1/3] eal: add quiet mode to suppress log output to stdout

2017-01-10 Thread Declan Doherty
On 05/01/17 15:40, Thomas Monjalon wrote: 2017-01-05 17:49, Slawomir Mrozowicz: Add EAL option to suppresses all log output to stdout. Signed-off-by: Declan Doherty [...] " --"OPT_LOG_LEVEL" Set default log level\n" + " -s, --"OPT_LOG_STDOUT_SILENT" Sil

Re: [dpdk-dev] MSI-X vector #1 seems to be stalled sometimes after VF reset (ixgbe)

2017-01-10 Thread Mcnamara, John
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Ruslan Nikolaev > Sent: Tuesday, January 10, 2017 2:48 AM > To: dev@dpdk.org > Subject: Re: [dpdk-dev] MSI-X vector #1 seems to be stalled sometimes > after VF reset (ixgbe) > > dpdk_vfreset.patch: > > diff -urN

Re: [dpdk-dev] [PATCH v3] net/enic: add support for TSO

2017-01-10 Thread Ferruh Yigit
On 1/9/2017 11:04 PM, John Daley wrote: > The enic TSO implementation requires that the length of the Eth/IP/TCP > headers be passed to the NIC. Other than that, it's just a matter of > setting the mss and offload mode on a per packet basis. > > In TSO mode, IP and TCP checksums are offloaded even

Re: [dpdk-dev] [PATCH v2] ixgbe: fix wrong VMDq function name

2017-01-10 Thread Ferruh Yigit
On 1/10/2017 2:19 AM, Wenzhuo Lu wrote: > The function name ixgbe_vmdq_mode_check is not right. > This function checks if Virtualization Technology is > enabled. It's for both VMDq and IOV. > Others may be misled by the current name. > > Fixes: fe3a45fd4104 ("ixgbe: add VMDq support") > > CC: sta

Re: [dpdk-dev] [PATCH] crypto/openssl: fix that remove unneeded check

2017-01-10 Thread Declan Doherty
On 09/01/17 14:45, Piotr Azarewicz wrote: EVP_CIPHER_CTX_set_padding() function always returns 1, so the check is unneeded. Fixes: d61f70b4c918 ("crypto/libcrypto: add driver for OpenSSL library") Signed-off-by: Piotr Azarewicz --- drivers/crypto/openssl/rte_openssl_pmd.c |3 +-- 1 file c

Re: [dpdk-dev] [PATCH] tools: fix active interface detection in dpdk-devbind.py

2017-01-10 Thread De Lara Guarch, Pablo
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Yoni Gilad > Sent: Monday, January 09, 2017 4:38 PM > To: De Lara Guarch, Pablo; Jain, Deepak K > Cc: dev@dpdk.org; Yoni Gilad; sta...@dpdk.org > Subject: [dpdk-dev] [PATCH] tools: fix active interface detection i

Re: [dpdk-dev] [PATCH v2] doc: add tso capabilities feature for mlx5

2017-01-10 Thread Elad Persiko
Thanks, The feature is not supported on MLX4. I will fix it on V2 -Original Message- From: Ferruh Yigit [mailto:ferruh.yi...@intel.com] Sent: Monday, January 9, 2017 2:31 PM To: Elad Persiko ; dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v2] doc: add tso capabilities feature for mlx5 On 1

[dpdk-dev] [PATCH v6 5/5] ethtool: display firmware version

2017-01-10 Thread Qiming Yang
This patch enhances the ethtool example to support to show firmware version, in the same way that the Linux kernel ethtool does. Signed-off-by: Qiming Yang Acked-by: Remy Horton --- examples/ethtool/ethtool-app/ethapp.c | 1 + examples/ethtool/lib/rte_ethtool.c| 6 ++ 2 files changed, 7

[dpdk-dev] [PATCH v6 4/5] net/i40e: add firmware version get

2017-01-10 Thread Qiming Yang
This patch add a new function i40e_fw_version_get. Signed-off-by: Qiming Yang Acked-by: Remy Horton --- doc/guides/nics/features/i40e.ini | 1 + drivers/net/i40e/i40e_ethdev.c| 31 +++ 2 files changed, 32 insertions(+) diff --git a/doc/guides/nics/features/i40e

[dpdk-dev] [PATCH v6 3/5] net/ixgbe: add firmware version get

2017-01-10 Thread Qiming Yang
This patch adds a new function ixgbe_fw_version_get. Signed-off-by: Qiming Yang Acked-by: Remy Horton --- doc/guides/nics/features/ixgbe.ini | 1 + drivers/net/ixgbe/ixgbe_ethdev.c | 25 + 2 files changed, 26 insertions(+) diff --git a/doc/guides/nics/features/ixgbe.

[dpdk-dev] [PATCH v6 2/5] net/e1000: add firmware version get

2017-01-10 Thread Qiming Yang
This patch adds a new function eth_igb_fw_version_get. Signed-off-by: Qiming Yang Acked-by: Remy Horton --- doc/guides/nics/features/igb.ini | 1 + drivers/net/e1000/igb_ethdev.c | 54 2 files changed, 55 insertions(+) diff --git a/doc/guides/nics/fe

[dpdk-dev] [PATCH v6 1/5] ethdev: add firmware version get

2017-01-10 Thread Qiming Yang
This patch adds a new API 'rte_eth_dev_fw_version_get' for fetching firmware version by a given device. Signed-off-by: Qiming Yang Acked-by: Remy Horton --- doc/guides/nics/features/default.ini | 1 + doc/guides/rel_notes/deprecation.rst | 4 doc/guides/rel_notes/release_17_02.rst |

[dpdk-dev] [PATCH v6 0/5] new API 'rte_eth_dev_fw_version_get'

2017-01-10 Thread Qiming Yang
v6: - renamed fw_length -> fw_size - added return value for insufficient fw_size - fixed the indentation problem in e1000 - added ver.build.patch in i40e, keep the same with Linux kernel driver v5: - modified the API rte_eth_dev_fw_version_get(uint8_t port_id, char *fw_version, i

Re: [dpdk-dev] [PATCH v2 5/7] net/virtio_user: add vhost kernel support

2017-01-10 Thread Tan, Jianfeng
On 1/10/2017 4:46 PM, Thomas Monjalon wrote: 2017-01-10 14:11, Tan, Jianfeng: On 1/9/2017 12:39 PM, Jason Wang wrote: On 2016年12月23日 15:14, Jianfeng Tan wrote: [...] +/* TUNSETIFF ifr flags */ +#define IFF_TAP 0x0002 +#define IFF_NO_PI0x1000 +#define IFF_ONE_QUEUE0x2000

  1   2   >