Hi Ferruh, > -----Original Message----- > From: Yigit, Ferruh > Sent: Wednesday, January 11, 2017 4:09 AM > To: Lu, Wenzhuo; dev@dpdk.org > Cc: Chen, Jing D; Iremonger, Bernard > Subject: Re: [dpdk-dev] [PATCH v8 18/25] app/testpmd: use VFD APIs on i40e > > On 1/10/2017 11:29 AM, Ferruh Yigit wrote: > > On 1/10/2017 7:16 AM, Wenzhuo Lu wrote: > >> The new VF Daemon (VFD) APIs is implemented on i40e. Change testpmd > >> code to use them, including VF MAC anti-spoofing, VF VLAN > >> anti-spoofing, TX loopback, VF VLAN strip, VF VLAN insert. > >> > >> Signed-off-by: Wenzhuo Lu <wenzhuo...@intel.com> > >> Signed-off-by: Chen Jing D(Mark) <jing.d.c...@intel.com> > >> Signed-off-by: Bernard Iremonger <bernard.iremon...@intel.com> > >> --- > > > > <...> > > > >> +#ifdef RTE_LIBRTE_IXGBE_PMD > > > > Within this ifdef, there is following call: > > > > ret = rte_pmd_ixgbe_set_all_queues_drop_en(res->port_id, is_on); > > > > It is not safe to make that call directly, port should be verified > > first if it is ixgbe port, as done in other functions. > > With a second thought, although this part is not correct, it is out of this > patches scope, because it concerns ixgbe related part. So below comment also > become invalid. > > Wenzhuo, > > What do you think not changing this patch, but fixing this in a separate > patch? Agree. I'll not change this patch but fix this issue with a separate patch.
> > Thanks, > ferruh
