On Mon, Dec 19, 2016 at 09:59:33PM -0800, Gopakumar Choorakkot Edakkunni wrote:
> While I was testing virtio with ubuntu 14.04 kvm as host and dpdk16.07
> linux as guest, quite often I have seen that I get into a situation where
> virtio_recv_mergeable_pkts() gets into a forever loop, after sending
On Thu, Dec 22, 2016 at 03:18:40PM +0800, Yuanhan Liu wrote:
> Here is a temp to fix few multiple process issues: only did some basic
Sign.., I meant "attempt" :-/
--yliu
If the primary enables the vector Rx/Tx path, the current code would
let the secondary always choose the non vector Rx/Tx path. This results
to a Rx/Tx method mismatch between primary and secondary process. Werid
errors then may happen, something like:
PMD: virtio_xmit_pkts() tx: virtqueue_enq
The introduce of virtio 1.0 support brings yet another set of ops, badly,
it's not handled correctly, that it breaks the multiple process support.
The issue is the function pointer may vary from different processes, and
the current code just does one time set (for primary process only). That
said,
Here is a temp to fix few multiple process issues: only did some basic
test, not positive sure (though it's likely) it will fix the issue
reported by Yaron.
Yaron, please help testing. Thanks!
---
Yuanhan Liu (3):
net/virtio: fix crash for secondary process
net/virtio: fix multiple process su
If a virtio net device is managed by kernel driver, the primary
process would be aware of it and skip it.
For secondary process, however, it isn't aware of that. Instead,
the 'hw' would be NULL. If we keep going on with the rx_func_get(),
a crash would happen. For such case, we simply return 1 to
On Wednesday 21 December 2016 08:39 PM, Jan Blunck wrote:
From: Stephen Hemminger
The info in rte_device about driver is immutable and
shouldn't change.
Acked-by: Jan Blunck
Acked-by: Jan Blunck
Not being picky - but, multiple Acked-by can be removed when this is
applied.
---
lib/libr
>
> Thanks for contributing code. But there are 2 problems here.
>
> 1. You are modifying base code under 'base' directory. It assumed
> READ ONLY because
> there is another Intel team are maintaining it.
> 2. Without your change, the code won't have any negative effect.
> Yes, I appreciate
On Thursday 22 December 2016 10:42 AM, Shreyansh Jain wrote:
On Thursday 22 December 2016 05:03 AM, Stephen Hemminger wrote:
On Wed, 21 Dec 2016 16:38:42 +0100
Jan Blunck wrote:
On Tue, Dec 20, 2016 at 6:11 PM, Stephen Hemminger
wrote:
On Tue, 20 Dec 2016 14:17:14 +0100
Jan Blunck wrote:
Hi, Chenghu,
> -Original Message-
> From: Chenghu Yao [mailto:yao.chen...@zte.com.cn]
> Sent: Wednesday, December 21, 2016 11:05 AM
> To: Chen, Jing D
> Cc: dev@dpdk.org; Chenghu Yao
> Subject: [PATCH] net/fm10k/base: add a break statement
>
> In function fm10k_mbx_create_reply(), the
On Thursday 22 December 2016 05:03 AM, Stephen Hemminger wrote:
On Wed, 21 Dec 2016 16:38:42 +0100
Jan Blunck wrote:
On Tue, Dec 20, 2016 at 6:11 PM, Stephen Hemminger
wrote:
On Tue, 20 Dec 2016 14:17:14 +0100
Jan Blunck wrote:
On Fri, Dec 16, 2016 at 2:10 PM, Shreyansh Jain wrote:
This
On Wed, Dec 21, 2016 at 03:34:14PM +, Declan Doherty wrote:
> On 08/12/16 17:45, Jerin Jacob wrote:
> > On Thu, Dec 08, 2016 at 12:32:52PM +0100, Zbigniew Bodek wrote:
> > > On 08.12.2016 11:24, Bruce Richardson wrote:
> > > > On Tue, Dec 06, 2016 at 06:32:53PM -0800,
> > > > zbigniew.bo...@ca
On Wed, Dec 21, 2016 at 10:06:36AM -0800, Stephen Hemminger wrote:
> On Wed, 21 Dec 2016 17:45:13 +0800
> Yuanhan Liu wrote:
>
> > From: Jan Wickbom
> >
> > Currently select() is used to monitor file descriptors for vhostuser
> > ports. This limits the number of ports possible to create since t
Many thanks to you for your taking time to review this patch set.
Thanks
-Wei
> -Original Message-
> From: Yigit, Ferruh
> Sent: Thursday, December 22, 2016 1:20 AM
> To: Dai, Wei ; dev@dpdk.org
> Cc: Zhang, Helin ; Ananyev, Konstantin
>
> Subject: Re: [dpdk-dev] [PATCH v2 00/30] update
From: Maple
To:
Cc: , ,
Subject: [PATCH] Load_balancer Tx Flush Bug
Date: Thu, 22 Dec 2016 09:57:48 +0800
Message-Id: <1482371868-19669-1-git-send-email-liuj...@raisecom.com>
X-Mailer: git-send-email 1.9.1
In-Reply-To: <2016122122394164225...@raisecom.com>
References: <2016122122394164225...@rai
On 21 December 2016 at 19:03, Bruce Richardson
wrote:
> On Wed, Dec 21, 2016 at 03:38:51PM +0530, Jerin Jacob wrote:
>> On Mon, Dec 19, 2016 at 11:39:18AM +0530, Jianbo Liu wrote:
>>
>> Hi Jianbo,
>>
>> > vPMD will check 4 descriptors in one time, but the statuses are not
>> > consistent
>> > bec
Hi Jerin,
On 21 December 2016 at 18:08, Jerin Jacob
wrote:
> On Mon, Dec 19, 2016 at 11:39:18AM +0530, Jianbo Liu wrote:
>
> Hi Jianbo,
>
>> vPMD will check 4 descriptors in one time, but the statuses are not
>> consistent
>> because the memory allocated for RX descriptors is cacheable huagepage
On Wed, 21 Dec 2016 16:38:42 +0100
Jan Blunck wrote:
> On Tue, Dec 20, 2016 at 6:11 PM, Stephen Hemminger
> wrote:
> > On Tue, 20 Dec 2016 14:17:14 +0100
> > Jan Blunck wrote:
> >
> >> On Fri, Dec 16, 2016 at 2:10 PM, Shreyansh Jain
> >> wrote:
> >> > This patch introduces the rte_bus abs
> -Original Message-
> From: Trahe, Fiona
> Sent: Wednesday, December 21, 2016 11:48 AM
> To: Kusztal, ArkadiuszX; dev@dpdk.org
> Cc: De Lara Guarch, Pablo; Griffin, John; Jain, Deepak K
> Subject: RE: [PATCH 0/3] Add DES capability to Intel QuickAssist Technology
> driver
>
>
>
> > --
Release v0.44 of Intel(R) Multi-Buffer Crypto for IPsec library adds
support for AVX512 instructions. This patch enables the new AVX512
accelerated functions from the aesni_mb_pmd crypto poll mode driver.
This patch set requires that the aesni_mb_pmd is linked against the
version 0.44 or greater o
In patchset "AESNI MB PMD updates"
(http://dpdk.org/ml/archives/dev/2016-December/050976.html) the AESNI
Multi-Buffer Crypto for IPsec library which the aesni_mb_pmd depends on is
updated to v0.44
This patch enables support for runtime selection of the AVX512 accelerated
functions added to the n
On Wed, 21 Dec 2016 16:09:44 +0100
Jan Blunck wrote:
> Only the device itself can decide its PCI or not.
>
> Signed-off-by: Jan Blunck
> Acked-by: Shreyansh Jain
> ---
I would still like to kill dev_pci from the dev_info API.
On Wed, 21 Dec 2016 16:09:33 +0100
Jan Blunck wrote:
> This adds a helper to get the rte_intr_handle from the virtio_hw. This is
> safe to do since the usage of the helper is guarded by RTE_ETH_DEV_INTR_LSC
> which is only set if we found a PCI device during initialization.
>
> Signed-off-by: Ja
> -Original Message-
> From: Hemant Agrawal [mailto:hemant.agra...@nxp.com]
> Sent: Monday, December 19, 2016 8:54 PM
> To: dev@dpdk.org
> Cc: thomas.monja...@6wind.com; Richardson, Bruce
> ; shreyansh.j...@nxp.com; Mcnamara, John
> ; Yigit, Ferruh ;
> jerin.ja...@caviumnetworks.com; Hemant
On Wed, 21 Dec 2016 17:45:13 +0800
Yuanhan Liu wrote:
> From: Jan Wickbom
>
> Currently select() is used to monitor file descriptors for vhostuser
> ports. This limits the number of ports possible to create since the
> fd number is used as index in the fd_set and we have seen fds > 1023.
> This
2016-11-24 12:26, Jan Blunck:
> Prior to 16.11 some drivers (e.g. virtio) still had problems if their
> queues where setup repeatedly. The bonding driver was working around the
> problem by reusing already setup queues. This series of patches changes the
> way how queue setup is done to give contro
On 12/21/2016 9:47 AM, Wei Dai wrote:
> update ixgbe shared code to version 16.11.21 .
> v2 changes:
> modify subject line and message body of git log according to
> feedbacks from communtiy.
>
> split the 24th patch into 2 separate ones.
> the 24th of v1 is net/ixgbe/base: add EEE supp
On 12/21/2016 3:30 PM, Ferruh Yigit wrote:
> On 12/17/2016 6:03 PM, Chas Williams wrote:
>> This patch initializes the eth_dev->link_intr_cbs queue which is
>> used when af_packet is passed into rte_eth_ev_callback_register().
>>
>> Fixes: 4dc294158cac ("ethdev: support optional Rx and Tx callbacks
> > Lets clear the eth_dev->data when allocating a new rte_eth_dev so that
> > drivers only need to set non-zero values.
> >
> > Signed-off-by: Jan Blunck
>
> Reviewed-by: Ferruh Yigit
Both patches applied, thanks
>
>Use device private information to minimize the places that assume eth_dev
>contains pci_dev.
>
>Signed-off-by: Jan Blunck
>---
> drivers/net/bnx2x/bnx2x_ethdev.c | 12 ++--
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
>diff --git a/drivers/net/bnx2x/bnx2x_ethdev.c
>b/drivers/net/b
>
>This simplifies later changes to ethdev.
>
>Signed-off-by: Jan Blunck
>---
> drivers/net/qede/qede_ethdev.c | 18 +-
> 1 file changed, 9 insertions(+), 9 deletions(-)
>
>diff --git a/drivers/net/qede/qede_ethdev.c
>b/drivers/net/qede/qede_ethdev.c
>index d106dd0..a50bd5f 100644
>
On Fri, Dec 16, 2016 at 05:24:57PM +0100, Adrien Mazarguil wrote:
> As previously discussed in RFC v1 [1], RFC v2 [2], with changes
> described in [3] (also pasted below), here is the first non-draft series
> for this new API.
>
> Its capabilities are so generic that its name had to be vague, it m
2016-11-25 14:51, Shreyansh Jain:
> On Thursday 24 November 2016 01:37 AM, Ben Walker wrote:
> > If resources were mapped prior to probe, unmap them
> > if probe fails.
> >
> > This does not handle the case where the kernel driver was
> > forcibly unbound prior to probe.
> >
> > Signed-off-by: Ben
Hi all,
I tested default L2FWD and IP_PIPELINE (pass-through). The throughput of
IP_PIPELINE is higher immensely.
There are only two virtual NICs in KVM. The experiment is just moving
packet from vNIC0 to vNIC1. I think the function is so simple. Why L2FWD
is much slower?
How can I improve L2FW
On 08/12/16 17:45, Jerin Jacob wrote:
On Thu, Dec 08, 2016 at 12:32:52PM +0100, Zbigniew Bodek wrote:
On 08.12.2016 11:24, Bruce Richardson wrote:
On Tue, Dec 06, 2016 at 06:32:53PM -0800, zbigniew.bo...@caviumnetworks.com
wrote:
From: Zbigniew Bodek
Introduce crypto poll mode driver using
On Tue, Dec 20, 2016 at 6:11 PM, Stephen Hemminger
wrote:
> On Tue, 20 Dec 2016 14:17:14 +0100
> Jan Blunck wrote:
>
>> On Fri, Dec 16, 2016 at 2:10 PM, Shreyansh Jain
>> wrote:
>> > This patch introduces the rte_bus abstraction for devices and drivers in
>> > EAL framework. The model is:
>> >
On Tue, Dec 20, 2016 at 4:41 PM, Stephen Hemminger
wrote:
> On Tue, 20 Dec 2016 12:11:53 +0100
> Jan Blunck wrote:
>
>> Only the device itself can decide its PCI or not.
>>
>> Signed-off-by: Jan Blunck
>> ---
>> drivers/net/bnx2x/bnx2x_ethdev.c| 1 +
>> drivers/net/bnxt/bnxt_ethdev.c
On 12/17/2016 6:03 PM, Chas Williams wrote:
> This patch initializes the eth_dev->link_intr_cbs queue which is
> used when af_packet is passed into rte_eth_ev_callback_register().
>
> Fixes: 4dc294158cac ("ethdev: support optional Rx and Tx callbacks")
>
> Signed-off-by: Chas Williams <3ch...@gma
On 12/20/2016 8:57 PM, Chas Williams wrote:
> On Tue, 2016-12-20 at 14:20 +, Ferruh Yigit wrote:
>> On 12/17/2016 6:03 PM, Chas Williams wrote:
>>> This patch initializes the eth_dev->link_intr_cbs queue which is
>>> used when af_packet is passed into rte_eth_ev_callback_register().
>>
>> Why d
Signed-off-by: Jan Blunck
Acked-by: Shreyansh Jain
---
app/test/virtual_pmd.c | 4 ++--
drivers/net/bonding/rte_eth_bond_args.c | 12 ++--
drivers/net/cxgbe/cxgbe_main.c | 4 ++--
drivers/net/fm10k/fm10k_ethdev.c| 6 +++---
drivers/net/mlx4/mlx4.c
PCI drivers could use this helper instead of directly accessing fields of
rte_eth_dev to map to rte_pci_device.
Signed-off-by: Jan Blunck
Acked-by: Shreyansh Jain
---
lib/librte_ether/rte_ethdev.h | 10 ++
1 file changed, 10 insertions(+)
diff --git a/lib/librte_ether/rte_ethdev.h b/li
This simplifies later changes to ethdev.
Signed-off-by: Jan Blunck
---
drivers/net/nfp/nfp_net.c | 16 ++--
1 file changed, 10 insertions(+), 6 deletions(-)
diff --git a/drivers/net/nfp/nfp_net.c b/drivers/net/nfp/nfp_net.c
index de80b46..2609f97 100644
--- a/drivers/net/nfp/nfp_net
This changes the driver to handle the PCI resource directly instead
of repeatedly going through eth_dev.
Signed-off-by: Jan Blunck
---
drivers/net/szedata2/rte_eth_szedata2.c | 72 -
drivers/net/szedata2/rte_eth_szedata2.h | 58 +++---
2 files
Signed-off-by: Jan Blunck
---
drivers/net/vmxnet3/vmxnet3_ethdev.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/vmxnet3/vmxnet3_ethdev.c
b/drivers/net/vmxnet3/vmxnet3_ethdev.c
index 8bb13e5..20a7966 100644
--- a/drivers/net/vmxnet3/vmxnet3_ethdev.c
+++ b/driver
Signed-off-by: Nelio Laranjeiro
---
drivers/net/mlx5/mlx5_flow.c | 59 ++--
1 file changed, 57 insertions(+), 2 deletions(-)
diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c
index a33c568..2478fb6 100644
--- a/drivers/net/mlx5/mlx5_
Introduce initial software validation for rte_flow rules.
Signed-off-by: Nelio Laranjeiro
---
drivers/net/mlx5/mlx5.h | 2 +
drivers/net/mlx5/mlx5_flow.c| 202 ++--
drivers/net/mlx5/mlx5_trigger.c | 2 +
3 files changed, 177 insertions(+), 29 d
Convert Ethernet, IPv4, IPv6, TCP, UDP layers into ibv_flow and create
those rules when after validation (i.e. NIC supports the rule).
VLAN is still not supported in this commit.
Signed-off-by: Nelio Laranjeiro
---
drivers/net/mlx5/mlx5.h | 3 +-
drivers/net/mlx5/mlx5_flow.c| 733
Signed-off-by: Nelio Laranjeiro
---
drivers/net/mlx5/Makefile| 1 +
drivers/net/mlx5/mlx5.h | 16 ++
drivers/net/mlx5/mlx5_fdir.c | 15 ++
drivers/net/mlx5/mlx5_flow.c | 122 +++
4 files changed, 154 insertions(+)
create mode 100644 dr
This series requires rte_flow [1].
It brings rte_flow support to the same level as flow director (FDIR) in mlx5.
[1] http://dpdk.org/ml/archives/dev/2016-December/052950.html
Changes in v3:
- Fix Ethernet ether type issue.
Changes in v2:
- Fix several issues.
- Support VLAN filtering.
N
We don't need to depend on rte_eth_dev->pci_dev to differentiate between
the virtio_user and the virtio_pci case. Instead we can use the private
virtio_hw struct to get that information.
Signed-off-by: Jan Blunck
Acked-by: Shreyansh Jain
---
drivers/net/virtio/virtio_ethdev.c | 24 -
On Wed, Dec 21, 2016 at 11:00 AM, Shreyansh Jain wrote:
> Hi Jan,
>
>
> On Tuesday 20 December 2016 04:41 PM, Jan Blunck wrote:
>>
>> This is a repost of the series I sent in November. I've addressed
>> Shreyansh's
>> review comments about the PCI device users I've missed.
>>
>> Jan Blunck (9):
>>
2016-12-08 11:53, David Marchand:
> On Wed, Dec 7, 2016 at 7:04 PM, Stephen Hemminger
> wrote:
> > No device driver sets the unbind flag in current public code base.
> > Therefore it is good time to remove the unused dead code.
>
> Yes, this has been unused for some time now.
>
> I would say thi
Only the device itself can decide its PCI or not.
Signed-off-by: Jan Blunck
Acked-by: Shreyansh Jain
---
drivers/net/bnx2x/bnx2x_ethdev.c| 1 +
drivers/net/bnxt/bnxt_ethdev.c | 2 ++
drivers/net/cxgbe/cxgbe_ethdev.c| 2 ++
drivers/net/e1000/em_ethdev.c | 1 +
The struct rte_intr_handle is an abstraction layer for different types of
interrupt mechanisms. It is embedded in the low-level device (e.g. PCI).
On allocation of a struct rte_eth_dev a reference to the intr_handle
should be stored for devices supporting interrupts.
Signed-off-by: Jan Blunck
Ack
The drivers should not directly access the rte_eth_dev->pci_dev but use
a helper instead. This is a preparation for replacing the pci_dev with
a struct rte_device member in the future.
Signed-off-by: Jan Blunck
Acked-by: Shreyansh Jain
---
drivers/net/bnx2x/bnx2x_ethdev.c| 2 +-
driver
Instead of duplicating this macro with different names lets use the helper
provided by ethdev.
Signed-off-by: Jan Blunck
---
drivers/net/e1000/e1000_ethdev.h | 2 --
drivers/net/e1000/em_ethdev.c | 13 ++---
drivers/net/e1000/igb_ethdev.c| 25 +
drivers/
This simplifies later changes to ethdev.
Signed-off-by: Jan Blunck
---
drivers/net/qede/qede_ethdev.c | 18 +-
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/drivers/net/qede/qede_ethdev.c b/drivers/net/qede/qede_ethdev.c
index d106dd0..a50bd5f 100644
--- a/drivers
This simplifies later changes to ethdev.
Signed-off-by: Jan Blunck
---
drivers/net/fm10k/fm10k_ethdev.c | 77 ++--
1 file changed, 43 insertions(+), 34 deletions(-)
diff --git a/drivers/net/fm10k/fm10k_ethdev.c b/drivers/net/fm10k/fm10k_ethdev.c
index 923690c
This adds a helper to get the rte_intr_handle from the virtio_hw. This is
safe to do since the usage of the helper is guarded by RTE_ETH_DEV_INTR_LSC
which is only set if we found a PCI device during initialization.
Signed-off-by: Jan Blunck
Acked-by: Shreyansh Jain
---
drivers/net/virtio/virti
Use device private information to minimize the places that assume eth_dev
contains pci_dev.
Signed-off-by: Jan Blunck
---
drivers/net/bnx2x/bnx2x_ethdev.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/net/bnx2x/bnx2x_ethdev.c b/drivers/net/bnx2x/bnx2x_e
From: Stephen Hemminger
Use existing information about pci and interrupt handle to minimize
the number of places that assume eth_dev contains pci_device
information.
Signed-off-by: Stephen Hemminger
Acked-by: Jan Blunck
---
drivers/net/bnxt/bnxt_ethdev.c | 22 +-
drivers/n
This is overwritten in rte_eth_dev_info_get().
Signed-off-by: Jan Blunck
Reviewed-by: David Marchand
---
drivers/net/virtio/virtio_ethdev.c | 4
1 file changed, 4 deletions(-)
diff --git a/drivers/net/virtio/virtio_ethdev.c
b/drivers/net/virtio/virtio_ethdev.c
index 079fd6c..741688e 1006
From: Stephen Hemminger
Simplify later changes to eth_dev.
Signed-off-by: Stephen Hemminger
Acked-by: Jan Blunck
---
drivers/net/i40e/i40e_ethdev.c| 77 ---
drivers/net/i40e/i40e_ethdev.h| 3 ++
drivers/net/i40e/i40e_ethdev_vf.c | 58 ++
From: Stephen Hemminger
Since later changes will change where PCI information is,
localize mapping in one macro.
Signed-off-by: Stephen Hemminger
Acked-by: Jan Blunck
---
drivers/net/ixgbe/ixgbe_ethdev.c | 120 ++-
drivers/net/ixgbe/ixgbe_ethdev.h | 3 +
From: Stephen Hemminger
Create one macro for where PCI device information is extracted
from ethernet device. Makes later changes easier to review, and test.
Acked-by: Jan Blunck
---
drivers/net/e1000/e1000_ethdev.h | 2 +
drivers/net/e1000/em_ethdev.c| 50 +++-
drivers/net
From: Stephen Hemminger
Since rte_eth_dev_info_get does memset() on dev_info before
calling device specific code, the explicit assignment of NULL
in all these virtual drivers has no effect.
Signed-off-by: Stephen Hemminger
Acked-by: Jan Blunck
---
app/test/virtual_pmd.c| 1
From: Stephen Hemminger
The info in rte_device about driver is immutable and
shouldn't change.
Acked-by: Jan Blunck
Acked-by: Jan Blunck
---
lib/librte_eal/common/include/rte_dev.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/librte_eal/common/include/rte_dev.h
b/l
This macro is based on Jan Viktorin's original patch but also checks the
type of the passed pointer against the type of the member.
Signed-off-by: Jan Viktorin
Signed-off-by: Shreyansh Jain
[jblu...@infradead.org: add type checking and __extension__]
Signed-off-by: Jan Blunck
---
lib/librte_ea
Both register/unregister and enable/disable don't necessarily require the
rte_intr_handle to be modifiable. Therefore lets constify it.
Signed-off-by: Jan Blunck
---
lib/librte_eal/common/include/rte_interrupts.h | 8 ++--
lib/librte_eal/linuxapp/eal/eal_interrupts.c | 62 ++--
This is a partial merge of Stephens and my patches to make the rte_eth_dev
independent of the rte_pci_device.
Changes between v4 and v3:
- broken out refactorings of drivers similar to Stephens example
- use inline function instead of macro
- fix build issues with bnx2x and mlx4/5
Changes betw
> -Original Message-
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Adrien Mazarguil
> Sent: Wednesday, December 21, 2016 2:51 PM
> To: dev@dpdk.org
> Subject: [dpdk-dev] [PATCH v5 02/26] doc: add rte_flow prog guide
>
> This documentation is based on the latest RFC submission, s
Hi,
Thanks for trying to send a patch.
Below are some comments to help you sending a proper patch.
2016-12-21 22:39, Maple:
> From 94f2eaed51e6e5402e8c03b80e0999a4fd420390 Mon Sep 17 00:00:00 2001
> From: root
Here we should have your real name, not "root".
> To:
> Cc: , ,
> Date: Wed, 21 Dec
Make all the DPDK Python apps work with Python 2 or 3 to
allow them to work with whatever is the system default.
Signed-off-by: John McNamara
---
app/cmdline_test/cmdline_test.py | 26
app/cmdline_test/cmdline_test_data.py | 2 --
app/test/autotest.py
Add a requirement to support both Python 2 and 3 to the
DPDK Python Coding Standards and Getting started Guide.
Signed-off-by: John McNamara
---
doc/guides/contributing/coding_style.rst | 3 ++-
doc/guides/linux_gsg/sys_reqs.rst| 2 +-
2 files changed, 3 insertions(+), 2 deletions(-)
di
These patches refactor the DPDK Python applications to make them Python 2/3
compatible.
In order to do this the patchset starts by making the apps PEP8 compliant in
accordance with the DPDK Coding guidelines:
http://dpdk.org/doc/guides/contributing/coding_style.html#python-code
Implementing
Make all DPDK python application compliant with the PEP8 standard
to allow for consistency checking of patches and to allow further
refactoring.
Signed-off-by: John McNamara
---
app/cmdline_test/cmdline_test.py | 81 +-
app/cmdline_test/cmdline_test_data.py | 401
> -Original Message-
> From: zbigniew.bo...@caviumnetworks.com
> [mailto:zbigniew.bo...@caviumnetworks.com]
> Sent: Wednesday, December 07, 2016 2:33 AM
> To: De Lara Guarch, Pablo; jerin.ja...@caviumnetworks.com
> Cc: dev@dpdk.org; Zbigniew Bodek
> Subject: [PATCH v2 08/12] mk/crypto/arm
This commit exposes the following item fields through the flow command:
- VLAN priority code point, drop eligible indicator and VLAN identifier
(all part of TCI).
- IPv4 type of service, time to live and protocol.
- IPv6 traffic class, flow label, next header and hop limit.
- SCTP tag and checks
> -Original Message-
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of
> zbigniew.bo...@caviumnetworks.com
> Sent: Wednesday, December 07, 2016 2:33 AM
> To: De Lara Guarch, Pablo; jerin.ja...@caviumnetworks.com
> Cc: dev@dpdk.org; Zbigniew Bodek
> Subject: [dpdk-dev] [PATCH v2 06/12
Document syntax, interaction with rte_flow and provide usage examples.
Signed-off-by: Adrien Mazarguil
Acked-by: Olga Shern
Acked-by: John McNamara
---
doc/guides/testpmd_app_ug/testpmd_funcs.rst | 612 +++
1 file changed, 612 insertions(+)
diff --git a/doc/guides/testpmd_
- QUEUE: assign packets to a given queue index.
- DUP: duplicate packets to a given queue index.
- RSS: spread packets among several queues.
Signed-off-by: Adrien Mazarguil
Acked-by: Olga Shern
---
app/test-pmd/cmdline_flow.c | 152 +++
1 file changed, 152 in
- MARK: attach 32 bit value to packets.
- FLAG: flag packets.
- DROP: drop packets.
- COUNT: enable counters for a rule.
- PF: redirect packets to physical device function.
- VF: redirect packets to virtual device function.
Signed-off-by: Adrien Mazarguil
Acked-by: Olga Shern
---
app/test-pmd/c
Add the ability to match a few properties of common L4[.5] protocol
headers:
- ICMP: type and code.
- UDP: source and destination ports.
- TCP: source and destination ports.
- SCTP: source and destination ports.
- VXLAN: network identifier.
Signed-off-by: Adrien Mazarguil
Acked-by: Olga Shern
-
Add the ability to match basic fields from IPv4 and IPv6 headers (source
and destination addresses only).
Signed-off-by: Adrien Mazarguil
Acked-by: Olga Shern
---
app/test-pmd/cmdline_flow.c | 177 +++
1 file changed, 177 insertions(+)
diff --git a/app/test-
Matches arbitrary byte strings with properties:
- relative: look for pattern after the previous item.
- search: search pattern from offset (see also limit).
- offset: absolute or relative offset for pattern.
- limit: search area limit for start of pattern.
- length: pattern length.
- pattern: byte
These pattern items match basic Ethernet headers (source, destination and
type) and related 802.1Q/ad VLAN headers.
Signed-off-by: Adrien Mazarguil
Acked-by: Olga Shern
---
app/test-pmd/cmdline_flow.c | 126 +++
1 file changed, 126 insertions(+)
diff --git a
- PF: match packets addressed to the physical function.
- VF: match packets addressed to a virtual function ID.
- PORT: device-specific physical port index to use.
Signed-off-by: Adrien Mazarguil
Acked-by: Olga Shern
---
app/test-pmd/cmdline_flow.c | 53
This pattern item matches any protocol in place of the current layer and
has two properties:
- min: minimum number of layers covered (0 or more).
- max: maximum number of layers covered (0 means infinity).
Signed-off-by: Adrien Mazarguil
Acked-by: Olga Shern
---
app/test-pmd/cmdline_flow.c | 2
Several rte_flow structures expose bit-fields that cannot be set in a
generic fashion at byte level. Add bit-mask support to handle them.
Signed-off-by: Adrien Mazarguil
Acked-by: Olga Shern
---
app/test-pmd/cmdline_flow.c | 70
1 file changed, 70 insert
Add parser code to fully set individual fields of pattern item
specification structures, using the following operators:
- fix: sets field and applies full bit-mask for perfect matching.
- spec: sets field without modifying its bit-mask.
- last: sets upper value of the spec => last range.
- mask: s
Syntax:
flow query {port_id} {rule_id} {action}
Query a specific action of an existing flow rule.
Signed-off-by: Adrien Mazarguil
Acked-by: Olga Shern
---
app/test-pmd/cmdline.c | 3 +
app/test-pmd/cmdline_flow.c | 121 ++-
2 files changed, 123 inse
Generating bit-masks from prefix lengths is often more convenient than
providing them entirely (e.g. to define IPv4 and IPv6 subnets).
This commit adds the "prefix" operator that assigns generated bit-masks to
any pattern item specification field.
Signed-off-by: Adrien Mazarguil
Acked-by: Olga S
Syntax:
flow (validate|create) {port_id}
[group {group_id}] [priority {level}] [ingress] [egress]
pattern {item} [/ {item} [...]] / end
actions {action} [/ {action} [...]] / end
Either check the validity of a flow rule or create it. Any number of
pattern items and actions can be prov
Syntax:
flow flush {port_id}
Destroy all flow rules on a port.
Signed-off-by: Adrien Mazarguil
Acked-by: Olga Shern
---
app/test-pmd/cmdline.c | 3 +++
app/test-pmd/cmdline_flow.c | 43 +++-
2 files changed, 45 insertions(+), 1 deletion(-)
diff --gi
Syntax:
flow destroy {port_id} rule {rule_id} [...]
Destroy a given set of flow rules associated with a port.
Signed-off-by: Adrien Mazarguil
Acked-by: Olga Shern
---
app/test-pmd/cmdline.c | 3 ++
app/test-pmd/cmdline_flow.c | 106 ++-
2 files chan
Syntax:
flow list {port_id} [group {group_id}] [...]
List configured flow rules on a port. Output can optionally be limited to a
given set of group identifiers.
Signed-off-by: Adrien Mazarguil
Acked-by: Olga Shern
---
app/test-pmd/cmdline.c | 4 ++
app/test-pmd/cmdline_flow.c | 141 ++
Parse all integer types and handle conversion to network byte order in a
single function.
Signed-off-by: Adrien Mazarguil
Acked-by: Olga Shern
---
app/test-pmd/cmdline_flow.c | 148 +++
1 file changed, 148 insertions(+)
diff --git a/app/test-pmd/cmdline_flow
Add basic management functions for the generic flow API (validate, create,
destroy, flush, query and list). Flow rule objects and properties are
arranged in lists associated with each port.
Signed-off-by: Adrien Mazarguil
Acked-by: Olga Shern
---
app/test-pmd/cmdline.c | 1 +
app/test-pmd
Managing generic flow API functions from command line requires the use of
dynamic tokens for convenience as flow rules are not fixed and cannot be
defined statically.
This commit adds specific flexible parser code and object for a new "flow"
command in separate file.
Signed-off-by: Adrien Mazargu
This prevents sigbus errors on architectures that cannot handle unexpected
unaligned accesses to the output buffer.
Signed-off-by: Adrien Mazarguil
Acked-by: Olga Shern
---
lib/librte_cmdline/cmdline_parse.c | 9 ++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/lib/librte
1 - 100 of 181 matches
Mail list logo
