[dpdk-dev] [PATCH] vhost: fix use after free issue

2016-10-18 Thread Yuanhan Liu
Fix the coverity USE_AFTER_FREE issue. Fixes: a277c7159876 ("vhost: refactor code structure") Coverity issue: 137884 Reported-by: John McNamara Signed-off-by: Yuanhan Liu --- lib/librte_vhost/socket.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/librte_vhost/socket.c

[dpdk-dev] [PATCH v3] vhost: Only access header if offloading is supported in dequeue path

2016-10-18 Thread Yuanhan Liu
On Fri, Oct 14, 2016 at 10:07:07AM +0200, Maxime Coquelin wrote: > If offloading features are not negotiated, parsing the virtio header > is not needed. > > Micro-benchmark with testpmd shows that the gain is +4% with indirect > descriptors, +1% when using direct descriptors. > > Signed-off-by: M

[dpdk-dev] [PATCH] drivers: make driver names consistent

2016-10-18 Thread Yuanhan Liu
On Tue, Oct 18, 2016 at 03:42:54PM +0200, Thomas Monjalon wrote: > 2016-10-18 21:06, Yuanhan Liu: > > On Tue, Oct 18, 2016 at 02:50:16PM +0200, Jan Blunck wrote: > > > >From my understanding this is a massive API breakage. This forces all > > > existing users of the virtual PMDs to change with zero

[dpdk-dev] Project Governance and Linux Foundation

2016-10-18 Thread Jerin Jacob
On Tue, Oct 18, 2016 at 03:27:27PM +0200, Thomas Monjalon wrote: > 2016-10-18 17:04, Jerin Jacob: > > On Mon, Oct 17, 2016 at 05:23:42PM -0400, Dave Neary wrote: > > > > I still hear concerns on this, and based on discussions with others who > > > > put their names to the post below, they do too.

[dpdk-dev] [PATCH v4 32/32] net/qede: update driver version

2016-10-18 Thread Rasesh Mody
This patch updates the qede pmd version to 1.2.0.1. Signed-off-by: Rasesh Mody --- drivers/net/qede/qede_ethdev.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/qede/qede_ethdev.h b/drivers/net/qede/qede_ethdev.h index 5ab36a5..5eb3f52 100644 --- a/drivers/net/qe

[dpdk-dev] [PATCH v4 31/32] doc: update qede pmd documentation

2016-10-18 Thread Rasesh Mody
Signed-off-by: Rasesh Mody Acked-by: John McNamara --- doc/guides/nics/qede.rst | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/doc/guides/nics/qede.rst b/doc/guides/nics/qede.rst index 902e82b..b6f54fd 100644 --- a/doc/guides/nics/qede.rst +++ b/doc/guides/nics/qede.rst @

[dpdk-dev] [PATCH v4 30/32] net/qede: remove zlib dependency and enable PMD by default

2016-10-18 Thread Rasesh Mody
The QEDE PMD now uses unzipped firmware file eliminating the dependency on zlib. Hence remove LDLIBS entry form the Makefile and enable qede PMD by default. Fixes: 6adac0bf30b3 ("qede: add missing external dependency and disable by default") Signed-off-by: Rasesh Mody --- config/common_base

[dpdk-dev] [PATCH v4 29/32] net/qede: add support for queue statistics

2016-10-18 Thread Rasesh Mody
This patch adds support for pulling per queue statistics. Signed-off-by: Rasesh Mody --- drivers/net/qede/qede_ethdev.c | 98 +- drivers/net/qede/qede_ethdev.h | 3 ++ drivers/net/qede/qede_rxtx.c | 23 +- drivers/net/qede/qede_rxtx.h | 4 +-

[dpdk-dev] [PATCH v4 28/32] net/qede: fix status block index for VF queues

2016-10-18 Thread Rasesh Mody
From: Harish Patil o Fix the fastpath status block index such that each queue pair shares the same index value. o Add ecore_vf_get_num_sbs() API that returns the number of status blocks assigned by PF. Use that to decide how many VF queues can be advertised. Additionally, restrict maximum number

[dpdk-dev] [PATCH v4 27/32] net/qede: fix driver version string

2016-10-18 Thread Rasesh Mody
From: Harish Patil This patch fixes the base driver version display. The driver version notation is: Fixes: 2ea6f76aff40 ("qede: add core driver") Signed-off-by: Harish Patil --- drivers/net/qede/qede_ethdev.c | 43 +- drivers/net/qede/qede_ethdev.h |

[dpdk-dev] [PATCH v4 26/32] net/qede: skip slowpath polling for 100G VF device

2016-10-18 Thread Rasesh Mody
From: Harish Patil There is no need to poll for slowpath events for VF device since the ramrod responses are received over PF-VF backchannel synchronously. So the fix is to restrict the slowpath polling for PF device only. Fixes: 2af14ca79c0a ("net/qede: support 100G") Signed-off-by: Harish Pat

[dpdk-dev] [PATCH v4 25/32] net/qede/base: add support to initiate PF FLR

2016-10-18 Thread Rasesh Mody
From: Harish Patil Add support to send PF FLR request to the management firmware to bringup the device in clean slate. This cleanup is necessary in some corner cases where the device would be left in a bad state from its previous operations. The driver will send PF FLR request before slowpath ini

[dpdk-dev] [PATCH v4 24/32] net/qede/base: change Rx Tx queue start APIs

2016-10-18 Thread Rasesh Mody
Changed q_{rx,tx}_start APIs to use common queue start parameters Signed-off-by: Rasesh Mody --- drivers/net/qede/base/ecore_l2.c | 131 +++ drivers/net/qede/base/ecore_l2.h | 26 ++- drivers/net/qede/base/ecore_l2_api.h | 69 +- driv

[dpdk-dev] [PATCH v4 23/32] net/qede: add scatter gather support

2016-10-18 Thread Rasesh Mody
From: Sony Chacko Add scatter gather support to enable transmit and receive of larger packets. Signed-off-by: Sony Chacko --- doc/guides/nics/features/qede.ini| 1 + doc/guides/nics/features/qede_vf.ini | 1 + doc/guides/nics/qede.rst | 4 +- drivers/net/qede/qede_ethdev.

[dpdk-dev] [PATCH v4 22/32] net/qede: fix RSS related issues

2016-10-18 Thread Rasesh Mody
From: Harish Patil This patch contains few RSS related changes as follows: o Fix inadvertent initializing of rss_params outside of the if block in qed_update_vport() which could cause FW exception. o Fix disabling of RSS when hash function is 0. o Rename qede_config_rss() to qede_check_vport

[dpdk-dev] [PATCH v4 21/32] net/qede: add enable/disable VLAN filtering

2016-10-18 Thread Rasesh Mody
From: Harish Patil The device doesn't explicitly support enable/disable of VLAN filtering. However, VLAN filtering takes effect when a matching VLAN is configured. So in order to support enable/disable of VLAN filtering, VLAN 0 is added/removed respectively. A check is added to ensure that the us

[dpdk-dev] [PATCH v4 20/32] net/qede: fixes for VLAN filters

2016-10-18 Thread Rasesh Mody
From: Harish Patil - fix to prevent duplicate VLAN filters librte_ether does not keep track of VLAN filters configured, so it becomes driver's responsibility to keep track of it and prevent duplicate filter programming. The fix is to use a singly linked list for tracking the entries and there b

[dpdk-dev] [PATCH v4 19/32] net/qede: remove unused/dead code

2016-10-18 Thread Rasesh Mody
From: Harish Patil Fixes: 2ea6f76aff40 ("qede: add core driver") Signed-off-by: Harish Patil Signed-off-by: Rasesh Mody --- drivers/net/qede/base/ecore_iov_api.h | 312 -- drivers/net/qede/qede_eth_if.c| 10 -- drivers/net/qede/qede_ethdev.c|

[dpdk-dev] [PATCH v4 18/32] net/qede: add missing 100G link speed capability

2016-10-18 Thread Rasesh Mody
From: Harish Patil This patch fixes the missing 100G link speed advertisement when the 100G support was initially added. Fixes: 2af14ca79c0a ("net/qede: support 100G") Signed-off-by: Harish Patil --- doc/guides/nics/features/qede.ini| 1 + doc/guides/nics/features/qede_vf.ini | 1 + drive

[dpdk-dev] [PATCH v4 17/32] net/qede/base: allow MTU change via vport-update

2016-10-18 Thread Rasesh Mody
From: Harish Patil Add support to allow MTU change on a deactivated vport in the qede/base driver and the core driver shall utilize the same. Signed-off-by: Harish Patil --- drivers/net/qede/base/ecore_l2.c | 5 + drivers/net/qede/base/ecore_l2_api.h | 4 drivers/net/qede/qede_eth

[dpdk-dev] [PATCH v4 16/32] net/qede: fix port (re)configuration issue

2016-10-18 Thread Rasesh Mody
From: Harish Patil Some applications set port configuration params like promisc mode before calling dev_start(). This config results in a firmware exception since this operation internally translates to sending of VPORT-UPDATE before VPORT-START ramrod which is considered illegal from firmware st

[dpdk-dev] [PATCH v4 15/32] net/qede: enable support for unequal number of Rx/Tx queues

2016-10-18 Thread Rasesh Mody
From: Sony Chacko Previous release of the qede PMD had a limitation that the driver expects the number of tx and rx queues to be the same. This patch fixes this issue by making appropriate changes in control and data path. Fixes: 2ea6f76aff40 ("qede: add core driver") Signed-off-by: Sony Chacko

[dpdk-dev] [PATCH v4 14/32] net/qede/base: add MFW crash dump support

2016-10-18 Thread Rasesh Mody
Add support for management firmware(MFW) crash dump collection. Signed-off-by: Rasesh Mody --- drivers/net/qede/base/ecore.h | 3 + drivers/net/qede/base/ecore_dev.c | 22 ++--- drivers/net/qede/base/ecore_dev_api.h | 29 --- drivers/net/qede/base/ecore_mcp.c | 151 ++

[dpdk-dev] [PATCH v4 13/32] net/qede/base: comment enhancements

2016-10-18 Thread Rasesh Mody
Comment additions and modifications Signed-off-by: Rasesh Mody --- drivers/net/qede/base/ecore_dev_api.h | 4 +- drivers/net/qede/base/ecore_gtt_reg_addr.h | 10 + drivers/net/qede/base/ecore_hsi_common.h | 863 +++- drivers/net/qede/base/ecore_hsi_eth.h |

[dpdk-dev] [PATCH v4 12/32] net/qede/base: rename structure and defines

2016-10-18 Thread Rasesh Mody
Renamed following to match with HSI changes - PMM_* to ETH_* - pmm_* to eth_* Signed-off-by: Rasesh Mody --- drivers/net/qede/base/ecore_l2.c | 90 ++--- drivers/net/qede/base/ecore_mcp.c | 12 +-- drivers/net/qede/base/mcp_public.h | 158 +-

[dpdk-dev] [PATCH v4 11/32] net/qede/base: update base driver

2016-10-18 Thread Rasesh Mody
This patch updates the base driver and incorporates necessary changes required to bring in the new firmware 8.10.9.0. In addition, it would allow driver to add new functionalities that might be needed in future. Signed-off-by: Rasesh Mody --- doc/guides/nics/features/qede.ini |2 +

[dpdk-dev] [PATCH v4 10/32] net/qede: add NIC selftest and query sensor info support

2016-10-18 Thread Rasesh Mody
From: Harish Patil This patch adds API support for NIC selftests (BIST) and APIs to retrieve GPIO info, sensor data like temperature, MBA versions, ECC events etc. Signed-off-by: Harish Patil --- drivers/net/qede/base/ecore_mcp.c | 314 ++ drivers/net/qede/b

[dpdk-dev] [PATCH v4 09/32] net/qede: serialize access to MFW mbox

2016-10-18 Thread Rasesh Mody
From: Harish Patil Add ecore_mcp_mb_lock() and ecore_mcp_mb_unlock() APIs to ensure a single thread is accessing MFW mailbox. Signed-off-by: Harish Patil --- drivers/net/qede/base/ecore_mcp.c | 70 ++- drivers/net/qede/base/ecore_mcp.h | 4 +++ 2 files chan

[dpdk-dev] [PATCH v4 08/32] net/qede: change signature of MCP command API

2016-10-18 Thread Rasesh Mody
From: Harish Patil Change ecore_mcp_cmd_and_union() to accept pointer to a structure rather than accepting multiple arguments. A new struct ecore_mcp_mb_params is added for that purpose. Also make this function static. This change is mostly keeping in mind the future requests which needs addition

[dpdk-dev] [PATCH v4 07/32] net/qede: fix 32 bit compilation

2016-10-18 Thread Rasesh Mody
Fix 32 bit compilation for gcc version 4.3.4. Fixes: ec94dbc57362 ("qede: add base driver") Signed-off-by: Rasesh Mody --- drivers/net/qede/Makefile | 4 1 file changed, 4 insertions(+) diff --git a/drivers/net/qede/Makefile b/drivers/net/qede/Makefile index fe449aa..7965a83 100644 --- a/

[dpdk-dev] [PATCH v4 06/32] net/qede/base: additional formatting/comment changes

2016-10-18 Thread Rasesh Mody
Change details: - adds new comments - modifies some of the existing comments - abstract code into macros - split long lines Signed-off-by: Rasesh Mody --- drivers/net/qede/base/ecore.h | 3 +- drivers/net/qede/base/ecore_chain.h | 14 ++--- drivers/net/qede/base/ecore_

[dpdk-dev] [PATCH v4 05/32] net/qede/base: add attention formatting string

2016-10-18 Thread Rasesh Mody
In case of attention from a signal that's represented by multiple bits in misc AEU, add the format string which is populated with proper index and resulting prints will show string as a prefix. Signed-off-by: Rasesh Mody --- drivers/net/qede/base/bcm_osal.c | 21 + drivers/n

[dpdk-dev] [PATCH v4 04/32] net/qede/base: add HSI changes and register defines

2016-10-18 Thread Rasesh Mody
- add the hardware software interface(HSI) changes - add register definitions These will be required for 8.10.9.0 FW upgrade. Signed-off-by: Rasesh Mody --- drivers/net/qede/base/common_hsi.h | 1202 +- drivers/net/qede/base/ecore_dev.c|2 - drive

[dpdk-dev] [PATCH v4 03/32] net/qede: use FW CONFIG defines as needed

2016-10-18 Thread Rasesh Mody
Replaced CONFIG_QED_BINARY_FW with CONFIG_ECORE_BINARY_FW. Use CONFIG_ECORE_BINARY_FW and CONFIG_ECORE_ZIPPED_FW defines as required. Signed-off-by: Rasesh Mody --- drivers/net/qede/base/bcm_osal.c | 2 ++ drivers/net/qede/base/ecore.h| 20 +++- drivers/net/qede/qede_main.c

[dpdk-dev] [PATCH v4 02/32] net/qede/base: formatting changes

2016-10-18 Thread Rasesh Mody
Fixes white spaces and tabs. Signed-off-by: Rasesh Mody --- drivers/net/qede/base/common_hsi.h | 252 ++--- drivers/net/qede/base/ecore.h | 414 +++ drivers/net/qede/base/ecore_chain.h | 20 +- drivers/net/qede/base/ecore_cxt.c | 16 +- drivers/

[dpdk-dev] [PATCH v4 01/32] net/qede/base: add new init files and rearrange the code

2016-10-18 Thread Rasesh Mody
Added ecore_hsi_debug_tools.h, ecore_hsi_init_func.h, ecore_hsi_init_tool.h files. Rearranged code from ecore_hsi_common.h and ecore_hsi_tools.h to the new files. Removed unused code. Signed-off-by: Rasesh Mody --- drivers/net/qede/base/ecore.h | 17 +- drivers/net/qede/base/ec

[dpdk-dev] [PATCH v4 00/32] net/qede: update qede pmd to 1.2.0.1 and enable by default

2016-10-18 Thread Rasesh Mody
Hi, This patch set includes changes to update the base driver, work with newer FW 8.10.9.0, adds new features, includes enhancements and code cleanup, provides bug fixes and updates documentation for the QEDE poll mode driver. It enables QEDE PMD in the dpdk config by default. The dependency on e

[dpdk-dev] [PATCH] drivers: make driver names consistent

2016-10-18 Thread Yuanhan Liu
On Tue, Oct 18, 2016 at 02:50:16PM +0200, Jan Blunck wrote: > >From my understanding this is a massive API breakage. This forces all > existing users of the virtual PMDs to change with zero benefit. Even > if that isn't enough it also makes it impossible to switch between > releases by recompiling.

[dpdk-dev] [PATCH] drivers: make driver names consistent

2016-10-18 Thread Thomas Monjalon
2016-10-18 22:18, Yuanhan Liu: > On Tue, Oct 18, 2016 at 03:42:54PM +0200, Thomas Monjalon wrote: > > 2016-10-18 21:06, Yuanhan Liu: > > > On Tue, Oct 18, 2016 at 02:50:16PM +0200, Jan Blunck wrote: > > > > >From my understanding this is a massive API breakage. This forces all > > > > existing user

[dpdk-dev] [PATCH] drivers: make driver names consistent

2016-10-18 Thread Thomas Monjalon
2016-10-18 17:26, Jan Blunck: > On Tue, Oct 18, 2016 at 3:42 PM, Thomas Monjalon > wrote: > > 2016-10-18 21:06, Yuanhan Liu: > >> On Tue, Oct 18, 2016 at 02:50:16PM +0200, Jan Blunck wrote: > >> > >From my understanding this is a massive API breakage. This forces all > >> > existing users of the v

[dpdk-dev] [dpdk-users] How to printout PMD logs to console

2016-10-18 Thread yingzhi
Hi All, I'm doing app debug and would like to see device PMD logs, e.g. dpdk/drivers/net/ixgbe/ixgbe_rxtx.c:1703 PMD_RX_LOG(...) Currently I can only see RTE logs from console. Any comments is appreciated Thanks

[dpdk-dev] [PATCH 1/3] mbuf: embedding timestamp into the packet

2016-10-18 Thread Olivier Matz
On 10/13/2016 04:35 PM, Oleg Kuporosov wrote: > The hard requirement of financial services industry is accurate > timestamping aligned with the packet itself. This patch is to satisfy > this requirement: > > - include uint64_t timestamp field into rte_mbuf with minimal impact to > throughput/l

[dpdk-dev] [PATCH 2/2] vhost: Add indirect desc support to the Rx no-mergeable path

2016-10-18 Thread Maxime Coquelin
Linux virtio-net kernel driver uses indirect descriptors when mergeable buffers are not used. This patch adds its support, fixing the use of indirect descriptors with these guests. Cc: Yuanhan Liu Cc: Ciara Loftus Signed-off-by: Maxime Coquelin --- lib/librte_vhost/virtio_net.c | 30 +

[dpdk-dev] [PATCH 1/2] vhost: Add indirect desc support to Rx mergeable path

2016-10-18 Thread Maxime Coquelin
Windows virtio-net driver uses indirect descriptors with mergeable buffers. This patch adds its support, fixing the use of indirect descriptors with these guests. Cc: Yuanhan Liu Cc: Zhihong Wang Signed-off-by: Maxime Coquelin --- lib/librte_vhost/virtio_net.c | 43 +++

[dpdk-dev] [PATCH 0/2] vhost: Add support to indirect descriptors on Rx path

2016-10-18 Thread Maxime Coquelin
Indirect descriptor feature has been enabled in v16.11-rc1, but only TX path was implemented. However, some configurations expect it is supported for the Rx path: - Windows guests with and without mergeable buffers enabled - Linux guests with Kernel drivr with mergeable buffers disabled This ser

[dpdk-dev] [PATCH] drivers: make driver names consistent

2016-10-18 Thread Jan Blunck
On Tue, Oct 18, 2016 at 3:42 PM, Thomas Monjalon wrote: > 2016-10-18 21:06, Yuanhan Liu: >> On Tue, Oct 18, 2016 at 02:50:16PM +0200, Jan Blunck wrote: >> > >From my understanding this is a massive API breakage. This forces all >> > existing users of the virtual PMDs to change with zero benefit. E

[dpdk-dev] [PATCH v2 2/2] drivers/i40e: fix the hash filter invalid calculation in X722

2016-10-18 Thread Ferruh Yigit
On 10/16/2016 2:40 AM, Jeff Guo wrote: > As X722 extracts IPv4 header to Field Vector different with XL710/X710, > need to corresponding to modify the fields of IPv4 header in input set > to map different default Field Vector Table of different NICs. > > Signed-off-by: Jeff Guo > > --- > v2: > f

[dpdk-dev] [PATCH v2 1/2] drivers/i40e: fix X722 macro absence result in compile

2016-10-18 Thread Ferruh Yigit
On 10/17/2016 10:54 AM, Ananyev, Konstantin wrote: > Hi Jeff, > >> >> hi, Konstantin >> Thanks your constructive suggestion. I don't think your question is >> silly and we also think about the code style simply and effective, but >> may be i would interpret the reason why we do that. >> >> 1) Sure

[dpdk-dev] [PATCH] Revert "bonding: use existing enslaved device queues"

2016-10-18 Thread Jan Blunck
On Tue, Oct 18, 2016 at 2:49 PM, Ilya Maximets wrote: > On 18.10.2016 15:28, Jan Blunck wrote: >> If the application already configured queues the PMD should not >> silently claim ownership and reset them. >> >> What exactly is the problem when changing MTU? This works fine from >> what I can tel

[dpdk-dev] Project Governance and Linux Foundation

2016-10-18 Thread Jerin Jacob
On Mon, Oct 17, 2016 at 05:23:42PM -0400, Dave Neary wrote: > Hi, > > On 10/17/2016 07:52 AM, O'Driscoll, Tim wrote: > >> -Original Message- > >> I don't really understand what can be gained by moving to Linux > >> Foundation, but I am almost sure that no individual expert will be able > >

[dpdk-dev] [PATCH v6 1/6] ethdev: add Tx preparation

2016-10-18 Thread Olivier Matz
Hi Tomasz, I think the principle of tx_prep() is good, it may for instance help to remove the function virtio_tso_fix_cksum() from the virtio, and maybe even change the mbuf TSO/cksum API. I have some questions/comments below, I'm sorry it comes very late. On 10/14/2016 05:05 PM, Tomasz Kulasek

[dpdk-dev] [PATCH v7 0/7] vhost: optimize mergeable Rx path

2016-10-18 Thread Maxime Coquelin
Hi Yuanhan, On 10/14/2016 11:34 AM, Yuanhan Liu wrote: > This is a new set of patches to optimize the mergeable Rx code path. > No refactoring (rewrite) was made this time. It just applies some > findings from Zhihong (kudos to him!) that could improve the mergeable > Rx path on the old code. > >

[dpdk-dev] [RFC] [PATCH v2] libeventdev: event driven programming model framework for DPDK

2016-10-18 Thread Jerin Jacob
On Mon, Oct 17, 2016 at 08:26:33PM +, Eads, Gage wrote: > > > > -Original Message- > > From: Jerin Jacob [mailto:jerin.jacob at caviumnetworks.com] > > Sent: Sunday, October 16, 2016 11:18 PM > > To: Eads, Gage > > Cc: dev at dpdk.org; thomas.monjalon at 6wind.com; Richardson, B

[dpdk-dev] [opnfv-tech-discuss][apex][ovsnfv]Problem showed up with OVS/DPDK with Cisco VIC adapter

2016-10-18 Thread Thomas F Herbert
All: This is not necessarily related to VPP but rather to OVS/DPDK. In OPNFV we found the following problem when using UCS NIC. The UCS fabric seems to set a VLAN tag on untagged packets. Any thoughts from DPDK and VPP folks would be appreciated. http://dpdk.org/doc/guides-16.07/nics/enic.html

[dpdk-dev] [PATCH] vhost: disable indirect descriptors feature

2016-10-18 Thread Yuanhan Liu
On Tue, Oct 18, 2016 at 10:13:54AM +0200, Maxime Coquelin wrote: > >>Thanks to Zhihong series you reworked, the changes to be done for > >>mergeable buffers case is greatly simplified. > >>I'll send the series later today. > > > >Do you mean the v6 from Zhihong? Unluckily, it will not be merged. Th

[dpdk-dev] [PATCH] vhost: disable indirect descriptors feature

2016-10-18 Thread Yuanhan Liu
On Tue, Oct 18, 2016 at 09:04:44AM +0200, Maxime Coquelin wrote: > Hi Yuanhan, > > On 10/17/2016 05:10 PM, Maxime Coquelin wrote: > >Commit 2304dd73d287 ("vhost: support indirect Tx descriptors") > >adds support for indirect descriptors for Tx, but not for Rx. > > > >The problem is that it does no

[dpdk-dev] [PATCH v2 12/12] virtio: add Tso support

2016-10-18 Thread Olivier Matz
Hi Stephen, On 10/14/2016 01:33 AM, Stephen Hemminger wrote: > On Thu, 13 Oct 2016 16:18:39 +0800 > Yuanhan Liu wrote: > >> On Mon, Oct 03, 2016 at 11:00:23AM +0200, Olivier Matz wrote: >>> +/* When doing TSO, the IP length is not included in the pseudo header >>> + * checksum of the packet give

[dpdk-dev] [PATCH] Revert "bonding: use existing enslaved device queues"

2016-10-18 Thread Ilya Maximets
On 18.10.2016 15:28, Jan Blunck wrote: > If the application already configured queues the PMD should not > silently claim ownership and reset them. > > What exactly is the problem when changing MTU? This works fine from > what I can tell. Following scenario leads to APP PANIC: 1. mempool

[dpdk-dev] [PATCH v11 00/24] Introducing rte_driver/rte_device generalization

2016-10-18 Thread Thomas Monjalon
2016-10-18 09:04, Neil Horman: > On Mon, Oct 17, 2016 at 02:43:12PM +0100, Ferruh Yigit wrote: > > I caught while running ABI validation script today, I think this patch > > should increase LIBABIVER of: > > - lib/librte_cryptodev > > - lib/librte_eal > > - lib/librte_ether > > > It should, and it

[dpdk-dev] [PATCH] drivers: make driver names consistent

2016-10-18 Thread Thomas Monjalon
2016-10-18 21:06, Yuanhan Liu: > On Tue, Oct 18, 2016 at 02:50:16PM +0200, Jan Blunck wrote: > > >From my understanding this is a massive API breakage. This forces all > > existing users of the virtual PMDs to change with zero benefit. Even > > if that isn't enough it also makes it impossible to sw

[dpdk-dev] Project Governance and Linux Foundation

2016-10-18 Thread Thomas Monjalon
2016-10-18 17:04, Jerin Jacob: > On Mon, Oct 17, 2016 at 05:23:42PM -0400, Dave Neary wrote: > > > I still hear concerns on this, and based on discussions with others who > > > put their names to the post below, they do too. I think it's a perception > > > that we need to address. > > > > I woul

[dpdk-dev] [dpdk-users] Project Governance and Linux Foundation

2016-10-18 Thread Thomas Monjalon
2016-10-17 14:40, O'Driscoll, Tim: > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > > 2016-10-17 11:52, O'Driscoll, Tim: > > > From: Hobywan Kenoby > > > > The current DPDK version can run on virtually all processors (Intel, > > > > IBM and ARM) and leverage all NICs: is there **real

[dpdk-dev] [PATCH] net/ixgbe: fix vlan insert parameter type and its use

2016-10-18 Thread E. Scott Daniels
The final parameter to rte_pmd_ixgbe_set_vf_vlan_insert is uint8_t and treated as a binary flag when it needs to be a uint16_t and treated as a VLAN id. The data sheet (sect 8.2.3.27.13) describes the right most 16 bits as the VLAN id that is to be inserted; the 16.11 code is accepting only a 1 o

[dpdk-dev] [dpdk-users] Project Governance and Linux Foundation

2016-10-18 Thread Thomas Monjalon
2016-10-18 12:16, Liu Yuan: > China Mobile would like to support moving the DPDK project to the Linux > Foundation. OK, there can be some advantages to join the Linux Foundation. > DPDK is a key technology / element in the NFV. As an end user, we can foresee > the importance of DPDK in the futu

[dpdk-dev] [PATCH] drivers: make driver names consistent

2016-10-18 Thread Jan Blunck
>From my understanding this is a massive API breakage. This forces all existing users of the virtual PMDs to change with zero benefit. Even if that isn't enough it also makes it impossible to switch between releases by recompiling. Can we please revert these changes and work on some aliasing suppo

[dpdk-dev] [PATCH v1] doc: announce API change for ethdev function

2016-10-18 Thread Bernard Iremonger
The _rte_eth_dev_call_process function will change to return "int" and a fourth parameter "void* ret_param" will be added. This change targets release 17.02. Signed-off-by: Bernard Iremonger --- doc/guides/rel_notes/deprecation.rst | 4 1 file changed, 4 insertions(+) diff --git a/doc/guid

[dpdk-dev] [PATCH v1] doc: announce API and ABI change for librte_ether

2016-10-18 Thread Bernard Iremonger
In 17.02 five rte_eth_dev_set_vf_*** functions will be removed from librte_ether, renamed and moved to the ixgbe PMD. Signed-off-by: Bernard Iremonger --- doc/guides/rel_notes/deprecation.rst | 36 1 file changed, 36 insertions(+) diff --git a/doc/guides/rel

[dpdk-dev] [PATCH] Revert "bonding: use existing enslaved device queues"

2016-10-18 Thread Jan Blunck
If the application already configured queues the PMD should not silently claim ownership and reset them. What exactly is the problem when changing MTU? This works fine from what I can tell. Cheers, Jan On Wed, Sep 7, 2016 at 2:28 PM, Ilya Maximets wrote: > This reverts commit 5b7bb2bda5519b7800

[dpdk-dev] [PATCH 2/2] examples/tep_term: Fix packet len for multi-seg mbuf

2016-10-18 Thread Michael Qiu
For multi-seg mbuf, ip->total_length should be pkt_len subtract ether len. Fixes: 4abe471ed6fc("examples/tep_term: implement VXLAN processing") Signed-off-by: Michael Qiu --- examples/tep_termination/vxlan.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/examples/tep_termin

[dpdk-dev] [PATCH 1/2] examples/tep_term: Fix l4_len issue

2016-10-18 Thread Michael Qiu
l4_len is not fixed, althrough mostly it is a fixed value, but when guest using iperf to do some tests, the l4_len will have another 12 bytes optional fields. Fixes: 2bb43bd4350a("examples/tep_term: add TSO offload configuration") Signed-off-by: Michael Qiu --- examples/tep_termination/vxlan.c

[dpdk-dev] [PATCH] openssl pmd: rename SW crypto device from libcrypto to openssl

2016-10-18 Thread Slawomir Mrozowicz
This patch replaces name "libcrypto" to "openssl" from file directories, symbol prefixes and sub-names connected with old name. Renamed poll mode driver files, test files, and documentations. It is done to better name association with library because the cryptography operations are using Openssl li

[dpdk-dev] [PATCH] examples/ip_pipeline: fix freeBSD build error

2016-10-18 Thread Dumitrescu, Cristian
> -Original Message- > From: Singh, Jasvinder > Sent: Monday, October 17, 2016 4:49 PM > To: dev at dpdk.org > Cc: Dumitrescu, Cristian > Subject: [PATCH] examples/ip_pipeline: fix freeBSD build error > > Error log: > CC init.o > examples/ip_pipeline/init.c:38:22: fatal error: linux/i

[dpdk-dev] [PATCH v6 0/6] add Tx preparation

2016-10-18 Thread Ananyev, Konstantin
> > As discussed in that thread: > > http://dpdk.org/ml/archives/dev/2015-September/023603.html > > Different NIC models depending on HW offload requested might impose different > requirements on packets to be TX-ed in terms of: > > - Max number of fragments per packet allowed > - Max numb

[dpdk-dev] packet sojourn time on TX/RX queues

2016-10-18 Thread Ali Volkan Atli
Hello I'm trying to implement CoDel algorithm on Intel's DPDK library, so I need to measure packet sojourn time (the time a packet stays in the queue before being sent) but I have trouble with measuring packet sojourn time on RX/TX queues because of DMA usage. When I call rte_eth_tx_burst() fu

[dpdk-dev] [PATCH v2 0/3] net: fix out of order Rx read issue

2016-10-18 Thread Ananyev, Konstantin
> > In vPMD, when load Rx desc with _mm_loadu_si128, > volatile point will be cast into non-volatile point. > So GCC is allowed to reorder the load instructions, > while Rx read's correctness is reply on these load > instructions to follow a backward sequence strictly, > so we add compile barrie

[dpdk-dev] [dpdk-users] How to printout PMD logs to console

2016-10-18 Thread Kavanagh, Mark B
> >Hi All, > > >I'm doing app debug and would like to see device PMD logs, e.g. >dpdk/drivers/net/ixgbe/ixgbe_rxtx.c:1703 > PMD_RX_LOG(...) Hi Yingzhi, PMD_RX_LOG is defined in ixgbe_logs.h (see code snippet below). #ifdef RTE_LIBRTE_IXGBE_DEBUG_RX #define

[dpdk-dev] [RFC v3] latencystats: added new library for latency stats

2016-10-18 Thread Pattan, Reshma
Hi, The below latency stats RFC adds new field to second cache line of mbuf. This is not an ABI break. But I would like to emphasize on this point so you can have a look into the changes and provide comments. Thanks, Reshma > -Original Message- > From: Pattan, Reshma > Sent: Monday, O

[dpdk-dev] [PATCH v7 0/7] vhost: optimize mergeable Rx path

2016-10-18 Thread Jianbo Liu
On 14 October 2016 at 17:34, Yuanhan Liu wrote: > This is a new set of patches to optimize the mergeable Rx code path. > No refactoring (rewrite) was made this time. It just applies some > findings from Zhihong (kudos to him!) that could improve the mergeable > Rx path on the old code. .. > -

[dpdk-dev] [PATCH v11 00/24] Introducing rte_driver/rte_device generalization

2016-10-18 Thread Ferruh Yigit
On 10/17/2016 6:29 PM, Shreyansh Jain wrote: > Hi Ferruh, > >> -Original Message- >> From: Ferruh Yigit [mailto:ferruh.yigit at intel.com] >> Sent: Monday, October 17, 2016 7:13 PM >> To: Shreyansh Jain ; Thomas Monjalon >> >> Cc: dev at dpdk.org; viktorin at rehivetech.com; David Marchan

[dpdk-dev] [PATCH] vhost: disable indirect descriptors feature

2016-10-18 Thread Maxime Coquelin
On 10/18/2016 10:12 AM, Yuanhan Liu wrote: > On Tue, Oct 18, 2016 at 09:04:44AM +0200, Maxime Coquelin wrote: >> Hi Yuanhan, >> >> On 10/17/2016 05:10 PM, Maxime Coquelin wrote: >>> Commit 2304dd73d287 ("vhost: support indirect Tx descriptors") >>> adds support for indirect descriptors for Tx, bu

[dpdk-dev] [PATCH] vhost: disable indirect descriptors feature

2016-10-18 Thread Maxime Coquelin
Hi Yuanhan, On 10/17/2016 05:10 PM, Maxime Coquelin wrote: > Commit 2304dd73d287 ("vhost: support indirect Tx descriptors") > adds support for indirect descriptors for Tx, but not for Rx. > > The problem is that it does not work with windows guests, which > uses indirect descriptors for the Rx, an

[dpdk-dev] [PATCH v11 00/24] Introducing rte_driver/rte_device generalization

2016-10-18 Thread Neil Horman
On Mon, Oct 17, 2016 at 02:43:12PM +0100, Ferruh Yigit wrote: > On 10/5/2016 12:57 PM, Shreyansh Jain wrote: > > Hi Thomas, > > > > On Tuesday 04 October 2016 01:12 PM, Thomas Monjalon wrote: > >> 2016-10-04 12:21, Shreyansh Jain: > >>> Hi Thomas, > >>> > >>> On Monday 03 October 2016 07:58 PM, Th

[dpdk-dev] [PATCH v2] net/ixgbe: support multiqueue mode VMDq DCB with SRIOV

2016-10-18 Thread Iremonger, Bernard
Hi Wenzhuo, > > Subject: RE: [PATCH v2] net/ixgbe: support multiqueue mode VMDq DCB > > with SRIOV > > > > Hi Wenzhuo, > > > > > > if (hw->mac.type != ixgbe_mac_82598EB) { @@ -3339,11 +3340,17 > > > @@ > > > > ixgbe_dcb_tx_hw_config(struct ixgbe_hw *hw, > > > > if (dcb_co

[dpdk-dev] [PATCH v5 0/2] app/testpmd: improve multiprocess support

2016-10-18 Thread Sergio Gonzalez Monroy
On 30/09/2016 15:00, Marcin Kerlin wrote: > This patch ensure not overwrite device data in the multiprocess application. > > 1)Changes in the library introduces continuity in array rte_eth_dev_data[] > shared between all processes. Secondary process adds new entries in free > space instead of overw

[dpdk-dev] [PATCH v2 3/3] net/fm10k: fix out of ofder Rx read issue

2016-10-18 Thread Qi Zhang
In vPMD, when load Rx desc with _mm_loadu_si128, volatile point will be cast into non-volatile point. So GCC is allowed to reorder the load instructions, while Rx read's correctness is reply on these load instructions to follow a backward sequence strictly, so we add compile barrier to prevent comp

[dpdk-dev] [PATCH v2 2/3] net/ixgbe: fix out of order Rx read issue

2016-10-18 Thread Qi Zhang
In vPMD, when load Rx desc with _mm_loadu_si128, volatile point will be cast into non-volatile point. So GCC is allowed to reorder the load instructions, while Rx read's correctness is reply on these load instructions to follow a backward sequence strictly, so we add compile barrier to prevent comp

[dpdk-dev] [PATCH v2 1/3] net/i40e: fix out of order Rx read issue

2016-10-18 Thread Qi Zhang
In vPMD, when load Rx desc with _mm_loadu_si128, volatile point will be cast into non-volatile point. So GCC is allowed to reorder the load instructions, while Rx read's correctness is reply on these load instructions to follow a backward sequence strictly, so we add compile barrier to prevent comp

[dpdk-dev] [PATCH v2 0/3] net: fix out of order Rx read issue

2016-10-18 Thread Qi Zhang
In vPMD, when load Rx desc with _mm_loadu_si128, volatile point will be cast into non-volatile point. So GCC is allowed to reorder the load instructions, while Rx read's correctness is reply on these load instructions to follow a backward sequence strictly, so we add compile barrier to prevent

[dpdk-dev] [PATCH v2] net/ixgbe: support multiqueue mode VMDq DCB with SRIOV

2016-10-18 Thread Lu, Wenzhuo
Hi Bernard, > -Original Message- > From: Iremonger, Bernard > Sent: Tuesday, October 18, 2016 12:27 AM > To: Lu, Wenzhuo; dev at dpdk.org; Shah, Rahul R > Subject: RE: [PATCH v2] net/ixgbe: support multiqueue mode VMDq DCB with > SRIOV > > Hi Wenzhuo, > > > > if (hw->mac.type != ixgbe