[dpdk-dev] [PATCH v8 2/2] examples/ipsec-secgw: add sample configuration files

2016-09-23 Thread De Lara Guarch, Pablo
> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Sergio Gonzalez > Monroy > Sent: Friday, September 23, 2016 12:53 AM > To: Zhang, Roy Fan; dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH v8 2/2] examples/ipsec-secgw: add sample > configuration files > > On

[dpdk-dev] [PATCH v8 1/2] examples/ipsec-secgw: add configuration file support

2016-09-23 Thread De Lara Guarch, Pablo
> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Sergio Gonzalez > Monroy > Sent: Friday, September 23, 2016 12:53 AM > To: Zhang, Roy Fan; dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH v8 1/2] examples/ipsec-secgw: add > configuration file support > > On

[dpdk-dev] [PATCH v2] vhost: Add indirect descriptors support to the TX path

2016-09-23 Thread Michael S. Tsirkin
On Fri, Sep 23, 2016 at 11:24:16AM -0700, Stephen Hemminger wrote: > On Fri, 23 Sep 2016 09:16:49 +0200 > Maxime Coquelin wrote: > > > Indirect descriptors are usually supported by virtio-net devices, > > allowing to dispatch a larger number of requests. > > > > When the virtio device sends a pa

[dpdk-dev] [PATCH] net/vhost: Add function to retreive the 'vid' for a given port id

2016-09-23 Thread Wiles, Keith
Regards, Keith > On Sep 23, 2016, at 12:26 AM, Yuanhan Liu > wrote: > > On Thu, Sep 22, 2016 at 06:43:55PM +0200, Thomas Monjalon wrote: There could be a similar need in other PMD. If we can get an opaque identifier of the device which is not the port id, w

[dpdk-dev] [PATCH v3] vhost: Add indirect descriptors support to the TX path

2016-09-23 Thread Michael S. Tsirkin
On Fri, Sep 23, 2016 at 08:16:09PM +0200, Maxime Coquelin wrote: > > > On 09/23/2016 08:06 PM, Michael S. Tsirkin wrote: > > On Fri, Sep 23, 2016 at 08:02:27PM +0200, Maxime Coquelin wrote: > > > > > > > > > On 09/23/2016 05:49 PM, Michael S. Tsirkin wrote: > > > > On Fri, Sep 23, 2016 at 10:28

[dpdk-dev] [PATCH v2] sched: fix releasing enqueued packets

2016-09-23 Thread Thomas Monjalon
> > rte_sched_port_free should release only enqueued packets of all queues. > > Previous behavior is that enqueued and already dequeued packets of > > only first 4 queues are released. > > > > Fixes: 61383240 ("sched: release enqueued mbufs when freeing port") > > > > Signed-off-by: Hiroyuki Miki

[dpdk-dev] [PATCH v3] vhost: Add indirect descriptors support to the TX path

2016-09-23 Thread Michael S. Tsirkin
On Fri, Sep 23, 2016 at 08:02:27PM +0200, Maxime Coquelin wrote: > > > On 09/23/2016 05:49 PM, Michael S. Tsirkin wrote: > > On Fri, Sep 23, 2016 at 10:28:23AM +0200, Maxime Coquelin wrote: > > > Indirect descriptors are usually supported by virtio-net devices, > > > allowing to dispatch a larger

[dpdk-dev] [PATCH v2 1/1] dpdk_procinfo: check for primary process

2016-09-23 Thread Thomas Monjalon
2016-09-08 12:31, Van Haaren, Harry: > > Add a check to see if the primary process is running and exit gracefully if > > it > > is not. > > v2: > > * Updated to tone down message and remove unnecessary brackets. > > > > Suggested-by: Patrick Kutch > > Signed-off-by: Maryam Tahhan > > Acked-by:

[dpdk-dev] [PATCH] testpmd: fix fdir command on MAC and tunnel modes

2016-09-23 Thread Thomas Monjalon
Anyone to review please? 2016-08-23 11:10, Frederico.Cadete-ext at oneaccess-net.com: > The flow_director_filter commands has a pf|vf option for most modes > except for MAC-VLAN and tunnel. On Intel NIC's these modes are not > supported under virtualized environments. > But the application was che

[dpdk-dev] [PATCH v2] app/testpmd: fix RSS-hash-key size

2016-09-23 Thread Thomas Monjalon
Anyone to review please? 2016-08-05 16:34, Mohammad Abdul Awal: > RSS hash-key-size is retrieved from device configuration instead of > using a fixed size of 40 bytes. > > Fixes: f79959ea1504 ("app/testpmd: allow to configure RSS hash key") > > Signed-off-by: Mohammad Abdul Awal

[dpdk-dev] [PATCH] app/testpmd: fix set MTU cmd help string

2016-09-23 Thread Thomas Monjalon
> > Fixes: ae03d0d18adf ("app/testpmd: command to configure MTU") > > > > Signed-off-by: Ferruh Yigit > > Acked-by: Pablo de Lara Applied, thanks

[dpdk-dev] [PATCH] app/testpmd: fix DCB config issue on ixgbe

2016-09-23 Thread Thomas Monjalon
What is the status of this patch? 2016-08-05 13:20, Wenzhuo Lu: > An issue is found that DCB cannot be configured on ixgbe > NICs. It's said the TX queue number is not right. > On ixgbe the max TX queue number is not fixed, it depends > on the multi-queue mode. > > This patch adds the device conf

[dpdk-dev] [PATCH] app/testpmd: fix timeout in Rx queue flushing

2016-09-23 Thread Thomas Monjalon
2016-09-13 17:04, Ferruh Yigit: > On 9/8/2016 10:49 AM, James Poole wrote: > > When testpmd is run, the application would hang on the second time > > that "start" is executed. This is because the timer limit would get > > multiplied to an unreachably high number. > > > > At the start of flush_fwd_

[dpdk-dev] [dpdk-stable] [PATCH v3] testpmd: fix crash when mempool allocation fails

2016-09-23 Thread Thomas Monjalon
> > Avoid access to mempool pointer if it is NULL. > > > > Fixes: b19a0c75a0d4 ("app/testpmd: remove anonymous mempool code") > > Coverity issue: 127553 > > > > Signed-off-by: Olivier Matz > > Acked-by: Pablo de Lara Applied, thanks

[dpdk-dev] [PATCH v3] vhost: Add indirect descriptors support to the TX path

2016-09-23 Thread Maxime Coquelin
On 09/23/2016 08:06 PM, Michael S. Tsirkin wrote: > On Fri, Sep 23, 2016 at 08:02:27PM +0200, Maxime Coquelin wrote: >> >> >> On 09/23/2016 05:49 PM, Michael S. Tsirkin wrote: >>> On Fri, Sep 23, 2016 at 10:28:23AM +0200, Maxime Coquelin wrote: Indirect descriptors are usually supported by v

[dpdk-dev] [PATCH v3] vhost: Add indirect descriptors support to the TX path

2016-09-23 Thread Maxime Coquelin
On 09/23/2016 05:49 PM, Michael S. Tsirkin wrote: > On Fri, Sep 23, 2016 at 10:28:23AM +0200, Maxime Coquelin wrote: >> Indirect descriptors are usually supported by virtio-net devices, >> allowing to dispatch a larger number of requests. >> >> When the virtio device sends a packet using indirect

[dpdk-dev] VLAN tx insert offload in I350

2016-09-23 Thread Shyam Sundar Govindaraj
Hi Has anyone tried VLAN tx insert offload in I350 nic.? It doesn't seem to be working. 03:00.0 Ethernet controller [0200]: Intel Corporation I350 Gigabit Network Connection [8086:1521] (rev 01) 0b:00.0 Ethernet controller [0200]: Intel Corporation I350 Gigabit Network Connection [8086:1521]

[dpdk-dev] [PATCH] app/test-pipeline: Fix table hash lru initialization

2016-09-23 Thread Thomas Monjalon
> > macro ?APP_METADATA_OFFSET? was not used to initialize > > ?signature_offset? and ?key_offset? part of struct > > rte_table_hash_lru_params. > > Instead integer offset values were directly used. > > > > with this fix 'hash-8-lru', 'hash-16-lru', 'hash-32-lru' table types are > > able to forwar

[dpdk-dev] [RFC PATCH v2 3/5] librte_ether: add API's for VF management

2016-09-23 Thread Thomas Monjalon
2016-09-23 17:02, Iremonger, Bernard: > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > > 2016-09-23 09:53, Richardson, Bruce: > > > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > > > > 2016-09-23 10:20, Bruce Richardson: > > > > > On Thu, Sep 22, 2016 at 07:04:37PM +02

[dpdk-dev] [PATCH v3] vhost: Add indirect descriptors support to the TX path

2016-09-23 Thread Michael S. Tsirkin
On Fri, Sep 23, 2016 at 10:28:23AM +0200, Maxime Coquelin wrote: > Indirect descriptors are usually supported by virtio-net devices, > allowing to dispatch a larger number of requests. > > When the virtio device sends a packet using indirect descriptors, > only one slot is used in the ring, even f

[dpdk-dev] [PATCH] app/test: fix failing packet-framework table unit-tests

2016-09-23 Thread Thomas Monjalon
> > The pipeline object is not freed when a particular test-case of the > > unit-test > > finishes. Using rte_pipeline_free() before returning the outcome for each > > test-case fixes the issue. > > > > Fixes: 5205954791cb ("app/test: packet framework unit tests") > > > > Signed-off-by: Jasvinde

[dpdk-dev] [PATCH] app/test: decrease memory requirements for sched

2016-09-23 Thread Thomas Monjalon
> > The sched test consumes 35MB memory. When memory is too fragmented > > (with > > 2M hugepages), the test can fail. > > > > To reduce this risk, decrease it to 4.5MB by modifying > > n_pipes_per_subport and qsize. > > > > Signed-off-by: Olivier Matz > > Acked-by: Cristian Dumitrescu Applie

[dpdk-dev] [PATCH] app/test: decrease memory requirements for hash

2016-09-23 Thread Thomas Monjalon
2016-09-12 13:38, Olivier Matz: > In hash autotest, the size of tables that should be succesfully created > is 32K entries (256KB), except for the table called "different_name", > which is 1M entries (8MB). When memory is too fragmented (with 2M > hugepages), the test can fail. > > To avoid alloca

[dpdk-dev] [PATCH v3 0/5] vhost: optimize enqueue

2016-09-23 Thread Jianbo Liu
On 23 September 2016 at 10:56, Wang, Zhihong wrote: . > This is expected because the 2nd patch is just a baseline and all optimization > patches are organized in the rest of this patch set. > > I think you can do bottleneck analysis on ARM to see what's slowing down the > perf, there might be

[dpdk-dev] [dpdk-stable] [PATCH] mk: use ?= instead of := for RTE_DEVEL_BUILD

2016-09-23 Thread Thomas Monjalon
2016-09-14 12:54, Christian Ehrhardt: > On Wed, Sep 14, 2016 at 12:50 PM, Luca Boccassi > wrote: > > > RTE_DEVEL_BUILD is set to := y in mk/rte.vars.mk, which makes it > > impossible to override via an environment variable, and forces users > > to pass it inline in the make call. > > Use ?= inste

[dpdk-dev] [PATCH] mk: add missing *CPPFLAGS to rte.compile-pre.mk

2016-09-23 Thread Thomas Monjalon
2016-09-14 13:06, Christian Ehrhardt: > On Tue, Aug 30, 2016 at 7:25 PM, Luca Boccassi > wrote: > > > Some targets in mk/internal/rte.compile-pre.mk are calling CC or > > HOSTCC without passing CPPFLAGS, EXTRA_CPPFLAGS or HOST_CPPFLAGS, > > HOST_EXTRA_CPPFLAGS. > > On Debian/Ubuntu builds this m

[dpdk-dev] [PATCH] Tools: Fix issue with virtio interface names

2016-09-23 Thread Yuanhan Liu
On Fri, Sep 02, 2016 at 03:23:34PM +, Mcnamara, John wrote: > > > > -Original Message- > > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Gary Mussar > > Sent: Friday, September 2, 2016 2:17 PM > > To: dev at dpdk.org > > Cc: Gary Mussar > > Subject: [dpdk-dev] [PATCH] Tools

[dpdk-dev] [PATCH v2] net/virtio: fix build error with clang

2016-09-23 Thread Yuanhan Liu
On Fri, Sep 23, 2016 at 10:31:12AM +0200, Thomas Monjalon wrote: > 2016-09-23 14:15, Yuanhan Liu: > > - _mm_prefetch((const void *)rused, _MM_HINT_T0); > > + rte_prefetch0(rused); > > There are other occurences of _mm_prefetch in other drivers. > It could deserve a patch. Indeed. I could make

[dpdk-dev] [PATCH] net/vhost: Add function to retreive the 'vid' for a given port id

2016-09-23 Thread Yuanhan Liu
On Fri, Sep 23, 2016 at 10:43:20AM +0200, Thomas Monjalon wrote: > 2016-09-23 12:26, Yuanhan Liu: > > On Thu, Sep 22, 2016 at 06:43:55PM +0200, Thomas Monjalon wrote: > > > > > > > > > There could be a similar need in other PMD. > > > > > > > > > If we can get an opaque identifier of the device whi

[dpdk-dev] [PATCH] eal: remove single file segments related code

2016-09-23 Thread Yuanhan Liu
On Fri, Sep 23, 2016 at 10:50:06AM +0200, Thomas Monjalon wrote: > 2016-09-23 15:10, Yuanhan Liu: > > Commit c711ccb30987 ("ivshmem: remove library and its EAL integration") > > removed ivshmem support, but seems David forgot to remove the another > > piece of code: code for RTE_EAL_SINGLE_FILE_SEG

[dpdk-dev] [PATCH 0/2] examples/l2fwd: Add option to enable/disable MAC addresses tweaking

2016-09-23 Thread De Lara Guarch, Pablo
> -Original Message- > From: Maxime Coquelin [mailto:maxime.coquelin at redhat.com] > Sent: Friday, September 23, 2016 6:52 AM > To: De Lara Guarch, Pablo; Richardson, Bruce > Cc: dev at dpdk.org > Subject: Re: [PATCH 0/2] examples/l2fwd: Add option to enable/disable MAC > addresses tweak

[dpdk-dev] [PATCH] app/test: add AES GCM performance test to cryptodev

2016-09-23 Thread Yuanhan Liu
On Fri, Sep 23, 2016 at 09:02:49AM +, Jain, Deepak K wrote: > > > > -Original Message- > > From: Yuanhan Liu [mailto:yuanhan.liu at linux.intel.com] > > Sent: Friday, September 23, 2016 7:33 AM > > To: Kusztal, ArkadiuszX > > Cc: dev at dpdk.org; Trahe, Fiona ; Jain, Deepak K > > ; D

[dpdk-dev] [RFC PATCH v2 3/5] librte_ether: add API's for VF management

2016-09-23 Thread Iremonger, Bernard
Hi Thoms > -Original Message- > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > Sent: Friday, September 23, 2016 2:15 PM > To: Richardson, Bruce ; Iremonger, Bernard > > Cc: dev at dpdk.org; Jerin Jacob ; Shah, > Rahul R ; Lu, Wenzhuo ; > azelezniak > Subject: Re: [dpdk-dev

[dpdk-dev] [PATCH] mk: fix verbosity zero

2016-09-23 Thread Thomas Monjalon
2016-09-23 10:33, Ferruh Yigit: > On 9/23/2016 12:42 AM, Thomas Monjalon wrote: > > Verbosity is considered enabled when $V is not empty. > > So V=0 and V=1 are equivalent. > > It is fixed by unsetting V when it is 0. > > > > A side effect is to fix kernel module compilation verbosity > > which is

[dpdk-dev] [PATCH v2 1/2] librte_ether: ensure not overwrite device data in mp app

2016-09-23 Thread Thomas Monjalon
2016-09-22 14:11, Kerlin, MarcinX: > Hi Reshma, > > From: Pattan, Reshma > > > > Hi Marcin, > > > > > /** > > > * @internal > > > + * Returns a shared device data slot specified by the unique identifier > > > name. > > > + * > > > + * @paramname > > > + * The pointer to the Unique i

[dpdk-dev] [PATCH v3] rte_delay_us can be replaced with user function

2016-09-23 Thread Thomas Monjalon
2016-09-23 08:39, jozmarti at cisco.com: > --- a/lib/librte_eal/common/include/generic/rte_cycles.h > +++ b/lib/librte_eal/common/include/generic/rte_cycles.h > @@ -180,15 +180,17 @@ rte_get_timer_hz(void) > default: rte_panic("Invalid timer source specified\n"); > } > } > - > /** > +

[dpdk-dev] [PATCH v2 1/6] ethdev: add Tx preparation

2016-09-23 Thread Jerin Jacob
On Fri, Sep 23, 2016 at 09:41:52AM +, Ananyev, Konstantin wrote: Hi Konstantin, > Hi Jerin, > > > > > Hi Konstantin, > > > > > > > > Hi Jerin, > > > > > > > > > > > > > Hi Jerin, > > > > > > > > Hi Konstantin, > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > [...] > > > > > >

[dpdk-dev] [PATCH 0/2] examples/l2fwd: Add option to enable/disable MAC addresses tweaking

2016-09-23 Thread Maxime Coquelin
Hi John, On 08/30/2016 05:42 PM, Mcnamara, John wrote: >> -Original Message- >> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Maxime Coquelin >> Sent: Tuesday, July 26, 2016 4:56 PM >> To: Richardson, Bruce ; De Lara Guarch, Pablo >> >> Cc: dev at dpdk.org; Maxime Coquelin >> S

[dpdk-dev] [PATCH v6] net/virtio: add set_mtu in virtio

2016-09-23 Thread Yuanhan Liu
On Wed, Sep 21, 2016 at 06:45:05PM -0700, Stephen Hemminger wrote: > On Thu, 22 Sep 2016 00:08:38 + > "Dey, Souvik" wrote: > > > Answers inline. > > > > -- > > Regards, > > Souvik > > > > -Original Message- > > From: Stephen Hemminger [mailto:stephen at networkplumber.org] > > Sent

[dpdk-dev] [PATCH 0/2] examples/l2fwd: Add option to enable/disable MAC addresses tweaking

2016-09-23 Thread Maxime Coquelin
On 09/21/2016 11:53 PM, De Lara Guarch, Pablo wrote: > > >> -Original Message- >> From: Maxime Coquelin [mailto:maxime.coquelin at redhat.com] >> Sent: Tuesday, July 26, 2016 8:56 AM >> To: Richardson, Bruce; De Lara Guarch, Pablo >> Cc: dev at dpdk.org; Maxime Coquelin >> Subject: [PATCH

[dpdk-dev] [PATCH v2 2/2] doc: l2fwd: document new --[no-]mac-updating option

2016-09-23 Thread Maxime Coquelin
This patch documents the new l2fwd option, which provides a way to disable the MAC addresses updating, enabling the use of l2fwd for basic VM to VM communication. Acked-by: John McNamara Signed-off-by: Maxime Coquelin --- doc/guides/sample_app_ug/img/l2_fwd_vm2vm.svg | 311

[dpdk-dev] [PATCH v2 1/2] examples/l2fwd: Add new option to enable/disable MAC addresses updating

2016-09-23 Thread Maxime Coquelin
l2fwd could be useful for testing virtual devices without the need of physical ones. To achieve this, this patch adds a new option to enable/disable the MAC addresses updating done at forwarding time: --[no-]mac-updating By default, MAC address updating remains enabled, to keep consistency with p

[dpdk-dev] [PATCH v2 0/2] examples/l2fwd: Add option to enable/disable MAC addresses updating

2016-09-23 Thread Maxime Coquelin
This series adds a new option to enable/disable MAC addresses updating in l2fwd example. Doing that, we can enable basic VM 2 VM communication easily, without external projects dependencies, nor real NIC (as with vhost example). Example of cli with vhost-user: #l2fwd -c f --socket-mem=1024 \

[dpdk-dev] [PATCH v3 0/5] vhost: optimize enqueue

2016-09-23 Thread Thomas Monjalon
2016-09-23 18:41, Jianbo Liu: > On 23 September 2016 at 10:56, Wang, Zhihong > wrote: > . > > This is expected because the 2nd patch is just a baseline and all > > optimization > > patches are organized in the rest of this patch set. > > > > I think you can do bottleneck analysis on ARM to s

[dpdk-dev] [PATCH] Tools: Fix issue with virtio interface names

2016-09-23 Thread Yuanhan Liu
On Thu, Sep 22, 2016 at 04:46:52PM +0200, Thomas Monjalon wrote: > 2016-09-22 10:34, Mussar, Gary: > > I am new at submitting patches to dpdk.org. This patch has been acked and > > patchwork claims success on build it: > > http://www.dpdk.org/dev/patchwork/patch/15595/ > > > > Other users state

[dpdk-dev] [PATCH v2] vhost: Add indirect descriptors support to the TX path

2016-09-23 Thread Yuanhan Liu
On Fri, Sep 23, 2016 at 09:16:49AM +0200, Maxime Coquelin wrote: > + if (vq->desc[desc_indexes[i]].flags & VRING_DESC_F_INDIRECT) { > + if (unlikely(!(dev->features & > + (1ULL << > VIRTIO_RING_F_INDIRECT_DESC { > +

[dpdk-dev] [PATCH v6] net/virtio: add set_mtu in virtio

2016-09-23 Thread Dey, Souvik
Hi Liu/Mark/Stephen, I have tried to modify the code with all of your latest comments. Do let me know if this looks fine or you have more comments. Changes done : -- max frame ize is compare to VIRTIO_MAX_RX_PKTLEN instead of dev_info.max_rx_pktlen -- removed the CRC_LEN from

[dpdk-dev] [RFC PATCH v2 3/5] librte_ether: add API's for VF management

2016-09-23 Thread Thomas Monjalon
2016-09-23 09:53, Richardson, Bruce: > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > > 2016-09-23 10:20, Bruce Richardson: > > > On Thu, Sep 22, 2016 at 07:04:37PM +0200, Thomas Monjalon wrote: > > > > 2016-09-15 16:46, Iremonger, Bernard: > > > > > > > > Do we really need to expose

[dpdk-dev] [PATCH] eal: remove single file segments related code

2016-09-23 Thread Yuanhan Liu
Commit c711ccb30987 ("ivshmem: remove library and its EAL integration") removed ivshmem support, but seems David forgot to remove the another piece of code: code for RTE_EAL_SINGLE_FILE_SEGMENTS, which is introduced when ivshmem was firstly added. Now ivshmem was removed and a simple git grep show

[dpdk-dev] [PATCH v2] net/virtio: fix build error with clang

2016-09-23 Thread Yuanhan Liu
On Fri, Sep 23, 2016 at 12:05:14PM +0530, Jerin Jacob wrote: > On Fri, Sep 23, 2016 at 02:15:09PM +0800, Yuanhan Liu wrote: > > Hi Yuanhan, > > Thanks for this patch. > > > Interestingly, clang and gcc has different prototype for _mm_prefetch(). > > For gcc, we have > > > >_mm_prefetch (con

[dpdk-dev] [PATCH] app/test-pipeline: Fix table hash lru initialization

2016-09-23 Thread Dumitrescu, Cristian
> -Original Message- > From: Rao, GuruprasadX > Sent: Friday, September 23, 2016 2:55 PM > To: dev at dpdk.org > Cc: Chokkalingam, SankarX ; Dumitrescu, > Cristian ; Singh, Jasvinder > > Subject: [PATCH] app/test-pipeline: Fix table hash lru initialization > > macro ?APP_METADATA_OFFSET

[dpdk-dev] [PATCH] app/test: add AES GCM performance test to cryptodev

2016-09-23 Thread Yuanhan Liu
On Fri, Sep 23, 2016 at 02:32:57PM +0800, Yuanhan Liu wrote: > On Thu, Sep 22, 2016 at 04:54:57PM +0100, Arek Kusztal wrote: > > This patch adds AES Galois Counter Mode test case for cryptodev > > QAT tests. Test is performed with different buffer sizes, burst > > size of 32 and 128b key. Test vect

[dpdk-dev] [PATCH] app/test: add AES GCM performance test to cryptodev

2016-09-23 Thread Yuanhan Liu
On Thu, Sep 22, 2016 at 04:54:57PM +0100, Arek Kusztal wrote: > This patch adds AES Galois Counter Mode test case for cryptodev > QAT tests. Test is performed with different buffer sizes, burst > size of 32 and 128b key. Test vectors are placed in > app/test/test_cryptodev_perf_vectors.h file. > >

[dpdk-dev] [PATCH v2] net/virtio: fix build error with clang

2016-09-23 Thread Yuanhan Liu
Interestingly, clang and gcc has different prototype for _mm_prefetch(). For gcc, we have _mm_prefetch (const void *__P, enum _mm_hint __I) While for clang, it's #define _mm_prefetch(a, sel) (__builtin_prefetch((void *)(a), 0, (sel))) That how the following error comes with clang: err

[dpdk-dev] [PATCH] net/virtio: fix build error with clang

2016-09-23 Thread Yuanhan Liu
On Tue, Aug 23, 2016 at 03:40:58PM +0800, Yuanhan Liu wrote: > Interestingly, clang and gcc has different prototype for _mm_prefetch(). > For gcc, we have > >_mm_prefetch (const void *__P, enum _mm_hint __I) > > While for clang, it's > >#define _mm_prefetch(a, sel) (__builtin_prefetch((v

[dpdk-dev] [PATCH v2] scripts: add more git log checks

2016-09-23 Thread Ferruh Yigit
Alphabetically sorted items to check and added git log capitalization checks for LRO, NIC and PMD Signed-off-by: Ferruh Yigit --- scripts/check-git-log.sh | 21 - 1 file changed, 12 insertions(+), 9 deletions(-) diff --git a/scripts/check-git-log.sh b/scripts/check-git-log.s

[dpdk-dev] [PATCH v2] vhost: Add indirect descriptors support to the TX path

2016-09-23 Thread Stephen Hemminger
On Fri, 23 Sep 2016 21:31:27 +0300 "Michael S. Tsirkin" wrote: > On Fri, Sep 23, 2016 at 11:24:16AM -0700, Stephen Hemminger wrote: > > On Fri, 23 Sep 2016 09:16:49 +0200 > > Maxime Coquelin wrote: > > > > > Indirect descriptors are usually supported by virtio-net devices, > > > allowing to d

[dpdk-dev] [PATCH v3] vhost: Add indirect descriptors support to the TX path

2016-09-23 Thread Stephen Hemminger
On Fri, 23 Sep 2016 21:22:23 +0300 "Michael S. Tsirkin" wrote: > On Fri, Sep 23, 2016 at 08:16:09PM +0200, Maxime Coquelin wrote: > > > > > > On 09/23/2016 08:06 PM, Michael S. Tsirkin wrote: > > > On Fri, Sep 23, 2016 at 08:02:27PM +0200, Maxime Coquelin wrote: > > > > > > > > > > > > On

[dpdk-dev] [PATCH 0/3] changes for enabling cuckoo hash into table library

2016-09-23 Thread Dumitrescu, Cristian
> -Original Message- > From: Chokkalingam, SankarX > Sent: Thursday, September 22, 2016 11:12 AM > To: dev at dpdk.org > Cc: Dumitrescu, Cristian ; Singh, Jasvinder > ; Chokkalingam, SankarX > ; Rao, GuruprasadX > > Subject: [PATCH 0/3] changes for enabling cuckoo hash into table library

[dpdk-dev] [PATCH 00/12] net/i40e: share code update

2016-09-23 Thread Bruce Richardson
On Thu, Aug 25, 2016 at 04:05:06PM -0400, Zhang Qi wrote: > The patch enable 25G PHY support, > add WoL and proxy configure feature for X722 > and other features for all i40e familiy. > > Zhang Qi (12): > net/i40e/base: add function to clear default VSI > net/i40e/base: fix UDP packet header

[dpdk-dev] [PATCH] net/vhost: Add function to retreive the 'vid' for a given port id

2016-09-23 Thread Yuanhan Liu
On Thu, Sep 22, 2016 at 06:43:55PM +0200, Thomas Monjalon wrote: > > > > > > > There could be a similar need in other PMD. > > > > > > > If we can get an opaque identifier of the device which is not the > > > > > > > port id, > > > > > > > we could call some specific functions of the driver not >

[dpdk-dev] [PATCH] doc: announce ABI changes in filtering support

2016-09-23 Thread Your Name
From: Laura Stroe This patch adds a notice that the ABI for filter types functionality will be enhanced in the 17.02 release with new operation available to manipulate the tunnel filters: replace filter types. Signed-off-by: Laura Stroe --- doc/guides/rel_notes/deprecation.rst | 9 + 1

[dpdk-dev] [PATCH v2 7/7] net/vhost: add an option to enable dequeue zero copy

2016-09-23 Thread Yuanhan Liu
Add an option, dequeue-zero-copy, to enable this feature in vhost-pmd. Signed-off-by: Yuanhan Liu --- drivers/net/vhost/rte_eth_vhost.c | 13 + 1 file changed, 13 insertions(+) diff --git a/drivers/net/vhost/rte_eth_vhost.c b/drivers/net/vhost/rte_eth_vhost.c index 7539cd4..61b3dfc

[dpdk-dev] [PATCH v2 6/7] examples/vhost: add an option to enable dequeue zero copy

2016-09-23 Thread Yuanhan Liu
Add an option, --dequeue-zero-copy, to enable dequeue zero copy. One thing worth noting while using dequeue zero copy is the nb_tx_desc has to be small enough so that the eth driver will hit the mbuf free threshold easily and thus free mbuf more frequently. The reason behind that is, when dequeue

[dpdk-dev] [PATCH v2 5/7] vhost: add a flag to enable dequeue zero copy

2016-09-23 Thread Yuanhan Liu
Dequeue zero copy is disabled by default. Here add a new flag ``RTE_VHOST_USER_DEQUEUE_ZERO_COPY`` to explictily enable it. Signed-off-by: Yuanhan Liu --- v2: - update release log - doc dequeue zero copy in detail --- doc/guides/prog_guide/vhost_lib.rst| 35 +

[dpdk-dev] [PATCH v2 4/7] vhost: add dequeue zero copy

2016-09-23 Thread Yuanhan Liu
The basic idea of dequeue zero copy is, instead of copying data from the desc buf, here we let the mbuf reference the desc buf addr directly. Doing so, however, has one major issue: we can't update the used ring at the end of rte_vhost_dequeue_burst. Because we don't do the copy here, an update of

[dpdk-dev] [PATCH v2 3/7] vhost: introduce last avail idx for dequeue

2016-09-23 Thread Yuanhan Liu
So far, we retrieve both the used ring and avail ring idx by the var last_used_idx; it won't be a problem because the used ring is updated immediately after those avail entries are consumed. But that's not true when dequeue zero copy is enabled, that used ring is updated only when the mbuf is cons

[dpdk-dev] [PATCH v2 2/7] vhost: get guest/host physical address mappings

2016-09-23 Thread Yuanhan Liu
So that we can convert a guest physical address to host physical address, which will be used in later Tx zero copy implementation. MAP_POPULATE is set while mmaping guest memory regions, to make sure the page tables are setup and then rte_mem_virt2phy() could yield proper physical address. Signed

[dpdk-dev] [PATCH v2 1/7] vhost: simplify memory regions handling

2016-09-23 Thread Yuanhan Liu
Due to history reason (that vhost-cuse comes before vhost-user), some fields for maintaining the vhost-user memory mappings (such as mmapped address and size, with those we then can unmap on destroy) are kept in "orig_region_map" struct, a structure that is defined only in vhost-user source file.

[dpdk-dev] [PATCH v2 0/7] vhost: add dequeue zero copy support

2016-09-23 Thread Yuanhan Liu
v2: - renamed "tx zero copy" to "dequeue zero copy", to reduce confusions. - hnadle the case that a desc buf might across 2 host phys pages - use MAP_POPULATE to let kernel populate the page tables - updated release note - doc-ed the limitations for the vm2nic case - merge 2 con

[dpdk-dev] [PATCH 0/6] vhost: add Tx zero copy support

2016-09-23 Thread Yuanhan Liu
On Mon, Aug 29, 2016 at 08:57:52AM +, Xu, Qian Q wrote: > Btw, some good news: if I run a simple dequeue workload (running rxonly in > vhost-pmd and runnin txonly in guest testpmd), it yields ~50% performance > boost for packet size 1518B, but this case is without NIC. > And similar case as

[dpdk-dev] [PATCH v2] net/virtio: fix build error with clang

2016-09-23 Thread Jerin Jacob
On Fri, Sep 23, 2016 at 02:15:09PM +0800, Yuanhan Liu wrote: Hi Yuanhan, Thanks for this patch. > Interestingly, clang and gcc has different prototype for _mm_prefetch(). > For gcc, we have > >_mm_prefetch (const void *__P, enum _mm_hint __I) > > While for clang, it's > >#define _mm_p

[dpdk-dev] [PATCH v3] net/i40e: fix parsing QinQ packets type issue

2016-09-23 Thread Bruce Richardson
On Thu, Sep 22, 2016 at 07:40:20AM +, Wu, Jingjing wrote: > > > > -Original Message- > > From: Xing, Beilei > > Sent: Monday, September 12, 2016 5:42 PM > > To: Wu, Jingjing > > Cc: dev at dpdk.org; Xing, Beilei > > Subject: [PATCH v3] net/i40e: fix parsing QinQ packets type issue > >

[dpdk-dev] [PATCH] net/i40e: fix null pointer dereferences when using VMDQ+RSS

2016-09-23 Thread Bruce Richardson
On Thu, Sep 22, 2016 at 08:20:25AM +, Wu, Jingjing wrote: > > > > -Original Message- > > From: Yigit, Ferruh > > Sent: Wednesday, September 14, 2016 10:00 PM > > To: Rich Lane; dev at dpdk.org > > Cc: Zhang, Helin; Wu, Jingjing > > Subject: Re: [dpdk-dev] [PATCH] net/i40e: fix null po

[dpdk-dev] [PATCH v5 0/2] net/vhost: add pmd xstats support

2016-09-23 Thread Yuanhan Liu
On Thu, Sep 22, 2016 at 04:19:07PM +0800, Zhiyong Yang wrote: > Patch 1 moves all stats counters to a new defined struct vhost_stats, > in order to manage all stats counters in a consistent way. > > Patch 2 adds the pmd xstats support. Applied to dpdk-next-virtio. Thanks. --yliu

[dpdk-dev] [PATCH] eal: check cpu flags at init

2016-09-23 Thread Flavio Leitner
An application might be linked to DPDK but not really use it, so move the cpu flag check to the EAL initialization instead. Signed-off-by: Flavio Leitner --- lib/librte_eal/bsdapp/eal/eal.c | 3 +++ lib/librte_eal/common/eal_common_cpuflags.c | 6 -- lib/librte_eal/linuxapp/eal/e

[dpdk-dev] [RFC PATCH v2 3/5] librte_ether: add API's for VF management

2016-09-23 Thread Thomas Monjalon
2016-09-23 10:20, Bruce Richardson: > On Thu, Sep 22, 2016 at 07:04:37PM +0200, Thomas Monjalon wrote: > > 2016-09-15 16:46, Iremonger, Bernard: > > > > > > Do we really need to expose VF specific functions here? > > > > > > It can be generic(PF/VF) function indexed only through port_id. > > > > >

[dpdk-dev] [RFC PATCH v2 3/5] librte_ether: add API's for VF management

2016-09-23 Thread Bruce Richardson
On Fri, Sep 23, 2016 at 11:36:21AM +0200, Thomas Monjalon wrote: > 2016-09-23 10:20, Bruce Richardson: > > On Thu, Sep 22, 2016 at 07:04:37PM +0200, Thomas Monjalon wrote: > > > 2016-09-15 16:46, Iremonger, Bernard: > > > > > > > Do we really need to expose VF specific functions here? > > > > > > >

[dpdk-dev] [PATCH] mk: fix verbosity zero

2016-09-23 Thread Thomas Monjalon
2016-09-23 10:06, Ferruh Yigit: > On 9/23/2016 12:42 AM, Thomas Monjalon wrote: > > Verbosity is considered enabled when $V is not empty. > > So V=0 and V=1 are equivalent. > > It is fixed by unsetting V when it is 0. > > > > A side effect is to fix kernel module compilation verbosity > > which is

[dpdk-dev] [PATCH v2] app/test: add AES GCM performance test to cryptodev

2016-09-23 Thread Arek Kusztal
This patch adds AES Galois Counter Mode performance test case for cryptodev QAT tests. Test is performed with different buffer sizes, burst size of 32 and 128b key. Test vectors are placed in app/test/test_cryptodev_perf_vectors.h file. This patch depends on the following patches/patchsets: "app/

[dpdk-dev] [PATCH v2] vhost: Add indirect descriptors support to the TX path

2016-09-23 Thread Stephen Hemminger
On Fri, 23 Sep 2016 09:16:49 +0200 Maxime Coquelin wrote: > Indirect descriptors are usually supported by virtio-net devices, > allowing to dispatch a larger number of requests. > > When the virtio device sends a packet using indirect descriptors, > only one slot is used in the ring, even for la

[dpdk-dev] [PATCH] net/mlx5: return RSS hash result in mbuf

2016-09-23 Thread Adrien Mazarguil
On Wed, Sep 14, 2016 at 10:16:05AM +0200, Nelio Laranjeiro wrote: > Signed-off-by: Nelio Laranjeiro Acked-by: Adrien Mazarguil > --- > drivers/net/mlx5/mlx5_rxq.c | 1 + > drivers/net/mlx5/mlx5_rxtx.c | 6 +- > drivers/net/mlx5/mlx5_rxtx.h | 2 ++ > 3 files changed, 8 insertions(+), 1 del

[dpdk-dev] [PATCH] net/mlx5: support Mellanox OFED 3.4

2016-09-23 Thread Adrien Mazarguil
On Wed, Sep 21, 2016 at 03:48:12PM +0200, Nelio Laranjeiro wrote: > Some macros are renamed by Mellanox OFED 3.4. > > Signed-off-by: Nelio Laranjeiro Acked-by: Adrien Mazarguil -- Adrien Mazarguil 6WIND

[dpdk-dev] [PATCH] eal: remove single file segments related code

2016-09-23 Thread Thomas Monjalon
2016-09-23 15:10, Yuanhan Liu: > Commit c711ccb30987 ("ivshmem: remove library and its EAL integration") > removed ivshmem support, but seems David forgot to remove the another > piece of code: code for RTE_EAL_SINGLE_FILE_SEGMENTS, which is introduced > when ivshmem was firstly added. It is not a

[dpdk-dev] [PATCH] pci:fix missing free

2016-09-23 Thread Thomas Monjalon
Hi, 2016-09-23 10:06, zhouyangchao: > Signed-off-by: zhouyangchao Is your first name Yangchao and your surname Zhou? If so, it would be: Signed-off-by: Yangchao Zhou

[dpdk-dev] [PATCH] net/vhost: Add function to retreive the 'vid' for a given port id

2016-09-23 Thread Thomas Monjalon
2016-09-23 12:26, Yuanhan Liu: > On Thu, Sep 22, 2016 at 06:43:55PM +0200, Thomas Monjalon wrote: > > > > > > > > There could be a similar need in other PMD. > > > > > > > > If we can get an opaque identifier of the device which is not > > > > > > > > the port id, > > > > > > > > we could call som

[dpdk-dev] [PATCH] Tools: Fix issue with virtio interface names

2016-09-23 Thread Thomas Monjalon
2016-09-23 15:36, Yuanhan Liu: > On Thu, Sep 22, 2016 at 04:46:52PM +0200, Thomas Monjalon wrote: > > 2016-09-22 10:34, Mussar, Gary: > > > I am new at submitting patches to dpdk.org. This patch has been acked and > > > patchwork claims success on build it: > > > http://www.dpdk.org/dev/patchwork

[dpdk-dev] [PATCH] mk: fix verbosity zero

2016-09-23 Thread Ferruh Yigit
On 9/23/2016 12:42 AM, Thomas Monjalon wrote: > Verbosity is considered enabled when $V is not empty. > So V=0 and V=1 are equivalent. > It is fixed by unsetting V when it is 0. > > A side effect is to fix kernel module compilation verbosity > which is set to 0 when V is empty. > > Reported-by: F

[dpdk-dev] [PATCH v2] net/virtio: fix build error with clang

2016-09-23 Thread Thomas Monjalon
2016-09-23 14:15, Yuanhan Liu: > - _mm_prefetch((const void *)rused, _MM_HINT_T0); > + rte_prefetch0(rused); There are other occurences of _mm_prefetch in other drivers. It could deserve a patch.

[dpdk-dev] [PATCH v3] vhost: Add indirect descriptors support to the TX path

2016-09-23 Thread Maxime Coquelin
Indirect descriptors are usually supported by virtio-net devices, allowing to dispatch a larger number of requests. When the virtio device sends a packet using indirect descriptors, only one slot is used in the ring, even for large packets. The main effect is to improve the 0% packet loss benchma

[dpdk-dev] [PATCH 1/2] i40e: Add packet_type metadata in the i40e vPMD

2016-09-23 Thread Thomas Monjalon
2016-09-23 06:40, Zhang, Qi Z: > > From: Damjan Marion > > > > The ptype is decoded from the rx descriptor and stored in the packet type > > field > > in the mbuf using the same function as the non-vector driver. > > > > Signed-off-by: Damjan Marion > > Signed-off-by: Jeff Shaw > > Acted-by:

[dpdk-dev] [RFC PATCH v2 3/5] librte_ether: add API's for VF management

2016-09-23 Thread Bruce Richardson
On Thu, Sep 22, 2016 at 07:04:37PM +0200, Thomas Monjalon wrote: > 2016-09-15 16:46, Iremonger, Bernard: > > > > > Do we really need to expose VF specific functions here? > > > > > It can be generic(PF/VF) function indexed only through port_id. > > > > > (example: as rte_eth_dev_set_vlan_anti_spoof

[dpdk-dev] [PATCH] eal: remove single file segments related code

2016-09-23 Thread Tan, Jianfeng
> -Original Message- > From: Yuanhan Liu [mailto:yuanhan.liu at linux.intel.com] > Sent: Friday, September 23, 2016 5:15 PM > To: Thomas Monjalon > Cc: dev at dpdk.org; David Marchand; Tan, Jianfeng > Subject: Re: [PATCH] eal: remove single file segments related code > > On Fri, Sep 23,

[dpdk-dev] [PATCH] pci:fix missing free

2016-09-23 Thread zhouyangchao
Signed-off-by: zhouyangchao --- lib/librte_eal/common/eal_common_pci.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/lib/librte_eal/common/eal_common_pci.c b/lib/librte_eal/common/eal_common_pci.c index 7248c38..eb44998 100644 --- a/lib/librte_eal/common/eal_common_pci

[dpdk-dev] [PATCH] mk: fix verbosity zero

2016-09-23 Thread Ferruh Yigit
On 9/23/2016 12:42 AM, Thomas Monjalon wrote: > Verbosity is considered enabled when $V is not empty. > So V=0 and V=1 are equivalent. > It is fixed by unsetting V when it is 0. > > A side effect is to fix kernel module compilation verbosity > which is set to 0 when V is empty. > > Reported-by: F

[dpdk-dev] [PATCH] mk: remove module compilation noise

2016-09-23 Thread Ferruh Yigit
On 9/23/2016 12:35 AM, Thomas Monjalon wrote: > 2016-09-08 13:33, Ferruh Yigit: >> Following log generated by Linux kernel Makefiles: >> (cat /dev/null; echo >> kernel/.../build/lib/librte_eal/linuxapp/igb_uio/igb_uio.ko;) > >> .../build/lib/librte_eal/linuxapp/igb_uio/modules.order >> >> This ha

[dpdk-dev] [RFC PATCH v2 3/5] librte_ether: add API's for VF management

2016-09-23 Thread Richardson, Bruce
> -Original Message- > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > Sent: Friday, September 23, 2016 10:36 AM > To: Richardson, Bruce > Cc: Iremonger, Bernard ; dev at dpdk.org; > Jerin > Jacob ; Shah, Rahul R > ; Lu, Wenzhuo ; azelezniak > > Subject: Re: [dpdk-dev] [RFC

[dpdk-dev] [PATCH v2 1/6] ethdev: add Tx preparation

2016-09-23 Thread Ananyev, Konstantin
Hi Jerin, > > Hi Konstantin, > > > > > Hi Jerin, > > > > > > > > > > Hi Jerin, > > > > > > Hi Konstantin, > > > > > > > > > > > > > > > > > > > > > > > > > > > [...] > > > > > > > > > > > > > > + > > > > > > > > +#ifdef RTE_ETHDEV_TX_PREP > > > > > > > > > > > > > > Sorry for being a bit late on

[dpdk-dev] [PATCH v2] vhost: Add indirect descriptors support to the TX path

2016-09-23 Thread Maxime Coquelin
On 09/23/2016 09:29 AM, Yuanhan Liu wrote: > On Fri, Sep 23, 2016 at 09:16:49AM +0200, Maxime Coquelin wrote: >> +if (vq->desc[desc_indexes[i]].flags & VRING_DESC_F_INDIRECT) { >> +if (unlikely(!(dev->features & >> +(1ULL << >>

[dpdk-dev] [PATCH] net/vhost: Add function to retreive the 'vid' for a given port id

2016-09-23 Thread Loftus, Ciara
> On Fri, Sep 23, 2016 at 10:43:20AM +0200, Thomas Monjalon wrote: > > 2016-09-23 12:26, Yuanhan Liu: > > > On Thu, Sep 22, 2016 at 06:43:55PM +0200, Thomas Monjalon wrote: > > > > > > > > > > There could be a similar need in other PMD. > > > > > > > > > > If we can get an opaque identifier of the

  1   2   >