[dpdk-dev] [PATCH v5 6/6] vhost: optimize cache access

2016-09-08 Thread Zhihong Wang
This patch reorders the code to delay virtio header write to optimize cache access efficiency for cases where the mrg_rxbuf feature is turned on. It reduces CPU pipeline stall cycles significantly. Signed-off-by: Zhihong Wang --- Changes in v3: 1. Remove unnecessary memset which causes frontend

[dpdk-dev] [PATCH v5 5/6] vhost: batch update used ring

2016-09-08 Thread Zhihong Wang
This patch enables batch update of the used ring for better efficiency. Signed-off-by: Zhihong Wang --- Changes in v4: 1. Free shadow used ring in the right place. 2. Add failure check for shadow used ring malloc. lib/librte_vhost/vhost.c | 20 -- lib/librte_vhost/vhost.h

[dpdk-dev] [PATCH v5 4/6] vhost: add desc prefetch

2016-09-08 Thread Zhihong Wang
This patch adds descriptor prefetch to hide cache access latency. Signed-off-by: Zhihong Wang --- lib/librte_vhost/virtio_net.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/lib/librte_vhost/virtio_net.c b/lib/librte_vhost/virtio_net.c index 6f63968..b38f18f 100644 --- a/lib/librte_v

[dpdk-dev] [PATCH v5 3/6] vhost: remove useless volatile

2016-09-08 Thread Zhihong Wang
This patch removes useless volatile attribute to allow compiler optimization. Signed-off-by: Zhihong Wang --- lib/librte_vhost/vhost.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/librte_vhost/vhost.h b/lib/librte_vhost/vhost.h index c2dfc3c..9707dfc 100644 --- a/lib/l

[dpdk-dev] [PATCH v5 2/6] vhost: rewrite enqueue

2016-09-08 Thread Zhihong Wang
This patch implements the vhost logic from scratch into a single function designed for high performance and better maintainability. This is the baseline version of the new code, more optimization will be added in the following patches in this patch set. Signed-off-by: Zhihong Wang --- Changes in

[dpdk-dev] [PATCH v5 1/6] vhost: fix windows vm hang

2016-09-08 Thread Zhihong Wang
This patch fixes a Windows VM compatibility issue in DPDK 16.07 vhost code which causes the guest to hang once any packets are enqueued when mrg_rxbuf is turned on by setting the right id and len in the used ring. As defined in virtio spec 0.95 and 1.0, in each used ring element, id means index of

[dpdk-dev] [PATCH v5 0/6] vhost: optimize enqueue

2016-09-08 Thread Zhihong Wang
This patch set optimizes the vhost enqueue function. It implements the vhost logic from scratch into a single function designed for high performance and good maintainability, and improves CPU efficiency significantly by optimizing cache access, which means: * Higher maximum throughput can be ac

[dpdk-dev] [PATCH] mempool: fix check flags

2016-09-08 Thread Hiroyuki Mikita
fix check flags in case of single producer and single consumer Fixes: 449c49b9 ("mempool: support handler operations") Signed-off-by: Hiroyuki Mikita --- lib/librte_mempool/rte_mempool.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/librte_mempool/rte_mempool.c b/lib/l

[dpdk-dev] [PATCH v6 9/9] table: align rte table hash structs for cache line size

2016-09-08 Thread gowrishankar muthukrishnan
Thanks Cristian and Thomas for your feedback. I have taken your suggestions and sent out v7. Please check if the new patch is fine. Thanks, Gowrishankar On Thursday 08 September 2016 03:10 PM, Dumitrescu, Cristian wrote: > >> -Original Message- >> From: Thomas Monjalon [mailto:thomas.monj

[dpdk-dev] [PATCH v7 9/9] table: fix verification on hash bucket header alignment

2016-09-08 Thread Gowrishankar
From: Gowrishankar Muthukrishnan In powerpc systems, rte table hash structs rte_bucket_4_8, rte_bucket_4_16 and rte_bucket_4_32 are not cache aligned and hence verification on same would fail. Instead of checking alignment on cpu cacheline, it could equally be tested as multiple of 64 bytes. Sig

[dpdk-dev] [PATCH v7 8/9] ip_pipeline: fix lcore mapping for varying SMT threads as in ppc64

2016-09-08 Thread Gowrishankar
From: Gowrishankar Muthukrishnan This patch fixes ip_pipeline panic in app_init_core_map while preparing cpu core map in powerpc with SMT off. cpu_core_map_compute_linux currently prepares core mapping based on file existence in sysfs ie. /sys/devices/system/cpu/cpu/topology/physical_package_id

[dpdk-dev] [PATCH v7 7/9] pipeline: enable pipeline library for ppc64le

2016-09-08 Thread Gowrishankar
From: Gowrishankar Muthukrishnan This patch enables librte_pipeline for ppc64le. Signed-off-by: Gowrishankar Muthukrishnan Acked-by: Chao Zhu --- config/defconfig_ppc_64-power8-linuxapp-gcc | 2 -- 1 file changed, 2 deletions(-) diff --git a/config/defconfig_ppc_64-power8-linuxapp-gcc b/con

[dpdk-dev] [PATCH v7 6/9] port: enable port library for ppc64le

2016-09-08 Thread Gowrishankar
From: Gowrishankar Muthukrishnan This patch enables librte_port in ppc64le. Signed-off-by: Gowrishankar Muthukrishnan Acked-by: Chao Zhu --- config/defconfig_ppc_64-power8-linuxapp-gcc | 1 - 1 file changed, 1 deletion(-) diff --git a/config/defconfig_ppc_64-power8-linuxapp-gcc b/config/def

[dpdk-dev] [PATCH v7 5/9] sched: enable sched library for ppc64le

2016-09-08 Thread Gowrishankar
From: Gowrishankar Muthukrishnan This patch enables librte_sched in ppc64le. Signed-off-by: Gowrishankar Muthukrishnan Acked-by: Chao Zhu --- config/defconfig_ppc_64-power8-linuxapp-gcc | 1 - 1 file changed, 1 deletion(-) diff --git a/config/defconfig_ppc_64-power8-linuxapp-gcc b/config/de

[dpdk-dev] [PATCH v7 4/9] table: enable table library for ppc64le

2016-09-08 Thread Gowrishankar
From: Gowrishankar Muthukrishnan This patch enables librte_table in ppc64le. Signed-off-by: Gowrishankar Muthukrishnan Acked-by: Chao Zhu --- config/defconfig_ppc_64-power8-linuxapp-gcc | 1 - 1 file changed, 1 deletion(-) diff --git a/config/defconfig_ppc_64-power8-linuxapp-gcc b/config/de

[dpdk-dev] [PATCH v7 3/9] l3fwd: add altivec support for em_hash_key

2016-09-08 Thread Gowrishankar
From: Gowrishankar Muthukrishnan This patch adds ppc64le port for em_mask_key function. Signed-off-by: Gowrishankar Muthukrishnan Acked-by: Chao Zhu --- examples/l3fwd/l3fwd_em.c | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/examples/l3fwd/l3fwd_em.c b/examples

[dpdk-dev] [PATCH v7 2/9] acl: add altivec intrinsics for dpdk acl on ppc_64

2016-09-08 Thread Gowrishankar
From: Gowrishankar Muthukrishnan This patch adds port for ACL library in ppc64le. Signed-off-by: Gowrishankar Muthukrishnan Acked-by: Konstantin Ananyev Acked-by: Chao Zhu --- app/test-acl/main.c | 4 + config/defconfig_ppc_64-power8-linuxapp-gcc | 1 - lib/librte

[dpdk-dev] [PATCH v7 1/9] lpm: add altivec intrinsics for dpdk lpm on ppc_64

2016-09-08 Thread Gowrishankar
From: Gowrishankar Muthukrishnan This patch adds ppc64le port for LPM library in DPDK. Signed-off-by: Gowrishankar Muthukrishnan Acked-by: Chao Zhu --- app/test/test_xmmt_ops.h | 16 +++ config/defconfig_ppc_64-power8-linuxapp-gcc| 1 - .../common/include/

[dpdk-dev] [PATCH v7 0/9] enable lpm, acl and other missing libraries in ppc64le

2016-09-08 Thread Gowrishankar
From: Gowrishankar Muthukrishnan This patchset enables LPM, ACL and other few missing libs in ppc64le and also address few patches in related examples (ip_pipeline and l3fwd). Test report: 1. LPM and ACL unit tests passed. Steps: compile test app and run (with any needed params) lpm_aut

[dpdk-dev] [PATCH 2/2] mempool:pktmbuf pool default fallback for mempool ops error

2016-09-08 Thread Hemant Agrawal
In the rte_pktmbuf_pool_create, if the default external mempool is not available, the implementation can default to "ring_mp_mc", which is an software implementation. Signed-off-by: Hemant Agrawal --- lib/librte_mbuf/rte_mbuf.c | 5 + 1 file changed, 5 insertions(+) diff --git a/lib/librte_

[dpdk-dev] [PATCH 1/2] eal/mempool: introduce check for external mempool availability

2016-09-08 Thread Hemant Agrawal
External offloaded mempool may not be available always. This check enables run time verification of the presence of external mempool before the mempool ops are installed. An application built with a specific external mempool may work fine on host. But, may not work on VM, specificaly if non-hw sp

[dpdk-dev] [PATCH 2/3] net/virtio_user: fix wrong sequence of messages

2016-09-08 Thread Yuanhan Liu
On Thu, Sep 08, 2016 at 04:53:22PM +0800, Tan, Jianfeng wrote: > > > On 9/6/2016 4:20 PM, Yuanhan Liu wrote: > >On Tue, Sep 06, 2016 at 03:54:30PM +0800, Tan, Jianfeng wrote: > >>Hi Yuanhan, > >> > >> > >>On 9/6/2016 2:42 PM, Yuanhan Liu wrote: > >>>On Fri, Aug 05, 2016 at 11:36:42AM +, Jianf

[dpdk-dev] [PATCH v2] kni: fix build with kernel 4.8

2016-09-08 Thread Ferruh Yigit
Linux kernel v4.8 removes macro DEFINE_PCI_DEVICE_TABLE Linux: 7e9321599011 ("treewide: remove references to the now unnecessary DEFINE_PCI_DEVICE_TABLE") Replaced macro with its value in kni ethtool drivers. Signed-off-by: Ferruh Yigit --- lib/librte_eal/linuxapp/kni/ethtool/igb/igb_main.c

[dpdk-dev] [PATCH] net/kni: add KNI PMD

2016-09-08 Thread Ferruh Yigit
On 9/8/2016 10:38 AM, Thomas Monjalon wrote: > 2016-09-08 10:25, Bruce Richardson: >> On Thu, Sep 08, 2016 at 09:44:55AM +0200, Thomas Monjalon wrote: >>> 2016-09-06 11:33, Ferruh Yigit: Add KNI PMD which wraps librte_kni for ease of use. KNI PMD can be used as any regular PMD to sen

[dpdk-dev] [PATCH] kni: fix build with kernel 4.8

2016-09-08 Thread Ferruh Yigit
Linux kernel v4.8 removes macro DEFINE_PCI_DEVICE_TABLE Linux: 7e9321599011 ("treewide: remove references to the now unnecessary DEFINE_PCI_DEVICE_TABLE") Added the macro to compatibility headers of the kni ethtool drivers. Signed-off-by: Ferruh Yigit --- lib/librte_eal/linuxapp/kni/ethtool/ig

[dpdk-dev] [PATCH] kni: unregister an unregisterd net_device could cause a kernel crash

2016-09-08 Thread Ferruh Yigit
On 9/8/2016 5:44 PM, Stephen Hemminger wrote: ... > But then again the whole KNI driver fails completely when > running kernel style check. > Yes, it generates lots of warnings. I can fix them (excluding ethtool/*), that wouldn't take much time but how syntax only patches welcomed? Another conc

[dpdk-dev] [PATCH] kni: unregister an unregisterd net_device could cause a kernel crash

2016-09-08 Thread Ferruh Yigit
On 9/9/2016 3:46 AM, zhouyangchao wrote: > Signed-off-by: zhouyangchao > --- > lib/librte_eal/linuxapp/kni/kni_misc.c |4 +++- > 1 files changed, 3 insertions(+), 1 deletions(-) > > diff --git a/lib/librte_eal/linuxapp/kni/kni_misc.c > b/lib/librte_eal/linuxapp/kni/kni_misc.c > index 67e9b7

[dpdk-dev] [PATCH 1/4] libcrypto_pmd: initial implementation of SW crypto device

2016-09-08 Thread Zbigniew Bodek
Hello, I hope this message will get formatted correctly as it is a forwarded e-mail. Please see my question in-line. Kind regards Zbigniew (zbb) > From: Marcin Kerlin > > This code provides the initial implementation of the libcrypto > poll mode driver. All cryptography operations are using Op

[dpdk-dev] [PATCH v7 0/9] enable lpm, acl and other missing libraries in ppc64le

2016-09-08 Thread Dumitrescu, Cristian
> > v7 changes: > - removed enforcing cache alignment for table hash structs and > instead check only for multiples of 64 bytes. > Acked-by: Cristian Dumitrescu

[dpdk-dev] [PATCH 2/3] net/virtio_user: fix wrong sequence of messages

2016-09-08 Thread Tan, Jianfeng
On 9/6/2016 4:20 PM, Yuanhan Liu wrote: > On Tue, Sep 06, 2016 at 03:54:30PM +0800, Tan, Jianfeng wrote: >> Hi Yuanhan, >> >> >> On 9/6/2016 2:42 PM, Yuanhan Liu wrote: >>> On Fri, Aug 05, 2016 at 11:36:42AM +, Jianfeng Tan wrote: When virtio_user is used with VPP's native vhost user, it

[dpdk-dev] [PATCH] mempool: fix check flags

2016-09-08 Thread Olivier Matz
Hi Hiroki, Ferruh, On 09/08/2016 04:44 PM, Ferruh Yigit wrote: > On 9/8/2016 3:28 PM, Hiroyuki Mikita wrote: >> fix check flags in case of single producer and single consumer >> >> Fixes: 449c49b9 ("mempool: support handler operations") >> >> Signed-off-by: Hiroyuki Mikita >> --- >> lib/librte_m

[dpdk-dev] [PATCH 1/6] ethdev: add Tx preparation

2016-09-08 Thread Kulasek, TomaszX
Hi Jerin, > -Original Message- > From: Jerin Jacob [mailto:jerin.jacob at caviumnetworks.com] > Sent: Thursday, September 8, 2016 09:29 > To: Kulasek, TomaszX > Cc: dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH 1/6] ethdev: add Tx preparation > [...] > > +static inline uint16_t > >

[dpdk-dev] [PATCH v2] add mtu set in virtio

2016-09-08 Thread Yuanhan Liu
On Thu, Sep 08, 2016 at 09:50:34AM +0200, Maxime Coquelin wrote: > > > On 09/08/2016 09:30 AM, Yuanhan Liu wrote: > >On Wed, Sep 07, 2016 at 11:16:47AM +0200, Maxime Coquelin wrote: > >> > >> > >>On 09/07/2016 05:25 AM, Yuanhan Liu wrote: > >>>On Tue, Aug 30, 2016 at 09:57:39AM +0200, Maxime Coqu

[dpdk-dev] [PATCH] mempool: fix check flags

2016-09-08 Thread Ferruh Yigit
On 9/8/2016 3:28 PM, Hiroyuki Mikita wrote: > fix check flags in case of single producer and single consumer > > Fixes: 449c49b9 ("mempool: support handler operations") > > Signed-off-by: Hiroyuki Mikita > --- > lib/librte_mempool/rte_mempool.c | 2 +- > 1 file changed, 1 insertion(+), 1 deleti

[dpdk-dev] [PATCH v2] add mtu set in virtio

2016-09-08 Thread Yuanhan Liu
On Wed, Sep 07, 2016 at 11:16:47AM +0200, Maxime Coquelin wrote: > > > On 09/07/2016 05:25 AM, Yuanhan Liu wrote: > >On Tue, Aug 30, 2016 at 09:57:39AM +0200, Maxime Coquelin wrote: > >>Hi Souvik, > >> > >>On 08/30/2016 01:02 AM, souvikdey33 wrote: > >>>Signed-off-by: Souvik Dey > >>> > >>>Fixes

[dpdk-dev] [PATCH v9 22/25] eal/pci: inherit rte_driver by rte_pci_driver

2016-09-08 Thread Ferruh Yigit
On 9/7/2016 3:08 PM, Shreyansh Jain wrote: > Remove the 'name' member from rte_pci_driver and move to generic rte_driver. > > Most of the PMD drivers were initially using DRIVER_REGISTER_PCI(..) > as well as assigning a name to eth_driver.pci_drv.name member. > In this patch, only the original DRI

[dpdk-dev] [PATCH 5/6] vhost: add a flag to enable Tx zero copy

2016-09-08 Thread Yuanhan Liu
On Wed, Sep 07, 2016 at 06:00:36PM +0200, Thomas Monjalon wrote: > 2016-09-06 17:55, Yuanhan Liu: > > On Tue, Sep 06, 2016 at 09:00:14AM +, Xu, Qian Q wrote: > > > Just curious about the naming: vhost USER TX Zero copy. In fact, it's > > > Vhost RX zero-copy > > > For virtio, it's Virtio TX ze

[dpdk-dev] [PATCH v9 01/25] eal: define macro container_of

2016-09-08 Thread Ferruh Yigit
On 9/7/2016 3:07 PM, Shreyansh Jain wrote: > Signed-off-by: Jan Viktorin > Signed-off-by: Shreyansh Jain > --- > lib/librte_eal/common/include/rte_common.h | 21 + > 1 file changed, 21 insertions(+) > > diff --git a/lib/librte_eal/common/include/rte_common.h > b/lib/librte_

[dpdk-dev] [PATCH v4 00/10] Fix build errors related to exported headers

2016-09-08 Thread Adrien Mazarguil
On Tue, Aug 23, 2016 at 06:36:57PM +0200, Thomas Monjalon wrote: > After rebasing the patchset, the compilation of each patch seems good. > But the new checks fail with clang: > rte_memcpy.h:814:2: error: > implicit declaration of function '_mm_alignr_epi8' is invalid > in C99

[dpdk-dev] [PATCH v5 10/10] scripts: check compilation of exported header files

2016-09-08 Thread Adrien Mazarguil
This script checks that header files in a given directory do not miss dependencies when included on their own, do not conflict and accept being compiled with the strictest possible flags. It is too slow at the moment to be automatically executed by test-build.sh and should be run voluntarily (like

[dpdk-dev] [PATCH v5 09/10] lib: hide static functions never defined

2016-09-08 Thread Adrien Mazarguil
Arch-specific functions not defined for all architectures (missing on x86 in this case) and not used anywhere should not expose a prototype. This commit prevents the following error: error: `rte_mov48' declared `static' but never defined Signed-off-by: Adrien Mazarguil --- lib/librte_eal/comm

[dpdk-dev] [PATCH v5 08/10] lib: remove named variadic macros in exported headers

2016-09-08 Thread Adrien Mazarguil
Exported header files used by applications should allow the strictest compiler flags. Language extensions used in many places must be explicitly marked or removed to avoid warnings and compilation failures. Since there is no way to force named variadic macros as extensions, use a a standard __VA_A

[dpdk-dev] [PATCH v5 07/10] lib: work around forward reference to enum types

2016-09-08 Thread Adrien Mazarguil
Exported header files used by applications should allow the strictest compiler flags. Language extensions used in many places must be explicitly marked or removed to avoid warnings and compilation failures. This commit prevents the following errors: error: ISO C forbids forward references to `en

[dpdk-dev] [PATCH v5 06/10] lib: add missing include dependencies

2016-09-08 Thread Adrien Mazarguil
Exported header files for use by applications should be self sufficient and allow out of order inclusion. Moreover, they must include all the system headers they need for types and macros. This commit prevents the following errors: error: `RTE_MAX_LCORE' undeclared here (not in a function) erro

[dpdk-dev] [PATCH v5 05/10] lib: work around unnamed structs/unions

2016-09-08 Thread Adrien Mazarguil
Exported header files used by applications should allow the strictest compiler flags. Language extensions used in many places must be explicitly marked to avoid warnings and compilation failures. Unnamed structs/unions are allowed since C11, however many compiler versions do not use this mode by d

[dpdk-dev] [PATCH v5 04/10] lib: work around nonstandard bit-fields

2016-09-08 Thread Adrien Mazarguil
Exported header files used by applications should allow the strictest compiler flags. Language extensions used in many places must be explicitly marked or removed to avoid warnings and compilation failures. This commit prevents the following errors: error: type of bit-field `[...]' is a GCC exte

[dpdk-dev] [PATCH v5 03/10] lib: use C99 syntax for zero-size arrays

2016-09-08 Thread Adrien Mazarguil
Exported header files used by applications should allow the strictest compiler flags. Language extensions used in many places must be explicitly marked or removed to avoid warnings and compilation failures. The extension keyword is used whenever the C99 syntax cannot do it. This commit prevents t

[dpdk-dev] [PATCH v5 02/10] lib: work around large enum values

2016-09-08 Thread Adrien Mazarguil
Exported header files used by applications should allow the strictest compiler flags. Language extensions used in many places must be explicitly marked or removed to avoid warnings and compilation failures. This commit prevents the following errors: error: ISO C restricts enumerator values to ra

[dpdk-dev] [PATCH v5 01/10] lib: work around braced-groups within expressions

2016-09-08 Thread Adrien Mazarguil
Exported header files used by applications should allow the strictest compiler flags. Language extensions used in many places must be explicitly marked or removed to avoid warnings and compilation failures. This commit prevents the following errors: error: ISO C forbids braced-groups within expr

[dpdk-dev] [PATCH v5 00/10] Fix build errors related to exported headers

2016-09-08 Thread Adrien Mazarguil
DPDK uses GNU C language extensions in most of its code base. This is fine for internal source files whose compilation flags are controlled by DPDK, however user applications that use exported "public" headers may experience compilation failures when enabling strict error/standard checks (-std and

[dpdk-dev] [PATCH v2] ntnic: add PMD driver

2016-09-08 Thread Finn Christensen
> -Original Message- > From: Neil Horman [mailto:nhorman at tuxdriver.com] > Sent: 8. september 2016 15:50 > To: Finn Christensen > Cc: dev at dpdk.org; thomas.monjalon at 6wind.com; > stephen at networkplumber.org > Subject: Re: [dpdk-dev] [PATCH v2] ntnic: add PMD driver > > On Thu, Se

[dpdk-dev] [PATCH] mk: remove module compilation noise

2016-09-08 Thread Ferruh Yigit
Following log generated by Linux kernel Makefiles: (cat /dev/null; echo kernel/.../build/lib/librte_eal/linuxapp/igb_uio/igb_uio.ko;) > .../build/lib/librte_eal/linuxapp/igb_uio/modules.order This happens because $(Q) used for both Linux and DPDK makefiles and DPDK unsets this variable when V=0,

[dpdk-dev] [PATCH 1/6] ethdev: add Tx preparation

2016-09-08 Thread Jerin Jacob
On Fri, Aug 26, 2016 at 06:22:53PM +0200, Tomasz Kulasek wrote: > Added API for `rte_eth_tx_prep` > > uint16_t rte_eth_tx_prep(uint8_t port_id, uint16_t queue_id, > struct rte_mbuf **tx_pkts, uint16_t nb_pkts) > > Added fields to the `struct rte_eth_desc_lim`: > > uint16_t nb_seg_max

[dpdk-dev] [PATCH v9 00/25] Introducing rte_driver/rte_device generalization

2016-09-08 Thread Shreyansh Jain
Hi Stephen, On Thursday 08 September 2016 12:10 AM, Stephen Hemminger wrote: > On Wed, 7 Sep 2016 19:37:52 +0530 > Shreyansh Jain wrote: > >> Based on master (e22856313) >> >> Background: >> === >> >> It includes two different patch-sets floated on ML earlier: >> * Original patch series

[dpdk-dev] [PATCH v8 00/25] Introducing rte_driver/rte_device generalization

2016-09-08 Thread Shreyansh Jain
Hi Ferruh, On Thursday 01 September 2016 06:06 PM, Shreyansh Jain wrote: > Hi Ferruh, > > Sorry for the delay in my reply. > Please find some comments inline. > > On Tuesday 30 August 2016 06:57 PM, Ferruh Yigit wrote: >> On 8/26/2016 2:56 PM, Shreyansh Jain wrote: >>> Based on master (e22856313ff

[dpdk-dev] [PATCH v2 1/1] dpdk_procinfo: check for primary process

2016-09-08 Thread Van Haaren, Harry
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Maryam Tahhan > Sent: Wednesday, September 7, 2016 11:38 AM > To: dev at dpdk.org > Cc: Tahhan, Maryam > Subject: [dpdk-dev] [PATCH v2 1/1] dpdk_procinfo: check for primary process > > Add a check to see if the primary process is running a

[dpdk-dev] [PATCH] net/kni: add KNI PMD

2016-09-08 Thread Thomas Monjalon
2016-09-08 10:25, Bruce Richardson: > On Thu, Sep 08, 2016 at 09:44:55AM +0200, Thomas Monjalon wrote: > > 2016-09-06 11:33, Ferruh Yigit: > > > Add KNI PMD which wraps librte_kni for ease of use. > > > > > > KNI PMD can be used as any regular PMD to send / receive packets to the > > > Linux netwo

[dpdk-dev] [PATCH v6 9/9] table: align rte table hash structs for cache line size

2016-09-08 Thread Thomas Monjalon
2016-08-31 17:29, Dumitrescu, Cristian: > From: Gowrishankar Muthukrishnan > > rte table hash structs rte_bucket_4_8, rte_bucket_4_16 and > > rte_bucket_4_32 have > > to be cache aligned as required by their corresponding hash create functions > > rte_table_hash_create_key8_lru etc. > > Hi Gowrish

[dpdk-dev] [PATCH v8 25/25] eal/pci: Create rte_device list and fallback on its members

2016-09-08 Thread Shreyansh Jain
On Monday 29 August 2016 10:23 PM, Ferruh Yigit wrote: > On 8/26/2016 2:57 PM, Shreyansh Jain wrote: >> Now that rte_device is available, drivers can start using its members (numa, >> name) as well as link themselves into another rte_device list. >> >> As of now no one is using this list, but can b

[dpdk-dev] [PATCH v8 22/25] eal/pci: inherit rte_driver by rte_pci_driver

2016-09-08 Thread Shreyansh Jain
Hi Ferruh, On Monday 29 August 2016 10:19 PM, Ferruh Yigit wrote: > On 8/26/2016 2:57 PM, Shreyansh Jain wrote: >> Remove the 'name' member from rte_pci_driver and move to generic rte_driver. >> >> Most of the PMD drivers were initially using DRIVER_REGISTER_PCI(..) >> as well as assigning a name

[dpdk-dev] [PATCH v8 17/25] drivers: convert PMD_VDEV drivers to use rte_vdev_driver

2016-09-08 Thread Shreyansh Jain
Hi Ferruh, On Monday 29 August 2016 10:27 PM, Ferruh Yigit wrote: > On 8/26/2016 2:56 PM, Shreyansh Jain wrote: >> All PMD_VDEV drivers can now use rte_vdev_driver instead of the >> rte_driver (which is embedded in the rte_vdev_driver). >> >> Signed-off-by: Jan Viktorin >> Signed-off-by: Shreyans

[dpdk-dev] [PATCH v8 10/25] eal/pci: Helpers for device name parsing/update

2016-09-08 Thread Shreyansh Jain
Hi Reshma, On Tuesday 30 August 2016 10:04 PM, Pattan, Reshma wrote: > Hi, > >> +/** >> + * Utility function to write a pci device name, this device name can >> +later be >> + * used to retrieve the corresponding rte_pci_addr using >> +eal_parse_pci_* >> + * BDF helpers. >> + * >> + * @param addr

[dpdk-dev] [PATCH v8 09/25] driver: Remove driver register callbacks for crypto/net

2016-09-08 Thread Shreyansh Jain
On Monday 29 August 2016 10:50 PM, Ferruh Yigit wrote: > On 8/26/2016 2:56 PM, Shreyansh Jain wrote: >> Now that all pdev are pci drivers, we don't need to register crypto and >> ethdev >> drivers through a dedicated channel. >> >> Signed-off-by: David Marchand >> Signed-off-by: Shreyansh Jain >

[dpdk-dev] [PATCH v8 01/25] eal: define macro container_of

2016-09-08 Thread Shreyansh Jain
Hi Ferruh, On Monday 29 August 2016 10:13 PM, Ferruh Yigit wrote: > On 8/26/2016 2:56 PM, Shreyansh Jain wrote: >> Signed-off-by: Jan Viktorin >> Signed-off-by: Shreyansh Jain >> --- >> lib/librte_eal/common/include/rte_common.h | 16 >> 1 file changed, 16 insertions(+) >> >> d

[dpdk-dev] [PATCH v2] ntnic: add PMD driver

2016-09-08 Thread Finn Christensen
This is the Napatech NTNIC Poll Mode Driver (PMD) for DPDK. This patch adds support for Napatech NICs to DPDK. This is the initial implementation. Signed-off-by: Finn Christensen --- v2: * Added information how to build the PMD without NIC Board Support Package * Fixed some formatting is

[dpdk-dev] [PATCH] mempool: fix sp sc mempool bug

2016-09-08 Thread Weiliang Luo
Thanks for your suggestion, I have submitted again with amended commit msg. Thanks, Weiliang On Thu, Sep 8, 2016 at 3:13 AM, Olivier Matz wrote: > Hi Weiliang, > > On 09/08/2016 05:36 AM, Weiliang Luo wrote: > > Signed-off-by: Weiliang Luo > > --- > > lib/librte_mempool/rte_mempool.c | 2 +- >

[dpdk-dev] [PATCH] kni: fix build with kernel 4.8

2016-09-08 Thread Stephen Hemminger
On Thu, 8 Sep 2016 18:54:56 +0100 Ferruh Yigit wrote: > Linux kernel v4.8 removes macro DEFINE_PCI_DEVICE_TABLE > > Linux: 7e9321599011 ("treewide: remove references to the now unnecessary > DEFINE_PCI_DEVICE_TABLE") > > Added the macro to compatibility headers of the kni ethtool drivers. > >

[dpdk-dev] [PATCH] app/testpmd: fix timeout in Rx queue flushing

2016-09-08 Thread James Poole
When testpmd is run, the application would hang on the second time that "start" is executed. This is because the timer limit would get multiplied to an unreachably high number. At the start of flush_fwd_rx_queues(), the timer limit now resets to stop it from getting to this high number. The timer

[dpdk-dev] [PATCH] mempool: fix corruption due to invalid handler

2016-09-08 Thread Weiliang Luo
When using rte_mempool_create(), the mempool handler is selected depending on the flags given by the user: - multi-consumer / multi-producer - multi-consumer / single-producer - single-consumer / multi-producer - single-consumer / single-producer The flags were not properly tested, resulti

[dpdk-dev] [PATCH] net/kni: add KNI PMD

2016-09-08 Thread Bruce Richardson
On Thu, Sep 08, 2016 at 09:44:55AM +0200, Thomas Monjalon wrote: > 2016-09-06 11:33, Ferruh Yigit: > > Add KNI PMD which wraps librte_kni for ease of use. > > > > KNI PMD can be used as any regular PMD to send / receive packets to the > > Linux networking stack. > > Good move! > Why not deprecate

[dpdk-dev] [PATCH] mempool: fix sp sc mempool bug

2016-09-08 Thread Olivier Matz
Hi Weiliang, On 09/08/2016 05:36 AM, Weiliang Luo wrote: > Signed-off-by: Weiliang Luo > --- > lib/librte_mempool/rte_mempool.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/lib/librte_mempool/rte_mempool.c > b/lib/librte_mempool/rte_mempool.c > index 2e28e2e..350d77

[dpdk-dev] QoS: The difference of traffic class between subport and pipe in QoS

2016-09-08 Thread lveny...@1218.com.cn
Hi Cristian, Thanks for your explanation. I haved learned. The traffic class in function of rte_sched_port_pkt_write is both subport's and pipe's . Regards, enyong lvenyong at 1218.com.cn From: Dumitrescu, Cristian Date: 2016-09-07 23:05 To: lvenyong at 1218.com.cn; dev at dpdk.org; users

[dpdk-dev] [PATCH 5/6] vhost: add a flag to enable Tx zero copy

2016-09-08 Thread Thomas Monjalon
2016-09-08 15:21, Yuanhan Liu: > On Wed, Sep 07, 2016 at 06:00:36PM +0200, Thomas Monjalon wrote: > > 2016-09-06 17:55, Yuanhan Liu: > > > On Tue, Sep 06, 2016 at 09:00:14AM +, Xu, Qian Q wrote: > > > > Just curious about the naming: vhost USER TX Zero copy. In fact, it's > > > > Vhost RX zero

[dpdk-dev] [PATCH v2] add mtu set in virtio

2016-09-08 Thread Maxime Coquelin
On 09/08/2016 09:30 AM, Yuanhan Liu wrote: > On Wed, Sep 07, 2016 at 11:16:47AM +0200, Maxime Coquelin wrote: >> >> >> On 09/07/2016 05:25 AM, Yuanhan Liu wrote: >>> On Tue, Aug 30, 2016 at 09:57:39AM +0200, Maxime Coquelin wrote: Hi Souvik, On 08/30/2016 01:02 AM, souvikdey33 wrot

[dpdk-dev] [PATCH v2] ntnic: add PMD driver

2016-09-08 Thread Neil Horman
On Thu, Sep 08, 2016 at 11:14:24AM +, Finn Christensen wrote: > This is the Napatech NTNIC Poll Mode Driver (PMD) for DPDK. > > This patch adds support for Napatech NICs to DPDK. This is the > initial implementation. > > Signed-off-by: Finn Christensen > --- > v2: > * Added information how

[dpdk-dev] [PATCH v9 00/25] Introducing rte_driver/rte_device generalization

2016-09-08 Thread Stephen Hemminger
On Thu, 8 Sep 2016 12:40:08 +0530 Shreyansh Jain wrote: > > Overall I like to see the clean separation. > > Are you sure you removed as much as possible from PCI? > > I am not very sure of what you mean. > > If you are referring to whether all PCI PMDs have been taken care of, I > think they

[dpdk-dev] [PATCH] kni: unregister an unregisterd net_device could cause a kernel crash

2016-09-08 Thread Stephen Hemminger
On Fri, 9 Sep 2016 10:42:16 +0800 zhouyangchao wrote: > Signed-off-by: zhouyangchao > --- > lib/librte_eal/linuxapp/kni/kni_misc.c |3 +++ > 1 files changed, 3 insertions(+), 0 deletions(-) > > diff --git a/lib/librte_eal/linuxapp/kni/kni_misc.c > b/lib/librte_eal/linuxapp/kni/kni_misc.c

[dpdk-dev] [PATCH] net/kni: add KNI PMD

2016-09-08 Thread Thomas Monjalon
2016-09-06 11:33, Ferruh Yigit: > Add KNI PMD which wraps librte_kni for ease of use. > > KNI PMD can be used as any regular PMD to send / receive packets to the > Linux networking stack. Good move! Why not deprecate librte_kni and move all the code in the PMD later?

[dpdk-dev] [PATCH] kni: unregister an unregisterd net_device could cause a kernel crash

2016-09-08 Thread Stephen Hemminger
On Fri, 9 Sep 2016 10:46:07 +0800 zhouyangchao wrote: > Signed-off-by: zhouyangchao > --- > lib/librte_eal/linuxapp/kni/kni_misc.c |4 +++- > 1 files changed, 3 insertions(+), 1 deletions(-) > > diff --git a/lib/librte_eal/linuxapp/kni/kni_misc.c > b/lib/librte_eal/linuxapp/kni/kni_misc.

[dpdk-dev] [PATCH v6 9/9] table: align rte table hash structs for cache line size

2016-09-08 Thread Dumitrescu, Cristian
> -Original Message- > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > Sent: Thursday, September 8, 2016 10:36 AM > To: Gowrishankar Muthukrishnan > Cc: dev at dpdk.org; Dumitrescu, Cristian ; > Chao Zhu ; Richardson, Bruce > ; Ananyev, Konstantin > ; Pradeep > Subject: Re

[dpdk-dev] [PATCH v8 25/25] eal/pci: Create rte_device list and fallback on its members

2016-09-08 Thread Ferruh Yigit
On 9/8/2016 6:55 AM, Shreyansh Jain wrote: > On Monday 29 August 2016 10:23 PM, Ferruh Yigit wrote: >> On 8/26/2016 2:57 PM, Shreyansh Jain wrote: >>> Now that rte_device is available, drivers can start using its members (numa, >>> name) as well as link themselves into another rte_device list. >>>

[dpdk-dev] [PATCH v2 2/2] drivers/i40e: Add FD PCTYPE translation for device x722

2016-09-08 Thread Wu, Jingjing
> -Original Message- > From: Guo, Jia > Sent: Wednesday, September 7, 2016 5:39 PM > To: Zhang, Helin; Wu, Jingjing > Cc: dev at dpdk.org; Guo, Jia > Subject: [PATCH v2 2/2] drivers/i40e: Add FD PCTYPE translation for device > x722 > > In device x722, before the FD filter is programmed,

[dpdk-dev] [PATCH v2 1/2] drivers/i40e: Add new PCTYPEs for device x722

2016-09-08 Thread Wu, Jingjing
> -Original Message- > From: Guo, Jia > Sent: Wednesday, September 7, 2016 5:38 PM > To: Zhang, Helin; Wu, Jingjing > Cc: dev at dpdk.org; Guo, Jia > Subject: [PATCH v2 1/2] drivers/i40e: Add new PCTYPEs for device x722 > > There are 6 new PCTYPEs enabled in the device x722. > The 6 new

[dpdk-dev] [RFC] net/ixgbe: start rxtx after all nic config done.

2016-09-08 Thread Lu, Wenzhuo
Hi Wei, > -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of wang wei > Sent: Tuesday, September 6, 2016 8:05 PM > To: thomas.monjalon at 6wind.com > Cc: dev at dpdk.org > Subject: [dpdk-dev] [RFC] net/ixgbe: start rxtx after all nic config done. > > if start rx

[dpdk-dev] [PATCH v2] net/ixgbe: use queues assigned to PF instad of VF

2016-09-08 Thread Lu, Wenzhuo
Hi, > -Original Message- > From: Alex Zelezniak [mailto:alexz at att.com] > Sent: Tuesday, August 30, 2016 9:23 AM > To: dev at dpdk.org > Cc: Lu, Wenzhuo; Yigit, Ferruh; stephen at networkplumber.org; azelezniak > Subject: [PATCH v2] net/ixgbe: use queues assigned to PF instad of VF > >