Hi Reshma,
On Tuesday 30 August 2016 10:04 PM, Pattan, Reshma wrote:
> Hi,
>
>> +/**
>> + * Utility function to write a pci device name, this device name can
>> +later be
>> + * used to retrieve the corresponding rte_pci_addr using
>> +eal_parse_pci_*
>> + * BDF helpers.
>> + *
>> + * @param addr
>> + * The PCI Bus-Device-Function address
>> + * @param output
>> + * The output buffer string
>> + * @param size
>> + * The output buffer size
>> + * @return
>> + * 0 on success, negative on error.
>> + */
>
> This function doesn't have any return value. Need to change the @return
> description.
>
>> +static inline void
>> +rte_eal_pci_device_name(const struct rte_pci_addr *addr,
>> + char *output, size_t size)
>> +{
>> + RTE_VERIFY(size >= PCI_PRI_STR_SIZE);
>> + RTE_VERIFY(snprintf(output, size, PCI_PRI_FMT,
>> + addr->domain, addr->bus,
>> + addr->devid, addr->function) >= 0); }
>> +
>
> Thanks,
> Reshma
>
Updated the comment in v9 [1].
[1] http://dpdk.org/ml/archives/dev/2016-September/046266.html
-
Shreyansh
