On 9/8/2016 10:38 AM, Thomas Monjalon wrote: > 2016-09-08 10:25, Bruce Richardson: >> On Thu, Sep 08, 2016 at 09:44:55AM +0200, Thomas Monjalon wrote: >>> 2016-09-06 11:33, Ferruh Yigit: >>>> Add KNI PMD which wraps librte_kni for ease of use. >>>> >>>> KNI PMD can be used as any regular PMD to send / receive packets to the >>>> Linux networking stack. >>> >>> Good move! >>> Why not deprecate librte_kni and move all the code in the PMD later? >> >> +1 to this plan. However, I don't think it all needs to be done in one >> patchset, >> though, does it? > > I think the deprecation notice must be in this patchset along with some > __rte_deprecated in front of librte_kni functions. > Then the move of the library in the PMD could be done in the next release. >
Not sure about deprecating librte_kni, this means existing KNI applications needs to be updated. What is the benefit of this effort? Also librte_kni supports more than what PMD does, like PMD doesn't have ethtool support or binding kernel threads, it uses hardcoded mbuf_size... I was thinking PMD as a data only, simplified use case of library. Regards, ferruh
