A new DPDK release candidate is ready for testing:
http://dpdk.org/browse/dpdk/tag/?id=v16.07-rc4
This week was a bit more involved than expected.
Some important bugs have been fixed and require a strong
validation. Please test as much as you can.
The next release candidate should hopeful
2016-07-19 12:17, Yuanhan Liu:
> Add a git tree line for the virtio/vhost section, to make an explicit
> statement that the developers are suggested to make patches based on
> that tree.
>
> Signed-off-by: Yuanhan Liu
Acked-by: Thomas Monjalon
Applied, thanks for your work on next-virtio
2016-07-20 12:38, Thomas Monjalon:
> There are now 2 different sections for drivers/net/ and drivers/crypto/.
> It makes possible to declare some dedicated git trees.
>
> Signed-off-by: Thomas Monjalon
Applied
2016-07-22 18:36, Yuanhan Liu:
> On Fri, Jul 22, 2016 at 10:04:13AM +0200, Thomas Monjalon wrote:
> > 2016-07-22 09:46, Yuanhan Liu:
> > > On Wed, Jul 20, 2016 at 04:24:30PM +0200, Thomas Monjalon wrote:
> > > > The following tools may be installed system-wise.
> > >
> > > Yes, indeed. Following i
On 7/17/16 2:08 PM, "Hiroyuki Mikita" wrote:
>When timer_cb resets another running timer on the same lcore,
>the list of expired timers is chained to the pending-list.
>This commit prevents a running timer from being reset
>by not its own timer_cb.
>
>Signed-off-by: Hiroyuki Mikita
>---
> lib/
On 7/17/16 1:35 PM, "Hiroyuki Mikita" wrote:
>When timer_set_running_state() fails in rte_timer_manage(),
>the failed timer is put back on pending-list.
>In this case, another core tries to reset or stop the timer.
>It does not need to be on pending-list
>
>Signed-off-by: Hiroyuki Mikita
>---
On 7/17/16 10:35 AM, "Hiroyuki Mikita" wrote:
>This commit fixes incorrect pending-list manipulation
>when getting list of expired timers in rte_timer_manage().
>
>When timer_get_prev_entries() sets pending_head on prev,
>the pending-list is broken.
>The next of pending_head always becomes NULL
2016-07-21 02:11, John Daley:
> Signed-off-by: John Daley
Applied, thanks
Inline:
> > This is the intended behavior with this patch. Ports are to be created
> > only by the primary process. This is required for correct operation
> > IMO, because if we allow secondary processes to create ports
> > dynamically (and locally use conflicting port ids) without any
> > synchro
2016-07-17 14:19, John McNamara:
> Update the Sphinx installation instructions in the documentation
> contributors guide to reflect the fact that in the 1.4+ versions
> of Sphinx the ReadTheDocs theme must also be installed. Previously,
> in version 1.3.x, it was installed by default.
>
> Also cha
2016-07-17 14:11, John McNamara:
> Fix warnings raised by Python Sphinx 1.4.5:
>
> guides/sample_app_ug/ip_pipeline.rst:334:
> WARNING: Could not lex literal_block as "ini". Highlighting skipped.
>
> guides/sample_app_ug/l2_forward_real_virtual.rst:467:
> WARNING: Could not lex li
2016-07-19 14:16, John McNamara:
> Fix grammar, spelling and formatting of DPDK 16.07 release notes.
>
> Signed-off-by: John McNamara
Applied, thanks
I love this commit, it means we are close to the release ;)
2016-07-22 10:21, Yulong Pei:
> --- a/doc/guides/rel_notes/release_16_07.rst
> +++ b/doc/guides/rel_notes/release_16_07.rst
> @@ -350,25 +350,120 @@ The libraries prepended with a plus sign were
> incremented in this version.
> Tested Platforms
>
>
> -.. This section should co
Hi folks,
Just to clarify. Thomas is talking about removing just the KNI ethtool
(i.e. lib/librte_eal/linuxapp/kni/ethtool/*). The major functionality
of those 45K lines of code is to get the same MAC address on the KNI
interface and the underlying igb/ixgbe NIC.
At the moment the rest of the DPDK
2016-07-01 15:10, Bernard Iremonger:
> add release note for live migration of a VM with SRIOV VF
>
> Signed-off-by: Bernard Iremonger
Applied, thanks
2016-07-18 15:30, Bernard Iremonger:
> This patchset describes the procedure to Live migrate a VM with
> Virtio PMD's with the vhost_user sample application (vhost-switch)
> running on the host.
Applied, thanks
On 7/22/2016 5:12 PM, Stephen Hemminger wrote:
> On Fri, 22 Jul 2016 11:34:10 -0400
> Sinan Kaya wrote:
>
>> The current code is enumerating devices based on bus, device and function
>> pairs. This does not work well for architectures with multiple PCI
>> segments/domains. Multiple PCI devices wi
2016-07-19 16:09, Bernard Iremonger:
> This patch set describes the procedure to Live migrate
> a VM with Virtio and VF PMD's using the bonding PMD.
Applied, thanks
On Fri, Jul 22, 2016 at 10:04:13AM +0200, Thomas Monjalon wrote:
> 2016-07-22 09:46, Yuanhan Liu:
> > On Wed, Jul 20, 2016 at 04:24:30PM +0200, Thomas Monjalon wrote:
> > > The following tools may be installed system-wise.
> >
> > Yes, indeed. Following is an example from dpdk package shipped in
>
2016-07-22 15:02, Pablo de Lara:
> i40e driver was removing elements when iterating tailq lists
> with TAILQ_FOREACH macro, which is not safe.
> Instead, TAILQ_FOREACH_SAFE macro is used when removing/freeing
> these elements, which is defined in DPDK if it is not already
> defined (in FreeBSD).
2016-07-22 17:02, Sergio Gonzalez Monroy:
> On 22/07/2016 16:24, Thomas Monjalon wrote:
> > 2016-07-22 16:33, Michal Jastrzebski:
> >> v2:
> >> -moved close(fd) just after read.
> >> -when read() from fd we expect 8 bytes, so PFN_MASK_SIZE macro
> >> was introduced instead sizeof(uint64_t).
> >> -r
2016-07-22 17:06, Bruce Richardson:
> Improve the wording of some text in the "new features" section of
> the release notes.
I think these patches conflict with this one:
http://dpdk.org/dev/patchwork/patch/14898/
2016-07-22 17:01, Sergio Gonzalez Monroy:
> Removing/freeing elements elements within a STAILQ_FOREACH loop
> is not safe. FreeBSD defines STAILQ_FOREACH_SAFE macro, which permits
> these operations safely.
>
> This patch defines this macro for Linux systems, where it is not defined.
[...]
> +#ifn
2016-07-21 14:10, Mark Kavanagh:
> - Fix vhost setup flags
> - Add minor edits to improve readability and consistency
>
> Signed-off-by: Mark Kavanagh
Acked-by: John McNamara
Applied, thanks
2016-07-20 09:08, Yuanhan Liu:
> On Tue, Jul 19, 2016 at 01:57:11PM +, Mcnamara, John wrote:
> > > - Note: the "reconnect" feature requires **QEMU v2.7** (or above).
> > > + .. Note::
> > > + * The "reconnect" feature requires **QEMU v2.7** (or above).
> > > +
> > > + * The vhost supp
> > Signed-off-by: Shreyansh Jain
>
> Acked-by: John McNamara
Applied, thanks
> > icc version 16.0.2, compile error:
> >
> > == host
> > CC host.o
> > /root/development/dpdk/examples/l2fwd-ivshmem/host/host.c(157):
> > error #3656: variable "total_vm_packets_dropped"
> > may be used before its value is set
> > total_vm_packets_dropped += ctrl->vm_port
2016-07-22 15:19, Ferruh Yigit:
> On 7/22/2016 2:44 PM, Reshma Pattan wrote:
> > Function create_mp_ring_vdev() for failure cases exits without
> > freeing the created rte rings, because of this pdump tool cannot be
> > rerun successfully. Added rte ring cleanup logic upon failures.
> >
> > Fixes:
2016-07-22 16:33, Michal Jastrzebski:
> v2:
> -moved close(fd) just after read.
> -when read() from fd we expect 8 bytes, so PFN_MASK_SIZE macro
> was introduced instead sizeof(uint64_t).
> -removed errno print when read returns less than 8 bytes
Looks better.
Note: this changelog should be below
On Fri, Jul 22, 2016 at 02:15:39PM +, De Lara Guarch, Pablo wrote:
>
>
> > -Original Message-
> > From: Yigit, Ferruh
> > Sent: Friday, July 22, 2016 2:19 PM
> > To: De Lara Guarch, Pablo; dev at dpdk.org; Mcnamara, John
> > Subject: Re: [dpdk-dev] [PATCH] doc: announce driver name ch
Improve the wording of some text in the "new features" section of
the release notes.
Signed-off-by: Bruce Richardson
---
doc/guides/rel_notes/release_16_07.rst | 50 +++---
1 file changed, 28 insertions(+), 22 deletions(-)
diff --git a/doc/guides/rel_notes/release_16
The description of the new feature for external caches on mempools was
indented too much, putting it out of alignment with the other items in the
new features list in the pdf output. Correct this by removing the extra
spaces.
Fixes: 4b5062755aa7 ("mempool: allow user-owned cache")
Signed-off-by:
2016-07-22 14:47, Azarewicz, PiotrX T:
> > > I was trying rc3 + fix and latest (today) dpdk version. The same fail
> > message:
> > >
> > > /x86_64-native-linuxapp-gcc/lib/librte_eal.a(eal_timer.o): In function
> > `get_tsc_freq':
> > > eal_timer.c:(.text+0x128): undefined reference to `clock_getti
On 22/07/2016 16:24, Thomas Monjalon wrote:
> 2016-07-22 16:33, Michal Jastrzebski:
>> v2:
>> -moved close(fd) just after read.
>> -when read() from fd we expect 8 bytes, so PFN_MASK_SIZE macro
>> was introduced instead sizeof(uint64_t).
>> -removed errno print when read returns less than 8 bytes
>
Potentially user provided function could remove/free tailq elements.
Doing so within a TAILQ_FOREACH loop is not safe.
Use _SAFE versions of _FOREACH macros.
Signed-off-by: Sergio Gonzalez Monroy
---
lib/librte_mempool/rte_mempool.c | 10 ++
1 file changed, 6 insertions(+), 4 deletions(
Removing/freeing elements elements within a STAILQ_FOREACH loop
is not safe. FreeBSD defines STAILQ_FOREACH_SAFE macro, which permits
these operations safely.
This patch defines this macro for Linux systems, where it is not defined.
Signed-off-by: Sergio Gonzalez Monroy
---
NOTE: This patch is
2016-07-22 15:02, Pablo de Lara:
> i40e driver was removing elements when iterating tailq lists
> with TAILQ_FOREACH macro, which is not safe.
> Instead, TAILQ_FOREACH_SAFE macro is used when removing/freeing
> these elements.
Pablo,
Maybe we should add a note to explain that the bug of freeing
wh
v2:
-moved close(fd) just after read.
-when read() from fd we expect 8 bytes, so PFN_MASK_SIZE macro
was introduced instead sizeof(uint64_t).
-removed errno print when read returns less than 8 bytes
In rte_mem_virt2phy: Value returned from a function and indicating the
number of bytes was ignored
HI Adrien,
Thank you for your effort and considering the inputs and comments.
The design looks fine for me now.
Regards
_Sugesh
> -Original Message-
> From: Adrien Mazarguil [mailto:adrien.mazarguil at 6wind.com]
> Sent: Thursday, July 21, 2016 2:37 PM
> To: Chandran, Sugesh
> Cc: dev
> -Original Message-
> From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com]
> Sent: Friday, July 22, 2016 5:25 PM
> To: Jastrzebski, MichalX K
> Cc: Richardson, Bruce ; dev at dpdk.org;
> Kobylinski, MichalX ; Gonzalez Monroy,
> Sergio ; david.marchand at 6wind.com
> Subject: Re: [P
2016-07-22 14:15, De Lara Guarch, Pablo:
> From: Yigit, Ferruh
> > For physical net devices, driver name is same as folder name (mlnx5,
> > ixgbe ...)
> >
> > For virtual net devices, driver name is folder name with "eth_" prefix
> > (eth_pcap, eth_ring)
> >
> > Driver names for net devices looks
2016-07-22 14:07, Azarewicz, PiotrX T:
> > > > > Tested-by: Yongjie Gu
> > > >
> > > > Applied
> > >
> > > OS: UB1204
> > > GCC: 4.6.4
> > > Kernel: 3.13.0-45
> > > glibc 2.15
> > >
> > > x86_64-native-linuxapp-gcc: FAIL
> >
> > Please don't be a bot and explain us the error you see.
>
> I was t
2016-07-22 13:38, Azarewicz, PiotrX T:
> > > Tested-by: Yongjie Gu
> >
> > Applied
>
> OS: UB1204
> GCC: 4.6.4
> Kernel: 3.13.0-45
> glibc 2.15
>
> x86_64-native-linuxapp-gcc: FAIL
Please don't be a bot and explain us the error you see.
On Fri, 22 Jul 2016 14:19:29 -0700
Prabahar Radhakrishnan wrote:
> Hi,
>I was running a dpdk application with e1000 driver and I am facing a
> rare driver lockup condition. Under this condition, what I am seeing is
> that the Receive side locks up. The transmit side is fine. When I exe
On 7/22/2016 2:44 PM, Reshma Pattan wrote:
> Function create_mp_ring_vdev() for failure cases exits without
> freeing the created rte rings, because of this pdump tool cannot be
> rerun successfully. Added rte ring cleanup logic upon failures.
>
> Fixes: caa7028276b8 ("app/pdump: add tool for pack
icc version 16.0.2, compile error:
== host
CC host.o
/root/development/dpdk/examples/l2fwd-ivshmem/host/host.c(157):
error #3656: variable "total_vm_packets_dropped"
may be used before its value is set
total_vm_packets_dropped += ctrl->vm_ports[portid].stats.dropped;
i40e driver was removing elements when iterating tailq lists
with TAILQ_FOREACH macro, which is not safe.
Instead, TAILQ_FOREACH_SAFE macro is used when removing/freeing
these elements.
Fixes: 4861cde46116 ("i40e: new poll mode driver")
Fixes: 440499cf5376 ("net/i40e: support floating VEB")
Signe
Removing/freeing elements elements within a TAILQ_FOREACH loop is not safe.
FreeBSD defines TAILQ_FOREACH_SAFE macro, which permits
these operations safely.
This patch defines this macro for Linux systems, where it is not defined.
Signed-off-by: Pablo de Lara
---
lib/librte_eal/common/include/rt
i40e driver was removing elements when iterating tailq lists
with TAILQ_FOREACH macro, which is not safe.
Instead, TAILQ_FOREACH_SAFE macro is used when removing/freeing
these elements, which is defined in DPDK if it is not already
defined (in FreeBSD).
Changes in v2:
- Modified second commit tit
Hi Pablo,
On Fri, Jul 22, 2016 at 12:37:22PM +, De Lara Guarch, Pablo wrote:
> Hi,
>
> > -Original Message-
> > From: De Lara Guarch, Pablo
> > Sent: Saturday, July 09, 2016 5:57 PM
> > To: dev at dpdk.org
> > Cc: Mcnamara, John; De Lara Guarch, Pablo
> > Subject: [PATCH] doc: announc
> -Original Message-
> From: Yigit, Ferruh
> Sent: Friday, July 22, 2016 3:14 PM
> To: dev at dpdk.org
> Cc: Burakov, Anatoly
> Subject: [PATCH] examples/l2fwd-ivshmem: fix icc compile error
>
> icc version 16.0.2, compile error:
>
> == host
> CC host.o
> /root/development/dpdk/example
> > > > > > Tested-by: Yongjie Gu
> > > > >
> > > > > Applied
> > > >
> > > > OS: UB1204
> > > > GCC: 4.6.4
> > > > Kernel: 3.13.0-45
> > > > glibc 2.15
> > > >
> > > > x86_64-native-linuxapp-gcc: FAIL
> > >
> > > Please don't be a bot and explain us the error you see.
> >
> > I was trying rc3 + f
Function create_mp_ring_vdev() for failure cases exits without
freeing the created rte rings, because of this pdump tool cannot be
rerun successfully. Added rte ring cleanup logic upon failures.
Fixes: caa7028276b8 ("app/pdump: add tool for packet capturing")
Signed-off-by: Reshma Pattan
---
ap
> -Original Message-
> From: Gonzalez Monroy, Sergio
> Sent: Thursday, July 21, 2016 4:37 PM
> To: Jastrzebski, MichalX K ; Richardson,
> Bruce
> Cc: dev at dpdk.org; Kobylinski, MichalX ;
> david.marchand at 6wind.com
> Subject: Re: [PATCH] eal: fix check number of bytes from read functio
On Fri, Jul 22, 2016 at 2:31 PM, Take Ceara wrote:
> Hi Beilei,
>
> On Fri, Jul 22, 2016 at 11:04 AM, Xing, Beilei
> wrote:
>> Hi Ceara,
>>
>>> -Original Message-
>>> From: Take Ceara [mailto:dumitru.ceara at gmail.com]
>>> Sent: Thursday, July 21, 2016 6:58 PM
>>> To: Xing, Beilei
>>>
Hi Beilei,
On Fri, Jul 22, 2016 at 11:04 AM, Xing, Beilei wrote:
> Hi Ceara,
>
>> -Original Message-
>> From: Take Ceara [mailto:dumitru.ceara at gmail.com]
>> Sent: Thursday, July 21, 2016 6:58 PM
>> To: Xing, Beilei
>> Cc: Zhang, Helin ; Wu, Jingjing
>> ; dev at dpdk.org
>> Subject: Re
Hi,
I was running a dpdk application with e1000 driver and I am facing a
rare driver lockup condition. Under this condition, what I am seeing is
that the Receive side locks up. The transmit side is fine. When I execute
"rte_eth_dev_stop()/rte_eth_dev_start()" from within the VM, the dpdk
On 7/22/2016 1:54 PM, Adrien Mazarguil wrote:
> Hi Pablo,
>
> On Fri, Jul 22, 2016 at 12:37:22PM +, De Lara Guarch, Pablo wrote:
>> Hi,
>>
>>> -Original Message-
>>> From: De Lara Guarch, Pablo
>>> Sent: Saturday, July 09, 2016 5:57 PM
>>> To: dev at dpdk.org
>>> Cc: Mcnamara, John; De
> -Original Message-
> From: Yigit, Ferruh
> Sent: Friday, July 22, 2016 2:19 PM
> To: De Lara Guarch, Pablo; dev at dpdk.org; Mcnamara, John
> Subject: Re: [dpdk-dev] [PATCH] doc: announce driver name changes
>
> On 7/22/2016 1:54 PM, Adrien Mazarguil wrote:
> > Hi Pablo,
> >
> > On Fri
On Fri, 22 Jul 2016 11:34:10 -0400
Sinan Kaya wrote:
> The current code is enumerating devices based on bus, device and function
> pairs. This does not work well for architectures with multiple PCI
> segments/domains. Multiple PCI devices will have the same BDF value but
> different segment numbe
i40e driver was removing elements when iterating tailq lists
with TAILQ_FOREACH macro, which is not safe.
Instead, TAILQ_FOREACH_SAFE macro is used when removing/freeing
these elements.
Fixes: 4861cde46116 ("i40e: new poll mode driver")
Fixes: 440499cf5376 ("net/i40e: support floating VEB")
Signe
Removing/freeing elements elements within a TAILQ_FOREACH loop is not safe.
FreeBSD defines TAILQ_FOREACH_SAFE macro, which permits
these operations safely.
This patch defines this macro for Linux systems, where it is not defined.
Signed-off-by: Pablo de Lara
---
lib/librte_eal/common/include/rt
i40e driver was removing elements when iterating tailq lists
with TAILQ_FOREACH macro, which is not safe.
Instead, TAILQ_FOREACH_SAFE macro is used when removing/freeing
these elements, which is defined in DPDK if it is not already
defined (in FreeBSD).
Pablo de Lara (2):
eal: add tailq safe it
> > > > Tested-by: Yongjie Gu
> > >
> > > Applied
> >
> > OS: UB1204
> > GCC: 4.6.4
> > Kernel: 3.13.0-45
> > glibc 2.15
> >
> > x86_64-native-linuxapp-gcc: FAIL
>
> Please don't be a bot and explain us the error you see.
I was trying rc3 + fix and latest (today) dpdk version. The same fail mess
> > Tested-by: Yongjie Gu
>
> Applied
OS: UB1204
GCC: 4.6.4
Kernel: 3.13.0-45
glibc 2.15
x86_64-native-linuxapp-gcc: FAIL
2016-07-20 15:02, Neil Horman:
> John Mcnamara and I were discussing enhacing the validate_abi script to build
> the dpdk tree faster with multiple jobs. Theres no reason not to do it, so
> this
> implements that requirement. It uses a MAKE_JOBS variable that can be set by
> the user to limit th
2016-07-22 10:20, De Lara Guarch, Pablo:
> From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com]
> > It seems cryptodev_start() calls empty driver functions,
> > and is not called in the example applications.
> >
> > This a v2 of patches from Hemant Agrawal and Akhil Goyal.
> > There are som
Hi,
> -Original Message-
> From: De Lara Guarch, Pablo
> Sent: Saturday, July 09, 2016 5:57 PM
> To: dev at dpdk.org
> Cc: Mcnamara, John; De Lara Guarch, Pablo
> Subject: [PATCH] doc: announce driver name changes
>
> Driver names for all the supported devices in DPDK do not have
> a nami
On 21/07/16 19:58, bynes adam wrote:
> On Wed, Jul 20, 2016 at 06:11:16PM +0100, Zoltan Kiss wrote:
> Hi, Kiss
>> Using weak symbols have a few issues with static linking:
>>
>> - normally the linker searches the .o files already linked, if your weak
>> one is there, it won't check if there is
2016-07-18 11:23, Chokkalingam, SankarX:
> In TM, the read size should be lesser than the write size to improve
> performance.
> This enables the TM ports to push maximum packets to the output port.
>
> This fix changes the burst_read value from 64 to 24 in default_tm_params.
>
> Signed-off-by:
2016-07-18 11:15, Chokkalingam, SankarX:
> IP Pipeline application with the configuration for Flow Classification IPV6
> did not instantiate.
> Parse error in section "PIPELINE1": entry "dma_src_mask" too long
>
> The dma_src_mask check in pipeline_passthrough_parse_args() is wrong.
>
> This fix
2016-07-18 10:32, Chokkalingam, SankarX:
> Error while executing action flow bulk command
> pipeline> p 1 action flow bulk ./config/action.txt
> Command "action flow bulk" failed
> pipeline>
>
> The flow action entries are added successfully.
> But the return value is not computed correctly.
> Due
2016-07-18 12:39, Mcnamara, John:
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Pablo de Lara
> > pthread_detach() function was returning 0 even when not calling
> > lthread_detach(), due to missing braces in conditional (extra indentation
> > was applied, giving a hint this is the corr
2016-07-21 09:34, Yuanhan Liu:
> On Thu, Jul 21, 2016 at 12:42:45AM +, Jianfeng Tan wrote:
> > We find significant perfermance drop introduced by below commit,
> > when vhost example is started with --mergeable 0 and inside vm,
> > kernel virtio-net driver is used to do ip based forwarding.
> >
2016-07-21 16:24, Xiao Wang:
> Sometimes app just wants to update the RSS hash function and no RSS key
> update is needed, but fm10k pmd will return EINVAL for this case.
>
> If the rss_key is NULL, we don't need to check the rss_key_len.
>
> Fixes: 57033cdf8fdc ("fm10k: add PF RSS")
>
> Reporte
> GCC 4.5.x does not handle well initializing anonymous union and/or
> structs.
>
> To make the compiler happy we name those anonymous union/struct.
>
> Fixes: 906257e965b7 ("examples/ipsec-secgw: support IPv6")
>
> Signed-off-by: Sergio Gonzalez Monroy
Applied, thanks
From: Hemant Agrawal
The usual device sequence is configure, queue setup and start.
Crypto device should be started before use.
Signed-off-by: Akhil Goyal
Signed-off-by: Hemant Agrawal
Signed-off-by: Thomas Monjalon
---
examples/ipsec-secgw/ipsec-secgw.c | 4
1 file changed, 4 insertion
From: Hemant Agrawal
The usual device sequence is configure, queue setup and start.
Crypto device should be started before use.
Signed-off-by: Akhil Goyal
Signed-off-by: Hemant Agrawal
Signed-off-by: Thomas Monjalon
---
examples/l2fwd-crypto/main.c | 7 +++
1 file changed, 7 insertions(+
It seems cryptodev_start() calls empty driver functions,
and is not called in the example applications.
This a v2 of patches from Hemant Agrawal and Akhil Goyal.
There are some improvements to make error messages more
consistent with existing ones and keep the existing error return.
Are they impo
The current code is enumerating devices based on bus, device and function
pairs. This does not work well for architectures with multiple PCI
segments/domains. Multiple PCI devices will have the same BDF value but
different segment numbers (01:01:01.0 and 02:01:01.0) for instance.
Adding segment nu
2016-07-18 14:21, Pablo de Lara:
> When parsing the parameters for virtual device initialization,
> rte_kvargs structure was being freed only if there was an error,
> not when parsing was successful.
>
> Coverity issue: 124568
>
> Fixes: f3e764fa2fb7 ("cryptodev: uninline parameter parsing")
>
>
2016-07-22 10:33, Yuanhan Liu:
> On Fri, Jul 22, 2016 at 02:24:47AM +, Jianfeng Tan wrote:
> > The commit cb6696d22023 ("drivers: update registration macro usage")
> > changes the name from virtio-user to virtio_user, because hyphen
> > cannot be used in a C symbol name. However, this commit do
On Fri, Jul 22, 2016 at 02:24:47AM +, Jianfeng Tan wrote:
> The commit cb6696d22023 ("drivers: update registration macro usage")
> changes the name from virtio-user to virtio_user, because hyphen
> cannot be used in a C symbol name. However, this commit does not
> update the strings in docs and
2016-07-20 13:31, Pablo de Lara:
> Signed-off-by: Pablo de Lara
Applied, thanks
2016-07-22 08:23, Chen, Jing D:
> From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com]
> > 2016-07-21 09:35, Wang, Xiao W:
> > > From: Chen, Jing D
> > > > > --- a/drivers/net/fm10k/fm10k_ethdev.c
> > > > > +++ b/drivers/net/fm10k/fm10k_ethdev.c
> > > > > @@ -2159,8 +2159,8 @@ fm10k_rss_hash
Hi Konstantin,
On 07/21/2016 12:51 PM, Ananyev, Konstantin wrote:
> Hi Olivier,
>
>>
>> This function can be used to calculate the checksum of data embedded in
>> mbuf, that can be composed of several segments.
>>
>> This function will be used by the virtio pmd in next commits to calculate
>> t
> > Flow Bifurcation is a mechanism which uses features of advanced Ethernet
> > devices to split traffic between queues. It provides the capability to let
> > the kernel driver and DPDK driver co-exist and take advantage of both.
> >
> > It is achieved by using SR-IOV and the NIC's advanced filte
2016-07-21 09:35, Wang, Xiao W:
> From: Chen, Jing D
> > > --- a/drivers/net/fm10k/fm10k_ethdev.c
> > > +++ b/drivers/net/fm10k/fm10k_ethdev.c
> > > @@ -2159,8 +2159,8 @@ fm10k_rss_hash_update(struct rte_eth_dev *dev,
> > >
> > > PMD_INIT_FUNC_TRACE();
> > >
> > > - if (rss_conf->rss_key_len < FM
Add new section on tested platforms and nics and OSes to the release notes.
Signed-off-by: Yulong Pei
---
doc/guides/rel_notes/release_16_07.rst | 117 +
1 file changed, 106 insertions(+), 11 deletions(-)
diff --git a/doc/guides/rel_notes/release_16_07.rst
b/doc
> -Original Message-
> From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com]
> Sent: Friday, July 22, 2016 10:44 AM
> To: Akhil Goyal; Hemant Agrawal; Doherty, Declan; De Lara Guarch, Pablo
> Cc: dev at dpdk.org
> Subject: [PATCH v2 0/2] cryptodev_start fixes
>
> It seems cryptodev
2016-07-22 09:46, Yuanhan Liu:
> On Wed, Jul 20, 2016 at 04:24:30PM +0200, Thomas Monjalon wrote:
> > The following tools may be installed system-wise.
>
> Yes, indeed. Following is an example from dpdk package shipped in
> ubutun 16.04:
>
> dpdk: /etc/dpdk/dpdk.conf
> dpdk: /etc/dpdk/int
Hi Stephen,
On 07/21/2016 11:22 PM, Stephen Hemminger wrote:
> On Thu, 21 Jul 2016 10:08:23 +0200
> Olivier Matz wrote:
>
>> +/**
>> + * Deprecated.
>> + * Checking this flag alone is deprecated: check the 2 bits of
>> + * PKT_RX_L4_CKSUM_MASK.
>> + * This flag was set when the L4 checksum of a
On 07/21/2016 11:15 PM, Stephen Hemminger wrote:
> On Thu, 21 Jul 2016 10:08:20 +0200
> Olivier Matz wrote:
>
>> +dev_info->max_rx_queues = (uint16_t)
>> +((VIRTIO_MAX_RX_QUEUES < hw->max_queue_pairs) ?
>> +VIRTIO_MAX_RX_QUEUES : hw->max_queue_pairs);
>> +
On Wed, Jul 20, 2016 at 04:24:30PM +0200, Thomas Monjalon wrote:
> The following tools may be installed system-wise.
Yes, indeed. Following is an example from dpdk package shipped in
ubutun 16.04:
dpdk: /etc/dpdk/dpdk.conf
dpdk: /etc/dpdk/interfaces
dpdk: /etc/init.d/dpdk
dpdk: /l
Hi, Thomas,
> -Original Message-
> From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com]
> Sent: Friday, July 22, 2016 4:29 PM
> To: Chen, Jing D
> Cc: dev at dpdk.org; Wang, Xiao W ; Lin, Xueqin
>
> Subject: Re: [dpdk-dev] [PATCH] net/fm10k: fix RSS hash config
>
> 2016-07-22 08
Hi Ceara,
> -Original Message-
> From: Take Ceara [mailto:dumitru.ceara at gmail.com]
> Sent: Thursday, July 21, 2016 6:58 PM
> To: Xing, Beilei
> Cc: Zhang, Helin ; Wu, Jingjing
> ; dev at dpdk.org
> Subject: Re: [dpdk-dev] [dpdk-users] RSS Hash not working for XL710/X710
> NICs for some
Hi, Thomas,
> -Original Message-
> From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com]
> Sent: Friday, July 22, 2016 4:22 PM
> To: Chen, Jing D
> Cc: dev at dpdk.org; Wang, Xiao W ; Lin, Xueqin
>
> Subject: Re: [dpdk-dev] [PATCH] net/fm10k: fix RSS hash config
>
> 2016-07-21 09:
The commit cb6696d22023 ("drivers: update registration macro usage")
changes the name from virtio-user to virtio_user, because hyphen
cannot be used in a C symbol name. However, this commit does not
update the strings in docs and source code, which could lead to
failure to start this device as per
+ dpdk.org mailing list. I also thought the patch to check port CRC strip then
make the port fail to start is not proper.
For testpmd, we can use -crc-strip, but for l3fwd, we may need change code to
enable crc-strip, and for all application, we need change the code; this is not
acceptable.
User
Hi Adrien,
> -Original Message-
> From: Adrien Mazarguil [mailto:adrien.mazarguil at 6wind.com]
> Sent: Thursday, July 21, 2016 8:48 PM
> To: Lu, Wenzhuo
> Cc: dev at dpdk.org; Thomas Monjalon; Zhang, Helin; Wu, Jingjing; Rasesh Mody;
> Ajit Khaparde; Rahul Lakkireddy; Jan Medala; John Da
1 - 100 of 116 matches
Mail list logo
