2016-07-22 18:36, Yuanhan Liu: > On Fri, Jul 22, 2016 at 10:04:13AM +0200, Thomas Monjalon wrote: > > 2016-07-22 09:46, Yuanhan Liu: > > > On Wed, Jul 20, 2016 at 04:24:30PM +0200, Thomas Monjalon wrote: > > > > The following tools may be installed system-wise. > > > > > > Yes, indeed. Following is an example from dpdk package shipped in > > > ubutun 16.04: > > > > > > dpdk: /etc/dpdk/dpdk.conf > > > dpdk: /etc/dpdk/interfaces > > > dpdk: /etc/init.d/dpdk > > > dpdk: /lib/dpdk/dpdk-init > > > dpdk: /lib/systemd/system/dpdk.service > > > dpdk: /sbin/dpdk_nic_bind > > > dpdk: /usr/bin/dpdk_proc_info > > > dpdk: /usr/bin/testpmd > > > dpdk: /usr/share/doc/dpdk/changelog.Debian.gz > > > dpdk: /usr/share/doc/dpdk/copyright > > > dpdk: /usr/share/dpdk/tools/cpu_layout.py > > > dpdk: /usr/share/dpdk/tools/dpdk_nic_bind.py > > > dpdk: /usr/share/dpdk/tools/setup.sh > > > > > > > It may be cleaner and more convenient to find them with the same > > > > dpdk- prefix (especially for autocompletion). > > > > > > Agreed. > > > > > > > Moreover, the script dpdk_nic_bind.py deserves a new name because it is > > > > not restricted to NICs and can be used for e.g. crypto. > > > > > > Second that. But we might need doc the name change to let user aware of > > > that. > > > > There is a note in API changes section. > > And every references in the doc are renamed. > > > > > > These files are renamed: > > > > pmdinfogen -> dpdk-pmdinfogen > > > > pmdinfo.py -> dpdk-pmdinfo.py > > > > dpdk_pdump -> dpdk-pdump > > > > dpdk_proc_info -> dpdk-procinfo > > > > dpdk_nic_bind.py -> dpdk-devbind.py > > > > setup.sh -> dpdk-setup.sh > > > > > > > > The tools pmdinfogen, pmdinfo.py and dpdk_pdump are new in 16.07. > > > > > > > > The scripts dpdk_nic_bind.py and setup.sh may have been used with > > > > previous releases by end users. That's why a symbolic link still > > > > provide the old name in the installed tools directory. > > > > > > I was about suggesting the same thing: yes, we should keep the > > > backward compatibility. > > > > Does it mean you ack this patch? > > Yes, here is an explict one: > > Acked-by: Yuanhan Liu <yuanhan.liu at linux.intel.com>
Applied
