2016-07-05 17:47, Ferruh Yigit:
> On 6/30/2016 1:00 PM, Christian Ehrhardt wrote:
> > + tac $(RTE_OUTPUT)/.config_tmp >
> > $(RTE_OUTPUT)/.config_tmp_reverse ; \
> Now we are adding new binary dependency (tac) to build system
tac can be replaced by sed '1!G;h;$!d'
On Tue, Jul 05, 2016 at 06:43:57PM +0530, Jerin Jacob wrote:
> On Tue, Jul 05, 2016 at 07:32:46PM +0800, Yuanhan Liu wrote:
> > On Tue, Jul 05, 2016 at 09:43:03AM +0100, Ferruh Yigit wrote:
> > > On 6/30/2016 6:28 PM, Thomas Monjalon wrote:
> > > > 2016-06-30 17:46, Jerin Jacob:
> > > >> Signed-off
Hi All,
First, forgive me for this large message, I know our mailboxes already
suffer quite a bit from the amount of traffic on this ML.
This is not exactly yet another thread about how flow director should be
extended, rather about a brand new API to handle filtering and
classification for incom
On Tue, Jul 05, 2016 at 11:42:59AM +, Jianfeng Tan wrote:
> There is a logic bug in this code, that could lead to null pointer
> dereference when cvq is NULL. Fix this problem by changing logic
> _and_ to logic _or_.
>
>>> CID 127480: Null pointer dereferences (FORWARD_NULL)
>>> Dere
(work)
-- next part --
A non-text attachment was scrubbed...
Name: dpdk_16_04_bug.pdf
Type: application/pdf
Size: 71384 bytes
Desc: dpdk_16_04_bug.pdf
URL:
<http://dpdk.org/ml/archives/dev/attachments/20160705/fdf44761/attachment-0001.pdf>
On Tue, Jul 05, 2016 at 09:43:03AM +0100, Ferruh Yigit wrote:
> On 6/30/2016 6:28 PM, Thomas Monjalon wrote:
> > 2016-06-30 17:46, Jerin Jacob:
> >> Signed-off-by: Jerin Jacob
> >> Acked-by: Olivier Matz
> >
> > Applied, thanks
> >
>
> Hi Jerin,
>
> This commit cause a compilation error on ta
On Tue, Jul 05, 2016 at 10:14:28AM +, Tan, Jianfeng wrote:
> > On Wed, Jun 29, 2016 at 09:05:33AM +, Jianfeng Tan wrote:
> > > - if (rte_kvargs_count(kvlist, VIRTIO_USER_ARG_CQ_NUM) == 1)
> > > - rte_kvargs_process(kvlist, VIRTIO_USER_ARG_CQ_NUM,
> > > -&
Let me point it this way:
??This patch fixes: [dpdk-dev,v3,1/6] ena: update of ENA communication layer
Jan
2016-07-05 19:04 GMT+02:00 Jan M?dala :
> Uhm, wait, I think that sha is wrong, please let me check it double time.
>
> Jan
>
> 2016-07-05 19:03 GMT+02:00 Jan M?dala :
>
>> Bruce,
>>
>>
Uhm, wait, I think that sha is wrong, please let me check it double time.
Jan
2016-07-05 19:03 GMT+02:00 Jan M?dala :
> Bruce,
>
>
> That'd be very kind of you if you can fix trailing zeros.
>
>
> This patch
>
> Fixes: b5b8cd9 ("ena: update of ENA communication layer")
>
>
> Regards,
>
> Jan
Yes, this is correct.
Jan
2016-07-05 18:13 GMT+02:00 Bruce Richardson :
> On Mon, Jul 04, 2016 at 05:27:50PM +0100, Bruce Richardson wrote:
> > On Thu, Jun 30, 2016 at 05:04:58PM +0200, Jan Medala wrote:
> > > After allocating memzone it's required to zeroize memory in it.
> > > Freeing memzon
Yes, this is correct.
Jan
2016-07-05 18:13 GMT+02:00 Bruce Richardson :
> On Mon, Jul 04, 2016 at 05:27:50PM +0100, Bruce Richardson wrote:
> > On Thu, Jun 30, 2016 at 05:04:58PM +0200, Jan Medala wrote:
> > > After allocating memzone it's required to zeroize memory in it.
> > > Freeing memzon
Bruce,
That'd be very kind of you if you can fix trailing zeros.
This patch
Fixes: b5b8cd9 ("ena: update of ENA communication layer")
Regards,
Jan
2016-07-05 18:19 GMT+02:00 Bruce Richardson :
> On Tue, Jul 05, 2016 at 09:52:09AM +0100, Ferruh Yigit wrote:
> > On 6/30/2016 4:04 PM, Jan
On Tue, Jul 05, 2016 at 07:32:46PM +0800, Yuanhan Liu wrote:
> On Tue, Jul 05, 2016 at 09:43:03AM +0100, Ferruh Yigit wrote:
> > On 6/30/2016 6:28 PM, Thomas Monjalon wrote:
> > > 2016-06-30 17:46, Jerin Jacob:
> > >> Signed-off-by: Jerin Jacob
> > >> Acked-by: Olivier Matz
> > >
> > > Applied,
Added neon based Rx vector implementation.
Selection of the new handler based neon availability at runtime.
Updated the release notes and MAINTAINERS file.
Signed-off-by: Jerin Jacob
---
MAINTAINERS | 1 +
doc/guides/rel_notes/release_16_07.rst | 2 +
d
Introduced cpuflag based run-time detection to select the
SSE based simple Rx handler
Signed-off-by: Jerin Jacob
---
drivers/net/virtio/virtio_rxtx.c | 38 --
1 file changed, 24 insertions(+), 14 deletions(-)
diff --git a/drivers/net/virtio/virtio_rxtx.c b/dr
Split out SSE instruction based virtio simple Rx
implementation to a separate file
Signed-off-by: Jerin Jacob
---
drivers/net/virtio/Makefile | 4 +
drivers/net/virtio/virtio_rxtx_simple.c | 273 ++--
drivers/net/virtio/virtio_rxtx_simple.h | 133
Removed unnecessary compile time dependency on "use_simple_rxtx".
Signed-off-by: Jerin Jacob
---
drivers/net/virtio/Makefile | 3 ---
drivers/net/virtio/virtio_pci.h | 1 +
drivers/net/virtio/virtio_rxtx.c| 24
drivers/net/virtio/virtio_rxtx
This patch-set includes,
1) General cleanup of compile time dependency.
2) made vector handler section based on run-time cpuflags
2) Added NEON support for optimized Rx handling
This patch-set is based on dpdk-next-virtio/master
v3:
Address Yuanhan's review comments
http://dpdk.org/dev/patchwork
Hi Remy,
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Remy Horton
> Sent: Friday, July 01, 2016 2:15 AM
>
>
> On 29/06/2016 17:40, Thomas Monjalon wrote:
> [..]
> > I don't think it is possible to standardize stats ids, for two reasons:
> > - it is hard to maintain and avoid conflic
The first word of each commit message is checked.
But when the commit range was greater than 1, only the latest commit
was checked.
It is fixed by checking each commit separately.
Fixes: 9c24780f0d5e ("scripts: check first word of commit messages")
Signed-off-by: Thomas Monjalon
---
scripts/che
On 6/30/2016 1:00 PM, Christian Ehrhardt wrote:
> *updates in v2*
> - move to .config target
> - fix usage order of tac
> - simplify inner section by only using awk (instead of awk+loop+bash+sed)
>
> Due to the hierarchy and the demand to keep the base config showing all
> options, some config key
In addition to the packet type returned by the PMD, also display the
packet type calculated by parsing the packet in software. This is
particularly useful to compare the 2 values.
Note: it does not mean that both hw and sw always have to provide the
same value, since it depends on what hardware su
Use the function introduced in previous commit to dump the packet type
of the received packet.
Signed-off-by: Olivier Matz
---
app/test-pmd/rxonly.c | 175 ++
1 file changed, 4 insertions(+), 171 deletions(-)
diff --git a/app/test-pmd/rxonly.c b/a
An IPv4 packet is considered as a fragment if:
- MF (more fragment) bit is set
- or Fragment_Offset field is non-zero
Update the API documentation of packet types to reflect this.
Signed-off-by: Olivier Matz
---
lib/librte_mbuf/rte_mbuf_ptype.h | 26 --
1 file changed, 1
Dumping the packet type is useful for debug purposes. Instead
of having each application providing its function to do that,
introduce functions to do it.
It factorizes the code and reduces the risk of desynchronization between
the new packet types and the dump function.
Signed-off-by: Olivier Mat
Add a parameter to rte_pktmbuf_get_ptype() to select which
layers should be parsed. This avoids to parse all layers if
only the first ones are required.
Signed-off-by: Olivier Matz
---
lib/librte_mbuf/rte_mbuf_ptype.c | 33 -
lib/librte_mbuf/rte_mbuf_ptype.h | 7
Add support of Nvgre tunnels in rte_pktmbuf_get_ptype(). At the same
time, as Nvgre transports Ethernet, we need to add the support for inner
Vlan, QinQ, and Mpls.
Signed-off-by: Jean Dao
Signed-off-by: Olivier Matz
---
lib/librte_mbuf/rte_mbuf_ptype.c | 48
Add support of Gre tunnels in rte_pktmbuf_get_ptype().
Signed-off-by: Jean Dao
Signed-off-by: Olivier Matz
---
lib/librte_mbuf/rte_mbuf_ptype.c | 40
lib/librte_mbuf/rte_mbuf_ptype.h | 2 +-
2 files changed, 37 insertions(+), 5 deletions(-)
diff --git
Add the Gre header structure in librte_net. It will be used by next
patches that adds the support of Gre tunnels in the software packet type
parser.
The extended headers (checksum, key or sequence number) are not defined.
Signed-off-by: Jean Dao
Signed-off-by: Olivier Matz
---
lib/librte_net/M
Add support of IP and IP6 tunnels in rte_pktmbuf_get_ptype().
We need to duplicate some code because the packet types do not have the
same value for a given protocol between inner and outer.
Signed-off-by: Jean Dao
Signed-off-by: Olivier Matz
---
lib/librte_mbuf/rte_mbuf_ptype.c | 158
Add a new RTE_PTYPE_L2_ETHER_MPLS packet type, and its support in
rte_pktmbuf_get_ptype().
Signed-off-by: Didier Pallard
Signed-off-by: Olivier Matz
---
lib/librte_mbuf/rte_mbuf_ptype.c | 25 +
lib/librte_mbuf/rte_mbuf_ptype.h | 9 -
lib/librte_net/Makefile
Add the Mpls header structure in librte_net. It will be used by next
patches that adds the support of Mpls L2 layer in the software packet
type parser.
Signed-off-by: Olivier Matz
---
lib/librte_net/rte_mpls.h | 64 +++
1 file changed, 64 insertions(+)
Add a new RTE_PTYPE_L2_ETHER_QINQ packet type, and its support in
rte_pktmbuf_get_ptype().
Signed-off-by: Didier Pallard
Signed-off-by: Olivier Matz
---
lib/librte_mbuf/rte_mbuf_ptype.c | 12
lib/librte_mbuf/rte_mbuf_ptype.h | 9 -
lib/librte_net/rte_ether.h | 1 +
Add a new RTE_PTYPE_L2_ETHER_VLAN packet type, and its support in
rte_pktmbuf_get_ptype().
Signed-off-by: Didier Pallard
Signed-off-by: Olivier Matz
---
lib/librte_mbuf/rte_mbuf_ptype.c | 13 +
lib/librte_mbuf/rte_mbuf_ptype.h | 9 -
2 files changed, 21 insertions(+), 1 del
Introduce the function rte_pktmbuf_get_ptype() that parses a
mbuf and returns its packet type. For now, the following packet
types are parsed:
L2: Ether
L3: IPv4, IPv6
L4: TCP, UDP, SCTP
The goal here is to provide a reference implementation for packet type
parsing. This function will be
The file rte_mbuf.h starts to be quite big, and next commits
will introduce more functions related to packet types. Let's
move them in a new file.
Signed-off-by: Olivier Matz
---
lib/librte_mbuf/Makefile | 2 +-
lib/librte_mbuf/rte_mbuf.h | 495 +--
The proper place for rte_ether.h is in librte_net because it defines
network headers.
Moving it will also prevent to have circular references in the following
patches that will require the Ethernet header definition in rte_mbuf.c.
By the way, fix minor checkpatch issues.
Signed-off-by: Didier Pal
Introduce a new function to read the packet data from an mbuf chain. It
linearizes the data if required, and also ensures that the mbuf is large
enough.
This function is used in next commits that add a software parser to
retrieve the packet type.
Signed-off-by: Olivier Matz
---
doc/guides/rel_n
Signed-off-by: Olivier Matz
---
doc/guides/rel_notes/release_16_11.rst | 160 +
1 file changed, 160 insertions(+)
create mode 100644 doc/guides/rel_notes/release_16_11.rst
diff --git a/doc/guides/rel_notes/release_16_11.rst
b/doc/guides/rel_notes/release_16_11.r
This patchset introduces a software packet type parser. This
feature is targeted for v16.11.
The goal here is to provide a reference implementation for packet type
parsing. This function will be used by testpmd to compare its result
with the value given by the hardware.
It will also be useful whe
On Tue, Jul 05, 2016 at 05:54:26PM +0200, Thomas Monjalon wrote:
> The first word of each commit message is checked.
> But when the commit range was greater than 1, only the latest commit
> was checked.
> It is fixed by checking each commit separately.
>
> Fixes: 9c24780f0d5e ("scripts: check firs
On Tue, Jul 05, 2016 at 09:52:09AM +0100, Ferruh Yigit wrote:
> On 6/30/2016 4:04 PM, Jan Medala wrote:
> > Signed-off-by: Alexander Matushevsky
> > Signed-off-by: Jakub Palider
> > Signed-off-by: Jan Medala
>
> The compilation error to fix is [1], it may be good to add what to fix
> into commi
On Mon, Jul 04, 2016 at 05:27:50PM +0100, Bruce Richardson wrote:
> On Thu, Jun 30, 2016 at 05:04:58PM +0200, Jan Medala wrote:
> > After allocating memzone it's required to zeroize memory in it.
> > Freeing memzone with function dedicated for memoryzones.
> >
>
> Can you provide a fixes line for
Add API, NUMA, HW, SW, FW and VMDq to list of words to capitalize properly.
Since VMDq is a bit unusual, add it as special case check so we can
print an error message giving the correct way to write it.
Signed-off-by: Bruce Richadson
---
v2: add NUMA to list
---
scripts/check-git-log.sh | 9 +++
On Tue, Jul 05, 2016 at 12:02:41PM +0200, Jan M?dala wrote:
> Bruce,
>
> Here's explanation of readless communication (on behalf of Alex):
>
> > "readless" refers to ability to read ENA registers without actually
> > issuing read request from host (x86).
> > Instead, host programs 2 registers on
On Mon, Jul 04, 2016 at 10:10:37PM +0200, Thomas Monjalon wrote:
> 2016-07-04 12:41, Neil Horman:
> > On Mon, Jul 04, 2016 at 03:10:14PM +0200, Thomas Monjalon wrote:
> > > Hi Neil,
> > >
> > > I don't really understand why you don't accept I contribute to this
> > > patchset. More details below.
mmap the iomem range of the PCI device fails for kernels that
enabled CONFIG_IO_STRICT_DEVMEM option:
EAL: pci_map_resource():
cannot mmap(39, 0x7f1c5180, 0x10, 0x0):
Invalid argument (0x)
CONFIG_IO_STRICT_DEVMEM is introduced in Linux v4.5 and not enable
Since the current standard for commit prefixes is to put the device type
e.g. "net", in front of the driver name, add a check for commit titles
which have a net driver name without any prefix in front of it.
Signed-off-by: Bruce Richardson
---
scripts/check-git-log.sh | 6 ++
1 file changed,
2016-07-05 14:04, Ferruh Yigit:
> On 7/4/2016 3:50 PM, Pablo de Lara wrote:
> > +* The rte_eal_vdev_init function will be changed in 16.11 to return
> > + the port/device id of the device created, instead of 0, when it has been
> > + initialized successfully, so user can use the returned value st
Hi:
I am a new fish, I have tried my best to find answer about my question on
web, but I failed. so
I come here to ask for your help. the below is my question:
I found that dpdk provides a api rte_eth_stats_get to read packet
statistics about the interface, includes total input/output
unicast/mult
On 7/5/2016 2:13 PM, Jerin Jacob wrote:
> On Tue, Jul 05, 2016 at 07:32:46PM +0800, Yuanhan Liu wrote:
>> On Tue, Jul 05, 2016 at 09:43:03AM +0100, Ferruh Yigit wrote:
>>> On 6/30/2016 6:28 PM, Thomas Monjalon wrote:
2016-06-30 17:46, Jerin Jacob:
> Signed-off-by: Jerin Jacob
> Acked-
> -Original Message-
> From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com]
> Sent: Tuesday, July 05, 2016 2:39 PM
> To: Yigit, Ferruh
> Cc: dev at dpdk.org; De Lara Guarch, Pablo; Mcnamara, John
> Subject: Re: [dpdk-dev] [PATCH] doc: announce API change for virtual device
> initia
On Tue, Jul 05, 2016 at 12:27:06PM +0100, Ferruh Yigit wrote:
> On 7/5/2016 11:44 AM, Adrien Mazarguil wrote:
> > DPDK uses GNU C language extensions in most of its code base. This is fine
> > for internal source files whose compilation flags are controlled by DPDK,
> > however user applications th
2016-07-05 12:27, Ferruh Yigit:
> On 7/5/2016 11:44 AM, Adrien Mazarguil wrote:
> > DPDK uses GNU C language extensions in most of its code base. This is fine
> > for internal source files whose compilation flags are controlled by DPDK,
> > however user applications that use exported "public" heade
On Tue, Jul 05, 2016 at 02:10:05PM +0800, Beilei Xing wrote:
> When calling i40e_flowtype_to_pctype in
> i40e_get_hash_filter_global_config and
> i40e_set_hash_filter_global_config, function
> i40e_flowtype_to_pctype will be possibly
> out-of-bounds accessed, because size of callee's array
> is 15.
On Tue, Jul 05, 2016 at 02:10:04PM +0800, Beilei Xing wrote:
> Null-checking vsi suggests that it may be null, but it
> has be dereferenced before null-checking. So move if
> statement to the front of assignment statement.
>
> Coverity: 119265, 119266
>
> Fixes: d0a349409bd7 ("i40e: support AQ ba
On Tue, Jul 05, 2016 at 02:10:03PM +0800, Beilei Xing wrote:
> The condition, "(pf->flags | I40E_FLAG_VMDQ)" will always be true,
> regardless of the value of the flags operand, because I40E_FLAG_VMDQ
> is 4ULL - meaning at least one bit will always be set in the result.
> That will cause log error
Coverity reported lots of out-of-bounds in function
vxlan_link, these issues should happen when index
port_id evaluates to 2, cause size of arrays is
2 in structure.
Fix this issue by modifying judgement condition, make
sure port_id is less than 2.
Coverity issue: 107121, 107122, 107123, 107124, 1
When calling i40e_flowtype_to_pctype in
i40e_get_hash_filter_global_config and
i40e_set_hash_filter_global_config, function
i40e_flowtype_to_pctype will be possibly
out-of-bounds accessed, because size of callee's array
is 15. So judge flow type before calling
i40e_flowtype_to_pctype.
Meanwhile do
Null-checking vsi suggests that it may be null, but it
has be dereferenced before null-checking. So move if
statement to the front of assignment statement.
Coverity: 119265, 119266
Fixes: d0a349409bd7 ("i40e: support AQ based RSS config")
Fixes: 647d1eaf758b ("i40evf: support AQ based RSS config"
The condition, "(pf->flags | I40E_FLAG_VMDQ)" will always be true,
regardless of the value of the flags operand, because I40E_FLAG_VMDQ
is 4ULL - meaning at least one bit will always be set in the result.
That will cause log error when VMDq is disabled.
Since the original intent behind the conditio
Fix some open coverity defects.
V2 changes:
Rework commit log.
Refactor patchset.
Beilei Xing (3):
i40e: fix log error
i40e: fix dereference before null check
i40e: fix out-of-bounds access
drivers/net/i40e/i40e_ethdev.c| 35 +--
drivers/net/i40e/i40e
Add API, HW, SW, FW and VMDq to list of words to capitalize properly.
Since VMDq is a bit unusual, add it as special case check so we can
print an error message giving the correct way to write it.
Signed-off-by: Bruce Richadson
---
scripts/check-git-log.sh | 8
1 file changed, 8 inserti
On 7/4/2016 3:50 PM, Pablo de Lara wrote:
> In order to create a virtual device, user needs to call
> rte_eal_vdev_init generally, but this function returns 0
> on success or negative number if error. Instead, something
> more useful would be to return the port or device id of the
> device created,
-Original Message-
From: Abhishek Mahajan
Date: Tuesday, July 5, 2016 at 1:49 AM
To: Keith Wiles , "dev at dpdk.org"
Cc: "Addepalli, Srinivasa R" , "Shivastava,
RakeshX"
Subject: RE: [dpdk-dev] Low packet generation rate of 526kpps using pktgen-dpdk
from inside VM
Hi Keith,
I tried y
Hi Jan,
On Tue, Jul 05, 2016 at 01:15:23PM +0200, Jan Viktorin wrote:
> Hi Adrien,
>
> I am the only one in CC and only in the 00/11 patch. Is it a mistake? Or what
> is the purpose?
It was on purpose to draw your attention to my comment regarding #includes
within extern "C" blocks.
> Regards?
Hi Adrien,
I am the only one in CC and only in the 00/11 patch. Is it a mistake? Or what
is the purpose?
Regards?
Jan?Viktorin
RehiveTech
Sent?from?a?mobile?device
? P?vodn? zpr?va ?
Od: Adrien Mazarguil
Odesl?no: ?ter?, 5. ?ervence 2016 12:45
Komu: dev at dpdk.org
Kopie: Jan Viktorin
P?edm?t: [
This script checks that header files in a given directory do not miss
dependencies when included on their own, do not conflict and accept being
compiled with the strictest possible flags.
Signed-off-by: Adrien Mazarguil
---
MAINTAINERS | 1 +
scripts/check-includes.sh | 286 +
Arch-specific functions not defined for all architectures (missing on x86
in this case) and not used anywhere should not expose a prototype.
This commit prevents the following error:
error: `rte_mov48' declared `static' but never defined
Signed-off-by: Adrien Mazarguil
---
lib/librte_eal/comm
Exported header files used by applications should allow the strictest
compiler flags. Language extensions used in many places must be explicitly
marked or removed to avoid warnings and compilation failures.
Since there is no way to force named variadic macros as extensions, use a
a standard __VA_A
Exported header files used by applications should allow the strictest
compiler flags. Language extensions used in many places must be explicitly
marked or removed to avoid warnings and compilation failures.
This commit prevents the following errors:
error: ISO C forbids forward references to `en
Exported header files for use by applications should be self sufficient and
allow out of order inclusion. Moreover, they must include all the system
headers they need for types and macros.
This commit prevents the following errors:
error: `RTE_MAX_LCORE' undeclared here (not in a function)
erro
Exported header files used by applications should allow the strictest
compiler flags. Language extensions used in many places must be explicitly
marked to avoid warnings and compilation failures.
Unnamed structs/unions are allowed since C11, however many compiler
versions do not use this mode by d
Exported header files used by applications should allow the strictest
compiler flags. Language extensions used in many places must be explicitly
marked or removed to avoid warnings and compilation failures.
This commit prevents the following errors:
error: struct has no members
Signed-off-by: A
Exported header files used by applications should allow the strictest
compiler flags. Language extensions used in many places must be explicitly
marked or removed to avoid warnings and compilation failures.
This commit prevents the following errors:
error: type of bit-field `[...]' is a GCC exte
Exported header files used by applications should allow the strictest
compiler flags. Language extensions used in many places must be explicitly
marked or removed to avoid warnings and compilation failures.
The extension keyword is used whenever the C99 syntax cannot do it.
This commit prevents t
Exported header files used by applications should allow the strictest
compiler flags. Language extensions used in many places must be explicitly
marked or removed to avoid warnings and compilation failures.
This commit prevents the following errors:
error: ISO C restricts enumerator values to ra
Exported header files used by applications should allow the strictest
compiler flags. Language extensions used in many places must be explicitly
marked or removed to avoid warnings and compilation failures.
This commit prevents the following errors:
error: ISO C forbids braced-groups within expr
DPDK uses GNU C language extensions in most of its code base. This is fine
for internal source files whose compilation flags are controlled by DPDK,
however user applications that use exported "public" headers may experience
compilation failures when enabling strict error/standard checks (-std and
On 7/5/2016 11:44 AM, Adrien Mazarguil wrote:
> DPDK uses GNU C language extensions in most of its code base. This is fine
> for internal source files whose compilation flags are controlled by DPDK,
> however user applications that use exported "public" headers may experience
> compilation failures
Bruce,
Here's explanation of readless communication (on behalf of Alex):
> "readless" refers to ability to read ENA registers without actually
> issuing read request from host (x86).
> Instead, host programs 2 registers on device that trigger DMA from device
> to host and report register value.
>
Zeroing out memory on rte_zmalloc_socket is not required anymore since all
allocated memory is already zeroed.
Signed-off-by: Sergio Gonzalez Monroy
---
lib/librte_eal/common/rte_malloc.c | 6 +-
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/lib/librte_eal/common/rte_malloc.c
Since [1] memzones are not guaranteed to be zeroed out.
This could potentially cause issues as applications might have been
relying on the allocated memory being zeroed out.
On init all allocated memory is zeroed by the kernel, so by zeroing out
memory on free, all available dpdk memory is always
On Tue, Jul 05, 2016 at 11:25:10AM +0200, Adrien Mazarguil wrote:
> On Mon, Jul 04, 2016 at 10:24:16AM +0200, Olivier Matz wrote:
> > This series adds a missing device operation in mlx4 to
> > set the link state. It also fixes the function to set the
> > flags on the kernel interface in both mlx4 a
On 04/07/16 15:50, Pablo de Lara wrote:
> In order to create a virtual device, user needs to call
> rte_eal_vdev_init generally, but this function returns 0
> on success or negative number if error. Instead, something
> more useful would be to return the port or device id of the
> device created, s
There is a logic bug in this code, that could lead to null pointer
dereference when cvq is NULL. Fix this problem by changing logic
_and_ to logic _or_.
>> CID 127480: Null pointer dereferences (FORWARD_NULL)
>> Dereferencing null pointer "cvq".
if (!cvq && !cvq->vq) {
On Mon, Jul 04, 2016 at 10:24:16AM +0200, Olivier Matz wrote:
> This series adds a missing device operation in mlx4 to
> set the link state. It also fixes the function to set the
> flags on the kernel interface in both mlx4 and mlx5.
Thanks.
Acked-by: Adrien Mazarguil
> Guo Fengtian (1):
> ne
On Tue, Jul 05, 2016 at 10:43:42AM +0100, Bruce Richardson wrote:
> On Mon, Jul 04, 2016 at 03:51:08PM +0800, Wang Xiao W wrote:
> > We find that when traffic is light, a few amount of packets will be
> > wrongly parsed (e.g. packet type), however this issue will not happen
> > when traffic is heav
On Mon, Jul 04, 2016 at 03:51:08PM +0800, Wang Xiao W wrote:
> We find that when traffic is light, a few amount of packets will be
> wrongly parsed (e.g. packet type), however this issue will not happen
> when traffic is heavy.
>
> The root cause is some fields in fm10k_rx_desc are read at wrong t
On Mon, Jul 04, 2016 at 12:46:14PM +0530, Jerin Jacob wrote:
> From: Kamil Rytarowski
>
> Allocate maximum supported hardware ring hardware descriptors
> memory on the first rte_eth_dma_zone_reserve call in-order to
> get sufficient hardware ring buffer space on subsequent queue
> setup request w
Since
commit f2bb7ae1d204 ("app/testpmd: handle all Rx queues in RSS setup")
behavior of rss_fwd_config_setup() changed and description of this
function is wrong now.
Also, there is a type mismatch in a loop.
Signed-off-by: Ilya Maximets
---
app/test-pmd/config.c | 17 ++---
1 file
Hi Yuanhan,
> -Original Message-
> From: Yuanhan Liu [mailto:yuanhan.liu at linux.intel.com]
> Sent: Friday, July 1, 2016 10:16 AM
> To: Tan, Jianfeng
> Cc: dev at dpdk.org; Xie, Huawei; Mcnamara, John
> Subject: Re: [PATCH 1/4] net/virtio-user: fix return value not checked
>
> On Wed, Ju
On Monday 04 July 2016 08:06 PM, Jan Viktorin wrote:
> On Mon, 4 Jul 2016 19:57:18 +0530
> Shreyansh jain wrote:
>
> [...]
>
> @@ -1431,7 +1524,7 @@ rte_eth_dev_info_get(uint8_t port_id, struct
> rte_eth_dev_info *dev_info)
>
> RTE_FUNC_PTR_OR_RET(*dev->dev_ops->dev_infos_ge
On Fri, Jul 01, 2016 at 10:02:46AM +0100, Ananyev, Konstantin wrote:
>
> > The ixgbe driver does not compile if CONFIG_RTE_IXGBE_RX_OLFLAGS_ENABLE=n
> > because the macro has not the proper number of parameters. To reproduce
> > the issue:
> >
> > make config T=x86_64-native-linuxapp-gcc
> >
> -Original Message-
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Yari Adan
> Petralanda
> Sent: Monday, July 04, 2016 10:00 AM
> To: dev at dpdk.org
> Subject: [dpdk-dev] [PATCH v3] hash: new function to retrieve a key given its
> position
>
> The function rte_hash_get_key_
On Tue, 2016-07-05 at 00:52 +, Lu, Wenzhuo wrote:
> Hi Luca,
>
>
> > -Original Message-
> > From: Luca Boccassi [mailto:lboccass at Brocade.com]
> > Sent: Monday, July 4, 2016 11:48 PM
> > To: Lu, Wenzhuo
> > Cc: dev at dpdk.org
> > Subject: Re: [dpdk-dev] [PATCH v6 0/4] support reset
On 6/30/2016 4:04 PM, Jan Medala wrote:
> Signed-off-by: Alexander Matushevsky
> Signed-off-by: Jakub Palider
> Signed-off-by: Jan Medala
The compilation error to fix is [1], it may be good to add what to fix
into commit log.
[1]
== Build drivers/net/ena
CC ena_ethdev.o
/tmp/dpdk_maintain/en
On 6/30/2016 6:28 PM, Thomas Monjalon wrote:
> 2016-06-30 17:46, Jerin Jacob:
>> Signed-off-by: Jerin Jacob
>> Acked-by: Olivier Matz
>
> Applied, thanks
>
Hi Jerin,
This commit cause a compilation error on target i686-native-linuxapp-gcc
with gcc6.
Compilation error is:
== Build drivers/net
Hello Shreyansh,
?
> On Monday 04 July 2016 08:06 PM, Jan Viktorin wrote:
>> On Mon, 4 Jul 2016 19:57:18 +0530
>> Shreyansh jain wrote:
>>
>> [...]
>>
>> @@ -1431,7 +1524,7 @@ >rte_eth_dev_info_get(uint8_t port_id, struct
>> >rte_eth_dev_info *dev_info)
>>
>> RTE_FUNC_PTR_OR_RE
On Tue, Jul 5, 2016 at 2:35 AM, Bill Bonaparte
wrote:
> Hi:
> I am a new fish, I have tried my best to find answer about my question on
> web, but I failed. so
> I come here to ask for your help. the below is my question:
>
> I found that dpdk provides a api rte_eth_stats_get to read packet
> sta
1 - 100 of 103 matches
Mail list logo
