On Tue, Jul 05, 2016 at 02:10:03PM +0800, Beilei Xing wrote: > The condition, "(pf->flags | I40E_FLAG_VMDQ)" will always be true, > regardless of the value of the flags operand, because I40E_FLAG_VMDQ > is 4ULL - meaning at least one bit will always be set in the result. > That will cause log error when VMDq is disabled. > Since the original intent behind the condition is to check if VMDq > is enabled, fix the code by changing "|" to "&". > > Coverity issue: 13219, 13221 > > Fixes: 4805ed59e957 ("i40e: enhance mac address operations") > > Signed-off-by: Beilei Xing <beilei.xing at intel.com>
Acked-by: Bruce Richardson <bruce.richardson at intel.com>