Thanks Thomas for putting back this topic.
Alex,
I'd like to hear more about the impacts of "unsupported":
https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=033291eccbdb1b70ffc02641edae19ac825dc75d
Use of this mode, specifically binding a device without a native
IOM
On Wed, Dec 2, 2015 at 10:06 PM, Yuanhan Liu
wrote:
>
> +static inline struct rte_mbuf *
> +copy_desc_to_mbuf(struct virtio_net *dev, struct vhost_virtqueue *vq,
> + uint16_t desc_idx, struct rte_mempool *mbuf_pool)
> +{
>
...
> +
> + desc = &vq->desc[desc_idx];
> + de
On Fri, Dec 11, 2015 at 12:55:57PM +, Ananyev, Konstantin wrote:
> Hi Jerin,
>
> > -Original Message-
> > From: Jerin Jacob [mailto:jerin.jacob at caviumnetworks.com]
> > Sent: Thursday, December 10, 2015 4:36 PM
> > To: dev at dpdk.org
> > Cc: thomas.monjalon at 6wind.com; Ananyev, Kon
> -Original Message-
> From: Stephen Hemminger [mailto:shemming at brocade.com]
> Sent: Friday, December 11, 2015 4:48 PM
> To: dev at dpdk.org; Zhang, Helin; Ananyev, Konstantin
> Subject: Re: [PATCH v2 ] ixgbe: speed up transmit
>
> On Fri, 13 Nov 2015 08:10:13 -0800
> Stephen Hemminger
On Fri, Dec 11, 2015 at 11:26:55AM +0300, Pavel Fedin wrote:
> Hello!
>
> I am currently testing this patchset with qemu and have problems.
Hi,
Thanks for testing!
>
> The guest migrates correctly, but after the migration it cries in the log:
>
> Vhost user backend fails to broadcast fake R
Recently there were some discussions to have an upstream replacement
for our igb_uio module.
Several solutions were discussed (new uio driver, uio_pci_generic, vfio):
https://lkml.org/lkml/2015/10/16/700
Alex Williamson (maintainer of VFIO driver), submitted a solution
and was waiting some
Coverity issue: 107133
Fixes: eb32fe7c5574 ("examples/ip_pipeline: rework initialization parameters")
Signed-off-by: Fan Zhang
Acked-by: Cristian Dumitrescu
---
*v2
fixed bug: fix possible buff not null terminated bug
examples/ip_pipeline/init.c | 2 +-
1 file changed, 1 insertion(+), 1 deleti
> -Original Message-
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Fan Zhang
> Sent: Friday, December 11, 2015 4:02 PM
> To: dev at dpdk.org
> Subject: [dpdk-dev] [PATCH] example/ip_pipeline: fix copy into fixed size
> buffer defect
>
> Coverity issue: 107133
> Fixes: eb32fe7c5
> -Original Message-
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Mcnamara, John
> Sent: Friday, December 11, 2015 3:37 PM
> To: Zhang, Roy Fan ; dev at dpdk.org
> Subject: Re: [dpdk-dev] [PATCH] example/ip_pipeline: fix copy into fixed
> size buffer defect
>
> > -Origin
On Fri, 2015-12-11 at 23:12 +0100, Vincent JARDIN wrote:
> Thanks Thomas for putting back this topic.
>
> Alex,
>
> I'd like to hear more about the impacts of "unsupported":
> https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commi
> t/?id=033291eccbdb1b70ffc02641edae19ac825dc75d
>
Coverity issue: 107133
Fixes: eb32fe7c5574 ("examples/ip_pipeline: rework initialization parameters")
Signed-off-by: Fan Zhang
Acked-by: Cristian Dumitrescu
---
*v2
fixed bug: fix possible buff not null terminated bug
examples/ip_pipeline/init.c | 3 ++-
1 file changed, 2 insertions(+), 1 dele
Hello Cunming,
On Fri, Dec 11, 2015 at 2:48 AM, Cunming Liang
wrote:
> In eal_intr_proc_rxtx_intr, negative value may be used as argument to a
> function expecting a positive value. If 'read' returns EAGAIN as example,
> the bytes_read updates to a negative value which continue be passed as
> ar
> -Original Message-
> From: discuss [mailto:discuss-bounces at openvswitch.org] On Behalf Of MAO
> Ruoyu
> Sent: Friday, December 11, 2015 2:25 AM
> To: discuss at openvswitch.org
> Subject: [ovs-discuss] ovs-vswitchd crash
>
> Hi,
> We install openstack using devstack with OVS-DPDK
> W
Hello Helin, Konstantin,
I noticed this issue quite some time ago (maybe around dpdk-1.3.0, not
sure) but had no time to investigate/report.
I hit it again with dpdk-2.2.0-rc2, so maybe all dpdk versions are impacted.
The test is quite simple :
- send icmp packets from a system (tn) to itself usi
> -Original Message-
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Fan Zhang
> Sent: Friday, December 11, 2015 11:29 AM
> To: dev at dpdk.org
> Subject: [dpdk-dev] [PATCH] example/ip_pipeline: fix value overwrite
>
> Coverity issue: 107136
> Fixes: 7f64b9c004aa ("examples/ip_
> -Original Message-
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Fan Zhang
> Sent: Friday, December 11, 2015 11:29 AM
> To: dev at dpdk.org
> Subject: [dpdk-dev] [PATCH] example/ip_pipeline: fix copy into fixed size
> buffer defect
>
> Coverity issue: 107133
> Fixes: eb32fe7c
> -Original Message-
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Fan Zhang
> Sent: Friday, December 11, 2015 11:29 AM
> To: dev at dpdk.org
> Subject: [dpdk-dev] [PATCH] example/ip_pipeline: fix overrunning byffer
> defect
>
> Coverity issue: 107127
> Fixes: 7f64b9c004aa ("ex
> -Original Message-
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Fan Zhang
> Sent: Friday, December 11, 2015 11:29 AM
> To: dev at dpdk.org
> Subject: [dpdk-dev] [PATCH] example/ip_pipeline: fix logically deadnode
> defect
>
> Coverity issue: 107109
> Fixes: 7122d30131ad ("ex
> -Original Message-
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Fan Zhang
> Sent: Friday, December 11, 2015 11:29 AM
> To: dev at dpdk.org
> Subject: [dpdk-dev] [PATCH] example/ip_pipeline: fix copy-paste error
>
> Coverity issue: 107104
> Fixes: 7f64b9c004aa ("examples/ip_p
> -Original Message-
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Fan Zhang
> Sent: Friday, December 11, 2015 11:29 AM
> To: dev at dpdk.org
> Subject: [dpdk-dev] [PATCH] example/ip_pipeline: fix buffer size warning
>
> Coverity issue: 107102
> Fixes: 7f64b9c004aa ("examples/i
On 12/11/2015 10:49 PM, Mcnamara, John wrote:
>> -Original Message-
>> From: Huawei Xie
>> Sent: Thursday, December 10, 2015 5:57 PM
>> To: dev at dpdk.org
>> Cc: Mcnamara, John; Xie, Huawei
>> Subject: [PATCH 1/4] vhost: Fix Coverity issue with possible array out-of-
>> bounds read
>>
>> C
> -Original Message-
> From: Huawei Xie
> Sent: Thursday, December 10, 2015 5:57 PM
> To: dev at dpdk.org
> Cc: Mcnamara, John; Xie, Huawei
> Subject: [PATCH 4/4] vhost: Fix Coverity issue with logically dead code
>
> CID 107107 (#1 of 1): Logically dead code
> Fixes: af4f2c5feb2e ("vhost:
> -Original Message-
> From: Huawei Xie
> Sent: Thursday, December 10, 2015 5:57 PM
> To: dev at dpdk.org
> Cc: Mcnamara, John; Xie, Huawei
> Subject: [PATCH 3/4] vhost: Fix Coverity issue with missed unlocking
>
> CID 107113 (#1 of 1): Missing unlock (LOCK)5. missing_unlock: Returning
> w
> -Original Message-
> From: Huawei Xie
> Sent: Thursday, December 10, 2015 5:57 PM
> To: dev at dpdk.org
> Cc: Mcnamara, John; Xie, Huawei
> Subject: [PATCH 2/4] vhost: Fix Coverity issue with missed break in switch
>
> CID 107114 (#1 of 1): Missing break in switch
> Fixes: 8f972312b8f4 (
> -Original Message-
> From: Huawei Xie
> Sent: Thursday, December 10, 2015 5:57 PM
> To: dev at dpdk.org
> Cc: Mcnamara, John; Xie, Huawei
> Subject: [PATCH 1/4] vhost: Fix Coverity issue with possible array out-of-
> bounds read
>
> CID 107126 (#1 OF 1): Out-of-bounds read
> Fixes: 8f972
2015-12-11 13:41, John McNamara:
> Enable Doxygen parsing of DPDK example files so that the example
> code is linked to and from the API docs. This allows the reader
> to see examples of API usage in context by following a link.
>
> Signed-off-by: John McNamara
Note sure of the benefit.
I think
When relpath.sh is called from install target with prefix set, eg
"make install DESTDIR=/tmp/dpdk-root prefix=/usr", the prefix
from the environment leaks to relpath.sh internal helper variable and
causes incorrect symlinks to be generated in sdk $(targetdir):
include -> /usr../../../include/dp
> -Original Message-
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Rahul Lakkireddy
> Sent: Friday, December 11, 2015 8:26 AM
> To: dev at dpdk.org
> Cc: Felix Marti; Kumar Sanghvi; Nirranjan Kirubaharan
> Subject: [dpdk-dev] [PATCH] cxgbe: fix unnecessary check for freelist
> e
> >
> > I think we better keep both struct rte_ring_debug_stats and
> > rte_mempool_debug_stats
> > as __rte_cache_aligned.
> > Both are on a per core basis and can be used at run-time
> > (when RTE_LIBRTE_RING_DEBUG/RTE_LIBRTE_MEMPOOL_DEBUG=y),
> > and not supposed to be shared by different cor
> -Original Message-
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Cunming Liang
> Sent: Friday, December 11, 2015 1:49 AM
> To: dev at dpdk.org
> Subject: [dpdk-dev] [PATCH v1] eal: fix negative value incorrectly being
> used defect
>
> In eal_intr_proc_rxtx_intr, negative val
examples/netmap_compat/bridge/../lib/compat_netmap.c:880:41:
error: ?POLLRDNORM? undeclared (first use in this function)
The root casue is POLLRDNORM is more-or-less nonstandard, and it
depends on macro "__USE_XOPEN".
Fixes: 06371afe394d (examples/netmap_compat: import netmap compatibility
exa
> -Original Message-
> From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com]
> Sent: Friday, December 11, 2015 1:45 PM
> To: Mcnamara, John
> Cc: dev at dpdk.org
> Subject: Re: [dpdk-dev] [PATCH] doc: add example programs to doxygen api
> docs
>
> 2015-12-11 13:41, John McNamara:
> >
2015-12-11 12:55, Ananyev, Konstantin:
> BTW, by some reason I can't find that series in the patchworks.
Because it is deferred:
http://dpdk.org/dev/patchwork/project/dpdk/list/?state=10
It's too late to do this change in 2.2.
2015-12-11 14:44, Panu Matilainen:
> When relpath.sh is called from install target with prefix set, eg
> "make install DESTDIR=/tmp/dpdk-root prefix=/usr", the prefix
> from the environment leaks to relpath.sh internal helper variable and
> causes incorrect symlinks to be generated in sdk $(targetd
When refilling freelists for the first time and if it fails, the rxq
is freed and returns ENOMEM. There is a check while freeing hardware rxq
to pass freelist context id if the freelist exists or 0x otherwise.
The error path is only reached if freelist exists. So, fix is to remove
the useless c
Enable Doxygen parsing of DPDK example files so that the example
code is linked to and from the API docs. This allows the reader
to see examples of API usage in context by following a link.
Signed-off-by: John McNamara
---
Notes:
* Here is an example of the sample code/api linkage in use:
h
Hello!
> On Fri, Dec 11, 2015 at 11:26:55AM +0300, Pavel Fedin wrote:
> > Hello!
> >
> > I am currently testing this patchset with qemu and have problems.
>
> Hi,
>
> Thanks for testing!
Not at all :)
BTW, it works, and it was my bad. openvswitch was configured incorrectly on
the other s
Hi Jerin,
> -Original Message-
> From: Jerin Jacob [mailto:jerin.jacob at caviumnetworks.com]
> Sent: Thursday, December 10, 2015 4:36 PM
> To: dev at dpdk.org
> Cc: thomas.monjalon at 6wind.com; Ananyev, Konstantin; viktorin at
> rehivetech.com; jianbo.liu at linaro.org; Jerin Jacob
> Su
2015-12-11 08:31, Betts, Ian:
> From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com]
> >Applied, thanks
> >The patch to mark it experimental and disable it has also been applied.
> >The huge codebase has been integrated to give visibility.
> >We need to discuss it more and decide how to con
On Wed, Dec 2, 2015 at 10:06 PM, Yuanhan Liu
wrote:
> +static inline int __attribute__((always_inline))
> +copy_mbuf_to_desc(struct virtio_net *dev, struct vhost_virtqueue *vq,
> + struct rte_mbuf *m, uint16_t desc_idx, uint32_t *copied)
> +{
> ...
> + while (1) {
> +
Hi Andrey,
On Thursday, December 12/10/15, 2015 at 07:46:42 -0800, Chilikin, Andrey wrote:
> Hi Rahul,
>
> If ABI for fdir is going to be changed should we then take more general
> approach to accommodate other NICs as well? For example, for
> "rte_eth_ipv4_flow" you have "tos" and "proto" fie
Coverity issue: 107136
Fixes: 7f64b9c004aa ("examples/ip_pipeline: rework config file syntax")
Signed-off-by: Fan Zhang
Acked-by: Cristian Dumitrescu
---
examples/ip_pipeline/config_parse.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/examples/ip_pipeline/config_parse
Coverity issue: 107127
Fixes: 7f64b9c004aa ("examples/ip_pipeline: rework config file syntax")
Signed-off-by: Fan Zhang
Acked-by: Cristian Dumitrescu
---
examples/ip_pipeline/config_parse_tm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/examples/ip_pipeline/config_parse_
Coverity issue: 107109
Fixes: 7122d30131ad ("examples/ip_pipeline: rework flow classification
pipeline")
Signed-off-by: Fan Zhang
Acked-by: Cristian Dumitrescu
---
examples/ip_pipeline/pipeline/pipeline_flow_classification.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/e
Coverity issue: 107104
Fixes: 7f64b9c004aa ("examples/ip_pipeline: rework config file syntax")
Signed-off-by: Fan Zhang
Acked-by: Cristian Dumitrescu
---
examples/ip_pipeline/config_parse.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/examples/ip_pipeline/config_parse.c
Coverity issue: 107133
Fixes: eb32fe7c5574 ("examples/ip_pipeline: rework initialization parameters")
Signed-off-by: Fan Zhang
Acked-by: Cristian Dumitrescu
---
examples/ip_pipeline/init.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/examples/ip_pipeline/init.c b/exam
Coverity issue: 107102
Fixes: 7f64b9c004aa ("examples/ip_pipeline: rework config file syntax")
Signed-off-by: Fan Zhang
Acked-by: Cristian Dumitrescu
---
examples/ip_pipeline/config_parse_tm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/examples/ip_pipeline/config_parse_
On 12/11/2015 01:27 AM, Stephen Hemminger wrote:
> Plan to change to version of struct ether_addr in
> DPDK 2.3. The change in DPDK source is trivial but it will impact
> source compatablilty therefore notification is necessary.
>
> Signed-off-by: Stephen Hemminger
> ---
> doc/guides/rel_notes/
Hello!
I am currently testing this patchset with qemu and have problems.
The guest migrates correctly, but after the migration it cries in the log:
Vhost user backend fails to broadcast fake RARP
and pinging the (new) host doesn't work. When i migrate it back to the old
host, the network r
DPDK ports are only detected during the EAL initialization. After that, any
new DPDK ports which are bound will not be visible to the application.
The dpdk_nic_bind.py can be a bit more helpful to let users know that DPDK
enabled applications will not find rebound ports until after they have been
On 12/10/2015 04:50 PM, Ananyev, Konstantin wrote:
>
>
>> -Original Message-
>> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Bernard Iremonger
>> Sent: Thursday, December 10, 2015 1:53 PM
>> To: dev at dpdk.org
>> Subject: [dpdk-dev] [PATCH v2] examples/vhost: reduce number of hu
In current codes, tunnel configuration information is not stored in a device
configuration, and it will get nothing if application want to retrieve tunnel
config, so I think it is necessary
to add rte_eth_dev_tunnel_configure() function is to do the configurations
including flow and classificat
Signed-off-by: Rasesh Mody
---
drivers/net/bnx2x/bnx2x_rxtx.c |3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/net/bnx2x/bnx2x_rxtx.c b/drivers/net/bnx2x/bnx2x_rxtx.c
index ccece43..28bc520 100644
--- a/drivers/net/bnx2x/bnx2x_rxtx.c
+++ b/drivers/net/bnx2x/bnx2x_rxtx.c
@@ -381,6
Correct the error check in PMD transmit routine.
Signed-off-by: Rasesh Mody
---
drivers/net/bnx2x/bnx2x_rxtx.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/bnx2x/bnx2x_rxtx.c b/drivers/net/bnx2x/bnx2x_rxtx.c
index 0f8b9bd..ccece43 100644
--- a/drivers/net/bn
In eal_intr_proc_rxtx_intr, negative value may be used as argument to a
function expecting a positive value. If 'read' returns EAGAIN as example, the
bytes_read updates to a negative value which continue be passed as argument for
the next 'read'.
Coverity issue: 107115
927do {
3. n
Since we have agreement on the purpose and scope of the board, I'd like to make
a proposal on the composition. I think the following people all have a strong
history of contributions and technical credibility within the community, and
represent a broad range of perspectives on DPDK: Stephen Hemm
From: Tom Kiely
SRIOV VFs support "transparent" vlans. Traffic from/to a VM
associated with a VF is tagged/untagged with the specified
vlan in a manner intended to be totally transparent to the VM.
The vlan is specified by "ip link set vf vlan ".
The VM is not configured for any vlan on the VF
On Fri, 13 Nov 2015 08:10:13 -0800
Stephen Hemminger wrote:
> From: Stephen Hemminger
>
> The freeing of mbuf's in ixgbe is one of the observable hot spots
> under load. Optimize it by doing bulk free of mbufs using code similar
> to i40e and fm10k.
>
> Drop the no longer needed micro-optimiza
On Fri, 11 Dec 2015 11:28:48 +0200
Panu Matilainen wrote:
> On 12/11/2015 01:27 AM, Stephen Hemminger wrote:
> > Plan to change to version of struct ether_addr in
> > DPDK 2.3. The change in DPDK source is trivial but it will impact
> > source compatablilty therefore notification is necessary.
>
-Original Message-
From: Thomas Monjalon [mailto:thomas.monja...@6wind.com]
Sent: Friday, December 11, 2015 1:41 AM
To: Betts, Ian
Cc: dev at dpdk.org; Kulasek, TomaszX
Subject: Re: [dpdk-dev] [PATCH v10 0/4] examples: add performance-thread
>Applied, thanks
>The patch to mark it experime
2015-12-10 12:24, Ian Betts:
> This commit removes the performance thread example from
> examples/Makefile, and marks the example as "experimental"
> in the release note, and it its API headers files.
>
> Signed-off-by: Ian Betts
Applied, thanks
It has been marked as experimental in the maintain
> > Ian Betts (4):
> > doc: add sample application guide for performance-thread
> > examples: add lthread subsystem for performance-thread
> > examples: add l3fwd-thread example in performance-thread
> > examples: add pthread_shim example to performance thread
>
> Series Acked-by: Tomasz K
CID 107107 (#1 of 1): Logically dead code
Fixes: af4f2c5feb2e ("vhost: fix code style")
Signed-off-by: Huawei Xie
---
lib/librte_vhost/virtio-net.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/lib/librte_vhost/virtio-net.c b/lib/librte_vhost/virtio-net.c
index 8364938..d
CID 107113 (#1 of 1): Missing unlock (LOCK)5. missing_unlock: Returning
without unlocking pfdset->fd_mutex.
Fixes: fbf7e07ca142 ("vhost: add select based event driven processing")
Signed-off-by: Huawei Xie
---
lib/librte_vhost/vhost_user/fd_man.c | 4 +++-
1 file changed, 3 insertions(+), 1 dele
CID 107114 (#1 of 1): Missing break in switch
Fixes: 8f972312b8f4 ("vhost: support vhost-user")
Signed-off-by: Huawei Xie
---
lib/librte_vhost/vhost_user/vhost-net-user.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/lib/librte_vhost/vhost_user/vhost-net-user.c
b/lib/librte_vhost/vhost_
The virtio_net_hdr desc all pointed to the same buffer. It doesn't cause
issue because in the simple TX mode we don't use the header. This patch
makes the header desc point to different buffer.
Signed-off-by: Huawei Xie
---
drivers/net/virtio/virtio_rxtx.c | 2 +-
1 file changed, 1 insertion(+),
CID 107126 (#1 OF 1): Out-of-bounds read
Fixes: 8f972312b8f4 ("vhost: support vhost-user")
Signed-off-by: Huawei Xie
---
lib/librte_vhost/vhost_user/vhost-net-user.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/librte_vhost/vhost_user/vhost-net-user.c
b/lib/librte_vho
Huawei Xie (4):
vhost: Fix Coverity issue with possible array out-of-bounds read
vhost: Fix Coverity issue with missed break in switch
vhost: Fix Coverity issue with missed unlocking
vhost: Fix Coverity issue with logically dead code
lib/librte_vhost/vhost_user/fd_man.c | 4 +++-
The virtio_net_hdr desc all pointed to the same buffer. It doesn't cause
issue because in the simple TX mode we don't use the header. This patch
makes the header desc point to different buffer.
Signed-off-by: Huawei Xie
---
drivers/net/virtio/virtio_rxtx.c | 2 +-
1 file changed, 1 insertion(+),
69 matches
Mail list logo
