> -----Original Message----- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Rahul Lakkireddy > Sent: Friday, December 11, 2015 8:26 AM > To: dev at dpdk.org > Cc: Felix Marti; Kumar Sanghvi; Nirranjan Kirubaharan > Subject: [dpdk-dev] [PATCH] cxgbe: fix unnecessary check for freelist > existence while freeing rxq > > When refilling freelists for the first time and if it fails, the rxq is > freed and returns ENOMEM. There is a check while freeing hardware rxq to > pass freelist context id if the freelist exists or 0xffff otherwise. > The error path is only reached if freelist exists. So, fix is to remove > the useless check for freelist existence. > > Thanks to John McNamara <john.mcnamara at intel.com> for reporting it. > > Coverity issue: 107108 > Fixes: 92c8a63223e5 ("cxgbe: add device configuration and Rx support") > > Signed-off-by: Rahul Lakkireddy <rahul.lakkireddy at chelsio.com> > Signed-off-by: Kumar Sanghvi <kumaras at chelsio.com>
Thanks for updating the Coverity Triage for the issue. Acked-by: John McNamara <john.mcnamara at intel.com>
