If a long name was passed the code would clobber memory with
strcpy.
Signed-off-by: Stephen Hemminger
---
examples/ip_pipeline/app.h | 2 +-
examples/ip_pipeline/init.c | 5 +++--
2 files changed, 4 insertions(+), 3 deletions(-)
diff --git a/examples/ip_pipeline/app.h b/examples/ip_pipeline/ap
Code here checks return from strdup() in only one place in this
whole module, and then does nothing useful by setting one
value that is then cleared. Just remove the check.
Signed-off-by: Stephen Hemminger
---
examples/ip_pipeline/config_parse.c | 3 ---
1 file changed, 3 deletions(-)
diff --gi
Found by Coverity:
Sizeof not portable (SIZEOF_MISMATCH)
suspicious_sizeof: Passing argument &app->cmds[app->n_cmds] of type
cmdline_parse_ctx_t * and argument n_cmds * 8UL /* sizeof
(cmdline_parse_ctx_t *) */
to function memcpy is suspicious.
In this case, sizeof (cmdline_parse_ctx_t *
If name is so long that it fills buffer, then string would not
be null terminated.
Signed-off-by: Stephen Hemminger
---
examples/ip_pipeline/config_parse_tm.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/examples/ip_pipeline/config_parse_tm.c
b/examples/ip_pipeline/con
Coverity found these as dead-code and/or copy-paste bugs.
Signed-off-by: Stephen Hemminger
---
examples/ip_pipeline/config_parse.c | 2 +-
examples/ip_pipeline/config_parse_tm.c | 2 +-
examples/ip_pipeline/pipeline/pipeline_flow_classification.c |
Lots of little trivial bugs/typos here.
Let's not start users off with a bad example.
Stephen Hemminger (5):
examples_ip_pipeline: fix typo's
example_ip_pipeline: avoid strncpy issue
example_ip_pipeline: fix sizeof() on memcpy
examples_ip_pipeline: remove useless code
examples_ip_pipelin
The change will affect on the csum fwd performance.
But I also think the change is necessary, or we cannot use csumonly fwd mode in
a VM.
Signed-off-by: Jijiang Liu
---
app/test-pmd/csumonly.c |6 ++
1 files changed, 6 insertions(+), 0 deletions(-)
diff --git a/app/test-pmd/csumonly.c
Change the vhost sample in order to support and test TSO offload.
Signed-off-by: Jijiang Liu
---
examples/vhost/main.c | 20 ++--
1 files changed, 18 insertions(+), 2 deletions(-)
diff --git a/examples/vhost/main.c b/examples/vhost/main.c
index 1b137b9..482f7af 100644
--- a/ex
Add TSO into supported vhost features
Signed-off-by: Jijiang Liu
---
lib/librte_vhost/virtio-net.c |5 -
1 files changed, 4 insertions(+), 1 deletions(-)
diff --git a/lib/librte_vhost/virtio-net.c b/lib/librte_vhost/virtio-net.c
index b520ec5..2f9ac25 100644
--- a/lib/librte_vhost/virti
Dequeue vhost TSO offload
Signed-off-by: Jijiang Liu
---
lib/librte_vhost/vhost_rxtx.c | 29 -
1 files changed, 28 insertions(+), 1 deletions(-)
diff --git a/lib/librte_vhost/vhost_rxtx.c b/lib/librte_vhost/vhost_rxtx.c
index 0d07338..9adfdb1 100644
--- a/lib/librt
Enqueue TSO4/6 offload.
Signed-off-by: Jijiang Liu
---
drivers/net/virtio/virtio_rxtx.c | 23 +++
1 files changed, 23 insertions(+), 0 deletions(-)
diff --git a/drivers/net/virtio/virtio_rxtx.c b/drivers/net/virtio/virtio_rxtx.c
index c5b53bb..4c2d838 100644
--- a/drivers/
Record virtual address of virtio net header.
Signed-off-by: Jijiang Liu
---
drivers/net/virtio/virtio_ethdev.c |3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/drivers/net/virtio/virtio_ethdev.c
b/drivers/net/virtio/virtio_ethdev.c
index 465d3cd..cb5dfee 100644
--- a/d
The virtual addr for virtio net header need to be recorded.
Signed-off-by: Jijiang Liu
---
drivers/net/virtio/virtqueue.h |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/net/virtio/virtqueue.h b/drivers/net/virtio/virtqueue.h
index 7789411..530f840 100644
--- a/d
Extend the VIRTIO_PMD_GUEST_FEATURES for supporting vhost TSO.
Signed-off-by: Jijiang Liu
---
drivers/net/virtio/virtio_ethdev.h |4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/drivers/net/virtio/virtio_ethdev.h
b/drivers/net/virtio/virtio_ethdev.h
index 9026d42..3a6
The patch set add the negotiation between us-vhost and virtio-net for vhost TSO
feature, and enqueue/dequeue vhost TSO offload, and change vhost sample and
csum application to test these.
Jijiang Liu (8):
add host TSO support in virtio_ethdev.h file
add virtual addr for virtio net header in
2015-08-31 08:59, Neil Horman:
> On Mon, Aug 31, 2015 at 10:23:33AM +, Iremonger, Bernard wrote:
> > The purpose of this RFC is to remove the need for a PCI device driver
> > from Vdev's that that do not use a PCI driver. Removing the PCI driver
> > is implemented in the ethdev changes. I have
2015-08-27 16:40, Bernard Iremonger:
> remove rte_null_pmd and pci_dev.
>
> Signed-off-by: Bernard Iremonger
[...]
> - eth_dev->pci_dev = pci_dev;
> - eth_dev->driver = &rte_null_pmd;
> + eth_dev->pci_dev = NULL;
Simple comment:
Why a driver should reset a PCI field if it does not ca
2015-08-27 16:40, Bernard Iremonger:
> add dev_flags to rte_eth_dev, add macros for dev_flags.
> add numa_node to rte_eth_dev_data.
> use dev_type to distinguish between vdev's and pdev's.
> remove unused RTE_ETH_DEV_MAX.
>
> Signed-off-by: Bernard Iremonger
[...]
> @@ -424,7 +425,10 @@ rte_eth_d
Hi Thomas,
> -Original Message-
> From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com]
> Sent: Monday, August 31, 2015 3:11 PM
> To: Iremonger, Bernard
> Cc: dev at dpdk.org; david.marchand at 6wind.com
> Subject: Re: [RFC PATCH 3/6] null: remove pci device driver
>
> 2015-08-27 16
On 2015/08/31 14:14, Ouyang, Changchun wrote:
>
> +struct pmd_internal {
> + TAILQ_ENTRY(pmd_internal) next;
> + char *dev_name;
> + char *iface_name;
> + unsigned nb_rx_queues;
> + unsigned nb_tx_queues;
> + rte_atomic16_t xfer;
> +
> + struct vhost_queue
> rx_vhost_que
Dne 31.8.2015 v 14:22 Thomas Monjalon napsal(a):
> It does not appear in doxygen (patch welcome) but it is documented.
> Check RTE_PTYPE_* in lib/librte_mbuf/rte_mbuf.h
Thanks! I was looking, but not good enough.
Indeed the defines are there and everything is working again :-)
However, I have no
Chaining/segmenting mbufs can be useful in many places, so make it
global.
Signed-off-by: Simon Kagstrom
Signed-off-by: Johan Faltstrom
---
NOTE! Only compile-tested.
We were looking for packet segmenting functionality in the MBUF API but
didn't find it. This patch moves the implementation, apa
When calculating the size for the table which allocates
the keys, size was calculated wrongly from multiplying
two 32-bit variables, resulting on a 32-bit number,
before casting to 64-bit, so maximum size was 4G.
Fixes: 48a399119619 ("hash: replace with cuckoo hash implementation")
Signed-off-by:
2015-08-31 12:40, Martin Dra?ar:
> Dne 31.8.2015 v 10:56 Thomas Monjalon napsal(a):
> > In order to keep compatibility with your old code, you have to disable
> > RTE_NEXT_ABI in your configuration file (.config).
>
> I have done this and the code works, but because the project is in
> prototype s
Hi,
I am using RSS to get identical hash for both directions of a flow.
Everything is working as it should with the Intel 82599ES, but when I
run the same code with the Intel 82574L, then the hash is not calculated
correctly and returns 0 as a hash value for all flows.
I could use the Toeplitz ha
The patch introduces a new PMD. This PMD is implemented as thin wrapper
of librte_vhost. It means librte_vhost is also needed to compile the PMD.
The PMD can have 'iface' parameter like below to specify a path to connect
to a virtio-net device.
$ ./testpmd -c f -n 4 --vdev 'eth_vhost0,iface=/tmp/s
The patch introduces a new PMD. This PMD is implemented as thin wrapper
of librte_vhost. To work the PMD correctly, below patches are needed.
- [PATCH 1/3] vhost: Fix return value of GET_VRING_BASE message
- [PATCH 2/3] vhost: Fix RESET_OWNER handling not to close callfd
- [PATCH 3/3] vhost: Fi
On 2015/08/29 3:18, Stephen Hemminger wrote:
> On Fri, 28 Aug 2015 12:21:41 +0900
> Tetsuya Mukawa wrote:
>
>> The patch introduces a new PMD. This PMD is implemented as thin wrapper
>> of librte_vhost. It means librte_vhost is also needed to compile the PMD.
>> The PMD can have 'iface' parameter
Hi Keith, Neil,
> >> > On Thu, Aug 27, 2015 at 04:40:35PM +0100, Bernard Iremonger wrote:
> >> > > There is a dummy pci driver in the vdev PMD's at present.
> >> > > This RFC proposes to remove the pci driver from the vdev PMD's.
> >> > > Changes have been made to librte_ether to handle vdevs wh
> From: Navneet Rao [mailto:navneet.rao at oracle.com]
> Sent: Friday, August 28, 2015 11:11 PM
> To: De Lara Guarch, Pablo; Wu, Jingjing; Mcnamara, John; dev at dpdk.org
> Subject: RE: [dpdk-dev] flow_director_filter error!!
>
> Hi John et al:
> I am using the X540, and setting it up to receive
2015-08-31 10:03, Martin Dra?ar:
> I just tried to upgrade to 2.1.0 and suddenly my code stopped compiling,
> because of using PKT_RX_IPV4_HDR feature flag and the like. In the
> rte_mbuf.h there is this code:
>
> > #ifndef RTE_NEXT_ABI
> > #define PKT_RX_IPV4_HDR (1ULL << 5) /**< RX packet
Hi John,
> -Original Message-
> From: John W. Linville [mailto:linville at tuxdriver.com]
> Sent: Friday, August 28, 2015 6:52 PM
> To: Iremonger, Bernard
> Cc: dev at dpdk.org
> Subject: Re: [dpdk-dev] [RFC PATCH 0/6] remove pci driver from vdevs
>
> On Fri, Aug 28, 2015 at 08:15:47AM +0
Hi,
I just tried to upgrade to 2.1.0 and suddenly my code stopped compiling,
because of using PKT_RX_IPV4_HDR feature flag and the like. In the
rte_mbuf.h there is this code:
> #ifndef RTE_NEXT_ABI
> #define PKT_RX_IPV4_HDR (1ULL << 5) /**< RX packet with IPv4 header. */
> #define PKT_RX_IP
On Mon, 31 Aug 2015 01:38:44 +
"Ouyang, Changchun" wrote:
> Hi Stephen,
>
> > -Original Message-
> > From: Stephen Hemminger [mailto:stephen at networkplumber.org]
> > Sent: Saturday, August 29, 2015 12:24 AM
> > To: Xie, Huawei; Ouyang, Changchun
> > Cc: dev at dpdk.org; Stephen Hem
HW requires it regardless the presence of the VLAN tag in the received frame.
Otherwise Rx frames are being filtered out on the MTU-4 boundary.
Signed-off-by: Vlad Zolotarov
---
drivers/net/i40e/i40e_rxtx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/i40e/i40e
On 08/30/15 16:03, Vlad Zolotarov wrote:
> Hi, I have the most strange issue on a setup of 2 pairs of connected
> back to back XL710 cards.
> It seems that frames above 1510 bytes are being filtered out by an
> i40e PMD receiver.
> The same setup works perfectly when I use Linux drivers on both
On Mon, Aug 31, 2015 at 10:23:33AM +, Iremonger, Bernard wrote:
> Hi John,
>
> > -Original Message-
> > From: John W. Linville [mailto:linville at tuxdriver.com]
> > Sent: Friday, August 28, 2015 6:52 PM
> > To: Iremonger, Bernard
> > Cc: dev at dpdk.org
> > Subject: Re: [dpdk-dev] [RF
On Mon, Aug 31, 2015 at 11:21:46AM +, Iremonger, Bernard wrote:
> Hi Keith, Neil,
>
>
>
> > >> > On Thu, Aug 27, 2015 at 04:40:35PM +0100, Bernard Iremonger wrote:
> > >> > > There is a dummy pci driver in the vdev PMD's at present.
> > >> > > This RFC proposes to remove the pci driver from
> -Original Message-
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Tetsuya Mukawa
> Sent: Friday, August 28, 2015 11:22 AM
> To: dev at dpdk.org
> Cc: ann.zhuangyanying at huawei.com
> Subject: [dpdk-dev] [RFC PATCH] vhost: Add VHOST PMD
>
> The patch introduces a new PMD. Th
> -Original Message-
> From: Stephen Hemminger [mailto:stephen at networkplumber.org]
> Sent: Saturday, August 29, 2015 12:24 AM
> To: Xie, Huawei; Ouyang, Changchun
> Cc: dev at dpdk.org; Stephen Hemminger; Stephen Hemminger
> Subject: [PATCH 1/3] virtio: don't report link state feature
Hi Stephen,
> -Original Message-
> From: Stephen Hemminger [mailto:stephen at networkplumber.org]
> Sent: Saturday, August 29, 2015 12:24 AM
> To: Xie, Huawei; Ouyang, Changchun
> Cc: dev at dpdk.org; Stephen Hemminger
> Subject: [PATCH 2/3] virtio: fix Coverity unsigned warnings
>
> Ther
> -Original Message-
> From: Stephen Hemminger [mailto:stephen at networkplumber.org]
> Sent: Saturday, August 29, 2015 12:24 AM
> To: Xie, Huawei; Ouyang, Changchun
> Cc: dev at dpdk.org; Stephen Hemminger
> Subject: [PATCH 3/3] virtio: fix possible NULL dereference
>
> Found by Coverit
42 matches
Mail list logo
