Hi Thomas,
> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com]
> Sent: Monday, August 31, 2015 3:11 PM
> To: Iremonger, Bernard
> Cc: dev at dpdk.org; david.marchand at 6wind.com
> Subject: Re: [RFC PATCH 3/6] null: remove pci device driver
>
> 2015-08-27 16:40, Bernard Iremonger:
> > remove rte_null_pmd and pci_dev.
> >
> > Signed-off-by: Bernard Iremonger <bernard.iremonger at intel.com>
> [...]
> > - eth_dev->pci_dev = pci_dev;
> > - eth_dev->driver = &rte_null_pmd;
> > + eth_dev->pci_dev = NULL;
>
> Simple comment:
> Why a driver should reset a PCI field if it does not care about PCI?
Setting the pci_dev field to NULL, was needed in an earlier internal revision
of the patch set.
This line is no longer needed and can be removed.
The dev_type field of struct rte_eth_dev{} is now used instead in rte_ethdev.c.
Regards,
Bernard.
