[dpdk-dev] DPDK: Proposal for a patch patch-test integration tree

2015-05-27 Thread Vincent JARDIN
On 27/05/2015 22:48, Thomas F Herbert wrote: > Work Flow and Process: > > All patches will be taken from from public submissions to dpdk-dev.org > scraped from dpdk patchwork. Patches will be applied to the patch-test > tree and tested against HEAD as they are received. The feedback from the > test

[dpdk-dev] Question about worker assignment in load balancer implementaion in DPDK library example.

2015-05-27 Thread 최익성
Dear DPDK experts. I have a question about load balancer implementaion in DPDK library example. (dpdk-2.0.0/examples/load_balancer) I read from load balancer application user guide that The worker lcore to handle the current packet is determined by reading a predefined 1 byte field from the inp

[dpdk-dev] [PATCH v3] pipeline: add statistics for librte_pipeline

2015-05-27 Thread Rajagopalan Sivaramakrishnan
> > You also reiterate that you would like to have the stats always enabled. You > can definitely do this, it is one of the available choices, but why not also > accommodate the users that want to pick the opposite choice? Why force > apps to spend cycles on stats if the app either does not want t

[dpdk-dev] [PATCH] ixgbe: fix checking for tx_free_thresh

2015-05-27 Thread Zoltan Kiss
This check doesn't do what's required by rte_eth_tx_burst: "When the number of previously sent packets reached the "minimum transmit packets to free" threshold" This can cause problems when txq->tx_free_thresh + [number of elements in the pool] < txq->nb_tx_desc. Signed-off-by: Zoltan Kiss ---

[dpdk-dev] [PATCH] kni: Use utsrelease.h to determine Ubuntu kernel version

2015-05-27 Thread Stephen Hemminger
This ugly and fast becoming unmaintainable and ridiculous. KNI needs to get out of being a bunch of out of tree code chasing the kernel API tail lights and become something stable and submitted upstream. On Wed, May 27, 2015 at 4:45 AM, Simon Kagstrom < simon.kagstrom at netinsight.net> wrote: >

[dpdk-dev] DPDK: Proposal for a patch patch-test integration tree

2015-05-27 Thread Thomas F Herbert
On 5/27/15 5:06 PM, Matthew Hall wrote: > On Wed, May 27, 2015 at 04:48:47PM -0400, Thomas F Herbert wrote: >> Submissions of test suites will be encouraged from the community including >> testing against compilers, architectures, devices, options etc. The purpose >> is to try to evolve to widen

[dpdk-dev] [RFC PATCH V2 2/2] drivers/net/virtio: check vq parameter

2015-05-27 Thread Bernard Iremonger
If vq is NULL, there is a segmentation fault. Signed-off-by: Bernard --- drivers/net/virtio/virtqueue.c | 14 -- 1 files changed, 8 insertions(+), 6 deletions(-) diff --git a/drivers/net/virtio/virtqueue.c b/drivers/net/virtio/virtqueue.c index 8a3005f..7f60e3e 100644 --- a/driver

[dpdk-dev] [RFC PATCH V2 1/2] drivers/net/virtio: add support for PCI Port Hotplug

2015-05-27 Thread Bernard Iremonger
This patch depends on the Port Hotplug Framework. It implements the eth_dev_uninit_t() function for virtio pmd. Changes in V2: Rebase to use new drivers directory. Reuse memzones. Signed-off-by: Bernard Iremonger --- drivers/net/virtio/virtio_ethdev.c | 83 +---

[dpdk-dev] [PATCH v8 05/11] eal/linux: add interrupt vectors handling on VFIO

2015-05-27 Thread Liang, Cunming
On 5/23/2015 4:21 AM, Stephen Hemminger wrote: > On Thu, 21 May 2015 16:55:57 +0800 > Cunming Liang wrote: > >> This patch does below: >> - Create VFIO eventfds for each interrupt vector (move to next) >> - Assign per interrupt vector's eventfd to VFIO by ioctl >> >> Signed-off-by: Danny Zho

[dpdk-dev] [PATCH 2/5] cxgbe: add cxgbe poll mode driver.

2015-05-27 Thread Rahul Lakkireddy
On Tue, May 26, 2015 at 22:49:08 -0700, Thomas Monjalon wrote: > 2015-05-23 11:23, Rahul Lakkireddy: > > We need to rebase anyway since PMDs now seem to have moved to > > drivers/net directory. > > Yes. And the subdirectory should probably be renamed base/. Yes, we will do this. > > It would be

[dpdk-dev] [PATCH 3/5] doc: add cxgbe PMD documentation under doc/guides/nics/cxgbe.rst

2015-05-27 Thread Rahul Lakkireddy
On Wed, May 27, 2015 at 07:38:50 +0200, Thomas Monjalon wrote: > 2015-05-22 18:54, Rahul Lakkireddy: > > Adds cxgbe poll mode driver documentation under the usual doc/guides/nics/ > > directory with the rest of the drivers. The documentation covers cxgbe > > implementation details, features and li

[dpdk-dev] DPDK: Proposal for a patch patch-test integration tree

2015-05-27 Thread Thomas F Herbert
This is a proposal to create a patch-test dpdk tree. I welcome feedback from the dpdk community on this proposal. This tree will consist of pre-integrated patches submitted to dpdk-dev mailing list. The purpose of this tree is to help reduce the effort in reviewing patches and providing feedbac

[dpdk-dev] [PATCH 1/4] kni: add function to query the name of a kni object

2015-05-27 Thread Bruce Richardson
On Wed, May 27, 2015 at 04:15:49PM +0200, Marc Sune wrote: > > > On 27/05/15 15:55, Bruce Richardson wrote: > >On Wed, May 27, 2015 at 03:52:34PM +0200, Marc Sune wrote: > >> > >>On 27/05/15 15:47, Bruce Richardson wrote: > >>>When a KNI object is created, a name is assigned to it which is stored

[dpdk-dev] [PATCH 1/4] kni: add function to query the name of a kni object

2015-05-27 Thread Marc Sune
On 27/05/15 15:55, Bruce Richardson wrote: > On Wed, May 27, 2015 at 03:52:34PM +0200, Marc Sune wrote: >> >> On 27/05/15 15:47, Bruce Richardson wrote: >>> When a KNI object is created, a name is assigned to it which is stored >>> internally. There is also an API function to look up a KNI object

[dpdk-dev] [PATCH 1/4] kni: add function to query the name of a kni object

2015-05-27 Thread Marc Sune
On 27/05/15 15:47, Bruce Richardson wrote: > When a KNI object is created, a name is assigned to it which is stored > internally. There is also an API function to look up a KNI object by > name, but there is no API to query the current name of an existing > KNI object. This patch adds just such a

[dpdk-dev] proposal: raw packet send and receive API for PMD driver

2015-05-27 Thread Venkatesan, Venky
> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Wiles, Keith > Sent: Wednesday, May 27, 2015 7:51 AM > To: Lin XU; dev at dpdk.org > Subject: Re: [dpdk-dev] proposal: raw packet send and receive API for PMD > driver > > > > On 5/26/15, 11:18 PM, "Lin XU" w

[dpdk-dev] [PATCH v2] eal: Allow combining -m and --no-huge

2015-05-27 Thread Simon Kagstrom
On Wed, 27 May 2015 09:06:46 -0400 Thomas F Herbert wrote: > I just tried applying v2 of the patch to master: > git apply ../patches/eal_common_options.patch > error: patch failed: lib/librte_eal/common/eal_common_options.c:850 > error: lib/librte_eal/common/eal_common_options.c: patch does not ap

[dpdk-dev] The use of --log-level and its default state

2015-05-27 Thread Wiles, Keith
Hi Everyone, Sorry, if this has been covered already. I would like to have the log-level default changed to not log everything, but the user needs to enable the log messages if he needs to see more information. Normally applications or systems are not so verbose, but if needed the user enables th

[dpdk-dev] [PATCH 1/4] kni: add function to query the name of a kni object

2015-05-27 Thread Bruce Richardson
On Wed, May 27, 2015 at 03:52:34PM +0200, Marc Sune wrote: > > > On 27/05/15 15:47, Bruce Richardson wrote: > >When a KNI object is created, a name is assigned to it which is stored > >internally. There is also an API function to look up a KNI object by > >name, but there is no API to query the c

[dpdk-dev] [PATCH 1/4] kni: add function to query the name of a kni object

2015-05-27 Thread Bruce Richardson
On Wed, May 27, 2015 at 02:47:49PM +0100, Bruce Richardson wrote: > When a KNI object is created, a name is assigned to it which is stored > internally. There is also an API function to look up a KNI object by > name, but there is no API to query the current name of an existing > KNI object. This p

[dpdk-dev] proposal: raw packet send and receive API for PMD driver

2015-05-27 Thread Wiles, Keith
On 5/26/15, 11:18 PM, "Lin XU" wrote: >I think it is very important to decouple PMD driver with DPDK framework. > (1) Currently, the rte_mbuf struct is too simple and hard to support >complex application such as IPSEC, flow control etc. This key struct >should be extendable to support custome

[dpdk-dev] [PATCH 1/4] kni: add function to query the name of a kni object

2015-05-27 Thread Bruce Richardson
When a KNI object is created, a name is assigned to it which is stored internally. There is also an API function to look up a KNI object by name, but there is no API to query the current name of an existing KNI object. This patch adds just such an API. Signed-off-by: Bruce Richardson --- lib/lib

[dpdk-dev] Small request for patch review in DPDK

2015-05-27 Thread Wiles, Keith
On 5/27/15, 12:59 AM, "Simon K?gstr?m" wrote: >Hi! > >As a well-meaning outsider submitting small patches to DPDK, I'd very >much appreciate help from the community with review and comments. Since >I'm a DPDK newbie, the patches might be incorrect or wrong in some other >way, so I think it's ev

[dpdk-dev] [PATCH] kni: Use utsrelease.h to determine Ubuntu kernel version

2015-05-27 Thread Simon Kagstrom
/proc/version_signature is the version for the host machine, but in e.g., chroots, this does not need to match that DPDK is built for. Use utsrelease.h from the kernel sources instead and fake the upload version. Signed-off-by: Simon Kagstrom Signed-off-by: Johan Faltstrom --- lib/librte_eal/li

[dpdk-dev] [PATCH v2] eal: Allow combining -m and --no-huge

2015-05-27 Thread Mcnamara, John
> -Original Message- > From: Thomas F Herbert [mailto:therbert at redhat.com] > Sent: Wednesday, May 27, 2015 2:07 PM > To: Simon Kagstrom; dev at dpdk.org; david.marchand at 6wind.com; Mcnamara, > John > Subject: Re: [dpdk-dev] [PATCH v2] eal: Allow combining -m and --no-huge > > > >

[dpdk-dev] [PATCH v2] eal: Allow combining -m and --no-huge

2015-05-27 Thread Simon Kagstrom
Needed to run as non-root but with higher memory allocations, and removes a constraint on no-huge mode being limited to 64M. A usage example is if running with file input with the pcap PMD, which can be done as non-root after this patch via e.g., ./test-dpdk --no-huge -m 1024 -l 0,1 -n3 --vdev

[dpdk-dev] [PATCH v2 1/2] Added ETH_SPEED_CAP bitmap in rte_eth_dev_info

2015-05-27 Thread Marc Sune
On 27/05/15 06:02, Thomas Monjalon wrote: > Hi Marc, > > 2015-05-26 21:50, Marc Sune: >> Added constants and bitmap to struct rte_eth_dev_info to be used by PMDs. >> >> Signed-off-by: Marc Sune > [...] >> +/** >> + * Device supported speeds >> + */ >> +#define ETH_SPEED_CAP_NOT_PHY (0) /*

[dpdk-dev] [PATCH 5/5] rte_sched: allow reading without clearing

2015-05-27 Thread Stephen Hemminger
The rte_sched statistics API should allow reading statistics without clearing. Make auto-clear optional. In this version, this is handled by deprecating the old API and adding a new one. Signed-off-by: Stephen Hemminger --- app/test/test_sched.c | 4 +-- lib/librte_sched/rte_sc

[dpdk-dev] [PATCH 4/5] rte_sched: hide structure of port hierarchy

2015-05-27 Thread Stephen Hemminger
Right now the scheduler hierarchy is encoded as a bitfield that is visible as part of the ABI. This creates an barrier limiting future expansion of the hierarchy. As a transistional step. hide the actual layout of the hierarchy and mark the exposed structure as deprecated. This will allow for expa

[dpdk-dev] [PATCH 3/5] rte_sched: use correct log level

2015-05-27 Thread Stephen Hemminger
The setup messages should be at DEBUG level since they are not important for normal operation of system. The messages about problems should be at NOTICE or ERR level. Signed-off-by: Stephen Hemminger --- lib/librte_sched/rte_sched.c | 15 +-- 1 file changed, 9 insertions(+), 6 deleti

[dpdk-dev] [PATCH 2/5] rte_sched: don't put tabs in log messages

2015-05-27 Thread Stephen Hemminger
From: Stephen Hemminger syslog does not like tabs in log messages; tab gets translated to #011 Signed-off-by: Stephen Hemminger --- lib/librte_sched/rte_sched.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/lib/librte_sched/rte_sched.c b/lib/librte_sched/rt

[dpdk-dev] [PATCH 1/5] rte_sched: make RED optional at runtime

2015-05-27 Thread Stephen Hemminger
From: Stephen Hemminger Want to be able to build with RTE_SCHED_RED enabled but allow disabling RED on a per-queue basis at runtime. RED is disabled unless min/max thresholds set. Signed-off-by: Stephen Hemmminger --- lib/librte_sched/rte_sched.c | 9 + 1 file changed, 9 insertions(+)

[dpdk-dev] [PATCH v4 0/5] rte_sched: cleanup and API enhancements

2015-05-27 Thread Stephen Hemminger
This fixes some small issues with rte_sched API and sets stage for enhancements in later release. Unfortunately, several things can not be done now because of the ABI rules. Stephen Hemminger (5): rte_sched: make RED optional at runtime rte_sched: don't put tabs in log messages rte_sched: us

[dpdk-dev] [PATCH] vhost: enable live migration

2015-05-27 Thread Huawei Xie
When we migrate VM, without this feature, qemu will report error: "migrate: Migration disabled: vhost lacks VHOST_F_LOG_ALL feature". Signed-off-by: Krishna Murthy --- lib/librte_vhost/virtio-net.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/lib/librte_vhost/virtio-net

[dpdk-dev] [PATCH v2 2/2] Filling speed capability bitmaps in the PMDs

2015-05-27 Thread Marc Sune
On 26/05/15 23:20, Igor Ryzhov wrote: > Hello, Marc! > > You swapped values for X710 and XL710 - you use 1G and 10G for XL710, 10G and > 40G for X710. Thanks, I will fix that in v3. This is why I was saying in the RFC patch that it needed to be carefully reviewed. marc > > Best regards, > Ig

[dpdk-dev] [PATCH] ixgbe: fall back to non-vector rx

2015-05-27 Thread Ananyev, Konstantin
Hi Eric, > -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Eric Kinzie > Sent: Tuesday, May 26, 2015 4:52 PM > To: dev at dpdk.org > Subject: [dpdk-dev] [PATCH] ixgbe: fall back to non-vector rx > > The ixgbe driver refuses to receive any packets when vector r

[dpdk-dev] [PATCH v2] eal: Allow combining -m and --no-huge

2015-05-27 Thread Thomas F Herbert
On 5/27/15 9:29 AM, Simon Kagstrom wrote: > On Wed, 27 May 2015 09:06:46 -0400 > Thomas F Herbert wrote: >> I just tried applying v2 of the patch to master: >> git apply ../patches/eal_common_options.patch >> error: patch failed: lib/librte_eal/common/eal_common_options.c:850 >> error: lib/librt

[dpdk-dev] [PATCH] eal_common_options: Allow combining -m and --no-huge

2015-05-27 Thread Simon Kågström
Hi John and David! On 2015-05-27 09:29, Mcnamara, John wrote:> > Minor comments. > > * Without mem_parsed the () aren't required and the conditional will fit on one line. > > * The section prefix on the first/subject line should be "eal:" and the commit message/justification could be clearer. It w

[dpdk-dev] [PATCHv2] mempool: fix pages computation to determine number of objects

2015-05-27 Thread Adrien Mazarguil
On Wed, May 27, 2015 at 01:41:09AM +0100, Konstantin Ananyev wrote: > v2: > - As suggested in comments use slightly different approach for the fix. > > In rte_mempool_obj_iter(), when element boundary coincides with page boundary, > even if a single page is required per object, a loop checks that

[dpdk-dev] [PATCH] eal_common_options: Allow combining -m and --no-huge

2015-05-27 Thread David Marchand
Hello Simon, On Wed, May 20, 2015 at 2:24 PM, Simon Kagstrom < simon.kagstrom at netinsight.net> wrote: > Needed to run as non-root but with higher memory allocations. > > Signed-off-by: Simon Kagstrom > Signed-off-by: Johan Faltstrom > --- > lib/librte_eal/common/eal_common_options.c | 4 ++--

[dpdk-dev] [PATCHv3] mempool: fix pages computation to determine number of objects

2015-05-27 Thread Konstantin Ananyev
v3: - Fixed typo in the commit message. v2: - As suggested in comments use slightly different approach for the fix. In rte_mempool_obj_iter(), when element boundary coincides with page boundary, even if a single page is required per object, a loop checks that the next page is contiguous and drops

[dpdk-dev] [PATCH v2] eal: Allow combining -m and --no-huge

2015-05-27 Thread Thomas F Herbert
On 5/27/15 5:30 AM, Simon Kagstrom wrote: > Needed to run as non-root but with higher memory allocations, and > removes a constraint on no-huge mode being limited to 64M. A usage > example is if running with file input with the pcap PMD, which can be > done as non-root after this patch via e.g.,

[dpdk-dev] Small request for patch review in DPDK

2015-05-27 Thread Simon Kågström
Hi! As a well-meaning outsider submitting small patches to DPDK, I'd very much appreciate help from the community with review and comments. Since I'm a DPDK newbie, the patches might be incorrect or wrong in some other way, so I think it's even more important with reviews for people like me. But

[dpdk-dev] [PATCH 3/5] doc: add cxgbe PMD documentation under doc/guides/nics/cxgbe.rst

2015-05-27 Thread Thomas Monjalon
2015-05-22 18:54, Rahul Lakkireddy: > Adds cxgbe poll mode driver documentation under the usual doc/guides/nics/ > directory with the rest of the drivers. The documentation covers cxgbe > implementation details, features and limitations, prerequisites, > configuration, > and a sample application

[dpdk-dev] [PATCH] eal_common_options: Allow combining -m and --no-huge

2015-05-27 Thread Mcnamara, John
> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Simon Kagstrom > Sent: Wednesday, May 20, 2015 1:24 PM > To: dev at dpdk.org > Subject: [dpdk-dev] [PATCH] eal_common_options: Allow combining -m and -- > no-huge > > Needed to run as non-root but with higher

[dpdk-dev] [PATCH v8 01/11] eal/linux: add interrupt vectors support in intr_handle

2015-05-27 Thread Neil Horman
On Fri, May 22, 2015 at 09:52:06AM -0700, Stephen Hemminger wrote: > On Fri, 22 May 2015 00:05:36 + > Neil Horman wrote: > > > On Thu, May 21, 2015 at 11:14:00AM -0700, Stephen Hemminger wrote: > > > On Thu, 21 May 2015 13:58:46 -0400 > > > Neil Horman wrote: > > > > > > > On Thu, May 21, 2

[dpdk-dev] [PATCH v3] pipeline: add statistics for librte_pipeline ports and tables

2015-05-27 Thread Thomas Monjalon
2015-05-26 07:57, Stephen Hemminger: > On Tue, 26 May 2015 15:39:18 +0200 > Maciej Gajdzica wrote: > > > +#if RTE_LOG_LEVEL == RTE_LOG_DEBUG > > +#define RTE_PIPELINE_STATS_ADD(counter, val) \ > > + ({ (counter) += (val); }) > > + > > +#define RTE_PIPELINE_STATS_ADD_M(counter, mask) \ > > + (

[dpdk-dev] [PATCH v2 1/2] Added ETH_SPEED_CAP bitmap in rte_eth_dev_info

2015-05-27 Thread Thomas Monjalon
Hi Marc, 2015-05-26 21:50, Marc Sune: > Added constants and bitmap to struct rte_eth_dev_info to be used by PMDs. > > Signed-off-by: Marc Sune [...] > +/** > + * Device supported speeds > + */ > +#define ETH_SPEED_CAP_NOT_PHY(0) /*< No phy media > */ Why not starting with lower values?

[dpdk-dev] proposal: raw packet send and receive API for PMD driver

2015-05-27 Thread Lin XU
I think it is very important to decouple PMD driver with DPDK framework. (1) Currently, the rte_mbuf struct is too simple and hard to support complex application such as IPSEC, flow control etc. This key struct should be extendable to support customer defined management header and hardware of

[dpdk-dev] Intel fortville not working with multi-segment

2015-05-27 Thread Zhang, Helin
Hi Nissim Sorry for late reply! Today I got a ready environment, and tried the latest DPDK code (on master branch) on my environment, it works well. So could you help to try the latest code (R2.0 +) on your environment again, to see if the issue is still there or not? Regards, Helin > -Ori

[dpdk-dev] [PATCHv2] mempool: fix pages computation to determine number of objects

2015-05-27 Thread Konstantin Ananyev
v2: - As suggested in comments use slightly different approach for the fix. In rte_mempool_obj_iter(), when element boundary coincides with page boundary, even if a single page is required per object, a loop checks that the next page is contiguous and drops the first oneo therwise. This commit che

[dpdk-dev] [PATCH 2/5] mbuf: use the reserved 16 bits for double vlan

2015-05-27 Thread Zhang, Helin
> -Original Message- > From: Ananyev, Konstantin > Sent: Tuesday, May 26, 2015 11:46 PM > To: Stephen Hemminger > Cc: Zhang, Helin; dev at dpdk.org > Subject: RE: [dpdk-dev] [PATCH 2/5] mbuf: use the reserved 16 bits for > double vlan > > > > > -Original Message- > > From: Step

[dpdk-dev] [PATCH 1/2] mempool: fix returned value on 64 bit after counting objects

2015-05-27 Thread Ananyev, Konstantin
> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Adrien Mazarguil > Sent: Monday, May 25, 2015 5:28 PM > To: dev at dpdk.org > Subject: [dpdk-dev] [PATCH 1/2] mempool: fix returned value on 64 bit after > counting objects > > rte_mempool_xmem_usage()'s retu

[dpdk-dev] [PATCH v2 2/2] Filling speed capability bitmaps in the PMDs

2015-05-27 Thread Igor Ryzhov
Hello, Marc! You swapped values for X710 and XL710 - you use 1G and 10G for XL710, 10G and 40G for X710. Best regards, Igor > 26 ??? 2015 ?., ? 22:50, Marc Sune ???(?): > > Added speed capabilities to all pmds supporting physical NICs: > > * e1000 > * ixgbe > * i40 > * mlx4 > * fm10k >