Hi John and David! On 2015-05-27 09:29, Mcnamara, John wrote:> > Minor comments. > > * Without mem_parsed the () aren't required and the conditional will fit on one line. > > * The section prefix on the first/subject line should be "eal:" and the commit message/justification could be clearer. It would be worth doing a "git log" on the file and following the previous conventions for commit message on that component/file.
OK, I'll fix these issues. On 2015-05-27 09:43, David Marchand wrote: > Well, I asked some question last time : > http://dpdk.org/ml/archives/dev/2015-March/015867.html > > This patch looks good but since I don't use this --no-huge that often, I > would like to know how you tested this. I used the pcap PMD driver with file input, basically ./test-dpdk --no-huge -m 1024 -l 0,1 -n3 --vdev 'eth_pcap0,rx_pcap=/tmp/eth-out.pcap,tx_pcap=/tmp/eth0.pcap' this patch allows me to run this as myself (i.e., not root) > And please, when resending a patch, it should be marked as vX. Sorry about that, I stashed it and forgot about it for a while, and then just re-made the commit. (Not only that: I lost the reply in the flood of DPDK mails, so sort of what I was complaining about in the first place!) Anyway, I'll update the patch and resend. // Simon
