[dpdk-dev] [PATCH v2 33/33] i40e/base: modifications for future use

2015-04-30 Thread Helin Zhang
Miscellaneous modifications are added as follows for future use. - Admin queue command opcodes - struct i40e_aqc_arp_proxy_data - struct i40e_aq_set_phy_config - struct i40e_aqc_nvm_config_data_immediate_field - struct i40e_aqc_oem_param_change - struct i40e_aqc_opc_oem_ocsd_initialize - struct i40

[dpdk-dev] [PATCH v2 32/33] i40e/base: rework of structures and macros for future use

2015-04-30 Thread Helin Zhang
Several structures as follows were modified for future use. - struct i40e_link_status - struct i40e_nvm_info - struct i40e_veb_tc_stats In addition, shadow RAM macros and enum were modified for future use as well. Signed-off-by: Helin Zhang --- lib/librte_pmd_i40e/i40e/i40e_type.h | 28 +

[dpdk-dev] [PATCH v2 31/33] i40e/base: add more virtual channel operations for future use

2015-04-30 Thread Helin Zhang
Virtual channel operations of I40E_VIRTCHNL_OP_EVENT and I40E_VIRTCHNL_OP_CONFIG_RSS are added for future use. Signed-off-by: Helin Zhang --- lib/librte_pmd_i40e/i40e/i40e_virtchnl.h | 41 1 file changed, 20 insertions(+), 21 deletions(-) v2 changes: Removed any

[dpdk-dev] [PATCH v2 30/33] i40e/base: future proof some sizeof calls

2015-04-30 Thread Helin Zhang
Make sure the sizeof() calls are taking the size of the actual struct that we care about. By using the pointer variable, it will always get the right struct size, even if the variable type changes sometime in the future. Signed-off-by: Helin Zhang --- lib/librte_pmd_i40e/i40e/i40e_common.c | 44

[dpdk-dev] [PATCH v2 29/33] i40e/base: set FLAG_RD when sending driver version to FW

2015-04-30 Thread Helin Zhang
When sending driver version to FW, FLAG_SI is not needed as it is done as part of i40e_fill_default_descriptor function call, and it should be replaced by FLAG_BUF and FLAG_RD. Signed-off-by: Helin Zhang --- lib/librte_pmd_i40e/i40e/i40e_common.c | 2 +- 1 file changed, 1 insertion(+), 1 deletio

[dpdk-dev] [PATCH v2 28/33] i40e/base: support for iSCSI capability

2015-04-30 Thread Helin Zhang
Add parsing and reporting of iSCSI capability for a given device or function. Signed-off-by: Helin Zhang --- lib/librte_pmd_i40e/i40e/i40e_common.c | 5 + lib/librte_pmd_i40e/i40e/i40e_type.h | 1 + 2 files changed, 6 insertions(+) diff --git a/lib/librte_pmd_i40e/i40e/i40e_common.c b/li

[dpdk-dev] [PATCH v2 27/33] i40e/base: add AOC phy types to case statement in get_media_type

2015-04-30 Thread Helin Zhang
Add the 10G and 40G AOC phy types to the case statement in get_media_type so that the correct information gets reported back to the user. Signed-off-by: Helin Zhang --- lib/librte_pmd_i40e/i40e/i40e_common.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/lib/librte_pmd_i40e/i40e/i40e_comm

[dpdk-dev] [PATCH v2 26/33] i40e/base: Reassign incorrect PHY type as a workaround for a FW issue

2015-04-30 Thread Helin Zhang
The FW for SW3E is incorrectly reporting a breakout cable as PHY type 0x3 when it should be 0x16 (I40E_PHY_TYPE_10GBASE_SFPP_CU). As this is supposed to be fixed in the next FW version (FW versions >= 4.4), if we get this value back from FW and the version is < 4.4, reassign it to I40E_PHY_TYPE_10G

[dpdk-dev] [PATCH v2 25/33] i40e/base: find partition_id in npar mode, and disable FCOE by default

2015-04-30 Thread Helin Zhang
In NPAR mode the driver instance might be controlling the base partition or one of the other "fake" PFs. There are some things that can only be done by the base partition, aka partition_id 1. This code does a bit of work to find how many partitions are there in per port and what is the current part

[dpdk-dev] [PATCH v2 24/33] i40e/base: get pf_id from HW rather than PCI function

2015-04-30 Thread Helin Zhang
Getting the pf_id from the function number was a good place to start, but when the PF was setup in pass-thru mode, the PCI bus/device/function was virtualized and the number in the VM is different from the number in the bare metal. This caused HW configuration issues when the wrong pf_id was used t

[dpdk-dev] [PATCH v2 23/33] i40e/base: clean up sparse complaint in i40e_debug_aq

2015-04-30 Thread Helin Zhang
A sparse complaint in i40e_debug_aq in a funky buffer write goes away by straightening out the code out to something less convoluted. Signed-off-by: Helin Zhang --- lib/librte_pmd_i40e/i40e/i40e_common.c | 56 ++ 1 file changed, 30 insertions(+), 26 deletions(-)

[dpdk-dev] [PATCH v2 22/33] i40e/base: update of get/set LED functions

2015-04-30 Thread Helin Zhang
As it is requried to blink the LEDs only, it should ignore the activity LEDs. Also a fix is added to clear the GPIO blink field specifically. Signed-off-by: Helin Zhang --- lib/librte_pmd_i40e/i40e/i40e_common.c | 37 +++--- 1 file changed, 34 insertions(+), 3 deletio

[dpdk-dev] [PATCH v2 21/33] i40e/base: add new interfaces for future use

2015-04-30 Thread Helin Zhang
Four new interfaces are added for future use, as follows, together with their relevant strucure and macro definitions. - i40e_aq_read_nvm_config() - i40e_aq_write_nvm_config() - i40e_aq_set_lldp_mib() - i40e_read_pba_string() In addition, removed i40e_read_nvm_srrd() as needed. Signed-off-by: Heli

[dpdk-dev] [PATCH v2 20/33] i40e/base: i40e_aq_get_link_info() should be used directly

2015-04-30 Thread Helin Zhang
As i40e_update_link_info() is just a simple wrapper of AQ command interface of i40e_aq_get_link_info(), the AQ command interface should be used directly. Signed-off-by: Helin Zhang --- lib/librte_pmd_i40e/i40e/i40e_common.c| 34 ++- lib/librte_pmd_i40e/i40e/i40e_p

[dpdk-dev] [PATCH v2 19/33] i40e/base: enhancements on adminq init and sending asq command

2015-04-30 Thread Helin Zhang
The timeout of ASQ command is enlarged from 100 ms to 250 ms to wait longer time for the response. nvm_busy is not needed anymore. Also nvm_release_on_done and nvmupd_state will be set during adminq init. Signed-off-by: Helin Zhang --- lib/librte_pmd_i40e/i40e/i40e_adminq.c | 21 ++--

[dpdk-dev] [PATCH v2 18/33] i40e/base: grab NVM devstarter version not image version

2015-04-30 Thread Helin Zhang
The NVM image version has useful data but it is a per image version, and every image can have a different one. While for the dev starter version, all the images for release will have the same version. So it would be better to use dev starter version number. Signed-off-by: Helin Zhang --- lib/lib

[dpdk-dev] [PATCH v2 17/33] i40e/base: define and use i40e_is_vf()

2015-04-30 Thread Helin Zhang
This patch is useful for future expansion when new VF MAC types get added. It also helps with cleaning up VF driver flow. Signed-off-by: Helin Zhang --- lib/librte_pmd_i40e/i40e/i40e_adminq.c | 7 ++- lib/librte_pmd_i40e/i40e/i40e_type.h | 5 + 2 files changed, 11 insertions(+), 1 dele

[dpdk-dev] [PATCH v2 16/33] i40e/base: add fw build info to AQ data

2015-04-30 Thread Helin Zhang
Since the FW build number is available in the AQ response, save it off for future use. Signed-off-by: Helin Zhang --- lib/librte_pmd_i40e/i40e/i40e_adminq.c| 1 + lib/librte_pmd_i40e/i40e/i40e_adminq.h| 1 + lib/librte_pmd_i40e/i40e/i40e_common.c| 4 lib/librte_pmd_i40e/i40e/i40

[dpdk-dev] [PATCH v2 15/33] i40e/base: replacement of DEBUGOUT() with i40e_debug()

2015-04-30 Thread Helin Zhang
To support better debug information printing, all DEBUGOUT() are replaced by i40e_debug(). In addition, the NVM update state strings are added in debug information. Signed-off-by: Helin Zhang --- lib/librte_pmd_i40e/Makefile| 1 + lib/librte_pmd_i40e/i40e/i40e_nvm.c | 77 +++

[dpdk-dev] [PATCH v2 14/33] i40e/base: enhancements of NVM checksum calculation

2015-04-30 Thread Helin Zhang
The data buffer for i40e_calc_nvm_checksum() is too big, so move it off and allocate separately. In addition, use i40e_read_nvm_buffer() to get the whole shadow RAM, together with minor enhancements. Signed-off-by: Helin Zhang --- lib/librte_pmd_i40e/i40e/i40e_nvm.c | 49 +++-

[dpdk-dev] [PATCH v2 13/33] i40e/base: enhancement of polling NVM semaphore

2015-04-30 Thread Helin Zhang
Only poll on the NVM semaphore if there's time left on a previous reservation. Signed-off-by: Helin Zhang --- lib/librte_pmd_i40e/i40e/i40e_nvm.c | 35 +-- 1 file changed, 17 insertions(+), 18 deletions(-) diff --git a/lib/librte_pmd_i40e/i40e/i40e_nvm.c b/lib/l

[dpdk-dev] [PATCH v2 12/33] i40e/base: fix up NVM update sm error handling

2015-04-30 Thread Helin Zhang
The state transitions after an error were not managed well, so these changes get us back to the INIT state or don't transit out of the INIT state after most errors. Signed-off-by: Helin Zhang --- lib/librte_pmd_i40e/i40e/i40e_nvm.c | 32 ++-- 1 file changed, 22 insert

[dpdk-dev] [PATCH v2 11/33] i40e/base: check for AQ timeout in aq_rc decode

2015-04-30 Thread Helin Zhang
Decoding the AQ return code is great except when the AQ send timed out and there's no return code set. This changes the handy decoder interface to help catch and properly report the condition as an useful error number rather than returning a misleading '0'. Signed-off-by: Helin Zhang --- lib/lib

[dpdk-dev] [PATCH v2 10/33] i40e/base: catch NVM write semaphore timeout and retry

2015-04-30 Thread Helin Zhang
In some circumstances, a multi-write transaction takes longer than the default 3 minutes timeout on the write semaphore. If the write failed with an EBUSY status, this is likely the problem. So here it tries to reacquire the semaphore and then retry the write. Signed-off-by: Helin Zhang --- lib/

[dpdk-dev] [PATCH v2 09/33] i40e/base: update of shadow RAM read/write functions

2015-04-30 Thread Helin Zhang
To support different hardware, shadow RAM read should be done via SRCTL register or AQ command, and shadow RAM write should be done via AQ command only. Signed-off-by: Helin Zhang --- lib/librte_pmd_i40e/i40e/i40e_nvm.c | 196 ++-- 1 file changed, 190 insertions(+

[dpdk-dev] [PATCH v2 08/33] i40e/base: rework of 'i40e_hmc_get_object_va'

2015-04-30 Thread Helin Zhang
To simplify the usage of invoking 'i40e_hmc_get_object_va', input parameters of it were reworked. In addition, minor code style fixes were added as well. Signed-off-by: Helin Zhang --- lib/librte_pmd_i40e/i40e/i40e_lan_hmc.c | 31 +-- 1 file changed, 13 insertions(+),

[dpdk-dev] [PATCH v2 07/33] i40e: replacement of 'i40e_debug_read_register()'

2015-04-30 Thread Helin Zhang
As base driver provides 'i40e_aq_debug_read_register()', the same functional interface of 'i40e_debug_read_register()' can be replaced. Signed-off-by: Helin Zhang --- lib/librte_pmd_i40e/i40e/i40e_common.c| 35 +++ lib/librte_pmd_i40e/i40e/i40e_prototype.h | 3 ++

[dpdk-dev] [PATCH v2 06/33] i40e/base: support of CEE DCBX on recent firmware versions

2015-04-30 Thread Helin Zhang
Recent firmware versions support CEE DCBX, while old firmware versions support IEEE DCBX only. So firmware version needs to be checked during getting DCB configurations. To support CEE DCBX, AQ commands of 'i40e_aq_get_cee_dcb_config' and 'i40e_aq_start_stop_dcbx' were implemented. Signed-off-by:

[dpdk-dev] [PATCH v2 05/33] i40e/base: support of building both PF and VF driver together

2015-04-30 Thread Helin Zhang
Macros of PF_DRIVER, VF_DRIVER and INTEGRATED_VF were defined to support building both PF and VF driver together. PF_DRIVER needs to be defined if a build is for PF only, while VF_DRIVER for VF only. PF_DRIVER, VF_DRIVER and INTEGRATED_VF are all needed for building both PF and VF driver together.

[dpdk-dev] [PATCH v2 04/33] i40e/base: rename 'err' to 'perrno'

2015-04-30 Thread Helin Zhang
To be consistent with the original base driver, the variable name of 'err' should be renamed to 'perrno'. Signed-off-by: Helin Zhang --- lib/librte_pmd_i40e/i40e/i40e_nvm.c | 118 ++-- 1 file changed, 59 insertions(+), 59 deletions(-) diff --git a/lib/librte_pmd_

[dpdk-dev] [PATCH v2 03/33] i40e: adjustment of register definitions and relevant

2015-04-30 Thread Helin Zhang
Some macros of register definitions or relevant are added, modified or deleted. In detail, they are as follows. - I40E_PRTDCB_RUPTQ - I40E_GLGEN_GPIO_CTL - I40E_GLGEN_MDIO_CTRL - I40E_GLGEN_RSTENA_EMP - I40E_GLPCI_LATCT - I40E_GLTPH_CTRL - I40E_GLPRT_BPRCH - I40E_GLPRT_TDPC - I40E_GLSCD_QUANTA Also

[dpdk-dev] [PATCH v2 02/33] i40e: disable setting of phy configuration

2015-04-30 Thread Helin Zhang
There was a known link issue on 40G ports on NVM version (FVL3E), when setting phy configuration. As a workaround, setting of phy configuration should be disabled. The impact is that the link cannot be forcedly configured, which doesn't affect any feature functions. The workaround can be removed wh

[dpdk-dev] [PATCH v2 01/33] i40e: copyright update

2015-04-30 Thread Helin Zhang
Copyright is updated. Signed-off-by: Helin Zhang --- lib/librte_pmd_i40e/Makefile | 2 +- lib/librte_pmd_i40e/i40e/i40e_adminq.c | 2 +- lib/librte_pmd_i40e/i40e/i40e_adminq.h | 2 +- lib/librte_pmd_i40e/i40e/i40e_adminq_cmd.h | 2 +- lib/librte_pmd_i40e/i40e/i40e_alloc.h

[dpdk-dev] [PATCH v2 00/33] i40e base driver update

2015-04-30 Thread Helin Zhang
To support firmware version 'FVL3E', i40e base driver should be updated. Together with necessary modifications to i40e Poll Mode Driver, it mainly includes the base driver update which contains additional enhancements, fixes, changes for future use and so on. The details are listed as follows. v2

[dpdk-dev] KNI interface is not coming up

2015-04-30 Thread Venkat Thummala
Hi Robert, Thanks a lot, it fixed the issue. Regards Venkat On 30 April 2015 at 20:11, Sanford, Robert wrote: > Hi Venkat, > > Perhaps your DPDK application needs to slow-poll KNI devices via > rte_kni_handle_request( ). > > http://dpdk.org/doc/api/rte__kni_8h.html > > -- > Regards, > Robert >

[dpdk-dev] Beyond DPDK 2.0

2015-04-30 Thread Wiles, Keith
Darn forgot the site link, below. On 4/30/15, 4:31 PM, "Wiles, Keith" wrote: > >(I snipped out the content here only because it had been snipped a lot >already) > >Sorry, if I am highjacking the thread. > >I believe the DPDK community would benefit from moving to GitHub as the >primary DPDK site

[dpdk-dev] Beyond DPDK 2.0

2015-04-30 Thread Wiles, Keith
(I snipped out the content here only because it had been snipped a lot already) Sorry, if I am highjacking the thread. I believe the DPDK community would benefit from moving to GitHub as the primary DPDK site. http://github.com I believe the DPDK community can benefit from being at a very well

[dpdk-dev] KNI interface is not coming up

2015-04-30 Thread Venkat Thummala
Hi, I am testing DPDK 2.0 release. I am not able to bring the KNI interface up. It always gives the following error. SIOCSIFFLAGS: Timer expired This is on Ubuntu, Linux vthummala-PowerEdge-R720 3.13.0-24-generic #46-Ubuntu SMP Thu Apr 10 19:11:08 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Please

[dpdk-dev] [PATCH v4 1/2] Simplify the ifdefs in rte.app.mk.

2015-04-30 Thread Olivier MATZ
Hi, On 04/30/2015 04:31 PM, Wiles, Keith wrote: > > > On 4/30/15, 8:38 AM, "Olivier MATZ" wrote: > >> Hi Keith, >> >> On 04/30/2015 03:24 PM, Wiles, Keith wrote: >>> >>> >>> On 4/30/15, 4:45 AM, "Olivier MATZ" wrote: >>> Hi Keith, Thank you for submitting a clean-up. Please see so

[dpdk-dev] [PATCH 1/3] uio: fix irq handling with igb_uio

2015-04-30 Thread Bruce Richardson
On Tue, Apr 28, 2015 at 09:36:38AM -0700, Stephen Hemminger wrote: > The introduction of uio_pci_generic broke interrupt handling with > igb_uio. The igb_uio device uses the kernel read/write method to > enable disable IRQ's; the uio_pci_generic has to use PCI intx > config read/write to enable dis

[dpdk-dev] NO_AUTOLIB is this variable really needed?

2015-04-30 Thread Bruce Richardson
On Thu, Apr 30, 2015 at 02:55:47PM +, Wiles, Keith wrote: > What is the NO_AUTOLIB variable used for anyway, the doc states this: > > > * NO_AUTOLIBS: If set, the libraries provided by the framework will not be > included in the LDLIBS variable automatically. > > Why was this variable create

[dpdk-dev] [PATCH v4 1/2] Simplify the ifdefs in rte.app.mk.

2015-04-30 Thread Bruce Richardson
On Thu, Apr 30, 2015 at 02:31:13PM +, Wiles, Keith wrote: > > > On 4/30/15, 8:38 AM, "Olivier MATZ" wrote: > > >Hi Keith, > > > >On 04/30/2015 03:24 PM, Wiles, Keith wrote: > >> > >> > >> On 4/30/15, 4:45 AM, "Olivier MATZ" wrote: > >> > >>> Hi Keith, > >>> > >>> Thank you for submitting a

[dpdk-dev] [PATCH v7 1/6] Move common functions in eal_thread.c

2015-04-30 Thread Ravi Kerur
On Thu, Apr 30, 2015 at 9:00 AM, Neil Horman wrote: > On Wed, Apr 29, 2015 at 10:47:04AM -0700, Ravi Kerur wrote: > > > > I tried to run validate-abi.sh on BSD but ran into errors. If there > is a > > > > way to check against BSD please let me know. > > > > > > > The ABI checker should work on BS

[dpdk-dev] [RFC PATCH 4/4] librte_pmd_i40e: call _clear_cmd() when error occurs

2015-04-30 Thread Bernard Iremonger
_clear_cmd() was not being called in failure situations, resulting in the next command also failing. Signed-off-by: Bernard Iremonger --- lib/librte_pmd_i40e/i40e_ethdev_vf.c | 11 +++ 1 files changed, 7 insertions(+), 4 deletions(-) diff --git a/lib/librte_pmd_i40e/i40e_ethdev_vf.c

[dpdk-dev] [RFC PATCH 3/4] librte_pmd_i40e: increase ASQ_DELAY_MS to 100 in i40evf_wait_cmd_done()

2015-04-30 Thread Bernard Iremonger
Increase delay to avoid i40evf_read_pfmsg() failures. Signed-off-by: Bernard Iremonger --- lib/librte_pmd_i40e/i40e_ethdev_vf.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/lib/librte_pmd_i40e/i40e_ethdev_vf.c b/lib/librte_pmd_i40e/i40e_ethdev_vf.c index 7c5b3f5..af

[dpdk-dev] [RFC PATCH 2/4] librte_pmd_i40e: release vmdq vsi's in dev_close

2015-04-30 Thread Bernard Iremonger
Signed-off-by: Bernard Iremonger --- lib/librte_pmd_i40e/i40e_ethdev.c | 10 +- 1 files changed, 9 insertions(+), 1 deletions(-) diff --git a/lib/librte_pmd_i40e/i40e_ethdev.c b/lib/librte_pmd_i40e/i40e_ethdev.c index e21ebed..5cff6df 100644 --- a/lib/librte_pmd_i40e/i40e_ethdev.c +++

[dpdk-dev] [RFC PATCH 1/4] librte_pmd_i40e: changes to support PCI Port Hotplug

2015-04-30 Thread Bernard Iremonger
This patch depends on the Port Hotplug Framework. It implements the eth_dev_uninit functions for rte_i40e_pmd and rte_i40evf_pmd. Signed-off-by: Bernard Iremonger --- lib/librte_pmd_i40e/i40e_ethdev.c| 69 +- lib/librte_pmd_i40e/i40e_ethdev_vf.c | 48 +

[dpdk-dev] [PATCH v4 1/2] Simplify the ifdefs in rte.app.mk.

2015-04-30 Thread Wiles, Keith
On 4/30/15, 11:22 AM, "Richardson, Bruce" wrote: >On Thu, Apr 30, 2015 at 02:31:13PM +, Wiles, Keith wrote: >> >> >> On 4/30/15, 8:38 AM, "Olivier MATZ" wrote: >> >> >Hi Keith, >> > >> >On 04/30/2015 03:24 PM, Wiles, Keith wrote: >> >> >> >> >> >> On 4/30/15, 4:45 AM, "Olivier MATZ" wr

[dpdk-dev] NO_AUTOLIB is this variable really needed?

2015-04-30 Thread Wiles, Keith
On 4/30/15, 11:24 AM, "Richardson, Bruce" wrote: >On Thu, Apr 30, 2015 at 02:55:47PM +, Wiles, Keith wrote: >> What is the NO_AUTOLIB variable used for anyway, the doc states this: >> >> >> * NO_AUTOLIBS: If set, the libraries provided by the framework will not >>be >> included in the LDL

[dpdk-dev] [PATCH v4 1/2] Simplify the ifdefs in rte.app.mk.

2015-04-30 Thread Olivier MATZ
Hi Keith, On 04/30/2015 03:24 PM, Wiles, Keith wrote: > > > On 4/30/15, 4:45 AM, "Olivier MATZ" wrote: > >> Hi Keith, >> >> Thank you for submitting a clean-up. Please see some comments below. >> >> On 04/29/2015 05:25 PM, Keith Wiles wrote: >>> Trying to simplify the ifdefs in rte.app.mk to make

[dpdk-dev] NO_AUTOLIB is this variable really needed?

2015-04-30 Thread Wiles, Keith
What is the NO_AUTOLIB variable used for anyway, the doc states this: * NO_AUTOLIBS: If set, the libraries provided by the framework will not be included in the LDLIBS variable automatically. Why was this variable created, do we have really good reason? It seems like the variable removes almost

[dpdk-dev] KNI interface is not coming up

2015-04-30 Thread Sanford, Robert
Hi Venkat, Perhaps your DPDK application needs to slow-poll KNI devices via rte_kni_handle_request( ). http://dpdk.org/doc/api/rte__kni_8h.html -- Regards, Robert >Hi, > >I am testing DPDK 2.0 release. >I am not able to bring the KNI interface up. >It always gives the following error. > >SIOCS

[dpdk-dev] [PATCH v4 1/2] Simplify the ifdefs in rte.app.mk.

2015-04-30 Thread Wiles, Keith
On 4/30/15, 8:38 AM, "Olivier MATZ" wrote: >Hi Keith, > >On 04/30/2015 03:24 PM, Wiles, Keith wrote: >> >> >> On 4/30/15, 4:45 AM, "Olivier MATZ" wrote: >> >>> Hi Keith, >>> >>> Thank you for submitting a clean-up. Please see some comments below. >>> >>> On 04/29/2015 05:25 PM, Keith Wiles wro

[dpdk-dev] [RFC PATCH 1/1] librte_pmd_ring: changes to support PCI Port Hotplug

2015-04-30 Thread Bernard Iremonger
This patch depends on the Port Hotplug Framework. It implements the rte_dev_uninit_t() function for the ring pmd. Signed-off-by: Bernard Iremonger --- lib/librte_pmd_ring/rte_eth_ring.c | 93 1 files changed, 72 insertions(+), 21 deletions(-) diff --git a

[dpdk-dev] [PATCH v2] pipeline: add statistics for librte_pipeline ports and tables

2015-04-30 Thread Michal Jastrzebski
From: Pawel Wodkowski This patch adds statistics collection for librte_pipeline. Those statistics ale disabled by default during build time. Signed-off-by: Pawel Wodkowski --- config/common_bsdapp |1 + config/common_linuxapp |1 + lib/librte_pipeline/rte_pipe

[dpdk-dev] [PATCH v2 10/10] table: added lpm table stats

2015-04-30 Thread Michal Jastrzebski
From: Maciej Gajdzica Added lpm table statistics. Signed-off-by: Maciej Gajdzica --- config/common_bsdapp |1 + config/common_linuxapp |1 + lib/librte_table/rte_table_lpm.c | 34 ++ 3 files changed, 36 insertions(+) diff --git a

[dpdk-dev] [PATCH v2 09/10] table: added lpm_ipv6 table stats

2015-04-30 Thread Michal Jastrzebski
From: Maciej Gajdzica Added lpm ipv6 table statistics. Signed-off-by: Maciej Gajdzica --- config/common_bsdapp |1 + config/common_linuxapp|1 + lib/librte_table/rte_table_lpm_ipv6.c | 34 + 3 files changed, 36 insertio

[dpdk-dev] [PATCH v2 08/10] table: added hash_lru table stats

2015-04-30 Thread Michal Jastrzebski
From: Maciej Gajdzica Added statistics for hash_lru table. Signed-off-by: Maciej Gajdzica --- config/common_bsdapp |1 + config/common_linuxapp|1 + lib/librte_table/rte_table_hash_lru.c | 44 + 3 files changed, 46 inse

[dpdk-dev] [PATCH v2 07/10] table: added hash_key8 table stats

2015-04-30 Thread Michal Jastrzebski
From: Maciej Gajdzica Added statistics for hash key8 table. Signed-off-by: Maciej Gajdzica --- config/common_bsdapp |1 + config/common_linuxapp |1 + lib/librte_table/rte_table_hash_key8.c | 52 3 files changed, 54 i

[dpdk-dev] [PATCH v2 06/10] table: added hash_key32 table stats

2015-04-30 Thread Michal Jastrzebski
From: Maciej Gajdzica Added statistics for hash key32 table. Signed-off-by: Maciej Gajdzica --- config/common_bsdapp|1 + config/common_linuxapp |1 + lib/librte_table/rte_table_hash_key32.c | 41 +++ 3 files changed, 4

[dpdk-dev] [PATCH v2 05/10] table: added hash_key16 table stats

2015-04-30 Thread Michal Jastrzebski
From: Maciej Gajdzica Added statistics for hash key16 table. Signed-off-by: Maciej Gajdzica --- config/common_bsdapp|1 + config/common_linuxapp |1 + lib/librte_table/rte_table_hash_key16.c | 41 +++ 3 files changed, 4

[dpdk-dev] [PATCH v2 04/10] table: added hash_ext table stats

2015-04-30 Thread Michal Jastrzebski
From: Maciej Gajdzica Added statistics for hash ext table. Signed-off-by: Maciej Gajdzica --- config/common_bsdapp |1 + config/common_linuxapp|1 + lib/librte_table/rte_table_hash_ext.c | 44 + 3 files changed, 46 inse

[dpdk-dev] [PATCH v2 03/10] table: added array table stats

2015-04-30 Thread Michal Jastrzebski
From: Maciej Gajdzica Added statistics for array table. Signed-off-by: Maciej Gajdzica --- config/common_bsdapp |1 + config/common_linuxapp |1 + lib/librte_table/rte_table_array.c | 34 +- 3 files changed, 35 insertions(+),

[dpdk-dev] [PATCH v2 02/10] table: added acl table stats

2015-04-30 Thread Michal Jastrzebski
From: Maciej Gajdzica Added statistics for ACL table. Signed-off-by: Maciej Gajdzica --- config/common_bsdapp |1 + config/common_linuxapp |1 + lib/librte_table/rte_table_acl.c | 35 +++ 3 files changed, 37 insertions(+) diff --

[dpdk-dev] [PATCH v2 01/10] table: added structure for storing table stats

2015-04-30 Thread Michal Jastrzebski
From: Maciej Gajdzica Added common structure for table statistics. Signed-off-by: Maciej Gajdzica --- lib/librte_table/rte_table.h | 25 + 1 file changed, 25 insertions(+) diff --git a/lib/librte_table/rte_table.h b/lib/librte_table/rte_table.h index d57bc33..9860b7b

[dpdk-dev] [PATCH v2 00/10] table: added table statistics

2015-04-30 Thread Michal Jastrzebski
From: Maciej Gajdzica Added statistics for every type of table. By default all table statistics are disabled, user must activate them in config file. Maciej Gajdzica (10): table: added structure for storing table stats table: added acl table stats table: added array table stats table: ad

[dpdk-dev] [PATCH v2 13/13] port: added port_sink stats

2015-04-30 Thread Michal Jastrzebski
From: Maciej Gajdzica Added statistics for sink port. Signed-off-by: Maciej Gajdzica --- config/common_bsdapp |1 + config/common_linuxapp |1 + lib/librte_port/rte_port_source_sink.c | 63 ++-- 3 files changed, 61 inserti

[dpdk-dev] [PATCH v2 12/13] port: added port_source stats

2015-04-30 Thread Michal Jastrzebski
From: Maciej Gajdzica Added statistics for source port. Signed-off-by: Maciej Gajdzica --- config/common_bsdapp |1 + config/common_linuxapp |1 + lib/librte_port/rte_port_source_sink.c | 35 3 files changed, 37 inser

[dpdk-dev] [PATCH v2 11/13] port: added port_sched_writer stats

2015-04-30 Thread Michal Jastrzebski
From: Maciej Gajdzica Added statistics for sched writer port. Signed-off-by: Maciej Gajdzica --- config/common_bsdapp |1 + config/common_linuxapp |1 + lib/librte_port/rte_port_sched.c | 57 ++ 3 files changed, 54 insertions(

[dpdk-dev] [PATCH v2 10/13] port: added port_sched_reader stats

2015-04-30 Thread Michal Jastrzebski
From: Maciej Gajdzica Added statistics for sched reader port. Signed-off-by: Maciej Gajdzica --- config/common_bsdapp |1 + config/common_linuxapp |1 + lib/librte_port/rte_port_sched.c | 39 +- 3 files changed, 40 insertions(

[dpdk-dev] [PATCH v2 09/13] port: added port_ring_writer_nodrop stats

2015-04-30 Thread Michal Jastrzebski
From: Maciej Gajdzica Added statistics for ring writer nodrop port. Signed-off-by: Maciej Gajdzica --- config/common_bsdapp|1 + config/common_linuxapp |1 + lib/librte_port/rte_port_ring.c | 39 +++ 3 files changed, 41 inserti

[dpdk-dev] [PATCH v2 08/13] port: added port_ring_writer stats

2015-04-30 Thread Michal Jastrzebski
From: Maciej Gajdzica Added statistics for port writer port. Signed-off-by: Maciej Gajdzica --- config/common_bsdapp|1 + config/common_linuxapp |1 + lib/librte_port/rte_port_ring.c | 40 +++ 3 files changed, 42 insertions(+)

[dpdk-dev] [PATCH v2 07/13] port: added port_ring_reader stats

2015-04-30 Thread Michal Jastrzebski
From: Maciej Gajdzica Added statistics for ring reader port. Signed-off-by: Maciej Gajdzica --- config/common_bsdapp|1 + config/common_linuxapp |1 + lib/librte_port/rte_port_ring.c | 39 ++- 3 files changed, 40 insertions(+),

[dpdk-dev] [PATCH v2 06/13] port: added port_ras stats

2015-04-30 Thread Michal Jastrzebski
From: Maciej Gajdzica Added statistics for IPv4 and IPv6 reassembly ports. Signed-off-by: Maciej Gajdzica --- config/common_bsdapp |1 + config/common_linuxapp |1 + lib/librte_port/rte_port_ras.c | 38 ++ 3 files changed, 40 inse

[dpdk-dev] [PATCH v2 05/13] port: added port_frag stats

2015-04-30 Thread Michal Jastrzebski
From: Maciej Gajdzica Added statistics for IPv4 and IPv6 fragmentation ports. Signed-off-by: Maciej Gajdzica --- config/common_bsdapp|1 + config/common_linuxapp |1 + lib/librte_port/rte_port_frag.c | 36 3 files changed, 38

[dpdk-dev] [PATCH v2 04/13] port: added port_ethdev_writer_nodrop stats

2015-04-30 Thread Michal Jastrzebski
From: Maciej Gajdzica Added statistics for ethdev writer nodrop port. Signed-off-by: Maciej Gajdzica --- config/common_bsdapp |1 + config/common_linuxapp|1 + lib/librte_port/rte_port_ethdev.c | 38 + 3 files changed, 40 i

[dpdk-dev] [PATCH v2 03/13] port: added port_ethdev_writer stats

2015-04-30 Thread Michal Jastrzebski
From: Maciej Gajdzica Added statistics for ethdev writer port. Signed-off-by: Maciej Gajdzica --- config/common_bsdapp |1 + config/common_linuxapp|1 + lib/librte_port/rte_port_ethdev.c | 38 + 3 files changed, 40 insertio

[dpdk-dev] [PATCH v2 02/13] port: added port_ethdev_reader stats

2015-04-30 Thread Michal Jastrzebski
From: Maciej Gajdzica Added statistics for ethdev reader port. Signed-off-by: Maciej Gajdzica --- config/common_bsdapp |1 + config/common_linuxapp|1 + lib/librte_port/rte_port_ethdev.c | 37 - 3 files changed, 38 insertio

[dpdk-dev] [PATCH v2 01/13] port: added structures for port stats

2015-04-30 Thread Michal Jastrzebski
From: Maciej Gajdzica Added common data structures for port statistics. Signed-off-by: Maciej Gajdzica --- lib/librte_port/rte_port.h | 60 1 file changed, 55 insertions(+), 5 deletions(-) diff --git a/lib/librte_port/rte_port.h b/lib/librte_port

[dpdk-dev] [PATCH v2 00/13] port: added port statistics

2015-04-30 Thread Michal Jastrzebski
From: Maciej Gajdzica Added statistics for every type of port. By default all port statistics are disabled, user must activate them in config file. Maciej Gajdzica (13): port: added structures for port stats port: added port_ethdev_reader stats port: added port_ethdev_writer stats port:

[dpdk-dev] [PATCH v2 3/3] port: added ipv6 reassembly port

2015-04-30 Thread Michal Jastrzebski
From: Maciej Gajdzica Added new port type - IPv6 reassembly port. Signed-off-by: Maciej Gajdzica --- lib/librte_port/rte_port_ras.c | 142 +--- lib/librte_port/rte_port_ras.h |9 ++- 2 files changed, 112 insertions(+), 39 deletions(-) diff --git a/lib/

[dpdk-dev] [PATCH v2 2/3] port: added ipv6 fragmentation port

2015-04-30 Thread Michal Jastrzebski
From: Maciej Gajdzica Added new port type - IPv6 Fragmentation port Signed-off-by: Maciej Gajdzica --- lib/librte_port/rte_port_frag.c | 61 +-- lib/librte_port/rte_port_frag.h |9 +- 2 files changed, 54 insertions(+), 16 deletions(-) diff --git a

[dpdk-dev] [PATCH v2 1/3] port: removed IPV4_MTU_DEFAULT define

2015-04-30 Thread Michal Jastrzebski
From: Maciej Gajdzica p->mtu field should be used instead. Signed-off-by: Maciej Gajdzica --- lib/librte_port/rte_port_frag.c |6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/lib/librte_port/rte_port_frag.c b/lib/librte_port/rte_port_frag.c index ff0ab9b..dce33d5 100

[dpdk-dev] [PATCH v2 0/3] port: added frag_ipv6 and ras_ipv6 ports

2015-04-30 Thread Michal Jastrzebski
From: Maciej Gajdzica Added ipv6 versions of ip fragmentation and ip reassembly ports. Maciej Gajdzica (3): port: removed IPV4_MTU_DEFAULT define port: added ipv6 fragmentation port port: added ipv6 reassembly port lib/librte_port/rte_port_frag.c | 67 -- lib/librte_por

[dpdk-dev] [PATCH v2 3/3] port: added ring_writer_nodrop port

2015-04-30 Thread Michal Jastrzebski
From: Maciej Gajdzica When ethdev_writer_nodrop port fails to send data, it tries to resend. Operation is aborted when maximum number of retries is reached. Signed-off-by: Maciej Gajdzica --- lib/librte_port/rte_port_ring.c | 226 +++ lib/librte_port/rte_po

[dpdk-dev] [PATCH v2 2/3] port: added ethdev_writer_nodrop port

2015-04-30 Thread Michal Jastrzebski
From: Maciej Gajdzica When ethdev_writer_nodrop port fails to send data, it tries to resend. Operation is aborted when maximum number of retries is reached. Signed-off-by: Maciej Gajdzica --- lib/librte_port/rte_port_ethdev.c | 230 + lib/librte_port/rte_po

[dpdk-dev] [PATCH v2 1/3] port: added WRITER_APPROACH == 1 implementation to ring port

2015-04-30 Thread Michal Jastrzebski
From: Maciej Gajdzica Added better optimized implementation of tx_bulk for ring writer port based on similar solution in ethdev_writer port. New implementation sends burst without copying data to internal buffer if it is possible. Signed-off-by: Maciej Gajdzica --- lib/librte_port/rte_port_rin

[dpdk-dev] [PATCH v2 0/3] port: added ethdev_writer_nodrop and ring_writer_nodrop ports

2015-04-30 Thread Michal Jastrzebski
From: Maciej Gajdzica When nodrop writer port fails to send data, it retries until reach maximum number of retries. Also added new tx_bulk implementation for ring writer port. Maciej Gajdzica (3): port: added WRITER_APPROACH == 1 implementation to ring port port: added ethdev_writer_nodrop p

[dpdk-dev] [PATCH 0/2] doc: refactored fig and table nums into references

2015-04-30 Thread Mcnamara, John
> -Original Message- > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > Sent: Wednesday, April 29, 2015 5:13 PM > To: Mcnamara, John > Cc: dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH 0/2] doc: refactored fig and table nums > into references > > is really a great work bu

[dpdk-dev] [PATCH v4 1/2] Simplify the ifdefs in rte.app.mk.

2015-04-30 Thread Wiles, Keith
On 4/30/15, 4:45 AM, "Olivier MATZ" wrote: >Hi Keith, > >Thank you for submitting a clean-up. Please see some comments below. > >On 04/29/2015 05:25 PM, Keith Wiles wrote: >> Trying to simplify the ifdefs in rte.app.mk to make the code >> more readable and maintainable by moving LDLIBS variable

[dpdk-dev] [PATCH v7 1/6] Move common functions in eal_thread.c

2015-04-30 Thread Neil Horman
On Wed, Apr 29, 2015 at 10:47:04AM -0700, Ravi Kerur wrote: > > > I tried to run validate-abi.sh on BSD but ran into errors. If there is a > > > way to check against BSD please let me know. > > > > > The ABI checker should work on BSD as far as I know, since it only relies > > on > > dwarf informat

[dpdk-dev] [PATCH v4 1/2] Simplify the ifdefs in rte.app.mk.

2015-04-30 Thread Olivier MATZ
Hi Keith, Thank you for submitting a clean-up. Please see some comments below. On 04/29/2015 05:25 PM, Keith Wiles wrote: > Trying to simplify the ifdefs in rte.app.mk to make the code > more readable and maintainable by moving LDLIBS variable to use > the same style as LDLIBS-y being used in the

[dpdk-dev] [PATCHv2] app/ and examples/ fix default mbuf size

2015-04-30 Thread Olivier MATZ
Hi Konstantin, On 04/30/2015 01:31 AM, Konstantin Ananyev wrote: > v2 changes: > - add a new macro into rte_mbuf.h > - make samples to use that new macro > > > Fixes: dfb03bbe2b ("app/testpmd: use standard functions to initialize > mbufs and mbuf pool"). > Latest mbuf changes (priv_size addition a

[dpdk-dev] [PATCH v5 2/2] Update Docs for new EXTRA_LDLIBS variable

2015-04-30 Thread Keith Wiles
Signed-off-by: Keith Wiles --- doc/build-sdk-quick.txt | 1 + doc/guides/prog_guide/build_app.rst | 2 +- doc/guides/prog_guide/dev_kit_build_system.rst | 2 ++ doc/guides/prog_guide/dev_kit_root_make_help.rst | 2 +- 4 files changed, 5 insertions(+), 2 del

[dpdk-dev] [PATCH v5 1/2] Simplify the ifdefs in rte.app.mk.

2015-04-30 Thread Keith Wiles
Trying to simplify the ifdefs in rte.app.mk to make the code more readable and maintainable by moving LDLIBS variable to use the same style as LDLIBS-y being used in the rest of the code. Added a new variable called EXTRA_LDLIBS to be used by example apps instead of using LDLIBS directly. The new

[dpdk-dev] [PATCH 0/3] port: added ethdev_writer_nodrop and ring_writer_nodrop ports

2015-04-30 Thread Gajdzica, MaciejX T
Forgot v2 prefix, will resend > -Original Message- > From: Maciej Gajdzica [mailto:mtgajdzx at stargo] > Sent: Thursday, April 30, 2015 11:23 AM > To: dev at dpdk.org > Cc: Gajdzica, MaciejX T > Subject: [PATCH 0/3] port: added ethdev_writer_nodrop and ring_writer_nodrop > ports > > When

[dpdk-dev] [PATCH v2 02/10] table: added acl table stats

2015-04-30 Thread Stephen Hemminger
On Thu, 30 Apr 2015 14:14:30 +0200 Michal Jastrzebski wrote: > From: Maciej Gajdzica > > Added statistics for ACL table. > > Signed-off-by: Maciej Gajdzica > --- > config/common_bsdapp |1 + > config/common_linuxapp |1 + > lib/librte_table/rte_table_acl.c | 3

[dpdk-dev] [PATCHv2] app/ and examples/ fix default mbuf size

2015-04-30 Thread Konstantin Ananyev
v2 changes: - add a new macro into rte_mbuf.h - make samples to use that new macro Fixes: dfb03bbe2b ("app/testpmd: use standard functions to initialize mbufs and mbuf pool"). Latest mbuf changes (priv_size addition and related fixes) exposed small problem with testpmd and few other sample apps: