[dpdk-dev] [PATCH v4 0/7] Move EAL common function

2015-03-30 Thread Thomas Monjalon
Hi Ravi, 2015-01-06 12:24, Ravi Kerur: > Fix v3 PATCH review comments from Thomas. > eal_common.c is further split into eal_common_system.c and > eal_common_runtime.c files with appropriate functions. > eal_externs.h file is removed and _get_ and _set_ APIs are > used to access variables. > Functi

[dpdk-dev] [PATCH v2 1/5] mbuf: fix clone support when application uses private mbuf data

2015-03-30 Thread Ananyev, Konstantin
Hi Olivier, > -Original Message- > From: Olivier MATZ [mailto:olivier.matz at 6wind.com] > Sent: Monday, March 30, 2015 8:56 PM > To: Ananyev, Konstantin > Cc: dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH v2 1/5] mbuf: fix clone support when > application uses private mbuf data > > H

[dpdk-dev] [PATCH 1/3] port: added WRITER_APPROACH == 1 implementation to ring port

2015-03-30 Thread David Marchand
On Mon, Mar 30, 2015 at 11:56 AM, Maciej Gajdzica < maciejx.t.gajdzica at intel.com> wrote: > Added better optimized implementation of tx_bulk for ring writer port > based on > similar solution in ethdev_writer port. New implementation sends burst > without > copying data to internal buffer if it

[dpdk-dev] [PATCH v2 0/2] test: fix strict aliasing rule errors in gcc 4.4

2015-03-30 Thread Thomas Monjalon
2015-03-27 11:55, Pawel Wodkowski: > Fix strict aliasing rule error seen in gcc 4.4 in virtual pmd and mode 4 link > bonding mode 4 test. > > changes v2: > - fix error in code instead disabling compiler warning. > > Pawel Wodkowski (2): > test: fix strict aliasing rule error in virtual pmd >

[dpdk-dev] [PATCH v2] DPDK does not build on gcc 4.4, as it complains due to strict-aliasing rules in virtual_pmd and link_bonding_mode4 tests, with no errors in next gcc versions:

2015-03-30 Thread Thomas Monjalon
2015-03-30 12:06, Pablo de Lara: > CC virtual_pmd.o > CC test_link_bonding_mode4.o > cc1: warnings being treated as errors > /root/dpdk/app/test/test_link_bonding_mode4.c: In function > ?test_mode4_expired?: > /root/dpdk/x86_64-native-linuxapp-gcc/include/rte_ring.h:645: error: > dereferencing po

[dpdk-dev] [PATCH] librte_pmd_e1000: power down the serdes link

2015-03-30 Thread Thomas Monjalon
2015-03-07 11:57, Shelton Chia: > Signed-off-by: Shelton Chia > --- > lib/librte_pmd_e1000/igb_ethdev.c | 5 - > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/lib/librte_pmd_e1000/igb_ethdev.c > b/lib/librte_pmd_e1000/igb_ethdev.c > index 504ae74..314ef2a 100644 > --- a/li

[dpdk-dev] [PATCH 00/13] port: added port statistics

2015-03-30 Thread David Marchand
On Mon, Mar 30, 2015 at 6:45 PM, Stephen Hemminger < stephen at networkplumber.org> wrote: > On Mon, 30 Mar 2015 12:28:51 +0200 > Maciej Gajdzica wrote: > > > Added statistics for every type of port. By default all port statistics > > are disabled, user must activate them in config file. > > Can

[dpdk-dev] [PATCH v9 3/3] ixgbe: Add LRO support

2015-03-30 Thread Vlad Zolotarov
- Only x540 and 82599 devices support LRO. - Add the appropriate HW configuration. - Add RSC aware rx_pkt_burst() handlers: - Implemented bulk allocation and non-bulk allocation versions. - Add LRO-specific fields to rte_eth_rxmode, to rte_eth_dev_data and to ixgb

[dpdk-dev] [PATCH v9 2/3] ixgbe: Code refactoring

2015-03-30 Thread Vlad Zolotarov
- ixgbe_rx_alloc_bufs(): - Reset the rte_mbuf fields only when requested. - Take the RDT update out of the function. - Add the stub when RTE_LIBRTE_IXGBE_RX_ALLOW_BULK_ALLOC is not defined. - ixgbe_recv_scattered_pkts(): - Take the code that updates the fields of the c

[dpdk-dev] [PATCH v9 1/3] ixgbe: Cleanups

2015-03-30 Thread Vlad Zolotarov
- Removed the not needed casting. - ixgbe_dev_rx_init(): shorten the lines by defining a local alias variable to access &dev->data->dev_conf.rxmode. Signed-off-by: Vlad Zolotarov --- New in v6: - Fixed a compilation error caused by a patches recomposition durin

[dpdk-dev] [PATCH v9 0/3]: Add LRO support to ixgbe PMD

2015-03-30 Thread Vlad Zolotarov
This series adds the missing flow for enabling the LRO in the ethdev and adds a support for this feature in the ixgbe PMD. There is a big hope that this initiative is going to be picked up by some Intel developer that would add the LRO support to other Intel PMDs. The series starts with some clea

[dpdk-dev] [PATCH] i40e: fix the issue reported by klocwork

2015-03-30 Thread Thomas Monjalon
Helin, is this patch valid and important? 2015-02-12 19:22, Jingjing Wu: > Klocwork reports array 'src_offset' may use index 16. > In function i40e_srcoff_to_flx_pit, index j + 1 can reach > I40E_FDIR_MAX_FLEX_LEN. > This patch fixes this issue to avoid array bound. > > Signed-off-by: Jingjing W

[dpdk-dev] [PATCH v3] virtio: Fix crash issue for secondary process

2015-03-30 Thread Thomas Monjalon
2015-03-27 21:23, Ouyang Changchun: > It needs Rx function even in the case of secondary process, and it also needs > check if > it supports mergeable feature or not. > > Signed-off-by: Changchun Ouyang > --- > > Changes in v3 > -- Extract a function to remove the duplicated codes; > > Chang

[dpdk-dev] [PATCH v2] rte_mbuf: mbuf bulk alloc/free functions added + unittest

2015-03-30 Thread Vadim Suraev
Hi, Neil >I think what you need to do here is enhance the underlying pktmbuf interface >such that an rte_mbuf structure has a destructor method association with it >which is called when its refcnt reaches zero. That way the >rte_pktmbuf_bulk_free function can just decrement the refcnt on each >mb

[dpdk-dev] [PATCH] fm10k: Fix queue start twice failed

2015-03-30 Thread Thomas Monjalon
2015-03-25 18:48, Michael Qiu: > When use "port 0 rxq 0 start" in testpmd twice, the rx queue 0 on > port 0 will failed to work. > > The root casue is the rxqctl enable bit need to reset if already > enabled. Please try to reword this message to make it clear. > Signed-off-by: Michael Qiu > ---

[dpdk-dev] [PATCH v2 1/5] mbuf: fix clone support when application uses private mbuf data

2015-03-30 Thread Olivier MATZ
Hi Konstantin, On 03/30/2015 02:34 PM, Ananyev, Konstantin wrote: > Hi Olivier, > >> -Original Message- >> From: Olivier MATZ [mailto:olivier.matz at 6wind.com] >> Sent: Friday, March 27, 2015 3:17 PM >> To: Ananyev, Konstantin; dev at dpdk.org >> Subject: Re: [dpdk-dev] [PATCH v2 1/5] mb

[dpdk-dev] [PATCH] ethdev: additional parameter in RX callback

2015-03-30 Thread Thomas Monjalon
2015-03-23 12:00, Neil Horman: > On Mon, Mar 23, 2015 at 04:16:36PM +0100, Thomas Monjalon wrote: > > I think John is saying that the API of rte_eth_rx_burst() already includes > > the nb_pkts parameter. So it's natural to push it to the callback. > > I also think Neil is saying that this parameter

[dpdk-dev] [RFC PATCH] eal: rte_rand yields only 62 random bits

2015-03-30 Thread Neil Horman
On Mon, Mar 30, 2015 at 06:19:28PM -0400, Robert Sanford wrote: > Yes, applications have many choices for PRNGs. But, we still need one > internally for the following libs: PMDs (e1000, fm10k, i40e, ixgbe, virtio, > xenvirt), sched, and timer. > They can be updated to use the apropriate rng from a

[dpdk-dev] [PATCH] mbuf: add comment explaining confusing code

2015-03-30 Thread Marc Sune
On 27/03/15 15:30, Bruce Richardson wrote: > On Fri, Mar 27, 2015 at 10:07:35AM -0400, Neil Horman wrote: >> On Fri, Mar 27, 2015 at 11:32:38AM +, Bruce Richardson wrote: >>> On Fri, Mar 27, 2015 at 06:29:56AM -0400, Neil Horman wrote: On Thu, Mar 26, 2015 at 09:14:54PM +, Bruce Rich

[dpdk-dev] [PATCH] mbuf: add comment explaining confusing code

2015-03-30 Thread Thomas Monjalon
2015-03-27 16:56, Richardson, Bruce: > > > -Original Message- > > From: Neil Horman [mailto:nhorman at tuxdriver.com] > > Sent: Friday, March 27, 2015 4:44 PM > > To: Richardson, Bruce > > Cc: dev at dpdk.org > > Subject: Re: [dpdk-dev] [PATCH] mbuf: add comment explaining confusing > > co

[dpdk-dev] [PATCH v8 3/3] ixgbe: Add LRO support

2015-03-30 Thread Vlad Zolotarov
On 03/30/15 18:37, Vlad Zolotarov wrote: > > > On 03/30/15 17:18, Ananyev, Konstantin wrote: >> Hi Vlad, >> >>> -Original Message- >>> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Vlad Zolotarov >>> Sent: Wednesday, March 18, 2015 5:52 PM >>> To: dev at dpdk.org >>> Subject: [d

[dpdk-dev] [PATCH v8 3/3] ixgbe: Add LRO support

2015-03-30 Thread Vlad Zolotarov
On 03/30/15 17:18, Ananyev, Konstantin wrote: > Hi Vlad, > >> -Original Message- >> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Vlad Zolotarov >> Sent: Wednesday, March 18, 2015 5:52 PM >> To: dev at dpdk.org >> Subject: [dpdk-dev] [PATCH v8 3/3] ixgbe: Add LRO support >> >>

[dpdk-dev] [RFC PATCH] eal: rte_rand yields only 62 random bits

2015-03-30 Thread Robert Sanford
Yes, applications have many choices for PRNGs. But, we still need one internally for the following libs: PMDs (e1000, fm10k, i40e, ixgbe, virtio, xenvirt), sched, and timer. On Fri, Mar 27, 2015 at 8:03 PM, Stephen Hemminger < stephen at networkplumber.org> wrote: > I would argue remove rte_rand

[dpdk-dev] Symmetric RSS Hashing, Part 2

2015-03-30 Thread Vladimir Medvedkin
Matthew, I don't use any special tricks to make symmetric RSS work. Furthermore, it works not only with 0x6d5a. Regards, Vladimir 2015-03-28 23:11 GMT+03:00 Matthew Hall : > On Sat, Mar 28, 2015 at 12:10:20PM +0300, Vladimir Medvedkin wrote: > > I just verify RSS symmetric in my code, all works

[dpdk-dev] [PATCH] mbuf: add comment explaining confusing code

2015-03-30 Thread Don Provan
> > > > > > > > if (likely (rte_mbuf_refcnt_read(m) == 1) || > > > > > > > > likely (rte_mbuf_refcnt_update(m, -1) > > > > > > > > == 0)) In all the debate about atomics, I don't think anyone got around to pointing out that in the unlikely case that the refcnt is

[dpdk-dev] [PATCH] claim responsibility for KVM virtio PMD, vhost backend, and XEN virtio solution.

2015-03-30 Thread Thomas Monjalon
2015-03-30 15:23, Xie, Huawei: > On 3/30/2015 11:08 PM, Thomas Monjalon wrote: > > 2015-03-30 14:52, Xie, Huawei: > >> On 3/30/2015 8:25 PM, Thomas Monjalon wrote: > >>> 2015-03-30 08:31, Xie, Huawei: > On 3/9/2015 11:45 PM, Huawei Xie wrote: > > --- > > MAINTAINERS | 7 +++ >

[dpdk-dev] [PATCH] cast used->idx to volatile

2015-03-30 Thread Linhaifeng
On 2015/3/24 18:06, Xie, Huawei wrote: > On 3/24/2015 3:44 PM, Linhaifeng wrote: >> >> On 2015/3/24 9:53, Xie, Huawei wrote: >>> On 3/24/2015 9:00 AM, Linhaifeng wrote: On 2015/3/23 20:54, Xie, Huawei wrote: >> -Original Message- >> From: Linhaifeng [mailto:haifeng.lin at hua

[dpdk-dev] [PATCH] claim responsibility for KVM virtio PMD, vhost backend, and XEN virtio solution.

2015-03-30 Thread Thomas Monjalon
2015-03-30 14:52, Xie, Huawei: > On 3/30/2015 8:25 PM, Thomas Monjalon wrote: > > 2015-03-30 08:31, Xie, Huawei: > >> On 3/9/2015 11:45 PM, Huawei Xie wrote: > >>> --- > >>> MAINTAINERS | 7 +++ > >>> 1 file changed, 7 insertions(+) > >>> > >>> diff --git a/MAINTAINERS b/MAINTAINERS > >>> inde

[dpdk-dev] [PATCH] mbuf: add comment explaining confusing code

2015-03-30 Thread Neil Horman
On Mon, Mar 30, 2015 at 09:39:13PM +0200, Marc Sune wrote: > > > On 27/03/15 15:30, Bruce Richardson wrote: > >On Fri, Mar 27, 2015 at 10:07:35AM -0400, Neil Horman wrote: > >>On Fri, Mar 27, 2015 at 11:32:38AM +, Bruce Richardson wrote: > >>>On Fri, Mar 27, 2015 at 06:29:56AM -0400, Neil Hor

[dpdk-dev] [PATCH v2] rte_mbuf: mbuf bulk alloc/free functions added + unittest

2015-03-30 Thread Neil Horman
On Mon, Mar 30, 2015 at 10:04:20PM +0300, Vadim Suraev wrote: > Hi, Neil > > >I think what you need to do here is enhance the underlying pktmbuf > interface > >such that an rte_mbuf structure has a destructor method association with it > >which is called when its refcnt reaches zero. That way the

[dpdk-dev] [PATCH v4 0/7] Move EAL common function

2015-03-30 Thread Ravi Kerur
Hi Thomas, Sure, please let me know when it is needed I can work on it. Thanks, Ravi On Mon, Mar 30, 2015 at 2:29 PM, Thomas Monjalon wrote: > Hi Ravi, > > 2015-01-06 12:24, Ravi Kerur: > > Fix v3 PATCH review comments from Thomas. > > eal_common.c is further split into eal_common_system.c and

[dpdk-dev] [PATCH] cast used->idx to volatile

2015-03-30 Thread Xie, Huawei
On 3/30/2015 5:21 PM, Linhaifeng wrote: > > On 2015/3/24 18:06, Xie, Huawei wrote: >> On 3/24/2015 3:44 PM, Linhaifeng wrote: >>> On 2015/3/24 9:53, Xie, Huawei wrote: On 3/24/2015 9:00 AM, Linhaifeng wrote: > On 2015/3/23 20:54, Xie, Huawei wrote: >>> -Original Message- >>

[dpdk-dev] [PATCH] claim responsibility for KVM virtio PMD, vhost backend, and XEN virtio solution.

2015-03-30 Thread Xie, Huawei
On 3/30/2015 11:33 PM, Thomas Monjalon wrote: > 2015-03-30 15:23, Xie, Huawei: >> On 3/30/2015 11:08 PM, Thomas Monjalon wrote: >>> 2015-03-30 14:52, Xie, Huawei: On 3/30/2015 8:25 PM, Thomas Monjalon wrote: > 2015-03-30 08:31, Xie, Huawei: >> On 3/9/2015 11:45 PM, Huawei Xie wrote: >>

[dpdk-dev] [PATCH] claim responsibility for KVM virtio PMD, vhost backend, and XEN virtio solution.

2015-03-30 Thread Xie, Huawei
On 3/30/2015 11:08 PM, Thomas Monjalon wrote: > 2015-03-30 14:52, Xie, Huawei: >> On 3/30/2015 8:25 PM, Thomas Monjalon wrote: >>> 2015-03-30 08:31, Xie, Huawei: On 3/9/2015 11:45 PM, Huawei Xie wrote: > --- > MAINTAINERS | 7 +++ > 1 file changed, 7 insertions(+) > >

[dpdk-dev] [PATCH] claim responsibility for KVM virtio PMD, vhost backend, and XEN virtio solution.

2015-03-30 Thread Xie, Huawei
On 3/30/2015 8:25 PM, Thomas Monjalon wrote: > 2015-03-30 08:31, Xie, Huawei: >> On 3/9/2015 11:45 PM, Huawei Xie wrote: >>> --- >>> MAINTAINERS | 7 +++ >>> 1 file changed, 7 insertions(+) >>> >>> diff --git a/MAINTAINERS b/MAINTAINERS >>> index 07fdf5e..b4327d3 100644 >>> --- a/MAINTAINERS >

[dpdk-dev] [PATCH] claim responsibility for KVM virtio PMD, vhost backend, and XEN virtio solution.

2015-03-30 Thread Thomas Monjalon
2015-03-30 08:31, Xie, Huawei: > On 3/9/2015 11:45 PM, Huawei Xie wrote: > > --- > > MAINTAINERS | 7 +++ > > 1 file changed, 7 insertions(+) > > > > diff --git a/MAINTAINERS b/MAINTAINERS > > index 07fdf5e..b4327d3 100644 > > --- a/MAINTAINERS > > +++ b/MAINTAINERS > > @@ -131,6 +131,12 @@ F:

[dpdk-dev] [PATCH v8 3/3] ixgbe: Add LRO support

2015-03-30 Thread Ananyev, Konstantin
Hi Vlad, > -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Vlad Zolotarov > Sent: Wednesday, March 18, 2015 5:52 PM > To: dev at dpdk.org > Subject: [dpdk-dev] [PATCH v8 3/3] ixgbe: Add LRO support > > - Only x540 and 82599 devices support LRO. > - Add

[dpdk-dev] [PATCH] pipeline: add statistics for librte_pipeline ports and tables

2015-03-30 Thread Maciej Gajdzica
From: Pawel Wodkowski This patch adds statistics collection for librte_pipeline. Those statistics ale disabled by default during build time. This patchset depends on patchset: port: added port statistics Signed-off-by: Pawel Wodkowski --- config/common_bsdapp | 1 + config/com

[dpdk-dev] [PATCH 10/10] table: added lpm table stats

2015-03-30 Thread Maciej Gajdzica
--- config/common_bsdapp |1 + config/common_linuxapp |1 + lib/librte_table/rte_table_lpm.c | 34 ++ 3 files changed, 36 insertions(+) diff --git a/config/common_bsdapp b/config/common_bsdapp index 08b2b4a..829591c 100644 --- a/conf

[dpdk-dev] [PATCH 09/10] table: added lpm_ipv6 table stats

2015-03-30 Thread Maciej Gajdzica
--- config/common_bsdapp |1 + config/common_linuxapp|1 + lib/librte_table/rte_table_lpm_ipv6.c | 34 + 3 files changed, 36 insertions(+) diff --git a/config/common_bsdapp b/config/common_bsdapp index 8206d22..08b2b4a 100

[dpdk-dev] [PATCH 08/10] table: added hash_lru table stats

2015-03-30 Thread Maciej Gajdzica
--- config/common_bsdapp |1 + config/common_linuxapp|1 + lib/librte_table/rte_table_hash_lru.c | 44 + 3 files changed, 46 insertions(+) diff --git a/config/common_bsdapp b/config/common_bsdapp index 7708b1c..8206d22 100

[dpdk-dev] [PATCH 07/10] table: added hash_key8 table stats

2015-03-30 Thread Maciej Gajdzica
--- config/common_bsdapp |1 + config/common_linuxapp |1 + lib/librte_table/rte_table_hash_key8.c | 52 3 files changed, 54 insertions(+) diff --git a/config/common_bsdapp b/config/common_bsdapp index a77e422..7708b1c 1

[dpdk-dev] [PATCH 06/10] table: added hash_key32 table stats

2015-03-30 Thread Maciej Gajdzica
--- config/common_bsdapp|1 + config/common_linuxapp |1 + lib/librte_table/rte_table_hash_key32.c | 41 +++ 3 files changed, 43 insertions(+) diff --git a/config/common_bsdapp b/config/common_bsdapp index 2f92f69..a77e422

[dpdk-dev] [PATCH 05/10] table: added hash_key16 table stats

2015-03-30 Thread Maciej Gajdzica
--- config/common_bsdapp|1 + config/common_linuxapp |1 + lib/librte_table/rte_table_hash_key16.c | 41 +++ 3 files changed, 43 insertions(+) diff --git a/config/common_bsdapp b/config/common_bsdapp index 7f35d53..2f92f69

[dpdk-dev] [PATCH 04/10] table: added hash_ext table stats

2015-03-30 Thread Maciej Gajdzica
--- config/common_bsdapp |1 + config/common_linuxapp|1 + lib/librte_table/rte_table_hash_ext.c | 44 + 3 files changed, 46 insertions(+) diff --git a/config/common_bsdapp b/config/common_bsdapp index 1aba0d5..7f35d53 100

[dpdk-dev] [PATCH 03/10] table: added array table stats

2015-03-30 Thread Maciej Gajdzica
--- config/common_bsdapp |1 + config/common_linuxapp |1 + lib/librte_table/rte_table_array.c | 34 +- 3 files changed, 35 insertions(+), 1 deletion(-) diff --git a/config/common_bsdapp b/config/common_bsdapp index 20aa745..1aba

[dpdk-dev] [PATCH 02/10] table: added acl table stats

2015-03-30 Thread Maciej Gajdzica
--- config/common_bsdapp |1 + config/common_linuxapp |1 + lib/librte_table/rte_table_acl.c | 35 +++ 3 files changed, 37 insertions(+) diff --git a/config/common_bsdapp b/config/common_bsdapp index 4c32f43..20aa745 100644 --- a/con

[dpdk-dev] [PATCH 01/10] table: added structure for storing table stats

2015-03-30 Thread Maciej Gajdzica
--- lib/librte_table/rte_table.h | 25 + 1 file changed, 25 insertions(+) diff --git a/lib/librte_table/rte_table.h b/lib/librte_table/rte_table.h index d57bc33..9860b7b 100644 --- a/lib/librte_table/rte_table.h +++ b/lib/librte_table/rte_table.h @@ -58,6 +58,12 @@ exter

[dpdk-dev] [PATCH 00/10] table: added table statistics

2015-03-30 Thread Maciej Gajdzica
Added statistics for every type of table. By default all table statistics are disabled, user must activate them in config file. Maciej Gajdzica (10): table: added structure for storing table stats table: added acl table stats table: added array table stats table: added hash_ext table stats

[dpdk-dev] [PATCH 13/13] port: added port_sink stats

2015-03-30 Thread Maciej Gajdzica
--- config/common_bsdapp |1 + config/common_linuxapp |1 + lib/librte_port/rte_port_source_sink.c | 63 ++-- 3 files changed, 61 insertions(+), 4 deletions(-) diff --git a/config/common_bsdapp b/config/common_bsdapp index 22

[dpdk-dev] VFIO in setup.sh

2015-03-30 Thread Stephen Hemminger
On Mon, 30 Mar 2015 13:35:07 -0700 Stephen Hemminger wrote: > This code around vfio in setup script looks incorrect, is anyone using it: > > 1. Why set the execute bit, when you want read-write? >Looks like a bug (or worse a security hole). > # make sure regular users can read /dev/vfi

[dpdk-dev] [PATCH 12/13] port: added port_source stats

2015-03-30 Thread Maciej Gajdzica
--- config/common_bsdapp |1 + config/common_linuxapp |1 + lib/librte_port/rte_port_source_sink.c | 35 3 files changed, 37 insertions(+) diff --git a/config/common_bsdapp b/config/common_bsdapp index f222cef..2241169 1

[dpdk-dev] VFIO in setup.sh

2015-03-30 Thread Stephen Hemminger
This code around vfio in setup script looks incorrect, is anyone using it: 1. Why set the execute bit, when you want read-write? Looks like a bug (or worse a security hole). # make sure regular users can read /dev/vfio echo "chmod /dev/vfio" sudo chmod a+x /dev/vfio 3.

[dpdk-dev] [PATCH 11/13] port: added port_sched_writer stats

2015-03-30 Thread Maciej Gajdzica
--- config/common_bsdapp |1 + config/common_linuxapp |1 + lib/librte_port/rte_port_sched.c | 57 ++ 3 files changed, 54 insertions(+), 5 deletions(-) diff --git a/config/common_bsdapp b/config/common_bsdapp index 4b1a877..f222c

[dpdk-dev] [PATCH 10/13] port: added port_sched_reader stats

2015-03-30 Thread Maciej Gajdzica
--- config/common_bsdapp |1 + config/common_linuxapp |1 + lib/librte_port/rte_port_sched.c | 39 +- 3 files changed, 40 insertions(+), 1 deletion(-) diff --git a/config/common_bsdapp b/config/common_bsdapp index 4a06da6..4b1a87

[dpdk-dev] issues with packets bigger than 1500 bytes

2015-03-30 Thread Newman Poborsky
Hi, I'm having some problems with dpdk on links that have packets bigger than 1500bytes. Some packets that are receieved are around 4K, and some are 9k jumbo frames. When using testpmd app, I can see a lot of RX-errors (both RX-missed and RX-badlen). When I set max packet length to 9000, RX-badl

[dpdk-dev] [PATCH v2 1/5] mbuf: fix clone support when application uses private mbuf data

2015-03-30 Thread Ananyev, Konstantin
Hi Olivier, > -Original Message- > From: Olivier MATZ [mailto:olivier.matz at 6wind.com] > Sent: Friday, March 27, 2015 3:17 PM > To: Ananyev, Konstantin; dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH v2 1/5] mbuf: fix clone support when > application uses private mbuf data > > Hi Kon

[dpdk-dev] [PATCH 09/13] port: added port_ring_writer_nodrop stats

2015-03-30 Thread Maciej Gajdzica
--- config/common_bsdapp|1 + config/common_linuxapp |1 + lib/librte_port/rte_port_ring.c | 39 +++ 3 files changed, 41 insertions(+) diff --git a/config/common_bsdapp b/config/common_bsdapp index 94930ed..4a06da6 100644 --- a/co

[dpdk-dev] [PATCH 08/13] port: added port_ring_writer stats

2015-03-30 Thread Maciej Gajdzica
--- config/common_bsdapp|1 + config/common_linuxapp |1 + lib/librte_port/rte_port_ring.c | 40 +++ 3 files changed, 42 insertions(+) diff --git a/config/common_bsdapp b/config/common_bsdapp index b51095c..94930ed 100644 --- a/co

[dpdk-dev] [PATCH 07/13] port: added port_ring_reader stats

2015-03-30 Thread Maciej Gajdzica
--- config/common_bsdapp|1 + config/common_linuxapp |1 + lib/librte_port/rte_port_ring.c | 39 ++- 3 files changed, 40 insertions(+), 1 deletion(-) diff --git a/config/common_bsdapp b/config/common_bsdapp index 0e73ce6..b51095c

[dpdk-dev] [PATCH 06/13] port: added port_ras stats

2015-03-30 Thread Maciej Gajdzica
--- config/common_bsdapp |1 + config/common_linuxapp |1 + lib/librte_port/rte_port_ras.c | 38 ++ 3 files changed, 40 insertions(+) diff --git a/config/common_bsdapp b/config/common_bsdapp index 523b9e9..0e73ce6 100644 --- a/config

[dpdk-dev] [PATCH 05/13] port: added port_frag stats

2015-03-30 Thread Maciej Gajdzica
--- config/common_bsdapp|1 + config/common_linuxapp |1 + lib/librte_port/rte_port_frag.c | 36 3 files changed, 38 insertions(+) diff --git a/config/common_bsdapp b/config/common_bsdapp index ed01d2d..523b9e9 100644 --- a/confi

[dpdk-dev] [PATCH 04/13] port: added port_ethdev_writer_nodrop stats

2015-03-30 Thread Maciej Gajdzica
--- config/common_bsdapp |1 + config/common_linuxapp|1 + lib/librte_port/rte_port_ethdev.c | 38 + 3 files changed, 40 insertions(+) diff --git a/config/common_bsdapp b/config/common_bsdapp index d62e6d9..ed01d2d 100644 ---

[dpdk-dev] [PATCH 03/13] port: added port_ethdev_writer stats

2015-03-30 Thread Maciej Gajdzica
--- config/common_bsdapp |1 + config/common_linuxapp|1 + lib/librte_port/rte_port_ethdev.c | 38 + 3 files changed, 40 insertions(+) diff --git a/config/common_bsdapp b/config/common_bsdapp index 823e295..d62e6d9 100644 ---

[dpdk-dev] [PATCH 02/13] port: added port_ethdev_reader stats

2015-03-30 Thread Maciej Gajdzica
--- config/common_bsdapp |1 + config/common_linuxapp|1 + lib/librte_port/rte_port_ethdev.c | 37 - 3 files changed, 38 insertions(+), 1 deletion(-) diff --git a/config/common_bsdapp b/config/common_bsdapp index 8ff4dc2..823e

[dpdk-dev] [PATCH 01/13] port: added structures for port stats

2015-03-30 Thread Maciej Gajdzica
--- lib/librte_port/rte_port.h | 60 1 file changed, 55 insertions(+), 5 deletions(-) diff --git a/lib/librte_port/rte_port.h b/lib/librte_port/rte_port.h index d84e5a1..ab433e5 100644 --- a/lib/librte_port/rte_port.h +++ b/lib/librte_port/rte_port.h

[dpdk-dev] [PATCH 00/13] port: added port statistics

2015-03-30 Thread Maciej Gajdzica
Added statistics for every type of port. By default all port statistics are disabled, user must activate them in config file. This patchset depends on two patchsets: port: added ethdev_writer_nodrop and ring_writer_nodrop ports port: added frag_ipv6 and ras_ipv6 ports Maciej Gajdzica (13): port

[dpdk-dev] [PATCH 3/3] port: added ipv6 reassembly port

2015-03-30 Thread Maciej Gajdzica
--- lib/librte_port/rte_port_ras.c | 142 +--- lib/librte_port/rte_port_ras.h |9 ++- 2 files changed, 112 insertions(+), 39 deletions(-) diff --git a/lib/librte_port/rte_port_ras.c b/lib/librte_port/rte_port_ras.c index b6ab67a..5eb627a 100644 --- a/lib/l

[dpdk-dev] [PATCH 2/3] port: added ipv6 fragmentation port

2015-03-30 Thread Maciej Gajdzica
--- lib/librte_port/rte_port_frag.c | 61 +-- lib/librte_port/rte_port_frag.h |9 +- 2 files changed, 54 insertions(+), 16 deletions(-) diff --git a/lib/librte_port/rte_port_frag.c b/lib/librte_port/rte_port_frag.c index dce33d5..c4c05dc 100644 --- a/

[dpdk-dev] [PATCH 1/3] port: removed IPV4_MTU_DEFAULT define

2015-03-30 Thread Maciej Gajdzica
p->mtu field should be used instead. --- lib/librte_port/rte_port_frag.c |6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/lib/librte_port/rte_port_frag.c b/lib/librte_port/rte_port_frag.c index ff0ab9b..dce33d5 100644 --- a/lib/librte_port/rte_port_frag.c +++ b/lib/librt

[dpdk-dev] [PATCH 0/3] port: added frag_ipv6 and ras_ipv6 ports

2015-03-30 Thread Maciej Gajdzica
Added ipv6 versions of ip fragmentation and ip reassembly ports. Maciej Gajdzica (3): port: removed IPV4_MTU_DEFAULT define port: added ipv6 fragmentation port port: added ipv6 reassembly port lib/librte_port/rte_port_frag.c | 67 -- lib/librte_port/rte_port_frag.h |9

[dpdk-dev] [PATCH] pipeline: add statistics for librte_pipeline ports and tables

2015-03-30 Thread Dumitrescu, Cristian
> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Maciej Gajdzica > Sent: Monday, March 30, 2015 1:06 PM > To: dev at dpdk.org > Cc: Wodkowski, PawelX > Subject: [dpdk-dev] [PATCH] pipeline: add statistics for librte_pipeline ports > and tables > > From: Pawe

[dpdk-dev] [PATCH v2] DPDK does not build on gcc 4.4, as it complains due to strict-aliasing rules in virtual_pmd and link_bonding_mode4 tests, with no errors in next gcc versions:

2015-03-30 Thread Pablo de Lara
CC virtual_pmd.o CC test_link_bonding_mode4.o cc1: warnings being treated as errors /root/dpdk/app/test/test_link_bonding_mode4.c: In function ?test_mode4_expired?: /root/dpdk/x86_64-native-linuxapp-gcc/include/rte_ring.h:645: error: dereferencing pointer ?pkt.409? does break strict-aliasing rules

[dpdk-dev] [PATCH 00/10] table: added table statistics

2015-03-30 Thread Dumitrescu, Cristian
> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Maciej Gajdzica > Sent: Monday, March 30, 2015 12:42 PM > To: dev at dpdk.org > Subject: [dpdk-dev] [PATCH 00/10] table: added table statistics > > Added statistics for every type of table. By default all tabl

[dpdk-dev] [PATCH 00/13] port: added port statistics

2015-03-30 Thread Dumitrescu, Cristian
> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Maciej Gajdzica > Sent: Monday, March 30, 2015 11:29 AM > To: dev at dpdk.org > Subject: [dpdk-dev] [PATCH 00/13] port: added port statistics > > Added statistics for every type of port. By default all port st

[dpdk-dev] [PATCH 3/3] port: added ring_writer_nodrop port

2015-03-30 Thread Maciej Gajdzica
When ethdev_writer_nodrop port fails to send data, it tries to resend. Operation is aborted when maximum number of retries is reached. --- lib/librte_port/rte_port_ring.c | 226 +++ lib/librte_port/rte_port_ring.h | 16 +++ 2 files changed, 242 insertions(+)

[dpdk-dev] [PATCH 2/3] port: added ethdev_writer_nodrop port

2015-03-30 Thread Maciej Gajdzica
When ethdev_writer_nodrop port fails to send data, it tries to resend. Operation is aborted when maximum number of retries is reached. --- lib/librte_port/rte_port_ethdev.c | 230 + lib/librte_port/rte_port_ethdev.h | 19 +++ 2 files changed, 249 insertions(

[dpdk-dev] [PATCH 1/3] port: added WRITER_APPROACH == 1 implementation to ring port

2015-03-30 Thread Maciej Gajdzica
Added better optimized implementation of tx_bulk for ring writer port based on similar solution in ethdev_writer port. New implementation sends burst without copying data to internal buffer if it is possible. --- lib/librte_port/rte_port_ring.c | 59 +++ 1 fi

[dpdk-dev] [PATCH 0/3] port: added ethdev_writer_nodrop and ring_writer_nodrop ports

2015-03-30 Thread Maciej Gajdzica
When nodrop writer port fails to send data, it retries until reach maximum number of retries. Also added new tx_bulk implementation for ring writer port. Maciej Gajdzica (3): port: added WRITER_APPROACH == 1 implementation to ring port port: added ethdev_writer_nodrop port port: added ring_w

[dpdk-dev] [PATCH 0/3] port: added frag_ipv6 and ras_ipv6 ports

2015-03-30 Thread Dumitrescu, Cristian
> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Maciej Gajdzica > Sent: Monday, March 30, 2015 11:15 AM > To: dev at dpdk.org > Subject: [dpdk-dev] [PATCH 0/3] port: added frag_ipv6 and ras_ipv6 ports > > Added ipv6 versions of ip fragmentation and ip reass

[dpdk-dev] [PATCH 0/3] port: added ethdev_writer_nodrop and ring_writer_nodrop ports

2015-03-30 Thread Dumitrescu, Cristian
> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Maciej Gajdzica > Sent: Monday, March 30, 2015 10:57 AM > To: dev at dpdk.org > Subject: [dpdk-dev] [PATCH 0/3] port: added ethdev_writer_nodrop and > ring_writer_nodrop ports > > When nodrop writer port fails

[dpdk-dev] [PATCH] mbuf: add comment explaining confusing code

2015-03-30 Thread Stephen Hemminger
On Mon, 30 Mar 2015 17:39:06 + Don Provan wrote: > In all the debate about atomics, I don't think anyone got around to pointing > out that in the unlikely case that the refcnt is not 1, then it's equally > unlikely that decrementing it will result in 0 despite the code's claim to > the con

[dpdk-dev] [PATCH] test: Disable strict-aliasing warnings

2015-03-30 Thread De Lara Guarch, Pablo
> -Original Message- > From: De Lara Guarch, Pablo > Sent: Friday, March 27, 2015 10:11 AM > To: Thomas Monjalon > Cc: dev at dpdk.org > Subject: RE: [dpdk-dev] [PATCH] test: Disable strict-aliasing warnings > > > > > -Original Message- > > From: dev [mailto:dev-bounces at dpdk

[dpdk-dev] [PATCH 2/3] port: added ethdev_writer_nodrop port

2015-03-30 Thread Walukiewicz, Miroslaw
> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Maciej Gajdzica > Sent: Monday, March 30, 2015 11:57 AM > To: dev at dpdk.org > Subject: [dpdk-dev] [PATCH 2/3] port: added ethdev_writer_nodrop port > > When ethdev_writer_nodrop port fails to send data, it t

[dpdk-dev] Symmetric RSS Hashing, Part 2

2015-03-30 Thread Matt Laswell
That's really encouraging. Thanks! One thing I'll note is that if my reading of the original paper is accurate, the 0x6d5a value isn't there in order to cause symmetry - other repeated 16 bit values will do that, as you've seen. What the 0x6d5a value gets you is symmetry while preserving RSS's e

[dpdk-dev] determine number of free TX descriptors in DPDK transmit queue

2015-03-30 Thread Walukiewicz, Miroslaw
Hello, Is there any method of determining the number free TX descriptor in specific TX queue? I know that when transmit function is called with some number packets to send and then number returned by function is different than provided that means that queue is full. This mechanism works good

[dpdk-dev] [PATCH 00/13] port: added port statistics

2015-03-30 Thread Stephen Hemminger
On Mon, 30 Mar 2015 12:28:51 +0200 Maciej Gajdzica wrote: > Added statistics for every type of port. By default all port statistics > are disabled, user must activate them in config file. Can we stop with the config file option for everything nonsense. I know that it makes sense for demos and sp

[dpdk-dev] [PATCH] pipeline: add statistics for librte_pipeline ports and tables

2015-03-30 Thread Stephen Hemminger
On Mon, 30 Mar 2015 14:06:22 +0200 Maciej Gajdzica wrote: > + /* Stats for this table. */ > + uint64_t n_pkts_dropped_by_lkp_hit_ah; > + uint64_t n_pkts_dropped_by_lkp_miss_ah; > + uint64_t n_pkts_dropped_lkp_hit; > + uint64_t n_pkts_dropped_lkp_miss; > }; Rather than extrem

[dpdk-dev] [PATCH] claim responsibility for KVM virtio PMD, vhost backend, and XEN virtio solution.

2015-03-30 Thread Xie, Huawei
On 3/9/2015 11:45 PM, Huawei Xie wrote: > --- > MAINTAINERS | 7 +++ > 1 file changed, 7 insertions(+) > > diff --git a/MAINTAINERS b/MAINTAINERS > index 07fdf5e..b4327d3 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -131,6 +131,12 @@ F: app/test-pmd/mempool_* > F: examples/vhost_xen/ >

[dpdk-dev] [PATCH] scripts: enable extended tag of PCIe

2015-03-30 Thread Zhang, Helin
Hi Patrick Yes, good point! I have a plan to implement writing pcie config space directly for i40e devices only, as pci config space accessing seems ready recently. That time, the extended-tag will be enabled by default for i40e devices only. Thank you for the good suggestion! Regards, Helin >

[dpdk-dev] [PATCH] scripts: enable extended tag of PCIe

2015-03-30 Thread Lu, Patrick
Hi Helin and Thomas, Rather than an additional patch. Can we always enable extended tag in i40e driver? There is no negative impact for enabling extended tag. (Even on devices that don't support extended tag, the PCIe packet will simply ignore the bit and go on.) Best, Patrick -Original