[dpdk-dev] [PATCH 1/3 v2] librte_hash: Fix unsupported instruction `crc32' in i686 platform

Acked-by: Yerden Zhumabekov 05.03.2015 22:55, Michael Qiu ?: > CC rte_hash.o > Error: unsupported instruction `crc32' > > The root cause is that i686 platform does not support 'crc32q' > Need make it only available in x86_64 platform > > Signed-off-by: Michael Qiu > --- > v2 --> v1: >

[dpdk-dev] [PATCH v2 5/6] common_linuxapp: Added CONFIG_RTE_ETHDEV_LRO_SUPPORT option

On Mar 5, 2015 9:14 PM, "Thomas Monjalon" wrote: > > 2015-03-05 16:18, Vlad Zolotarov: > > > > On 03/05/15 16:01, Thomas Monjalon wrote: > > > 2015-03-05 15:39, Vlad Zolotarov: > > >> On 03/05/15 15:19, Thomas Monjalon wrote: > > >>> 2015-03-05 13:28, Vlad Zolotarov: > > Enables LRO support i

[dpdk-dev] [PATCH 1/3] librte_hash: Fix unsupported instruction `crc32' in i686 platform

Hi Michael, Thanks for this patch, in fact I didn't try to compile it on i686 when developing original software fallback for CRC32. I think if we want to make code compilable as wide as possible, we should compile out all SSE4.2 instructions. As to the patch, we may compile out 'crc32l' instructi

[dpdk-dev] [PATCH] lib/librte_vhost: remove vhost device from data plane when receive VHOST_SET_MEM_TABLE message

> > This patch fixes the segfault issue in the case vhost receives new > > VHOST_SET_MEM_TABLE message without VHOST_VRING_GET_VRING_BASE(which > > we uses as the stop message). > > > > Signed-off-by: Huawei Xie > > Acked-by: Tommy Long Applied, thanks

[dpdk-dev] [PATCH 2/3 v2] app/test: Fix size_t printf format issue

test_hash.c: In function ?test_crc32_hash_alg_equiv?: error: format ?%lu? expects argument of type ?long unsigned int?, but argument 2 has type ?size_t? [-Werror=format] According to C99, for size_t type should use format "%zu" Signed-off-by: Michael Qiu --- v2 --> v1: typo fix of "forma

[dpdk-dev] [PATCH 3/3 v3] =?UTF-8?q?librte=5Feal/common:=20Fix=20redeclaration=20of?= =?UTF-8?q?=20enumerator=20=E2=80=98REG=5FEAX=E2=80=99?=

include/rte_cpuflags.h:154:2: error: redeclaration of enumerator ?REG_EAX? In file included from /usr/include/signal.h:358:0, from /usr/include/sys/wait.h:30, from /root/dpdk/app/test/test_mp_secondary.c:50: /usr/include/sys/ucontext.h:180:3: note: previous definit

[dpdk-dev] [PATCH] ethdev: add missing symbol export for rte_eth_dev_release_port

2015-03-04 08:12, Panu Matilainen: > Fixes: 36ec8585b298 ("ethdev: release port") > > Signed-off-by: Panu Matilainen Acked-by: Thomas Monjalon Applied, thanks

[dpdk-dev] [PATCH 3/3 v2] =?UTF-8?q?librte=5Feal/common:=20Fix=20redeclaration=20of?= =?UTF-8?q?=20enumerator=20=E2=80=98REG=5FEAX=E2=80=99?=

include/rte_cpuflags.h:154:2: error: redeclaration of enumerator ?REG_EAX? In file included from /usr/include/signal.h:358:0, from /usr/include/sys/wait.h:30, from /root/dpdk/app/test/test_mp_secondary.c:50: /usr/include/sys/ucontext.h:180:3: note: previous definit

[dpdk-dev] [PATCH v2] tools/dpdk_nic_bind: Fix can't bind virtio-pci issue

> > The dpdk_nic_bind script will not allow ports to be bound or unbound if > > none of the > > kernel modules supported by DPDK is loaded. This patch relaxes this > > restriction by > > checking if a DPDK module is actually requested. The example below > > illustrates this > > problem: > > > >

[dpdk-dev] [PATCH 3/3] librte_eal/common: Fix redeclaration of enumerator ‘REG_EAX’

include/rte_cpuflags.h:154:2: error: redeclaration of enumerator ?REG_EAX? In file included from /usr/include/signal.h:358:0, from /usr/include/sys/wait.h:30, from /root/dpdk/app/test/test_mp_secondary.c:50: /usr/include/sys/ucontext.h:180:3: note: previous definit

[dpdk-dev] [PATCH 2/3] app/test: Fix size_t printf formart issue

test_hash.c: In function ?test_crc32_hash_alg_equiv?: error: format ?%lu? expects argument of type ?long unsigned int?, but argument 2 has type ?size_t? [-Werror=format] According to C99, for size_t type should use formart "%zu" Signed-off-by: Michael Qiu --- app/test/test_hash.c | 2 +- 1 file

[dpdk-dev] [PATCH 1/3] librte_hash: Fix unsupported instruction `crc32' in i686 platform

CC rte_hash.o Error: unsupported instruction `crc32' The root cause is that i686 platform does not support 'crc32q' Need make it only available in x86_64 platform Signed-off-by: Michael Qiu --- lib/librte_hash/rte_hash_crc.h | 4 1 file changed, 4 insertions(+) diff --git a/lib/librte_has

[dpdk-dev] [PATCH 0/3] dpdk2.0-rc1 build error fix

This patch set is to fix dpdk2.0-rc1 compile error. Michael Qiu (3): librte_hash: Fix unsupported instruction `crc32' in i686 platform app/test: Fix size_t printf formart issue librte_eal/common: Fix redeclaration of enumerator ?REG_EAX? app/test/test_hash.c |

[dpdk-dev] [PATCH] Missing use of macro rte_eth_dev_is_valid_port()

> > Signed-off-by: Keith Wiles > > Acked-by: John McNamara Some checks with rte_eth_dev_is_valid_port() were missed when merging hotplug and callbacks features. Fixes: c282abd2a6cd ("ethdev: remove assumption that port will not be detached") Applied, thanks

[dpdk-dev] [PATCH v2 5/6] common_linuxapp: Added CONFIG_RTE_ETHDEV_LRO_SUPPORT option

2015-03-05 16:18, Vlad Zolotarov: > > On 03/05/15 16:01, Thomas Monjalon wrote: > > 2015-03-05 15:39, Vlad Zolotarov: > >> On 03/05/15 15:19, Thomas Monjalon wrote: > >>> 2015-03-05 13:28, Vlad Zolotarov: > Enables LRO support in PMDs. > > Signed-off-by: Vlad Zolotarov > --- >

[dpdk-dev] ixgbe vector mode not working.

2015-02-28 03:33, Liang, Cunming: > Hi Stephen, > > The root cause is about the rx descriptor number. > As we use below code to quick process the rx_tail wrap, it require rxd value > is a 2^n. > "rxq->rx_tail = (uint16_t)(rxq->rx_tail & (rxq->nb_rx_desc - 1));" > We should add more checking on th

[dpdk-dev] Build failure on FreeBSD-10.1-RELEASE

2015-03-05 16:08, Tetsuya Mukawa: > On 2015/03/04 19:15, Bruce Richardson wrote: > > On Wed, Mar 04, 2015 at 10:33:14AM +0100, Olivier MATZ wrote: > >> Hi Tetsuya, Hi Bruce, > >> > >> On 03/04/2015 04:34 AM, Tetsuya Mukawa wrote: > >>> On 2015/03/02 19:22, Bruce Richardson wrote: > On Mon, Mar

[dpdk-dev] [PATCH v1] ixgbe/vector: add rxd 2^n check to avoid mbuf leak

> > The mbuf leak happens when the assigned number of rx descriptor is not > > power of 2. > > As it's presumed on vpmd rx(for rx_tail wrap), adding condition check to > > prevent it. > > The root cause reference code in *_recv_raw_pkts_vec* as below. > > "rxq->rx_tail = (uint16_t)(rxq->rx_tail &

[dpdk-dev] [PATCH] mk: Remove '-fdirectives-only' flag from mk/rte.sdkconfig.mk

> > The '-fdirectives-only' flag doesn't exist in cpp of FreeBSD. > > To remove expanding macros when parsing the config files won't > > add any issue. > > > > Signed-off-by: Tetsuya Mukawa > Acked-by: Bruce Richardson Applied, thanks

[dpdk-dev] [PATCH 3/7] vmxnet3: cleanup txq stats

On 2/25/15, 6:31 PM, "Stephen Hemminger" wrote: >There are several stats here which are never set, and have no way >to be displayed. Assume in future xstats could be used. > >Signed-off-by: Stephen Hemminger Acked-by: Yong Wang >--- > lib/librte_pmd_vmxnet3/vmxnet3_ring.h | 16 ++

[dpdk-dev] [PATCH] ethdev: remove useless parameter in init functions

The pointer to struct eth_driver is not used and is already set in struct rte_eth_dev. It's a small cleanup in PMD API which probably needs more attention to make clear what is a driver, a PCI driver, an ethernet driver, etc. Signed-off-by: Thomas Monjalon --- lib/librte_ether/rte_ethdev.c

[dpdk-dev] [PATCH 4/7] vmxnet3: add support for multi-segment transmit

A quick glance over v2 shows that it only made the change for max segment check. I am not sure if all the other comments on v1 of this patch are missed or ignored? If it?s the latter, can you explain your reasoning why they are not addressed? On 2/25/15, 6:31 PM, "Stephen Hemminger" wrote: >C

[dpdk-dev] [PATCH 6/7] vmxnet3: support RSS and refactor offload

I believe I have ACKed v1 of this commit but I didn't see ACKed-by in v2. Or is there any changes from v1? If that?s the case, can you explain the changes in the changelog? On 2/25/15, 6:32 PM, "Stephen Hemminger" wrote: >Refactor the logic to compute receive offload flags to a simpler >functi

[dpdk-dev] [PATCH 00/10] eal: rte_tailq api cleanup

On Wed, Mar 04, 2015 at 10:50:00PM +0100, David Marchand wrote: > This is a first cleanup at trying to remove references to other dpdk libraries > from eal. > > This cleanup is focused on rte_tailq api which has been marked as "for > internal > use" for quite some time now. > Rather than have a s

[dpdk-dev] [PATCH 3/3 v2] librte_eal/common: Fix redeclaration of enumerator ‘REG_EAX’

2015-03-05 16:31, Qiu, Michael: > On 2015/3/5 22:39, Thomas Monjalon wrote: > > 2015-03-05 14:03, Qiu, Michael: > >> On 3/5/2015 9:54 PM, David Marchand wrote: > >>> On Thu, Mar 5, 2015 at 2:50 PM, Michael Qiu >>> > wrote: > >>> > >>> include/rte_cpuflags.h:154

[dpdk-dev] [PATCH] A fix to work around strict-aliasing rules breaking

2015-03-02 17:03, zhihong.wang at intel.com: > Fixed strict-aliasing rules breaking errors for some GCC version. > > Signed-off-by: Zhihong Wang > --- > .../common/include/arch/x86/rte_memcpy.h | 44 > -- > 1 file changed, 24 insertions(+), 20 deletions(-) > > dif

[dpdk-dev] [PATCH 2/3 v2] app/test: Fix size_t printf format issue

2015-03-05 22:00, Michael Qiu: > test_hash.c: In function ?test_crc32_hash_alg_equiv?: > error: format ?%lu? expects argument of type ?long unsigned int?, > but argument 2 has type ?size_t? [-Werror=format] > > According to C99, for size_t type should use format "%zu" > > Signed-off-by: Michael Q

[dpdk-dev] [PATCH v4] pci: save list of detached devices, and re-probe during driver unload

Added code that saves the pointers to the detached devices, during driver loading, and during driver unloading, go over the list, and re-attach them by calling device_probe_and_attach on each device. Signed-off-by: Raz Amir --- lib/librte_eal/bsdapp/nic_uio/nic_uio.c | 34 +++

[dpdk-dev] [PATCH 1/3 v2] librte_hash: Fix unsupported instruction `crc32' in i686 platform

2015-03-06 00:55, Michael Qiu: > CC rte_hash.o > Error: unsupported instruction `crc32' > > The root cause is that i686 platform does not support 'crc32q' > Need make it only available in x86_64 platform > > Signed-off-by: Michael Qiu > --- > v2 --> v1: > Make crc32 instruction only wor

[dpdk-dev] [PATCH] Missing use of macro rte_eth_dev_is_valid_port()

> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Keith Wiles > Sent: Thursday, February 26, 2015 2:01 PM > To: dev at dpdk.org > Subject: [dpdk-dev] [PATCH] Missing use of macro rte_eth_dev_is_valid_port() > > Signed-off-by: Keith Wiles Acked-by: John McNama

[dpdk-dev] [PATCH v3 6/6] ixgbe: Add LRO support

- Only x540 and 82599 devices support LRO. - Add the appropriate HW configuration. - Add RSC aware rx_pkt_burst() handlers: - Implemented bulk allocation and non-bulk allocation versions. - Add LRO-specific fields to rte_eth_rxmode, to rte_eth_dev_data and to igb_

[dpdk-dev] [PATCH v3 5/6] common_linuxapp: Added CONFIG_RTE_ETHDEV_LRO_SUPPORT option

Enables LRO support in PMDs. Signed-off-by: Vlad Zolotarov --- config/common_linuxapp | 1 + 1 file changed, 1 insertion(+) diff --git a/config/common_linuxapp b/config/common_linuxapp index 97f1c9e..5b98595 100644 --- a/config/common_linuxapp +++ b/config/common_linuxapp @@ -137,6 +137,7 @@ CO

[dpdk-dev] [PATCH v3 4/6] ixgbe: Unify the rx_pkt_bulk callback initialization

- Set the callback in a single function that is called from ixgbe_dev_rx_init() for a primary process and from eth_ixgbe_dev_init() for a secondary processes. This is instead of multiple, hard to track places. - Removed rte_eth_dev_data.lro_bulk_alloc and added ixgbe_hw.rx_bulk_al

[dpdk-dev] [PATCH v3 3/6] ixgbe: Code refactoring

- ixgbe_rx_alloc_bufs(): - Reset the rte_mbuf fields only when requested. - Take the RDT update out of the function. - Add the stub when RTE_LIBRTE_IXGBE_RX_ALLOW_BULK_ALLOC is not defined. - ixgbe_recv_scattered_pkts(): - Take the code that updates the fields of

[dpdk-dev] [PATCH v3 2/6] ixgbe: Bug fix: Properly configure Rx CRC stripping for x540 devices

According to x540 spec chapter 8.2.4.8.9 CRCSTRIP field of RDRXCTL should be configured to the same value as HLREG0.RXCRCSTRP. Clearing the RDRXCTL.RSCFRSTSIZE field for x540 is not required by the spec but seems harmless. Signed-off-by: Vlad Zolotarov --- lib/librte_pmd_ixgbe/ixgbe_rxtx.c | 3

[dpdk-dev] [PATCH v3 1/6] ixgbe: Cleanups

- Removed the not needed casting. - Use the rte_le_to_cpu_xx()/rte_cpu_to_le_xx() when reading/setting HW ring descriptor fields. There were a few places where fields were accessed/written directly, which would break on big endian platforms like Power PC. - ixgbe_dev_rx_init():

[dpdk-dev] [PATCH v3 0/6]: Add LRO support to ixgbe PMD

This series adds the missing flow for enabling the LRO in the ethdev and adds a support for this feature in the ixgbe PMD. There is a big hope that this initiative is going to be picked up by some Intel developer that would add the LRO support to other Intel PMDs. ;) The series starts with some c

[dpdk-dev] [PATCH v4] pci: save list of detached devices, and re-probe during driver unload

Added code that saves the pointers to the detached devices, during driver loading, and during driver unloading, go over the list, and re-attach them by calling device_probe_and_attach on each device. Signed-off-by: Raz Amir --- lib/librte_eal/bsdapp/nic_uio/nic_uio.c | 34 +++

[dpdk-dev] [PATCH 2/2] virtio: allow running w/o vlan filtering

Vlan filtering is an option, and not a requirement. If host does not support filtering then it can be done in software. Signed-off-by: Stephen Hemminger --- lib/librte_pmd_virtio/virtio_ethdev.c | 1 - 1 file changed, 1 deletion(-) diff --git a/lib/librte_pmd_virtio/virtio_ethdev.c b/lib/librt

[dpdk-dev] [PATCH 1/2] virtio: initialize iopl when device is initialized

The virtio driver needs to use in/out instructions therefore it must initialize using iopl(2) system call. The problem is that virtio initialization happens very early, and any application that uses daemon() or calls eal_init later in another context will fail. The fix is to move the iopl into rte

[dpdk-dev] [PATCH 0/2] virtio: bugfixes

These are patches we are using in latest release to make our application work with virtio. Stephen Hemminger (2): virtio: initialize iopl when device is initialized virtio: allow running w/o vlan filtering lib/librte_eal/linuxapp/eal/eal.c | 5 + lib/librte_pmd_virtio/virtio_ethdev.c

[dpdk-dev] [PATCH 1/3] librte_hash: Fix unsupported instruction `crc32' in i686 platform

On 2015/3/6 0:12, Yerden Zhumabekov wrote: > Hi Michael, > > Thanks for this patch, in fact I didn't try to compile it on i686 when > developing original software fallback for CRC32. > > I think if we want to make code compilable as wide as possible, we > should compile out all SSE4.2 instructions.

[dpdk-dev] [PATCH 3/3 v2] librte_eal/common: Fix redeclaration of enumerator ‘REG_EAX’

On 2015/3/5 22:39, Thomas Monjalon wrote: > 2015-03-05 14:03, Qiu, Michael: >> On 3/5/2015 9:54 PM, David Marchand wrote: >>> On Thu, Mar 5, 2015 at 2:50 PM, Michael Qiu >> > wrote: >>> >>> include/rte_cpuflags.h:154:2: error: redeclaration of enumerator >>>

[dpdk-dev] [PATCH] mk: Remove '-fdirectives-only' flag from mk/rte.sdkconfig.mk

The '-fdirectives-only' flag doesn't exist in cpp of FreeBSD. To remove expanding macros when parsing the config files won't add any issue. Signed-off-by: Tetsuya Mukawa --- mk/rte.sdkconfig.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mk/rte.sdkconfig.mk b/mk/rte.sdkco

[dpdk-dev] [PATCH] testpmd: Fix port validation code of "port stop all" command

When "port stop all" is executed, the command doesn't work as it should because of wrong port validation. The patch fixes this issue. Reported-by: Pablo de Lara Signed-off-by: Tetsuya Mukawa --- app/test-pmd/testpmd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/test-

[dpdk-dev] [PATCH v2 5/6] common_linuxapp: Added CONFIG_RTE_ETHDEV_LRO_SUPPORT option

On 03/05/15 16:01, Thomas Monjalon wrote: > 2015-03-05 15:39, Vlad Zolotarov: >> On 03/05/15 15:19, Thomas Monjalon wrote: >>> 2015-03-05 13:28, Vlad Zolotarov: Enables LRO support in PMDs. Signed-off-by: Vlad Zolotarov --- config/common_linuxapp | 1 + 1 file

[dpdk-dev] [PATCH v3 10/10] vmxnet3: remove excess inlining

From: Stephen Hemminger No reason to inline large functions. Compiler will decide already based on optimization level. Also register array should be const. Signed-off-by: Stephen Hemminger --- lib/librte_pmd_vmxnet3/vmxnet3_rxtx.c | 10 -- 1 file changed, 4 insertions(+), 6 deletions(

[dpdk-dev] [PATCH v3 09/10] vmxnet3: add check for jumbo segment

From: Stephen Hemminger It is possible that some rogue application might pass a segment larger than 16K to the vmxnet3 transmit routine. In which case just drop it and increment counter. Signed-off-by: Stephen Hemminger --- lib/librte_pmd_vmxnet3/vmxnet3_ring.h | 1 + lib/librte_pmd_vmxnet3/v

[dpdk-dev] [PATCH v3 08/10] vmxnet3: get rid of DEBUG ifdefs

By defining macro as a stub it is possible to get rid of #ifdef's in the actual code. Always evaluate the argument (even in the stub) so that there are no extra unused variable errors. Signed-off-by: Stephen Hemminger --- lib/librte_pmd_vmxnet3/vmxnet3_ethdev.h | 6 -- lib/librte_pmd_vmxnet

[dpdk-dev] [PATCH v3 07/10] vmxnet3: support jumbo frames

From: Stephen Hemminger Add support for linking multi-segment buffers together to handle Jumbo packets. Signed-off-by: Stephen Hemminger --- lib/librte_pmd_vmxnet3/vmxnet3_ethdev.c | 3 +- lib/librte_pmd_vmxnet3/vmxnet3_ring.h | 2 + lib/librte_pmd_vmxnet3/vmxnet3_rxtx.c | 76 +++

[dpdk-dev] [PATCH v3 06/10] vmxnet3: support RSS and refactor offload

From: Stephen Hemminger Refactor the logic to compute receive offload flags to a simpler function. Andd add support for putting RSS flow hash into packet. Signed-off-by: Stephen Hemminger Signed-off-by: Bill Hong Acked-by: Yong Wang --- lib/librte_pmd_vmxnet3/vmxnet3_rxtx.c | 69

[dpdk-dev] [PATCH v3 05/10] vmxnet3: add support for multi-segment transmit

From: Stephen Hemminger Change sending loop to support multi-segment mbufs. The VMXNET3 api has start-of-packet and end-packet flags, so it is not hard to send multi-segment mbuf's. Also, update descriptor in 32 bit value rather than toggling bitfields which is slower and error prone. Based on c

[dpdk-dev] [PATCH v3 04/10] vmxnet3: cleanup txq stats

From: Stephen Hemminger There are several stats here which are never set, and have no way to be displayed. Assume in future xstats could be used. Signed-off-by: Stephen Hemminger Acked-by: Yong Wang --- lib/librte_pmd_vmxnet3/vmxnet3_ring.h | 16 ++-- 1 file changed, 6 insertions

[dpdk-dev] [PATCH v3 03/10] vmxnet3: remove mtu check

From: Stephen Hemminger Remove check for packets greater than MTU. No other driver does this, it should be handled at higher layer Signed-off-by: Stephen Hemminger Acked-by: Yong Wang --- lib/librte_pmd_vmxnet3/vmxnet3_ethdev.c | 2 -- lib/librte_pmd_vmxnet3/vmxnet3_ethdev.h | 1 - lib/libr

[dpdk-dev] [PATCH v3 02/10] vmxnet3: enable VLAN filtering

From: Stephen Hemminger Support the VLAN filter functionality of the VMXNET3 interface. Signed-off-by: Stephen Hemminger --- lib/librte_pmd_vmxnet3/vmxnet3_ethdev.c | 105 +--- lib/librte_pmd_vmxnet3/vmxnet3_ethdev.h | 4 +- lib/librte_pmd_vmxnet3/vmxnet3_rxtx.c

[dpdk-dev] [PATCH v3 01/10] vmxnet3: fix link state handling

From: Stephen Hemminger The Intel version of VMXNET3 driver does not handle link state properly. The VMXNET3 API returns 1 if connected and 0 if disconnected. Also need to return correct value to indicate state change. Signed-off-by: Stephen Hemminger Acked-by: Yong Wang --- lib/librte_pmd_vm

[dpdk-dev] [PATCH v3 00/10] vmxnet3: multisegment and bugfixes

From: Stephen Hemminger Revised version of earlier patches. Incorporate the small packet optimization Add more cleanups Stephen Hemminger (10): vmxnet3: fix link state handling vmxnet3: enable VLAN filtering vmxnet3: remove mtu check vmxnet3: cleanup txq stats vmxnet3: add support for

[dpdk-dev] Build failure on FreeBSD-10.1-RELEASE

On 2015/03/04 19:15, Bruce Richardson wrote: > On Wed, Mar 04, 2015 at 10:33:14AM +0100, Olivier MATZ wrote: >> Hi Tetsuya, Hi Bruce, >> >> On 03/04/2015 04:34 AM, Tetsuya Mukawa wrote: >>> On 2015/03/02 19:22, Bruce Richardson wrote: On Mon, Mar 02, 2015 at 12:47:42PM +0900, Tetsuya Mukawa wr

[dpdk-dev] [PATCH v3] librte_eal/common: Fix cast from pointer to integer of different size

./i686-native-linuxapp-gcc/include/rte_memcpy.h:592:23: error: cast from pointer to integer of different size [-Werror=pointer-to-int-cast] dstofss = 16 - (int)((long long)(void *)dst & 0x0F) + 16; Type 'long long' is 64-bit in i686 platform while 'void *' is 32-bit. Signed-off-by: Michael Qiu

[dpdk-dev] [PATCH v2 5/6] common_linuxapp: Added CONFIG_RTE_ETHDEV_LRO_SUPPORT option

On 03/05/15 15:19, Thomas Monjalon wrote: > 2015-03-05 13:28, Vlad Zolotarov: >> Enables LRO support in PMDs. >> >> Signed-off-by: Vlad Zolotarov >> --- >> config/common_linuxapp | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/config/common_linuxapp b/config/common_linuxapp >> ind

[dpdk-dev] [PATCH 3/3 v2] librte_eal/common: Fix redeclaration of enumerator ‘REG_EAX’

2015-03-05 14:03, Qiu, Michael: > On 3/5/2015 9:54 PM, David Marchand wrote: > > On Thu, Mar 5, 2015 at 2:50 PM, Michael Qiu > > wrote: > > > > include/rte_cpuflags.h:154:2: error: redeclaration of enumerator > > ?REG_EAX? > > In file included from /usr

[dpdk-dev] [PATCH v15] testpmd: Add port hotplug support

On 2015/03/04 0:54, De Lara Guarch, Pablo wrote: > Hi Tetsuya, > >> -Original Message- >> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Tetsuya Mukawa >> Sent: Wednesday, February 25, 2015 7:32 PM >> To: dev at dpdk.org >> Subject: [dpdk-dev] [PATCH v15] testpmd: Add port hotplug

[dpdk-dev] [PATCH 3/3 v2] librte_eal/common: Fix redeclaration of enumerator ‘REG_EAX’

On Thu, Mar 5, 2015 at 2:50 PM, Michael Qiu wrote: > include/rte_cpuflags.h:154:2: error: redeclaration of enumerator ?REG_EAX? > In file included from /usr/include/signal.h:358:0, > from /usr/include/sys/wait.h:30, > from /root/dpdk/app/test/test_mp_secondary.c:

[dpdk-dev] [PATCH 3/3] librte_eal/common: Fix redeclaration of enumerator ‘REG_EAX’

On Thu, Mar 5, 2015 at 2:23 PM, Bruce Richardson wrote: > On Thu, Mar 05, 2015 at 09:15:39PM +0800, Michael Qiu wrote: > > include/rte_cpuflags.h:154:2: error: redeclaration of enumerator > ?REG_EAX? > > In file included from /usr/include/signal.h:358:0, > > from /usr/include/sys

[dpdk-dev] [PATCH v2 5/6] common_linuxapp: Added CONFIG_RTE_ETHDEV_LRO_SUPPORT option

2015-03-05 13:28, Vlad Zolotarov: > Enables LRO support in PMDs. > > Signed-off-by: Vlad Zolotarov > --- > config/common_linuxapp | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/config/common_linuxapp b/config/common_linuxapp > index 97f1c9e..5b98595 100644 > --- a/config/common_linuxa

[dpdk-dev] rte_prefetch0() performance info

Hi all, I have a question related to usage of rte_prefetch0() function,In one of the sample files, we have implementation like: /* Prefetch first packets */ for (j = 0; j < PREFETCH_OFFSET && j < nb_rx; j++) { rte_prefetch0(rte_pktmbuf_mtod(

[dpdk-dev] [PATCH 3/3 v2] librte_eal/common: Fix redeclaration of enumerator ‘REG_EAX’

On 3/5/2015 9:54 PM, David Marchand wrote: > On Thu, Mar 5, 2015 at 2:50 PM, Michael Qiu > wrote: > > include/rte_cpuflags.h:154:2: error: redeclaration of enumerator > ?REG_EAX? > In file included from /usr/include/signal.h:358:0, >

[dpdk-dev] [PATCH 3/3] librte_eal/common: Fix redeclaration of enumerator ‘REG_EAX’

On 3/5/2015 9:36 PM, David Marchand wrote: > On Thu, Mar 5, 2015 at 2:23 PM, Bruce Richardson > mailto:bruce.richardson at intel.com>> wrote: > > On Thu, Mar 05, 2015 at 09:15:39PM +0800, Michael Qiu wrote: > > include/rte_cpuflags.h:154:2: error: redeclaration of enumerator > ?REG_EAX?

[dpdk-dev] [PATCH 3/3] librte_eal/common: Fix redeclaration of enumerator ‘REG_EAX’

On 3/5/2015 9:24 PM, Richardson, Bruce wrote: > On Thu, Mar 05, 2015 at 09:15:39PM +0800, Michael Qiu wrote: >> include/rte_cpuflags.h:154:2: error: redeclaration of enumerator ?REG_EAX? >> In file included from /usr/include/signal.h:358:0, >> from /usr/include/sys/wait.h:30, >>

[dpdk-dev] [PATCH] testpmd: Fix port validation code of "port stop all" command

On 3/5/2015 9:33 PM, Qiu, Michael wrote: > Hi, Tetsuya and Pablo > This is not a full fix, I have generate the full fix patch two days ago, > See below: > > diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c > index 49be819..ec53923 100644 > --- a/app/test-pmd/config.c > +++ b/app/test-pmd/

[dpdk-dev] [PATCH] testpmd: Fix port validation code of "port stop all" command

Hi, Tetsuya and Pablo This is not a full fix, I have generate the full fix patch two days ago, See below: diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c index 49be819..ec53923 100644 --- a/app/test-pmd/config.c +++ b/app/test-pmd/config.c @@ -384,6 +384,9 @@ port_infos_display(portid_t

[dpdk-dev] [PATCH v2 6/6] ixgbe: Add LRO support

- Only x540 and 82599 devices support LRO. - Add the appropriate HW configuration. - Add RSC aware rx_pkt_burst() handlers: - Implemented bulk allocation and non-bulk allocation versions. - Add LRO-specific fields to rte_eth_rxmode, to rte_eth_dev_data and to igb_

[dpdk-dev] [PATCH v2 5/6] common_linuxapp: Added CONFIG_RTE_ETHDEV_LRO_SUPPORT option

Enables LRO support in PMDs. Signed-off-by: Vlad Zolotarov --- config/common_linuxapp | 1 + 1 file changed, 1 insertion(+) diff --git a/config/common_linuxapp b/config/common_linuxapp index 97f1c9e..5b98595 100644 --- a/config/common_linuxapp +++ b/config/common_linuxapp @@ -137,6 +137,7 @@ CO

[dpdk-dev] [PATCH v2 4/6] ixgbe: Unify the rx_pkt_bulk callback initialization

- Set the callback in a single function (set_rx_function()) that is called from ixgbe_dev_rx_init() for a primary process and from eth_ixgbe_dev_init() for a secondary processes. This is instead of multiple, hard to track places. - Bug fix: rx_pkt_bulk callback setting was done ba

[dpdk-dev] [PATCH v2 3/6] ixgbe: Code refactoring

- ixgbe_rx_alloc_bufs(): - Reset the rte_mbuf fields only when requested. - Take the RDT update out of the function. - Add the stub when RTE_LIBRTE_IXGBE_RX_ALLOW_BULK_ALLOC is not defined. - ixgbe_recv_scattered_pkts(): - Take the code that updates the fields of

[dpdk-dev] [PATCH v2 2/6] ixgbe: Bug fix: Properly configure Rx CRC stripping for x540 devices

According to x540 spec chapter 8.2.4.8.9 CRCSTRIP field of RDRXCTL should be configured to the same value as HLREG0.RXCRCSTRP. Clearing the RDRXCTL.RSCFRSTSIZE field for x540 is not required by the spec but seems harmless. Signed-off-by: Vlad Zolotarov --- lib/librte_pmd_ixgbe/ixgbe_rxtx.c | 3

[dpdk-dev] [PATCH v2 1/6] ixgbe: Cleanups

- Removed the not needed casting. - Use the rte_le_to_cpu_xx()/rte_cpu_to_le_xx() when reading/setting HW ring descriptor fields. There were a few places where fields were accessed/written directly, which would break on big endian platforms like Power PC. - ixgbe_dev_rx_init():

[dpdk-dev] [PATCH v2 0/6]: Add LRO support to ixgbe PMD

This series adds the missing flow for enabling the LRO in the ethdev and adds a support for this feature in the ixgbe PMD. There is a big hope that this initiative is going to be picked up by some Intel developer that would add the LRO support to other Intel PMDs. ;) The series starts with some c

[dpdk-dev] [PATCH 3/3] librte_eal/common: Fix redeclaration of enumerator ‘REG_EAX’

On 3/5/2015 9:16 PM, Qiu, Michael wrote: > include/rte_cpuflags.h:154:2: error: redeclaration of enumerator ?REG_EAX? > In file included from /usr/include/signal.h:358:0, > from /usr/include/sys/wait.h:30, > from /root/dpdk/app/test/test_mp_secondary.c:50: > /usr/i

[dpdk-dev] [PATCH 3/3] librte_eal/common: Fix redeclaration of enumerator ‘REG_EAX’

On Thu, Mar 05, 2015 at 09:15:39PM +0800, Michael Qiu wrote: > include/rte_cpuflags.h:154:2: error: redeclaration of enumerator ?REG_EAX? > In file included from /usr/include/signal.h:358:0, > from /usr/include/sys/wait.h:30, > from /root/dpdk/app/test/test_mp_seco

[dpdk-dev] [PATCH 2/3] app/test: Fix size_t printf formart issue

On Thu, Mar 05, 2015 at 09:15:38PM +0800, Michael Qiu wrote: > test_hash.c: In function ?test_crc32_hash_alg_equiv?: > error: format ?%lu? expects argument of type ?long unsigned int?, > but argument 2 has type ?size_t? [-Werror=format] > > According to C99, for size_t type should use formart "%zu

[dpdk-dev] Not getting statistics for all queues.

ping :-) ? Any thoughts about this ? Thanks, Alexandra On 2 March 2015 at 17:00, Alexandra Sava wrote: > Hi, > > lspci command shows the following: > > *04:00.0 Ethernet controller: Intel Corporation 82599EB 10-Gigabit > SFI/SFP+ Network Connection (rev 01)Subsystem: Hewlett-Packard Company >

[dpdk-dev] [PATCH v3] ABI: Add abi checking utility

On Wed, Mar 04, 2015 at 05:49:50PM +0100, Thomas Monjalon wrote: > 2015-03-04 11:26, Neil Horman: > > +#trap on ctrl-c to clean up > > +trap cleanup_and_exit SIGINT > > I think INT is preffered over SIGINT. > You may also add QUIT and TERM. > With QUIT, you can replace cleanup_and_exit calls by a

[dpdk-dev] [PATCH] testpmd: HW vlan command

2015-03-03 23:52, De Lara Guarch, Pablo: > > > -Original Message- > > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Ouyang Changchun > > Sent: Friday, February 13, 2015 12:04 PM > > To: dev at dpdk.org > > Subject: [dpdk-dev] [PATCH] testpmd: HW vlan command > > > > This patch e

[dpdk-dev] [PATCH v1] ixgbe/vector: add rxd 2^n check to avoid mbuf leak

On Mon, Mar 02, 2015 at 09:28:24PM +0800, Cunming Liang wrote: > The mbuf leak happens when the assigned number of rx descriptor is not power > of 2. > As it's presumed on vpmd rx(for rx_tail wrap), adding condition check to > prevent it. > The root cause reference code in *_recv_raw_pkts_vec* as

[dpdk-dev] [PATCH v1 5/5] ixgbe: Add LRO support

On 03/04/15 20:54, Stephen Hemminger wrote: > On Wed, 04 Mar 2015 09:57:24 +0200 > Vlad Zolotarov wrote: > >> >> On 03/04/15 02:33, Stephen Hemminger wrote: >>> On Tue, 3 Mar 2015 21:48:43 +0200 >>> Vlad Zolotarov wrote: >>> + next_desc: + /* + * The code in

[dpdk-dev] [PATCH v3] librte_eal/common: Fix cast from pointer to integer of different size

2015-03-05 09:21, Tang, HaifengX: > Hi Thomas and all : [...] > CC rte_hash.o > /jenkins/workspace/DPDK_AUTO_IDT_VM_FC18_32_BUILD2/DPDK/lib/librte_hash/rte_hash_crc.h: > Assembler messages: > /jenkins/workspace/DPDK_AUTO_IDT_VM_FC18_32_BUILD2/DPDK/lib/librte_hash/rte_hash_crc.h:380: > Error: u

[dpdk-dev] [PATCH] eal/linux: fix build

Hi Michael, 2015-03-05 09:13, Qiu, Michael: > On 3/4/2015 6:24 AM, Thomas Monjalon wrote: > >>> Compilation fails in some distributions because of missing unistd.h > >>> needed for pread/pwrite (seen with Suse): > >>> lib/librte_eal/linuxapp/eal/eal_pci_uio.c:62:2: > >>> error: imp

[dpdk-dev] [PATCH] mk: Remove '-fdirectives-only' flag from mk/rte.sdkconfig.mk

On Thu, Mar 05, 2015 at 04:31:01PM +0900, Tetsuya Mukawa wrote: > The '-fdirectives-only' flag doesn't exist in cpp of FreeBSD. > To remove expanding macros when parsing the config files won't > add any issue. > > Signed-off-by: Tetsuya Mukawa Acked-by: Bruce Richardson > --- > mk/rte.sdkconfi

[dpdk-dev] [PATCH] eal/linux: fix build

> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Qiu, Michael > Sent: Thursday, March 05, 2015 9:13 AM > To: Thomas Monjalon; David Marchand > Cc: dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH] eal/linux: fix build > > On 3/4/2015 6:24 AM, Thomas Monjalon

[dpdk-dev] [PATCH v3] librte_eal/common: Fix cast from pointer to integer of different size

Hi Thomas and all : I686 gcc and icc targets both have the below build issue: For GCC(after apply the patch :[dpdk-dev] [PATCH v3] librte_eal/common: Fix cast from pointer to integer of different size) == Build lib/librte_hash CC rte_hash.o /jenkins/workspace/DPDK_AUTO_IDT_VM_FC18_3

[dpdk-dev] [PATCH] eal/linux: fix build

On 3/4/2015 6:24 AM, Thomas Monjalon wrote: >>> Compilation fails in some distributions because of missing unistd.h >>> needed for pread/pwrite (seen with Suse): >>> lib/librte_eal/linuxapp/eal/eal_pci_uio.c:62:2: >>> error: implicit declaration of function ?pread? >>> >>> Fixes: 4a

[dpdk-dev] i40e and RSS woes

On Thu, Mar 05, 2015 at 05:56:27AM +, Zhang, Helin wrote: > Hi Gleb > > Sorry for late! I am struggling on my tasks for the following DPDK release > these days. > > > -Original Message- > > From: Gleb Natapov [mailto:gleb at cloudius-systems.com] > > Sent: Monday, March 2, 2015 8:56

[dpdk-dev] [PATCH v3] librte_eal/common: Fix cast from pointer to integer of different size

Tested-by: haifeng.tang Patch name: [dpdk-dev] [PATCH v3] librte_eal/common: Fix cast from pointer to integer of different size Test Env : Fedora 18 , 3.6.10-4 ,4.7.2 ,14.0.0 Fedora20 ,3.11.0,4.8.2,14.0.0 Fedora21,3.17.4-302,4.9.2,15.0.0 Ubuntu 14.04, 3.13.0-30, 4.8.2, 14.0.0 Test Result: er

[dpdk-dev] proposal: remove separate doc tree

Thank you Thomas > -Original Message- > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > Sent: Wednesday, March 4, 2015 9:07 PM > To: Butler, Siobhan A > Cc: dev at dpdk.org > Subject: Re: [dpdk-dev] proposal: remove separate doc tree > > 2015-02-11 14:28, Butler, Siobhan A:

[dpdk-dev] i40e and RSS woes

> -Original Message- > From: Gleb Natapov [mailto:gleb at cloudius-systems.com] > Sent: Thursday, March 5, 2015 2:39 PM > To: Zhang, Helin > Cc: dev at dpdk.org > Subject: Re: i40e and RSS woes > > On Thu, Mar 05, 2015 at 05:56:27AM +, Zhang, Helin wrote: > > Hi Gleb > > > > Sorry fo

[dpdk-dev] [PATCH v2 5/6] common_linuxapp: Added CONFIG_RTE_ETHDEV_LRO_SUPPORT option

2015-03-05 15:39, Vlad Zolotarov: > > On 03/05/15 15:19, Thomas Monjalon wrote: > > 2015-03-05 13:28, Vlad Zolotarov: > >> Enables LRO support in PMDs. > >> > >> Signed-off-by: Vlad Zolotarov > >> --- > >> config/common_linuxapp | 1 + > >> 1 file changed, 1 insertion(+) > >> > >> diff --git a

[dpdk-dev] i40e and RSS woes

Hi Gleb Sorry for late! I am struggling on my tasks for the following DPDK release these days. > -Original Message- > From: Gleb Natapov [mailto:gleb at cloudius-systems.com] > Sent: Monday, March 2, 2015 8:56 PM > To: dev at dpdk.org > Cc: Zhang, Helin > Subject: Re: i40e and RSS woes >

[dpdk-dev] KNI with multiple kthreads per port

> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of JP M. > Sent: Sunday, March 1, 2015 6:40 AM > To: dev at dpdk.org > Subject: [dpdk-dev] KNI with multiple kthreads per port > > Howdy! First time posting; please be gentle. :-) > > Environment: > * DPDK 1.8.

[dpdk-dev] rte_prefetch0() performance info

Hi Parikshith. A CPU core can have a limited number of prefetches in flight (around 10). So if you issue 64 (or nb_rx > 10) prefetches in quick succession, you'll stall on memory access. The main idea here is to overlap prefetches of some packets with computation from other packets. This paper ex

  1   2   >