[dpdk-dev] to the intel dpdk engineers and all contributors

2014-10-15 Thread O'driscoll, Tim
Thanks Daniel. I'm sure the many people who've put a lot of time and effort into building DPDK will really appreciate your kind words. Tim > -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of daniel chapiesky > Sent: Wednesday, October 15, 2014 9:47 PM > To: de

[dpdk-dev] [PATCH] vhost: Fix the vhost broken issue

2014-10-15 Thread Xie, Huawei
I generated the vhost example patch based on vhost library, but find there is issue with --mergeable feature. Only thousands of packets could be sent. Then I tried the latest vhost example, which is just before my vhost lib patch, I found that not only it has the issue Which is fixed by the foll

[dpdk-dev] kernel panic when stop my test demo

2014-10-15 Thread Lilijun
Hi all, After adding unmap uio resources operations in process signal handler functions, An new error was found as follows: Call Trace: [] uio_release+0x40/0x60 [uio] [] __fput+0xe9/0x270 [] fput+0xe/0x10 [] task_work_run+0xa7/0xe0 [] do_notify_resume+0x97/0xb0 [] int_signal+0x12/0x17 T

[dpdk-dev] to the intel dpdk engineers and all contributors

2014-10-15 Thread daniel chapiesky
I just watched the closing remarks by Tim Driscol at the dpdk summit http://youtu.be/r-JA5NBybrs At time 4:30, he mentioned the "shock to the system" of developers expecting a pat on the back and instead receiving critiques of their code. I realized that I was one of those who failed to

[dpdk-dev] [PATCH v2] virtio: Update max RX packet length

2014-10-15 Thread Thomas Monjalon
2014-10-13 11:46, Ouyang Changchun: > Update max RX packet length since virtio PMD has the capability of receiving > and transmitting jumbo frame. > > This following patch provides the above capability: > [dpdk-dev,v3] virtio: Support mergeable buffer in virtio pmd > Submitter Ouyang Changchun

[dpdk-dev] [PATCH v2] Pass CC option when building kernel modules

2014-10-15 Thread Thomas Monjalon
> > At least on kernels 3.15 or newer, wrong compiler flags are set when > > building > > kernel modules. > > > > v2: > > Remove unnecessary reset of CC when being included from the kernel. > > > > Signed-off-by: Sergio Gonzalez Monroy > > Acked-by: Pablo de Lara Applied Thanks -- Thomas

[dpdk-dev] [PATCH v2] Set V=1 when building kernel modules

2014-10-15 Thread Thomas Monjalon
2014-10-15 14:08, Sergio Gonzalez Monroy: > Linux kernel build system requires V=1 to enable verbose output, but > current DPDK framework just check if V is defined. > > Fix: force V=1 when building Linux kernel modules if verbose output is > enabled. > > Signed-off-by: Sergio Gonzalez Monroy A

[dpdk-dev] [PATCH v5 4/8]librte_ether:add a common filter API

2014-10-15 Thread De Lara Guarch, Pablo
> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Jijiang Liu > Sent: Saturday, October 11, 2014 6:56 AM > To: dev at dpdk.org > Subject: [dpdk-dev] [PATCH v5 4/8]librte_ether:add a common filter API > > Introduce a new filter framewok in librte_ether. As to

[dpdk-dev] to the intel dpdk engineers and all contributors

2014-10-15 Thread Matthew Hall
On Wed, Oct 15, 2014 at 04:46:41PM -0400, daniel chapiesky wrote: > At time 4:30, he mentioned the "shock to the system" of developers > expecting a pat on the back and instead receiving critiques of their > code. > > I realized that I was one of those who failed to acknowledge the incredible

[dpdk-dev] [PATCH] Add Rx error statistics for Fortville

2014-10-15 Thread Thomas Monjalon
> > This patch adds incoming packet error statistics in the i40e_ethdev.c file. > > > > Signed-off-by: Jijiang Liu > > Acked-by: Helin Zhang Applied Thanks -- Thomas

[dpdk-dev] [PATCH] Add Rx error statistics for Fortville

2014-10-15 Thread Thomas Monjalon
Helin, As you are in charge of i40e, here are 2 tips to acknowledge patches: 1) title should take this format: i40e: add Rx error statistics > Acked-by: Helin Zhang 2) This line should be added right after the Signed-off-by. And the rest of the email (patch body) can be removed. This w

[dpdk-dev] [PATCH v2] Set V=1 when building kernel modules

2014-10-15 Thread Sergio Gonzalez Monroy
Linux kernel build system requires V=1 to enable verbose output, but current DPDK framework just check if V is defined. Fix: force V=1 when building Linux kernel modules if verbose output is enabled. Signed-off-by: Sergio Gonzalez Monroy --- mk/rte.module.mk | 2 +- 1 file changed, 1 insertion(

[dpdk-dev] [PATCH] Set V=1 when building kernel modules

2014-10-15 Thread Sergio Gonzalez Monroy
Linux kernel build system requires V=1 to enable verbose output, but current DPDK framework just check if V is defined. Fix: force V=1 when building Linux kernel modules if verbose output is enabled. Signed-off-by: Sergio Gonzalez Monroy --- mk/rte.module.mk | 2 +- 1 file changed, 1 insertion(

[dpdk-dev] [PATCH] Pass verbose flag to kernel module

2014-10-15 Thread Thomas Monjalon
Sergio, I'd like to see a v2 patch with your explanations in commit log and with a Signed-off-by. > > - CROSS_COMPILE=$(CROSS) > > + V=$(if $(V),1,0) CROSS_COMPILE=$(CROSS) Minor nits: - paren is not needed for one letter variable - V option should go to the end to keep thing

[dpdk-dev] [PATCH] Set V=1 when building kernel modules

2014-10-15 Thread Gonzalez Monroy, Sergio
> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Sergio Gonzalez > Monroy > Sent: Wednesday, October 15, 2014 2:08 PM > To: dev at dpdk.org > Subject: [dpdk-dev] [PATCH] Set V=1 when building kernel modules > Self-NACK. Please ignore as I forgot to add v2 pref

[dpdk-dev] FW: BUG in IP FRAGMENTATION

2014-10-15 Thread Thomas Monjalon
ME TOO, I HAVE A BUG WITH CAPS LOCK ;) 2014-10-15 11:06, Dey, Souvik: > In DPDK1.6 do we support overlapped fragments while doing reassembly. > Also why we don't consider the first or last fragment to be out-of-order. > Are this known limitations in DPDK or they are not working due to some > bugs

[dpdk-dev] [PATCH] Pass verbose flag to kernel module

2014-10-15 Thread Gonzalez Monroy, Sergio
> -Original Message- > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > Sent: Wednesday, October 15, 2014 1:05 PM > To: De Lara Guarch, Pablo; Gonzalez Monroy, Sergio > Cc: dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH] Pass verbose flag to kernel module > > Sergio, > > I'

[dpdk-dev] FW: BUG in IP FRAGMENTATION

2014-10-15 Thread Dey, Souvik
Any plans to support this in future in DPDK fragmentation code ? -Original Message- From: Ananyev, Konstantin [mailto:konstantin.anan...@intel.com] Sent: Wednesday, October 15, 2014 5:49 PM To: Dey, Souvik; Thomas Monjalon Cc: dev at dpdk.org; Patil, PraveenKumar Subject: RE: [dpdk-dev] F

[dpdk-dev] FW: BUG in IP FRAGMENTATION

2014-10-15 Thread Ananyev, Konstantin
> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Dey, Souvik > Sent: Wednesday, October 15, 2014 12:53 PM > To: Thomas Monjalon > Cc: dev at dpdk.org; Patil, PraveenKumar > Subject: Re: [dpdk-dev] FW: BUG in IP FRAGMENTATION > > We have not directly tried to

[dpdk-dev] [PATCH 1/6] ether: enhancement for VMDQ support

2014-10-15 Thread Thomas Monjalon
2014-10-15 09:47, Chen, Jing D: > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > > 2014-10-15 06:59, Chen, Jing D: > > > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > > > > > enum rte_eth_rx_mq_mode { > > > > > - ETH_MQ_RX_NONE = 0, /**< None of DCB,RSS or VMDQ

[dpdk-dev] FW: BUG in IP FRAGMENTATION

2014-10-15 Thread Dey, Souvik
We have not directly tried to use the 1.7 code with fragmentation apis, but we did run through the 1.7 code and did not find any much difference between 1.6 and 1.7 code. I had wrongly mentioned out-of-order in my previous mail. Actually out-of-order is working fine but we are facing issues wit

[dpdk-dev] i40e: Steps and required configurations of how to achieve the best performance!

2014-10-15 Thread Thomas Monjalon
Hi Helin, 2014-09-19 03:43, Zhang, Helin: > My idea on it could be, > 1. Write a script to use ?setpci? to configure pci configuration. > End user can decide which PCI device needs to be changed. > 2. Add code to change that PCI configuration in i40e PMD only, as > it seems nobody else

[dpdk-dev] [PATCH] Add Rx error statistics for Fortville

2014-10-15 Thread Jijiang Liu
This patch adds incoming packet error statistics in the i40e_ethdev.c file. Signed-off-by: Jijiang Liu --- lib/librte_pmd_i40e/i40e_ethdev.c | 11 +-- 1 files changed, 9 insertions(+), 2 deletions(-) diff --git a/lib/librte_pmd_i40e/i40e_ethdev.c b/lib/librte_pmd_i40e/i40e_ethdev.c i

[dpdk-dev] [PATCH v5] virtio: Fix vring entry number issue

2014-10-15 Thread Ouyang Changchun
Fix one issue in virtio TX: it needs one more vring descriptor to hold the virtio header when transmitting packets, it is used later to determine whether to free more entries from used vring. It fixes failing to transmit any packet with 1 segment in the circumstance of only 1 descripto

[dpdk-dev] FW: BUG in IP FRAGMENTATION

2014-10-15 Thread Dey, Souvik
Hi, In DPDK1.6 do we support overlapped fragments while doing reassembly. Also why we don't consider the first or last fragment to be out-of-order. Are this known limitations in DPDK or they are not working due to some bugs in the code ? -- Regards, Souvik

[dpdk-dev] [PATCH 1/6] ether: enhancement for VMDQ support

2014-10-15 Thread Thomas Monjalon
2014-10-15 06:59, Chen, Jing D: > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > > > enum rte_eth_rx_mq_mode { > > > - ETH_MQ_RX_NONE = 0, /**< None of DCB,RSS or VMDQ mode */ > > > - > > > - ETH_MQ_RX_RSS, /**< For RX side, only RSS is on */ > > > - ETH_MQ_RX_DCB, /**<

[dpdk-dev] kernel panic when stop my test demo

2014-10-15 Thread Richardson, Bruce
> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Lilijun > Sent: Wednesday, October 15, 2014 10:43 AM > To: dev at dpdk.org; stephen at networkplumber.org > Subject: Re: [dpdk-dev] kernel panic when stop my test demo > > Hi all, > > After adding unmap uio r

[dpdk-dev] [PATCH] i40e: fix of compile error

2014-10-15 Thread Thomas Monjalon
2014-10-13 12:42, Zhan, Zhaochen: > > It fixes the compile error as below on gcc version 4.3.4. > > cc1: error: unrecognized command line option "-Wno-unused-but-set- > > variable" > > > > Signed-off-by: Helin Zhang > > Tested-by: Zhaochen Zhan Applied Thanks -- Thomas

[dpdk-dev] [PATCH 1/6] ether: enhancement for VMDQ support

2014-10-15 Thread Chen, Jing D
> -Original Message- > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > Sent: Wednesday, October 15, 2014 4:11 PM > To: Chen, Jing D > Cc: dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH 1/6] ether: enhancement for VMDQ support > > 2014-10-15 06:59, Chen, Jing D: > > From:

[dpdk-dev] [PATCH v5] virtio: Fix vring entry number issue

2014-10-15 Thread Thomas Monjalon
2014-10-15 11:11, Ouyang Changchun: > Fix one issue in virtio TX: it needs one more vring descriptor to hold the > virtio > header when transmitting packets, it is used later to determine whether to > free > more entries from used vring. > It fixes failing to transmit any packet with 1 se

[dpdk-dev] [PATCH 5/6] i40e: macaddr add/del enhancement

2014-10-15 Thread Chen, Jing D
> -Original Message- > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > Sent: Tuesday, October 14, 2014 10:25 PM > To: Chen, Jing D > Cc: dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH 5/6] i40e: macaddr add/del enhancement > > 2014-09-23 21:14, Chen Jing D: > > +

[dpdk-dev] [PATCH 1/6] ether: enhancement for VMDQ support

2014-10-15 Thread Chen, Jing D
> -Original Message- > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > Sent: Tuesday, October 14, 2014 10:10 PM > To: Chen, Jing D > Cc: dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH 1/6] ether: enhancement for VMDQ support > > 2014-09-23 21:14, Chen Jing D: > > The chan

[dpdk-dev] [PATCH] Add Rx error statistics for Fortville

2014-10-15 Thread Zhang, Helin
Acked-by: Helin Zhang > -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Jijiang Liu > Sent: Wednesday, October 15, 2014 11:15 AM > To: dev at dpdk.org > Subject: [dpdk-dev] [PATCH] Add Rx error statistics for Fortville > > This patch adds incoming packet erro

[dpdk-dev] [PATCH v4] virtio: Fix vring entry number issue

2014-10-15 Thread Ouyang, Changchun
Hi Huawei, I have v5 patch for this comment. Thanks, Changchun > -Original Message- > From: Xie, Huawei > Sent: Wednesday, October 15, 2014 12:26 AM > To: Ouyang, Changchun; dev at dpdk.org > Subject: RE: [dpdk-dev] [PATCH v4] virtio: Fix vring entry number issue > > > > > -Original

[dpdk-dev] [PATCH v4] virtio: Fix vring entry number issue

2014-10-15 Thread Ouyang Changchun
Fix one issue in virtio TX: it needs one more vring descriptor to hold the virtio header when transmitting packets, it is used later to determine whether to free more entries from used vring. It fixes failing to transmit any packet with 1 segment in the circumstance of only 1 descripto