> -----Original Message----- > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > Sent: Tuesday, October 14, 2014 10:25 PM > To: Chen, Jing D > Cc: dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH 5/6] i40e: macaddr add/del enhancement > > 2014-09-23 21:14, Chen Jing D: > > + PMD_DRV_LOG(ERR, "VMDQ not %s, can't set mac to > pool %u\n", > > + pf->flags | I40E_FLAG_VMDQ ? "configured" : > "enabled", > > + pool); > [...] > > - if (ret != I40E_SUCCESS) { > > - PMD_DRV_LOG(ERR, "Failed to write mac address"); > > + if (pool > pf->nb_cfg_vmdq_vsi) { > > + PMD_DRV_LOG(ERR, "Pool number %u invalid. Max pool > is %u\n", > > + pool, pf->nb_cfg_vmdq_vsi); > [...] > > - PMD_DRV_LOG(ERR, "Failed to add MACVLAN filter"); > > + PMD_DRV_LOG(ERR, "Failed to add MACVLAN filter\n"); > [...] > > + PMD_DRV_LOG(ERR, "Failed to remove > MACVLAN filter\n"); > > I'm pretty sure you rebased this patch and solved the conflicts without > updating your patch accordingly. Indeed carriage returns have been removed > from logs recently. > Hint: rebase conflicts are really often meaningful ;) >
Thanks for your suggestion. > -- > Thomas
