2014-06-24 15:32, Zhang, Helin:
> From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com]
>
> > The PMD is built on top of the base driver which is provided by Intel and
> > shouldn't be modified to allow easy batch upgrade from Intel.
> >
> > The base driver is a "shared code" between many p
The internal buffering of packets for TX done in l2fwd is no longer
needed, so replace this code with calls to the new rte_eth_tx_buffer*
APIs.
---
examples/l2fwd/main.c | 61 ++-
1 file changed, 7 insertions(+), 54 deletions(-)
diff --git a/example
Many sample apps include internal buffering for single-packet-at-a-time
operation. Since this is such a common paradigm, this functionality is
better suited to being inside the core ethdev API.
The new APIs include three functions:
* rte_eth_tx_buffer - buffer up a single packet for future transmis
This is an RFC patch to get feedback on this change proposal before I do any
further investigation work into it, looking at all the example apps - as there
are a lot of them. :-)
The idea is to remove all the code in the sample applications for buffering
packets on TX by moving the buffering functi
Thanks, all!
We have alloc/free counters in place but I'll enable those debug options.
I'll try older releases of RHEL and get back to you.
I've also eradicated pthreads in this code but also have the mempool cache
size set to 0 just in case. I should mention we hold onto mbufs for a while
(up to
Indeed, I just verified it with building for Westmere, thanks.
However the meaning is that the system will be built to the lowest
target microarchitecture,
or alternatively, multiple builds for different microarchitectures will be
delivered.
Thanks.
On Tue, Jun 24, 2014 at 8:32 PM, Richardson,
one more detail, i am using dpdk-1.6.0r1
On Tue, Jun 24, 2014 at 6:05 PM, Helmut Sim wrote:
> Hi,
>
> I need some help to understand the following issue.
>
> I am building the DPDK with make install T=x86_64-default-linuxapp-gcc and
> it works well on my machine.
> However when testing it on m
Hi,
I need some help to understand the following issue.
I am building the DPDK with make install T=x86_64-default-linuxapp-gcc and
it works well on my machine.
However when testing it on my virtual machine (ubuntu 14.04 server guest n
xen hv) it fails for SIGILL:
here is the relevant gdb output f
> -Original Message-
> From: Stephen Hemminger [mailto:stephen at networkplumber.org]
> Sent: Tuesday, June 24, 2014 10:54 AM
> To: Richardson, Bruce
> Cc: dev at dpdk.org
> Subject: Re: [dpdk-dev] [PATCH 1/3] stringfns: remove rte_snprintf
>
> On Tue, 24 Jun 2014 17:39:52 +
> "Richard
>
> On Tue, 24 Jun 2014 16:16:02 +
> "Ananyev, Konstantin" wrote:
>
> > But now, memzone created for the actual mempool could get leaked instead?
>
> Since memzone's can't be destroyed, then only solution would be if
> checked if memzone with same name already exists.
Actually, wouldn't it
> -Original Message-
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Ananyev, Konstantin
> Sent: Tuesday, June 24, 2014 9:16 AM
> To: Stephen Hemminger; dev at dpdk.org
> Subject: Re: [dpdk-dev] [PATCH] mempool: don't leak ring on failure
>
> Hi Stephen,
>
> >
> > If mempool can
> -Original Message-
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Stephen Hemminger
> Sent: Tuesday, June 24, 2014 9:03 AM
> To: dev at dpdk.org
> Subject: [dpdk-dev] [PATCH 1/3] stringfns: remove rte_snprintf
>
> The function rte_snprintf serves no useful purpose. It is the
>
> -Original Message-
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Helmut Sim
> Sent: Tuesday, June 24, 2014 8:08 AM
> To: dev at dpdk.org
> Subject: Re: [dpdk-dev] eal_parse_coremask fails on SIGILL
>
> one more detail, i am using dpdk-1.6.0r1
>
>
>
> On Tue, Jun 24, 2014
> -Original Message-
> From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com]
> Sent: Tuesday, June 24, 2014 2:39 AM
> To: Richardson, Bruce
> Cc: dev at dpdk.org
> Subject: Re: [dpdk-dev] [PATCH 1/2] mk: overriding CC also overrides HOSTCC
>
> Hi Bruce,
>
> 2014-06-24 01:23, Bruce R
Signed-off-by: Declan Doherty
---
doc/doxy-api-index.md |1 +
doc/doxy-api.conf |1 +
2 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/doc/doxy-api-index.md b/doc/doxy-api-index.md
index 7b26e98..ee3ad4f 100644
--- a/doc/doxy-api-index.md
+++ b/doc/doxy-api-index.md
@@
- Includes the ability to create new bonded devices.
- Add /remove bonding slave devices.
- Interogate bonded device stats/configuration
- Change bonding modes and select balance transmit polices
Signed-off-by: Declan Doherty
---
app/test-pmd/cmdline.c| 579 +
Including:
- code to generate packet bursts for testing rx and tx
functionality of bonded device
- virtual/stubbed out ethdev for use as slave ethdev in testing
Signed-off-by: Declan Doherty
---
app/test/Makefile |4 +-
app/test/commands.c |7 +
app/tes
Updating functionality in EAL to support adding link bonding
devices via ?vdev option. Link bonding devices will be
initialized after all physical devices have been probed and
initialized.
Signed-off-by: Declan Doherty
---
lib/librte_eal/bsdapp/eal/eal.c | 10 -
lib/librte_eal/
Adding support to rte_eth_dev_data structure to support unique
name identifier for ethdevs to support adding slave ethdevs
(specifically virtual devices which have no public unique
identifier) to a link bonding device. This changes the API
rte_eth_dev_allocate() to require a const char *name when
a
Initial release with support for
Mode 0 - Round Robin
Mode 1 - Active Backup
Mode 2 - Balance -> Supports 3 transmit polices (layer 2, layer 2+3, layer 3+4)
Mode 3 - Broadcast
Signed-off-by: Declan Doherty
---
config/common_bsdapp |5 +
config/common_linuxapp |
This patch contains the initial release of the Link Bonding PMD Library
Supporting bonding modes:
0 - Round Robin
1 - Active Backup
2 - Balance (Supporting 3 transmission polices)
layer 2, layer 2+3, layer 3+4
3 - Broadcast
Version 6 of patch set:
Debug tracing formatting issue in rte
Hi Stephen,
>
> If mempool can not be created because of insufficient memory
> it returns an error but has already created a ring (and leaves it
> behind). This prevents code from trying one mempool size and then
> retrying with a smaller size if the bigger size fails.
>
> Reordering to do ring
On Tue, 24 Jun 2014 23:32:15 +0100
Bruce Richardson wrote:
> Many sample apps include internal buffering for single-packet-at-a-time
> operation. Since this is such a common paradigm, this functionality is
> better suited to being inside the core ethdev API.
> The new APIs include three functions
On Tue, 24 Jun 2014 23:32:15 +0100
Bruce Richardson wrote:
>
> +static void
> +free_unsent_pkts(struct rte_mbuf **pkts, uint16_t unsent,
> + void *userdata __rte_unused)
> +{
> + unsigned i;
> + for (i = 0; i < unsent; i++)
> + rte_pktmbuf_free(pkts[i]);
> +}
> +
Signed-off-by: Declan Doherty
---
doc/doxy-api-index.md |1 +
doc/doxy-api.conf |1 +
2 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/doc/doxy-api-index.md b/doc/doxy-api-index.md
index 7b26e98..ee3ad4f 100644
--- a/doc/doxy-api-index.md
+++ b/doc/doxy-api-index.md
@@
- Includes the ability to create new bonded devices.
- Add /remove bonding slave devices.
- Interogate bonded device stats/configuration
- Change bonding modes and select balance transmit polices
Signed-off-by: Declan Doherty
---
app/test-pmd/cmdline.c| 579 +
Including:
- code to generate packet bursts for testing rx and tx
functionality of bonded device
- virtual/stubbed out ethdev for use as slave ethdev in testing
Signed-off-by: Declan Doherty
---
app/test/Makefile |4 +-
app/test/commands.c |7 +
app/tes
Updating functionality in EAL to support adding link bonding
devices via ?vdev option. Link bonding devices will be
initialized after all physical devices have been probed and
initialized.
Signed-off-by: Declan Doherty
---
lib/librte_eal/bsdapp/eal/eal.c | 10 -
lib/librte_eal/
Adding support to rte_eth_dev_data structure to support unique
name identifier for ethdevs to support adding slave ethdevs
(specifically virtual devices which have no public unique
identifier) to a link bonding device. This changes the API
rte_eth_dev_allocate() to require a const char *name when
a
Initial release with support for
Mode 0 - Round Robin
Mode 1 - Active Backup
Mode 2 - Balance -> Supports 3 transmit polices (layer 2, layer 2+3, layer 3+4)
Mode 3 - Broadcast
Signed-off-by: Declan Doherty
---
config/common_bsdapp |5 +
config/common_linuxapp |
This patch contains the initial release of the Link Bonding PMD Library
Supporting bonding modes:
0 - Round Robin
1 - Active Backup
2 - Balance (Supporting 3 transmission polices)
layer 2, layer 2+3, layer 3+4
3 - Broadcast
Version 6 of patch set:
Small fix for tx burst function in ro
From: Pablo de Lara
This was previosly solved in commit 60a70d4e042350ca0f9200334b341063438be89b,
but this alternative fix solves the same issue, but without modifying
the ixgbe shared code.
Signed-off-by: Pablo de Lara
---
lib/librte_pmd_ixgbe/ixgbe/ixgbe_82599.c |3 --
lib/librte_pmd_ix
-Original Message-
From: Ananyev, Konstantin
Sent: Tuesday, June 24, 2014 11:31 PM
To: Zhang, Helin; De Lara Guarch, Pablo
Cc: dev at dpdk.org
Subject: RE: [dpdk-dev] [PATCH] ixgbe: Alternative fix for 82599 Bypass NIC,
getting incorrect media type
Hi Helin,
> -Original Message---
-Original Message-
From: Thomas Monjalon [mailto:thomas.monja...@6wind.com]
Sent: Tuesday, June 24, 2014 4:57 PM
To: dev at dpdk.org
Cc: Zhang, Helin
Subject: [PATCH] i40e: prefer base driver naming
The PMD is built on top of the base driver which is provided by Intel and
shouldn't be
Hi Helin,
> -Original Message-
> From: Zhang, Helin
> Sent: Tuesday, June 24, 2014 4:23 PM
> To: Ananyev, Konstantin; De Lara Guarch, Pablo
> Cc: dev at dpdk.org
> Subject: RE: [dpdk-dev] [PATCH] ixgbe: Alternative fix for 82599 Bypass NIC,
> getting incorrect media type
>
> -Origina
-Original Message-
From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Ananyev, Konstantin
Sent: Tuesday, June 24, 2014 10:44 PM
To: Thomas Monjalon; Chen, Jing D
Cc: dev at dpdk.org
Subject: Re: [dpdk-dev] [PATCH] i40e: fix shared code compile warning
Hi Thomas,
> -Original Messag
-Original Message-
From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Ananyev, Konstantin
Sent: Tuesday, June 24, 2014 10:47 PM
To: De Lara Guarch, Pablo; dev at dpdk.org
Subject: Re: [dpdk-dev] [PATCH] ixgbe: Alternative fix for 82599 Bypass NIC,
getting incorrect media type
> This wa
We might want to only change a parameter rather than have to set all possible
parameters, so add "partial" commands.
These commands only change the specified parameter.
To avoid duplicating code all around, a unique parser is kept. This parser uses
the .data parameter to select the right behavior.
Prepare for next commit.
Signed-off-by: David Marchand
---
app/test-pmd/cmdline.c | 74
1 file changed, 37 insertions(+), 37 deletions(-)
diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c
index 3d2a91a..8b85d4d 100644
--- a/app/test-
Following commit 2d95b84aaacb3d2d0bd70367c0530d15e0cbb14e, rte_eth_fc_conf
struct contains a autoneg field that must be set by callers.
Add this parameter to testpmd.
Signed-off-by: David Marchand
---
app/test-pmd/cmdline.c | 15 +--
1 file changed, 13 insertions(+), 2 deletions(-)
Here is a patchset that addresses the problem reported by Jijiang Liu and
introduces "partial" commands for setting flow control parameters in testpmd.
By the way, I tried to factorise the code in testpmd when handling flow control
"commands" so that we have only one parser even if multiple comman
> -Original Message-
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Robert Sanford
> Sent: Monday, June 23, 2014 10:17 PM
> To: dev at dpdk.org
> Subject: [dpdk-dev] [PATCH v3 0/2] malloc: fix malloc and free linear
> complexity
>
> Comments on previous versions of this patch:
>
> This was previosly solved in commit 60a70d4e042350ca0f9200334b341063438be89b,
> but this alternative fix solves the same issue, but without modifying
> the ixgbe shared code.
>
> Signed-off-by: Pablo de Lara
> ---
> lib/librte_pmd_ixgbe/ixgbe/ixgbe_82599.c |3 --
> lib/librte_pmd_ixgbe/i
Hi Thomas,
> -Original Message-
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Thomas Monjalon
> Sent: Tuesday, June 24, 2014 11:06 AM
> To: Chen, Jing D
> Cc: dev at dpdk.org
> Subject: Re: [dpdk-dev] [PATCH] i40e: fix shared code compile warning
>
> 2014-06-24 09:47, Chen, Ji
From: "Chen Jing D(Mark)"
Fix a compile warning in shared code on 32-bits RHEL6.3/6.5.
Signed-off-by: Chen Jing D(Mark)
---
lib/librte_pmd_i40e/Makefile |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/lib/librte_pmd_i40e/Makefile b/lib/librte_pmd_i40e/Makefile
index 09
2014-06-24 10:02, Helin Zhang:
> These patches are enhancements for i40e or relevant. In detail, they
> include: * fix for getting correct RSS hash result.
> * remove an interface which is not used.
> * fix for copying wrong size of link info.
> * fix for updating the hash lookup table of PF RSS
Hi,
On 06/24/2014 12:48 PM, Neil Horman wrote:
> Sounds like it might be time to add in some poisoning options to the mbuf
> allocator.
Such option already exists: CONFIG_RTE_LIBRTE_MBUF_DEBUG and
RTE_LIBRTE_MEMPOOL_DEBUG will enable some runtime checks, at least
double free and buffer overflows.
On Tue, Jun 24, 2014 at 11:21 AM, Thomas Monjalon wrote:
> Welcome Alex.
> Please, for future messages, try to answer below as explained here:
> http://dpdk.org/ml
>
> 2014-06-24 11:12, Alex Markuze:
> > Thomas Monjalon wrote:
> > > 2014-06-23 15:42, Alex Markuze:
> > > > Hi, I'm new to
2014-06-24 09:47, Chen, Jing D:
> From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com]
> > 2014-06-24 13:22, Chen Jing D:
> > > +CFLAGS_i40e_lan_hmc.o += -Wno-error
> >
> > I know we shouldn't modify base drivers. But this one seems to be an
> > important error. In such case, we already mo
Hi Bruce,
2014-06-24 01:23, Bruce Richardson:
> when overriding the CC variable on the commandline, the HOSTCC value
> was remaining at "gcc", which caused errors on Free BSD10 when using a gcc
> as e.g. gcc48, without a binary just called "gcc". This change overrides
> HOSTCC when CC is overridde
2014-06-23 22:53, Richardson, Bruce:
> As for the #define, it's a quick fix, except that we end up having to keep
> it forever as the code using the function will never get changed to use
> rte_snprintf. Given it's just a one-line macro, it's probably not a big
> deal in this case, but I'd rather s
The function rte_snprintf serves no useful purpose. It is the
same as snprintf() for all valid inputs. Deprecate it and
replace all uses in current code.
Leave the tests for the deprecated function in place.
Signed-off-by: Stephen Hemminger
---
v2 -- don't remove rte_snprintf, deprecate instead
Now that snprintf is used, Gcc finds more uses of unsafe arguments.
Fix where found. Some of these may have already been fixed by
other patches on the mailing list.
Signed-off-by: Stephen Hemminger
---
v2 - no changes to this part
--- a/lib/librte_kni/rte_kni.c 2014-06-24 08:48:55.758031238 -
Thomas Thanks for your reply,
I've resolved the issue in a similar way by modifying the VM xml config
file with this line
CONFIG_RTE_MACHINE="x86-64"'
But it didn't seem to matter (I didn't explore this much farther, I
dint really try a clean build and didn't make sure that the .config file
I've m
The PMD is built on top of the base driver which is provided by Intel
and shouldn't be modified to allow easy batch upgrade from Intel.
The base driver is a "shared code" between many projects. But in DPDK,
the "base driver" naming makes more sense.
Signed-off-by: Thomas Monjalon
---
lib/librte
On Tue, 24 Jun 2014 17:39:52 +
"Richardson, Bruce" wrote:
> > -Original Message-
> > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Stephen Hemminger
> > Sent: Tuesday, June 24, 2014 9:03 AM
> > To: dev at dpdk.org
> > Subject: [dpdk-dev] [PATCH 1/3] stringfns: remove rte_snp
Hi,
2014-06-24 13:22, Chen Jing D:
> Fix a compile warning in shared code on 32-bits RHEL6.3/6.5.
>
> Signed-off-by: Chen Jing D(Mark)
In such case you should show the error message in the log.
lib/librte_pmd_i40e/i40e/i40e_lan_hmc.c:917:
error: integer constant is too large for
On Tue, 24 Jun 2014 16:16:02 +
"Ananyev, Konstantin" wrote:
> But now, memzone created for the actual mempool could get leaked instead?
Since memzone's can't be destroyed, then only solution would be if
checked if memzone with same name already exists.
Welcome Alex.
Please, for future messages, try to answer below as explained here:
http://dpdk.org/ml
2014-06-24 11:12, Alex Markuze:
> Thomas Monjalon wrote:
> > 2014-06-23 15:42, Alex Markuze:
> > > Hi, I'm new to DPDK and Im trying to compile on a x86 Ubuntu 14.04
> > VM(KVM).
> > > And
i40e supports 16 and 32 bytes RX descriptors which can be configured.
It needs to check the driver type and the configuration to determine
if 16 or 32 bytes RX descriptors is being used, for reading and
displaying the different sizes of RX descriptors.
Signed-off-by: Helin Zhang
Acked-by: Jing Ch
For NVM4.2.2 or after, the firmware has the correct configurations
and load the macvlan filter as expected. It is not needed to
Update the default macvlan filter which cannot be removed at
all during initialization.
Signed-off-by: Helin Zhang
Acked-by: Jing Chen
Acked-by: Cunming Liang
---
lib
Double vlan should be specifically disabled by default during
port initialization which is expected.
Signed-off-by: Helin Zhang
Acked-by: Jing Chen
Acked-by: Cunming Liang
---
lib/librte_pmd_i40e/i40e_ethdev.c | 4
1 file changed, 4 insertions(+)
diff --git a/lib/librte_pmd_i40e/i40e_eth
The bit shifting were written wrongly in '0x1 < j',
the correct one should be '0x1 << j'.
Signed-off-by: Helin Zhang
Acked-by: Jing Chen
Acked-by: Cunming Liang
---
lib/librte_pmd_i40e/i40e_ethdev.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/librte_pmd_i40e/i40e_et
Fix a bug of copying wrong size of link information in the
function of i40evf_get_link_status().
Signed-off-by: Helin Zhang
Acked-by: Jing Chen
Acked-by: Cunming Liang
---
lib/librte_pmd_i40e/i40e_ethdev_vf.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/librte_pmd_i4
i40evf_dev_atomic_read_link_status() was defined but not used.
To avoid possible warnings by some compilers, it needs to
delete the whole function.
Signed-off-by: Helin Zhang
Acked-by: Jing Chen
Acked-by: Cunming Liang
---
lib/librte_pmd_i40e/i40e_ethdev_vf.c | 14 --
1 file change
It wrongly gets the RSS hash result from the RX descriptor which
has been modified for receiving new packet. The fix is to get the
RSS hash result from the buffer which saves the RX descriptor.
Signed-off-by: Helin Zhang
Acked-by: Jing Chen
Acked-by: Cunming Liang
---
lib/librte_pmd_i40e/i40e_
These patches are enhancements for i40e or relevant. In detail, they include:
* fix for getting correct RSS hash result.
* remove an interface which is not used.
* fix for copying wrong size of link info.
* fix for updating the hash lookup table of PF RSS.
* double vlan should be specifically
Hi Thomas,
-Original Message-
From: Thomas Monjalon [mailto:thomas.monja...@6wind.com]
Sent: Tuesday, June 24, 2014 4:47 PM
To: Chen, Jing D
Cc: dev at dpdk.org
Subject: Re: [dpdk-dev] [PATCH] i40e: fix shared code compile warning
Hi,
2014-06-24 13:22, Chen Jing D:
> Fix a compile warn
Now that snprintf is used, Gcc finds more uses of unsafe arguments.
Fix where found. These may have already been fixed by
other patches on the mailing list.
Signed-off-by: Stephen Hemminger
--- a/lib/librte_kni/rte_kni.c 2014-06-24 08:48:55.758031238 -0700
+++ b/lib/librte_kni/rte_kni.c 2014-
Since GCC catches calling snprintf() with NULL argument at compile time
(which is even better). These string function tests are unnecessary
and no longer compile.
Signed-off-by: Stephen Hemminger
--- a/app/test/test_string_fns.c2014-06-24 08:48:52.558007950 -0700
+++ b/app/test/test_stri
The function rte_snprintf serves no useful purpose. It is the
same as snprintf() for all valid inputs. Just remove it and
replace all uses in current code.
Signed-off-by: Stephen Hemminger
--- a/app/test-pipeline/init.c 2014-06-20 13:23:17.462947732 -0700
+++ b/app/test-pipeline/init.c 2014-0
If mempool can not be created because of insufficient memory
it returns an error but has already created a ring (and leaves it
behind). This prevents code from trying one mempool size and then
retrying with a smaller size if the bigger size fails.
Reordering to do ring creation after getting memo
>
> Paul,
>
> Thanks for the advice; we ran memtest as well as the Dell complete system
> diagnostic and neither found an issue. The plot thickens, though!
>
> Our admins messed up our kickstart labels and what I *thought* was CentOS
> 6.4 was actually RHEL 6.4 and the problem seems to be follow
On Mon, Jun 23, 2014 at 05:43:21PM -0400, Stefan Baranoff wrote:
> Paul,
>
> Thanks for the advice; we ran memtest as well as the Dell complete system
> diagnostic and neither found an issue. The plot thickens, though!
>
> Our admins messed up our kickstart labels and what I *thought* was CentOS
Using gcc 4.8 on FreeBSD 10, support for SSE4.x is not detected by
the compiler, meaning that the ACL library, which depends on SSE4.2
cannot compile. Disable this library for the native target allows
compiles to succeed on FreeBSD 10 using gcc.
Signed-off-by: Bruce Richardson
---
config/defconf
when overriding the CC variable on the commandline, the HOSTCC value
was remaining at "gcc", which caused errors on Free BSD10 when using a gcc
as e.g. gcc48, without a binary just called "gcc". This change overrides
HOSTCC when CC is overridden, which means that setting CC=gcc48, will
now also set
These two small patches fix minor compilation issues found when testing
compilation on a FreeBSD 10 system.
Bruce Richardson (2):
mk: overriding CC also overrides HOSTCC
bsdapp: disable ACL library compilation
config/defconfig_x86_64-native-bsdapp-gcc | 5 +
mk/toolchain/gcc/rte.vars.m
77 matches
Mail list logo
