Re: [VOTE] Release Apache Doris-Sdk 1.0.0

2023-05-11 Thread Jiafeng.Zhang
Here is my +1(binding). I checked: [x] The download link is legal and the PGP signature are valid. [x] The source code matches the current release version. [x] The LICENSE and NOTICE files are correct. Jiafeng.Zhang / 张家锋 Email: jiafengzh...@apache.org Mingyu Chen 于2023年5月11日周四 00:03写道: > Here

Re:[VOTE] Release Apache Doris-Sdk 1.0.0

2023-05-10 Thread Mingyu Chen
Here is my +1 (binding) I checked: [x] The download link is legal. [x] The PGP signature are valid. [x] The source code matches the current release version. [x] All files carry the necessary protocol header. [x] The compiled content is not included in the source package. I didn't check the comp

Re:[VOTE] Release Apache Doris-Sdk 1.0.0

2023-05-10 Thread "Kaijie Chen"
Thanks Dongliang for explaining, > 3. For THRIFT BIN, you may not have noticed that the README.md document has > explained how to install thrift 0.16.0. I was using the thrift from Doris thirdparty, quote from README.md: > Note: If you have compiled Doris, you do not need to install thrift, y

Re:[VOTE] Release Apache Doris-Sdk 1.0.0

2023-05-10 Thread 吴栋梁
Thanks to Kaijie Chen for the suggestion. Below I will answer some questions: 1. For the problem of LICENSE.txt, it does contain unused items, we will fix this in the next version. 2. CHANGE-LOG.txt is just to explain some changes in this release, here don’t need license header. 3. For THRIFT

Re:[VOTE] Release Apache Doris-Sdk 1.0.0

2023-05-10 Thread "Kaijie Chen"
Thanks wudi for hosting the release. +0 (non-binding), a few benign cons from me. Pros: * Download link, checksum and signature is valid. * Source code matches the current release version and git tag. * NOTICE.txt is correct. * No unexpected binary files in source package. * Build from source suc

Re:[VOTE] Release Apache Doris-Sdk 1.0.0

2023-05-10 Thread 吴栋梁
+1 吴栋梁 wudongli...@selectdb.com Original: From:wudi <676366...@qq.com.INVALID>Date:2023-05-10 14:55:47To:devCc:Subject:[VOTE] Release Apache Doris-Sdk 1.0.0Hi all, This is a call for the vote to release Apache Doris-SDK 1.0.0 The git tag for the release: https://github.com/apa