Thanks wudi for hosting the release. +0 (non-binding), a few benign cons from me.
Pros: * Download link, checksum and signature is valid. * Source code matches the current release version and git tag. * NOTICE.txt is correct. * No unexpected binary files in source package. * Build from source successfully. Cons: * LICENSE.txt contains unused items (used in doris but not doris-sdk) * Missing license header in CHANGE-LOG.txt (probably fine?) * Setting THRIFT_BIN only is not enough, you have to include thrift bin in PATH (maybe update the docs?) === LOG === [INFO] --- maven-thrift-plugin:0.1.11:compile (thrift-sources) @ thrift-service --- [ERROR] thrift failed output: [ERROR] thrift failed error: /bin/sh: thrift: command not found Best, Kaijie Chen ---- On Wed, 10 May 2023 15:38:28 +0800 吴栋梁 wrote --- > +1 > > > > > > > > 吴栋梁 > wudongli...@selectdb.com > > > > > > > > > > > > Original: > From：wudi 676366...@qq.com.INVALID>Date：2023-05-10 > 14:55:47To：dev...@doris.apache.org>Cc：Subject：[VOTE] Release Apache > Doris-Sdk 1.0.0Hi all, > > This is a call for the vote to release Apache Doris-SDK 1.0.0 > > The git tag for the release: > https://github.com/apache/doris-sdk/releases/tag/1.0.0 > https://github.com/apache/doris-shade/releases/tag/doris-shade-1.0.0> > > Release Notes are here: > https://github.com/apache/doris-sdk/blob/1.0.0/CHANGE-LOG.txt > https://github.com/apache/doris-shade/blob/doris-shade-1.0.0/CHANGE-LOG.txt> > > Thanks to everyone who has contributed to this release. > > The release candidates: > https://dist.apache.org/repos/dist/dev/doris/doris-sdk/1.0.0/ > https://dist.apache.org/repos/dist/dev/doris/doris-shade/> > > This has been signed with PGP key A692590313BF6657160079C0211FCDC7FC019983, > corresponding to > d...@apache.org d...@apache.org>. > > KEYS file is available here: > https://downloads.apache.org/doris/KEYS > https://downloads.apache.org/doris/KEYS> > > To verify and build, you can refer to following link: > https://doris.apache.org/community/release-and-verify/release-verify > https://doris.apache.org/community/release-and-verify/release-verify> > > The vote will be open for at least 72 hours. > > [ ] +1 Approve the release > [ ] +0 No opinion > [ ] -1 Do not release this package because … > > > Brs, > di.wu > > > > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@doris.apache.org For additional commands, e-mail: dev-h...@doris.apache.org
