Here is my +1(binding).

I checked:
[x] The download link is legal and the PGP signature are valid.
[x] The source code matches the current release version.
[x] The LICENSE and NOTICE files are correct.

Jiafeng.Zhang / 张家锋
Email: jiafengzh...@apache.org

Mingyu Chen <morning...@163.com> 于2023年5月11日周四 00:03写道:

> Here is my +1 (binding)
> I checked:
>
>
> [x] The download link is legal.
> [x] The PGP signature are valid.
> [x] The source code matches the current release version.
> [x] All files carry the necessary protocol header.
> [x] The compiled content is not included in the source package.
>
>
> I didn't check the compilation.
>
>
> And beside, there are some suggestions:
>
>
> 1. We need to find a way to detect if the thrift file change in Doris core
> repo. And we need to change it synchronizly.
> 2. Please update the release document:
> https://doris.apache.org/community/release-and-verify/release-prepare, to
> add steps how to do release this repo.
>
>
>
>
> --
>
> Best Regards
> Mingyu Chen
>
> Email:
> morning...@apache.org
>
>
>
>
>
> At 2023-05-10 14:55:47, "wudi" <676366...@qq.com.INVALID> wrote:
> >Hi all,
> >
> >This is a call for the vote to release Apache Doris-SDK 1.0.0
> >
> >The git tag for the release:
> >https://github.com/apache/doris-sdk/releases/tag/1.0.0 <
> https://github.com/apache/doris-shade/releases/tag/doris-shade-1.0.0>
> >
> >Release Notes are here:
> >https://github.com/apache/doris-sdk/blob/1.0.0/CHANGE-LOG.txt <
> https://github.com/apache/doris-shade/blob/doris-shade-1.0.0/CHANGE-LOG.txt
> >
> >
> >Thanks to everyone who has contributed to this release.
> >
> >The release candidates:
> >https://dist.apache.org/repos/dist/dev/doris/doris-sdk/1.0.0/ <
> https://dist.apache.org/repos/dist/dev/doris/doris-shade/>
> >
> >This has been signed with PGP key
> A692590313BF6657160079C0211FCDC7FC019983, corresponding to
> >d...@apache.org <mailto:d...@apache.org>.
> >
> >KEYS file is available here:
> >https://downloads.apache.org/doris/KEYS <
> https://downloads.apache.org/doris/KEYS>
> >
> >To verify and build, you can refer to following link:
> >https://doris.apache.org/community/release-and-verify/release-verify <
> https://doris.apache.org/community/release-and-verify/release-verify>
> >
> >The vote will be open for at least 72 hours.
> >
> >[ ] +1 Approve the release
> >[ ] +0 No opinion
> >[ ] -1 Do not release this package because …
> >
> >
> >Brs,
> >di.wu
>


-- 
张家峰

Reply via email to