Re: [PR] Add PostgreSQL specfic "CREATE TYPE t AS ENUM (...)" support. [datafusion-sqlparser-rs]

2024-10-08 Thread via GitHub
iffyio commented on code in PR #1460: URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1460#discussion_r1792219167 ## src/dialect/postgresql.rs: ## @@ -138,6 +138,14 @@ impl Dialect for PostgreSqlDialect { fn parse_statement(&self, parser: &mut Parser) -> Option

Re: [PR] chore: Add asf.yaml [datafusion-sqlparser-rs]

2024-10-09 Thread via GitHub
alamb merged PR #1463: URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1463 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@

Re: [PR] chore: Add asf.yaml [datafusion-sqlparser-rs]

2024-10-09 Thread via GitHub
Xuanwo commented on code in PR #1463: URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1463#discussion_r1793693500 ## .asf.yaml: ## @@ -0,0 +1,42 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTI

Re: [PR] Add support for ASC and DESC in CREATE TABLE column constraints for SQLite. [datafusion-sqlparser-rs]

2024-10-08 Thread via GitHub
alamb merged PR #1462: URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1462 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@

Re: [PR] Add support of `EXPLAIN QUERY PLAN` syntax for SQLite dialect [datafusion-sqlparser-rs]

2024-10-08 Thread via GitHub
alamb merged PR #1458: URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1458 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@

Re: [I] `EXPLAIN QUERY PLAN` fails to parse (sqlite) [datafusion-sqlparser-rs]

2024-10-08 Thread via GitHub
alamb closed issue #1455: `EXPLAIN QUERY PLAN` fails to parse (sqlite) URL: https://github.com/apache/datafusion-sqlparser-rs/issues/1455 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] Add support for quantified comparison predicates (ALL/ANY/SOME) [datafusion-sqlparser-rs]

2024-10-08 Thread via GitHub
iffyio commented on code in PR #1459: URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1459#discussion_r1792185691 ## src/ast/mod.rs: ## @@ -646,12 +646,16 @@ pub enum Expr { regexp: bool, }, /// `ANY` operation e.g. `foo > ANY(bar)`, comparison op

Re: [PR] Add support for quantified comparison predicates (ALL/ANY/SOME) [datafusion-sqlparser-rs]

2024-10-08 Thread via GitHub
yoavcloud commented on PR #1459: URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1459#issuecomment-2400352384 Pushed doc changes as recommended. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

Re: [PR] Implement `Spanned` to retrieve source locations on AST nodes [datafusion-sqlparser-rs]

2024-10-09 Thread via GitHub
Nyrox commented on code in PR #1435: URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1435#discussion_r1793097747 ## src/ast/spans.rs: ## @@ -0,0 +1,1768 @@ +use core::iter; + +use crate::tokenizer::Span; + +use super::{ +AlterColumnOperation, AlterIndexOperation

Re: [PR] Implement `Spanned` to retrieve source locations on AST nodes [datafusion-sqlparser-rs]

2024-10-09 Thread via GitHub
Nyrox commented on code in PR #1435: URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1435#discussion_r1793098167 ## src/ast/spans.rs: ## @@ -0,0 +1,1768 @@ +use core::iter; + +use crate::tokenizer::Span; + +use super::{ +AlterColumnOperation, AlterIndexOperation

Re: [PR] Add "DROP TYPE" support. [datafusion-sqlparser-rs]

2024-10-09 Thread via GitHub
alamb merged PR #1461: URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1461 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@

Re: [PR] Add "DROP TYPE" support. [datafusion-sqlparser-rs]

2024-10-09 Thread via GitHub
alamb commented on PR #1461: URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1461#issuecomment-2402430677 🚀 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] chore: Add asf.yaml [datafusion-sqlparser-rs]

2024-10-09 Thread via GitHub
tisonkun commented on code in PR #1463: URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1463#discussion_r1793132420 ## .asf.yaml: ## @@ -0,0 +1,43 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NO

Re: [PR] Implement `Spanned` to retrieve source locations on AST nodes [datafusion-sqlparser-rs]

2024-10-09 Thread via GitHub
Nyrox commented on code in PR #1435: URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1435#discussion_r1793045556 ## src/ast/mod.rs: ## @@ -156,6 +179,30 @@ impl Ident { Ident { value: value.into(), quote_style: Some(quote), +

Re: [PR] chore: Add asf.yaml [datafusion-sqlparser-rs]

2024-10-09 Thread via GitHub
Xuanwo commented on code in PR #1463: URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1463#discussion_r1793137226 ## .asf.yaml: ## @@ -0,0 +1,43 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTI

Re: [PR] chore: Add asf.yaml [datafusion-sqlparser-rs]

2024-10-09 Thread via GitHub
Xuanwo commented on code in PR #1463: URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1463#discussion_r1793137713 ## .asf.yaml: ## @@ -0,0 +1,43 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTI

Re: [PR] chore: Add asf.yaml [datafusion-sqlparser-rs]

2024-10-09 Thread via GitHub
alamb commented on code in PR #1463: URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1463#discussion_r1793529354 ## .asf.yaml: ## @@ -0,0 +1,42 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTIC

[PR] chore: Add asf.yaml [datafusion-sqlparser-rs]

2024-10-09 Thread via GitHub
Xuanwo opened a new pull request, #1463: URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1463 This PR adds `asf.yaml` which mainly copied from https://github.com/apache/datafusion/blob/main/.asf.yaml After this change, we can avoid sending too many traffic to dev@d.a.o.

Re: [PR] chore: Add asf.yaml [datafusion-sqlparser-rs]

2024-10-09 Thread via GitHub
coveralls commented on PR #1463: URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1463#issuecomment-2401717571 ## Pull Request Test Coverage Report for [Build 11251382349](https://coveralls.io/builds/70242932) ### Details * **0** of **0** changed or added rele

Re: [PR] Snowflake: support for extended column options in `CREATE TABLE` [datafusion-sqlparser-rs]

2024-10-09 Thread via GitHub
7phs commented on code in PR #1454: URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1454#discussion_r1793276815 ## src/ast/ddl.rs: ## @@ -1098,17 +1098,116 @@ impl fmt::Display for ColumnOptionDef { } } +#[derive(Debug, Clone, PartialEq, PartialOrd, Eq, Ord,

Re: [PR] Snowflake: support for extended column options in `CREATE TABLE` [datafusion-sqlparser-rs]

2024-10-09 Thread via GitHub
7phs commented on code in PR #1454: URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1454#discussion_r1793277714 ## src/parser/mod.rs: ## @@ -6193,24 +6186,160 @@ impl<'a> Parser<'a> { && dialect_of!(self is MySqlDialect | SQLiteDialect | DuckDbDialect

Re: [PR] Snowflake: support for extended column options in `CREATE TABLE` [datafusion-sqlparser-rs]

2024-10-09 Thread via GitHub
7phs commented on code in PR #1454: URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1454#discussion_r1793281102 ## src/parser/mod.rs: ## @@ -6193,24 +6186,160 @@ impl<'a> Parser<'a> { && dialect_of!(self is MySqlDialect | SQLiteDialect | DuckDbDialect

Re: [PR] Snowflake: support for extended column options in `CREATE TABLE` [datafusion-sqlparser-rs]

2024-10-09 Thread via GitHub
7phs commented on code in PR #1454: URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1454#discussion_r1793279817 ## src/ast/ddl.rs: ## @@ -1291,11 +1406,13 @@ impl fmt::Display for ColumnOption { write!(f, "OPTIONS({})", display_comma_separated(optio

Re: [PR] Snowflake: support for extended column options in `CREATE TABLE` [datafusion-sqlparser-rs]

2024-10-09 Thread via GitHub
7phs commented on code in PR #1454: URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1454#discussion_r1793281102 ## src/parser/mod.rs: ## @@ -6193,24 +6186,160 @@ impl<'a> Parser<'a> { && dialect_of!(self is MySqlDialect | SQLiteDialect | DuckDbDialect

Re: [PR] Snowflake: support for extended column options in `CREATE TABLE` [datafusion-sqlparser-rs]

2024-10-09 Thread via GitHub
7phs commented on code in PR #1454: URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1454#discussion_r1793283035 ## src/parser/mod.rs: ## @@ -6193,24 +6186,160 @@ impl<'a> Parser<'a> { && dialect_of!(self is MySqlDialect | SQLiteDialect | DuckDbDialect

Re: [PR] Snowflake: support for extended column options in `CREATE TABLE` [datafusion-sqlparser-rs]

2024-10-09 Thread via GitHub
7phs commented on code in PR #1454: URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1454#discussion_r1793354187 ## tests/sqlparser_snowflake.rs: ## @@ -525,6 +525,307 @@ fn test_snowflake_single_line_tokenize() { assert_eq!(expected, tokens); } +#[test] +fn

Re: [PR] Snowflake: support for extended column options in `CREATE TABLE` [datafusion-sqlparser-rs]

2024-10-09 Thread via GitHub
7phs commented on code in PR #1454: URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1454#discussion_r1793352226 ## tests/sqlparser_snowflake.rs: ## @@ -525,6 +525,307 @@ fn test_snowflake_single_line_tokenize() { assert_eq!(expected, tokens); } +#[test] +fn

[PR] fix for maybe_parse preventing parser from erroring on recursion limit [datafusion-sqlparser-rs]

2024-10-09 Thread via GitHub
tomershaniii opened a new pull request, #1464: URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1464 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] Implement `Spanned` to retrieve source locations on AST nodes [datafusion-sqlparser-rs]

2024-10-09 Thread via GitHub
Nyrox commented on code in PR #1435: URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1435#discussion_r1793057894 ## src/ast/spans.rs: ## @@ -0,0 +1,1768 @@ +use core::iter; + +use crate::tokenizer::Span; + +use super::{ +AlterColumnOperation, AlterIndexOperation

[PR] adding sqlite data files [datafusion-testing]

2024-12-26 Thread via GitHub
Omega359 opened a new pull request, #1: URL: https://github.com/apache/datafusion-testing/pull/1 Adding sqlite data files for sqllogictests. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

Re: [PR] adding sqlite data files [datafusion-testing]

2024-12-26 Thread via GitHub
jonahgao merged PR #1: URL: https://github.com/apache/datafusion-testing/pull/1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@datafusi