7phs commented on code in PR #1454:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1454#discussion_r1793279817
##########
src/ast/ddl.rs:
##########
@@ -1291,11 +1406,13 @@ impl fmt::Display for ColumnOption {
write!(f, "OPTIONS({})", display_comma_separated(options))
}
Identity(parameters) => {
- write!(f, "IDENTITY")?;
- if let Some(parameters) = parameters {
- write!(f, "({parameters})")?;
- }
- Ok(())
+ write!(f, "{parameters}")
+ }
+ Policy(parameters) => {
+ write!(f, "{parameters}")
+ }
+ Tags(tags) => {
+ write!(f, "WITH TAG ({})", display_comma_separated(tags))
Review Comment:
Current implementation of similar options of table has no this flag - it is
a reason that I skipped it.
I added `with` flag to existing structs and updated tags columns option
definition.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@datafusion.apache.org
For additional commands, e-mail: dev-h...@datafusion.apache.org
