7phs commented on code in PR #1454:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1454#discussion_r1793281102
##########
src/parser/mod.rs:
##########
@@ -6193,24 +6186,160 @@ impl<'a> Parser<'a> {
&& dialect_of!(self is MySqlDialect | SQLiteDialect |
DuckDbDialect | GenericDialect)
{
self.parse_optional_column_option_as()
+ } else if self.parse_keyword(Keyword::AUTOINCREMENT)
+ && dialect_of!(self is SnowflakeDialect | SQLiteDialect |
GenericDialect)
+ {
+ if dialect_of!(self is SnowflakeDialect) {
Review Comment:
I moved all snowflake specific code of column options parsing into snowflake
dialect implementation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@datafusion.apache.org
For additional commands, e-mail: dev-h...@datafusion.apache.org
