alamb merged PR #1463:
URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1463
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@
Xuanwo commented on code in PR #1463:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1463#discussion_r1793693500
##
.asf.yaml:
##
@@ -0,0 +1,42 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTI
There is an epic PR/proposal [1] that I would like everyone to be aware of.
The PR has a lot of detail to explain the motivation, but the TL;DR is that
this PR trims Ballista down to be a library that people can extend rather
than an out-of-the-box application.
Copied from the PR description: Thi
Nyrox commented on code in PR #1435:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1435#discussion_r1793097747
##
src/ast/spans.rs:
##
@@ -0,0 +1,1768 @@
+use core::iter;
+
+use crate::tokenizer::Span;
+
+use super::{
+AlterColumnOperation, AlterIndexOperation
Nyrox commented on code in PR #1435:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1435#discussion_r1793098167
##
src/ast/spans.rs:
##
@@ -0,0 +1,1768 @@
+use core::iter;
+
+use crate::tokenizer::Span;
+
+use super::{
+AlterColumnOperation, AlterIndexOperation
alamb merged PR #1461:
URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1461
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@
alamb commented on PR #1461:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1461#issuecomment-2402430677
🚀
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
tisonkun commented on code in PR #1463:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1463#discussion_r1793132420
##
.asf.yaml:
##
@@ -0,0 +1,43 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NO
Nyrox commented on code in PR #1435:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1435#discussion_r1793045556
##
src/ast/mod.rs:
##
@@ -156,6 +179,30 @@ impl Ident {
Ident {
value: value.into(),
quote_style: Some(quote),
+
Xuanwo commented on code in PR #1463:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1463#discussion_r1793137226
##
.asf.yaml:
##
@@ -0,0 +1,43 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTI
Xuanwo commented on code in PR #1463:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1463#discussion_r1793137713
##
.asf.yaml:
##
@@ -0,0 +1,43 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTI
alamb commented on code in PR #1463:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1463#discussion_r1793529354
##
.asf.yaml:
##
@@ -0,0 +1,42 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTIC
Xuanwo opened a new pull request, #1463:
URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1463
This PR adds `asf.yaml` which mainly copied from
https://github.com/apache/datafusion/blob/main/.asf.yaml
After this change, we can avoid sending too many traffic to dev@d.a.o.
coveralls commented on PR #1463:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1463#issuecomment-2401717571
## Pull Request Test Coverage Report for [Build
11251382349](https://coveralls.io/builds/70242932)
### Details
* **0** of **0** changed or added rele
7phs commented on code in PR #1454:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1454#discussion_r1793276815
##
src/ast/ddl.rs:
##
@@ -1098,17 +1098,116 @@ impl fmt::Display for ColumnOptionDef {
}
}
+#[derive(Debug, Clone, PartialEq, PartialOrd, Eq, Ord,
7phs commented on code in PR #1454:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1454#discussion_r1793277714
##
src/parser/mod.rs:
##
@@ -6193,24 +6186,160 @@ impl<'a> Parser<'a> {
&& dialect_of!(self is MySqlDialect | SQLiteDialect |
DuckDbDialect
7phs commented on code in PR #1454:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1454#discussion_r1793281102
##
src/parser/mod.rs:
##
@@ -6193,24 +6186,160 @@ impl<'a> Parser<'a> {
&& dialect_of!(self is MySqlDialect | SQLiteDialect |
DuckDbDialect
7phs commented on code in PR #1454:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1454#discussion_r1793279817
##
src/ast/ddl.rs:
##
@@ -1291,11 +1406,13 @@ impl fmt::Display for ColumnOption {
write!(f, "OPTIONS({})", display_comma_separated(optio
7phs commented on code in PR #1454:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1454#discussion_r1793281102
##
src/parser/mod.rs:
##
@@ -6193,24 +6186,160 @@ impl<'a> Parser<'a> {
&& dialect_of!(self is MySqlDialect | SQLiteDialect |
DuckDbDialect
7phs commented on code in PR #1454:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1454#discussion_r1793283035
##
src/parser/mod.rs:
##
@@ -6193,24 +6186,160 @@ impl<'a> Parser<'a> {
&& dialect_of!(self is MySqlDialect | SQLiteDialect |
DuckDbDialect
7phs commented on code in PR #1454:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1454#discussion_r1793354187
##
tests/sqlparser_snowflake.rs:
##
@@ -525,6 +525,307 @@ fn test_snowflake_single_line_tokenize() {
assert_eq!(expected, tokens);
}
+#[test]
+fn
7phs commented on code in PR #1454:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1454#discussion_r1793352226
##
tests/sqlparser_snowflake.rs:
##
@@ -525,6 +525,307 @@ fn test_snowflake_single_line_tokenize() {
assert_eq!(expected, tokens);
}
+#[test]
+fn
tomershaniii opened a new pull request, #1464:
URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1464
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
Nyrox commented on code in PR #1435:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1435#discussion_r1793057894
##
src/ast/spans.rs:
##
@@ -0,0 +1,1768 @@
+use core::iter;
+
+use crate::tokenizer::Span;
+
+use super::{
+AlterColumnOperation, AlterIndexOperation
24 matches
Mail list logo
