Re: [PR] CXF-9003: Name clash when two SEIs have a same name method in the same Java package [cxf]

2025-01-31 Thread via GitHub
reta commented on code in PR #2237: URL: https://github.com/apache/cxf/pull/2237#discussion_r1937279650 ## rt/frontend/jaxws/src/main/java/org/apache/cxf/jaxws/spi/WrapperClassNamingConvention.java: ## @@ -0,0 +1,148 @@ +/** + * Licensed to the Apache Software Foundation (ASF) u

Re: [PR] CXF-9003: Name clash when two SEIs have a same name method in the same Java package [cxf]

2025-01-31 Thread via GitHub
reta commented on code in PR #2237: URL: https://github.com/apache/cxf/pull/2237#discussion_r1937280194 ## rt/frontend/jaxws/src/main/java/org/apache/cxf/jaxws/spi/WrapperClassNamingConvention.java: ## @@ -0,0 +1,148 @@ +/** + * Licensed to the Apache Software Foundation (ASF) u

Re: [PR] CXF-9003: Name clash when two SEIs have a same name method in the same Java package [cxf]

2025-01-31 Thread via GitHub
reta commented on code in PR #2237: URL: https://github.com/apache/cxf/pull/2237#discussion_r1937284604 ## rt/frontend/jaxws/src/test/java/org/apache/cxf/jaxws/spi/WrapperClassLoaderTest.java: ## @@ -115,8 +119,31 @@ public void testWrapperClassLoaderWhenNoWrappedOperations() t

Re: [PR] CXF-9003: Name clash when two SEIs have a same name method in the same Java package [cxf]

2025-01-31 Thread via GitHub
reta commented on PR #2237: URL: https://github.com/apache/cxf/pull/2237#issuecomment-2627294305 Love it @ppalaga , thank you, a few nits but LGTM otherwise, @ffang wdyt? Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [PR] CXF-9003: Name clash when two SEIs have a same name method in the same Java package [cxf]

2025-01-31 Thread via GitHub
ffang commented on PR #2237: URL: https://github.com/apache/cxf/pull/2237#issuecomment-2627314942 > Love it @ppalaga , thank you, a few nits but LGTM otherwise, @ffang wdyt? Thanks! LGTM, thanks @ppalaga , @reta ! -- This is an automated message from the Apache Git Service. To resp

Re: [PR] CXF-9003: Name clash when two SEIs have a same name method in the same Java package [cxf]

2025-01-31 Thread via GitHub
ppalaga commented on code in PR #2237: URL: https://github.com/apache/cxf/pull/2237#discussion_r1937115315 ## rt/frontend/jaxws/src/main/java/org/apache/cxf/jaxws/spi/WrapperClassUtils.java: ## @@ -0,0 +1,60 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one

Re: [PR] CXF-9003: Name clash when two SEIs have a same name method in the same Java package [cxf]

2025-01-31 Thread via GitHub
ppalaga commented on PR #2237: URL: https://github.com/apache/cxf/pull/2237#issuecomment-2627037528 6582f43: * Improved the JavaDoc as suggested by @reta * Introduced a new extension, called `WrapperClassNamingConvention` for the naming. * Provided two implementations of the a

[PR] Bump net.sourceforge.pmd:pmd-core from 6.55.0 to 7.10.0 in /parent [cxf]

2025-01-31 Thread via GitHub
dependabot[bot] opened a new pull request, #2244: URL: https://github.com/apache/cxf/pull/2244 Bumps [net.sourceforge.pmd:pmd-core](https://github.com/pmd/pmd) from 6.55.0 to 7.10.0. Release notes Sourced from https://github.com/pmd/pmd/releases";>net.sourceforge.pmd:pmd-core's re

Re: [PR] Bump com.google.code.gson:gson from 2.12.0 to 2.12.1 [cxf]

2025-01-31 Thread via GitHub
reta merged PR #2241: URL: https://github.com/apache/cxf/pull/2241 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cxf.apache.org For q

Re: [PR] Bump org.owasp:dependency-check-maven from 12.0.1 to 12.0.2 [cxf]

2025-01-31 Thread via GitHub
reta merged PR #2240: URL: https://github.com/apache/cxf/pull/2240 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cxf.apache.org For q

Re: [PR] CXF-9039: Run Jakarta RESTful Web Services 3.1 TCK. Fixing test failures [cxf]

2025-01-31 Thread via GitHub
reta merged PR #2242: URL: https://github.com/apache/cxf/pull/2242 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cxf.apache.org For q

Re: [PR] Bump net.sourceforge.pmd:pmd-java from 6.55.0 to 7.9.0 [cxf-build-utils]

2025-01-31 Thread via GitHub
dependabot[bot] closed pull request #143: Bump net.sourceforge.pmd:pmd-java from 6.55.0 to 7.9.0 URL: https://github.com/apache/cxf-build-utils/pull/143 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[PR] Bump net.sourceforge.pmd:pmd-java from 6.55.0 to 7.10.0 [cxf-build-utils]

2025-01-31 Thread via GitHub
dependabot[bot] opened a new pull request, #144: URL: https://github.com/apache/cxf-build-utils/pull/144 Bumps [net.sourceforge.pmd:pmd-java](https://github.com/pmd/pmd) from 6.55.0 to 7.10.0. Release notes Sourced from https://github.com/pmd/pmd/releases";>net.sourceforge.pmd:pmd-

Re: [PR] Bump net.sourceforge.pmd:pmd-java from 6.55.0 to 7.9.0 [cxf-build-utils]

2025-01-31 Thread via GitHub
dependabot[bot] commented on PR #143: URL: https://github.com/apache/cxf-build-utils/pull/143#issuecomment-2628507821 Superseded by #144. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

Re: [PR] [CXF-9105] add synchronized to the principal iteration [cxf]

2025-01-31 Thread via GitHub
sstremler commented on PR #2245: URL: https://github.com/apache/cxf/pull/2245#issuecomment-2628556571 > Thank you @sstremler , a few comments but LGTM otherwise! Thank you, I added the changes you suggested. -- This is an automated message from the Apache Git Service. To respond to

Re: [PR] [CXF-9105] add synchronized to the principal iteration [cxf]

2025-01-31 Thread via GitHub
reta commented on code in PR #2245: URL: https://github.com/apache/cxf/pull/2245#discussion_r1938068328 ## rt/features/logging/src/main/java/org/apache/cxf/ext/logging/event/DefaultLogEventMapper.java: ## @@ -125,31 +126,36 @@ private String getPrincipal(Message message) {

Re: [PR] [CXF-9105] add synchronized to the principal iteration [cxf]

2025-01-31 Thread via GitHub
reta commented on code in PR #2245: URL: https://github.com/apache/cxf/pull/2245#discussion_r1938070843 ## rt/features/logging/src/main/java/org/apache/cxf/ext/logging/event/DefaultLogEventMapper.java: ## @@ -125,31 +126,36 @@ private String getPrincipal(Message message) {

Re: [PR] [CXF-9105] add synchronized to the principal iteration [cxf]

2025-01-31 Thread via GitHub
reta commented on PR #2245: URL: https://github.com/apache/cxf/pull/2245#issuecomment-2628539485 Thank you @sstremler , a few comments but LGTM otherwise! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t