reta commented on code in PR #2237: URL: https://github.com/apache/cxf/pull/2237#discussion_r1937280194
########## rt/frontend/jaxws/src/main/java/org/apache/cxf/jaxws/spi/WrapperClassNamingConvention.java: ########## @@ -0,0 +1,148 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.cxf.jaxws.spi; + +import java.util.Locale; +import java.util.regex.Pattern; + +import org.apache.cxf.common.util.PackageUtils; +/** + * Provides names for storing generated wrapper classes. + * + * @since 4.2.0 + */ +public interface WrapperClassNamingConvention { + + /** + * Returns a package name unique for the given {@code sei} and {@code anonymous} + * parameters suitable for storing generated wrapper classes. + * + * @param sei the service endpoint interface for which the package name should be created + * @param anonymous whether the generated wrapper types are anonymous + * @return a valid Java package name + */ + String getWrapperClassPackageName(Class<?> sei, boolean anonymous); + + /** + * Default naming scheme since CXF 4.2.0. + * <p> + * The package name returned by {@link #getWrapperClassPackageName(Class, boolean)} are unique + * per given {@code sei}. + * <p> + * Examples: + * <table> + * <tr> + * <th>SEI</th><th>anonymous</th> + * <th>{@code getWrapperClassPackageName()} return value</th> + * </tr> + * <tr> + * <td>{@code org.example.Service}</td> + * <td>{@code false}</td> + * <td>{@code org.example.jaxws_asm.service}</td> + * </tr> + * <tr> + * <td>{@code org.example.OuterClass$Service}</td> + * <td>{@code false}</td> + * <td>{@code org.example.jaxws_asm.outerclass_service}</td> + * </tr> + * <tr> + * <td>{@code org.example.Service}</td> + * <td>{@code true}</td> + * <td>{@code org.example.jaxws_asm_an.service}</td> + * </tr> + * </table> + * + * @since 4.2.0 Review Comment: ```suggestion * @since 4.1.1 ``` ########## rt/frontend/jaxws/src/main/java/org/apache/cxf/jaxws/spi/WrapperClassNamingConvention.java: ########## @@ -0,0 +1,148 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.cxf.jaxws.spi; + +import java.util.Locale; +import java.util.regex.Pattern; + +import org.apache.cxf.common.util.PackageUtils; +/** + * Provides names for storing generated wrapper classes. + * + * @since 4.2.0 Review Comment: ```suggestion * @since 4.1.1 ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cxf.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
