Re: [PR] CXF-9003: Name clash when two SEIs have a same name method in the same Java package [cxf]

[via GitHub]

reta commented on code in PR #2237:
URL: https://github.com/apache/cxf/pull/2237#discussion_r1937284604


##########
rt/frontend/jaxws/src/test/java/org/apache/cxf/jaxws/spi/WrapperClassLoaderTest.java:
##########
@@ -115,8 +119,31 @@ public void 
testWrapperClassLoaderWhenNoWrappedOperations() throws Exception {
     }
 
     @org.junit.Test
-    public void testWrapperClassLoaderWithWrappedOperations() throws Exception 
{
-        WrapperClassLoader wrapperClassLoader = new WrapperClassLoader(bus);
+    public void 
testWrapperClassLoaderWithWrappedOperationsAndDefaultConvention() throws 
Exception {
+        final List<String> loadedClassNames = 
testWrapperClassLoaderWithNamingConvention(
+                new 
WrapperClassNamingConvention.DefaultWrapperClassNamingConvention());
+        assertEquals(
+                List.of(
+                        "org.apache.cxf.jaxws.service.jaxws_asm.sayhi.SayHi",
+                        
"org.apache.cxf.jaxws.service.jaxws_asm.sayhi.SayHiResponse"),
+                loadedClassNames);
+    }
+
+    @org.junit.Test
+    public void 
testWrapperClassLoaderWithWrappedOperationsAndLegacyConvention() throws 
Exception {
+        final List<String> loadedClassNames = 
testWrapperClassLoaderWithNamingConvention(
+                new 
WrapperClassNamingConvention.LegacyWrapperClassNamingConvention());
+        assertEquals(
+                List.of(
+                        "org.apache.cxf.jaxws.service.jaxws_asm.SayHi",
+                        
"org.apache.cxf.jaxws.service.jaxws_asm.SayHiResponse"),
+                loadedClassNames);
+    }
+
+    public List<String> 
testWrapperClassLoaderWithNamingConvention(WrapperClassNamingConvention 
convention)

Review Comment:
   ```suggestion
       private List<String> 
testWrapperClassLoaderWithNamingConvention(WrapperClassNamingConvention 
convention)
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cxf.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org