[GitHub] cordova-app-hello-world pull request: CB-2528 Add window.onerror

2014-03-10 Thread jsoref
Github user jsoref commented on a diff in the pull request: https://github.com/apache/cordova-app-hello-world/pull/6#discussion_r10442330 --- Diff: www/index.html --- @@ -37,6 +37,8 @@

[GitHub] cordova-mobile-spec pull request: [firefoxos] CB-3208 Added suppor...

2014-03-10 Thread jsoref
Github user jsoref commented on a diff in the pull request: https://github.com/apache/cordova-mobile-spec/pull/44#discussion_r10442560 --- Diff: autotest/tests/contacts.tests.js --- @@ -341,13 +348,18 @@ describe("Contacts (navigator.contacts)"

[GitHub] cordova-mobile-spec pull request: [firefoxos] CB-3208 Added suppor...

2014-03-10 Thread jsoref
Github user jsoref commented on a diff in the pull request: https://github.com/apache/cordova-mobile-spec/pull/44#discussion_r10442605 --- Diff: autotest/tests/contacts.tests.js --- @@ -363,39 +375,93 @@ describe("Contacts (navigator.contacts)"

[GitHub] cordova-mobile-spec pull request: [firefoxos] CB-3208 Added suppor...

2014-03-10 Thread jsoref
Github user jsoref commented on a diff in the pull request: https://github.com/apache/cordova-mobile-spec/pull/44#discussion_r10442686 --- Diff: contacts/index.html --- @@ -127,8 +39,8 @@ Action -Get phone's contacts --- End

[GitHub] cordova-app-hello-world pull request: CB-2528 Add window.onerror

2014-03-10 Thread jsoref
Github user jsoref commented on the pull request: https://github.com/apache/cordova-app-hello-world/pull/6#issuecomment-37227558 Developers should be encouraged to use WebInspector instead... --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] cordova-mobile-spec pull request: [firefoxos] CB-3208 Added suppor...

2014-03-10 Thread jsoref
Github user jsoref commented on a diff in the pull request: https://github.com/apache/cordova-mobile-spec/pull/44#discussion_r10448723 --- Diff: autotest/tests/contacts.tests.js --- @@ -363,39 +375,93 @@ describe("Contacts (navigator.contacts)"

[GitHub] cordova-mobile-spec pull request: [firefoxos] CB-3208 Added suppor...

2014-03-10 Thread jsoref
Github user jsoref commented on a diff in the pull request: https://github.com/apache/cordova-mobile-spec/pull/44#discussion_r10452942 --- Diff: autotest/tests/contacts.tests.js --- @@ -363,39 +375,93 @@ describe("Contacts (navigator.contacts)"

[GitHub] cordova-android pull request: CB-5316 Spell Cordova as a brand unl...

2014-03-11 Thread jsoref
Github user jsoref closed the pull request at: https://github.com/apache/cordova-android/pull/84 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-blackberry pull request: [CB-4531] bin/check_reqs scripts ...

2014-03-11 Thread jsoref
Github user jsoref commented on the pull request: https://github.com/apache/cordova-blackberry/pull/107#issuecomment-37331942 #135 resolved the remainder --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cordova-plugman pull request: PB-6160 adding plugin fails for Fire...

2014-03-11 Thread jsoref
Github user jsoref commented on the pull request: https://github.com/apache/cordova-plugman/pull/61#issuecomment-37332618 @Steckelfisch please note that the JIRA label should be "CB-6160" not "PB-6160" :( --- If your project is set up for it, you can reply to

[GitHub] cordova-blackberry pull request: [CB-4531] bin/check_reqs scripts ...

2014-03-11 Thread jsoref
Github user jsoref closed the pull request at: https://github.com/apache/cordova-blackberry/pull/107 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-firefoxos pull request: CB-5816 FirefoxOS - add build scri...

2014-03-11 Thread jsoref
Github user jsoref commented on a diff in the pull request: https://github.com/apache/cordova-firefoxos/pull/7#discussion_r10489420 --- Diff: bin/templates/project/cordova/build --- @@ -0,0 +1,28 @@ +#!/usr/bin/env node + +/* + Licensed to the Apache Software

[GitHub] cordova-firefoxos pull request: CB-5816 FirefoxOS - add build scri...

2014-03-11 Thread jsoref
Github user jsoref commented on the pull request: https://github.com/apache/cordova-firefoxos/pull/7#issuecomment-37353118 It depends what you're doing. https://wiki.apache.org/cordova/CommandLineToolingDesign#Errors is the contract. +console.log("Build is not i

[GitHub] cordova-blackberry pull request: CB-6241 Default to prompting for ...

2014-03-13 Thread jsoref
GitHub user jsoref opened a pull request: https://github.com/apache/cordova-blackberry/pull/150 CB-6241 Default to prompting for passwords (replace --query with --no-qu... ...ery) https://issues.apache.org/jira/browse/CB-6241 As a consequence, if you don't sp

[GitHub] cordova-firefoxos pull request: CB-5816 FirefoxOS - add build scri...

2014-03-14 Thread jsoref
Github user jsoref commented on the pull request: https://github.com/apache/cordova-firefoxos/pull/7#issuecomment-37646613 Normally there is --release Please don't invent things without checking for precedent. I still don't understand why this pull req

[GitHub] cordova-plugman pull request: CB-6272 Fix subdir handling

2014-03-14 Thread jsoref
GitHub user jsoref opened a pull request: https://github.com/apache/cordova-plugman/pull/65 CB-6272 Fix subdir handling https://issues.apache.org/jira/browse/CB-6272 You can merge this pull request into a Git repository by running: $ git pull https://github.com/jsoref/cordova

[GitHub] cordova-plugman pull request: CB-6272 Fix subdir handling

2014-03-17 Thread jsoref
Github user jsoref closed the pull request at: https://github.com/apache/cordova-plugman/pull/65 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-cli pull request: CB-6306 Error creating project when path...

2014-03-18 Thread jsoref
GitHub user jsoref opened a pull request: https://github.com/apache/cordova-cli/pull/143 CB-6306 Error creating project when path to project includes spaces https://issues.apache.org/jira/browse/CB-6306 You can merge this pull request into a Git repository by running: $ git

[GitHub] cordova-mobile-spec pull request: CB-6163 Document geolocation fie...

2014-03-19 Thread jsoref
GitHub user jsoref opened a pull request: https://github.com/apache/cordova-mobile-spec/pull/52 CB-6163 Document geolocation fields https://issues.apache.org/jira/browse/CB-6163 Documenting the fields makes it easier for people testing to verify that what they see is what

[GitHub] cordova-cli pull request: CB-6306 Error creating project when path...

2014-03-20 Thread jsoref
Github user jsoref commented on the pull request: https://github.com/apache/cordova-cli/pull/143#issuecomment-38213622 r? @agrieve --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] cordova-cli pull request: CB-6306 Error creating project when path...

2014-03-20 Thread jsoref
Github user jsoref commented on the pull request: https://github.com/apache/cordova-cli/pull/143#issuecomment-38213942 r? @jbondc --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cordova-cli pull request: CB-6322 Simplify platforms/platform code...

2014-03-20 Thread jsoref
GitHub user jsoref opened a pull request: https://github.com/apache/cordova-cli/pull/146 CB-6322 Simplify platforms/platform code for platform specifics https://issues.apache.org/jira/browse/CB-6322 You can merge this pull request into a Git repository by running: $ git pull

[GitHub] cordova-plugman pull request: CB-6272 Fix subdir bug + tests & met...

2014-03-20 Thread jsoref
Github user jsoref commented on a diff in the pull request: https://github.com/apache/cordova-plugman/pull/66#discussion_r10821082 --- Diff: spec/install.spec.js --- @@ -348,13 +349,58 @@ describe('install', function() { run

[GitHub] cordova-plugman pull request: CB-6272 Fix subdir bug + tests & met...

2014-03-20 Thread jsoref
Github user jsoref commented on a diff in the pull request: https://github.com/apache/cordova-plugman/pull/66#discussion_r10821094 --- Diff: spec/install.spec.js --- @@ -348,13 +349,58 @@ describe('install', function() { run

[GitHub] cordova-plugman pull request: CB-6272 Fix subdir bug + tests & met...

2014-03-20 Thread jsoref
Github user jsoref commented on a diff in the pull request: https://github.com/apache/cordova-plugman/pull/66#discussion_r10821101 --- Diff: spec/install.spec.js --- @@ -348,13 +349,58 @@ describe('install', function() { run

[GitHub] cordova-plugman pull request: CB-6272 Fix subdir bug + tests & met...

2014-03-20 Thread jsoref
Github user jsoref commented on a diff in the pull request: https://github.com/apache/cordova-plugman/pull/66#discussion_r10821128 --- Diff: spec/plugins/dependencies/meta/D/plugin.xml --- @@ -0,0 +1,61 @@ + + + +http://cordova.apache.org/ns/plugins/1.0

[GitHub] cordova-plugman pull request: CB-6272 Fix subdir bug + tests & met...

2014-03-20 Thread jsoref
Github user jsoref commented on a diff in the pull request: https://github.com/apache/cordova-plugman/pull/66#discussion_r10821122 --- Diff: spec/plugins/dependencies/meta/D/plugin.xml --- @@ -0,0 +1,61 @@ + + + +http://cordova.apache.org/ns/plugins/1.0

[GitHub] cordova-plugman pull request: CB-6272 Fix subdir bug + tests & met...

2014-03-20 Thread jsoref
Github user jsoref commented on a diff in the pull request: https://github.com/apache/cordova-plugman/pull/66#discussion_r10821143 --- Diff: spec/plugins/dependencies/meta/subdir/E/plugin.xml --- @@ -0,0 +1,57 @@ + + + +http://cordova.apache.org/ns/plugins/1.0

[GitHub] cordova-plugman pull request: CB-6272 Fix subdir bug + tests & met...

2014-03-20 Thread jsoref
Github user jsoref commented on a diff in the pull request: https://github.com/apache/cordova-plugman/pull/66#discussion_r10821152 --- Diff: src/install.js --- @@ -329,20 +329,20 @@ function installDependencies(install, dependencies, options) { function

[GitHub] cordova-plugman pull request: CB-6272 Fix subdir bug + tests & met...

2014-03-20 Thread jsoref
Github user jsoref commented on a diff in the pull request: https://github.com/apache/cordova-plugman/pull/66#discussion_r10821159 --- Diff: src/install.js --- @@ -399,6 +404,33 @@ function tryFetchDependency(dep, install) { } else if (fetchdata.source.type

[GitHub] cordova-plugman pull request: CB-6272 Fix subdir bug + tests & met...

2014-03-20 Thread jsoref
Github user jsoref commented on a diff in the pull request: https://github.com/apache/cordova-plugman/pull/66#discussion_r10821163 --- Diff: src/install.js --- @@ -399,6 +404,33 @@ function tryFetchDependency(dep, install) { } else if (fetchdata.source.type

[GitHub] cordova-plugman pull request: CB-6272 Fix subdir bug + tests & met...

2014-03-20 Thread jsoref
Github user jsoref commented on a diff in the pull request: https://github.com/apache/cordova-plugman/pull/66#discussion_r10821172 --- Diff: src/install.js --- @@ -413,7 +445,7 @@ function tryFetchDependency(dep, install) { // CB-4770: registry fetching if

[GitHub] cordova-plugman pull request: CB-6272 Fix subdir bug + tests & met...

2014-03-20 Thread jsoref
Github user jsoref commented on a diff in the pull request: https://github.com/apache/cordova-plugman/pull/66#discussion_r10821212 --- Diff: src/util/plugins.js --- @@ -25,18 +25,30 @@ var http = require('http'), shell = require('shelljs'), chi

[GitHub] cordova-cli pull request: CB-6337 Print nice error when cordova-cl...

2014-03-24 Thread jsoref
GitHub user jsoref opened a pull request: https://github.com/apache/cordova-cli/pull/148 CB-6337 Print nice error when cordova-cli hits various expected things You can merge this pull request into a Git repository by running: $ git pull https://github.com/jsoref/cordova-cli

[GitHub] cordova-cli pull request: CB-6338 Improve error for missing templa...

2014-03-24 Thread jsoref
GitHub user jsoref opened a pull request: https://github.com/apache/cordova-cli/pull/149 CB-6338 Improve error for missing template You can merge this pull request into a Git repository by running: $ git pull https://github.com/jsoref/cordova-cli cb_6338 Alternatively you

[GitHub] cordova-cli pull request: Add platform tizen

2014-03-26 Thread jsoref
Github user jsoref commented on a diff in the pull request: https://github.com/apache/cordova-cli/pull/125#discussion_r10983854 --- Diff: src/metadata/tizen_parser.js --- @@ -0,0 +1,131 @@ +var Q = require( "q" ), + shelljs = require( "shelljs" ),

[GitHub] cordova-cli pull request: Add platform tizen

2014-03-26 Thread jsoref
Github user jsoref commented on a diff in the pull request: https://github.com/apache/cordova-cli/pull/125#discussion_r10987117 --- Diff: package.json --- @@ -44,6 +44,7 @@ }, "devDependencies": { "jasmine-node": "1.13.x" +

[GitHub] cordova-cli pull request: Add platform tizen

2014-03-26 Thread jsoref
Github user jsoref commented on a diff in the pull request: https://github.com/apache/cordova-cli/pull/125#discussion_r10987445 --- Diff: spec/metadata/tizen_parser.spec.js --- @@ -0,0 +1,102 @@ +/** + Licensed to the Apache Software Foundation (ASF) under one + or more

[GitHub] cordova-cli pull request: Fix errors from CB-6337 CB-6338

2014-03-26 Thread jsoref
GitHub user jsoref opened a pull request: https://github.com/apache/cordova-cli/pull/150 Fix errors from CB-6337 CB-6338 I can't actually find our CI to confirm that it likes everything, but `npm test` only shows the errors that aren't mine. You can merge this pull requ

[GitHub] cordova-cli pull request: CB-5082 [CLI] BB10 add support in doPlat...

2014-03-26 Thread jsoref
Github user jsoref commented on a diff in the pull request: https://github.com/apache/cordova-cli/pull/152#discussion_r10993531 --- Diff: src/info-utils.js --- @@ -0,0 +1,132 @@ +/** + Licensed to the Apache Software Foundation (ASF) under one + or more contributor

[GitHub] cordova-cli pull request: CB-5082 [CLI] BB10 add support in doPlat...

2014-03-26 Thread jsoref
Github user jsoref commented on a diff in the pull request: https://github.com/apache/cordova-cli/pull/152#discussion_r10993586 --- Diff: src/info-utils.js --- @@ -0,0 +1,132 @@ +/** + Licensed to the Apache Software Foundation (ASF) under one + or more contributor

[GitHub] cordova-cli pull request: CB-5082 [CLI] BB10 add support in doPlat...

2014-03-26 Thread jsoref
Github user jsoref commented on a diff in the pull request: https://github.com/apache/cordova-cli/pull/152#discussion_r10993657 --- Diff: src/info-utils.js --- @@ -0,0 +1,132 @@ +/** + Licensed to the Apache Software Foundation (ASF) under one + or more contributor

[GitHub] cordova-cli pull request: CB-5082 [CLI] BB10 add support in doPlat...

2014-03-26 Thread jsoref
Github user jsoref commented on a diff in the pull request: https://github.com/apache/cordova-cli/pull/152#discussion_r10993672 --- Diff: src/info-utils.js --- @@ -0,0 +1,132 @@ +/** --- End diff -- No one likes tabs --- If your project is set up for it, you can

[GitHub] cordova-cli pull request: CB-5082 [CLI] BB10 add support in doPlat...

2014-03-26 Thread jsoref
Github user jsoref commented on a diff in the pull request: https://github.com/apache/cordova-cli/pull/152#discussion_r10993698 --- Diff: src/info-utils.js --- @@ -0,0 +1,132 @@ +/** + Licensed to the Apache Software Foundation (ASF) under one + or more contributor

[GitHub] cordova-cli pull request: CB-5082 [CLI] BB10 add support in doPlat...

2014-03-26 Thread jsoref
Github user jsoref commented on the pull request: https://github.com/apache/cordova-cli/pull/152#issuecomment-38730048 Right, I'm not saying you shouldn't set environment variables before calling children. It's about how you call them and for whom. You shouldn't b

[GitHub] cordova-cli pull request: CB-5082 [CLI] BB10 add support in doPlat...

2014-03-26 Thread jsoref
Github user jsoref commented on the pull request: https://github.com/apache/cordova-cli/pull/152#issuecomment-38747218 While cordova-cli is usually run as `bin/cordova`, it's possible to use cordova as a library, which means that your env changes last longer. --- If your proje

[GitHub] cordova-plugman pull request: Add platform support for tizen

2014-03-26 Thread jsoref
Github user jsoref commented on a diff in the pull request: https://github.com/apache/cordova-plugman/pull/67#discussion_r11002341 --- Diff: spec/plugins/DummyPlugin/plugin.xml --- @@ -161,6 +161,11 @@ + --- End diff

[GitHub] cordova-plugman pull request: Add platform support for tizen

2014-03-26 Thread jsoref
Github user jsoref commented on a diff in the pull request: https://github.com/apache/cordova-plugman/pull/67#discussion_r11002418 --- Diff: package.json --- @@ -34,6 +34,7 @@ "request": "2.22.0" }, "devDependencies": { +

[GitHub] cordova-plugman pull request: Add platform support for tizen

2014-03-26 Thread jsoref
Github user jsoref commented on a diff in the pull request: https://github.com/apache/cordova-plugman/pull/67#discussion_r11002375 --- Diff: README.md --- @@ -30,6 +30,7 @@ You must have `git` on your PATH to be able to install plugins directly from rem * BlackBerry 10

[GitHub] cordova-cli pull request: CB-6357 platform check - install each pl...

2014-03-26 Thread jsoref
GitHub user jsoref opened a pull request: https://github.com/apache/cordova-cli/pull/153 CB-6357 platform check - install each platform to determine working + version number The other changesets (Refactor, exports, silence output, sort output, fix indentation) are split because

[GitHub] cordova-cli pull request: CB-6357 platform check - install each pl...

2014-03-26 Thread jsoref
Github user jsoref commented on the pull request: https://github.com/apache/cordova-cli/pull/153#issuecomment-38762210 Sigh, and now i need to deal w/ `npm test` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cordova-blackberry pull request: CB-6346 - Add node_modules to sou...

2014-03-26 Thread jsoref
Github user jsoref commented on the pull request: https://github.com/apache/cordova-blackberry/pull/152#issuecomment-38762335 r+ --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cordova-cli pull request: Fix errors from CB-6337 CB-6338

2014-03-26 Thread jsoref
Github user jsoref commented on the pull request: https://github.com/apache/cordova-cli/pull/150#issuecomment-38767219 `npm test` is happy, would someone please merge this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] cordova-cli pull request: CB-6357 platform check - install each pl...

2014-03-26 Thread jsoref
Github user jsoref commented on the pull request: https://github.com/apache/cordova-cli/pull/153#issuecomment-38767269 ok, with #150 applied, this set of changes applies cleanly and doesn't introduce any new `npm test` failures. --- If your project is set up for it, you can rep

[GitHub] cordova-plugman pull request: Add platform support for tizen

2014-03-27 Thread jsoref
Github user jsoref commented on a diff in the pull request: https://github.com/apache/cordova-plugman/pull/67#discussion_r11038519 --- Diff: package.json --- @@ -34,6 +34,7 @@ "request": "2.22.0" }, "devDependencies": { +

[GitHub] cordova-cli pull request: CB-6322 Simplify platforms/platform code...

2014-03-28 Thread jsoref
Github user jsoref commented on a diff in the pull request: https://github.com/apache/cordova-cli/pull/146#discussion_r11085455 --- Diff: platforms.js --- @@ -39,12 +41,14 @@ module.exports = { version: '3.4.0' }, 'wp7' : {

[GitHub] cordova-plugin-camera pull request: Update index.md

2014-03-31 Thread jsoref
Github user jsoref commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/21#issuecomment-39114920 Square brackets in JavaScript mean "pass an array". While Square brackets in CMD make sense for optional, I wouldn't recommend that notation

[GitHub] cordova-cli pull request: CB-6377 Handle spaces in paths for cmd r...

2014-03-31 Thread jsoref
GitHub user jsoref opened a pull request: https://github.com/apache/cordova-cli/pull/155 CB-6377 Handle spaces in paths for cmd related scripts 0. as discussed elsewhere the slice() efforts on process.platform are pointless 1. for .bat, .cmd, and .js/.vbs, we want to use

[GitHub] cordova-cli pull request: CB-6382 platform list: sort output

2014-03-31 Thread jsoref
GitHub user jsoref opened a pull request: https://github.com/apache/cordova-cli/pull/156 CB-6382 platform list: sort output You can merge this pull request into a Git repository by running: $ git pull https://github.com/jsoref/cordova-cli cb_6382 Alternatively you can review

[GitHub] cordova-blackberry pull request: CB-6398 Support additional comman...

2014-04-03 Thread jsoref
GitHub user jsoref opened a pull request: https://github.com/apache/cordova-blackberry/pull/153 CB-6398 Support additional commands in blackberry10.json Enables proxy blackberry10.json: ```json { "blackberry-signer": { "-proxyho

[GitHub] cordova-blackberry pull request: [BlackBerry10] Improvements to de...

2014-04-07 Thread jsoref
Github user jsoref commented on a diff in the pull request: https://github.com/apache/cordova-blackberry/pull/154#discussion_r11348541 --- Diff: blackberry10/bin/templates/project/cordova/lib/target-utils.js --- @@ -254,16 +254,15 @@ _self

[GitHub] cordova-blackberry pull request: [BlackBerry10] Improvements to de...

2014-04-07 Thread jsoref
Github user jsoref commented on the pull request: https://github.com/apache/cordova-blackberry/pull/154#issuecomment-39743948 r+ otherwise --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] cordova-cli pull request: CB-6377 superspawn: always wrap non .exe...

2014-04-10 Thread jsoref
GitHub user jsoref opened a pull request: https://github.com/apache/cordova-cli/pull/161 CB-6377 superspawn: always wrap non .exe calls to cmd with /s /c You can merge this pull request into a Git repository by running: $ git pull https://github.com/blackberry/cordova-cli

[GitHub] cordova-cli pull request: CB-6415 Make project/.cordova/config.jso...

2014-04-10 Thread jsoref
GitHub user jsoref opened a pull request: https://github.com/apache/cordova-cli/pull/162 CB-6415 Make project/.cordova/config.json integrate with platforms.js You can merge this pull request into a Git repository by running: $ git pull https://github.com/blackberry/cordova

[GitHub] cordova-cli pull request: CB-6377 superspawn: always wrap non .exe...

2014-04-10 Thread jsoref
Github user jsoref commented on a diff in the pull request: https://github.com/apache/cordova-cli/pull/161#discussion_r11502427 --- Diff: src/superspawn.js --- @@ -67,11 +69,11 @@ exports.spawn = function(cmd, args, opts) { var spawnOpts = {}; var d = Q.defer

[GitHub] cordova-cli pull request: CB-6377 superspawn: always wrap non .exe...

2014-04-10 Thread jsoref
Github user jsoref commented on the pull request: https://github.com/apache/cordova-cli/pull/161#issuecomment-40128762 I want QA to confirm this works before it merges... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] cordova-cli pull request: CB-6377 superspawn: always wrap non .exe...

2014-04-11 Thread jsoref
Github user jsoref commented on a diff in the pull request: https://github.com/apache/cordova-cli/pull/161#discussion_r11531129 --- Diff: src/superspawn.js --- @@ -24,6 +24,8 @@ var _ = require('underscore'); var Q = require('q'); var shell = require(

[GitHub] cordova-cli pull request: CB-6377 superspawn: always wrap non .exe...

2014-04-11 Thread jsoref
Github user jsoref commented on a diff in the pull request: https://github.com/apache/cordova-cli/pull/161#discussion_r11539545 --- Diff: src/superspawn.js --- @@ -24,6 +24,8 @@ var _ = require('underscore'); var Q = require('q'); var shell = require(

[GitHub] cordova-plugin-file pull request: Update index.md

2014-04-25 Thread jsoref
Github user jsoref commented on a diff in the pull request: https://github.com/apache/cordova-plugin-file/pull/41#discussion_r12001137 --- Diff: doc/index.md --- @@ -24,6 +24,20 @@ to HTML5 Rocks' [FileSystem article](http://www.html5rocks.com/en/tutorials/file on the su

[GitHub] cordova-plugin-file pull request: Update index.md

2014-04-25 Thread jsoref
Github user jsoref commented on a diff in the pull request: https://github.com/apache/cordova-plugin-file/pull/41#discussion_r12001097 --- Diff: doc/index.md --- @@ -24,6 +24,20 @@ to HTML5 Rocks' [FileSystem article](http://www.html5rocks.com/en/tutorials/file on the su

[GitHub] cordova-firefoxos pull request: CB-5816 FirefoxOS - add build scri...

2014-04-25 Thread jsoref
Github user jsoref commented on a diff in the pull request: https://github.com/apache/cordova-firefoxos/pull/7#discussion_r12001272 --- Diff: bin/lib/create.js --- @@ -26,6 +26,7 @@ var fs = require('fs'), ROOT= path.join(__dirname, '..', '

[GitHub] cordova-firefoxos pull request: CB-5816 FirefoxOS - add build scri...

2014-04-25 Thread jsoref
Github user jsoref commented on a diff in the pull request: https://github.com/apache/cordova-firefoxos/pull/7#discussion_r12001296 --- Diff: bin/lib/create.js --- @@ -53,14 +54,24 @@ exports.createProject = function(project_path,package_name,project_name){ //copy

[GitHub] cordova-firefoxos pull request: CB-5816 FirefoxOS - add build scri...

2014-04-25 Thread jsoref
Github user jsoref commented on a diff in the pull request: https://github.com/apache/cordova-firefoxos/pull/7#discussion_r12001306 --- Diff: bin/lib/create.js --- @@ -53,14 +54,24 @@ exports.createProject = function(project_path,package_name,project_name){ //copy

[GitHub] cordova-firefoxos pull request: CB-5816 FirefoxOS - add build scri...

2014-04-25 Thread jsoref
Github user jsoref commented on a diff in the pull request: https://github.com/apache/cordova-firefoxos/pull/7#discussion_r12001446 --- Diff: bin/templates/project/cordova/clean --- @@ -0,0 +1,38 @@ +#!/usr/bin/env node + +/* + Licensed to the Apache Software

[GitHub] cordova-firefoxos pull request: CB-5816 FirefoxOS - add build scri...

2014-04-25 Thread jsoref
Github user jsoref commented on a diff in the pull request: https://github.com/apache/cordova-firefoxos/pull/7#discussion_r12001459 --- Diff: bin/templates/project/cordova/clean --- @@ -0,0 +1,38 @@ +#!/usr/bin/env node + +/* + Licensed to the Apache Software

[GitHub] cordova-firefoxos pull request: CB-5816 FirefoxOS - add build scri...

2014-04-25 Thread jsoref
Github user jsoref commented on a diff in the pull request: https://github.com/apache/cordova-firefoxos/pull/7#discussion_r12001480 --- Diff: bin/templates/project/cordova/lib/build.js --- @@ -0,0 +1,167 @@ +#!/usr/bin/env node + +/* + * Licensed to the Apache

[GitHub] cordova-firefoxos pull request: CB-5816 FirefoxOS - add build scri...

2014-04-25 Thread jsoref
Github user jsoref commented on a diff in the pull request: https://github.com/apache/cordova-firefoxos/pull/7#discussion_r12001463 --- Diff: bin/templates/project/cordova/lib/build.js --- @@ -0,0 +1,167 @@ +#!/usr/bin/env node + +/* + * Licensed to the Apache

[GitHub] cordova-firefoxos pull request: CB-5816 FirefoxOS - add build scri...

2014-04-25 Thread jsoref
Github user jsoref commented on a diff in the pull request: https://github.com/apache/cordova-firefoxos/pull/7#discussion_r12001511 --- Diff: bin/templates/project/cordova/lib/build.js --- @@ -0,0 +1,167 @@ +#!/usr/bin/env node + +/* + * Licensed to the Apache

[GitHub] cordova-blackberry pull request: CB-6522 Disallow space in target ...

2014-04-25 Thread jsoref
Github user jsoref commented on the pull request: https://github.com/apache/cordova-blackberry/pull/155#issuecomment-41410913 You need to use `/ /g` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] cordova-firefoxos pull request: CB-5816 FirefoxOS - add build scri...

2014-04-28 Thread jsoref
Github user jsoref commented on a diff in the pull request: https://github.com/apache/cordova-firefoxos/pull/7#discussion_r12049234 --- Diff: bin/lib/create.js --- @@ -26,6 +26,7 @@ var fs = require('fs'), ROOT= path.join(__dirname, '..', '

[GitHub] cordova-blackberry pull request: Improve README

2014-04-28 Thread jsoref
GitHub user jsoref opened a pull request: https://github.com/apache/cordova-blackberry/pull/156 Improve README You can merge this pull request into a Git repository by running: $ git pull https://github.com/jsoref/cordova-blackberry readme Alternatively you can review and

[GitHub] cordova-cli pull request: CB-6537 Consistently indicate `cordova ....

2014-04-28 Thread jsoref
GitHub user jsoref opened a pull request: https://github.com/apache/cordova-cli/pull/172 CB-6537 Consistently indicate `cordova ...` in errors You can merge this pull request into a Git repository by running: $ git pull https://github.com/jsoref/cordova-cli cb_6537

[GitHub] cordova-cli pull request: CB-6540 Error for creating a project ins...

2014-04-28 Thread jsoref
GitHub user jsoref opened a pull request: https://github.com/apache/cordova-cli/pull/173 CB-6540 Error for creating a project inside its template is confusing You can merge this pull request into a Git repository by running: $ git pull https://github.com/blackberry/cordova

[GitHub] cordova-cli pull request: CB-6542 Delay creating project until the...

2014-04-28 Thread jsoref
GitHub user jsoref opened a pull request: https://github.com/apache/cordova-cli/pull/174 CB-6542 Delay creating project until there's some chance that it will work You can merge this pull request into a Git repository by running: $ git pull https://github.com/black

[GitHub] cordova-plugin-file pull request: updated support for the OS X pla...

2014-04-30 Thread jsoref
Github user jsoref commented on a diff in the pull request: https://github.com/apache/cordova-plugin-file/pull/42#discussion_r12157876 --- Diff: plugin.xml --- @@ -203,6 +203,27 @@ xmlns:android="http://schemas.android.com/apk/res/an

[GitHub] cordova-plugin-file pull request: updated support for the OS X pla...

2014-04-30 Thread jsoref
Github user jsoref commented on a diff in the pull request: https://github.com/apache/cordova-plugin-file/pull/42#discussion_r12157924 --- Diff: doc/index.md --- @@ -69,6 +70,10 @@ Android also supports a special filesystem named "documents", which represents a

[GitHub] cordova-labs pull request: Cordova client

2014-05-12 Thread jsoref
GitHub user jsoref opened a pull request: https://github.com/apache/cordova-labs/pull/6 Cordova client You can merge this pull request into a Git repository by running: $ git pull https://github.com/jsoref/cordova-labs cordova-client Alternatively you can review and apply

[GitHub] cordova-labs pull request: Jira

2014-05-12 Thread jsoref
GitHub user jsoref opened a pull request: https://github.com/apache/cordova-labs/pull/4 Jira You can merge this pull request into a Git repository by running: $ git pull https://github.com/jsoref/cordova-labs jira Alternatively you can review and apply these changes as the

[GitHub] cordova-labs pull request: Cordova firefoxos

2014-05-12 Thread jsoref
GitHub user jsoref opened a pull request: https://github.com/apache/cordova-labs/pull/5 Cordova firefoxos You can merge this pull request into a Git repository by running: $ git pull https://github.com/jsoref/cordova-labs cordova-firefoxos Alternatively you can review and

incubator-cordova-bada pull request: Spelling fixes

2012-11-19 Thread jsoref
GitHub user jsoref opened a pull request: https://github.com/apache/incubator-cordova-bada/pull/1 Spelling fixes The first commit is actually a code fix... You can merge this pull request into a Git repository by running: $ git pull https://github.com/jsoref/incubator-cordova

[GitHub] cordova-docs pull request: CB-6680 Clarify instructions for instal...

2014-05-21 Thread jsoref
Github user jsoref commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/205#discussion_r12906514 --- Diff: docs/en/edge/guide/cli/index.md --- @@ -64,8 +64,9 @@ whose assets you pull down to local working directories. To install the `cordova

[GitHub] cordova-docs pull request: CB-6680 Clarify instructions for instal...

2014-05-21 Thread jsoref
Github user jsoref commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/205#discussion_r12906580 --- Diff: docs/en/edge/guide/cli/index.md --- @@ -73,22 +74,41 @@ To install the `cordova` command-line tool, follow these steps: the CLI does

[GitHub] cordova-docs pull request: CB-6680 Clarify instructions for instal...

2014-05-21 Thread jsoref
Github user jsoref commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/205#discussion_r12906648 --- Diff: docs/en/edge/guide/cli/index.md --- @@ -73,22 +74,41 @@ To install the `cordova` command-line tool, follow these steps: the CLI does

[GitHub] cordova-docs pull request: CB-6680 Clarify instructions for instal...

2014-05-21 Thread jsoref
Github user jsoref commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/205#discussion_r12906677 --- Diff: docs/en/edge/guide/cli/index.md --- @@ -73,22 +74,41 @@ To install the `cordova` command-line tool, follow these steps: the CLI does

[GitHub] cordova-docs pull request: CB-6680 Clarify instructions for instal...

2014-05-21 Thread jsoref
Github user jsoref commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/205#discussion_r12906738 --- Diff: docs/en/edge/guide/cli/index.md --- @@ -73,22 +74,41 @@ To install the `cordova` command-line tool, follow these steps: the CLI does

[GitHub] cordova-docs pull request: CB-6680 Clarify instructions for instal...

2014-05-21 Thread jsoref
Github user jsoref commented on the pull request: https://github.com/apache/cordova-docs/pull/205#issuecomment-43782968 I like this (I don't usually spend time commenting on things I don't like...) --- If your project is set up for it, you can reply to this email and have

[GitHub] cordova-docs pull request: CB-6680 Clarify instructions for instal...

2014-05-21 Thread jsoref
Github user jsoref commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/205#discussion_r12906784 --- Diff: docs/en/edge/guide/cli/index.md --- @@ -73,22 +74,41 @@ To install the `cordova` command-line tool, follow these steps: the CLI does

[GitHub] cordova-blackberry pull request: CB-6757 Provide useful hint when ...

2014-05-26 Thread jsoref
GitHub user jsoref opened a pull request: https://github.com/apache/cordova-blackberry/pull/158 CB-6757 Provide useful hint when simulator does not seem to know its IP You can merge this pull request into a Git repository by running: $ git pull https://github.com/blackberry

[GitHub] cordova-cli pull request: CB-6767 Allow `cordova` to be replacable

2014-05-27 Thread jsoref
GitHub user jsoref opened a pull request: https://github.com/apache/cordova-cli/pull/179 CB-6767 Allow `cordova` to be replacable You can merge this pull request into a Git repository by running: $ git pull https://github.com/jsoref/cordova-cli cb_6767 Alternatively you can

[GitHub] cordova-lib pull request: CB-6767 Allow `cordova` to be replaceabl...

2014-05-29 Thread jsoref
Github user jsoref commented on the pull request: https://github.com/apache/cordova-lib/pull/20#issuecomment-44566880 I don't really want to do that right now. One reason I want to do it this way instead of that way is that various pieces of code will do require(), and I

  1   2   3   4   5   >