Github user jsoref commented on a diff in the pull request:

    https://github.com/apache/cordova-cli/pull/125#discussion_r10983854
  
    --- Diff: src/metadata/tizen_parser.js ---
    @@ -0,0 +1,131 @@
    +var Q = require( "q" ),
    +   shelljs = require( "shelljs" ),
    +   util = require( "../util" ),
    +   elementTree = require( "elementtree" ),
    +   exec = require( "child_process" ).exec,
    +   path = require( "path" );
    +
    +function genPackageId() {
    +   var idx,
    +           returnValue = "";
    +           characters = [
    +                   "0", "1", "2", "3", "4", "5", "6", "7", "8", "9",
    +                   "a", "b", "c", "d", "e", "f", "g", "h", "i", "j",
    +                   "k", "l", "m", "n", "o", "p", "q", "r", "s", "t",
    +                   "u", "v", "w", "x", "y", "z" ];
    +
    +   for ( idx = 0 ; idx < 10 ; idx++ ) {
    +           returnValue += ( characters[ Math.round( Math.random() * 35 ) ] 
);
    +   }
    +
    +   return returnValue;
    +}
    +
    +module.exports = function tizen_parser( project ) {
    +   this.path = project;
    +}
    +
    +// Returns a promise
    +module.exports.check_requirements = function( project_root ) {
    +   var deferred = Q.defer();
    +
    +   exec( "web-build", {}, function( error, stdout, stderr ) {
    +           if ( error ) {
    +                   deferred.reject( new Error( "Requirements check failed. 
Command 'web-build' not found." ) );
    --- End diff --
    
    Please see CB-6337 and use CordovaError instead of Error (don't forget to 
add the require for it)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to